[GitHub] incubator-distributedlog issue #2: Add NOTICE file.

2016-07-26 Thread fpj
Github user fpj commented on the issue: https://github.com/apache/incubator-distributedlog/pull/2 @franckcuny you may have seen this already, but just in case you may want to have a look at the instructions here: http://www.apache.org/dev/licensing-howto.html --- If your

[GitHub] incubator-distributedlog issue #2: DL-4: Add NOTICE file.

2016-07-27 Thread fpj
Github user fpj commented on the issue: https://github.com/apache/incubator-distributedlog/pull/2 @franckcuny @sijie It looks good, but I haven't done an inspection of dependencies and such to determine whether we have anything we need to add to the notice file. That's m

[GitHub] incubator-distributedlog issue #121: DL-191: Fix license header issues

2017-02-01 Thread fpj
Github user fpj commented on the issue: https://github.com/apache/incubator-distributedlog/pull/121 I haven't checked whether this pull request covers all files, but otherwise it looks good, +1. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-distributedlog pull request #121: DL-191: Fix license header issue...

2017-02-01 Thread fpj
Github user fpj commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/121#discussion_r99005521 --- Diff: distributedlog-core/conf/zookeeper.conf.dynamic.template --- @@ -1 +1 @@ -#/**# * Copyright 2007 The Apache Software Foundation

[GitHub] incubator-distributedlog issue #119: DL-192: year needs updating in NOTICE

2017-02-01 Thread fpj
Github user fpj commented on the issue: https://github.com/apache/incubator-distributedlog/pull/119 If you find a way to automate, then great, but otherwise, just add a bullet to the release management page to remind the release manager to update if necessary. --- If your project

[GitHub] incubator-distributedlog pull request #120: DL-190: Add DISCLAIMER to the re...

2017-02-01 Thread fpj
Github user fpj commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/120#discussion_r99009920 --- Diff: src/main/resources/DISCLAIMER.bin.txt --- @@ -0,0 +1 @@ +Apache DistributedLog is an effort undergoing incubation at The Apache

[GitHub] incubator-distributedlog pull request #121: DL-191: Fix license header issue...

2017-02-03 Thread fpj
Github user fpj commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/121#discussion_r99298234 --- Diff: distributedlog-core/conf/zookeeper.conf.dynamic.template --- @@ -1 +1 @@ -#/**# * Copyright 2007 The Apache Software Foundation