[GitHub] [incubator-dlab] ppapou closed pull request #911: [Dlab-1922] Scheduler debug for comp cluster
ppapou closed pull request #911: URL: https://github.com/apache/incubator-dlab/pull/911 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] ppapou opened a new pull request #926: [DLAB-1650] Creating ODAHU cluster in same project
ppapou opened a new pull request #926: URL: https://github.com/apache/incubator-dlab/pull/926 it's possible to add ODAHU cluster, if there are no Stopped or Active Instances This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov merged pull request #925: [DLAB-1911]: fixed usage of predefined firewall ip ranges for gcp
leonidfrolov merged pull request #925: URL: https://github.com/apache/incubator-dlab/pull/925 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov opened a new pull request #925: [DLAB-1911]: fixed usage of predefined firewall ip ranges for gcp
leonidfrolov opened a new pull request #925: URL: https://github.com/apache/incubator-dlab/pull/925 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #924: [DLAB-2039]: Added endpoint for instances on 'Environment management'
DG1202 merged pull request #924: URL: https://github.com/apache/incubator-dlab/pull/924 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 opened a new pull request #924: [DLAB-2039]: Added endpoint for instances on 'Environment management'
DG1202 opened a new pull request #924: URL: https://github.com/apache/incubator-dlab/pull/924 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #923: [DLAB-1778]: Added localization
DG1202 merged pull request #923: URL: https://github.com/apache/incubator-dlab/pull/923 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 opened a new pull request #923: [DLAB-1778]: Added localization
DG1202 opened a new pull request #923: URL: https://github.com/apache/incubator-dlab/pull/923 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #921: [DLAB-1101]: Fixed 'Default timezone_offset' is rewritten if switching scheduler types for notebook
DG1202 merged pull request #921: URL: https://github.com/apache/incubator-dlab/pull/921 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov merged pull request #922: [DLAB-1911]: added network tags to instances on gcp
leonidfrolov merged pull request #922: URL: https://github.com/apache/incubator-dlab/pull/922 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov merged pull request #922: [DLAB-1911]: added network tags to instances on gcp
leonidfrolov merged pull request #922: URL: https://github.com/apache/incubator-dlab/pull/922 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov opened a new pull request #922: [DLAB-1911]: added network tags to instances on gcp
leonidfrolov opened a new pull request #922: URL: https://github.com/apache/incubator-dlab/pull/922 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #921: [DLAB-1101]: Fixed 'Default timezone_offset' is rewritten if switching scheduler types for notebook
DG1202 merged pull request #921: URL: https://github.com/apache/incubator-dlab/pull/921 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov merged pull request #920: [DLAB-1911]: Support access to all existing and following environments only via VPN
leonidfrolov merged pull request #920: URL: https://github.com/apache/incubator-dlab/pull/920 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov opened a new pull request #920: [DLAB-1911]: Support access to all existing and following environments only via VPN
leonidfrolov opened a new pull request #920: URL: https://github.com/apache/incubator-dlab/pull/920 fixed some bugs during env termination with predefined vpc, subnet, etc. for gcp and azure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] ofuks merged pull request #917: [DLAB-1922] Fixed bug with reminder about notebook stopping
ofuks merged pull request #917: URL: https://github.com/apache/incubator-dlab/pull/917 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 opened a new pull request #919: [DLAB-2044]: Style fix in compute popup
DG1202 opened a new pull request #919: URL: https://github.com/apache/incubator-dlab/pull/919 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #919: [DLAB-2044]: Style fix in compute popup
DG1202 merged pull request #919: URL: https://github.com/apache/incubator-dlab/pull/919 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #918: [DLAB-2043]: Changed message for scheduler reminder
DG1202 merged pull request #918: URL: https://github.com/apache/incubator-dlab/pull/918 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 opened a new pull request #918: [DLAB-2043]: Changed message for scheduler reminder
DG1202 opened a new pull request #918: URL: https://github.com/apache/incubator-dlab/pull/918 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] ofuks opened a new pull request #917: [DLAB-1922] Fixed bug with reminder about notebook stopping
ofuks opened a new pull request #917: URL: https://github.com/apache/incubator-dlab/pull/917 [DLAB-1922] Fixed bug with a reminder about notebook stopping continues to show up after scheduler triggering This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #916: [DLAB-2055]: Fixed errors on library popup
DG1202 merged pull request #916: URL: https://github.com/apache/incubator-dlab/pull/916 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 opened a new pull request #916: [DLAB-2055]: Fixed errors on library popup
DG1202 opened a new pull request #916: URL: https://github.com/apache/incubator-dlab/pull/916 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #915: [DLAB-2047]: Made fixed size for library management popup
DG1202 merged pull request #915: URL: https://github.com/apache/incubator-dlab/pull/915 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 opened a new pull request #915: [DLAB-2047]: Made fixed size for library management popup
DG1202 opened a new pull request #915: URL: https://github.com/apache/incubator-dlab/pull/915 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov opened a new pull request #913: [DLAB-2052]: Downgrade RStudio to the previous version
leonidfrolov opened a new pull request #913: URL: https://github.com/apache/incubator-dlab/pull/913 fixed link and rstudio service path This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #912: [DLAB-2048]: Fixed billing details on list of resources
DG1202 merged pull request #912: URL: https://github.com/apache/incubator-dlab/pull/912 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov merged pull request #913: [DLAB-2052]: Downgrade RStudio to the previous version
leonidfrolov merged pull request #913: URL: https://github.com/apache/incubator-dlab/pull/913 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov merged pull request #914: [DLAB-2052]: Downgrade RStudio to the previous version
leonidfrolov merged pull request #914: URL: https://github.com/apache/incubator-dlab/pull/914 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov opened a new pull request #914: [DLAB-2052]: Downgrade RStudio to the previous version
leonidfrolov opened a new pull request #914: URL: https://github.com/apache/incubator-dlab/pull/914 fixed link and rstudio service path This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 opened a new pull request #912: [DLAB-2050]: Fixed billing details on list of resources
DG1202 opened a new pull request #912: URL: https://github.com/apache/incubator-dlab/pull/912 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] ppapou opened a new pull request #911: [Dlab-1922] Scheduler debug for comp cluster
ppapou opened a new pull request #911: URL: https://github.com/apache/incubator-dlab/pull/911 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 opened a new pull request #910: [DLAB-2049]: Fixed clicking the same sort icon should not change value position in grid
DG1202 opened a new pull request #910: URL: https://github.com/apache/incubator-dlab/pull/910 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #910: [DLAB-2049]: Fixed clicking the same sort icon should not change value position in grid
DG1202 merged pull request #910: URL: https://github.com/apache/incubator-dlab/pull/910 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #909: [DLAB-2050]: Fixed space between compute status and icon should not change if expand head grid
DG1202 merged pull request #909: URL: https://github.com/apache/incubator-dlab/pull/909 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 opened a new pull request #909: [DLAB-2050]: Fixed space between compute status and icon should not change if expand head grid
DG1202 opened a new pull request #909: URL: https://github.com/apache/incubator-dlab/pull/909 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov opened a new pull request #908: [DLAB-2052]: Downgraded RStudio to the previous version
leonidfrolov opened a new pull request #908: URL: https://github.com/apache/incubator-dlab/pull/908 Downgraded RStudio to the previous version This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov merged pull request #908: [DLAB-2052]: Downgraded RStudio to the previous version
leonidfrolov merged pull request #908: URL: https://github.com/apache/incubator-dlab/pull/908 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov merged pull request #907: [DLAB-2052]: Downgraded RStudio to the previous version
leonidfrolov merged pull request #907: URL: https://github.com/apache/incubator-dlab/pull/907 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov opened a new pull request #907: [DLAB-2052]: Downgraded RStudio to the previous version
leonidfrolov opened a new pull request #907: URL: https://github.com/apache/incubator-dlab/pull/907 Downgraded RStudio to the previous version This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] ofuks edited a comment on pull request #846: DLAB-845: Fixed the broken link for opening new issue in the CONTRIBUTING.md
ofuks edited a comment on pull request #846: URL: https://github.com/apache/incubator-dlab/pull/846#issuecomment-692555099 We will merge this PR as soon as we make the 2.4 release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] ofuks commented on pull request #846: DLAB-845: Fixed the broken link for opening new issue in the CONTRIBUTING.md
ofuks commented on pull request #846: URL: https://github.com/apache/incubator-dlab/pull/846#issuecomment-692555099 We will merge this PR as soon as we make a 2.4 release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov merged pull request #906: [DLAB-2025]: changed Rstudio version in description json
leonidfrolov merged pull request #906: URL: https://github.com/apache/incubator-dlab/pull/906 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov opened a new pull request #906: [DLAB-2025]: changed Rstudio version in description json
leonidfrolov opened a new pull request #906: URL: https://github.com/apache/incubator-dlab/pull/906 changed Rstudio version in description json This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #905: [DLAB-2045]: Removed unnecessary console.logs
DG1202 merged pull request #905: URL: https://github.com/apache/incubator-dlab/pull/905 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 opened a new pull request #905: [DLAB-2045]: Removed unnecessary console.logs
DG1202 opened a new pull request #905: URL: https://github.com/apache/incubator-dlab/pull/905 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov merged pull request #904: [DLAB-2025] - Livy connection for RStudio availbale, RStudio version updated
leonidfrolov merged pull request #904: URL: https://github.com/apache/incubator-dlab/pull/904 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] bodnarmykola opened a new pull request #904: [DLAB-2025] - Livy connection for RStudio availbale, RStudio version updated
bodnarmykola opened a new pull request #904: URL: https://github.com/apache/incubator-dlab/pull/904 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 opened a new pull request #903: [DLAB-2045]: Fixed issue with filtering by name on all filters
DG1202 opened a new pull request #903: URL: https://github.com/apache/incubator-dlab/pull/903 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #903: [DLAB-2045]: Fixed issue with filtering by name on all filters
DG1202 merged pull request #903: URL: https://github.com/apache/incubator-dlab/pull/903 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #902: [DLAB-2030]: Added hint/message for different cases
DG1202 merged pull request #902: URL: https://github.com/apache/incubator-dlab/pull/902 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 opened a new pull request #902: [DLAB-2030]: Added hint/message for different cases
DG1202 opened a new pull request #902: URL: https://github.com/apache/incubator-dlab/pull/902 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] bodnarmykola merged pull request #901: [DLAB-1833]: [Branch-515][Azure]: Deep Learning/Zeppelin/Tensorflow with Jupyter creations fail on stage of disk mount
bodnarmykola merged pull request #901: URL: https://github.com/apache/incubator-dlab/pull/901 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] bodnarmykola merged pull request #900: [DLAB-1527]: Rarely notebook is not created successful from the first attempt or ssn
bodnarmykola merged pull request #900: URL: https://github.com/apache/incubator-dlab/pull/900 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov opened a new pull request #901: [DLAB-1833]: [Branch-515][Azure]: Deep Learning/Zeppelin/Tensorflow with Jupyter creations fail on stage of disk mount
leonidfrolov opened a new pull request #901: URL: https://github.com/apache/incubator-dlab/pull/901 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov opened a new pull request #900: [DLAB-1527]: Rarely notebook is not created successful from the first attempt or ssn
leonidfrolov opened a new pull request #900: URL: https://github.com/apache/incubator-dlab/pull/900 change manage_pkg function to fix dpkg frontend locker error This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #898: [DLAB-2035]: Fixed issues with adding library without autocomplete
DG1202 merged pull request #898: URL: https://github.com/apache/incubator-dlab/pull/898 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #899: [DLAB-2033]: Prevented possibility to edit project for admin per project
DG1202 merged pull request #899: URL: https://github.com/apache/incubator-dlab/pull/899 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #898: [DLAB-2035]: Fixed issues with adding library without autocomplete
DG1202 merged pull request #898: URL: https://github.com/apache/incubator-dlab/pull/898 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #899: [DLAB-2033]: Prevented possibility to edit project for admin per project
DG1202 merged pull request #899: URL: https://github.com/apache/incubator-dlab/pull/899 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #898: [DLAB-2035]: Fixed issues with adding library without autocomplete
DG1202 merged pull request #898: URL: https://github.com/apache/incubator-dlab/pull/898 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #899: [DLAB-2033]: Prevented possibility to edit project for admin per project
DG1202 merged pull request #899: URL: https://github.com/apache/incubator-dlab/pull/899 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 opened a new pull request #899: [DLAB-2033]: Prevented possibility to edit project for admin per project
DG1202 opened a new pull request #899: URL: https://github.com/apache/incubator-dlab/pull/899 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #898: [DLAB-2035]: Fixed issues with adding library without autocomplete
DG1202 merged pull request #898: URL: https://github.com/apache/incubator-dlab/pull/898 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 opened a new pull request #898: [DLAB-2035]: Fixed issues with adding library without autocomplete
DG1202 opened a new pull request #898: URL: https://github.com/apache/incubator-dlab/pull/898 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov opened a new pull request #897: [DLAB-2037]: [Jupyter][Jupyter with TensorFlow][DeepLearning]: Notebook creation fails on stage of 'pyrsistent' download
leonidfrolov opened a new pull request #897: URL: https://github.com/apache/incubator-dlab/pull/897 specified pyrsistent version This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov merged pull request #897: [DLAB-2037]: [Jupyter][Jupyter with TensorFlow][DeepLearning]: Notebook creation fails on stage of 'pyrsistent' download
leonidfrolov merged pull request #897: URL: https://github.com/apache/incubator-dlab/pull/897 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #896: [DLAB-2026]: Made behavior of filter actions the same on all pages. Fixed minor bugs on library and bucket browser
DG1202 merged pull request #896: URL: https://github.com/apache/incubator-dlab/pull/896 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 opened a new pull request #896: [DLAB-2026]: Made behavior of filter actions the same on all pages. Fixed minor bugs on library and bucket browser
DG1202 opened a new pull request #896: URL: https://github.com/apache/incubator-dlab/pull/896 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov opened a new pull request #895: [DLAB-2034]: Project creation fails for external endpoint on GCP
leonidfrolov opened a new pull request #895: URL: https://github.com/apache/incubator-dlab/pull/895 added compute.routes.create, compute.routes.delete, compute.routes.get permissions for gcp external endpiont`s service account This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov merged pull request #895: [DLAB-2034]: Project creation fails for external endpoint on GCP
leonidfrolov merged pull request #895: URL: https://github.com/apache/incubator-dlab/pull/895 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] ofuks merged pull request #894: Unit test fix
ofuks merged pull request #894: URL: https://github.com/apache/incubator-dlab/pull/894 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] ppapou opened a new pull request #894: Unit test fix
ppapou opened a new pull request #894: URL: https://github.com/apache/incubator-dlab/pull/894 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] ofuks merged pull request #893: [DLAB ]Project resource UT
ofuks merged pull request #893: URL: https://github.com/apache/incubator-dlab/pull/893 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] ppapou commented on a change in pull request #893: [DLAB ]Project resource UT
ppapou commented on a change in pull request #893:
URL: https://github.com/apache/incubator-dlab/pull/893#discussion_r484427139
##
File path:
services/self-service/src/test/java/com/epam/dlab/backendapi/resources/ProjectResourceTest.java
##
@@ -181,4 +278,16 @@ private ProjectDTO returnProjectDTO(CreateProjectDTO
createProjectDTO) {
private ProjectActionFormDTO getProjectActionDTO() {
return new ProjectActionFormDTO(PROJECT_NAME,
Collections.singletonList("https://localhost:8083/;));
}
+
+private UpdateProjectDTO prepareUpdateProjectDTO() {
+return new UpdateProjectDTO(PROJECT_NAME, Collections.emptySet(),
Collections.emptySet(), true);
Review comment:
Boolean object is added
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org
For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] ppapou commented on a change in pull request #893: [DLAB ]Project resource UT
ppapou commented on a change in pull request #893:
URL: https://github.com/apache/incubator-dlab/pull/893#discussion_r484427246
##
File path:
services/self-service/src/test/java/com/epam/dlab/backendapi/resources/ProjectResourceTest.java
##
@@ -181,4 +278,16 @@ private ProjectDTO returnProjectDTO(CreateProjectDTO
createProjectDTO) {
private ProjectActionFormDTO getProjectActionDTO() {
return new ProjectActionFormDTO(PROJECT_NAME,
Collections.singletonList("https://localhost:8083/;));
}
+
+private UpdateProjectDTO prepareUpdateProjectDTO() {
+return new UpdateProjectDTO(PROJECT_NAME, Collections.emptySet(),
Collections.emptySet(), true);
+}
+
+private ProjectActionFormDTO prepareProjectActionFormDTO(){
+return new ProjectActionFormDTO(PROJECT_NAME,
Collections.singletonList("https://localhost:8083/;));
+}
+
+private List prepareUpdateProjectBudgetDTOs() {
+return Collections.singletonList(new
UpdateProjectBudgetDTO(PROJECT_NAME, 123, false));
Review comment:
Variable is changed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org
For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] ppapou commented on a change in pull request #893: [DLAB ]Project resource UT
ppapou commented on a change in pull request #893:
URL: https://github.com/apache/incubator-dlab/pull/893#discussion_r484426866
##
File path:
services/self-service/src/test/java/com/epam/dlab/backendapi/resources/ProjectResourceTest.java
##
@@ -115,23 +131,104 @@ public void stopProject() {
verifyNoMoreInteractions(projectService);
}
+
@Test
-public void startProject() {
+public void getProject() {
+
when(projectService.get(anyString())).thenReturn(ProjectDTO.builder().name(PROJECT_NAME).build());
+
final Response response = resources.getJerseyTest()
-.target("project/start")
+.target("project/" + PROJECT_NAME)
.request()
.header("Authorization", "Bearer " + TOKEN)
-.post(Entity.json(getProjectActionDTO()));
+.get();
-assertEquals(HttpStatus.SC_ACCEPTED, response.getStatus());
-verify(projectService).start(any(UserInfo.class), anyList(),
anyString());
+assertEquals(HttpStatus.SC_OK, response.getStatus());
+assertEquals(MediaType.APPLICATION_JSON,
response.getHeaderString(HttpHeaders.CONTENT_TYPE));
+verify(projectService).get(PROJECT_NAME);
+verifyNoMoreInteractions(projectService);
+}
+
+@Test
+public void getProjects() {
+
when(projectService.getProjects(any(UserInfo.class))).thenReturn(Collections.singletonList(ProjectDTO.builder().name(PROJECT_NAME).build()));
+
+final Response response = resources.getJerseyTest()
+.target("project")
+.request()
+.header("Authorization", "Bearer " + TOKEN)
+.get();
+
+assertEquals(HttpStatus.SC_OK, response.getStatus());
+assertEquals(MediaType.APPLICATION_JSON,
response.getHeaderString(HttpHeaders.CONTENT_TYPE));
+verify(projectService).getProjects(getUserInfo());
+verifyNoMoreInteractions(projectService);
+}
+
+@Test
+public void getUserProjects() {
+when(projectService.getUserProjects(getUserInfo(),
false)).thenReturn(Collections.singletonList(ProjectDTO.builder().name(PROJECT_NAME).build()));
+
+final Response response = resources.getJerseyTest()
+.target("project/me")
+.request()
+.header("Authorization", "Bearer " + TOKEN)
+.get();
+
+assertEquals(HttpStatus.SC_OK, response.getStatus());
+assertEquals(MediaType.APPLICATION_JSON,
response.getHeaderString(HttpHeaders.CONTENT_TYPE));
+verify(projectService).getUserProjects(getUserInfo(), false);
Review comment:
The Boolean class is added
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org
For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] ppapou commented on a change in pull request #893: [DLAB ]Project resource UT
ppapou commented on a change in pull request #893:
URL: https://github.com/apache/incubator-dlab/pull/893#discussion_r484426689
##
File path:
services/self-service/src/test/java/com/epam/dlab/backendapi/resources/ProjectResourceTest.java
##
@@ -98,7 +101,20 @@ public void createExistingProject() {
.post(Entity.json(createProjectDTO));
assertEquals(HttpStatus.SC_INTERNAL_SERVER_ERROR,
response.getStatus());
-verify(projectService).create(getUserInfo(),
returnProjectDTO(createProjectDTO), createProjectDTO.getName());
+verify(projectService).create(getUserInfo(),
prepareProjectDTO(createProjectDTO), createProjectDTO.getName());
+verifyNoMoreInteractions(projectService);
+}
+
+@Test
+public void startProject() {
+final Response response = resources.getJerseyTest()
+.target("project/start")
+.request()
+.header("Authorization", "Bearer " + TOKEN)
+.post(Entity.json(getProjectActionDTO()));
+
+assertEquals(HttpStatus.SC_ACCEPTED, response.getStatus());
+verify(projectService).start(any(UserInfo.class), anyList(),
anyString());
Review comment:
Variables are updated
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org
For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] ofuks commented on a change in pull request #893: [DLAB ]Project resource UT
ofuks commented on a change in pull request #893:
URL: https://github.com/apache/incubator-dlab/pull/893#discussion_r484379658
##
File path:
services/self-service/src/test/java/com/epam/dlab/backendapi/resources/ProjectResourceTest.java
##
@@ -98,7 +101,20 @@ public void createExistingProject() {
.post(Entity.json(createProjectDTO));
assertEquals(HttpStatus.SC_INTERNAL_SERVER_ERROR,
response.getStatus());
-verify(projectService).create(getUserInfo(),
returnProjectDTO(createProjectDTO), createProjectDTO.getName());
+verify(projectService).create(getUserInfo(),
prepareProjectDTO(createProjectDTO), createProjectDTO.getName());
+verifyNoMoreInteractions(projectService);
+}
+
+@Test
+public void startProject() {
+final Response response = resources.getJerseyTest()
+.target("project/start")
+.request()
+.header("Authorization", "Bearer " + TOKEN)
+.post(Entity.json(getProjectActionDTO()));
+
+assertEquals(HttpStatus.SC_ACCEPTED, response.getStatus());
+verify(projectService).start(any(UserInfo.class), anyList(),
anyString());
Review comment:
We need to specify the exact arguments here, isn’t it?
##
File path:
services/self-service/src/test/java/com/epam/dlab/backendapi/resources/ProjectResourceTest.java
##
@@ -115,23 +131,104 @@ public void stopProject() {
verifyNoMoreInteractions(projectService);
}
+
@Test
-public void startProject() {
+public void getProject() {
+
when(projectService.get(anyString())).thenReturn(ProjectDTO.builder().name(PROJECT_NAME).build());
+
final Response response = resources.getJerseyTest()
-.target("project/start")
+.target("project/" + PROJECT_NAME)
.request()
.header("Authorization", "Bearer " + TOKEN)
-.post(Entity.json(getProjectActionDTO()));
+.get();
-assertEquals(HttpStatus.SC_ACCEPTED, response.getStatus());
-verify(projectService).start(any(UserInfo.class), anyList(),
anyString());
+assertEquals(HttpStatus.SC_OK, response.getStatus());
+assertEquals(MediaType.APPLICATION_JSON,
response.getHeaderString(HttpHeaders.CONTENT_TYPE));
+verify(projectService).get(PROJECT_NAME);
+verifyNoMoreInteractions(projectService);
+}
+
+@Test
+public void getProjects() {
+
when(projectService.getProjects(any(UserInfo.class))).thenReturn(Collections.singletonList(ProjectDTO.builder().name(PROJECT_NAME).build()));
+
+final Response response = resources.getJerseyTest()
+.target("project")
+.request()
+.header("Authorization", "Bearer " + TOKEN)
+.get();
+
+assertEquals(HttpStatus.SC_OK, response.getStatus());
+assertEquals(MediaType.APPLICATION_JSON,
response.getHeaderString(HttpHeaders.CONTENT_TYPE));
+verify(projectService).getProjects(getUserInfo());
+verifyNoMoreInteractions(projectService);
+}
+
+@Test
+public void getUserProjects() {
+when(projectService.getUserProjects(getUserInfo(),
false)).thenReturn(Collections.singletonList(ProjectDTO.builder().name(PROJECT_NAME).build()));
+
+final Response response = resources.getJerseyTest()
+.target("project/me")
+.request()
+.header("Authorization", "Bearer " + TOKEN)
+.get();
+
+assertEquals(HttpStatus.SC_OK, response.getStatus());
+assertEquals(MediaType.APPLICATION_JSON,
response.getHeaderString(HttpHeaders.CONTENT_TYPE));
+verify(projectService).getUserProjects(getUserInfo(), false);
Review comment:
Use **Boolean.FALSE** instead of just **false**
##
File path:
services/self-service/src/test/java/com/epam/dlab/backendapi/resources/ProjectResourceTest.java
##
@@ -181,4 +278,16 @@ private ProjectDTO returnProjectDTO(CreateProjectDTO
createProjectDTO) {
private ProjectActionFormDTO getProjectActionDTO() {
return new ProjectActionFormDTO(PROJECT_NAME,
Collections.singletonList("https://localhost:8083/;));
}
+
+private UpdateProjectDTO prepareUpdateProjectDTO() {
+return new UpdateProjectDTO(PROJECT_NAME, Collections.emptySet(),
Collections.emptySet(), true);
Review comment:
Use **Boolean.TRUE** instead of just **true**
##
File path:
services/self-service/src/test/java/com/epam/dlab/backendapi/resources/ProjectResourceTest.java
##
@@ -181,4 +278,16 @@ private ProjectDTO returnProjectDTO(CreateProjectDTO
createProjectDTO) {
private ProjectActionFormDTO getProjectActionDTO() {
return new ProjectActionFormDTO(PROJECT_NAME,
Collections.singletonList("https://localhost:8083/;));
}
+
+private UpdateProjectDTO
[GitHub] [incubator-dlab] ppapou opened a new pull request #893: [DLAB ]Project resource UT
ppapou opened a new pull request #893: URL: https://github.com/apache/incubator-dlab/pull/893 UT Coverage is done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #892: [DLAB-2023]: Removed r package for Spark Standalone on DeepLearning
DG1202 merged pull request #892: URL: https://github.com/apache/incubator-dlab/pull/892 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 opened a new pull request #892: [DLAB-2023]: Removed r package for Spark Standalone on DeepLearning
DG1202 opened a new pull request #892: URL: https://github.com/apache/incubator-dlab/pull/892 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] bodnarmykola merged pull request #891: [DLAB-1980]: [Jupyter]: Custom Spark Standalone creation/reconfiguration fails
bodnarmykola merged pull request #891: URL: https://github.com/apache/incubator-dlab/pull/891 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] bodnarmykola merged pull request #890: [DLAB-2021]: For wrong library name convey 'invalid name' instead of 'invalid version' for Data Engine Service apt/yum group
bodnarmykola merged pull request #890: URL: https://github.com/apache/incubator-dlab/pull/890 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov opened a new pull request #890: [DLAB-2021]: For wrong library name convey 'invalid name' instead of 'invalid version' for Data Engine Service apt/yum group
leonidfrolov opened a new pull request #890: URL: https://github.com/apache/incubator-dlab/pull/890 changed available yum package versions acquirement This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov opened a new pull request #891: [DLAB-1980]: [Jupyter]: Custom Spark Standalone creation/reconfiguration fails
leonidfrolov opened a new pull request #891:
URL: https://github.com/apache/incubator-dlab/pull/891
added check if /opt/{cluster_name} exist during custom spark creation
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org
For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #889: [DLAB-2022]: Fixed allocation to another folder during refresh
DG1202 merged pull request #889: URL: https://github.com/apache/incubator-dlab/pull/889 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 opened a new pull request #889: [DLAB-2022]: Fixed allocation to another folder during refresh
DG1202 opened a new pull request #889: URL: https://github.com/apache/incubator-dlab/pull/889 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] ofuks merged pull request #888: [DLAB] Project resource UT
ofuks merged pull request #888: URL: https://github.com/apache/incubator-dlab/pull/888 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] ofuks commented on a change in pull request #888: [DLAB] Project resource UT
ofuks commented on a change in pull request #888:
URL: https://github.com/apache/incubator-dlab/pull/888#discussion_r483471730
##
File path:
services/self-service/src/test/java/com/epam/dlab/backendapi/resources/ProjectResourceTest.java
##
@@ -128,6 +128,34 @@ public void startProject() {
verifyNoMoreInteractions(projectService);
}
+@Test
+public void getProject() {
+
when(projectService.get(PROJECT_NAME)).thenReturn(ProjectDTO.builder().name(PROJECT_NAME).build());
Review comment:
Please, use **any()** method
##
File path:
services/self-service/src/test/java/com/epam/dlab/backendapi/resources/ProjectResourceTest.java
##
@@ -128,6 +128,34 @@ public void startProject() {
verifyNoMoreInteractions(projectService);
}
+@Test
+public void getProject() {
+
when(projectService.get(PROJECT_NAME)).thenReturn(ProjectDTO.builder().name(PROJECT_NAME).build());
+final Response response = resources.getJerseyTest()
+.target("project/" + PROJECT_NAME)
+.request()
+.header("Authorization", "Bearer " + TOKEN)
+.get();
+
+assertEquals(HttpStatus.SC_OK, response.getStatus());
+verify(projectService).get(PROJECT_NAME);
+verifyNoMoreInteractions(projectService);
+}
+
+@Test
+public void getProjects() {
+
when(projectService.getProjects(getUserInfo())).thenReturn(Collections.singletonList(ProjectDTO.builder().name(PROJECT_NAME).build()));
Review comment:
The same here
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org
For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] ppapou opened a new pull request #888: [DLAB] Project resource UT
ppapou opened a new pull request #888: URL: https://github.com/apache/incubator-dlab/pull/888 - getProject and getProjects tests have been added This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] bodnarmykola merged pull request #887: [DLAB-1980]: [Jupyter]: Custom Spark Standalone creation/reconfiguration fails
bodnarmykola merged pull request #887: URL: https://github.com/apache/incubator-dlab/pull/887 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov opened a new pull request #887: [DLAB-1980]: [Jupyter]: Custom Spark Standalone creation/reconfiguration fails
leonidfrolov opened a new pull request #887: URL: https://github.com/apache/incubator-dlab/pull/887 fixed reconfiguration fail This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #886: [DLAB-2019]: Allowed to stop notebook if at least one instance is in running status during multiple choice
DG1202 merged pull request #886: URL: https://github.com/apache/incubator-dlab/pull/886 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 opened a new pull request #886: [DLAB-2019]: Allowed to stop notebook if at least one instance is in running status during multiple choice
DG1202 opened a new pull request #886: URL: https://github.com/apache/incubator-dlab/pull/886 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #885: [DLAB-2020]: Minor changes about library installation
DG1202 merged pull request #885: URL: https://github.com/apache/incubator-dlab/pull/885 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 opened a new pull request #885: [DLAB-2020]: Minor changes about library installation
DG1202 opened a new pull request #885: URL: https://github.com/apache/incubator-dlab/pull/885 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov merged pull request #884: [DLAB-2018]: JupyterLab image is not created during the first notebook creation
leonidfrolov merged pull request #884: URL: https://github.com/apache/incubator-dlab/pull/884 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] leonidfrolov opened a new pull request #884: [DLAB-2018]: JupyterLab image is not created during the first notebook creation
leonidfrolov opened a new pull request #884: URL: https://github.com/apache/incubator-dlab/pull/884 fixed AMI creation for jupyterlab This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 merged pull request #883: [DLAB-2015]: Removed Ungit link for Apache Zeppelin on 'Environment management' page
DG1202 merged pull request #883: URL: https://github.com/apache/incubator-dlab/pull/883 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
