[GitHub] imay commented on a change in pull request #246: Colocate Join (#245)

imay commented on a change in pull request #246: Colocate Join (#245) URL: https://github.com/apache/incubator-doris/pull/246#discussion_r226547574 ## File path: fe/src/com/baidu/palo/clone/BackendInfo.java ## @@ -0,0 +1,95 @@ +// Copyright (c) 2017, Baidu.com, Inc. All Rig

[GitHub] imay commented on a change in pull request #246: Colocate Join (#245)

imay commented on a change in pull request #246: Colocate Join (#245) URL: https://github.com/apache/incubator-doris/pull/246#discussion_r226547137 ## File path: fe/src/com/baidu/palo/catalog/Catalog.java ## @@ -3121,6 +3162,60 @@ private Table createOlapTable(Database db,

[GitHub] imay commented on a change in pull request #246: Colocate Join (#245)

imay commented on a change in pull request #246: Colocate Join (#245) URL: https://github.com/apache/incubator-doris/pull/246#discussion_r226545340 ## File path: fe/src/com/baidu/palo/planner/HashJoinNode.java ## @@ -114,6 +115,17 @@ public void setDistributionMode(Distribu

[GitHub] imay commented on a change in pull request #246: Colocate Join (#245)

imay commented on a change in pull request #246: Colocate Join (#245) URL: https://github.com/apache/incubator-doris/pull/246#discussion_r226545407 ## File path: fe/src/com/baidu/palo/planner/DistributedPlanner.java ## @@ -393,6 +412,83 @@ private PlanFragment createHashJoi

[GitHub] imay commented on a change in pull request #246: Colocate Join (#245)

imay commented on a change in pull request #246: Colocate Join (#245) URL: https://github.com/apache/incubator-doris/pull/246#discussion_r226546847 ## File path: fe/src/com/baidu/palo/alter/DecommissionBackendJob.java ## @@ -433,6 +438,12 @@ public synchronized int tryFinis

[GitHub] imay commented on a change in pull request #246: Colocate Join (#245)

imay commented on a change in pull request #246: Colocate Join (#245) URL: https://github.com/apache/incubator-doris/pull/246#discussion_r226545181 ## File path: gensrc/thrift/PaloInternalService.thrift ## @@ -121,6 +121,9 @@ struct TQueryOptions { // multithreaded deg

[GitHub] imay commented on a change in pull request #246: Colocate Join (#245)

imay commented on a change in pull request #246: Colocate Join (#245) URL: https://github.com/apache/incubator-doris/pull/246#discussion_r226544716 ## File path: fe/src/com/baidu/palo/qe/SessionVariable.java ## @@ -403,6 +407,16 @@ public int getMtDop() { public void s

[GitHub] kangkaisen commented on issue #245: Colocate Join

kangkaisen commented on issue #245: Colocate Join URL: https://github.com/apache/incubator-doris/issues/245#issuecomment-430946769 > I think there is no need to add "colocate_with" property when create parent table. There is some case that user have already have a table, then they need

[GitHub] kangkaisen opened a new pull request #246: Colocate Join (#245)

kangkaisen opened a new pull request #246: Colocate Join (#245) URL: https://github.com/apache/incubator-doris/pull/246 [For 245](https://github.com/apache/incubator-doris/issues/245) Please review, Thanks! **About Test** I will add test later. -

[GitHub] morningman commented on issue #241: Invalid metric type error for Prometheus 2.4.x

morningman commented on issue #241: Invalid metric type error for Prometheus 2.4.x URL: https://github.com/apache/incubator-doris/issues/241#issuecomment-430905621 Yes it is. We already fixed it, and will pull it later. prometheus 2.3.1 works for now, you can download it here: