[GitHub] wuyunfeng commented on a change in pull request #272: Change SQL built-in function's symbol

2018-11-01 Thread GitBox
wuyunfeng commented on a change in pull request #272: Change SQL built-in function's symbol URL: https://github.com/apache/incubator-doris/pull/272#discussion_r230283632 ## File path: gensrc/script/gen_vector_functions.py ## @@ -410,7 +410,7 @@ #ifndef BDG_PALO_OPCODE_VEC

[GitHub] chenhao7253886 opened a new pull request #272: Change SQL built-in function's symbol

2018-11-01 Thread GitBox
chenhao7253886 opened a new pull request #272: Change SQL built-in function's symbol URL: https://github.com/apache/incubator-doris/pull/272 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] imay commented on a change in pull request #250: Fix InsertStmt explain bug

2018-11-01 Thread GitBox
imay commented on a change in pull request #250: Fix InsertStmt explain bug URL: https://github.com/apache/incubator-doris/pull/250#discussion_r230283062 ## File path: fe/src/main/java/org/apache/doris/analysis/InsertStmt.java ## @@ -233,7 +233,7 @@ public void analyze(Anal

[GitHub] imay closed pull request #249: Fix UnionStmt toSql bug

2018-11-01 Thread GitBox
imay closed pull request #249: Fix UnionStmt toSql bug URL: https://github.com/apache/incubator-doris/pull/249 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (fr

[GitHub] morningman commented on issue #271: User can not kill it own session with 'kill' cmd

2018-11-01 Thread GitBox
morningman commented on issue #271: User can not kill it own session with 'kill' cmd URL: https://github.com/apache/incubator-doris/issues/271#issuecomment-435286245 Now, only admin and root user can kill connection. This is

[GitHub] morningman opened a new issue #271: User can not kill it own session with 'kill' cmd

2018-11-01 Thread GitBox
morningman opened a new issue #271: User can not kill it own session with 'kill' cmd URL: https://github.com/apache/incubator-doris/issues/271 **Describe the bug** User can not kill it own session with 'kill' cmd **To Reproduce** 1. connect to doris with a non-root user; 2.

[GitHub] kangkaisen commented on issue #250: Fix InsertStmt explain bug

2018-11-01 Thread GitBox
kangkaisen commented on issue #250: Fix InsertStmt explain bug URL: https://github.com/apache/incubator-doris/pull/250#issuecomment-435285123 Update this commit. This is an automated message from the Apache Git Service. To res

[GitHub] kangkaisen commented on issue #249: Fix UnionStmt toSql bug

2018-11-01 Thread GitBox
kangkaisen commented on issue #249: Fix UnionStmt toSql bug URL: https://github.com/apache/incubator-doris/pull/249#issuecomment-435283485 Update this commit. This is an automated message from the Apache Git Service. To respo

[GitHub] kangkaisen commented on issue #248: Doris view support AnalyticExpr

2018-11-01 Thread GitBox
kangkaisen commented on issue #248: Doris view support AnalyticExpr URL: https://github.com/apache/incubator-doris/pull/248#issuecomment-435282762 Update this commit to apply the latest version code. This is an automated messa

[GitHub] lide-reed opened a new issue #270: Reducing the duplication of code with Apache Impala

2018-11-01 Thread GitBox
lide-reed opened a new issue #270: Reducing the duplication of code with Apache Impala URL: https://github.com/apache/incubator-doris/issues/270 1. Find out the code, modules, components which duplicates of Impala; 2. Determine the features which could be merged to Impala under Impala

[GitHub] imay closed pull request #269: Fix unit test failed in BE

2018-11-01 Thread GitBox
imay closed pull request #269: Fix unit test failed in BE URL: https://github.com/apache/incubator-doris/pull/269 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (

Re: Refactoring to work with Apache Impala

2018-11-01 Thread Li,De(BDG)
Yes, I agree with you. We are going to use GitHub Issues for Doris, I will put them into GitHub Issues. Best Regards, Reed On 2018/11/2 上午11:00, "Willem Jiang" wrote: >Hi > >I think we can put these tasks into the JIRA to keep track it. >We also need to put these tasks into the roadmap, it's qu

Re: Refactoring to work with Apache Impala

2018-11-01 Thread Willem Jiang
Hi I think we can put these tasks into the JIRA to keep track it. We also need to put these tasks into the roadmap, it's quit important for Doris and Impala work together. Any thoughts? Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Fri, Nov 2, 2018 at 10:29 AM Li,De(BDG) wrote: > > Hi

[GitHub] chenhao7253886 opened a new pull request #269: Fix unit test failed in BE

2018-11-01 Thread GitBox
chenhao7253886 opened a new pull request #269: Fix unit test failed in BE URL: https://github.com/apache/incubator-doris/pull/269 This is an automated message from the Apache Git Service. To respond to the message, please log

Re: Refactoring to work with Apache Impala

2018-11-01 Thread Li,De(BDG)
Hi Jim, This work has not start yet, and we are working for the first release now. Yes, we plan to do this work after the first release. Best Regards, Reed On 2018/11/1 下午9:18, "Jim Apple" wrote: >During the incubation discussion for Doris, Reed discussed the plan for >reducing the duplication

[GitHub] kangpinghuang commented on a change in pull request #264: Update #257: rewrite aes encryption

2018-11-01 Thread GitBox
kangpinghuang commented on a change in pull request #264: Update #257: rewrite aes encryption URL: https://github.com/apache/incubator-doris/pull/264#discussion_r230254695 ## File path: be/src/util/aes_util.cpp ## @@ -0,0 +1,174 @@ +// Licensed to the Apache Software Foun

[GitHub] kangpinghuang commented on a change in pull request #264: Update #257: rewrite aes encryption

2018-11-01 Thread GitBox
kangpinghuang commented on a change in pull request #264: Update #257: rewrite aes encryption URL: https://github.com/apache/incubator-doris/pull/264#discussion_r230254743 ## File path: be/src/util/aes_util.cpp ## @@ -0,0 +1,174 @@ +// Licensed to the Apache Software Foun

[GitHub] kangpinghuang commented on a change in pull request #264: Update #257: rewrite aes encryption

2018-11-01 Thread GitBox
kangpinghuang commented on a change in pull request #264: Update #257: rewrite aes encryption URL: https://github.com/apache/incubator-doris/pull/264#discussion_r230254695 ## File path: be/src/util/aes_util.cpp ## @@ -0,0 +1,174 @@ +// Licensed to the Apache Software Foun

[GitHub] kangpinghuang commented on a change in pull request #264: Update #257: rewrite aes encryption

2018-11-01 Thread GitBox
kangpinghuang commented on a change in pull request #264: Update #257: rewrite aes encryption URL: https://github.com/apache/incubator-doris/pull/264#discussion_r230254703 ## File path: be/src/util/aes_util.cpp ## @@ -0,0 +1,174 @@ +// Licensed to the Apache Software Foun

[GitHub] kangpinghuang commented on a change in pull request #264: Update #257: rewrite aes encryption

2018-11-01 Thread GitBox
kangpinghuang commented on a change in pull request #264: Update #257: rewrite aes encryption URL: https://github.com/apache/incubator-doris/pull/264#discussion_r230254634 ## File path: be/src/aes/aes.cpp ## @@ -0,0 +1,171 @@ +// Copyright (c) 2018, Baidu.com, Inc. All Ri

[GitHub] kangpinghuang commented on a change in pull request #264: Update #257: rewrite aes encryption

2018-11-01 Thread GitBox
kangpinghuang commented on a change in pull request #264: Update #257: rewrite aes encryption URL: https://github.com/apache/incubator-doris/pull/264#discussion_r230254599 ## File path: be/src/aes/aes.cpp ## @@ -0,0 +1,171 @@ +// Copyright (c) 2018, Baidu.com, Inc. All Ri

[GitHub] kangpinghuang commented on a change in pull request #264: Update #257: rewrite aes encryption

2018-11-01 Thread GitBox
kangpinghuang commented on a change in pull request #264: Update #257: rewrite aes encryption URL: https://github.com/apache/incubator-doris/pull/264#discussion_r230254623 ## File path: be/CMakeLists.txt ## @@ -585,6 +585,7 @@ if (${MAKE_TEST} STREQUAL "ON") add_subd

[GitHub] chenhao7253886 opened a new pull request #268: Change variable and namespace name in BE

2018-11-01 Thread GitBox
chenhao7253886 opened a new pull request #268: Change variable and namespace name in BE URL: https://github.com/apache/incubator-doris/pull/268 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] kangpinghuang commented on a change in pull request #264: Update #257: rewrite aes encryption

2018-11-01 Thread GitBox
kangpinghuang commented on a change in pull request #264: Update #257: rewrite aes encryption URL: https://github.com/apache/incubator-doris/pull/264#discussion_r230054287 ## File path: be/src/util/aes_util.cpp ## @@ -0,0 +1,174 @@ +// Licensed to the Apache Software Foun

Refactoring to work with Apache Impala

2018-11-01 Thread Jim Apple
During the incubation discussion for Doris, Reed discussed the plan for reducing the duplication of code with Apache Impala. The plan was: "1. Find out the code, modules, components which duplicates of Impala; 2. Determine the features which could be merged to Impala under Impala community suppor

[GitHub] morningman closed pull request #266: Fix equal conjuncts which refer more than two tuples registered unsuccessfully

2018-11-01 Thread GitBox
morningman closed pull request #266: Fix equal conjuncts which refer more than two tuples registered unsuccessfully URL: https://github.com/apache/incubator-doris/pull/266 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] morningman commented on a change in pull request #266: Fix equal conjuncts which refer more than two tuples registered unsuccessfully

2018-11-01 Thread GitBox
morningman commented on a change in pull request #266: Fix equal conjuncts which refer more than two tuples registered unsuccessfully URL: https://github.com/apache/incubator-doris/pull/266#discussion_r230011980 ## File path: fe/src/main/java/org/apache/doris/analysis/Analyzer.java

[GitHub] imay commented on a change in pull request #264: Update #257: rewrite aes encryption

2018-11-01 Thread GitBox
imay commented on a change in pull request #264: Update #257: rewrite aes encryption URL: https://github.com/apache/incubator-doris/pull/264#discussion_r230024578 ## File path: be/src/util/aes_util.cpp ## @@ -0,0 +1,174 @@ +// Licensed to the Apache Software Foundation (A

[GitHub] imay commented on a change in pull request #264: Update #257: rewrite aes encryption

2018-11-01 Thread GitBox
imay commented on a change in pull request #264: Update #257: rewrite aes encryption URL: https://github.com/apache/incubator-doris/pull/264#discussion_r230024782 ## File path: be/src/util/aes_util.cpp ## @@ -0,0 +1,174 @@ +// Licensed to the Apache Software Foundation (A

[GitHub] imay commented on a change in pull request #264: Update #257: rewrite aes encryption

2018-11-01 Thread GitBox
imay commented on a change in pull request #264: Update #257: rewrite aes encryption URL: https://github.com/apache/incubator-doris/pull/264#discussion_r230025349 ## File path: be/src/util/aes_util.cpp ## @@ -0,0 +1,174 @@ +// Licensed to the Apache Software Foundation (A

[GitHub] imay closed pull request #267: Make class name compatible with the old name

2018-11-01 Thread GitBox
imay closed pull request #267: Make class name compatible with the old name URL: https://github.com/apache/incubator-doris/pull/267 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fore

[GitHub] morningman opened a new pull request #267: Make class name compatible with the old name

2018-11-01 Thread GitBox
morningman opened a new pull request #267: Make class name compatible with the old name URL: https://github.com/apache/incubator-doris/pull/267 We wrote the old name 'com.baidu.palo.xxx' in bdbje as meta journal. So we need to make it compatible with 'org.apache.doris.xxx'.

[GitHub] chenhao7253886 opened a new pull request #266: fail to register equal conjuncts which refer more than three tuples

2018-11-01 Thread GitBox
chenhao7253886 opened a new pull request #266: fail to register equal conjuncts which refer more than three tuples URL: https://github.com/apache/incubator-doris/pull/266 Change-Id: I7eaf28ee6db35671971108f3edefe908d46ae87f T

[GitHub] imay closed pull request #265: Change the lock type of Catalog lock

2018-11-01 Thread GitBox
imay closed pull request #265: Change the lock type of Catalog lock URL: https://github.com/apache/incubator-doris/pull/265 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] imay commented on a change in pull request #265: Change the lock type of Catalog lock

2018-11-01 Thread GitBox
imay commented on a change in pull request #265: Change the lock type of Catalog lock URL: https://github.com/apache/incubator-doris/pull/265#discussion_r229965066 ## File path: fe/src/main/java/org/apache/doris/common/util/QueryableReentrantLock.java ## @@ -0,0 +1,24 @@

[GitHub] imay commented on a change in pull request #264: Update #257: rewrite aes encryption

2018-11-01 Thread GitBox
imay commented on a change in pull request #264: Update #257: rewrite aes encryption URL: https://github.com/apache/incubator-doris/pull/264#discussion_r229954963 ## File path: be/src/aes/aes.cpp ## @@ -0,0 +1,171 @@ +// Copyright (c) 2018, Baidu.com, Inc. All Rights Rese

[GitHub] imay commented on a change in pull request #264: Update #257: rewrite aes encryption

2018-11-01 Thread GitBox
imay commented on a change in pull request #264: Update #257: rewrite aes encryption URL: https://github.com/apache/incubator-doris/pull/264#discussion_r229954591 ## File path: be/src/aes/aes.cpp ## @@ -0,0 +1,171 @@ +// Copyright (c) 2018, Baidu.com, Inc. All Rights Rese

[GitHub] imay commented on a change in pull request #264: Update #257: rewrite aes encryption

2018-11-01 Thread GitBox
imay commented on a change in pull request #264: Update #257: rewrite aes encryption URL: https://github.com/apache/incubator-doris/pull/264#discussion_r229954881 ## File path: be/CMakeLists.txt ## @@ -585,6 +585,7 @@ if (${MAKE_TEST} STREQUAL "ON") add_subdirectory(

[GitHub] morningman opened a new pull request #265: Change the lock type of Catalog lock

2018-11-01 Thread GitBox
morningman opened a new pull request #265: Change the lock type of Catalog lock URL: https://github.com/apache/incubator-doris/pull/265 Implement a QueryableReentrantLock to see which thread held the lock. This is an automated