[GitHub] imay commented on a change in pull request #283: Fix truncation error in CastExpr
imay commented on a change in pull request #283: Fix truncation error in CastExpr URL: https://github.com/apache/incubator-doris/pull/283#discussion_r230776846 ## File path: fe/src/main/java/org/apache/doris/analysis/TypeDef.java ## @@ -0,0 +1,128 @@ +// Modifications copyright (C) 2017, Baidu.com, Inc. +// Copyright 2017 The Apache Software Foundation Review comment: your license is not right This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] imay commented on a change in pull request #283: Fix truncation error in CastExpr
imay commented on a change in pull request #283: Fix truncation error in
CastExpr
URL: https://github.com/apache/incubator-doris/pull/283#discussion_r230782696
##
File path: fe/src/main/java/org/apache/doris/analysis/CastExpr.java
##
@@ -219,7 +195,9 @@ private void analyze() throws AnalysisException {
@Override
public void analyzeImpl(Analyzer analyzer) throws AnalysisException {
-type = targetType;
+Preconditions.checkState(!isImplicit);
+targetTypeDef.analyze(analyzer);
Review comment:
targetTypeDef will null if this is implicit cast? And this will throw a
NullPointerException
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
