imay commented on a change in pull request #1658: FROM_UNIXTIME should only
convert timestamp from 0 to 253402271999
URL: https://github.com/apache/incubator-doris/pull/1658#discussion_r314569259
##########
File path: be/src/runtime/datetime_value.cpp
##########
@@ -1544,6 +1544,10 @@ bool DateTimeValue::unix_timestamp(int64_t* timestamp,
const std::string& timezo
}
bool DateTimeValue::from_unixtime(int64_t timestamp, const std::string&
timezone) {
+ // timestamp should between 1900-01-01 00:00:00 ~ 9999-12-31 23:59:59
Review comment:
```suggestion
// timestamp should between 1970-01-01 00:00:00 ~ 9999-12-31 23:59:59
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
