[GitHub] kangkaisen commented on a change in pull request #255: Simplify constant Expr

2018-11-06 Thread GitBox
kangkaisen commented on a change in pull request #255: Simplify constant Expr URL: https://github.com/apache/incubator-doris/pull/255#discussion_r231047664 ## File path: fe/src/main/java/org/apache/doris/rewrite/FoldConstantsRule.java ## @@ -0,0 +1,233 @@ +// Licensed to th

[GitHub] kangkaisen commented on a change in pull request #255: Simplify constant Expr

2018-11-05 Thread GitBox
kangkaisen commented on a change in pull request #255: Simplify constant Expr URL: https://github.com/apache/incubator-doris/pull/255#discussion_r230672079 ## File path: fe/src/main/java/org/apache/doris/rewrite/FoldConstantsRule.java ## @@ -0,0 +1,233 @@ +// Licensed to th