[dpdk-dev] [PATCH]i40e: move the fdir_setup from dev_init to dev_configure

2014-12-04 Thread Ananyev, Konstantin
> -Original Message- > From: Wu, Jingjing > Sent: Thursday, December 04, 2014 3:40 PM > To: dev at dpdk.org > Cc: Wu, Jingjing; Zhang, Helin; Ananyev, Konstantin > Subject: [PATCH]i40e: move the fdir_setup from dev_init to dev_configure > > In order not to affect the FVL's performance

[dpdk-dev] [PATCH v2] ixgbe: don't override mbuf buffer length

2014-12-04 Thread Jean-Mickael Guerin
The template mbuf_initializer is hard coded with a buflen which might have been set differently by the application at the time of mbuf pool creation. Switch to a mbuf allocation, to fetch the correct default values. There is no performance impact because this is not a data-plane API.

[dpdk-dev] [PATCH] Fix KNI compiling issue on IBM Power

2014-12-04 Thread Chao Zhu
Because of different cache line size, the alignment of struct rte_kni_mbuf in rte_kni_common.h doesn't work on IBM Power. This patch changed from 64 to RTE_CACHE_LINE_SIZE micro to do the alignment. Signed-off-by: Chao Zhu --- .../linuxapp/eal/include/exec-env/rte_kni_common.h |7 +-- 1

[dpdk-dev] [PATCH] Fix KNI compiling on IBM Power

2014-12-04 Thread Chao Zhu
This patch solves the KNI compiling problem on IBM Power by using RTE_CACHE_LINE_SIZE micro. Chao Zhu (1): Fix KNI compiling issue on IBM Power .../linuxapp/eal/include/exec-env/rte_kni_common.h |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-)

[dpdk-dev] [PATCH] i40e: Fix a vlan bug

2014-12-04 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" i40e uses an bitmap array to store those vlan tags that are set by application. In function i40e_set_vlan_filter, it stores vlan tag to wrong place. This change will fix it. Signed-off-by: Chen Jing D(Mark) --- lib/librte_pmd_i40e/i40e_ethdev.c

[dpdk-dev] [PATCH 0/2] fix endianness in EAL

2014-12-04 Thread Chao Zhu
On 2014/12/4 4:47, Thomas Monjalon wrote: > It can be hard to implement a reliable detection of endianness. > Previous trials in testpmd failed. > The IBM Power patchset introduced a config option. > > This patchset try to improve the situation by having a detection > in EAL headers. > > Please

[dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length

2014-12-04 Thread Bruce Richardson
On Thu, Dec 04, 2014 at 05:17:16PM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Richardson, Bruce > > Sent: Thursday, December 04, 2014 4:59 PM > > To: Ananyev, Konstantin > > Cc: Thomas Monjalon; dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 2/2] ixgbe:

[dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length

2014-12-04 Thread Bruce Richardson
On Thu, Dec 04, 2014 at 06:11:41PM +0100, Jean-Mickael Guerin wrote: > >>Which makes me think, that we probably shouldn't overwrite buf_len by > >>rxq->mbuf_initializer. > >> > >I believe that it is perfectly safe to do so. All buffers from a mempool are > >meant > >to be the same size,

[dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length

2014-12-04 Thread Ananyev, Konstantin
> -Original Message- > From: Richardson, Bruce > Sent: Thursday, December 04, 2014 4:59 PM > To: Ananyev, Konstantin > Cc: Thomas Monjalon; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length > > On Thu, Dec 04, 2014 at 04:18:03PM +,

[dpdk-dev] [PATCH v3] Fix two compile issues with i686 platform

2014-12-04 Thread Michael Qiu
lib/librte_eal/linuxapp/eal/eal_memory.c:324:4: error: comparison is always false due to limited range of data type [-Werror=type-limits] || (hugepage_sz == RTE_PGSIZE_16G)) { ^ cc1: all warnings being treated as errors lib/librte_eal/linuxapp/eal/eal.c(461): error #2259: non-pointer

[dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length

2014-12-04 Thread Jean-Mickael Guerin
On 04/12/2014 16:32, Bruce Richardson wrote: > On Thu, Dec 04, 2014 at 03:29:04PM +, Ananyev, Konstantin wrote: >> >> >>> -Original Message- >>> From: Richardson, Bruce >>> Sent: Thursday, December 04, 2014 3:15 PM >>> To: Ananyev, Konstantin >>> Cc: Jean-Mickael Guerin; dev at

[dpdk-dev] [PATCH] Fix KNI compiling issue on IBM Power

2014-12-04 Thread Thomas Monjalon
2014-12-04 10:32, Neil Horman: > On Thu, Dec 04, 2014 at 02:47:03PM +0100, Thomas Monjalon wrote: > > 2014-12-04 08:29, Neil Horman: > > > On Thu, Dec 04, 2014 at 12:59:31PM +0100, Thomas Monjalon wrote: > > > > > Because of different cache line size, the alignment of struct > > > > > rte_kni_mbuf

[dpdk-dev] [PATCH] librte_pmd_af_packet: add compile-time checks for kernel-specific options

2014-12-04 Thread John W. Linville
This allows the PMD to compile with kernels that don't support the options in question. The "#if defined(...)" lines are a bit ugly, but I don't know of any better way to accomplish the task. Signed-off-by: John W. Linville --- lib/librte_pmd_af_packet/rte_eth_af_packet.c | 16

[dpdk-dev] [PATCH] examples: fix symmetric_mp, set NIC rx_drop_en bit

2014-12-04 Thread Thomas Monjalon
2014-12-04 14:03, Bruce Richardson: > On Thu, Dec 04, 2014 at 02:37:15PM +0100, Thomas Monjalon wrote: > > 2014-12-03 16:56, Bruce Richardson: > > > The symmetric_mp example app is set up to allow two processes to > > > share a NIC port, with each pulling packets from one queue. In order > > > to

[dpdk-dev] [PATCH] i40e: Fix a vlan bug

2014-12-04 Thread Thomas Monjalon
2014-12-04 14:29, Chen, Jing D: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2014-12-04 10:30, Chen, Jing D: > > > As I don't know what commit he is based on, I'd like to generate a new > > patch with latest dpdk repo. > > > > There's something wrong here. You rework a patch

[dpdk-dev] [PATCH] VFIO: Avoid to enable vfio while the module not loaded

2014-12-04 Thread Burakov, Anatoly
Hi Michael > But indeed, when try to unload both vfio and vfio_iommu_type1, > /dev/vfio/vfio still there, I'm also surprise. > > My ENV is fedora20, kernel version 3.6.7-200 X86_64. > > Believe or not, you can have a try, it seems a kernel issue. > > When you unload both two modules, then open

[dpdk-dev] [PATCH 1/2] ixgbe: fix setup of mbuf initializer template

2014-12-04 Thread Ananyev, Konstantin
> -Original Message- > From: Jean-Mickael Guerin [mailto:jean-mickael.guerin at 6wind.com] > Sent: Thursday, December 04, 2014 3:15 PM > To: Ananyev, Konstantin; Richardson, Bruce > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] ixgbe: fix setup of mbuf initializer > template

[dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length

2014-12-04 Thread Ananyev, Konstantin
> -Original Message- > From: Richardson, Bruce > Sent: Thursday, December 04, 2014 3:32 PM > To: Ananyev, Konstantin > Cc: Jean-Mickael Guerin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length > > On Thu, Dec 04, 2014 at 03:29:04PM +,

[dpdk-dev] [PATCH] librte_cmdline: FreeBSD Fix oveflow when size of command result structure is greater than BUFSIZ

2014-12-04 Thread Thomas Monjalon
2014-12-04 14:01, Carew, Alan: > I did post a V2 http://dpdk.org/ml/archives/dev/2014-November/007920.html. > I must have used an incorrect message ID incorrect for "--in-reply-to" though. Sorry I failed to check similar patches. I reverted the v1 patch and wait the review to apply the v2. --

[dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length

2014-12-04 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ananyev, Konstantin > Sent: Thursday, December 04, 2014 4:05 PM > To: Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length > > > > >

[dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length

2014-12-04 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, December 04, 2014 3:48 PM > To: Ananyev, Konstantin > Cc: dev at dpdk.org; Richardson, Bruce > Subject: Re: [dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length > > 2014-12-04

[dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length

2014-12-04 Thread Ananyev, Konstantin
> -Original Message- > From: Richardson, Bruce > Sent: Thursday, December 04, 2014 3:15 PM > To: Ananyev, Konstantin > Cc: Jean-Mickael Guerin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length > > On Thu, Dec 04, 2014 at 02:50:11PM +,

[dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length

2014-12-04 Thread Jean-Mickael Guerin
The template mbuf_initializer is hard coded with a buflen which might have been set differently by the application at the time of mbuf pool creation. Switch to a mbuf allocation, to fetch the correct default values. There is no performance impact because this is not a data-plane API.

[dpdk-dev] [PATCH 1/2] ixgbe: fix setup of mbuf initializer template

2014-12-04 Thread Jean-Mickael Guerin
Add a compiler barrier to make sure all fields covered by the marker rearm_data are assigned before the read. Signed-off-by: Jean-Mickael Guerin Acked-by: David Marchand Fixes: 0ff3324da2 ("ixgbe: rework vector pmd following mbuf changes") --- lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 3 +++ 1

[dpdk-dev] [PATCH 0/2] ixgbe: bug fixes for RX vector mode

2014-12-04 Thread Jean-Mickael Guerin
Jean-Mickael Guerin (2): ixgbe: fix setup of mbuf initializer template ixgbe: don't override mbuf buffer length lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) -- 2.1.3

[dpdk-dev] [PATCH] table: fix table_array for incomplete bitmask

2014-12-04 Thread Dumitrescu, Cristian
Acked by: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson Sent: Thursday, December 4, 2014 2:24 PM To: dev at dpdk.org Subject: [dpdk-dev] [PATCH] table: fix table_array for incomplete bitmask When a lookup was done on a table_array structure

[dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length

2014-12-04 Thread Bruce Richardson
On Thu, Dec 04, 2014 at 02:50:11PM +, Ananyev, Konstantin wrote: > Hi, > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jean-Mickael Guerin > > Sent: Thursday, December 04, 2014 2:26 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH 2/2]

[dpdk-dev] [PATCH] Fix KNI compiling issue on IBM Power

2014-12-04 Thread Neil Horman
On Thu, Dec 04, 2014 at 04:59:59PM +0100, Thomas Monjalon wrote: > 2014-12-04 10:32, Neil Horman: > > On Thu, Dec 04, 2014 at 02:47:03PM +0100, Thomas Monjalon wrote: > > > 2014-12-04 08:29, Neil Horman: > > > > On Thu, Dec 04, 2014 at 12:59:31PM +0100, Thomas Monjalon wrote: > > > > > > Because

[dpdk-dev] [PATCH v5 2/3] mbuf:add three TX ol_flags and repalce PKT_TX_VXLAN_CKSUM

2014-12-04 Thread Olivier MATZ
Hi, On 12/04/2014 12:03 PM, Ananyev, Konstantin wrote: > 1/ (Jijiang's patch) > PKT_TX_IP_CKSUM /* packet is IPv4, and we want hw cksum */ > PKT_TX_IPV6 /* packet is IPv6 */ > PKT_TX_IPV4 /* packet is IPv4, and we don't want hw cksum */ > > with PKT_TX_IP_CKSUM

[dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length

2014-12-04 Thread Ananyev, Konstantin
Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jean-Mickael Guerin > Sent: Thursday, December 04, 2014 2:26 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length > > The template mbuf_initializer is hard

[dpdk-dev] [PATCH v5 2/3] mbuf:add three TX ol_flags and repalce PKT_TX_VXLAN_CKSUM

2014-12-04 Thread Olivier MATZ
Hi, On 12/04/2014 11:19 AM, Ananyev, Konstantin wrote: >>> 1/ (Jijiang's patch) >>> PKT_TX_IP_CKSUM /* packet is IPv4, and we want hw cksum */ >>> PKT_TX_IPV6 /* packet is IPv6 */ >>> PKT_TX_IPV4 /* packet is IPv4, and we don't want hw cksum */ >>> >>> with PKT_TX_IP_CKSUM and

[dpdk-dev] [PATCH] Fix KNI compiling issue on IBM Power

2014-12-04 Thread Thomas Monjalon
2014-12-04 08:29, Neil Horman: > On Thu, Dec 04, 2014 at 12:59:31PM +0100, Thomas Monjalon wrote: > > > Because of different cache line size, the alignment of struct > > > rte_kni_mbuf in rte_kni_common.h doesn't work on IBM Power. This patch > > > changed from 64 to RTE_CACHE_LINE_SIZE micro to

[dpdk-dev] [PATCH] examples: fix symmetric_mp, set NIC rx_drop_en bit

2014-12-04 Thread Thomas Monjalon
2014-12-03 16:56, Bruce Richardson: > The symmetric_mp example app is set up to allow two processes to > share a NIC port, with each pulling packets from one queue. In order > to have the app continue working when one of the process dies, the > drop_en bit should be set in the NIC configuration.

[dpdk-dev] [PATCH] i40e: Fix a vlan bug

2014-12-04 Thread Chen, Jing D
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, December 4, 2014 6:39 PM > To: Chen, Jing D > Cc: dev at dpdk.org; Qiu, Michael > Subject: Re: [dpdk-dev] [PATCH] i40e: Fix a vlan bug > > 2014-12-04 10:30, Chen, Jing D: > > As I don't

[dpdk-dev] [PATCH] table: fix table_array for incomplete bitmask

2014-12-04 Thread Bruce Richardson
On Thu, Dec 04, 2014 at 02:23:33PM +, Bruce Richardson wrote: > Hi Cristian, please review before I send out publically. Thanks. B. > - > > When a lookup was done on a table_array structure with an incomplete > bitmask, the results was always zero hits. This was

[dpdk-dev] [PATCH] table: fix table_array for incomplete bitmask

2014-12-04 Thread Bruce Richardson
Hi Cristian, please review before I send out publically. Thanks. B. - When a lookup was done on a table_array structure with an incomplete bitmask, the results was always zero hits. This was because the pkts_mask value was cleared as we process each entry, and the result

[dpdk-dev] [PATCH] app/test: fix memory needs after RTE_MAX_LCORE was increased to 128

2014-12-04 Thread Thomas Monjalon
> Since commit b91c67e5a693211862aa7dc3b78630b4e856c2af, > maximum number of cores is 128, which has increase > the total memory necessary for a rte_mempool structure, > as the per-lcore local cache has been doubled in size. > Therefore, eal_flags unit test was broken since it needed > to use more

[dpdk-dev] [PATCH] examples: fix symmetric_mp, set NIC rx_drop_en bit

2014-12-04 Thread Bruce Richardson
On Thu, Dec 04, 2014 at 02:37:15PM +0100, Thomas Monjalon wrote: > 2014-12-03 16:56, Bruce Richardson: > > The symmetric_mp example app is set up to allow two processes to > > share a NIC port, with each pulling packets from one queue. In order > > to have the app continue working when one of the

[dpdk-dev] [PATCH] librte_cmdline: FreeBSD Fix oveflow when size of command result structure is greater than BUFSIZ

2014-12-04 Thread Carew, Alan
Hi folks and thanks, > > Sorry, I had no time to deeply check this. I think your patch can go > > in 1.8 as it's still an enhancement compared to the current situation. > > We may go back on this later. > > > > Acked-by: Olivier Matz > > Applied > > Thanks > -- > Thomas I did post a V2

[dpdk-dev] [PATCH] VFIO: Avoid to enable vfio while the module not loaded

2014-12-04 Thread Qiu, Michael
On 12/4/2014 9:12 PM, Burakov, Anatoly wrote: > Hi Michael > >> When vfio module is not loaded when kernel support vfio feature, the >> routine still try to open the container to get file description. >> >> This action is not safe, and of cause got error messages: >> >> EAL: Detected 40 lcore(s)

[dpdk-dev] [PATCH 1/2] eal: detect endianness

2014-12-04 Thread Thomas Monjalon
2014-12-04 10:28, Qiu, Michael: > On 12/4/2014 5:01 PM, Thomas Monjalon wrote: > > 2014-12-04 02:28, Qiu, Michael: > >> On 12/4/2014 5:26 AM, Thomas Monjalon wrote: > >>> There is no standard to check endianness. > >>> So we need to try different checks. > >>> Previous trials were done in testpmd

[dpdk-dev] [PATCH] VFIO: Avoid to enable vfio while the module not loaded

2014-12-04 Thread Burakov, Anatoly
Hi Michael > When vfio module is not loaded when kernel support vfio feature, the > routine still try to open the container to get file description. > > This action is not safe, and of cause got error messages: > > EAL: Detected 40 lcore(s) > EAL: unsupported IOMMU type! > EAL: VFIO support

[dpdk-dev] [PATCH] VFIO: Avoid to enable vfio while the module not loaded

2014-12-04 Thread Burakov, Anatoly
Hi Michael > When vfio module is not loaded when kernel support vfio feature, the > routine still try to open the container to get file description. > > This action is not safe, and of cause got error messages: > > EAL: Detected 40 lcore(s) > EAL: unsupported IOMMU type! > EAL: VFIO support

[dpdk-dev] [PATCH] enic: fix warnings

2014-12-04 Thread Thomas Monjalon
> >A lot of warnings were not seen because $(WERROR_FLAGS) was not set > >in the Makefile. But they appear with toolchains that enforce more checks. > > > >-Wno-deprecated seems useless. > >-Wno-strict-aliasing is added to avoid false positives. > > > >This patch cleans up unused variable, unused

[dpdk-dev] [PATCH v2] test-pmd: Fix pointer aliasing error

2014-12-04 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michael Qiu > Sent: Thursday, December 04, 2014 3:29 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2] test-pmd: Fix pointer aliasing error > > > app/test-pmd/csumonly.c: In function ?get_psd_sum?: >

[dpdk-dev] [PATCH 1/2] eal: detect endianness

2014-12-04 Thread Qiu, Michael
On 12/4/2014 8:20 PM, Thomas Monjalon wrote: > 2014-12-04 10:28, Qiu, Michael: >> On 12/4/2014 5:01 PM, Thomas Monjalon wrote: >>> 2014-12-04 02:28, Qiu, Michael: On 12/4/2014 5:26 AM, Thomas Monjalon wrote: > There is no standard to check endianness. > So we need to try different

[dpdk-dev] [PATCH] app/test: fix memory needs after RTE_MAX_LCORE was increased to 128

2014-12-04 Thread Pablo de Lara
Since commit b91c67e5a693211862aa7dc3b78630b4e856c2af, maximum number of cores is 128, which has increase the total memory necessary for a rte_mempool structure, as the per-lcore local cache has been doubled in size. Therefore, eal_flags unit test was broken since it needed to use more hugepages.

[dpdk-dev] Next Community Call, Tuesday 2nd December, 8:00 AM GMT

2014-12-04 Thread Thomas Monjalon
2014-12-04 06:30, Neil Horman: > On Wed, Dec 03, 2014 at 11:07:10PM +, O'driscoll, Tim wrote: > > Hi Olga, > > > > > Can you please send the presentations from last Community Call. > > > We have Tetsuya's presentation, if we can also get other presentations > > > it will > > > be great > >

[dpdk-dev] [PATCH] enic: fix warnings

2014-12-04 Thread Thomas Monjalon
2014-12-04 10:29, Sujith Sankar: > > On 02/12/14 8:29 pm, "Thomas Monjalon" wrote: > > >A lot of warnings were not seen because $(WERROR_FLAGS) was not set > >in the Makefile. But they appear with toolchains that enforce more checks. > > > >-Wno-deprecated seems useless. > >-Wno-strict-aliasing

[dpdk-dev] [PATCH v5 2/3] mbuf:add three TX ol_flags and repalce PKT_TX_VXLAN_CKSUM

2014-12-04 Thread Thomas Monjalon
Hi, 2014-12-04 10:23, Ananyev, Konstantin: > From: Liu, Jijiang > > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > > > On 12/03/2014 01:59 PM, Ananyev, Konstantin wrote: > > > >> I still think having a flag IPV4 + another flag IP_CHECKSUM is not > > > >> appropriate. > > > > > > > >

[dpdk-dev] [PATCH 2/3] docs: adjust line lengths in FreeBSD GSG rst files

2014-12-04 Thread Iremonger, Bernard
Hi Bruce, Thomas, > Subject: Re: [dpdk-dev] [PATCH 2/3] docs: adjust line lengths in FreeBSD GSG > rst files > > On Wed, Dec 03, 2014 at 02:23:44PM +0100, Thomas Monjalon wrote: > > 2014-11-24 15:48, Bruce Richardson: > > > The FreeBSD GSG rst files had very inconsistent line lengths for > > >

[dpdk-dev] [PATCH] VFIO: Avoid to enable vfio while the module not loaded

2014-12-04 Thread Michael Qiu
When vfio module is not loaded when kernel support vfio feature, the routine still try to open the container to get file description. This action is not safe, and of cause got error messages: EAL: Detected 40 lcore(s) EAL: unsupported IOMMU type! EAL: VFIO support could not be initialized EAL:

[dpdk-dev] [PATCH v2] test-pmd: Fix pointer aliasing error

2014-12-04 Thread Michael Qiu
app/test-pmd/csumonly.c: In function ?get_psd_sum?: build/include/rte_ip.h:161: error: dereferencing pointer ?u16? does break strict-aliasing rules build/include/rte_ip.h:157: note: initialized from here ... The root cause is that, compile enable strict aliasing by default, while

[dpdk-dev] [PATCH 4/4] doc: Various document fixes in testpmd UG

2014-12-04 Thread Iremonger, Bernard
Hi Thomas, > Subject: Re: [dpdk-dev] [PATCH 4/4] doc: Various document fixes in testpmd UG > > 2014-11-15 19:13, Pablo de Lara: > > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > [...] > > -Quit to prompt in Linux or reboot on Baremetal:

[dpdk-dev] [PULL REQUEST] doc: document modifications in user guides

2014-12-04 Thread Iremonger, Bernard
Hi Thomas, > Hi Bernard, > > These patches won't pulled as is for 2 reasons: > 1) I made some comments recently on some of these patches Clearly I was too eager to apply these patches. Are you happy with of the patches, if so I could a send a request pull with a reduced patch set > 2) It

[dpdk-dev] [PATCH] enic: fix warnings

2014-12-04 Thread Sujith Sankar (ssujith)
On 02/12/14 8:29 pm, "Thomas Monjalon" wrote: >A lot of warnings were not seen because $(WERROR_FLAGS) was not set >in the Makefile. But they appear with toolchains that enforce more checks. > >-Wno-deprecated seems useless. >-Wno-strict-aliasing is added to avoid false positives. > >This

[dpdk-dev] [PATCH 1/2] eal: detect endianness

2014-12-04 Thread Qiu, Michael
On 12/4/2014 5:01 PM, Thomas Monjalon wrote: > 2014-12-04 02:28, Qiu, Michael: >> On 12/4/2014 5:26 AM, Thomas Monjalon wrote: >>> There is no standard to check endianness. >>> So we need to try different checks. >>> Previous trials were done in testpmd (see commits >>> 51f694dd40f56 and

[dpdk-dev] [PATCH v2] Fix two compile issues with i686 platform

2014-12-04 Thread Qiu, Michael
On 12/4/2014 5:05 PM, Thomas Monjalon wrote: > 2014-12-04 02:49, Qiu, Michael: >> On 12/3/2014 11:40 PM, Richardson, Bruce wrote: >>> On Wed, Dec 03, 2014 at 04:10:23PM +0800, Michael Qiu wrote: lib/librte_eal/linuxapp/eal/eal_memory.c:324:4: error: comparison is always false due to

[dpdk-dev] [PATCH v5 2/3] mbuf:add three TX ol_flags and repalce PKT_TX_VXLAN_CKSUM

2014-12-04 Thread Ananyev, Konstantin
Hi Helin, > -Original Message- > From: Zhang, Helin > Sent: Thursday, December 04, 2014 6:52 AM > To: Olivier MATZ; Ananyev, Konstantin; Liu, Jijiang; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH v5 2/3] mbuf:add three TX ol_flags and repalce > PKT_TX_VXLAN_CKSUM > > > > >

[dpdk-dev] [PATCH] i40e: Fix a vlan bug

2014-12-04 Thread Qiu, Michael
Hi Mark, I think Huawei (huawei.xie at intel.com) has one patch set to fix this issue. If your patch is totally different with him: [dpdk-dev] [PATCH v4 0/2] lib/librte_pmd_i40e: set vlan filter fix please ignore my comments :) But you both calculation are different. Thanks, Michael On

[dpdk-dev] [PATCH v2] Fix two compile issues with i686 platform

2014-12-04 Thread Thomas Monjalon
2014-12-04 02:49, Qiu, Michael: > On 12/3/2014 11:40 PM, Richardson, Bruce wrote: > > On Wed, Dec 03, 2014 at 04:10:23PM +0800, Michael Qiu wrote: > >> lib/librte_eal/linuxapp/eal/eal_memory.c:324:4: error: comparison > >> is always false due to limited range of data type [-Werror=type-limits] >

[dpdk-dev] [PATCH 1/2] eal: detect endianness

2014-12-04 Thread Thomas Monjalon
2014-12-04 02:28, Qiu, Michael: > On 12/4/2014 5:26 AM, Thomas Monjalon wrote: > > There is no standard to check endianness. > > So we need to try different checks. > > Previous trials were done in testpmd (see commits > > 51f694dd40f56 and 64741f237cf29) without full success. > > This one is not

[dpdk-dev] [PATCH] Fix KNI compiling issue on IBM Power

2014-12-04 Thread Neil Horman
On Thu, Dec 04, 2014 at 12:59:31PM +0100, Thomas Monjalon wrote: > > Because of different cache line size, the alignment of struct > > rte_kni_mbuf in rte_kni_common.h doesn't work on IBM Power. This patch > > changed from 64 to RTE_CACHE_LINE_SIZE micro to do the alignment. > > > >

[dpdk-dev] [PATCH v5 2/3] mbuf:add three TX ol_flags and repalce PKT_TX_VXLAN_CKSUM

2014-12-04 Thread Liu, Jijiang
Hi Helin, > -Original Message- > From: Zhang, Helin > Sent: Thursday, December 4, 2014 2:52 PM > To: Olivier MATZ; Ananyev, Konstantin; Liu, Jijiang; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH v5 2/3] mbuf:add three TX ol_flags and repalce > PKT_TX_VXLAN_CKSUM > > > > >

[dpdk-dev] [PATCH v2] add one option memory-only for secondary processes

2014-12-04 Thread Chi, Xiaobo (NSN - CN/Hangzhou)
Hi, Hiroshi, Yes, you are right, in order to avoid such problem, while create the mempool, which shall be shared between the primary process and those secondary Processes, we need to assign the cache_size param value to be zero. And in order to make the system more stable, it's better to define

[dpdk-dev] [PATCH v5 2/3] mbuf:add three TX ol_flags and repalce PKT_TX_VXLAN_CKSUM

2014-12-04 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier MATZ > Sent: Wednesday, December 3, 2014 10:42 PM > To: Ananyev, Konstantin; Liu, Jijiang; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 2/3] mbuf:add three TX ol_flags and repalce >

[dpdk-dev] Next Community Call, Tuesday 2nd December, 8:00 AM GMT

2014-12-04 Thread Neil Horman
On Wed, Dec 03, 2014 at 11:07:10PM +, O'driscoll, Tim wrote: > Hi Olga, > > > Can you please send the presentations from last Community Call. > > We have Tetsuya's presentation, if we can also get other presentations it > > will > > be great > > No problem. Changchun's slides on the

[dpdk-dev] [question] DPDK-2.0 support broadcom driver

2014-12-04 Thread Qiu, Michael
On 12/4/2014 3:18 AM, Thomas Monjalon wrote: > 2014-12-03 10:04, Stephen Hemminger: >> On Wed, 3 Dec 2014 09:48:57 +0800 >> "Zhang Haoyu" wrote: >>> I see that broadcom driver will be supported in DPDK-2.0 from >>> DPDK roadmap(http://dpdk.org/dev/roadmap), >>> any details about the progress? >>

[dpdk-dev] [PATCH v2] Fix two compile issues with i686 platform

2014-12-04 Thread Qiu, Michael
On 12/3/2014 11:40 PM, Richardson, Bruce wrote: > On Wed, Dec 03, 2014 at 04:10:23PM +0800, Michael Qiu wrote: >> lib/librte_eal/linuxapp/eal/eal_memory.c:324:4: error: comparison >> is always false due to limited range of data type [-Werror=type-limits] >> || (hugepage_sz == RTE_PGSIZE_16G))

[dpdk-dev] [PATCH] test-pmd: Fix pointer aliasing error

2014-12-04 Thread Qiu, Michael
On 12/3/2014 11:36 PM, Richardson, Bruce wrote: > On Wed, Dec 03, 2014 at 03:19:34PM +, Qiu, Michael wrote: >> On 2014/12/3 22:51, Richardson, Bruce wrote: >>> On Wed, Dec 03, 2014 at 01:59:58PM +, Qiu, Michael wrote: On 2014/12/3 19:43, Richardson, Bruce wrote: > On Wed, Dec 03,

[dpdk-dev] [PATCH 1/2] eal: detect endianness

2014-12-04 Thread Qiu, Michael
On 12/4/2014 5:26 AM, Thomas Monjalon wrote: > There is no standard to check endianness. > So we need to try different checks. > Previous trials were done in testpmd (see commits > 51f694dd40f56 and 64741f237cf29) without full success. > This one is not guaranteed to work everywhere so it could >

[dpdk-dev] [PATCH v5 2/3] mbuf:add three TX ol_flags and repalce PKT_TX_VXLAN_CKSUM

2014-12-04 Thread Liu, Jijiang
Hi Olivier, > -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Wednesday, December 3, 2014 10:42 PM > To: Ananyev, Konstantin; Liu, Jijiang; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 2/3] mbuf:add three TX ol_flags and repalce >

[dpdk-dev] [PATCH] test-pmd: Fix pointer aliasing error

2014-12-04 Thread Dayu Qiu
Hi Olivier, You can check gcc manual. -fstrict-aliasing Allow the compiler to assume the strictest aliasing rules applicable to the language being compiled. For C (and C++), this activates optimizations based on the type of expressions. In particular, an object