> Subject: Re: [dpdk-dev] mk: fix app linking for combined libs
>
> 2014-12-08 09:53, Neil Horman:
> > On Thu, Oct 23, 2014 at 04:36:44PM +0100, Sergio Gonzalez Monroy wrote:
> > > Building combined shared libraries results in applications being linked
> > > against separeted/individual and
My DPDK application works fine when it's the primary process but crashes
whenever --proc-type=secondary. The segmentation fault occurs in this call
to mmap() within rte_eal_hugepage_attach():
/*
* fdzero is mmapped to get a contiguous block of virtual
* addresses of the
From: Stephen Hemminger
Refactor the logic to compute receive offload flags to a simpler
function. Andd add support for putting RSS flow hash into packet.
Signed-off-by: Stephen Hemminger
Signed-off-by: Bill Hong
---
lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 69
From: Stephen Hemminger
By defining macro as a stub it is possible to get rid of #ifdef's
in the actual code.
Signed-off-by: Stephen Hemminger
---
lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h | 6 --
lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 9 +
2 files changed,
From: Stephen Hemminger
This patch is a bugfx.
The Intel version of VMXNET3 driver does not handle link state properly.
The VMXNET3 API returns 1 if connected and 0 if disconnected.
Also need to return correct value to indicate state change.
Signed-off-by: Stephen
From: Stephen Hemminger
Change sending loop to support multi-segment mbufs.
The VMXNET3 api has start-of-packet and end-packet flags, so it
is not hard to send multi-segment mbuf's.
Also, update descriptor in 32 bit value rather than toggling
bitfields which is slower and
From: Stephen Hemminger
VMXNET3 supports configuring filter table in host.
Signed-off-by: Stephen Hemminger
---
lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 107 +---
lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h | 2 +-
This set of patches updates the vmxnet3 in the DPDK to match
the features in the driver I wrote. The most important critical
feature is support for multi-segment jumbo frames.
Stephen Hemminger (7):
vmxnet3: add support for VLAN filtering
vmxnet3: remove mtu check
vmxnet3: add support for
2014-10-28 15:48, Sergio Gonzalez Monroy:
> If we set EXTRA_CFLAGS=-O0, build fails with following error:
>
> /usr/bin/ld: test: hidden symbol `mknod' in
> /usr/lib64/libc_nonshared.a(mknod.oS) is referenced by DSO
>
> Fix: link combined shared lib using CC if LINK_USING_CC is enabled.
>
>
On Fri, 31 Oct 2014 15:53:19 -0700 (PDT)
Thomas Monjalon wrote:
> Hi,
>
> Talks related to DPDK can be proposed for FOSDEM 2015:
> https://fosdem.org/2015/
> This conference will take place in Belgium on 31 January & 1 February.
>
Did DPDK make it in the schedule or not?
Cristian, this patch is about packet framework.
Could you review it please?
2014-12-12 17:06, Mark Wunderlich:
> The existing lookup function was returning an unmodified
> pkts_mask bitmask into lookup_hit_mask. This effectively
> assumes that all packets would index correctly into one
> of the
Hi Jay,
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jay Rolette
> Sent: Thursday, December 11, 2014 4:06 PM
> To: Dev
> Subject: [dpdk-dev] [PATCH] replaced O(n^2) sort in sort_by_physaddr() with
> qsort() from standard library
>
> Signed-off-by: Jay
2014-12-15 17:13, Declan Doherty:
> -v2:
> Incorporates Pawel's comments regarding assertion's check on activate_slave
> array indexing
Changelog should be below three dashes to be excluded from git history.
> Fixes for link bonding library identified by static analysis tool
>
> - Overflow
Hi Pablo,
On 12/15/2014 02:41 PM, Pablo de Lara wrote:
> Enqueue and dequeue burst functions always return a positive
> value (including 0), so return type should be unsigned,
> instead of int.
>
> Fixed also API doc for one of the functions.
>
> Signed-off-by: Pablo de Lara
Acked-by: Olivier
(2014/12/16 17:47), Thomas Monjalon wrote:
> 2014-12-16 17:44, Tetsuya Mukawa:
>> I've updated the null PMD to apply it to latest DPDK.
>> Also I've sent a port hotplug patch for null PMD.
> As explained in http://dpdk.org/dev#send, do not hesitate to
> use --annotate to add this kind of changelog
I've updated the null PMD to apply it to latest DPDK.
Also I've sent a port hotplug patch for null PMD.
Thanks,
Tetsuya
(2014/12/16 17:39), Tetsuya Mukawa wrote:
> 'null PMD' is a driver of the virtual device particulary designed to measure
> performance of DPDK PMDs. When an application call
The patch is for adding port hotplug funcion to null PMD.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_pmd_null/rte_eth_null.c | 32
1 file changed, 32 insertions(+)
diff --git a/lib/librte_pmd_null/rte_eth_null.c
b/lib/librte_pmd_null/rte_eth_null.c
index
'null PMD' is a driver of the virtual device particulary designed to measure
performance of DPDK PMDs. When an application call rx, null PMD just allocates
mbufs and returns those. Also tx, the PMD just frees mbufs.
The PMD has following options.
- size: specify packe size allocated by RX.
2014-12-12 12:15, Ouyang Changchun:
> The following commit break vm2vm hard mode test cases:
> commit db4014f2b65cb31bf209cadd5bcec778ca137fe2
> Author: Huawei Xie
> Date: Thu Nov 13 06:34:07 2014 +0800
> examples/vhost: use factorized default Rx/Tx configuration
>
> Investigation show
Hi
When building 1.7.1 or 1.8.0-rc4 on recent CentOS 6 (6.6) I got this error:
In file included from
/home/makerpm/rpmbuild/BUILD/dpdk-1.8.0/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41,
from
At error app_acl_init() can return without freeing dynamically allocated memory.
Not really a big problem, as if app_acl_init() fails,
then application would terminate immediately anyway.
Though it is a good coding practise to make a function to cleanup after itself.
Signed-off-by: Konstantin
2014-12-08 09:53, Neil Horman:
> On Thu, Oct 23, 2014 at 04:36:44PM +0100, Sergio Gonzalez Monroy wrote:
> > Building combined shared libraries results in applications being linked
> > against separeted/individual and combined libs altogether.
> >
> > Link only against combined lib when the
On Tue, Dec 16, 2014 at 02:39:44PM +, Bruce Richardson wrote:
> The port mask parsing in testpmd allowed up to 64 bits to be processed,
> even if RTE_MAX_ETHPORTS is set to a max of 32. Fix this by only
> processing up to min(RTE_MAX_ETHPORTS,64) bits of the mask.
>
> Signed-off-by: Bruce
On Tue, Dec 16, 2014 at 03:39:56PM +0100, Thomas Monjalon wrote:
> 2014-12-16 08:58, Neil Horman:
> > On Tue, Dec 16, 2014 at 12:04:44AM +0100, Thomas Monjalon wrote:
> > > Some applications doesn't have the pcap link flag
> > > when shared libraries are enabled.
> > > Indeed in such case, pcap
On Tue, Dec 16, 2014 at 08:46:51AM -0800, Ravi Kerur wrote:
> On Sat, Dec 13, 2014 at 2:39 AM, Neil Horman wrote:
> >
> > On Fri, Dec 12, 2014 at 03:04:34PM -0800, r k wrote:
> > > Subject: [PATCH] Minor fixes in rte_common.h file.
> > >
> > > Fix rte_is_power_of_2 since 0 is not.
> > > Avoid
Switch the order of the conditions in a while loop, so we check the
range of "i" against the max, before using it to index into the array.
Signed-off-by: Bruce Richardson
---
lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The cleanup code on error checks for *internals being NULL only after
using the pointer to perform other cleanup. Fix this by moving the
clean-up based on the pointer inside the check for NULL.
Signed-off-by: Bruce Richardson
---
lib/librte_pmd_af_packet/rte_eth_af_packet.c | 15 ---
A further three small patches fixing more issues highlighted by static
analysis scans.
Bruce Richardson (3):
af_packet: ensure *internals is not null when dereferencing
ixgbe: prevent array overflow access in vector driver
eal: for safety, use snprintf instead of sprintf
On X710, performance number is far from the expectation on recent
firmware versions. The fix for this issue may not be integrated in
the following firmware version. So the workaround in software driver
is needed. It needs to modify the initial values of 3 internal only
registers. Note that the
2014-12-11 13:27, Jincheng Miao:
> RHEL6.5 kernel is based on 2.6.32. But there are two changing
> from 2.6.35:
> 1. socket struct is changed
> It wrappered previous wait_queue_head_t of socket to
> struct socket_wq. So for the kernel older than 2.6.35, we should
> directly use socket->wait
2014-12-16 08:58, Neil Horman:
> On Tue, Dec 16, 2014 at 12:04:44AM +0100, Thomas Monjalon wrote:
> > Some applications doesn't have the pcap link flag
> > when shared libraries are enabled.
> > Indeed in such case, pcap PMD must not be linked but pcap library should.
> >
> > Actually -lpcap is
The check for NULL is in the wrong position in the "if" error leg. The
pointer should be checked for NULL before checking what the value of
what the pointer points to is.
Signed-off-by: Bruce Richardson
---
examples/vm_power_manager/channel_manager.c | 2 +-
The length of the path to a unix socket is not PATH_MAX but instead is
UNIX_PATH_MAX which is generally just over 100 bytes in size. It's not
actually defined in sys/un.h on linux - despite the man page referencing
it, so calculate the size in the case where it's not defined.
Signed-off-by: Bruce
If mbuf allocation failed for whatever reason, we would get a NULL
pointer exception in test_table_acl.c:test_pipeline_single_filter test
case.
We fix this by causing an early break out of the application loop. If we
quit the test immediately we would leak any existing allocated mbufs,
but by
In the kvargs test cases, we were checking for errors by checking if the
returned pointer value was NULL. In the error handling, we then tried to
free back the NULL pointer, which would cause a crash.
Signed-off-by: Bruce Richardson
---
app/test/test_kvargs.c | 3 ---
1 file changed, 3
This patch set fixes 5 issues found during a static analysis scan of the latest
DPDK code. These fixes are for possible NULL pointer references and array
overflow/underflow.
Bruce Richardson (5):
test: after NULL check, don't free the NULL pointer
test: check for mbuf alloc failure
Added new and existing names of sample apps to list of
sample apps in release notes.
Signed-off-by: Siobhan Butler
---
doc/guides/rel_notes/rel_description.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/rel_notes/rel_description.rst
Removed resolved issues from known issues section.
Added new resolved issues to resolved issues section.
Signed-off-by: Siobhan Butler
---
doc/guides/rel_notes/known_issues.rst| 225 ---
doc/guides/rel_notes/resolved_issues.rst | 173 +++-
2
Removing Appendix A from Release Notes as Intel Licensing information is
no longer relevant in this document.
Signed-off-by: Siobhan Butler
---
doc/guides/rel_notes/appendices.rst | 324
doc/guides/rel_notes/index.rst | 44 -
2 files changed, 368
Signed-off-by: Siobhan Butler
---
doc/guides/rel_notes/resolved_issues.rst | 30 ++
1 file changed, 30 insertions(+)
diff --git a/doc/guides/rel_notes/resolved_issues.rst
b/doc/guides/rel_notes/resolved_issues.rst
index f9ddb7f..5e88005 100644
---
Signed-off-by: Siobhan Butler
---
doc/guides/rel_notes/new_features.rst | 17 -
doc/guides/rel_notes/supported_features.rst | 22 ++
2 files changed, 22 insertions(+), 17 deletions(-)
diff --git a/doc/guides/rel_notes/new_features.rst
New Features section:
- Removed 1.7 New Features
- Added 1.8.0 New Features
Supported Features section:
- Added 1.7 features to Supported Features
Known Issues:
- Added devices to Known issue "Not all varients of supported NIC types have
been used in testing"
- Removed known issue
2014-12-16 13:27, Bruce Richardson:
> The port mask parsing in testpmd allowed up to 64 bits to be processed,
> even if RTE_MAX_ETHPORTS is set to a max of 32. Fix this by only
> processing up to min(RTE_MAX_ETHPORTS,64) bits of the mask.
[...]
> - for (i = 0; i < 64; i++) {
> + for (i =
The port mask parsing in testpmd allowed up to 64 bits to be processed,
even if RTE_MAX_ETHPORTS is set to a max of 32. Fix this by only
processing up to min(RTE_MAX_ETHPORTS,64) bits of the mask.
Signed-off-by: Bruce Richardson
---
V2: changed to use RTE_MIN in comparison, instead of double
The port mask parsing in testpmd allowed up to 64 bits to be processed,
even if RTE_MAX_ETHPORTS is set to a max of 32. Fix this by only
processing up to min(RTE_MAX_ETHPORTS,64) bits of the mask.
Signed-off-by: Bruce Richardson
---
app/test-pmd/config.c | 2 +-
1 file changed, 1 insertion(+),
Actually, I just relooked at the email I sent and it looks correct
(properly indented, etc.). Any suggestions for what might be going on?
On Tue, Dec 16, 2014 at 1:18 PM, Jay Rolette wrote:
>
> Thanks Konstantin. Yes, I'll resend. Not sure why gmail is removing
> whitespace when I sent in Plain
Thanks Konstantin. Yes, I'll resend. Not sure why gmail is removing
whitespace when I sent in Plain Text mode.
Ultimately I'll need to figure out how to properly configure git to send
these directly instead of handling them more manually. The examples I saw
assumed you were using a gmail.com
Signed-off-by: Reshma Pattan
---
doc/guides/linux_gsg/quick_start.rst | 64 ++---
1 files changed, 35 insertions(+), 29 deletions(-)
diff --git a/doc/guides/linux_gsg/quick_start.rst
b/doc/guides/linux_gsg/quick_start.rst
index 089dddb..a99b8fa 100644
---
Hi Declan,
2014-12-16 11:15, Declan Doherty:
> - Split transmit hashing function into separate functions to reduce branching
> and to make code clearer.
> - Add IPv4 IHL parameters to rte_ip.h
> - Fixed VLAN tag support in hashing functions and add support for TCP
> in layer 4 header hashing.
> -Original Message-
> From: Doherty, Declan
> Sent: Tuesday, December 16, 2014 12:16 PM
> To: dev at dpdk.org
> Cc: Wodkowski, PawelX; Doherty, Declan
> Subject: [PATCH] bond: vlan flags misinterpreted in xmit_slave_hash function
>
> - Split transmit hashing function into separate
(2014/12/11 6:37), Huawei Xie wrote:
> deals with vhost user memory map/unmap alignment
>
> Signed-off-by: Huawei Xie
> ---
> lib/librte_vhost/rte_virtio_net.h | 2 +
> lib/librte_vhost/vhost-net.h | 2 -
> lib/librte_vhost/vhost_user/vhost-net-user.h | 3 +-
>
2014-12-16 10:00, Sujith Sankar:
> On 16/12/14 1:21 pm, "Qiu, Michael" wrote:
> >On 12/16/2014 12:13 PM, Sujith Sankar (ssujith) wrote:
> >> On 16/12/14 4:54 am, "Thomas Monjalon"
> >> wrote:
> >>> 2014-12-12 13:48, Sujith Sankar:
> This patch corrects the usage of the flag VFIO_PRESENT in
- Split transmit hashing function into separate functions to reduce branching
and to make code clearer.
- Add IPv4 IHL parameters to rte_ip.h
- Fixed VLAN tag support in hashing functions and add support for TCP
in layer 4 header hashing.
- Fixed incorrect flag set in test application packet
There were two static functions called "parse_item_list" in testpmd app.
Since one was a superset of the functionality of the other, we can
collapse the two calls down into a single one, shared between the two
C files.
Signed-off-by: Bruce Richardson
---
app/test-pmd/cmdline.c| 2 +-
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Tuesday, December 16, 2014 4:37 PM
> To: Zhang, Helin
> Cc: dev at dpdk.org; Rowden, Aaron F; Chen, Jing D
> Subject: Re: [dpdk-dev] [PATCH v3] i40e: workaround for X710 performance
> issues
>
>
Removed redundant legal blurb from FreeBSD GSG
Signed-off-by: Siobhan Butler
---
doc/guides/freebsd_gsg/index.rst | 38 --
1 file changed, 38 deletions(-)
diff --git a/doc/guides/freebsd_gsg/index.rst b/doc/guides/freebsd_gsg/index.rst
index f84c2f8..1b4cd3b
Use RTE_EXEC_ENV_BSDAPP in common files for code specific to BSD and
!RTE_EXEC_ENV_BSDAPP for Linux.
Signed-off-by: Ravi Kerur
---
lib/librte_eal/bsdapp/eal/Makefile| 6 ++--
lib/librte_eal/common/eal_common_alarm.c | 40
This patch is RFC for moving EAL source files into common directory.
Currently eal_alarm.c, eal_interrupts.c and eal_debug.c are moved.
Please let me know if this approach makes sense.
Ravi Kerur (2):
Move EAL source files into common directory.
Makefile changes for moved files.
Updated the FreeBSD GSG to remove redundant Intel references.
Signed-off-by: Siobhan Butler
---
doc/guides/freebsd_gsg/build_dpdk.rst | 78 +--
doc/guides/freebsd_gsg/build_sample_apps.rst | 40 +++---
doc/guides/freebsd_gsg/install_from_ports.rst | 28
On 16/12/14 4:06 pm, "Burakov, Anatoly" wrote:
>> -Original Message-
>> From: Sujith Sankar (ssujith) [mailto:ssujith at cisco.com]
>> Sent: Tuesday, December 16, 2014 10:34 AM
>> To: Burakov, Anatoly; Thomas Monjalon
>> Cc: dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] enic:
> -Original Message-
> From: Sujith Sankar (ssujith) [mailto:ssujith at cisco.com]
> Sent: Tuesday, December 16, 2014 10:34 AM
> To: Burakov, Anatoly; Thomas Monjalon
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT
>
>
>
> On 16/12/14
On 16/12/14 3:52 pm, "Burakov, Anatoly" wrote:
>> On 16/12/14 4:54 am, "Thomas Monjalon"
>> wrote:
>>
>> >2014-12-12 13:48, Sujith Sankar:
>> >> This patch corrects the usage of the flag VFIO_PRESENT in enic
>>driver.
>> >
>> >Please, could you explain why the flag VFIO_PRESENT was not well
> On 16/12/14 4:54 am, "Thomas Monjalon"
> wrote:
>
> >2014-12-12 13:48, Sujith Sankar:
> >> This patch corrects the usage of the flag VFIO_PRESENT in enic driver.
> >
> >Please, could you explain why the flag VFIO_PRESENT was not well used?
>
> Without including eal_vfio.h, VFIO_PRESENT is not
On Tue, Dec 16, 2014 at 09:26:48AM +, Chi, Xiaobo (NSN - CN/Hangzhou) wrote:
> Hi, Bruce,
> How about this patch, can it be merged to master branch? Thanks.
>
> Brgs,
> Chi Xiaobo
>
At this point, I think we are well past code-freeze for new features for 1.8,
but this looks a good candidate
On 16/12/14 1:21 pm, "Qiu, Michael" wrote:
>On 12/16/2014 12:13 PM, Sujith Sankar (ssujith) wrote:
>> On 16/12/14 4:54 am, "Thomas Monjalon"
>>wrote:
>>
>>> 2014-12-12 13:48, Sujith Sankar:
This patch corrects the usage of the flag VFIO_PRESENT in enic driver.
>>> Please, could you
On Tue, Dec 16, 2014 at 01:50:06PM +, Bruce Richardson wrote:
> On Tue, Dec 16, 2014 at 02:40:09PM +0100, Thomas Monjalon wrote:
> > 2014-12-16 13:27, Bruce Richardson:
> > > The port mask parsing in testpmd allowed up to 64 bits to be processed,
> > > even if RTE_MAX_ETHPORTS is set to a max
> -Original Message-
> From: Zhang, Helin
> Sent: Tuesday, December 16, 2014 4:23 PM
> To: dev at dpdk.org
> Cc: Chen, Jing D; Wu, Jingjing; Liu, Jijiang; Cao, Waterman; Lu, Patrick;
> Rowden, Aaron F; Zhang, Helin
> Subject: [PATCH v3] i40e: workaround for X710 performance issues
>
>
On Sun, Dec 14, 2014 at 06:10:59PM +, Konstantin Ananyev wrote:
> Signed-off-by: Konstantin Ananyev
> ---
> lib/librte_acl/rte_acl_osdep_alone.h | 47
> ++--
> 1 file changed, 45 insertions(+), 2 deletions(-)
>
> diff --git
> -Original Message-
> From: Doherty, Declan
> Sent: Monday, December 15, 2014 6:14 PM
> To: dev at dpdk.org
> Cc: Wodkowski, PawelX; Doherty, Declan
> Subject: [PATCH v2] bond: static analysis issues fix
>
> -v2:
> Incorporates Pawel's comments regarding assertion's check on
On Sat, Dec 13, 2014 at 2:39 AM, Neil Horman wrote:
>
> On Fri, Dec 12, 2014 at 03:04:34PM -0800, r k wrote:
> > Subject: [PATCH] Minor fixes in rte_common.h file.
> >
> > Fix rte_is_power_of_2 since 0 is not.
> > Avoid branching instructions in RTE_MAX and RTE_MIN.
> >
> > Signed-off-by: Ravi
Hi Helin,
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Helin Zhang
> Sent: Monday, December 15, 2014 3:56 PM
> To: dev at dpdk.org
> Cc: Rowden, Aaron F
> Subject: [dpdk-dev] [PATCH v2] i40e: workaround for X710 performance
> issues
>
> As the fixes of
2014-12-12 13:48, Sujith Sankar:
> This patch corrects the usage of the flag VFIO_PRESENT in enic driver.
Please, could you explain why the flag VFIO_PRESENT was not well used?
> This has uncovered a few warnings, and this patch corrects those too.
[...]
> --- a/lib/librte_pmd_enic/enic_main.c
>
72 matches
Mail list logo