I tested against DPDK 1.7.0, 1.8.0 and trunk(?ed2547b6).?
> From: yuzhichang_scl at hotmail.com
> To: dev at dpdk.org
> Subject: RE: ACL lookup doesn't work for some schemes
> Date: Sun, 15 Feb 2015 17:23:53 +0800
>
> Sorry I forgot to attach the sample code
ttp://dpdk.org/ml/archives/dev/attachments/20150215/1553d3ad/attachment-0001.zip>
Hi,I noticed that ACL lookup doesn't work for some schemes.1. If the first
field is not uint8_t, even all fields are wildcard, lookup doesn't find the
matching rule. See acl_8last.c.2. I prepended a uint8_t field, keep other
fields be wildcard, lookup returns the correct result. See
> > In loopback mode, it's expected force link up even when there's no cable
> > connect.
> > But in codes, setup_sfp() rewrites the related register.
> > It causes in the case 'multispeed_fiber', it can't link up without cable
> > connect.
> >
> > Signed-off-by: Cunming Liang
> Acked-by:
> > Function to get rx/tx port configuration from the PMDs was added in
> > previous release to simplify the port configuration in all sample apps,
> > but testpmd was not modified.
> >
> > This patch makes testpmd get the default rx/tx port configuration, but
> > still uses the parameters passed
> > Testpmd has the capability of changing the forwarding cores and ports in
> > runtime.
> > If these are changed when forwarding, two issues may be encountered:
> >
> > - If "show config fwd" is used, changes made in the core list are applied.
> > Therefore, trying to stop forwarding may hang
> > Ring threshold parameters an RX/TX queue (pthresh, wthresh and hthresh)
> > had an incorrect range of values shown in help command line.
> >
> > Signed-off-by: Pablo de Lara
> >
> Acked-by: Sergio Gonzalez Monroy
Applied, thanks
> > Several parameters were being parsed twice in testpmd, so this patch gets
> > rid of the second parsing.
> >
> > Signed-off-by: Pablo de Lara
> >
> Acked-by: Sergio Gonzalez Monroy
Applied, thanks
> > the port number type should be consistent with librte_cmdline,
> > else there is potential endian issue.
> >
> > Signed-off-by: Xuelin Shi
>
> Acked-by: Olivier Matz
Applied, thanks
The following changes since commit ed2547b68fb0b47d2b17ce6a16a5b8f299b0ead4:
pci: fix max VFs for non igb_uio drivers (2015-02-13 14:48:16 +0100)
are available in the git repository at:
helin at dpdk.org:dpdk-i40e-next.git master
for you to fetch changes up to
The patch add unit test for the new eal option "--lcores".
Signed-off-by: Cunming Liang
---
It depends on the previous patch which enabling EAL "--lcores" option.
http://dpdk.org/ml/archives/dev/2015-February/013204.html
app/test/test_eal_flags.c | 95
Structure rte_flex_filter is removed.
Following APIs are removed:
- rte_eth_dev_add_flex_filter
- rte_eth_dev_remove_flex_filter
- rte_eth_dev_get_flex_filter
Signed-off-by: Jingjing Wu
---
lib/librte_ether/rte_ethdev.c | 51 -
lib/librte_ether/rte_ethdev.h | 89
Following commands of flex filter are removed:
- add_flex_filter (port_id) len (len_value) bytes (bytes_string) mask
(mask_value)
priority (prio_value) queue (queue_id)
- remove_flex_filter (port_id) index (idx)
- get_flex_filter (port_id) index (idx)
New command is added for flex
This patch defines flex filter type RTE_ETH_FILTER_FLEXIBLE and its structure
rte_eth_flex_filter.
Signed-off-by: Jingjing Wu
---
lib/librte_ether/rte_eth_ctrl.h | 20
1 file changed, 20 insertions(+)
diff --git a/lib/librte_ether/rte_eth_ctrl.h
v2 changes:
- split one patch to patch series
- change the command's format in testpmd.
- add doc changes in testpmd_funcs.rst
- correct the errors reported by checkpatch.pl
The patch set uses new filter_ctrl API to replace old flex filter APIs.
It uses new functions and structure to replace
Allow to setup timers only for EAL (lcore) threads (__lcore_id < MAX_LCORE_ID).
E.g. ? dynamically created thread will be able to reset/stop timer for lcore
thread,
but it will be not allowed to setup timer for itself or another non-lcore
thread.
rte_timer_manage() for non-lcore thread would
Add a sched_yield() syscall if the thread spins for too long, waiting other
thread to finish its operations on the ring.
That gives pre-empted thread a chance to proceed and finish with ring
enqnue/dequeue operation.
The purpose is to reduce contention on the ring. By ring_perf_test, it doesn't
ring debug stat won't take care non-EAL thread.
Signed-off-by: Cunming Liang
---
v6 changes:
rollback v5 changes
v5 changes:
check __lcore_id with LCORE_ID_ANY instead of RTE_MAX_LCORE
lib/librte_ring/rte_ring.h | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff
For non-EAL thread, bypass per lcore cache, directly use ring pool.
It allows using rte_mempool in either EAL thread or any user pthread.
As in non-EAL thread, it directly rely on rte_ring and it's none preemptive.
It doesn't suggest to run multi-pthread/cpu which compete the rte_mempool.
It will
In non-EAL thread, lcore_id alrways be LCORE_ID_ANY.
It cann't be used as unique id for recursive spinlock.
Then use rte_gettid() to replace it.
Signed-off-by: Cunming Liang
---
lib/librte_eal/common/include/generic/rte_spinlock.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
For those none EAL thread, *_lcore_id* shall always be LCORE_ID_ANY.
The libraries using *_lcore_id* as index need to take care.
*_socket_id* always be SOCKET_ID_ANY unitl the thread changes the affinity
by rte_thread_set_affinity()
Signed-off-by: Cunming Liang
---
v5 changes:
define
For those non-EAL thread, *_lcore_id* is invalid and probably larger than
RTE_MAX_LCORE.
The patch adds the check and allows only EAL thread using EAL per thread log
level and log type.
Others shares the global log level.
Signed-off-by: Cunming Liang
---
lib/librte_eal/common/eal_common_log.c
Add check for rte_socket_id(), avoid get unexpected return like (-1).
By using rte_malloc_socket(), socket id is assigned by socket_arg.
If socket_arg set to SOCKET_ID_ANY, it expects to use the socket id to which
the current cores belongs.
As the thread may affinity on a cpuset, the cores in the
Some macro already been defined by freebsd 'sys/param.h'.
Signed-off-by: Cunming Liang
---
v5 changes:
rename the redefined MACRO instead of undefine them
lib/librte_pmd_enic/enic.h | 4 ++--
lib/librte_pmd_enic/enic_compat.h | 2 +-
lib/librte_pmd_enic/vnic/vnic_dev.c | 6
EAL threads use assigned cpuset to set core affinity during startup.
It keeps 1:1 mapping, if no '--lcores' option is used.
Signed-off-by: Cunming Liang
---
v5 changes:
add return check for dump_affinity
call rte_thread_set_affinity() directly during EAL thread set
The rte_gettid() wraps the linux and freebsd syscall gettid().
It provides a persistent unique thread id for the calling thread.
It will save the unique id in TLS on the first time.
Signed-off-by: Cunming Liang
---
lib/librte_eal/bsdapp/eal/eal_thread.c | 9 +
Signed-off-by: Cunming Liang
---
lib/librte_eal/bsdapp/eal/eal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index 69f3c03..cb11b5c 100644
--- a/lib/librte_eal/bsdapp/eal/eal.c
+++
The API works for both EAL thread and none EAL thread.
When calling rte_thread_set_affinity, the *_socket_id* and
*_cpuset* of calling thread will be updated if the thread
successful set the cpu affinity.
Signed-off-by: Cunming Liang
---
v5 changes:
refine code of rte_thread_set_affinity()
1. add two TLS *_socket_id* and *_cpuset*
2. add two internal API, eal_cpu_socket_id/eal_thread_dump_affinity
3. add two public API, rte_thread_set/get_affinity
4. update EAL version map for EAL public API
Signed-off-by: Cunming Liang
---
v7 changes:
update version map for EAL public API and
It defines eal_cpu_socket_id() which exposing the origin private
cpu_socket_id().
The function is only used inside EAL. It returns socket_id of the specified
cpu_id.
Signed-off-by: Cunming Liang
---
v7 changes:
reword comments
v5 changes:
expose cpu_socket_id as eal_cpu_socket_id for
The problem is that strnlen() here may return invalid value with 32bit icc.
(actually it returns it?s second parameter,e.g: sysconf(_SC_ARG_MAX)).
It starts to manifest hwen max_len parameter is > 2M and using icc ?m32 ?O2 (or
above).
Suggested-by: Konstantin Ananyev
Signed-off-by: Cunming
It supports one new eal long option '--lcores' for EAL thread cpuset assignment.
The format pattern:
--lcores='lcores[@cpus]<,lcores[@cpus]>'
lcores, cpus could be a single digit/range or a group.
'(' and ')' are necessary if it's a group.
If not supply '@cpus', the value of cpus uses the
Signed-off-by: Cunming Liang
---
lib/librte_eal/bsdapp/eal/eal_memory.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal_memory.c
b/lib/librte_eal/bsdapp/eal/eal_memory.c
index 65ee87d..33ebd0f 100644
---
The patch adds 'cpuset' into per-lcore configure 'lcore_config[]',
as the lcore no longer always 1:1 pinning with physical cpu.
The lcore now stands for a EAL thread rather than a logical cpu.
It doesn't change the default behavior of 1:1 mapping, but allows to
affinity the EAL thread to multiple
This driver implements DPDK driver that has the same functionality
as net-front driver in Linux kernel.
Signed-off-by: Stephen Hemminger
---
v2 -- no changes
config/common_linuxapp| 6 +
lib/Makefile | 1 +
lib/librte_pmd_xen/Makefile |
New uio helper kernel driver for Xen netfront UIO poll
mode driver.
Signed-off-by: Stephen Hemminger
---
v2 -- use PMD_REGISTER
lib/librte_eal/linuxapp/Makefile | 3 +
lib/librte_eal/linuxapp/xen_uio/Makefile | 55 ++
lib/librte_eal/linuxapp/xen_uio/xen_uio.c | 837
Allow overriding default Xen DOM0 behavior to
use physical addresses insted of mfn
Signed-off-by: Stephen Hemminger
---
v2 -- no changes
lib/librte_eal/common/eal_common_options.c | 5 +
lib/librte_eal/common/eal_internal_cfg.h | 1 +
lib/librte_eal/common/eal_options.h| 2 ++
It is possible to passthrough a PCI device when running in Xen
Paravirt mode. The device driver has to accomodate by using
memory zones differently. This patch models the memory allocation
for ENIC device based on changes already done for ixgbe and igb.
Build tested only; has not been tested on
The previous code would only allow building library and application
so that it ran on Xen DOM0 or not on DOM0. This changes that to
a runtime flag.
Signed-off-by: Stephen Hemminger
---
v2 -- fix i40e as well
lib/librte_eal/common/include/rte_memory.h | 4 +++
On Sun, 15 Feb 2015 04:07:21 +
"Liu, Jijiang" wrote:
> Hi Stephen,
>
> What do you mean ' allow choosing dom0 support at runtime'?
> If you mean user can choose DPDK to run Xen Dom0 or not on DOM0 by a runtime
> flag, I don't think your change can achieve this goal.
>
> Thanks
> Jijiang
On Sun, Feb 15, 2015 at 12:43:03AM +, Liang, Cunming wrote:
> Hi,
>
> > -Original Message-
> > From: Neil Horman [mailto:nhorman at tuxdriver.com]
> > Sent: Saturday, February 14, 2015 1:57 AM
> > To: Liang, Cunming
> > Cc: dev at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v6 12/19]
Hi,
> -Original Message-
> From: Qiu, Michael
> Sent: Sunday, February 15, 2015 2:59 PM
> To: Liang, Cunming; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1] test: add ut for eal flags --lcores
>
> Hi, Steve
>
> Why not post this patch within your enabling EAL "--lcores" option
Hi, Steve
Why not post this patch within your enabling EAL "--lcores" option patch
set?
As it is not merged yet.
Just a suggestion, depends you.
Thanks,
Michael
On 2/15/2015 1:48 PM, Cunming Liang wrote:
> The patch add unit test for the new eal option "--lcores".
>
> Signed-off-by: Cunming
Tested-by: min.cao
Patch name: [PATCH 0/2] enable SRIOV switch in i40e driver
Test Flag: Tested-by
Tester name:min.cao at intel.com
Result summary: total 1 cases, 1 passed, 0 failed
Test Case 1:
Name:
Stephen,
Saw your patch. Will take a look.
Thanks,
-Sujith
On 15/02/15 11:43 am, "Sujith Sankar (ssujith)" wrote:
>Hi Stephen, David,
>
>I agree with you and shall submit this change.
>
>Thanks,
>-Sujith
>
>On 09/02/15 9:41 pm, "Stephen Hemminger"
>wrote:
>
>>Agree it should not use printf.
Test by: min.cao
Patch name: [PATCH 0/2] enable SRIOV switch in i40e driver
Test Flag: Tested-by
Tester name:min.cao at intel.com
Result summary: total 1 cases, 1 passed, 0 failed
Test Case 1:
Name: packet
> -Original Message-
> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
> Sent: Friday, February 13, 2015 5:23 PM
> To: dev at dpdk.org
> Cc: Ananyev, Konstantin; Liu, Jijiang; Zhang, Helin; olivier.matz at 6wind.com
> Subject: [PATCH v3 00/20] enhance tx checksum offload API
>
>
Hi Stephen, David,
I agree with you and shall submit this change.
Thanks,
-Sujith
On 09/02/15 9:41 pm, "Stephen Hemminger"
wrote:
>Agree it should not use printf.
>If you insist on keeping the useless message then it should be log level
>debug
> -Original Message-
> From: Zhang, Helin
> Sent: Wednesday, February 04, 2015 3:16 PM
> To: dev at dpdk.org
> Cc: Wu, Jingjing; Cao, Waterman; Zhang, Helin
> Subject: [PATCH v2 0/7] unified flow types and RSS offload types
>
> It unifies the flow types and RSS offload types for all
Hi Stephen,
What do you mean ' allow choosing dom0 support at runtime'?
If you mean user can choose DPDK to run Xen Dom0 or not on DOM0 by a runtime
flag, I don't think your change can achieve this goal.
Thanks
Jijiang Liu
> -Original Message-
> From: dev [mailto:dev-bounces at
Hi,
> -Original Message-
> From: Olivier MATZ [mailto:olivier.matz at 6wind.com]
> Sent: Friday, February 13, 2015 6:06 PM
> To: Liang, Cunming; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 00/19] support multi-pthread per core
>
> Hi,
>
> On 02/13/2015 02:38 AM, Cunming Liang
> -Original Message-
> From: Neil Horman [mailto:nhorman at tuxdriver.com]
> Sent: Saturday, February 14, 2015 1:55 AM
> To: Olivier MATZ
> Cc: Liang, Cunming; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 04/19] eal: fix wrong strnlen() return
> value in
> 32bit icc
>
> On Fri,
> -Original Message-
> From: Neil Horman [mailto:nhorman at tuxdriver.com]
> Sent: Friday, February 13, 2015 9:52 PM
> To: Liang, Cunming
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 05/19] eal: add support parsing socket_id
> from cpuset
>
> On Fri, Feb 13, 2015 at
> -Original Message-
> From: Olivier MATZ [mailto:olivier.matz at 6wind.com]
> Sent: Friday, February 13, 2015 5:53 PM
> To: Liu, Jijiang; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 4/4] app/testpmd:test NVGRE Tx checksum
> offload
>
> Hi Jijiang,
>
>
> On 02/12/2015 01:45
Hi,
> -Original Message-
> From: Neil Horman [mailto:nhorman at tuxdriver.com]
> Sent: Friday, February 13, 2015 9:58 PM
> To: Liang, Cunming
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 06/19] eal: new TLS definition and API
> declaration
>
> On Fri, Feb 13, 2015 at
Hi,
> -Original Message-
> From: Neil Horman [mailto:nhorman at tuxdriver.com]
> Sent: Saturday, February 14, 2015 1:57 AM
> To: Liang, Cunming
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 12/19] malloc: fix the issue of
> SOCKET_ID_ANY
>
> On Fri, Feb 13, 2015 at
On Sun, Feb 15, 2015 at 01:13:07AM +, Liang, Cunming wrote:
> Hi,
>
> > -Original Message-
> > From: Neil Horman [mailto:nhorman at tuxdriver.com]
> > Sent: Friday, February 13, 2015 9:58 PM
> > To: Liang, Cunming
> > Cc: dev at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v6 06/19]
57 matches
Mail list logo
