[dpdk-dev] [PATCH v3] virtio: Fix crash issue for secondary process

It needs Rx function even in the case of secondary process, and it also needs check if it supports mergeable feature or not. Signed-off-by: Changchun Ouyang --- Changes in v3 -- Extract a function to remove the duplicated codes; Changes in v2: -- Check if it supports mergeable or not for

[dpdk-dev] [PATCH v2 1/5] mbuf: fix clone support when application uses private mbuf data

On 27/03/15 15:17, Olivier MATZ wrote: > Hi Konstantin, > > On 03/27/2015 03:25 PM, Ananyev, Konstantin wrote: >> Hi Olivier, >> >>> -Original Message- >>> From: Olivier MATZ [mailto:olivier.matz at 6wind.com] >>> Sent: Friday, March 27, 2015 1:56 PM >>> To: Ananyev, Konstantin; dev at

[dpdk-dev] [PATCH v3 5/5] eal: Fix uio mapping differences between linuxapp and bsdapp

This patch fixes below. - bsdapp - Use map_id in pci_uio_map_resource(). - Fix interface of pci_map_resource(). - Move path variable of mapped_pci_resource structure to pci_map. - linuxapp - Remove redundant error message of linuxapp. - Remove unused path variable of mapped_pci_resource

[dpdk-dev] [PATCH v3 4/5] eal/bsdapp: Change names of pci related data structure

To merge pci code of linuxapp and bsdapp, this patch changes names like below. - uio_map to pci_map - uio_resource to mapped_pci_resource - uio_res_list to mapped_pci_res_list Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal/eal_pci.c | 24 1 file changed,

[dpdk-dev] [PATCH v3 3/5] eal: Fix memory leaks and needless increment of pci_map_addr

This patch fixes following memory leaks. - When open() is failed, uio_res and fds won't be freed in pci_uio_map_resource(). - When pci_map_resource() is failed but path is allocated correctly, path and fds won't be freed in pci_uio_map_recource(). - When pci_uio_unmap() is called, path should

[dpdk-dev] [PATCH v3 2/5] eal: Close file descriptor of uio configuration

When pci_uio_unmap_resource() is called, a file descriptor that is used for uio configuration should be closed. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v3 1/5] eal: Fix coding style of eal_pci.c and eal_pci_uio.c

This patch fixes coding style of below files in linuxapp and bsdapp. - eal_pci.c - eal_pci_uio.c Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal/eal_pci.c | 24 +--- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 12 2 files changed, 21

[dpdk-dev] [PATCH v3 0/5] Clean up pci uio implementations

This patch set cleans up pci uio implementation. These clean up are for consolidating pci uio implementation of linuxapp and bsdapp, and moving consolidated functions in eal common. Because of above, this patch set tries to implement linuxapp and bsdapp almost same. Actual consolidations will be

[dpdk-dev] [RFC PATCH] eal: rte_rand yields only 62 random bits

On Fri, Mar 27, 2015 at 05:03:02PM -0700, Stephen Hemminger wrote: > I would argue remove rte_rand from DPDK. +1 To paraphrase Donald Knuth, "Random numbers should not be generated [using a function coded] at random." It'd be better to fix libc, or considering that has a slow dev cycle and

[dpdk-dev] FlowDirector Rules for TX packets

Thanks for the answer Cristian, Is there any TX-side packet filtering feature? (or one planned) (I do think it make sense in virtualised environments) Thanks Gal. On Fri, Mar 27, 2015 at 5:20 PM, Dumitrescu, Cristian < cristian.dumitrescu at intel.com> wrote: > Hi Gal, > > No, flow director

[dpdk-dev] [PATCH v2 5/6] eal: Use map_idx in pci_uio_map_resource() of bsdapp to work same as linuxapp

On 2015/03/26 19:41, Iremonger, Bernard wrote: > >> -Original Message- >> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] >> Sent: Thursday, March 26, 2015 2:51 AM >> To: Iremonger, Bernard; dev at dpdk.org >> Cc: Richardson, Bruce; david.marchand at 6wind.com >> Subject: Re: [PATCH v2

[dpdk-dev] [RFC PATCH] eal: rte_rand yields only 62 random bits

I would argue remove rte_rand from DPDK. On Fri, Mar 27, 2015 at 9:38 AM, Sanford, Robert wrote: > Never mind ... I cancel the previous suggestion. After further reading on > RNGs, I believe we should abandon the use of lrand48() and implement our > own RNG based on the so-called KISS family of

[dpdk-dev] [RFC PATCH] eal: rte_rand yields only 62 random bits

Please do this work upstream in glibc rather than in the corner case of DPDK. On Fri, Mar 27, 2015 at 9:38 AM, Sanford, Robert wrote: > Never mind ... I cancel the previous suggestion. After further reading on > RNGs, I believe we should abandon the use of lrand48() and implement our > own RNG

[dpdk-dev] [PATCH] doc: added missing new EAL options in testpmd UG

> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Friday, March 27, 2015 4:50 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] doc: added missing new EAL options in testpmd > UG > > Added information on testpmd user guide > for -l, --lcores and --master-lcore

[dpdk-dev] [PATCH] mbuf: add comment explaining confusing code

> -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Friday, March 27, 2015 4:44 PM > To: Richardson, Bruce > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] mbuf: add comment explaining confusing > code > > On Fri, Mar 27, 2015 at 02:55:27PM +,

[dpdk-dev] [PATCH] doc: added missing new EAL options in testpmd UG

Added information on testpmd user guide for -l, --lcores and --master-lcore options Signed-off-by: Pablo de Lara --- doc/guides/testpmd_app_ug/run_app.rst | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/doc/guides/testpmd_app_ug/run_app.rst

[dpdk-dev] [PATCH] mk: create pdf docs as a separate make target

2015-03-27 14:40, Mcnamara, John: > I acked the patch that introduced this change but we've had a number of > complaints from devs who don't want to or can't correctly install the > (largish) toolchain for PDF generation, or if they do, don't like the > extra time it takes. You forgot to quote my

[dpdk-dev] [RFC PATCH] eal: rte_rand yields only 62 random bits

Never mind ... I cancel the previous suggestion. After further reading on RNGs, I believe we should abandon the use of lrand48() and implement our own RNG based on the so-called KISS family of RNGs originally proposed by the late George Marsaglia. In his excellent paper, "Good Practice in (Pseudo)

[dpdk-dev] [PATCH 1/2] doc: update testpmd guide about csum forward engine

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier Matz > Sent: Thursday, March 19, 2015 4:37 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] doc: update testpmd guide about csum > forward engine > > Document the functions introduced by

[dpdk-dev] [PATCH v2 1/5] mbuf: fix clone support when application uses private mbuf data

Hi Konstantin, On 03/27/2015 03:25 PM, Ananyev, Konstantin wrote: > Hi Olivier, > >> -Original Message- >> From: Olivier MATZ [mailto:olivier.matz at 6wind.com] >> Sent: Friday, March 27, 2015 1:56 PM >> To: Ananyev, Konstantin; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v2 1/5]

[dpdk-dev] [PATCH] mk: create pdf docs as a separate make target

> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, March 27, 2015 3:27 PM > To: Mcnamara, John > Cc: dev at dpdk.org > Subject: Re: [PATCH] mk: create pdf docs as a separate make target > > > NACK > > PDF can already be built with "make

[dpdk-dev] [PATCH] test: Disable strict-aliasing warnings

> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Friday, March 27, 2015 3:46 PM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] test: Disable strict-aliasing warnings > > On Thu, 26 Mar 2015 19:17:35 +

[dpdk-dev] [PATCH v2 2/6] eal: Close file descriptor of uio configuration

On 2015/03/26 19:03, Iremonger, Bernard wrote: > >> -Original Message- >> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] >> Sent: Thursday, March 26, 2015 4:19 AM >> To: Stephen Hemminger >> Cc: Iremonger, Bernard; david.marchand at 6wind.com; dev at dpdk.org >> Subject: Re: [dpdk-dev]

[dpdk-dev] [PATCH v2 1/5] mbuf: fix clone support when application uses private mbuf data

Hi Konstantin, On 03/27/2015 10:07 AM, Olivier MATZ wrote: >> I think that to support ability to setup priv_size on a mempool basis, >> and reserve private space between struct rte_mbuf and rte_mbuf. buf_addr, >> we need to: >> >> 1. Store priv_size both inside the mempool and inside the mbuf.

[dpdk-dev] [PATCH] mbuf: add comment explaining confusing code

On Fri, Mar 27, 2015 at 10:38:41AM -0400, Neil Horman wrote: > On Fri, Mar 27, 2015 at 02:30:50PM +, Bruce Richardson wrote: > > On Fri, Mar 27, 2015 at 10:07:35AM -0400, Neil Horman wrote: > > > On Fri, Mar 27, 2015 at 11:32:38AM +, Bruce Richardson wrote: > > > > On Fri, Mar 27, 2015 at

[dpdk-dev] method to destroy a rte_mempool

Hi, What's the right way to destroy a rte_mempool returned by rte_mempool_create()? I cannot find any such function, could anyone share some hints? Thanks, Tim

[dpdk-dev] [PATCH] mk: create pdf docs as a separate make target

> -Original Message- > From: Mcnamara, John > Sent: Friday, March 27, 2015 2:35 PM > To: dev at dpdk.org > Cc: thomas.monjalon at 6wind.com; Mcnamara, John > Subject: [PATCH] mk: create pdf docs as a separate make target Hi Thomas, I acked the patch that introduced this change but we've

[dpdk-dev] [PATCH v2] virtio: Fix crash issue for secondary process

It needs Rx function even in the case of secondary process, and it also needs check if it supports mergeable feature or not. Signed-off-by: Changchun Ouyang --- Changes in v2: -- Check if it supports mergeable or not for the secondary process. lib/librte_pmd_virtio/virtio_ethdev.c | 7

[dpdk-dev] [PATCH] mk: create pdf docs as a separate make target

This patch separates out the PDF generation from 'make doc' to 'make doc-pdf'. The docs can now be built as follows: make doc make doc-pdf This is to: * Reduce the PDF dependencies for people who only require the Html docs. * Speed up the doc build. Signed-off-by: John

[dpdk-dev] [PATCH] mbuf: add comment explaining confusing code

On Fri, Mar 27, 2015 at 10:07:35AM -0400, Neil Horman wrote: > On Fri, Mar 27, 2015 at 11:32:38AM +, Bruce Richardson wrote: > > On Fri, Mar 27, 2015 at 06:29:56AM -0400, Neil Horman wrote: > > > On Thu, Mar 26, 2015 at 09:14:54PM +, Bruce Richardson wrote: > > > > The logic used in the

[dpdk-dev] [PATCH] doc: update of testpmd user guide

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Helin Zhang > Sent: Monday, March 09, 2015 2:39 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] doc: update of testpmd user guide > > It updated the user guide of testpmd, for the newly supported

[dpdk-dev] [PATCH] virtio: Fix stats issue

Hi Stephen, Thomas, David, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, March 23, 2015 6:42 PM > To: Ouyang, Changchun > Cc: dev at dpdk.org; David Marchand > Subject: Re: [dpdk-dev] [PATCH] virtio: Fix stats issue > > 2015-03-23

[dpdk-dev] [PATCH v2 1/5] mbuf: fix clone support when application uses private mbuf data

Hi Olivier, > -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Friday, March 27, 2015 1:56 PM > To: Ananyev, Konstantin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/5] mbuf: fix clone support when > application uses private mbuf data > > Hi

[dpdk-dev] FlowDirector Rules for TX packets

Hi Gal, No, flow director is just an RX-side packet filtering NIC feature. Regards, Cristian > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Gal Sagie > Sent: Friday, March 27, 2015 10:44 AM > To: > Subject: [dpdk-dev] FlowDirector Rules for TX packets >

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

> > > > Due to increased `struct file's reference counter subsequent call > > > > to `filp_close' does not free the `struct file'. Prepend `fput' call > > > > to decrease the reference counter. > > > > > > > > Signed-off-by: Pavel Boldin > > > > > > Acked-by Huawei Xie > > > > Applied, thanks >

[dpdk-dev] [PATCH] doc: New option for vhost sample

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ouyang Changchun > Sent: Tuesday, March 03, 2015 2:23 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] doc: New option for vhost sample > > Since codes for this new option(--vlan-strip) are already

[dpdk-dev] [PATCH] mbuf: optimize refcnt handling during free

Hi Neil, On 03/27/2015 01:44 PM, Neil Horman wrote: > On Fri, Mar 27, 2015 at 10:48:20AM +, Ananyev, Konstantin wrote: >> >> >>> -Original Message- >>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman >>> Sent: Friday, March 27, 2015 10:26 AM >>> To: Wiles, Keith

[dpdk-dev] [PATCH v4] doc: Update doc for vhost sample

> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John McNamara > Sent: Friday, March 27, 2015 1:20 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v4] doc: Update doc for vhost sample > > From: Ouyang Changchun > > Added some documentation on common issues for the vhost sample

[dpdk-dev] [PATCH] librte_eal: Allow combining --no-huge with -m XXX

Hello Simon, On Mon, Mar 23, 2015 at 3:33 PM, Simon Kagstrom < simon.kagstrom at netinsight.net> wrote: > Useful to run applications in usermode via a test driver. > I would add that this commit removes a constraint on no-huge mode being limited to 64M. > Signed-off-by: Simon Kagstrom > ---

[dpdk-dev] FlowDirector Rules for TX packets

Hello All, I can define drop filter rules for RX packets using FlowDirector. Support for configuring this from CLI is also available using ethtool with the --config-ntuple option I am wondering, does FlowDirector has any support to drop TX packets? (Meaning that i can define rules which are if

[dpdk-dev] [PATCH v4] doc: Update doc for vhost sample

From: Ouyang Changchun Added some documentation on common issues for the vhost sample app and how to resolve them. Signed-off-by: Changchun Ouyang Signed-off-by: John McNamara --- doc/guides/sample_app_ug/vhost.rst | 58 -- 1

[dpdk-dev] [PATCH] mbuf: optimize refcnt handling during free

On Fri, Mar 27, 2015 at 02:10:33PM +0100, Olivier MATZ wrote: > Hi Neil, > > On 03/27/2015 01:44 PM, Neil Horman wrote: > > On Fri, Mar 27, 2015 at 10:48:20AM +, Ananyev, Konstantin wrote: > >> > >> > >>> -Original Message- > >>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of

[dpdk-dev] [PATCH] mbuf: add comment explaining confusing code

On Fri, Mar 27, 2015 at 02:55:27PM +, Bruce Richardson wrote: > On Fri, Mar 27, 2015 at 10:38:41AM -0400, Neil Horman wrote: > > On Fri, Mar 27, 2015 at 02:30:50PM +, Bruce Richardson wrote: > > > On Fri, Mar 27, 2015 at 10:07:35AM -0400, Neil Horman wrote: > > > > On Fri, Mar 27, 2015 at

[dpdk-dev] [PATCH] ethdev: fix crash with multiprocess

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Thursday, March 26, 2015 5:03 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] ethdev: fix crash with multiprocess Acked-by: John McNamara

[dpdk-dev] [PATCH v3] doc: Update doc for vhost sample

From: Ouyang Changchun Add some documentation updates for vhost sample app. Signed-off-by: Changchun Ouyang Signed-off-by: John McNamara --- doc/guides/sample_app_ug/vhost.rst | 55 -- 1 file changed, 47 insertions(+), 8

[dpdk-dev] [PATCH v3] Update doc for vhost sample

V3: Fix for code indentation issue preventing PDF build. Ouyang Changchun (1): doc: Update doc for vhost sample doc/guides/sample_app_ug/vhost.rst | 55 -- 1 file changed, 47 insertions(+), 8 deletions(-) -- 1.8.1.4

[dpdk-dev] [PATCH] table: fix a crash during key8 and key32 overload

> > hash_key8_ext and hash_key32_ext tables allocate cache entries to > > support table overload cases. The crash can occur when cache entry is > > free after use. The problem is with computing the index of the free > > cache entry. The same case for key16 was fixed with earlier patch. > > > >

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

> > Due to increased `struct file's reference counter subsequent call > > to `filp_close' does not free the `struct file'. Prepend `fput' call > > to decrease the reference counter. > > > > Signed-off-by: Pavel Boldin > Acked-by Huawei Xie Applied, thanks (already sent this notification but

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

> > Due to increased `struct file's reference counter subsequent call > > to `filp_close' does not free the `struct file'. Prepend `fput' call > > to decrease the reference counter. > > > > Signed-off-by: Pavel Boldin > > Acked-by Huawei Xie Applied, thanks

[dpdk-dev] [PATCH v3] lib/librte_vhost: update used->idx when allocation of mbuf fails

> >> When failed to malloc buffer from mempool we just update last_used_idx > >> but not used->idx so after many times vhost thought have handle all packets > >> but virtio_net thought vhost have not handle all packets and will not > >> update > >> avail->idx. > >> > >> Signed-off-by: Linhaifeng

[dpdk-dev] [PATCH v2] librte_pmd_bond: remove memory alloc for rte_pci_driver

> > eth_driver already contains rte_pci_driver data structure. > > Allocating rte_pci_driver without referencing it after bond > > creation causes memory leakage. > > > > Added signed off information. > > > > Signed-off-by: Jia Yu > > Acked-by: Declan Doherty Applied, thanks

[dpdk-dev] [PATCH] mlx4: remove old VMware compatibility code

> > CONFIG_RTE_LIBRTE_MLX4_COMPAT_VMWARE has no effect since this option enables > > MLX4_PMD_COMPAT_VMWARE. This macro is not used by the PMD which expects > > MLX4_COMPAT_VMWARE instead. > > > > Because this option does not work and the related code is no longer useful > > for VMware (as it

[dpdk-dev] [PATCH v2 2/2] test: fix strict aliasing rule error in link bonding mode 4 test

Fix strict aliasing rule error seen in gcc 4.4 Signed-off-by: Pawel Wodkowski --- app/test/test_link_bonding_mode4.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c index c35129f..02380f9 100644

[dpdk-dev] [PATCH v2 1/2] test: fix strict aliasing rule error in virtual pmd

Fix strict aliasing rule error seen in gcc 4.4 Signed-off-by: Pawel Wodkowski --- app/test/virtual_pmd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c index 9b07ab1..f163562 100644 --- a/app/test/virtual_pmd.c +++

[dpdk-dev] [PULL REQUEST] i40e: removel of switch flag of ALLOW_LB from VF VSI, and bug fix for FD

2015-03-26 09:31, Helin Zhang: > helin at dpdk.org:dpdk-i40e-next.git master [...] > Jingjing Wu (2): > i40e: remove ALLOW_LB flag on SRIOV vsi > i40e: zero local variable > > lib/librte_pmd_i40e/i40e_ethdev.c | 17 +++-- > 1 file changed, 11 insertions(+), 6

[dpdk-dev] [PATCH] i40e: remove ALLOW_LB flag on SRIOV vsi

> > Disable VEB switching by removing ALLOW_LB on SRIOV vsi. > > > > If the source mac address of packet sent from VF is not listed in the VEB's > > mac > > table, the VEB will switch the packet back to the VF. > > It's a hardware issue. Enabling ALLOW_LB flag will block VF functions. > > > >

[dpdk-dev] [PATCH] ixgbe: fix the issue second 5tuple filter overwrites the first one

> > This patch corrects the index to fix the issue that is second 5tuple > > filter > > overwrites the first one. > > > > Signed-off-by: Jingjing Wu > > Acked-by: Marvin Liu Fixes: 4c54a7e7bd42 ("ixgbe: migrate ntuple filter to new API") Applied, thanks

[dpdk-dev] [PATCH] e1000: modify mac type checking before flex filter is programmed

2015-03-26 05:08, Liu, Yong: > From: Wu, Jingjing > > This patch changes MAC_TYPE_FILTER_SUP to MAC_TYPE_FILTER_SUP_EXT in > > flex filter handling function. It will remove NIC 82576 from flex filter > > support. > > > > Signed-off-by: Jingjing Wu > > Acked-by: Marvin Liu Fixes: 231d43909a31

[dpdk-dev] [PATCH] mbuf: add comment explaining confusing code

On Fri, Mar 27, 2015 at 06:29:56AM -0400, Neil Horman wrote: > On Thu, Mar 26, 2015 at 09:14:54PM +, Bruce Richardson wrote: > > The logic used in the condition check before freeing an mbuf is > > sometimes confusing, so explain it in a proper comment. > > > > Signed-off-by: Bruce Richardson

[dpdk-dev] [PATCH] ethdev: fix crash with multiprocess

2015-03-26 17:36, De Lara Guarch, Pablo: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > > The data structure for the rx and tx callbacks is local to each process > > since it contains function pointers and cannot be shared between > > different unique binaries.

[dpdk-dev] [PATCH] test: Disable strict-aliasing warnings

2015-03-27 09:29, De Lara Guarch, Pablo: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2015-03-26 19:17, Pablo de Lara: > > > DPDK does not build on gcc 4.4, as it complains due to > > > strict-aliasing rules in virtual_pmd and link_bonding_mode4 tests, > > > with no errors in

[dpdk-dev] [PATCH] mbuf: add comment explaining confusing code

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman > Sent: Friday, March 27, 2015 10:30 AM > To: Richardson, Bruce > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] mbuf: add comment explaining confusing code > > On Thu, Mar 26, 2015 at

[dpdk-dev] [PATCH] mbuf: optimize refcnt handling during free

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman > Sent: Friday, March 27, 2015 10:26 AM > To: Wiles, Keith > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] mbuf: optimize refcnt handling during free > > On Thu, Mar 26, 2015 at 09:00:33PM

[dpdk-dev] [PATCH] mbuf: add comment explaining confusing code

On Fri, Mar 27, 2015 at 02:30:50PM +, Bruce Richardson wrote: > On Fri, Mar 27, 2015 at 10:07:35AM -0400, Neil Horman wrote: > > On Fri, Mar 27, 2015 at 11:32:38AM +, Bruce Richardson wrote: > > > On Fri, Mar 27, 2015 at 06:29:56AM -0400, Neil Horman wrote: > > > > On Thu, Mar 26, 2015 at

[dpdk-dev] [PATCH v2] hash: fix breaking strict-aliasing rules

> > Fix rte_hash_crc() function by making use of uintptr_t variable > > to hold a pointer to data being hashed. In this way, casting uint64_t > > pointer to uint32_t avoided. > > > > Signed-off-by: Yerden Zhumabekov > > Acked-by: Pablo de Lara Applied, thanks

[dpdk-dev] [PATCH] test: Disable strict-aliasing warnings

2015-03-26 19:17, Pablo de Lara: > DPDK does not build on gcc 4.4, as it complains due to > strict-aliasing rules in virtual_pmd and link_bonding_mode4 tests, > with no errors in next gcc versions: Do you mean it's not possible to fix it in the code? You are disabling some checks which may be

[dpdk-dev] [PATCH] test: Disable strict-aliasing warnings

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Friday, March 27, 2015 10:01 AM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] test: Disable strict-aliasing warnings > > 2015-03-27 09:29, De Lara

[dpdk-dev] [PATCH v2 1/5] mbuf: fix clone support when application uses private mbuf data

Hi Konstantin, Thank you for your comments. On 03/27/2015 01:24 AM, Ananyev, Konstantin wrote: > Hi Olivier, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier Matz >> Sent: Thursday, March 26, 2015 4:00 PM >> To: dev at dpdk.org >> Cc:

[dpdk-dev] [PATCH] mbuf: add comment explaining confusing code

On Fri, Mar 27, 2015 at 11:32:38AM +, Bruce Richardson wrote: > On Fri, Mar 27, 2015 at 06:29:56AM -0400, Neil Horman wrote: > > On Thu, Mar 26, 2015 at 09:14:54PM +, Bruce Richardson wrote: > > > The logic used in the condition check before freeing an mbuf is > > > sometimes confusing, so

[dpdk-dev] [PATCH v2] virtio: Fix crash issue for secondary process

2015-03-27 14:35, Ouyang Changchun: > It needs Rx function even in the case of secondary process, and it also needs > check if > it supports mergeable feature or not. > > Signed-off-by: Changchun Ouyang > --- > > Changes in v2: > -- Check if it supports mergeable or not for the secondary

[dpdk-dev] [PATCH] test: Disable strict-aliasing warnings

> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, March 27, 2015 9:20 AM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] test: Disable strict-aliasing warnings > > 2015-03-26 19:17, Pablo de Lara: > >

[dpdk-dev] [PATCH] test: Disable strict-aliasing warnings

> -Original Message- > From: Qiu, Michael > Sent: Friday, March 27, 2015 8:41 AM > To: De Lara Guarch, Pablo; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] test: Disable strict-aliasing warnings > > On 3/27/2015 3:18 AM, Pablo de Lara wrote: > > DPDK does not build on gcc 4.4, as it

[dpdk-dev] [PATCH v2 1/2] test: fix strict aliasing rule error in virtual pmd

On Fri, 27 Mar 2015 11:56:00 +0100 Pawel Wodkowski wrote: > Fix strict aliasing rule error seen in gcc 4.4 > > Signed-off-by: Pawel Wodkowski > --- > app/test/virtual_pmd.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/app/test/virtual_pmd.c

[dpdk-dev] [PATCH] test: Disable strict-aliasing warnings

On Thu, 26 Mar 2015 19:17:35 + Pablo de Lara wrote: > +# Disable warnings of no-strict-aliasing in virtual_pmd > +# and test_link_bonding_mode4 tests > +CFLAGS_virtual_pmd.o += -Wno-strict-aliasing > +CFLAGS_test_link_bonding_mode4.o += -Wno-strict-aliasing > + > There is a way to do it

[dpdk-dev] [PATCH] vhost: Fix Segmentation fault of NULL address

On 3/26/2015 4:29 PM, Linhaifeng wrote: > > On 2015/3/26 15:58, Qiu, Michael wrote: >> On 3/26/2015 3:52 PM, Xie, Huawei wrote: >>> On 3/26/2015 3:05 PM, Qiu, Michael wrote: Function gpa_to_vva() could return zero, while this will lead a Segmentation fault. This patch is to fix

[dpdk-dev] [PATCH] mbuf: optimize refcnt handling during free

On Fri, Mar 27, 2015 at 10:48:20AM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman > > Sent: Friday, March 27, 2015 10:26 AM > > To: Wiles, Keith > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev]

[dpdk-dev] [PATCH] test: Disable strict-aliasing warnings

On 3/27/2015 3:18 AM, Pablo de Lara wrote: > DPDK does not build on gcc 4.4, as it complains due to Why? Will gcc 4.4 not supported? Thanks, Michael > strict-aliasing rules in virtual_pmd and link_bonding_mode4 tests, > with no errors in next gcc versions: > > CC virtual_pmd.o > CC

[dpdk-dev] [PATCH v2] ixgbe: fix ixgbe access endian issue on bigendian arch

Hi, Please see my comments inline. Thanks, Xuelin > -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.ananyev at intel.com] > Sent: Friday, March 27, 2015 09:04 > To: Shi Xuelin-B29237; thomas.monjalon at 6wind.com > Cc: dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH

[dpdk-dev] [PATCH v2] virtio: Fix crash issue for secondary process

On 3/27/2015 2:35 PM, Ouyang, Changchun wrote: > It needs Rx function even in the case of secondary process, and it also needs > check if > it supports mergeable feature or not. > > Signed-off-by: Changchun Ouyang > --- > > Changes in v2: > -- Check if it supports mergeable or not for the

[dpdk-dev] Symmetric RSS Hashing, Part 2

On Mar 26, 2015, at 10:30 PM, Zhang, Helin wrote: > Hi guys > > Did you guys talk about symmetric hash in software or in hardware? > > If about hardware, I have one comment. > I40e supports symmetric hash by hardware, which was enabled in i40e PMD > recently. You can have a try. > > Regards,

[dpdk-dev] [PATCH] mbuf: optimize refcnt handling during free

On Thu, Mar 26, 2015 at 09:00:33PM +, Wiles, Keith wrote: > > > On 3/26/15, 1:10 PM, "Zoltan Kiss" wrote: > > >The current way is not the most efficient: if m->refcnt is 1, the second > >condition never evaluates, and we set it to 0. If refcnt > 1, the 2nd > >condition fails again,

[dpdk-dev] Symmetric RSS Hashing, Part 2

Hi guys Did you guys talk about symmetric hash in software or in hardware? If about hardware, I have one comment. I40e supports symmetric hash by hardware, which was enabled in i40e PMD recently. You can have a try. Regards, Helin > -Original Message- > From: dev [mailto:dev-bounces

[dpdk-dev] [PATCH v2] ixgbe: fix ixgbe access endian issue on bigendian arch

Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of xuelin.shi at > freescale.com > Sent: Tuesday, March 24, 2015 6:34 AM > To: thomas.monjalon at 6wind.com > Cc: dev at dpdk.org; Xuelin Shi > Subject: [dpdk-dev] [PATCH v2] ixgbe: fix ixgbe access endian

[dpdk-dev] [PATCH v2 1/5] mbuf: fix clone support when application uses private mbuf data

Hi Olivier, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier Matz > Sent: Thursday, March 26, 2015 4:00 PM > To: dev at dpdk.org > Cc: zoltan.kiss at linaro.org > Subject: [dpdk-dev] [PATCH v2 1/5] mbuf: fix clone support when application > uses