On Fri, May 01, 2015 at 12:49:51PM -0700, Matthew Hall wrote:
> On Fri, May 01, 2015 at 11:09:14AM -0700, Stephen Hemminger wrote:
> > With email, the patches are right in front of developers and easier to quote
> > for review comments.
>
> Right in front of that subset of developers who do
There's been a good discussion on the mailing list on the Beyond DPDK 2.0
thread. To supplement this, we'd like to have a community call for people to
air their views, and to help progress things towards a conclusion. It'll be an
open format, so people can bring up whatever issues they want,
Hi,
On Fri, May 01, 2015 at 12:45:12PM -0400, Neil Horman wrote:
> > - GitHub manages the patches via pull requests and can be easily seen
> > via a web browser.
> > - The down side is you do have to use a web browser to do some work, but
> > the bulk of the everyday work would be done as it
On 5/1/15, 1:48 PM, "Neil Horman" wrote:
>On Fri, May 01, 2015 at 10:31:08AM -0700, Matthew Hall wrote:
>> On Fri, May 01, 2015 at 12:45:12PM -0400, Neil Horman wrote:
>> > Yes, but as you said above, using a web browser doesn't make
>>reviewing patches
>> > faster. In fact, I would assert
Hi Tim,
When were you thinking of having the call?
It's not been explicit, but can I assume that this call will also be
promoted among potential supporters of the project who may not be on
this list? I would be interested to get the perspective from the people
who are perhaps not developers who
On 5/1/15, 1:09 PM, "Stephen Hemminger" wrote:
>On Fri, 1 May 2015 15:56:32 +
>"Wiles, Keith" wrote:
>
>> Hi Everyone,
>>
>> I believe the DPDK community would benefit from moving to GitHub as the
>> primary DPDK site. http://github.com
>>
>> I believe the DPDK community can benefit
On 5/1/15, 11:45 AM, "Neil Horman" wrote:
>On Fri, May 01, 2015 at 03:56:32PM +, Wiles, Keith wrote:
>> Hi Everyone,
>>
>> I believe the DPDK community would benefit from moving to GitHub as the
>> primary DPDK site. http://github.com
>>
>I'm not explicitly opposed to this, but I'm
On 5/1/15, 12:31 PM, "Matthew Hall" wrote:
>Normally I'm a big command-line supporter. However I have found reviewing
>patches by email for me is about the most painful workflow.
>
>The emails are pages and pages.
>
>The replies from commenters are buried in the walls of text.
>
>Replies to
This patch depends on the Port Hotplug Framework.
It implements the eth_dev_uninit_t() function for virtio pmd.
Signed-off-by: Bernard Iremonger
---
lib/librte_pmd_virtio/virtio_ethdev.c | 39 -
1 files changed, 38 insertions(+), 1 deletions(-)
diff --git
Hi Everyone,
I believe the DPDK community would benefit from moving to GitHub as the
primary DPDK site. http://github.com
I believe the DPDK community can benefit from being at a very well know
world wide site. GitHub seems to have the most eyes of any of the open
source Git repos today and it
This patch depends on the Port Hotplug Framework.
It implements the rte_dev_uninit_t() function for the link bonding pmd.
Signed-off-by: Bernard Iremonger
---
lib/librte_pmd_bond/rte_eth_bond.h | 13 -
lib/librte_pmd_bond/rte_eth_bond_api.c | 84
On Fri, May 01, 2015 at 10:31:08AM -0700, Matthew Hall wrote:
> On Fri, May 01, 2015 at 12:45:12PM -0400, Neil Horman wrote:
> > Yes, but as you said above, using a web browser doesn't make reviewing
> > patches
> > faster. In fact, I would assert that it slows the process down, as it
> >
On Fri, May 01, 2015 at 10:59:32PM +0300, Aaro Koskinen wrote:
> Projects like GCC, GLIBC, binutils, busybox, etc or what?
>
> A.
You'll notice all of these are low-level UNIX hacker sorts of tools mostly,
with the partial exception of busybox. But even that is mainly for embedded
use. It
On Fri, May 01, 2015 at 11:09:14AM -0700, Stephen Hemminger wrote:
> With email, the patches are right in front of developers and easier to quote
> for review comments.
Right in front of that subset of developers who do everything kernel-style,
perhaps yes. But this sort of workflow is in the
On Fri, May 01, 2015 at 03:56:32PM +, Wiles, Keith wrote:
> Hi Everyone,
>
> I believe the DPDK community would benefit from moving to GitHub as the
> primary DPDK site. http://github.com
>
I'm not explicitly opposed to this, but I'm having trouble matching up the
technical and governance
On Fri, May 01, 2015 at 03:36:19PM +0100, Bernard Iremonger wrote:
> This patch depends on the Port Hotplug Framework.
> It implements the rte_dev_uninit_t() function for the link bonding pmd.
>
> Signed-off-by: Bernard Iremonger
> ---
> lib/librte_pmd_bond/rte_eth_bond.h | 13 -
>
On Fri, 1 May 2015 15:56:32 +
"Wiles, Keith" wrote:
> Hi Everyone,
>
> I believe the DPDK community would benefit from moving to GitHub as the
> primary DPDK site. http://github.com
>
> I believe the DPDK community can benefit from being at a very well know
> world wide site. GitHub seems
On Fri, May 01, 2015 at 12:45:12PM -0400, Neil Horman wrote:
> Yes, but as you said above, using a web browser doesn't make reviewing patches
> faster. In fact, I would assert that it slows the process down, as it
> prevents
> quick, easy command line access to patch review (as you have with a
On Thu, Apr 30, 2015 at 05:26:57PM +0100, Wiles, Keith wrote:
>
>
> On 4/30/15, 11:24 AM, "Richardson, Bruce"
> wrote:
>
> >On Thu, Apr 30, 2015 at 02:55:47PM +, Wiles, Keith wrote:
> >> What is the NO_AUTOLIB variable used for anyway, the doc states this:
> >>
> >>
> >> * NO_AUTOLIBS:
On Thu, Apr 30, 2015 at 05:33:36PM +0100, Wiles, Keith wrote:
>
>
> On 4/30/15, 11:22 AM, "Richardson, Bruce"
> wrote:
>
> >On Thu, Apr 30, 2015 at 02:31:13PM +, Wiles, Keith wrote:
> >>
> >>
> >> On 4/30/15, 8:38 AM, "Olivier MATZ" wrote:
> >>
> >> >Hi Keith,
> >> >
> >> >On
NO_AUTOLIBS is not required as it was not used or defined in the config files.
Signed-off-by: Keith Wiles
---
mk/rte.app.mk | 5 -
1 file changed, 5 deletions(-)
diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index b8030d2..b63e346 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -54,11 +54,8
Removed the LDLIBS-y reference as it is not required.
Signed-off-by: Keith Wiles
---
doc/build-sdk-quick.txt | 1 +
doc/guides/prog_guide/build_app.rst | 2 +-
doc/guides/prog_guide/dev_kit_build_system.rst | 2 ++
Trying to simplify the ifdefs in rte.app.mk to make the code
more readable and maintainable by moving LDLIBS variable to use
the same style as LDLIBS-y being used in the rest of the code.
Added a new variable called EXTRA_LDLIBS to be used by example apps
instead of using LDLIBS directly. The new
Miscellaneous modifications are added as follows for future use.
- Admin queue command opcodes
- struct i40e_aqc_arp_proxy_data
- struct i40e_aq_set_phy_config
- struct i40e_aqc_nvm_config_data_immediate_field
- struct i40e_aqc_oem_param_change
- struct i40e_aqc_opc_oem_ocsd_initialize
- struct
Several structures as follows were modified for future use.
- struct i40e_link_status
- struct i40e_nvm_info
- struct i40e_veb_tc_stats
In addition, shadow RAM macros and enum were modified for future
use as well.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/i40e/i40e_type.h | 28
Virtual channel operations of I40E_VIRTCHNL_OP_EVENT and
I40E_VIRTCHNL_OP_CONFIG_RSS are added for future use.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/i40e/i40e_virtchnl.h | 41
1 file changed, 20 insertions(+), 21 deletions(-)
v2 changes:
Removed
Make sure the sizeof() calls are taking the size of the actual
struct that we care about. By using the pointer variable, it will
always get the right struct size, even if the variable type
changes sometime in the future.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/i40e/i40e_common.c | 44
When sending driver version to FW, FLAG_SI is not needed as it is
done as part of i40e_fill_default_descriptor function call, and it
should be replaced by FLAG_BUF and FLAG_RD.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/i40e/i40e_common.c | 2 +-
1 file changed, 1 insertion(+), 1
Add parsing and reporting of iSCSI capability for a given device
or function.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/i40e/i40e_common.c | 5 +
lib/librte_pmd_i40e/i40e/i40e_type.h | 1 +
2 files changed, 6 insertions(+)
diff --git a/lib/librte_pmd_i40e/i40e/i40e_common.c
Add the 10G and 40G AOC phy types to the case statement in
get_media_type so that the correct information gets reported back
to the user.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/i40e/i40e_common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
The FW for SW3E is incorrectly reporting a breakout cable as PHY
type 0x3 when it should be 0x16 (I40E_PHY_TYPE_10GBASE_SFPP_CU).
As this is supposed to be fixed in the next FW version
(FW versions >= 4.4), if we get this value back from FW and the
version is < 4.4, reassign it to
In NPAR mode the driver instance might be controlling the base
partition or one of the other "fake" PFs. There are some things
that can only be done by the base partition, aka partition_id 1.
This code does a bit of work to find how many partitions are there
in per port and what is the current
Getting the pf_id from the function number was a good place to
start, but when the PF was setup in pass-thru mode, the PCI
bus/device/function was virtualized and the number in the VM is
different from the number in the bare metal. This caused HW
configuration issues when the wrong pf_id was used
A sparse complaint in i40e_debug_aq in a funky buffer write goes
away by straightening out the code out to something less convoluted.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/i40e/i40e_common.c | 56 ++
1 file changed, 30 insertions(+), 26 deletions(-)
As it is requried to blink the LEDs only, it should ignore the
activity LEDs. Also a fix is added to clear the GPIO blink field
specifically.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/i40e/i40e_common.c | 37 +++---
1 file changed, 34 insertions(+), 3
Four new interfaces are added for future use, as follows, together
with their relevant strucure and macro definitions.
- i40e_aq_read_nvm_config()
- i40e_aq_write_nvm_config()
- i40e_aq_set_lldp_mib()
- i40e_read_pba_string()
In addition, removed i40e_read_nvm_srrd() as needed.
Signed-off-by:
As i40e_update_link_info() is just a simple wrapper of AQ command
interface of i40e_aq_get_link_info(), the AQ command interface
should be used directly.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/i40e/i40e_common.c| 34 ++-
The timeout of ASQ command is enlarged from 100 ms to 250 ms to
wait longer time for the response. nvm_busy is not needed anymore.
Also nvm_release_on_done and nvmupd_state will be set during
adminq init.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/i40e/i40e_adminq.c | 21
The NVM image version has useful data but it is a per image version,
and every image can have a different one. While for the dev starter
version, all the images for release will have the same version. So
it would be better to use dev starter version number.
Signed-off-by: Helin Zhang
---
This patch is useful for future expansion when new VF MAC types get
added. It also helps with cleaning up VF driver flow.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/i40e/i40e_adminq.c | 7 ++-
lib/librte_pmd_i40e/i40e/i40e_type.h | 5 +
2 files changed, 11 insertions(+), 1
Since the FW build number is available in the AQ response, save it
off for future use.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/i40e/i40e_adminq.c| 1 +
lib/librte_pmd_i40e/i40e/i40e_adminq.h| 1 +
lib/librte_pmd_i40e/i40e/i40e_common.c| 4
To support better debug information printing, all DEBUGOUT() are
replaced by i40e_debug(). In addition, the NVM update state strings
are added in debug information.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/Makefile| 1 +
lib/librte_pmd_i40e/i40e/i40e_nvm.c | 77
The data buffer for i40e_calc_nvm_checksum() is too big, so move
it off and allocate separately. In addition, use
i40e_read_nvm_buffer() to get the whole shadow RAM, together with
minor enhancements.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/i40e/i40e_nvm.c | 49
Only poll on the NVM semaphore if there's time left on a previous
reservation.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/i40e/i40e_nvm.c | 35 +--
1 file changed, 17 insertions(+), 18 deletions(-)
diff --git a/lib/librte_pmd_i40e/i40e/i40e_nvm.c
The state transitions after an error were not managed well, so
these changes get us back to the INIT state or don't transit
out of the INIT state after most errors.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/i40e/i40e_nvm.c | 32 ++--
1 file changed, 22
Decoding the AQ return code is great except when the AQ send timed
out and there's no return code set. This changes the handy decoder
interface to help catch and properly report the condition as an
useful error number rather than returning a misleading '0'.
Signed-off-by: Helin Zhang
---
In some circumstances, a multi-write transaction takes longer than
the default 3 minutes timeout on the write semaphore. If the write
failed with an EBUSY status, this is likely the problem. So here
it tries to reacquire the semaphore and then retry the write.
Signed-off-by: Helin Zhang
---
To support different hardware, shadow RAM read should be done via
SRCTL register or AQ command, and shadow RAM write should be done
via AQ command only.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/i40e/i40e_nvm.c | 196 ++--
1 file changed, 190
To simplify the usage of invoking 'i40e_hmc_get_object_va', input
parameters of it were reworked. In addition, minor code style fixes
were added as well.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/i40e/i40e_lan_hmc.c | 31 +--
1 file changed, 13
As base driver provides 'i40e_aq_debug_read_register()', the same
functional interface of 'i40e_debug_read_register()' can be replaced.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/i40e/i40e_common.c| 35 +++
lib/librte_pmd_i40e/i40e/i40e_prototype.h | 3
Recent firmware versions support CEE DCBX, while old firmware
versions support IEEE DCBX only. So firmware version needs to be
checked during getting DCB configurations. To support CEE DCBX,
AQ commands of 'i40e_aq_get_cee_dcb_config' and
'i40e_aq_start_stop_dcbx' were implemented.
Signed-off-by:
Macros of PF_DRIVER, VF_DRIVER and INTEGRATED_VF were defined to
support building both PF and VF driver together. PF_DRIVER needs
to be defined if a build is for PF only, while VF_DRIVER for VF
only. PF_DRIVER, VF_DRIVER and INTEGRATED_VF are all needed for
building both PF and VF driver together.
To be consistent with the original base driver, the variable name
of 'err' should be renamed to 'perrno'.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/i40e/i40e_nvm.c | 118 ++--
1 file changed, 59 insertions(+), 59 deletions(-)
diff --git
Some macros of register definitions or relevant are added, modified
or deleted. In detail, they are as follows.
- I40E_PRTDCB_RUPTQ
- I40E_GLGEN_GPIO_CTL
- I40E_GLGEN_MDIO_CTRL
- I40E_GLGEN_RSTENA_EMP
- I40E_GLPCI_LATCT
- I40E_GLTPH_CTRL
- I40E_GLPRT_BPRCH
- I40E_GLPRT_TDPC
- I40E_GLSCD_QUANTA
There was a known link issue on 40G ports on NVM version (FVL3E),
when setting phy configuration. As a workaround, setting of phy
configuration should be disabled. The impact is that the link cannot
be forcedly configured, which doesn't affect any feature functions.
The workaround can be removed
Copyright is updated.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/Makefile | 2 +-
lib/librte_pmd_i40e/i40e/i40e_adminq.c | 2 +-
lib/librte_pmd_i40e/i40e/i40e_adminq.h | 2 +-
lib/librte_pmd_i40e/i40e/i40e_adminq_cmd.h | 2 +-
lib/librte_pmd_i40e/i40e/i40e_alloc.h
To support firmware version 'FVL3E', i40e base driver should be updated.
Together with necessary modifications to i40e Poll Mode Driver, it mainly
includes the base driver update which contains additional enhancements,
fixes, changes for future use and so on. The details are listed as follows.
v2
57 matches
Mail list logo
