[dpdk-dev] [PATCH v9 01/12] eal: Fix coding style of eal_pci.c and eal_pci_uio.c

2015-07-08 09:09, Stephen Hemminger: > On Wed, 8 Jul 2015 19:34:42 +0900 > Tetsuya Mukawa wrote: > > > diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c > > b/lib/librte_eal/bsdapp/eal/eal_pci.c > > index 2df5c1c..a63d450 100644 > > --- a/lib/librte_eal/bsdapp/eal/eal_pci.c > > +++

[dpdk-dev] [PATCH v9 12/12] eal: Consolidate rte_eal_pci_probe/close_one_driver() of linuxapp and bsdapp

From: "Tetsuya.Mukawa" This patch consolidates below functions, and implements these in common eal code. - rte_eal_pci_probe_one_driver() - rte_eal_pci_close_one_driver() Signed-off-by: Tetsuya Mukawa Acked-by: David Marchand --- lib/librte_eal/bsdapp/eal/eal_pci.c|

[dpdk-dev] [PATCH v9 10/12] eal: Consolidate pci uio functions of linuxapp and bsdapp

From: "Tetsuya.Mukawa" The patch consolidates below functions, and implement these in eal_common_pci_uio.c. - pci_uio_map_secondary() - pci_uio_map_resource() - pci_uio_unmap() - pci_uio_find_resource() - pci_uio_unmap_resource() Signed-off-by: Tetsuya Mukawa Acked-by:

[dpdk-dev] [PATCH v9 09/12] eal: Consolidate pci_map/unmap_resource() of linuxapp and bsdapp

From: "Tetsuya.Mukawa" The patch consolidates below functions, and implemented in common eal code. - pci_map_resource() - pci_unmap_resource() Signed-off-by: Tetsuya Mukawa Acked-by: Bernard Iremonger Acked-by: David Marchand --- lib/librte_eal/bsdapp/eal/eal_pci.c

[dpdk-dev] [PATCH v9 08/12] eal: Consolidate pci_map and mapped_pci_resource of linuxapp and bsdapp

From: "Tetsuya.Mukawa" This patch consolidates below structures, and defines them in common code. - struct pci_map - strucy mapped_pci_resouces Signed-off-by: Tetsuya Mukawa Acked-by: Bernard Iremonger Acked-by: David Marchand --- lib/librte_eal/bsdapp/eal/eal_pci.c

[dpdk-dev] [PATCH v9 07/12] eal: Add pci_uio_map_resource_by_index()

From: "Tetsuya.Mukawa" This patch adds a new function called pci_uio_map_resource_by_index(). The function hides how to map uio resource in linuxapp and bsdapp. With the function, pci_uio_map_resource() will be more abstracted. Signed-off-by: Tetsuya Mukawa ---

[dpdk-dev] [PATCH v9 06/12] eal: Add pci_uio_alloc/free_resource()

From: "Tetsuya.Mukawa" This patch adds new functions called pci_uio_alloc_resource() and pci_uio_free_resource(). The functions hides how to prepare or free uio resource in linuxapp and bsdapp. With the function, pci_uio_map_resource() will be more abstracted. Signed-off-by:

[dpdk-dev] [PATCH v9 05/12] eal: Fix uio mapping differences between linuxapp and bsdapp

From: "Tetsuya.Mukawa" This patch fixes below. - bsdapp - Use map_id in pci_uio_map_resource(). - Fix interface of pci_map_resource(). - Move path variable of mapped_pci_resource structure to pci_map. - linuxapp - Remove redundant error message of linuxapp.

[dpdk-dev] [PATCH v9 04/12] eal/bsdapp: Change names of pci related data structure

From: "Tetsuya.Mukawa" To merge pci code of linuxapp and bsdapp, this patch changes names like below. - uio_map to pci_map - uio_resource to mapped_pci_resource - uio_res_list to mapped_pci_res_list Signed-off-by: Tetsuya Mukawa Acked-by: Bernard Iremonger Acked-by:

[dpdk-dev] [PATCH v9 03/12] eal: Fix memory leaks and needless increment of pci_map_addr

From: "Tetsuya.Mukawa" This patch fixes following memory leaks. - When open() is failed, uio_res and fds won't be freed in pci_uio_map_resource(). - When pci_map_resource() is failed but path is allocated correctly, path and fds won't be freed in pci_uio_map_recource().

[dpdk-dev] [PATCH v9 02/12] eal: Close file descriptor of uio configuration

From: "Tetsuya.Mukawa" When pci_uio_unmap_resource() is called, a file descriptor that is used for uio configuration should be closed. Signed-off-by: Tetsuya Mukawa Acked-by: Stephen Hemminger Acked-by: Bernard Iremonger Acked-by: David Marchand ---

[dpdk-dev] [PATCH v9 01/12] eal: Fix coding style of eal_pci.c and eal_pci_uio.c

From: "Tetsuya.Mukawa" This patch fixes coding style of below files in linuxapp and bsdapp. - eal_pci.c - eal_pci_uio.c Signed-off-by: Tetsuya Mukawa Acked-by: Stephen Hemminger Acked-by: David Marchand Acked-by: Bruce Richardson Acked-by: Bernard Iremonger ---

[dpdk-dev] [PATCH v9 00/12] Clean up pci uio implementations

Currently Linux implementation and BSD implementation have almost same code about pci uio. This patch series cleans up it. PATCH v9 changes: - Add lost Acked-by and Tested-by signatures. - Remove NULL checkings before calling rte_free(). - Fix pci_uio_map_secondary() to remove needless

[dpdk-dev] [PATCH v3] mk: enable next abi preview

When a change makes really hard to keep ABI compatibility, instead of waiting next release to break the ABI, it is smoother to introduce the new code as a preview and disable it when packaging. The flag RTE_NEXT_ABI must be used to "ifdef" the new code. When the release is out, a dynamically

[dpdk-dev] FDIR issues when upgrading custom application from dpdk 1.8 to dpdk 2.0

2015-07-08 16:17, Marian Barbu: > Hello, > > I've been working on upgrading a custom dpdk application from dpdk 1.8.0 to > dpdk 2.0.0. > > I want to use FDIR to distribute the traffic based on IP to multiple > queues, but I seem to get -95 (ENOTSUP) error code from > *rte_eth_dev_fdir_set_masks.

[dpdk-dev] [PATCH 1/4] eal: provide functions to access PCI config

2015-07-08 09:11, Stephen Hemminger: > On Wed, 8 Jul 2015 15:04:16 + > Thomas Monjalon wrote: > > > 2015-07-07 17:08, Stephen Hemminger: > > > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > > @@ -98,3 +98,8 @@ DPDK_2.0 {

[dpdk-dev] [PATCH v8 11/12] eal: Consolidate pci_map/unmap_device() of linuxapp and bsdapp

On 2015/07/08 17:27, Thomas Monjalon wrote: > 2015-07-08 11:42, Tetsuya Mukawa: >> On 2015/07/07 17:06, David Marchand wrote: >>> On Mon, Jul 6, 2015 at 8:24 AM, Tetsuya Mukawa >> + /* FreeBSD has only one pass through driver */ >>> + dev->kdrv = RTE_KDRV_NIC_UIO; >>> + >>>

[dpdk-dev] [PATCH v2] test/hash: improve hash unit tests

Add new unit test for calculating the average table utilization, using random keys, based on number of entries that can be added until we encounter one that cannot be added (bucket if full) Also, replace current hash_perf unit test to see performance more clear. The current hash_perf unit test

[dpdk-dev] [PATCH v2] Improve hash unit tests - Cuckoo hash part 2

This patch improves the unit tests for the hash library, showing more readable results, in preparation for the new hash implementation to show performance differences. Changes in v2: - Add missing error check - Simplify average table utilization test - Improve outputs - Fix some typos Pablo de

[dpdk-dev] [PATCH v2] i40e:Fix the Description Done check mechanism for i40e

If the descriptor the device derive is handling is the context descriptor its type will be 0x1, so using the not expression, the device driver will consider the descriptor has been completed for transmission even its DD field is still 0x1 which means NIC has't finished the operation on this

[dpdk-dev] [PATCH] [PATCH] librte_hash: miss parentheses in hash function

In the no-x86 branch, a parentheses is missing. And need to include header to use CHAR_BIT. --- lib/librte_hash/rte_jhash.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_hash/rte_jhash.h b/lib/librte_hash/rte_jhash.h index e230449..f9a8266 100644 ---

[dpdk-dev] Using the testpmd app & ixgbe driver on 540-Twinville, cannot configure rxq > 1

Hello: Couple of questions for the 540-Twinville & "testpmd" app: 1. How do I specify multiple receive queues/port - Used the command line option -rxq=2 and get this error.. *** Fail: nb_rxq(2) is greater than max_rx_queues(1) EAL: Error - exiting with code: 1

[dpdk-dev] [PATCH 1/4] eal: provide functions to access PCI config

2015-07-07 17:08, Stephen Hemminger: > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > @@ -98,3 +98,8 @@ DPDK_2.0 { > > local: *; > }; > + > +DPDK_2.1 { > + rte_eal_pci_read_config; > + rte_eal_pci_write_config;

[dpdk-dev] [PATCH] [PATCH] librte_hash: miss parentheses in hash function

2015-07-08 17:26, Bruce Liu: > In the no-x86 branch, a parentheses is missing. > And need to include header to use CHAR_BIT. Thanks for fixing that. Please, could you submit a v2 with Fixes: and Signed-off-by: lines?

[dpdk-dev] [PATCH v2 2/2] mk: enable next abi preview

When a change makes really hard to keep ABI compatibility, instead of waiting next release to break the ABI, it is smoother to introduce the new code as a preview and disable it when packaging. The flag RTE_NEXT_ABI must be used to "ifdef" the new code. When the release is out, a dynamically

[dpdk-dev] [PATCH v2 1/2] mk: remove variables identical to config ones

CONFIG_RTE_BUILD_SHARED_LIB and CONFIG_RTE_BUILD_COMBINE_LIBS does not have quotes in their values (only y or n). That's why the variables RTE_BUILD_SHARED_LIB and RTE_BUILD_COMBINE_LIBS are always identical to their CONFIG_ counterpart, and are useless. In order to have consistent naming of

[dpdk-dev] [PATCH v2 0/2] next abi option

This is the second version of the NEXT_ABI policy. It can now be used for shared and static libraries. While updating rte.lib.mk, it appeared that some useless (and not consistent) variables were used for some config options. The first patch clean them. Thomas Monjalon (2): mk: remove

[dpdk-dev] [PATCH] pcap: add support for jumbo frames

From: Tero Aho Extend eth_pcap rx and tx to support jumbo frames. On the receive side read large packets into multiple mbufs and on the transmit side convert them back to a single pcap buffer. Signed-off-by: Tero Aho Signed-off-by: John McNamara ---

[dpdk-dev] [PATCH] [PATCH v2] librte_hash: miss parentheses in hash function

On Wed, Jul 08, 2015 at 11:15:47PM +0800, damu wrote: > In the no-x86 branch, a parentheses is missing. > And need to include header to use CHAR_BIT. > > Signed-off-by: Bruce Liu <2103458176 at qq.com> Previously also reported here: http://dpdk.org/dev/patchwork/patch/6105/ Fixes line can be

[dpdk-dev] [PATCH v3 02/12] hash: fix compilation on non-X86 platforms

>-Original Message- >From: Sanford, Robert [mailto:rsanford at akamai.com] >Sent: Tuesday, July 07, 2015 10:52 PM >To: Zhigang Lu; dev at dpdk.org >Subject: Re: [dpdk-dev] [PATCH v3 02/12] hash: fix compilation on non-X86 >platforms > >Hi Zhigang, > >Can you add this one-line X86 change

[dpdk-dev] FDIR issues when upgrading custom application from dpdk 1.8 to dpdk 2.0

Hello, I've been working on upgrading a custom dpdk application from dpdk 1.8.0 to dpdk 2.0.0. I want to use FDIR to distribute the traffic based on IP to multiple queues, but I seem to get -95 (ENOTSUP) error code from *rte_eth_dev_fdir_set_masks. *I mention that this was all working fine with

[dpdk-dev] [PATCH] add rx and tx byte counter statistics for PCAP PMD

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Klaus Degner > Sent: Tuesday, June 30, 2015 12:40 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] add rx and tx byte counter statistics for > PCAP PMD > > PCAP PMD vdev accounts only rx and tx packet

[dpdk-dev] [PATCH] test/hash: improve hash unit tests

On Wed, Jul 08, 2015 at 02:12:06PM +0100, Pablo de Lara wrote: > Add new unit test for calculating the average table utilization, > using random keys, based on number of entries that can be added > until we encounter one that cannot be added (bucket if full) > > Also, replace current hash_perf

[dpdk-dev] DPDK and netfilter functionality

I am new to DPDK, but I have been tasked with researching it's capabilities. One of the things I am trying to understand is how it would interact with some kind of packet capturing application. One of the things I use to grab a packet from the Linux Kernel is using netfilter hooks to get the

[dpdk-dev] [PATCH v3] doc: announce ABI changes planned for unified packet type

Hi Neil Please review it and ack it, if no objections! Thank you very much in advance! - Helin > -Original Message- > From: Zhang, Helin > Sent: Tuesday, July 7, 2015 10:45 AM > To: dev at dpdk.org > Cc: Liu, Jijiang; Wu, Jingjing; nhorman at tuxdriver.com; Zhang, Helin > Subject:

[dpdk-dev] [PATCH] pcap: add support for jumbo frames

> -Original Message- > From: Mcnamara, John > Sent: Wednesday, July 8, 2015 4:53 PM > To: dev at dpdk.org > Cc: maxim.uvarov at linaro.org; Tero Aho; Mcnamara, John > Subject: [PATCH] pcap: add support for jumbo frames > Hi, This patch is a rebase and refactoring of the following

[dpdk-dev] [RFC] vfio: only map regions VFIO supports

The FM10K driver has 3 BARS numbered 0, 4, and 8. But the kernel VFIO driver only allows mapping 0-5 anything bigger than that will return -EINVAL (see kernel source vfio_pci.c:vfio_pci_mmap). The workaround is to limit the DPDK EAL VFIO support only map the regions that will work. The FM10K

[dpdk-dev] [PATCH] test/hash: improve hash unit tests

Hi Bruce, > -Original Message- > From: Richardson, Bruce > Sent: Wednesday, July 08, 2015 4:04 PM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] test/hash: improve hash unit tests > > On Wed, Jul 08, 2015 at 02:12:06PM +0100, Pablo de Lara wrote: > >

[dpdk-dev] [PATCH] test/hash: improve hash unit tests

On Wed, Jul 08, 2015 at 02:12:06PM +0100, Pablo de Lara wrote: > Add new unit test for calculating the average table utilization, > using random keys, based on number of entries that can be added > until we encounter one that cannot be added (bucket if full) > > Also, replace current hash_perf

[dpdk-dev] [PATCH] i40e: fix the build error with gcc 4.4

Fix the build warning reported like: error: dereferencing pointer 'cmd' does break strict-aliasing rules Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git

[dpdk-dev] [PATCH v9 00/12] Clean up pci uio implementations

On Wed, Jul 8, 2015 at 12:34 PM, Tetsuya Mukawa wrote: > Currently Linux implementation and BSD implementation have almost same > code about pci uio. This patch series cleans up it. > > PATCH v9 changes: > - Add lost Acked-by and Tested-by signatures. > - Remove NULL checkings before calling

[dpdk-dev] [PATCH] hash: move rte_hash structure to C file and make it internal

On Wed, Jul 08, 2015 at 12:27:34PM +0100, Pablo de Lara wrote: > rte_hash structure should not be a public structure, > and therefore it should be moved to the C file and be declared > as internal. rte_hash_hash implementation is also moved > to the C file, as it uses the structure. > > This

[dpdk-dev] [PATCH] Improve hash unit tests - Cuckoo hash part 2

This patch improves the unit tests for the hash library, showing more readable results, in preparation for the new hash implementation to show performance differences. Pablo de Lara (1): test/hash: improve hash unit tests app/test/test_hash.c | 61 app/test/test_hash_perf.c | 906

[dpdk-dev] [PATCH v3 7/7] abi: announce mbuf addition for ieee1588 in DPDK 2.2

On Mon, Jul 06, 2015 at 03:16:01PM +0200, Thomas Monjalon wrote: > 2015-07-02 16:16, John McNamara: > > --- a/doc/guides/rel_notes/abi.rst > > +++ b/doc/guides/rel_notes/abi.rst > > Deprecation Notices > > --- > > + > > +* In DPDK 2.1 the IEEE1588/802.1AS support in the i40e

[dpdk-dev] How to prevent KNI interface from getting deleted on application termination?

Hi all, My application takes over one/multiple ethernet port(s) in a linux system and creates KNI interfaces corresponding to them. So if there was eth0 and eth1 in the non-dpdk mode, once I take over the ports using dpdk, I create eth0 and eth1 KNI interfaces. As far as the linux network

[dpdk-dev] [PATCH v2 0/2] next abi option

On Wed, Jul 08, 2015 at 04:55:21PM +0200, Thomas Monjalon wrote: > This is the second version of the NEXT_ABI policy. > It can now be used for shared and static libraries. > > While updating rte.lib.mk, it appeared that some useless > (and not consistent) variables were used for some config >

[dpdk-dev] [PATCH v2] librte_ether: release memory in uninit function.

On 2015/07/07 19:53, Iremonger, Bernard wrote: >> -Original Message- >> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] >> Sent: Tuesday, July 7, 2015 4:38 AM >> To: dev at dpdk.org >> Cc: Qiu, Michael; Iremonger, Bernard; thomas.monjalon at 6wind.com; >> Ananyev, Konstantin; Stephen

[dpdk-dev] [PATCH] hash: move rte_hash structure to C file and make it internal

rte_hash structure should not be a public structure, and therefore it should be moved to the C file and be declared as internal. rte_hash_hash implementation is also moved to the C file, as it uses the structure. This patch also removes part of a unit test that was checking a field of the

[dpdk-dev] [PATCH] Make rte_hash struct internal - Cuckoo hash part 1

First part of the changes for new hash implementation. This patch makes the current public rte_hash structure internal, as it should not be inspected directly by any applications. Pablo de Lara (1): hash: move rte_hash structure to C file and make it internal app/test/test_hash.c | 6

[dpdk-dev] [PATCH 0/6] eal/linux: cleanup hugepage code

On 07/07/2015 10:00, David Marchand wrote: > Here is a little patchset cleaning eal_hugepage_info.c file and fixing a bug > when having more than two hugepage sizes. > No functional change to be expected. > Acked-by: Sergio Gonzalez Monroy

[dpdk-dev] [PATCH] eal: add const in prefetch functions

2015-07-08 10:59, Bruce Richardson: > On Wed, Jul 08, 2015 at 10:51:33AM +0100, Pablo de Lara wrote: > > rte_prefetchX functions included volatile void *p as parameter, > > but the function does not modify it, > > so it should include the const keyword. > > > > Signed-off-by: Pablo de Lara > >

[dpdk-dev] [PATCH v2] librte_ether: release memory in uninit function.

2015-07-08 09:49, Iremonger, Bernard: > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > > On 2015/07/07 19:53, Iremonger, Bernard wrote: > > > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > > >> On 2015/07/06 20:35, Qiu, Michael wrote: > > >>> Hi, all > > >>> > > >>> As we has gap on

[dpdk-dev] [PATCHv4 1/4] rte_compat.h : Clean up some typos

Hi Neil, 2015-06-29 09:59, Neil Horman: > - * int __vsym foo_v20(char *string) > + * int foo_v20(char *string) [...] > -#define BIND_DEFAULT_SYMBOL(b, e, n) __asm__(".symver " RTE_STR(b) > RTE_STR(e) ", "RTE_STR(b)"@@DPDK_"RTE_STR(n)) > +#define BIND_DEFAULT_SYMBOL(b, e, n) __asm__(".symver

[dpdk-dev] [PATCH v8 11/12] eal: Consolidate pci_map/unmap_device() of linuxapp and bsdapp

On 2015/07/07 17:06, David Marchand wrote: > On Mon, Jul 6, 2015 at 8:24 AM, Tetsuya Mukawa > wrote: > > From: "Tetsuya.Mukawa" mailto:mukawa at > igel.co.jp>> > > The patch consolidates below functions, and implemented in common > eal code. > -

[dpdk-dev] [PATCH v8 07/12] eal: Add pci_uio_map_resource_by_index()

On 2015/07/07 17:05, David Marchand wrote: > > > On Mon, Jul 6, 2015 at 8:24 AM, Tetsuya Mukawa > wrote: > > From: "Tetsuya.Mukawa" mailto:mukawa at > igel.co.jp>> > > This patch adds a new function called pci_uio_map_resource_by_index(). > The function

[dpdk-dev] [PATCH v8 06/12] eal: Add pci_uio_alloc_resource()

On 2015/07/07 17:04, David Marchand wrote: > On Mon, Jul 6, 2015 at 8:24 AM, Tetsuya Mukawa > wrote: > > From: "Tetsuya.Mukawa" mailto:mukawa at > igel.co.jp>> > > This patch adds a new function called pci_uio_alloc_resource(). > The function hides how to

[dpdk-dev] [PATCH v8 05/12] eal: Fix uio mapping differences between linuxapp and bsdapp

On 2015/07/07 17:04, David Marchand wrote: > On Mon, Jul 6, 2015 at 8:24 AM, Tetsuya Mukawa > wrote: > > diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c > b/lib/librte_eal/bsdapp/eal/eal_pci.c > index 21d1e66..92d9886 100644 > ---

[dpdk-dev] [PATCH v8 03/12] eal: Fix memory leaks and needless increment of pci_map_addr

On 2015/07/07 17:04, David Marchand wrote: > Hello Tetsuya, > > Little comment below for this patch. > > On Mon, Jul 6, 2015 at 8:24 AM, Tetsuya Mukawa > wrote: > > > diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c > b/lib/librte_eal/bsdapp/eal/eal_pci.c >

[dpdk-dev] [PATCH v8 01/12] eal: Fix coding style of eal_pci.c and eal_pci_uio.c

On 2015/07/07 17:04, David Marchand wrote: > On Mon, Jul 6, 2015 at 8:24 AM, Tetsuya Mukawa > wrote: > > From: "Tetsuya.Mukawa" mailto:mukawa at > igel.co.jp>> > > This patch fixes coding style of below files in linuxapp and bsdapp. > - eal_pci.c >

[dpdk-dev] [PATCH v4 1/4] ethdev: rename rte_eth_vmdq_mirror_conf

On Wed, Jul 08, 2015 at 10:31:15AM +, Mcnamara, John wrote: > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Tuesday, July 7, 2015 3:51 PM > > To: Wu, Jingjing > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v4 1/4]

[dpdk-dev] [PATCH] i40e: fix the build error with gcc 4.4

> > Fix the build warning reported like: > >error: dereferencing pointer 'cmd' does break strict-aliasing rules > > > > Signed-off-by: Jingjing Wu > Acked-by: Wenzhuo Lu Fixes: a4def5edf0fc ("i40e: enable port mirroring") Applied, thanks

[dpdk-dev] [PATCH] eal: add const in prefetch functions

On Wed, Jul 08, 2015 at 10:51:33AM +0100, Pablo de Lara wrote: > rte_prefetchX functions included volatile void *p as parameter, > but the function does not modify it, > so it should include the const keyword. > > Signed-off-by: Pablo de Lara Acked-by: Bruce Richardson

[dpdk-dev] [PATCH] eal: add const in prefetch functions

rte_prefetchX functions included volatile void *p as parameter, but the function does not modify it, so it should include the const keyword. Signed-off-by: Pablo de Lara --- lib/librte_eal/common/include/arch/ppc_64/rte_prefetch.h | 6 +++---

[dpdk-dev] [PATCH v4 1/4] ethdev: rename rte_eth_vmdq_mirror_conf

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, July 7, 2015 3:51 PM > To: Wu, Jingjing > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: rename > rte_eth_vmdq_mirror_conf > > > Additional, about the

[dpdk-dev] [PATCH v2] mempool: improve cache search

On Tue, Jul 07, 2015 at 06:17:05PM +0100, Zoltan Kiss wrote: > > > On 02/07/15 18:07, Ananyev, Konstantin wrote: > > > > > >>-Original Message- > >>From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zoltan Kiss > >>Sent: Wednesday, July 01, 2015 10:04 AM > >>To: dev at dpdk.org >

[dpdk-dev] [PATCH v8 11/12] eal: Consolidate pci_map/unmap_device() of linuxapp and bsdapp

2015-07-08 11:42, Tetsuya Mukawa: > On 2015/07/07 17:06, David Marchand wrote: > > On Mon, Jul 6, 2015 at 8:24 AM, Tetsuya Mukawa > + /* FreeBSD has only one pass through driver */ > > + dev->kdrv = RTE_KDRV_NIC_UIO; > > + > > > > Do we need a new define for this ? > > > >

[dpdk-dev] [PATCH] doc:announce ABI changes planned for struct rte_eth_dev to support up to 1024 queues per port

The significant ABI change of all shared libraries is planned for struct rte_eth_dev to support up to 1024 queues per port which will be taken effect from release 2.2. Signed-off-by: Jijiang Liu --- doc/guides/rel_notes/abi.rst |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff

[dpdk-dev] [PATCH] testpmd: Fix wrong message in testpmd

On Wed, Jul 08, 2015 at 07:16:21AM +, Qiu, Michael wrote: > Any comments? This is a bug fix, not a feature. > > Thanks, > Michael > > On 6/24/2015 3:56 PM, Qiu, Michael wrote: > > When close one port twice, testpmd will give out wrong messagse. > > > > testpmd> port stop 0 > > Stopping

[dpdk-dev] [PATCH] hash: move rte_hash structure to C file and make it internal

On Wed, Jul 08, 2015 at 02:21:42PM +0100, Bruce Richardson wrote: > Irrespective of whether or not we change the underlying hash table > implementation > this looks a good change to me. The rte_hash structure should not be used > directly > by any applications - the APIs all take pointers to the

[dpdk-dev] [PATCH v2] librte_ether: release memory in uninit function.

> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Wednesday, July 8, 2015 4:48 AM > To: Iremonger, Bernard; dev at dpdk.org > Cc: Qiu, Michael; thomas.monjalon at 6wind.com; Ananyev, Konstantin; > Stephen Hemminger; Zhang, Helin; Chen, Jing D; Neil Horman

[dpdk-dev] [PATCH] config: revert the CONFIG_RTE_MAX_QUEUES_PER_PORT to 256

Revert the CONFIG_RTE_MAX_QUEUES_PER_PORT to 256. The previous commit changed the size and the offsets of struct rte_eth_dev, so it is an ABI breakage. I revert it, and will send a deprecation notice for this. Signed-off-by: Jijiang Liu --- config/common_linuxapp |2 +- 1 files changed, 1

[dpdk-dev] [PATCH] ixgbe: fix the issue that auto negotiation for flow control cannot be disabled

There's a parameter "autoneg on|off" in testpmd CLI "set flow_ctrl ...". This parameter is used to enable/disable auto negotiation for flow control. But it's not supported yet. The auto negotiation is enabled by default, we have no way to disable it. This patch lets the parameter "autoneg on|off"

[dpdk-dev] [PATCH 1/4] eal: provide functions to access PCI config

On Wed, 8 Jul 2015 15:04:16 + Thomas Monjalon wrote: > 2015-07-07 17:08, Stephen Hemminger: > > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > @@ -98,3 +98,8 @@ DPDK_2.0 { > > > > local: *; > > }; > > + > >

[dpdk-dev] [PATCH v9 01/12] eal: Fix coding style of eal_pci.c and eal_pci_uio.c

On Wed, 8 Jul 2015 19:34:42 +0900 Tetsuya Mukawa wrote: > diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c > b/lib/librte_eal/bsdapp/eal/eal_pci.c > index 2df5c1c..a63d450 100644 > --- a/lib/librte_eal/bsdapp/eal/eal_pci.c > +++ b/lib/librte_eal/bsdapp/eal/eal_pci.c > @@ -2,6 +2,7 @@ > *

[dpdk-dev] [PATCH] testpmd: Fix wrong message in testpmd

Any comments? This is a bug fix, not a feature. Thanks, Michael On 6/24/2015 3:56 PM, Qiu, Michael wrote: > When close one port twice, testpmd will give out wrong messagse. > > testpmd> port stop 0 > Stopping ports... > Checking link statuses... > Port 0 Link Up - speed 0 Mbps - full-duplex >

[dpdk-dev] [PATCH] doc:announce ABI changes planned for struct rte_eth_dev to support up to 1024 queues per port

On Wed, Jul 08, 2015 at 10:08:25AM +0800, Jijiang Liu wrote: > The significant ABI change of all shared libraries is planned for struct > rte_eth_dev to support up to 1024 queues per port which will be taken effect > from release 2.2. > > Signed-off-by: Jijiang Liu > --- >

[dpdk-dev] [PATCHv4 1/4] rte_compat.h : Clean up some typos

On Wed, Jul 08, 2015 at 11:52:51AM +0200, Thomas Monjalon wrote: > Hi Neil, > > 2015-06-29 09:59, Neil Horman: > > - * int __vsym foo_v20(char *string) > > + * int foo_v20(char *string) > [...] > > -#define BIND_DEFAULT_SYMBOL(b, e, n) __asm__(".symver " RTE_STR(b) > > RTE_STR(e) ",

[dpdk-dev] [PATCH] i40e: fix the build error with gcc 4.4

Hi, > -Original Message- > From: Wu, Jingjing > Sent: Wednesday, July 8, 2015 2:37 PM > To: dev at dpdk.org > Cc: Wu, Jingjing; Lu, Wenzhuo > Subject: [PATCH] i40e: fix the build error with gcc 4.4 > > Fix the build warning reported like: >error: dereferencing pointer 'cmd' does

[dpdk-dev] [PATCH v3] doc: announce ABI changes planned for unified packet type

The significant ABI changes of all shared libraries are planned to support unified packet type which will be taken effect from release 2.2. Here announces that ABI changes in detail. Signed-off-by: Helin Zhang --- doc/guides/rel_notes/abi.rst | 1 + 1 file changed, 1 insertion(+) v2 changes: *

[dpdk-dev] [PATCH v4 1/4] ethdev: rename rte_eth_vmdq_mirror_conf

Thanks for the clarification. Jingjing > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, July 07, 2015 10:51 PM > To: Wu, Jingjing > Cc: dev at dpdk.org; nhorman at tuxdriver.com > Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: rename >

[dpdk-dev] [PATCH v4 4/4] test-pmd: remove call to rte_eth_promiscuous_disable() from detach_port()

> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, July 7, 2015 5:18 PM > To: dev at dpdk.org > Cc: Ouyang, Changchun; Iremonger, Bernard > Subject: [PATCH v4 4/4] test-pmd: remove call to > rte_eth_promiscuous_disable() from detach_port() > > At this point the stop() and

[dpdk-dev] [PATCH 1/3] cxgbe: Fix RX performance for cxgbe PMD.

2015-07-07 22:42, Rahul Lakkireddy: > CXGBE PMD rx allocates a new mbuf everytime, which could lead to performance > hit. Instead, do bulk allocation of mbufs and re-use them. > > Also, simplify the overall rx-handler, and update its logic to fix rx perf. For such change, it would be nice to

[dpdk-dev] [PATCH v2 0/4] extend flow director to support L2_paylod type

> > This patch set extends flow director to support L2_paylod type in i40e > > driver. > > > > v2 change: > > - remove the flow director VF filtering from this patch to avoid breaking > > ABI. > > > > Jingjing Wu (4): > > ethdev: add struct rte_eth_l2_flow to support l2_payload flow type >