[dpdk-dev] Issue with non-scattered rx in ixgbe and i40e when mbuf private area size is odd

2015-07-29 Thread Zhang, Helin
Hi Martin Thank you very much for the good catch! The similar situation in i40e, as explained by Konstantin. As header split hasn't been supported by DPDK till now. It would be better to put the header address in RX descriptor to 0. But in the future, during header split enabling. We may need

[dpdk-dev] [PATCH 1/2] virtio: initialize iopl when device is initialized

2015-07-29 Thread Thomas Monjalon
2015-03-06 08:20, Stephen Hemminger: > The issue is that virtio has no place it can do iopl() and have the IRQ thread > work. It only shows up on real code where application is daemon, not in a toy > demo or test application. > > Right now: > gcc start >rte_virtio_pmd_init >

[dpdk-dev] [PATCH] i40e: fix for ieee15888 with rte_next_abi

2015-07-29 Thread John McNamara
Fixes issue where ieee15888 timestamping doesn't work for the i40e pmd when RTE_ABI_NEXT is enabled. Also refactors repeated ieee15888 flag checking and setting code into a function. Reported-by: Huilong Xu Signed-off-by: John McNamara --- drivers/net/i40e/i40e_rxtx.c | 52

[dpdk-dev] Issue with non-scattered rx in ixgbe and i40e when mbuf private area size is odd

2015-07-29 Thread Ananyev, Konstantin
Hi Martin, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Martin Weiser > Sent: Wednesday, July 29, 2015 4:07 PM > To: Zhang, Helin; olivier.matz at 6wind.com > Cc: dev at dpdk.org > Subject: [dpdk-dev] Issue with non-scattered rx in ixgbe and i40e when

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Thomas Monjalon
2015-07-29 15:09, Zhang, Helin: > From: Gonzalez Monroy, Sergio > > Fixes: 4d4ebca4 ("pci: merge probing and closing functions for linux and > > bsd") > > > > The function rte_eal_pci_probe_one_driver, which calls pci_config_space_set, > > was moved to eal_common_pci.c, but pci_config_space_set

[dpdk-dev] [PATCH 1/2] log: rte_openlog_stream should be void

2015-07-29 Thread Stephen Hemminger
On Tue, 19 May 2015 11:24:03 +0100 Bruce Richardson wrote: > On Fri, Apr 17, 2015 at 08:35:33AM -0700, Stephen Hemminger wrote: > > Function always returned 0 and no one was checking anyway. > > > > Signed-off-by: Stephen Hemminger > > Acked-by: Bruce Richardson > > > --- > >

[dpdk-dev] [PATCH] pci: make rte_pci_probe void

2015-07-29 Thread Stephen Hemminger
On Mon, 20 Apr 2015 15:15:36 +0200 Thomas Monjalon wrote: > 2015-04-14 10:55, Stephen Hemminger: > > Since rte_pci_probe always returns 0 or exits via rte_exit() > > there is no point in having it return a value. > > > > Just make it void > > > > Signed-off-by: Stephen Hemminger > > Seems

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Thomas Monjalon
2015-07-29 15:00, Zhang, Helin: > Hi Thomas > > It was just an implicit declaration of function, when set > CONFIG_RTE_PCI_CONFIG=y, as follows. Nobody else cares about it. Why do we have this config option? Please remove these useless ifdef's. >

[dpdk-dev] Issue with non-scattered rx in ixgbe and i40e when mbuf private area size is odd

2015-07-29 Thread Martin Weiser
Hi Helin, Hi Olivier, we are seeing an issue with the ixgbe and i40e drivers which we could track down to our setting of the private area size of the mbufs. The issue can be easily reproduced with the l2fwd example application when a small modification is done: just set the priv_size parameter in

[dpdk-dev] [PATCH v6] Add toeplitz hash algorithm used by RSS

2015-07-29 Thread Vladimir Medvedkin
Hi Michael, Thanks for comment, it will be fixed in next patch. Regards, Vladimir 2015-07-29 8:01 GMT+03:00 Qiu, Michael : > Hi, Vladimir > > You need also to fix this issue in i686 platform: > > RHEL65_32,2.6.32,4.4.7,14.0.0 > SUSE11SP3_32,3.0.76-0,4.3.4,14.0.0 > > >

[dpdk-dev] [PATCH v2] Add support for pthreads setname.

2015-07-29 Thread Stephen Hemminger
On Tue, 28 Jul 2015 17:51:44 -0700 Ravi Kerur wrote: > This patch adds support for pthread_setname_np on Linux and > pthread_set_name_np on FreeBSD. > > Changes in V2: > Remove config support for max thread name len. > Restrict max thread name len to 16 on Linux and FreeBSD. > Fix checkpatch.pl

[dpdk-dev] [PATCH] lpm: fix extended flag check when adding a "depth small" entry

2015-07-29 Thread Liang, Cunming
On 7/28/2015 5:14 PM, Zhe Tao wrote: > When adding a "depth small" entry, if its extended flag is not set > and its depth is smaller than the one in the tbl24, nothing should > be done otherwise will operate on the wrong memory area. > > Signed-off-by: Zhe Tao > --- > lib/librte_lpm/rte_lpm.c

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Zhang, Helin
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, July 29, 2015 9:06 AM > To: Zhang, Helin > Cc: Gonzalez Monroy, Sergio; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] eal: fix build > > 2015-07-29 15:09, Zhang, Helin: > > From:

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Gonzalez Monroy, Sergio
On 29/07/2015 16:00, Zhang, Helin wrote: > Hi Thomas > > It was just an implicit declaration of function, when set > CONFIG_RTE_PCI_CONFIG=y, as follows. Nobody else cares about it. > > /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_pci.c: In > function

[dpdk-dev] [PATCH 2/2] mlx4: add missing library dependency when compiling in shared library

2015-07-29 Thread Nelio Laranjeiro
librte_pmd_mlx4.so needs to be linked with libiverbs otherwise, the PMD is not able to open Mellanox devices and the following message is printed by testpmd at startup "librte_pmd_mlx4: cannot access device, is mlx4_ib loaded?". Applications dependency on libverbs are moved to be only valid in

[dpdk-dev] [PATCH 1/2] mk: add LDLIBS variable when producing the .so file

2015-07-29 Thread Nelio Laranjeiro
Some .so libraries needs to be linked with external libraries. For that the LDLIBS variable should be present on the link line when those .so files are created. PMD Makefile is responsible for filling the LDLIBS variable with the link to the external library it needs. Signed-off-by: Nelio

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Zhang, Helin
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, July 29, 2015 8:09 AM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] eal: fix build > > 2015-07-29 15:00, Zhang, Helin: > > Hi Thomas > > > > It was just an

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Zhang, Helin
> -Original Message- > From: Gonzalez Monroy, Sergio > Sent: Wednesday, July 29, 2015 8:06 AM > To: Zhang, Helin > Cc: dev at dpdk.org; Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH] eal: fix build > > On 29/07/2015 16:00, Zhang, Helin wrote: > > Hi Thomas > > > > It was just an

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Zhang, Helin
Hi Thomas It was just an implicit declaration of function, when set CONFIG_RTE_PCI_CONFIG=y, as follows. Nobody else cares about it. /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_pci.c: In function ???rte_eal_pci_probe_one_driver???:

[dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering

2015-07-29 Thread Thomas Monjalon
Back on this old patch, it seems justified but nobody agreed. --- a/lib/librte_pmd_virtio/virtio_ethdev.c +++ b/lib/librte_pmd_virtio/virtio_ethdev.c @@ -1288,7 +1288,6 @@ virtio_dev_configure(struct rte_eth_dev *dev) && !vtpci_with_feature(hw, VIRTIO_NET_F_CTRL_VLAN)) {

[dpdk-dev] [PATCH v4] ixgbe: fix data access on big endian cpu.

2015-07-29 Thread xuelin....@freescale.com
From: Xuelin Shi 1. cpu use data owned by ixgbe must use rte_le_to_cpu_xx(...) 2. cpu fill data to ixgbe must use rte_cpu_to_le_xx(...) 3. checking pci status with converted constant Signed-off-by: Xuelin Shi --- changes for v4: fix compiling error: cpu16 to cpu_16

[dpdk-dev] Fwd: OVS with DPDK ..Error packets

2015-07-29 Thread Srikanth Akula
(+DPDK dev team ) Hello , I am trying to test the OVS_DPDK performance and found that lot of packets being treated as error packets . ovs-vsctl get Interface dpdk0 statistics {collisions=0, rx_bytes=38915076374, rx_crc_err=0, rx_dropped=0, *rx_errors=3840287219 <3840287219>, *rx_frame_err=0,

[dpdk-dev] [PATCH] app test: fix eal --no-huge option should work with -m option

2015-07-29 Thread Yong Liu
From: Marvin Liu '--no-huge' option now can workable with -m option. Unit test for eal flag should change pass criterion. Signed-off-by: Marvin Liu diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c index 0352f87..e6f7035 100644 ---

[dpdk-dev] lost when learning how to test dpdk

2015-07-29 Thread ciprian.barbu
On 28.07.2015 21:13, Jan Viktorin wrote: > Hello all, > > I am learning how to measure throughput with dpdk. I have 4 cores > Intel(R) Core(TM) i3-4360 CPU @ 3.70GHz and two 82545GM NICs connected > together. I do not understand very well, how to setup testpmd. http://dpdk.org/doc

[dpdk-dev] [PATCH] app test: fix eal --no-huge option should work with -m option

2015-07-29 Thread Yong Liu
From: Marvin Liu '--no-huge' option now can workable with -m option. Unit test for eal flag should change pass criterion. Signed-off-by: Marvin Liu diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c index 0352f87..e6f7035 100644 ---

[dpdk-dev] [PATCH] app test: fix mempool cache_size not match limited cache_size

2015-07-29 Thread Yong Liu
From: Marvin Liu In previous setting, mempool size and cache_size are both 32. This is not satisfied with cache_size checking rule by now. Cache size should less than CONFIG_RTE_MEMPOOL_CACHE_MAX_SIZE and mempool size / 1.5. Signed-off-by: Marvin Liu diff --git

[dpdk-dev] [PATCH] test-pmd: show pci address in port info

2015-07-29 Thread Thomas Monjalon
2015-07-29 09:05, Michael Qiu: > pci address is one important info for port. > This patch make it visible for port info. > > Signed-off-by: Michael Qiu Maybe you missed this thread: http://dpdk.org/ml/archives/dev/2015-July/022107.html > + if (strncmp(":00:00.0", pci_addr, 12))

[dpdk-dev] ixgbe vPMD RX functions and buffer number minimum requirement

2015-07-29 Thread Zoltan Kiss
Hi, On 28/07/15 01:10, Ananyev, Konstantin wrote: > Hi Zoltan, > >> -Original Message- >> From: Zoltan Kiss [mailto:zoltan.kiss at linaro.org] >> Sent: Monday, July 27, 2015 12:38 PM >> To: Ananyev, Konstantin; Richardson, Bruce; dev at dpdk.org >> Subject: Re: [dpdk-dev] ixgbe vPMD RX

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Thomas Monjalon
2015-07-29 06:48, Helin Zhang: > It fixes the build error of implicit declaration of function. What is the error? Please show the build log and describe the case when it happens (compiler, version).

[dpdk-dev] ixgbe vPMD RX functions and buffer number minimum requirement

2015-07-29 Thread Ananyev, Konstantin
Hi Zoltan, > -Original Message- > From: Zoltan Kiss [mailto:zoltan.kiss at linaro.org] > Sent: Wednesday, July 29, 2015 10:40 AM > To: Ananyev, Konstantin; Richardson, Bruce; dev at dpdk.org > Subject: Re: [dpdk-dev] ixgbe vPMD RX functions and buffer number minimum > requirement > >

[dpdk-dev] [PATCH v2] Make the thash library arch-independent

2015-07-29 Thread Vladimir Medvedkin
v2 changes - Fix SSE to SSE3 typo - remove unnecessary comments - Leave unalligned union rte_thash_tuple if no support for SSE3 - Makes 32bit compiler happy by adding ULL suffix Signed-off-by: Vladimir Medvedkin --- lib/librte_hash/rte_thash.h | 23 +-- 1 file changed, 21

[dpdk-dev] [PATCH] bnx2x: fix undeclared PAGE_SIZE build error

2015-07-29 Thread Tony Lu
>-Original Message- >From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >Sent: Tuesday, July 28, 2015 5:18 PM >To: Zhigang Lu >Cc: dev at dpdk.org >Subject: Re: [dpdk-dev] [PATCH] bnx2x: fix undeclared PAGE_SIZE build error > >2015-07-28 16:48, Zhigang Lu: >> This patch fixes a

[dpdk-dev] [PATCH] test-pmd: show pci address in port info

2015-07-29 Thread Michael Qiu
pci address is one important info for port. This patch make it visible for port info. Signed-off-by: Michael Qiu --- app/test-pmd/config.c | 13 + 1 file changed, 13 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 1d29146..c7db5bc 100644 ---

[dpdk-dev] [PATCH v4] ixgbe: fix data access on big endian cpu.

2015-07-29 Thread Ananyev, Konstantin
> -Original Message- > From: xuelin.shi at freescale.com [mailto:xuelin.shi at freescale.com] > Sent: Wednesday, July 29, 2015 7:38 AM > To: Ananyev, Konstantin > Cc: thomas.monjalon at 6wind.com; dev at dpdk.org; Xuelin Shi > Subject: [PATCH v4] ixgbe: fix data access on big endian cpu.

[dpdk-dev] [PATCH v1 1/1] ixgbe: Fix oerrors by setting it to 0

2015-07-29 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maryam Tahhan > Sent: Tuesday, July 28, 2015 4:38 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v1 1/1] ixgbe: Fix oerrors by setting it to 0 > > Fix afebc86be1346136125af8026dc215f81c202c50. oerrors

[dpdk-dev] [PATCH v4] enforce rules of the cpu and ixgbe exchange data.

2015-07-29 Thread Xuelin Shi
Hi Thomas & Konstantin, Thanks for the review and the comments are addressed by http://www.dpdk.org/dev/patchwork/patch/6653/ Best Regards, Xuelin Shi > -Origina Konstantin l Message- > From: Ananyev, Konstantin [mailto:konstantin.ananyev at intel.com] > Sent: Monday, July 27, 2015

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Helin Zhang
It fixes the build error of implicit declaration of function. Signed-off-by: Helin Zhang --- lib/librte_eal/common/include/rte_pci.h | 11 +++ lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] Failed to compile the dpdk on FreeBSD10.1

2015-07-29 Thread Fan, ChangruX
Hi Stephen, When I compile the newest dpdk, I meet these error info. Please check. [root at dpdk-test36 ~/dpdk]# gmake install T=x86_64-native-bsdapp-gcc CC=gcc48 == Installing x86_64-native-bsdapp-gcc Configuration done == Build lib == Build lib/librte_compat

[dpdk-dev] [PATCH v6] Add toeplitz hash algorithm used by RSS

2015-07-29 Thread Qiu, Michael
Hi, Vladimir You need also to fix this issue in i686 platform: RHEL65_32,2.6.32,4.4.7,14.0.0 SUSE11SP3_32,3.0.76-0,4.3.4,14.0.0 i686-native-linuxapp-gcc/include/rte_thash.h:63: error: integer constant is too large for 'long' type i686-native-linuxapp-gcc/include/rte_thash.h:63: error: integer

[dpdk-dev] [PATCH] testpmd: Fix segment fault when port ID greater than 76

2015-07-29 Thread Michael Qiu
In testpmd, when using "rx_vlan add 1 77", it will be a segment fault Because the port ID should be less than 32. Signed-off-by: Michael Qiu --- app/test-pmd/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index

[dpdk-dev] [PATCH v1 1/1] ixgbe: Fix oerrors by setting it to 0

2015-07-29 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maryam Tahhan > Sent: Tuesday, July 28, 2015 11:38 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v1 1/1] ixgbe: Fix oerrors by setting it to 0 > > Fix afebc86be1346136125af8026dc215f81c202c50.

[dpdk-dev] [PATCHv2 0/2] ixgbe: Two fixes for RX scatter functions.

2015-07-29 Thread Lu, Wenzhuo
Hi, Acked-by: Wenzhuo Lu

[dpdk-dev] [PATCH] config: disable bnx2x driver

2015-07-29 Thread Thomas Monjalon
2015-07-28 19:16, Thomas Monjalon: > This driver has too many issues: > - too big > - bad coding style > - no git history (dropped in 2 patches) > - no documentation > - no BSD support > - no maintainer > And the biggest one, constraining this disabling: >