[dpdk-dev] [PATCH 1/2] mbuf: fix performance/cache resource issue with 128-byte cache line targets

2015-12-08 Thread Jerin Jacob
On Tue, Dec 08, 2015 at 04:07:46PM +, Ananyev, Konstantin wrote: > > > > Hi Konstantin, > > > > > Hi Jerin, > > > > > > > -Original Message- > > > > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > > > > Sent: Sunday, December 06, 2015 3:59 PM > > > > To: dev at dpdk.org

[dpdk-dev] [[RFC PATCH]] lib/ether: fix 16-bit unaligned access

2015-12-08 Thread Jan Viktorin
On Tue, 08 Dec 2015 21:57:33 +0100 Thomas Monjalon wrote: > 2015-12-08 21:55, Jan Viktorin: > > On Tue, 08 Dec 2015 21:30:03 +0100 > > Thomas Monjalon wrote: > > > > > 2015-12-08 20:29, Jan Viktorin: > > > > (I considered to not add the cover-letter as this is just a single > > > > small

[dpdk-dev] [[RFC PATCH]] lib/ether: fix 16-bit unaligned access

2015-12-08 Thread Thomas Monjalon
2015-12-08 21:55, Jan Viktorin: > On Tue, 08 Dec 2015 21:30:03 +0100 > Thomas Monjalon wrote: > > > 2015-12-08 20:29, Jan Viktorin: > > > (I considered to not add the cover-letter as this is just a single small > > > patch. > > > I hope it does not matter a lot. Is there any convention how to

[dpdk-dev] [[RFC PATCH]] lib/ether: fix 16-bit unaligned access

2015-12-08 Thread Jan Viktorin
On Tue, 08 Dec 2015 21:30:03 +0100 Thomas Monjalon wrote: > 2015-12-08 20:29, Jan Viktorin: > > (I considered to not add the cover-letter as this is just a single small > > patch. > > I hope it does not matter a lot. Is there any convention how to do this?) > > The main interest of splitting

[dpdk-dev] [[RFC PATCH]] lib/ether: fix 16-bit unaligned access

2015-12-08 Thread Jan Viktorin
On Tue, 8 Dec 2015 12:02:54 -0800 Stephen Hemminger wrote: > On Tue, 8 Dec 2015 20:29:53 +0100 > Jan Viktorin wrote: > > > Hello, > > > > I was looking at some warnings generated during ARM build. I can see > > 53 warnings for my build based on v2.2.0-rc3, spread among: > > > >

[dpdk-dev] [PATCH v3 10/11] config: Enable BNX2X driver build by default

2015-12-08 Thread Rasesh Mody
Hi Thomas, > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, November 24, 2015 6:26 AM > > We still have a compilation error when zlib.h is missing. > Please keep it disabled until we have a solution (probably a "configure" > script). We'll split the patch set so

[dpdk-dev] [PATCH] bnx2x: set Ethernet address type during transmit for VF's

2015-12-08 Thread Bruce Richardson
On Tue, Dec 08, 2015 at 09:27:05AM -0500, Charles (Chas) Williams wrote: > On Mon, 2015-12-07 at 17:29 +, Harish Patil wrote: > > > > > >On Sun, 2015-12-06 at 23:34 +, Harish Patil wrote: > > >> > > > >> >The original was always setting unicast. While here, clean up some > > >> >other

[dpdk-dev] [[RFC PATCH]] lib/ether: fix 16-bit unaligned access

2015-12-08 Thread Thomas Monjalon
2015-12-08 20:29, Jan Viktorin: > (I considered to not add the cover-letter as this is just a single small > patch. > I hope it does not matter a lot. Is there any convention how to do this?) The main interest of splitting patches or adding a cover letter it to have a place to explain the

[dpdk-dev] [PATCH 3/6] virtio: armv7/v8: Introdice api to emulate x86-style of PCI/ISA ioport access

2015-12-08 Thread Santosh Shukla
On Mon, Dec 7, 2015 at 10:39 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > On Fri, 4 Dec 2015 23:05:16 +0530 > Santosh Shukla wrote: > > > +#if defined(RTE_ARCH_ARM64) > > + uint64_tio_base; > > +#else /* !ARM64 */ > > uint32_tio_base; > > +#endif > > Is

[dpdk-dev] [[RFC PATCH]] lib/ether: fix 16-bit unaligned access

2015-12-08 Thread Jan Viktorin
Hello, I was looking at some warnings generated during ARM build. I can see 53 warnings for my build based on v2.2.0-rc3, spread among: app/test-pmd/{flowgen,icmpecho,txonly}.c app/test/{packet_burst_generator,test_hash_functions,test_thash}.c lib/librte_ether/rte_ether.h

[dpdk-dev] [PATCH 6/6] virtio: arm/arm64: memory mapped IO support in pmd driver

2015-12-08 Thread Santosh Shukla
On Tue, Dec 8, 2015 at 3:17 PM, Ananyev, Konstantin < konstantin.ananyev at intel.com> wrote: > Hi, > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Santosh Shukla > > Sent: Friday, December 04, 2015 5:35 PM > > To: dev at dpdk.org > > Cc: Rizwan Ansari

[dpdk-dev] [PATCH 6/6] virtio: arm/arm64: memory mapped IO support in pmd driver

2015-12-08 Thread Santosh Shukla
On Mon, Dec 7, 2015 at 10:38 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > On Fri, 4 Dec 2015 23:05:19 +0530 > Santosh Shukla wrote: > > > > > +#ifdef RTE_EXEC_ENV_LINUXAPP > > +/* start address of first pci_iobar slot (user-space virtual-addres) */ > > +void *ioport_map; > >

[dpdk-dev] [PATCH v2 2/3] eal/acl: enable acl for armv7-a

2015-12-08 Thread Jianbo Liu
On 8 December 2015 at 18:03, Thomas Monjalon wrote: > 2015-12-08 15:56, Jianbo Liu: >> On 8 December 2015 at 10:23, Thomas Monjalon >> wrote: >> > 2015-12-08 09:50, Jianbo Liu: >> >> On 8 December 2015 at 09:18, Thomas Monjalon > >> 6wind.com> wrote: >> >> > 2015-12-03 23:02, Jianbo Liu: >> >>

[dpdk-dev] [PATCH 1/2] mbuf: fix performance/cache resource issue with 128-byte cache line targets

2015-12-08 Thread Jerin Jacob
On Mon, Dec 07, 2015 at 03:21:33PM +, Ananyev, Konstantin wrote: Hi Konstantin, > Hi Jerin, > > > -Original Message- > > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > > Sent: Sunday, December 06, 2015 3:59 PM > > To: dev at dpdk.org > > Cc: thomas.monjalon at

[dpdk-dev] Problem with new "make install" of DPDK 2.2.0-rc3 + XenVirt on 32-bit build is broken

2015-12-08 Thread Piotr Bartosiewicz
> cp: cannot stat > ?/home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/{mk,scripts}?: No > such file or directory > /home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/mk/ > rte.sdkinstall.mk:137: recipe for target 'install-sdk' failed > I have the same problem and it has nothing to do with

[dpdk-dev] New Coverity warnings

2015-12-08 Thread Mcnamara, John
Hi, Stephen, thanks for highlighting this. For the last few analysis runs I have been generating some automatic emails from these summary emails and git blame. There is an example below. I'd like to do this for all of the open defects but can't find a way to generate a similar report for

[dpdk-dev] Problem with new "make install" of DPDK 2.2.0-rc3 + XenVirt on 32-bit build is broken

2015-12-08 Thread Martinx - ジェームズ
On 8 December 2015 at 17:03, Thomas Monjalon wrote: > 2015-12-08 18:01, Piotr Bartosiewicz: > > > > > cp: cannot stat > > > ?/home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/{mk,scripts}?: No > > > such file or directory > > > /home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/mk/ > > >

[dpdk-dev] [PATCH] mk: fix the combined library problems by replacing it with a linker script

2015-12-08 Thread Robie Basak
On Wed, Dec 02, 2015 at 06:44:19AM -0500, Neil Horman wrote: > Theres nothing "complex" about the simple fact that a project builds lots of > libraries. Its extreemely common. Any graphic window manager has exactly the > same situation, as do any number of tools that have multiple hardware

[dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy issue

2015-12-08 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mcnamara, John > Sent: Tuesday, December 8, 2015 2:47 PM > To: Azarewicz, PiotrX T; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy > issue > > > -Original

[dpdk-dev] [PATCH 2/2] ethtool: fix dead code

2015-12-08 Thread Remy Horton
Beat me to it.. :) On 08/12/2015 16:51, Stephen Hemminger wrote: > Remove dead code, and print better return for other errors. > > Signed-off-by: Stephen Hemminger Acked-by: Remy Horton

[dpdk-dev] [PATCH v4 2/2] eal/linux: Add support for handling built-in kernel modules

2015-12-08 Thread Kamil Rytarowski
Currently rte_eal_check_module() detects Linux kernel modules via reading /proc/modules. Built-in ones aren't listed there and therefore they are not being found by the script. Add support for checking built-in modules with parsing the sysfs files This commit obsoletes the /proc/modules parsing

[dpdk-dev] [PATCH v4 1/2] tools: Add support for handling built-in kernel modules

2015-12-08 Thread Kamil Rytarowski
Currently dpdk_nic_bind.py detects Linux kernel modules via reading /proc/modules. Built-in ones aren't listed there and therefore they are not being found by the script. Add support for checking built-in modules with parsing the sysfs files. This commit obsoletes the /proc/modules parsing

[dpdk-dev] [PATCH] librte_hash: Fix compile errors on IBM POWER

2015-12-08 Thread Chao Zhu
This patch fixes the compile errors caused by lacking of "size_t" definition in rte_hash.h. Signed-off-by: Chao Zhu --- lib/librte_hash/rte_hash.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/rte_hash.h index

[dpdk-dev] [PATCH v2] mk: fix external shared library dependencies of libraries

2015-12-08 Thread Sergio Gonzalez Monroy
On 08/12/2015 11:47, Panu Matilainen wrote: > Similar to commit 5f9115e58cc6f304ff4ade694cf5823d32887d1a etc, but > for libraries. Clean up librte_vhost CFLAGS/LDFLAGS/LDLIBS confusion > while at it. > > Requiring applications to know about library internal details like > dependencies to external

[dpdk-dev] [PATCH 1/2] mbuf: fix performance/cache resource issue with 128-byte cache line targets

2015-12-08 Thread Ananyev, Konstantin
> > Hi Konstantin, > > > Hi Jerin, > > > > > -Original Message- > > > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > > > Sent: Sunday, December 06, 2015 3:59 PM > > > To: dev at dpdk.org > > > Cc: thomas.monjalon at 6wind.com; Richardson, Bruce; olivier.matz at > > >

[dpdk-dev] [PATCH v2 2/3] eal/acl: enable acl for armv7-a

2015-12-08 Thread Jianbo Liu
On 8 December 2015 at 10:23, Thomas Monjalon wrote: > 2015-12-08 09:50, Jianbo Liu: >> On 8 December 2015 at 09:18, Thomas Monjalon >> wrote: >> > 2015-12-03 23:02, Jianbo Liu: >> >> -ifeq ($(CONFIG_RTE_ARCH_ARM64),y) >> >> +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),)

[dpdk-dev] [PATCH] bonding: fix reordering of IP fragments

2015-12-08 Thread Andriy Berestovskyy
Fragmented IPv4 packets have no TCP/UDP headers, so we hashed random data introducing reordering of the fragments. --- drivers/net/bonding/rte_eth_bond_pmd.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c

[dpdk-dev] Problem with new "make install" of DPDK 2.2.0-rc3 + XenVirt on 32-bit build is broken

2015-12-08 Thread Martinx - ジェームズ
On 8 December 2015 at 15:01, Piotr Bartosiewicz < piotr.bartosiewicz at atendesoftware.pl> wrote: > > cp: cannot stat >> ?/home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/{mk,scripts}?: No >> such file or directory >> /home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/mk/ >>

[dpdk-dev] [PATCH 1/4] vhost: handle VHOST_USER_SET_LOG_BASE request

2015-12-08 Thread Yuanhan Liu
On Tue, Dec 08, 2015 at 05:57:54AM +, Xie, Huawei wrote: > On 12/2/2015 11:40 AM, Yuanhan Liu wrote: > [...] > > + > > + addr = mmap(0, size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, off); > > + if (addr == MAP_FAILED) { > > + RTE_LOG(ERR, VHOST_CONFIG, "mmap log base failed!\n");

[dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy issue

2015-12-08 Thread Piotr Azarewicz
The cmds and thread_cmds both are the arrays of cmdline_parse_ctx_t. So the goal is to copy elements size of cmdline_parse_ctx_t not cmdline_parse_ctx_t*. Coverity issue: 120412 Fixes: b4aee0fb9c6d ("examples/ip_pipeline: reconfigure thread binding dynamically") Signed-off-by: Piotr Azarewicz

[dpdk-dev] [PATCH] config: cleanup existing RTE_CACHE_LINE_SIZE selection scheme

2015-12-08 Thread Jerin Jacob
On Mon, Dec 07, 2015 at 03:45:10PM +0100, Thomas Monjalon wrote: > 2015-12-07 19:52, Jerin Jacob: > > by default, all the targets will be configured with the 64-byte cache line > > size, targets which have different cache line size can be overridden > > through target specific config file. > > >

[dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy issue

2015-12-08 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Piotr Azarewicz > Sent: Tuesday, December 8, 2015 2:17 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy issue > > The cmds and thread_cmds both are the arrays of

[dpdk-dev] [PATCH] librte_hash: Fix compile errors on IBM POWER

2015-12-08 Thread Jerin Jacob
On Tue, Dec 08, 2015 at 04:28:52PM +0800, Chao Zhu wrote: > This patch fixes the compile errors caused by lacking of "size_t" definition > in rte_hash.h. > > Signed-off-by: Chao Zhu > --- > lib/librte_hash/rte_hash.h |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git

[dpdk-dev] [PATCH] bond: fix LACP mempool size

2015-12-08 Thread Andriy Berestovskyy
The following messages might appear after some idle time: "PMD: Failed to allocate LACP packet from pool" The fix ensures the mempool size is greater than the sum of TX descriptors. --- drivers/net/bonding/rte_eth_bond_8023ad.c | 24 +++- 1 file changed, 15 insertions(+), 9

[dpdk-dev] [PATCH v3 2/2] eal/linux: Add support for handling built-in kernel modules

2015-12-08 Thread Kamil Rytarowski
W dniu 08.12.2015 o 08:25, Panu Matilainen pisze: > On 12/07/2015 10:55 PM, Stephen Hemminger wrote: >> On Mon, 7 Dec 2015 19:36:05 +0100 >> Kamil Rytarowski wrote: >> >>> +/* Check if there is sysfs mounted */ >>> +if (stat("/sys/module", ) != 0) { >>> +RTE_LOG(DEBUG, EAL,

[dpdk-dev] [ovs-discuss] [announce] driverctl: utility for persistent alternative driver binding

2015-12-08 Thread Panu Matilainen
On 12/04/2015 05:44 PM, Gray, Mark D wrote: > I welcome this initiative, one question below: > >> -Original Message- >> From: discuss [mailto:discuss-bounces at openvswitch.org] On Behalf Of Panu >> Matilainen >> Sent: Friday, December 4, 2015 10:54 AM >> To: dev at dpdk.org; users at

[dpdk-dev] [PATCH v2] mk: fix external shared library dependencies of libraries

2015-12-08 Thread Panu Matilainen
Similar to commit 5f9115e58cc6f304ff4ade694cf5823d32887d1a etc, but for libraries. Clean up librte_vhost CFLAGS/LDFLAGS/LDLIBS confusion while at it. Requiring applications to know about library internal details like dependencies to external helper libraries is a limitation of static linkage,

[dpdk-dev] [PATCH] mk: fix external shared library dependencies of libraries

2015-12-08 Thread Panu Matilainen
On 12/08/2015 12:11 PM, Thomas Monjalon wrote: > Hi Panu, > > 2015-12-08 10:30, Panu Matilainen: >> --- a/lib/librte_vhost/Makefile >> +++ b/lib/librte_vhost/Makefile >> @@ -44,10 +44,12 @@ CFLAGS += -I vhost_user >> else >> CFLAGS += -I vhost_cuse -lfuse >> LDFLAGS += -lfuse >> +LDLIBS +=

[dpdk-dev] [PATCH 0/6] Add virtio support in arm/arm64

2015-12-08 Thread Xie, Huawei
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Monday, December 07, 2015 10:12 AM > To: Santosh Shukla > Cc: dev at dpdk.org; thomas.monjalon at 6wind.com; Xie, Huawei > Subject: Re: [PATCH 0/6] Add virtio support in arm/arm64 > > On Fri, Dec

[dpdk-dev] [PATCH] Remove the extra blank lines in the output

2015-12-08 Thread Keith Wiles
The output for the core list included an extra linefeed making the number of lines displayed much larger then required. Signed-off-by: Keith Wiles --- tools/cpu_layout.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/cpu_layout.py b/tools/cpu_layout.py index

[dpdk-dev] [PATCH v10 0/4] examples: add performance-thread

2015-12-08 Thread Kulasek, TomaszX
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ian Betts > Sent: Tuesday, December 8, 2015 07:05 > To: dev at dpdk.org > Cc: Betts, Ian > Subject: [dpdk-dev] [PATCH v10 0/4] examples: add performance-thread > > This patchset comprises a layer 3 forwarding

[dpdk-dev] [[RFC PATCH]] lib/ether: fix 16-bit unaligned access

2015-12-08 Thread Stephen Hemminger
On Tue, 8 Dec 2015 20:29:53 +0100 Jan Viktorin wrote: > Hello, > > I was looking at some warnings generated during ARM build. I can see > 53 warnings for my build based on v2.2.0-rc3, spread among: > > app/test-pmd/{flowgen,icmpecho,txonly}.c >

[dpdk-dev] [PATCH v2 2/3] eal/acl: enable acl for armv7-a

2015-12-08 Thread Thomas Monjalon
2015-12-08 18:21, Jianbo Liu: > On 8 December 2015 at 18:03, Thomas Monjalon > wrote: > > 2015-12-08 15:56, Jianbo Liu: > >> On 8 December 2015 at 10:23, Thomas Monjalon >> 6wind.com> wrote: > >> > 2015-12-08 09:50, Jianbo Liu: > >> >> On 8 December 2015 at 09:18, Thomas Monjalon >> >>

[dpdk-dev] DPDK Community Call - ARM Support

2015-12-08 Thread Jan Viktorin
Hello, I'd like to see the presentation as well. Another point. Last time, I was confused a bit by who is talking as the gotomeeting system doesn't show it always and if it does it hides very quickly. The topic was not very clear sometimes. Could we agree on some rules? Could somebody be a

[dpdk-dev] [PATCH v2 2/3] eal/acl: enable acl for armv7-a

2015-12-08 Thread Jan Viktorin
? P?vodn? zpr?va ? Od: Thomas Monjalon Odesl?no: ?ter?, 8. prosince 2015 11:04 Komu: Jianbo Liu Kopie: dev at dpdk.org; Jan Viktorin; Jerin Jacob P?edm?t: Re: [dpdk-dev] [PATCH v2 2/3] eal/acl: enable acl for armv7-a 2015-12-08 15:56, Jianbo Liu: > On 8 December 2015 at 10:23, Thomas Monjalon >

[dpdk-dev] [PATCH] examples/vhost: fix strict aliasing error on gcc 4.4.7

2015-12-08 Thread Pablo de Lara
Fixes following error on gcc 4.4.7: make: Entering directory `/tmp/dpdk-tmp/examples/vhost' CC main.o cc1: warnings being treated as errors /tmp/dpdk-tmp/examples/vhost/main.c: In function ?new_device?: /tmp/dpdk-tmp/x86_64-native-linuxapp-gcc/include/rte_ring.h:740: error: dereferencing

[dpdk-dev] [PATCH] vhost: don't stall if guest is slow

2015-12-08 Thread Yuanhan Liu
On Tue, Dec 08, 2015 at 03:30:43AM +0100, Thomas Monjalon wrote: > 2015-12-08 10:23, Yuanhan Liu: > > On Mon, Dec 07, 2015 at 04:50:21PM -0800, Stephen Hemminger wrote: > > > When guest is booting (or any othertime guest is busy) it is possible > > > for the small receive ring (256) to get full.

[dpdk-dev] [PATCH] mk: fix external shared library dependencies of libraries

2015-12-08 Thread Thomas Monjalon
Hi Panu, 2015-12-08 10:30, Panu Matilainen: > --- a/lib/librte_vhost/Makefile > +++ b/lib/librte_vhost/Makefile > @@ -44,10 +44,12 @@ CFLAGS += -I vhost_user > else > CFLAGS += -I vhost_cuse -lfuse > LDFLAGS += -lfuse > +LDLIBS += -lfuse > endif > > ifeq ($(CONFIG_RTE_LIBRTE_VHOST_NUMA),y)

[dpdk-dev] [PATCH v5 0/3] Add VHOST PMD

2015-12-08 Thread Tetsuya Mukawa
On 2015/12/08 11:03, Yuanhan Liu wrote: > On Tue, Dec 08, 2015 at 10:12:52AM +0900, Tetsuya Mukawa wrote: >> Hi Xie and Yuanhan, >> >> Please let me make sure whether this patch is differed. >> If it is differed, I guess I may need to add ABI breakage notice before > Tetsuya, > > What do you mean

[dpdk-dev] [PATCH] librte_hash: Fix compile errors on IBM POWER

2015-12-08 Thread Thomas Monjalon
2015-12-08 16:28, Chao Zhu: > This patch fixes the compile errors caused by lacking of "size_t" definition > in rte_hash.h. > > Signed-off-by: Chao Zhu Please Chao, could you provide the exact error and a Fixes: line in the commit message? Thanks

[dpdk-dev] [PATCH] virtio: fix wrong queue index for VIRTIO_PCI_QUEUE_SEL

2015-12-08 Thread Yuanhan Liu
We should provide VIRTIO_PCI_QUEUE_SEL with vq->vq_queue_idx, but not vq->queue_id. vq->queue_id is the queue id from rte_eth_rx/tx_queue_setup(), which always starts from 0 no matter which queue it is. However, for virtio, even number is for RX queue, and odd number is for TX queue. Fixes:

[dpdk-dev] [PATCH v2 2/3] eal/acl: enable acl for armv7-a

2015-12-08 Thread Thomas Monjalon
2015-12-08 15:56, Jianbo Liu: > On 8 December 2015 at 10:23, Thomas Monjalon > wrote: > > 2015-12-08 09:50, Jianbo Liu: > >> On 8 December 2015 at 09:18, Thomas Monjalon >> 6wind.com> wrote: > >> > 2015-12-03 23:02, Jianbo Liu: > >> >> -ifeq ($(CONFIG_RTE_ARCH_ARM64),y) > >> >> +ifneq ($(filter

[dpdk-dev] Problem with new "make install" of DPDK 2.2.0-rc3 + XenVirt on 32-bit build is broken

2015-12-08 Thread Thomas Monjalon
2015-12-08 18:01, Piotr Bartosiewicz: > > > cp: cannot stat > > ?/home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/{mk,scripts}?: No > > such file or directory > > /home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/mk/ > > rte.sdkinstall.mk:137: recipe for target 'install-sdk' failed > > >

[dpdk-dev] [PATCH] mk: fix external shared library dependencies of libraries

2015-12-08 Thread Panu Matilainen
Similar to commit 5f9115e58cc6f304ff4ade694cf5823d32887d1a etc, but for libraries. Requiring applications to know about library internal details like dependencies to external helper libraries is a limitation of static linkage, shared libraries should always know their own dependencies for sane

[dpdk-dev] [PATCH] vhost: don't stall if guest is slow

2015-12-08 Thread Yuanhan Liu
On Mon, Dec 07, 2015 at 04:50:21PM -0800, Stephen Hemminger wrote: > When guest is booting (or any othertime guest is busy) it is possible > for the small receive ring (256) to get full. If this happens the > vhost library should just return normally. It's current behavior > of logging just

[dpdk-dev] [PATCH v5 0/3] Add VHOST PMD

2015-12-08 Thread Tetsuya Mukawa
Hi Xie and Yuanhan, Please let me make sure whether this patch is differed. If it is differed, I guess I may need to add ABI breakage notice before releasing DPDK-2.2, because the patches changes virtio_net structure. Tetsuya, On 2015/11/24 18:00, Tetsuya Mukawa wrote: > The patch introduces a

[dpdk-dev] Problem with new "make install" of DPDK 2.2.0-rc3 + XenVirt on 32-bit build is broken

2015-12-08 Thread Martinx - ジェームズ
Hey guys, I'm seeing that there are something wrong with "standard make install", look: --- cd dpdk-2.2.0-rc3 make T=x86_64-native-linuxapp-gcc config sed -ri -e 's,(RTE_MACHINE=).*,\1"default",' \ -e 's,(RTE_APP_TEST=).*,\1n,' \ -e 's,(LIBRTE_VHOST=).*,\1y,' \

[dpdk-dev] [PATCH v5 0/3] Add VHOST PMD

2015-12-08 Thread Yuanhan Liu
On Tue, Dec 08, 2015 at 10:12:52AM +0900, Tetsuya Mukawa wrote: > Hi Xie and Yuanhan, > > Please let me make sure whether this patch is differed. > If it is differed, I guess I may need to add ABI breakage notice before Tetsuya, What do you mean by "differed"? Do you mean "delayed"? Per my

[dpdk-dev] [PATCH 2/2] virtio: clean up space checks on xmit

2015-12-08 Thread Yuanhan Liu
On Sat, Dec 05, 2015 at 11:50:07AM -0800, Stephen Hemminger wrote: > int error; > > > > > > @@ -846,58 +845,49 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf > > > **tx_pkts, uint16_t nb_pkts) > > > if (likely(nb_used > txvq->vq_nentries - txvq->vq_free_thresh)) > > >

[dpdk-dev] [PATCH v2 2/3] eal/acl: enable acl for armv7-a

2015-12-08 Thread Jianbo Liu
On 8 December 2015 at 09:18, Thomas Monjalon wrote: > 2015-12-03 23:02, Jianbo Liu: >> -ifeq ($(CONFIG_RTE_ARCH_ARM64),y) >> +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),) > [...] >> +#ifdef RTE_ARCH_ARM >> +/* NEON intrinsic vqtbl1q_u8() is not supported in

[dpdk-dev] [PATCH] bnx2x: check sc->state to prevent double init

2015-12-08 Thread Chas Williams
If the link is up, then the driver cannot be stopped and started successfully. Instead of checking the link status, use the driver's state. Signed-off-by: Chas Williams <3chas3 at gmail.com> --- drivers/net/bnx2x/bnx2x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH 6/6] virtio: arm/arm64: memory mapped IO support in pmd driver

2015-12-08 Thread Ananyev, Konstantin
Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Santosh Shukla > Sent: Friday, December 04, 2015 5:35 PM > To: dev at dpdk.org > Cc: Rizwan Ansari > Subject: [dpdk-dev] [PATCH 6/6] virtio: arm/arm64: memory mapped IO support > in pmd driver > > This

[dpdk-dev] [PATCH] bnx2x: set Ethernet address type during transmit for VF's

2015-12-08 Thread Charles (Chas) Williams
On Mon, 2015-12-07 at 17:29 +, Harish Patil wrote: > > > >On Sun, 2015-12-06 at 23:34 +, Harish Patil wrote: > >> > > >> >The original was always setting unicast. While here, clean up some > >> >other references that also point into the Ethernet header. > >> > > >> >Signed-off-by: Chas

[dpdk-dev] Compile error with CONFIG_RTE_BUILD_COMBINE_LIBS=y

2015-12-08 Thread Qiu, Michael
My mistake. please ignore this issue. Thanks, Michael On 2015/12/8 15:08, Qiu, Michael wrote: > Hi, Thomas > > I see you recently merged one commit: > > commit 8f1c704fb0f1b867471fc692ed2c0fc5610831e2 > Author: Thomas Monjalon > Date: Tue Dec 8 01:50:17 2015 +0100 > > mk: fix external

[dpdk-dev] [PATCH v3 2/2] eal/linux: Add support for handling built-in kernel modules

2015-12-08 Thread Panu Matilainen
On 12/07/2015 10:55 PM, Stephen Hemminger wrote: > On Mon, 7 Dec 2015 19:36:05 +0100 > Kamil Rytarowski wrote: > >> +/* Check if there is sysfs mounted */ >> +if (stat("/sys/module", ) != 0) { >> +RTE_LOG(DEBUG, EAL, "Open /sys/module failed: %s\n", >> +

[dpdk-dev] [PATCH 2/2] ethtool: fix dead code

2015-12-08 Thread Stephen Hemminger
Remove dead code, and print better return for other errors. Signed-off-by: Stephen Hemminger *** CID 120411: Control flow issues (DEADCODE) /examples/ethtool/ethtool-app/ethapp.c: 484 in pcmd_macaddr_callback() 478 mac_addr.addr_bytes[4], 479

[dpdk-dev] [PATCH 1/2] ip_pipeline: fix coverity warning

2015-12-08 Thread Stephen Hemminger
Fix problem reported by latest Coverity scan. It won't have a direct impact on anything. Signed-off-by: Stephen Hemminger ** CID 120412: Code maintainability issues (SIZEOF_MISMATCH) /examples/ip_pipeline/thread_fe.c: 338 in app_pipeline_thread_cmd_push() *** CID 120412: Code

[dpdk-dev] [PATCH 0/2] Trivial fixes for Coverity warnings

2015-12-08 Thread Stephen Hemminger
Fix the low hanging fruit. Stephen Hemminger (2): ip_pipeline: fix coverity warning ethtool: fix dead code examples/ethtool/ethtool-app/ethapp.c | 9 +++-- examples/ip_pipeline/thread_fe.c | 5 ++--- 2 files changed, 5 insertions(+), 9 deletions(-) -- 2.1.4

[dpdk-dev] New Coverity warnings

2015-12-08 Thread Stephen Hemminger
*** CID 120410: Error handling issues (CHECKED_RETURN) /examples/l2fwd-keepalive/main.c: 571 in dead_core() 565 566 static void 567 dead_core(__attribute__((unused)) void *ptr_data, const int id_core) 568 { 569 printf("Dead core %i - restarting..\n", id_core); 570

[dpdk-dev] Compile error with CONFIG_RTE_BUILD_COMBINE_LIBS=y

2015-12-08 Thread Qiu, Michael
Hi, Thomas I see you recently merged one commit: commit 8f1c704fb0f1b867471fc692ed2c0fc5610831e2 Author: Thomas Monjalon Date: Tue Dec 8 01:50:17 2015 +0100 mk: fix external library build when combine is enabled The object files are copied to prepare the internal combined library.

[dpdk-dev] [PATCH v10 4/4] examples: add pthread_shim example to performance thread

2015-12-08 Thread Ian Betts
This commit adds an example that illustrates how to implement a pthread shim with the lthread subsystem included in the performance thread example application. Signed-off-by: Ian Betts --- examples/performance-thread/Makefile | 2 +

[dpdk-dev] [PATCH v10 3/4] examples: add l3fwd-thread example in performance-thread

2015-12-08 Thread Ian Betts
This commit adds an L3 forwarding application to the performace-thread example. Changes in this version * Use DIRS-y in examples/Makefile * remove superflous entry in maintainers Signed-off-by: Ian Betts --- MAINTAINERS |4 + examples/Makefile

[dpdk-dev] [PATCH v10 2/4] examples: add lthread subsystem for performance-thread

2015-12-08 Thread Ian Betts
This commit adds the lightweight thread subsystem used by the performance-thread sample applications. Changes in this version * fix clang errors Signed-off-by: Ian Betts --- examples/performance-thread/common/arch/x86/ctx.c | 93 +++ examples/performance-thread/common/arch/x86/ctx.h | 57

[dpdk-dev] [PATCH v10 1/4] doc: add sample application guide for performance-thread

2015-12-08 Thread Ian Betts
This commit adds the sample application user guide for the performance thread sample application. Signed-off-by: Ian Betts --- .../sample_app_ug/img/performance_thread_1.svg | 799 + .../sample_app_ug/img/performance_thread_2.svg | 865 ++

[dpdk-dev] [PATCH v10 0/4] examples: add performance-thread

2015-12-08 Thread Ian Betts
This patchset comprises a layer 3 forwarding derivative intended to facilitate characterization of performance with different threading models, specifically:- 1. EAL threads running on different physical cores 2. EAL threads running on the same physical core 3. Lightweight threads running in an

[dpdk-dev] [PATCH 1/4] vhost: handle VHOST_USER_SET_LOG_BASE request

2015-12-08 Thread Xie, Huawei
On 12/2/2015 11:40 AM, Yuanhan Liu wrote: [...] > + > + addr = mmap(0, size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, off); > + if (addr == MAP_FAILED) { > + RTE_LOG(ERR, VHOST_CONFIG, "mmap log base failed!\n"); > + return -1; > + } Yuanhan: mmap could fail with

[dpdk-dev] [dpdk-announce] release candidate 2.2.0-rc3

2015-12-08 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: http://dpdk.org/browse/dpdk/tag/?id=v2.2.0-rc3 Changelog (main changes since 2.2.0-rc2) - enhancements: * new Netronome nfp networking driver * pipeline example * new ethtool example

[dpdk-dev] [PATCH v9 3/4] examples: add l3fwd-thread example in performance-thread

2015-12-08 Thread Thomas Monjalon
2015-12-08 01:54, Betts, Ian: > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, December 8, 2015 1:36 AM > To: Betts, Ian > Cc: dev at dpdk.org; stephen at networkplumber.org; Richardson, Bruce > Subject: Re: [PATCH v9 3/4] examples: add

[dpdk-dev] [PATCH v2 2/3] eal/acl: enable acl for armv7-a

2015-12-08 Thread Thomas Monjalon
2015-12-08 09:50, Jianbo Liu: > On 8 December 2015 at 09:18, Thomas Monjalon > wrote: > > 2015-12-03 23:02, Jianbo Liu: > >> -ifeq ($(CONFIG_RTE_ARCH_ARM64),y) > >> +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),) > > [...] > >> +#ifdef RTE_ARCH_ARM > >> +/* NEON intrinsic

[dpdk-dev] [PATCH v9 3/4] examples: add l3fwd-thread example in performance-thread

2015-12-08 Thread Thomas Monjalon
2015-12-07 17:58, Ian Betts: > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -575,3 +575,10 @@ F: doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst > M: Pablo de Lara > M: Daniel Mrzyglod > F: examples/ptpclient/ > + > +M: Ian Betts > +F: examples/performance-thread/ > + > +M: Ian Betts > +M:

[dpdk-dev] [PATCH v2 0/3] support acl lib for armv7-a and a small fix

2015-12-08 Thread Thomas Monjalon
2015-12-03 23:02, Jianbo Liu: > This patchset includes a small fix in rte_cycle_32.h, > and support ACL for armv7-a platform. > > v2: > - select alg as RTE_ACL_CLASSIFY_NEON only when NEON is checked in cpuflags. > - remove lpm/table/pipeline patch, and part of change will be merged into >

[dpdk-dev] [PATCH v2 1/3] eal/arm: use RTE_ARM_EAL_RDTSC_USE_PMU in rte_cycle_32.h

2015-12-08 Thread Thomas Monjalon
2015-12-03 23:02, Jianbo Liu: > CONFIG_* from config files can not be used in code. > > Signed-off-by: Jianbo Liu > Acked-by: Jan Viktorin Fixes: 12f45fa7e29b ("eal/arm: read timer from PMU if enabled")

[dpdk-dev] [PATCH v9 3/4] examples: add l3fwd-thread example in performance-thread

2015-12-08 Thread Betts, Ian
-Original Message- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Tuesday, December 8, 2015 1:36 AM To: Betts, Ian Cc: dev at dpdk.org; stephen at networkplumber.org; Richardson, Bruce Subject: Re: [PATCH v9 3/4] examples: add l3fwd-thread example in performance-thread >

[dpdk-dev] [PATCH v10 2/4] mk: Fix missing directory with combined extlib build

2015-12-08 Thread Thomas Monjalon
2015-12-07 13:48, Remy Horton: > Signed-off-by: Remy Horton > --- > mk/rte.extlib.mk | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/mk/rte.extlib.mk b/mk/rte.extlib.mk > index 4d459e4..47023a3 100644 > --- a/mk/rte.extlib.mk > +++ b/mk/rte.extlib.mk > @@ -42,11 +42,17 @@ export

[dpdk-dev] [PATCH v10 0/4] User-space ethtool sample application

2015-12-08 Thread Thomas Monjalon
2015-12-07 13:48, Remy Horton: > Further enhancements to the userspace ethtool implementation that was > submitted in 2.1 and packaged as a self-contained sample application. > Implements an rte_ethtool shim layer based on rte_ethdev API, along > with a command prompt driven demonstration

[dpdk-dev] [PATCH v10 4/4] doc: add user-space ethtool sample app guide

2015-12-08 Thread Thomas Monjalon
2015-12-07 13:49, Remy Horton: > --- a/doc/guides/rel_notes/release_2_2.rst > +++ b/doc/guides/rel_notes/release_2_2.rst > @@ -243,6 +243,7 @@ Examples > > * **vhost_xen: Fixed compile error.** > > +* **ethtool: Added ethtool shim and sample application.** > > Other > ~ There are

[dpdk-dev] DPDK Community Call - ARM Support

2015-12-08 Thread Bob Monkman
Tim, Yes, and I have been meaning to ask Venky to send out the presentation again. This was asked at the meeting and it fell through the cracks. I had wanted to ping some of the ARM SoC folks to read it and come prepared to discuss. As it stands, I will send a note anyways and see if I can get

[dpdk-dev] [PATCH] vhost: reserve some spaces for virtio_net and vhost_virtqueue struct

2015-12-08 Thread Thomas Monjalon
2015-12-03 10:27, Yuanhan Liu: > So that we will not break ABI in future extension by adding few more > fields. > > Struct vhost_virtqueue is reserved with 16 qwords (the later vhost-live > migration support would at least consume 3 of them), and struct virtio_net > is reserved with a bit more,

[dpdk-dev] [PATCH v3 06/13] mk: split install rule

2015-12-08 Thread Thomas Monjalon
Hi, 2015-12-07 23:22, Arevalo, Mario Alfredo C: > Hi Thomas, > > I'm testing this set of patches that has been applied, and I haven't noticed > before > that you exclude some binaries in "install-runtime" (test, testpipeline, > testacl etc...), I would like > to ask you the reason about this

[dpdk-dev] [PATCH v10 0/8] support for netronome nfp-6xxx card

2015-12-08 Thread Thomas Monjalon
2015-11-30 10:25, Alejandro Lucero: > This patchset adds a new PMD for Netronome nfp-6xxx card. > Just PCI Virtual Functions support. > Using this PMD requires previous Netronome BSP installation. There is no risk to merge this driver disabled by default. Applied, thanks