[dpdk-dev] VFIO no-iommu

2016-01-13 Thread Alex Williamson
On Thu, 2016-01-14 at 14:03 +0800, Jike Song wrote: > On Wed, Dec 16, 2015 at 12:38 PM, Alex Williamson > wrote: > > > > So it works.??Is it acceptable???Useful???Sufficiently complete???Does > > it imply deprecating the uio interface???I believe the feature that > > started this discussion was

[dpdk-dev] [PATCH 2/2] i40evf: support interrupt based pf reset request

2016-01-13 Thread Jingjing Wu
Interrupt based request of PF reset from PF is supported by enabling the adminq event process in VF driver. Users can register a callback for this interrupt event to get informed, when a PF reset request detected like: rte_eth_dev_callback_register(portid,

[dpdk-dev] [PATCH 1/2] i40evf: allocate virtchnl cmd buffer for each vf

2016-01-13 Thread Jingjing Wu
Currently, i40evf PMD uses a global static buffer to send virtchnl command to host driver. It is shared by multi VFs. This patch changed to allocate virtchnl cmd buffer for each VF. Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.h| 2 + drivers/net/i40e/i40e_ethdev_vf.c | 183

[dpdk-dev] [PATCH 0/2] i40evf: support interrupt based pf reset request

2016-01-13 Thread Jingjing Wu
If DPDK is used on VF while the host is using Linux Kernel driver as PF driver on FVL NIC, some setting on PF will trigger VF reset. DPDK VF need to know the event. This patch set makes the interrupt based request of PF reset from PF supported by enabling the adminq event process in VF driver.

[dpdk-dev] [PATCH 0/4] virtio support for container

2016-01-13 Thread Amit Tomer
Hello, > > You can use below patch for l2fwd to send out an arp packet when it gets > started. I tried to send out arp packet using this patch but buffer allocation for arp packets itself gets failed: m = rte_pktmbuf_alloc(mp); Return a NULL Value. Thanks, Amit.

[dpdk-dev] [PATCH v2 6/7] eal: pci: export pci_map_device

2016-01-13 Thread Santosh Shukla
On Tue, Jan 12, 2016 at 2:35 PM, Yuanhan Liu wrote: > On Tue, Jan 12, 2016 at 04:40:43PM +0800, Yuanhan Liu wrote: >> On Tue, Jan 12, 2016 at 09:31:05AM +0100, David Marchand wrote: >> > On Tue, Jan 12, 2016 at 7:59 AM, Yuanhan Liu > > linux.intel.com> >> > wrote: >> > >> > Normally we could

[dpdk-dev] [PATCH v3 09/12] virtio: vfio: Enable RTE_PCI_DRV_NEED_MAPPING flag in driver

2016-01-13 Thread Santosh Shukla
On Tue, Jan 12, 2016 at 12:44 PM, Yuanhan Liu wrote: > On Sat, Jan 09, 2016 at 06:08:46PM +0530, Santosh Shukla wrote: >> On Thu, Jan 7, 2016 at 11:50 PM, Stephen Hemminger >> wrote: >> > On Thu, 7 Jan 2016 22:03:06 +0530 >> > Santosh Shukla wrote: >> > >> >> +#ifdef RTE_EAL_VFIO >> >> +

[dpdk-dev] [PATCH v2 0/4] fix the issue that DPDK takes over virtio device blindly

2016-01-13 Thread Santosh Shukla
On Tue, Jan 12, 2016 at 10:46 AM, Xie, Huawei wrote: > On 1/12/2016 12:24 PM, Santosh Shukla wrote: >> On Tue, Jan 12, 2016 at 8:32 AM, Xie, Huawei wrote: >>> On 1/5/2016 1:25 AM, Stephen Hemminger wrote: On Mon, 4 Jan 2016 01:56:09 +0800 Huawei Xie wrote: > v2 changes:

[dpdk-dev] [PATCH v2 7/7] virtio: add 1.0 support

2016-01-13 Thread Yuanhan Liu
On Wed, Jan 13, 2016 at 12:31:43PM +0900, Tetsuya Mukawa wrote: > On 2016/01/12 15:59, Yuanhan Liu wrote: > > +static int > > +virtio_read_caps(struct rte_pci_device *dev, struct virtio_hw *hw) > > +{ > > + uint8_t pos; > > + struct virtio_pci_cap cap; > > + int ret; > > + > > + if

[dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update

2016-01-13 Thread Bruce Richardson
On Wed, Jan 13, 2016 at 04:28:34PM +, Hanoch Haim (hhaim) wrote: > Hi Bruce. > This is exactly what was possible before the patch and does *not* work after > this patch. > I think it is more related to the semantic of the API. My understanding of > the API was that I could allocate a share

[dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update

2016-01-13 Thread Hanoch Haim (hhaim)
Hi Bruce. This is exactly what was possible before the patch and does *not* work after this patch. I think it is more related to the semantic of the API. My understanding of the API was that I could allocate a share mbuf (ref=1) and then attach it from many concurrent threads (as each thread

[dpdk-dev] [PATCH] doc: coding style: use linux kernel style for indentation

2016-01-13 Thread Yuanhan Liu
Using two tabs for "if" (or "while") statements is a bit weird to me. Also, using one tab unconditionaly for function definitions and prototypes doesn't look great. Here I'd suggest to use the indentation style the Linux kernel project prefers: to align with the open brace with tabs and additonal

[dpdk-dev] Getting error while running DPDK test app on X-Gene1

2016-01-13 Thread Ankit Jindal
Hi, We are trying to run dpdk on our arm64 based SOC having Intel 10G ixgbe PCIe card plugged. While running any test app, we are getting following error. EAL: PCI device :01:00.0 on NUMA socket 0 EAL: probe driver: 8086:10fb rte_ixgbe_pmd EAL: Cannot open

[dpdk-dev] [PATCH] vhost_user: Make sure that memory map is set before attempting address translation

2016-01-13 Thread Yuanhan Liu
On Wed, Jan 13, 2016 at 10:18:43AM +0300, Pavel Fedin wrote: > Hello! > > > > Change-Id: Ibc8f6637fb5fb9885b02c316adf18afd45e0d49a > > > > What's this? An internal track id? > > Yes, it's from our gerrit. I've just done git format-patch. > > > If so, you should not include it > > here: it's

[dpdk-dev] rte_prefetch0() is effective?

2016-01-13 Thread Polehn, Mike A
Prefetchs make a big difference because a powerful CPU like IA is always trying to find items to prefetch and the priority of these is not always easy to determine. This is especially a problem across subroutine calls since the compiler cannot determine what is of priority in the other

[dpdk-dev] [PATCH 03/14] eal/common: introduce union rte_device and related

2016-01-13 Thread Jan Viktorin
On Wed, 13 Jan 2016 14:01:19 + Bruce Richardson wrote: > On Mon, Jan 04, 2016 at 09:08:15PM +0100, Jan Viktorin wrote: > > The union rte_device can be used in situations where we want to work with > > all > > devices without distinguishing among bus-specific features (PCI, ...). > > The

[dpdk-dev] [PATCH 00/14] Step towards PCI independency

2016-01-13 Thread David Marchand
Hello Jan, On Mon, Jan 11, 2016 at 6:29 PM, Jan Viktorin wrote: > Hello David, > > did you find time to see the patchset? I am working on a PMD on top of > these so I'd be glad to base on the code close to the (potentially) > upstreamed one. I took a quick look but since we still have an abi

[dpdk-dev] [PATCH] doc: coding style: use linux kernel style for indentation

2016-01-13 Thread Bruce Richardson
On Wed, Jan 13, 2016 at 03:58:49PM +0800, Yuanhan Liu wrote: > Using two tabs for "if" (or "while") statements is a bit weird to me. > Also, using one tab unconditionaly for function definitions and > prototypes doesn't look great. > > Here I'd suggest to use the indentation style the Linux

[dpdk-dev] [PATCH v3 06/12] eal: pci: vfio: add rd/wr func for pci bar space

2016-01-13 Thread Bruce Richardson
On Thu, Jan 07, 2016 at 10:19:25AM -0800, Stephen Hemminger wrote: > On Thu, 7 Jan 2016 22:03:03 +0530 > Santosh Shukla wrote: > > > > > +int rte_eal_pci_read_bar(const struct rte_pci_device *device __rte_unused, > > +void *buf __rte_unused, > > +size_t

[dpdk-dev] [PATCH 03/14] eal/common: introduce union rte_device and related

2016-01-13 Thread Bruce Richardson
On Wed, Jan 13, 2016 at 03:12:27PM +0100, Jan Viktorin wrote: > On Wed, 13 Jan 2016 14:01:19 + > Bruce Richardson wrote: > > > On Mon, Jan 04, 2016 at 09:08:15PM +0100, Jan Viktorin wrote: > > > The union rte_device can be used in situations where we want to work with > > > all > > >

[dpdk-dev] [PATCH v2] app/testpmd Fix max_socket detection

2016-01-13 Thread Stephen Hurd
Previously, max_socket was set to the highest numbered socket with an enabled lcore. The intent is to set it to the highest socket regardless of it being enabled. Change-Id: I6306af0f90aa3c1fc5ffed75d1eed8297d29e132 Signed-off-by: Stephen Hurd v2: Forgot to commit before sending email... sorry

[dpdk-dev] [PATCH] pci: Add the class_id support in pci probe

2016-01-13 Thread Panu Matilainen
On 01/13/2016 01:55 PM, Bruce Richardson wrote: > On Thu, Dec 31, 2015 at 09:12:14AM -0800, Stephen Hemminger wrote: >> On Tue, 29 Dec 2015 10:53:26 +0800 >> Ziye Yang wrote: >> >>> This patch is used to add the class_id support >>> for pci_probe since some devices need the class_info >>>

[dpdk-dev] [PATCH] app/testpmd Fix max_socket detection

2016-01-13 Thread Stephen Hurd
Previously, max_socket was set to the highest numbered socket with an enabled lcore. The intent is to set it to the highest socket regardless of it being enabled. Change-Id: I6306af0f90aa3c1fc5ffed75d1eed8297d29e132 Signed-off-by: Stephen Hurd --- app/test-pmd/testpmd.c | 10 +- 1 file

[dpdk-dev] [RFC v2 1/2] ethdev: add packet filter flow and new behavior switch to fdir

2016-01-13 Thread Rahul Lakkireddy
Hi Jingjing, On Tuesday, January 01/12/16, 2016 at 17:12:47 -0800, Wu, Jingjing wrote: > > > > diff --git a/lib/librte_ether/rte_eth_ctrl.h > > b/lib/librte_ether/rte_eth_ctrl.h > > index ce224ad..5cc22a0 100644 > > --- a/lib/librte_ether/rte_eth_ctrl.h > > +++ b/lib/librte_ether/rte_eth_ctrl.h

[dpdk-dev] [PATCH 03/14] eal/common: introduce union rte_device and related

2016-01-13 Thread Bruce Richardson
On Mon, Jan 04, 2016 at 09:08:15PM +0100, Jan Viktorin wrote: > The union rte_device can be used in situations where we want to work with all > devices without distinguishing among bus-specific features (PCI, ...). > The target device type can be detected by reading the magic. > > Also, the

[dpdk-dev] [RFC v2 1/2] ethdev: add packet filter flow and new behavior switch to fdir

2016-01-13 Thread Wu, Jingjing
Hi, Rahul > -Original Message- > From: Rahul Lakkireddy [mailto:rahul.lakkireddy at chelsio.com] > Sent: Wednesday, January 13, 2016 4:49 PM > To: Wu, Jingjing > Cc: dev at dpdk.org; Felix Marti; Kumar A S; Nirranjan Kirubaharan > Subject: Re: [dpdk-dev] [RFC v2 1/2] ethdev: add packet

[dpdk-dev] [RESEND PATCH] vhost_user: Make sure that memory map is set before attempting address translation

2016-01-13 Thread Xie, Huawei
On 1/13/2016 5:40 PM, Pavel Fedin wrote: > Hello! > >> Do you have examples for the malfunctioning clients? If so, could you >> list them in the commit message? > The only malfunctioning client was DPDK itself, with virtio for container > RFC applied. The client-side problem has been fixed >

[dpdk-dev] [RESEND PATCH] vhost_user: Make sure that memory map is set before attempting address translation

2016-01-13 Thread Pavel Fedin
Hello! > Do you have examples for the malfunctioning clients? If so, could you > list them in the commit message? The only malfunctioning client was DPDK itself, with virtio for container RFC applied. The client-side problem has been fixed afterwards by

[dpdk-dev] [PATCH v2] vfio: Support for no-IOMMU mode

2016-01-13 Thread Anatoly Burakov
This commit is adding a generic mechanism to support multiple IOMMU types. For now, it's only type 1 (x86 IOMMU) and no-IOMMU (a special VFIO mode that doesn't use IOMMU at all), but it's easily extended by adding necessary definitions into eal_pci_init.h and a DMA mapping function to

[dpdk-dev] [PATCH v2 7/7] virtio: add 1.0 support

2016-01-13 Thread Tetsuya Mukawa
On 2016/01/12 15:59, Yuanhan Liu wrote: > +static int > +virtio_read_caps(struct rte_pci_device *dev, struct virtio_hw *hw) > +{ > + uint8_t pos; > + struct virtio_pci_cap cap; > + int ret; > + > + if (rte_eal_pci_map_device(dev) < 0) { > + PMD_INIT_LOG(DEBUG, "failed

[dpdk-dev] rte_prefetch0() is effective?

2016-01-13 Thread Matthew Hall
On Wed, Jan 13, 2016 at 11:34:33AM +, Bruce Richardson wrote: > When the first example apps using this style of prefetch were originally > written, yes, there was a noticable performance increase achieved by using > the prefetch. Thereafter, I'm not sure that anyone has checked with each >

[dpdk-dev] UX Bug in Sphinx HTML Layout for Programming Guide (and maybe other guides?)

2016-01-13 Thread Matthew Hall
When you go to this link: http://dpdk.org/doc/guides/prog_guide/perf_opt_guidelines.html There is a bug in the Sphinx layout, where the subchapters of a chapter are invisible even after the chapter is clicked. It is a pain when you are trying to figure out the different sections in a widely

[dpdk-dev] [PATCH] pci: Add the class_id support in pci probe

2016-01-13 Thread Bruce Richardson
On Thu, Dec 31, 2015 at 09:12:14AM -0800, Stephen Hemminger wrote: > On Tue, 29 Dec 2015 10:53:26 +0800 > Ziye Yang wrote: > > > This patch is used to add the class_id support > > for pci_probe since some devices need the class_info > > (class_code, subclass_code, programming_interface) > > > >

[dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update

2016-01-13 Thread Bruce Richardson
On Tue, Jan 05, 2016 at 11:11:24AM +, Hanoch Haim (hhaim) wrote: > Hi Oliver, > Thank you for the fast response and it would be great to open a discussion on > that. > In general our project can leverage your optimization and I think it is great > (we should have thought about it) . We can

[dpdk-dev] rte_prefetch0() is effective?

2016-01-13 Thread Bruce Richardson
On Thu, Dec 24, 2015 at 03:35:14PM +0900, Moon-Sang Lee wrote: > I see codes as below in example directory, and I wonder it is effective. > Coherent IO is adopted to modern architectures, > so I think that DMA initiation by rte_eth_rx_burst() might already fulfills > cache lines of RX buffers. >

[dpdk-dev] patchwork 9704-9710 compilation error

2016-01-13 Thread Jan Viktorin
Hello Yongjie, I know about this error. It does not work on some GCC versions... However, this patch is not intended to be merged upstream. It just shows that the infra works in the RFC series. Anyway, thank you for your notification. Regards Jan On Wed, 13 Jan 2016 10:17:37 + "Gu,

[dpdk-dev] [RESEND PATCH] vhost_user: Make sure that memory map is set before attempting address translation

2016-01-13 Thread Pavel Fedin
Malfunctioning virtio clients may not send VHOST_USER_SET_MEM_TABLE for some reason. This causes NULL dereference in qva_to_vva(). Signed-off-by: Pavel Fedin Acked-by: Yuanhan Liu --- lib/librte_vhost/virtio-net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH] vhost_user: Make sure that memory map is set before attempting address translation

2016-01-13 Thread Pavel Fedin
Hello! > > Change-Id: Ibc8f6637fb5fb9885b02c316adf18afd45e0d49a > > What's this? An internal track id? Yes, it's from our gerrit. I've just done git format-patch. > If so, you should not include it > here: it's just meaningless to us. > > Otherwise, this patch looks good to me. Should i

[dpdk-dev] [PATCH] vhost_user: Make sure that memory map is set before attempting address translation

2016-01-13 Thread Yuanhan Liu
On Tue, Jan 12, 2016 at 05:35:06PM +0300, Pavel Fedin wrote: > Malfunctioning virtio clients may not send VHOST_USER_SET_MEM_TABLE for > some reason. This causes NULL dereference in qva_to_vva(). > > Change-Id: Ibc8f6637fb5fb9885b02c316adf18afd45e0d49a What's this? An internal track id? If so,

[dpdk-dev] [RESEND PATCH] vhost_user: Make sure that memory map is set before attempting address translation

2016-01-13 Thread Xie, Huawei
On 1/13/2016 3:33 PM, Pavel Fedin wrote: > Malfunctioning virtio clients may not send VHOST_USER_SET_MEM_TABLE for > some reason. This causes NULL dereference in qva_to_vva(). Do you have examples for the malfunctioning clients? If so, could you list them in the commit message? > >

[dpdk-dev] [PATCH] doc: coding style: use linux kernel style for indentation

2016-01-13 Thread Stephen Hemminger
On Wed, 13 Jan 2016 15:07:08 + Bruce Richardson wrote: > So, while the two-tab indent may look "a bit weird" it does solve the two > issues > above. I believe practical benefits should override initial impressions. [It > took > me a while to get used to also, but now I very much like it as

[dpdk-dev] [PATCH v2] vfio: Support for no-IOMMU mode

2016-01-13 Thread Stephen Hemminger
On Wed, 13 Jan 2016 12:36:09 + Anatoly Burakov wrote: > +/* IOMMU types we support */ > +static const struct vfio_iommu_type iommu_types[] = { > + /* x86 IOMMU, otherwise known as type 1 */ > + { VFIO_TYPE1_IOMMU, "Type 1", _iommu_type1_dma_map}, > + /*

[dpdk-dev] [PATCH] ixgbe: fix whitespace

2016-01-13 Thread Zhang, Helin
-Original Message- From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Wednesday, January 13, 2016 12:54 PM To: Zhang, Helin ; Ananyev, Konstantin Cc: dev at dpdk.org; Stephen Hemminger Subject: [PATCH] ixgbe: fix whitespace Normally, I ignore random minor whitespace

[dpdk-dev] [PATCH 4/4] doc: update release note for VxLAN & NVGRE checksum off-load support

2016-01-13 Thread Lu, Wenzhuo
Hi John, > -Original Message- > From: Mcnamara, John > Sent: Tuesday, January 12, 2016 9:45 PM > To: Lu, Wenzhuo ; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH 4/4] doc: update release note for VxLAN & > NVGRE checksum off-load support > > > -Original Message- > > From: dev

[dpdk-dev] [PATCH 1/4] ixgbe: support UDP tunnel add/del

2016-01-13 Thread Lu, Wenzhuo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, January 12, 2016 8:37 PM > To: Lu, Wenzhuo > Cc: dev at dpdk.org; Vincent JARDIN > Subject: Re: [dpdk-dev] [PATCH 1/4] ixgbe: support UDP tunnel add/del > > Hi, > >

[dpdk-dev] [PATCH v3 4/4] vmxnet3: announce device offload capability

2016-01-13 Thread Yong Wang
On 1/5/16, 4:52 PM, "Stephen Hemminger" wrote: >On Tue, 5 Jan 2016 16:12:58 -0800 >Yong Wang wrote: > >> >> /* return 0 means link status changed, -1 means not changed */ >> @@ -819,7 +831,7 @@ vmxnet3_dev_vlan_filter_set(struct rte_eth_dev *dev, >> uint16_t vid, int on) >> else >>

[dpdk-dev] [PATCH v3 2/4] vmxnet3: add tx l4 cksum offload

2016-01-13 Thread Yong Wang
On 1/5/16, 4:51 PM, "Stephen Hemminger" wrote: >On Tue, 5 Jan 2016 16:12:56 -0800 >Yong Wang wrote: > >> -if (txq->shared->ctrl.txNumDeferred >= txq->shared->ctrl.txThreshold) { >> +PMD_TX_LOG(DEBUG, "vmxnet3 txThreshold: %u", >> rte_le_to_cpu_32(txq_ctrl->txThreshold)); > >For

[dpdk-dev] [PATCH v3 1/4] vmxnet3: restore tx data ring support

2016-01-13 Thread Yong Wang
On 1/5/16, 4:48 PM, "Stephen Hemminger" wrote: >On Tue, 5 Jan 2016 16:12:55 -0800 >Yong Wang wrote: > >> @@ -365,6 +366,14 @@ vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf >> **tx_pkts, >> break; >> } >> >> +if (rte_pktmbuf_pkt_len(txm) <=

[dpdk-dev] [PATCH 00/12] Add API to get packet type info

2016-01-13 Thread Qiu, Michael
On 12/31/2015 9:53 PM, Jianfeng Tan wrote: > HAPPRY NEW YEAR! > > A new ether API rte_eth_dev_get_ptype_info() is added to query what > packet type information will be provided by current pmd driver of the > specifed port. > > To achieve this, a new function pointer, dev_ptype_info_get, is added >

[dpdk-dev] [RFC v2 1/2] ethdev: add packet filter flow and new behavior switch to fdir

2016-01-13 Thread Wu, Jingjing
> > diff --git a/lib/librte_ether/rte_eth_ctrl.h b/lib/librte_ether/rte_eth_ctrl.h > index ce224ad..5cc22a0 100644 > --- a/lib/librte_ether/rte_eth_ctrl.h > +++ b/lib/librte_ether/rte_eth_ctrl.h > @@ -74,7 +74,11 @@ extern "C" { > #define RTE_ETH_FLOW_IPV6_EX15 > #define

[dpdk-dev] [PATCH 0/4] virtio support for container

2016-01-13 Thread Tan, Jianfeng
Hello, On 1/12/2016 11:11 PM, Amit Tomer wrote: > Hello, > >> In vhost-switch, it judges if a virtio device is ready for processing after >> receiving >> a pkt from virtio device. So you'd better construct a pkt, and send it out >> firstly >> in l2fwd. > I tried to ping the socket interface from