[dpdk-dev] [PATCH v3] vhost: remove vhost_net_device_ops

2016-02-19 Thread Thomas Monjalon
2016-02-19 10:10, Rich Lane: > The indirection is unnecessary because there is only one implementation > of the vhost common code. Removing it makes the code more readable. > > Signed-off-by: Rich Lane > Acked-by: Yuanhan Liu Applied, thanks

[dpdk-dev] [PATCH v3 18/18] fm10k/base: remove unused struct element

2016-02-19 Thread Wang Xiao W
Remove the unused element request_lport_map in struct fm10k_mac_ops. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_type.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/fm10k/base/fm10k_type.h b/drivers/net/fm10k/base/fm10k_type.h index f807216..3fc8f13 100644 ---

[dpdk-dev] [PATCH v3 17/18] fm10k/base: minor cleanups

2016-02-19 Thread Wang Xiao W
Some cleanups to better reflect the code that was actually pushed out to the upstream Linux community. Among the above cleanups, a few macros such as FM10K_RXINT_TIMER_SHIFT are removed, but they are needed in dpdk/fm10k, so we have to put all these necessary macros into fm10k_osdep.h.

[dpdk-dev] [PATCH v3 16/18] fm10k/base: move constants to the right of binary operators

2016-02-19 Thread Wang Xiao W
The upstream Linux kernel community prefers constants are to the right of binary operators. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/fm10k/base/fm10k_pf.c

[dpdk-dev] [PATCH v3 15/18] fm10k/base: fix TLV structures alignment

2016-02-19 Thread Wang Xiao W
Per comments from an upstream patch, and looking at how TLV LE_STRUCT code works, we actually want these structures to be 4byte aligned, not 1byte aligned. In practice, 1byte alignment has worked so far because all our structures end up being a multiple of 4. But if a future TLV structure were

[dpdk-dev] [PATCH v3 14/18] fm10k/base: imporve comment per upstream review changes

2016-02-19 Thread Wang Xiao W
The comment here was changed during review of upstream patch, and the new wording is slightly more clear. Re-write the comment in SHARED code based on this new wording. Fix a number of mailbox comment issues with function header comments, lower-case acronyms (i.e. FIFO, TLV), incorrect function

[dpdk-dev] [PATCH v3 13/18] fm10k/base: consistently use VLAN ID when referencing vid variables

2016-02-19 Thread Wang Xiao W
The vid variable name is shorthand for VLAN ID, so we should use this in comments explaining what is happening. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/fm10k/base/fm10k_pf.c

[dpdk-dev] [PATCH v3 12/18] fm10k/base: allow removal of is_slot_appropriate function

2016-02-19 Thread Wang Xiao W
The Linux Kernel provides the OS a call "pcie_get_minimum_link" which can crawl the PCIe tree and determine the actual minimum link speed of a device which is a more general check than provided by is_slot_appropriate. Thus, the upstream driver does not use or want the is_slot_appropriate function

[dpdk-dev] [PATCH v3 11/18] fm10k/base: use memcpy for mac addr copy

2016-02-19 Thread Wang Xiao W
Use memcpy instead of copying MAC address byte-by-byte. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/fm10k/base/fm10k_pf.c b/drivers/net/fm10k/base/fm10k_pf.c index 7d48210..a1469aa

[dpdk-dev] [PATCH v3 10/18] fm10k/base: do not use CamelCase

2016-02-19 Thread Wang Xiao W
The upstream Linux kernel community prefers avoiding CamelCase in variables, function names, etc. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_type.h | 14 +++--- drivers/net/fm10k/fm10k_ethdev.c| 24 2 files changed, 19 insertions(+), 19

[dpdk-dev] [PATCH v3 09/18] fm10k/base: use BIT macro instead of open-coded bit-shifting of 1

2016-02-19 Thread Wang Xiao W
The upstream Linux kernel community prefers using the BIT macro over bit-shifting a 1. Similar to how this is handled in the i40e shared code, define a macro for OSes that do not already have it and wrap all that in LINUX_MACROS so that it can be stripped from the Linux driver. Signed-off-by:

[dpdk-dev] [PATCH v3 08/18] fm10k/base: cleanup useless else

2016-02-19 Thread Wang Xiao W
checkpatch warns that else is not generally useful after a break or return. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/fm10k/base/fm10k_pf.c b/drivers/net/fm10k/base/fm10k_pf.c

[dpdk-dev] [PATCH v3 07/18] fm10k/base: cleanup lines over 80 characters

2016-02-19 Thread Wang Xiao W
checkpatch warns about lines over 80 characters. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_mbx.c | 2 +- drivers/net/fm10k/base/fm10k_pf.c | 7 --- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/fm10k/base/fm10k_mbx.c

[dpdk-dev] [PATCH v3 06/18] fm10k/base: document ITR scale workaround in VF TDLEN register

2016-02-19 Thread Wang Xiao W
Add comments which properly explain the undocumented use of bits in TDLEN register prior to VF initializing it to the correct value. Note that the mechanism is entirely software-defined and explain its purpose to help reduce confusion in the future. Signed-off-by: Wang Xiao W ---

[dpdk-dev] [PATCH v3 05/18] fm10k/base: reset max_queues on init_hw_vf failure

2016-02-19 Thread Wang Xiao W
VF drivers must detect how many queues are available. Previously, the driver assumed that each VF has at minimum 1 queue. This assumption is incorrect, since it is possible that the PF has not yet assigned the queues to the VF by the time the VF checks. To resolve this, we added a check first to

[dpdk-dev] [PATCH v3 04/18] fm10k/base: use bitshift for itr_scale

2016-02-19 Thread Wang Xiao W
Upstream community wishes us to use bitshift instead of a divisor, because this is faster, and prevents any need for a '0' check. In our case, this even works out because default Gen3 will be 0. Because of this, we are also able to remove the check for non-zero value in the VF code path since

[dpdk-dev] [PATCH v3 03/18] fm10k/base: cleanup namespace pollution

2016-02-19 Thread Wang Xiao W
Make functions that are only referenced locally static. Wrap fm10k_msg_data fm10k_iov_msg_data_pf[] in the new ifndef NO_DEFAULT_SRIOV_MSG_HANDLERS so that drivers with custom SR-IOV message handlers can strip it. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c | 6 --

[dpdk-dev] [PATCH v3 02/18] fm10k/base: correct typecast in fm10k_update_xc_addr_pf

2016-02-19 Thread Wang Xiao W
Since the resultant data type of the mac_update.mac_upper field is u16, it does not make sense to typecast u8 variables to u32 first. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[dpdk-dev] [PATCH v3 01/18] fm10k: use default mailbox message handler for PF

2016-02-19 Thread Wang Xiao W
The new share code makes fm10k_msg_update_pvid_pf function static, so we can not refer to it now in fm10k_ethdev.c. The registered PF handler is almost the same as the default PF handler, removing it has no impact on mailbox. Signed-off-by: Wang Xiao W Acked-by: Jing Chen ---

[dpdk-dev] [PATCH v3 00/18] fm10k: update shared code

2016-02-19 Thread Wang Xiao W
v3: * Fixed checkpatch.pl warning about long commit message. * Fixed the issue of compile failure about part of patches applied. * Split the misc-small-fixes patch into several patches. v2: * Put the two extra fix patches ahead of the base code patches. This patch set has passed regression test.

[dpdk-dev] [PATCH v2] tools/dpdk_nic_bind: fix flake8 warnings

2016-02-19 Thread Mauricio Vasquez B
flake8 checks were run for both python 2.7 and 3.4 There were some style issues as: - Line width > 79 - No double blank line before function definition - No double blank space before inline comment - Some other minor issues Signed-off-by: Mauricio Vasquez B --- v2: fix still existing warning

[dpdk-dev] [PATCH v2 1/3] doc: fix keepalive sample app guide

2016-02-19 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Harry van Haaren > Sent: Thursday, January 21, 2016 11:05 AM > To: Horton, Remy > Cc: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2 1/3] doc: fix keepalive sample app guide > > This patch fixes some

[dpdk-dev] [PATCH v2] tools/dpdk_nic_bind: fix flake8 warnings

2016-02-19 Thread Mcnamara, John
> -Original Message- > From: Mauricio Vasquez B > [mailto:mauricio.vasquezbernal at studenti.polito.it] > Sent: Friday, February 19, 2016 5:03 PM > To: dev at dpdk.org > Cc: Mcnamara, John > Subject: [PATCH v2] tools/dpdk_nic_bind: fix flake8 warnings > > flake8 checks were run for both

[dpdk-dev] [PATCH v3 6/8] vhost: handle VHOST_USER_SEND_RARP request

2016-02-19 Thread Yuanhan Liu
On Fri, Feb 19, 2016 at 03:03:26PM +0800, Yuanhan Liu wrote: > On Fri, Feb 19, 2016 at 02:11:36PM +0800, Tan, Jianfeng wrote: > > What I suggest here is to move user_send_rarp() to rte_vhost_dequeue_burst() > > using a flag to control, so that this arp packet can be broadcasted in its > > own L2

[dpdk-dev] [PATCH] Correcting upstream kernel version in driver

2016-02-19 Thread Declan Doherty
On 10/02/16 23:28, John Griffin wrote: > Fixing the version of the kernel required in the QAT documentation. > > Signed-off-by: John Griffin > --- > doc/guides/cryptodevs/qat.rst | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/doc/guides/cryptodevs/qat.rst

[dpdk-dev] [PATCH] mempool: fix leak when mempool creation fails

2016-02-19 Thread Thomas Monjalon
2016-02-16 15:40, Olivier Matz: > Since commits ff909fe21f and 4e32101f9b, it is now possible to free > memzones and rings. > > The rte_mempool_create() should be modified to take advantage of this > and not leak memory when an allocation fails. > > Signed-off-by: Olivier Matz Applied, thanks

[dpdk-dev] [PATCH v2] vhost: remove vhost_net_device_ops

2016-02-19 Thread Thomas Monjalon
2016-02-17 20:58, Yuanhan Liu: > On Tue, Feb 16, 2016 at 02:45:04PM -0800, Rich Lane wrote: > > The indirection is unnecessary because there is only one implementation > > of the vhost common code. Removing it makes the code more readable. > > > > Signed-off-by: Rich Lane > > Acked-by: Yuanhan

[dpdk-dev] [PATCH v3] vhost: fix leak of fds and mmaps

2016-02-19 Thread Thomas Monjalon
2016-02-10 10:40, Rich Lane: > The common vhost code only supported a single mmap per device. vhost-user > worked around this by saving the address/length/fd of each mmap after the end > of the rte_virtio_memory struct. This only works if the vhost-user code frees > dev->mem, since the common code

[dpdk-dev] [PATCH v3 0/8] vhost-user live migration support

2016-02-19 Thread Thomas Monjalon
2016-01-29 12:57, Yuanhan Liu: > This patch set adds the vhost-user live migration support. > > The major task behind that is to log pages we touched during > live migration, including used vring and desc buffer. So, this > patch set is basically about adding vhost log support, and > using it. >

[dpdk-dev] [PATCH v5 4/4] app/test-pmd: test tunnel filter for IP in GRE

2016-02-19 Thread Xutao Sun
This patch add some options in tunnel_filter command to test IP in GRE packet classification on i40e. Signed-off-by: Xutao Sun Signed-off-by: Jijiang Liu --- app/test-pmd/cmdline.c | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git

[dpdk-dev] [PATCH v5 3/4] driver/i40e: implement tunnel filter for IP in GRE

2016-02-19 Thread Xutao Sun
Signed-off-by: Xutao Sun Signed-off-by: Jijiang Liu --- drivers/net/i40e/i40e_ethdev.c | 32 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 7c22358..a33fef5 100644 ---

[dpdk-dev] [PATCH v5 2/4] lib/ether: add IP in GRE type

2016-02-19 Thread Xutao Sun
Signed-off-by: Xutao Sun Signed-off-by: Jijiang Liu --- lib/librte_ether/rte_eth_ctrl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ether/rte_eth_ctrl.h b/lib/librte_ether/rte_eth_ctrl.h index 30cbde7..0e948a1 100644 --- a/lib/librte_ether/rte_eth_ctrl.h +++

[dpdk-dev] [PATCH v5 1/4] lib/ether: optimize the'rte_eth_tunnel_filter_conf' structure

2016-02-19 Thread Xutao Sun
Change the fields of outer_mac and inner_mac from pointer to struct in order to keep the code's readability. Signed-off-by: Xutao Sun Signed-off-by: Jijiang Liu --- app/test-pmd/cmdline.c | 6 +++-- doc/guides/rel_notes/deprecation.rst| 5 -

[dpdk-dev] [PATCH v5 0/4] Add tunnel filter support for IP in GRE on i40e

2016-02-19 Thread Xutao Sun
This patch set adds tunnel filter support for IP in GRE on i40e. v2 changes: Fix the byte order problem. v3 changes: Remove the deprecation notice and update the release notes. v4 changes: Modify the mistakes in cmdline.c in the old patch. v5 changes: Fix type errors and update the

[dpdk-dev] [PATCH v3 2/8] vhost: introduce vhost_log_write

2016-02-19 Thread Thomas Monjalon
2016-01-29 12:57, Yuanhan Liu: > Introduce vhost_log_write() helper function to log the dirty pages we > touched. Page size is harded code to 4096 (VHOST_LOG_PAGE), and each > log is presented by 1 bit. > > Therefore, vhost_log_write() simply finds the right bit for related > page we are gonna

[dpdk-dev] [PATCH v4] cfgfile: support looking up sections by index

2016-02-19 Thread Dumitrescu, Cristian
> -Original Message- > From: Rich Lane [mailto:rich.lane at bigswitch.com] > Sent: Tuesday, February 16, 2016 10:59 PM > To: dev at dpdk.org > Cc: Dumitrescu, Cristian ; Panu Matilainen > > Subject: [PATCH v4] cfgfile: support looking up sections by index > > This is useful when

[dpdk-dev] [PATCH v2] ixgbe: Fix disable interrupt twice

2016-02-19 Thread Ananyev, Konstantin
Hi Michael > > On 2016/2/2 19:03, Ananyev, Konstantin wrote: > > > > [...] > > I don't think i40e miss it, because it not the right please to disable > interrupt. > because all interrupts are enabled in init stage. > > Actually, ixgbe enable the interrupt in init

[dpdk-dev] [PATCH RFC 4/4] doc: add note about rte_vhost_enqueue_burst thread safety.

2016-02-19 Thread Yuanhan Liu
On Fri, Feb 19, 2016 at 09:32:43AM +0300, Ilya Maximets wrote: > Signed-off-by: Ilya Maximets > --- > doc/guides/prog_guide/thread_safety_dpdk_functions.rst | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/doc/guides/prog_guide/thread_safety_dpdk_functions.rst >

[dpdk-dev] [PATCH v3 0/2] Fix CRC32c computation

2016-02-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Didier Pallard > Sent: Friday, February 19, 2016 11:00 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v3 0/2] Fix CRC32c computation > > CRC32c computation is not valid when buffer length is not a

[dpdk-dev] [PATCH RFC 2/4] vhost: make buf vector for scatter RX local.

2016-02-19 Thread Yuanhan Liu
On Fri, Feb 19, 2016 at 09:32:41AM +0300, Ilya Maximets wrote: > Array of buf_vector's is just an array for temporary storing information > about available descriptors. It used only locally in virtio_dev_merge_rx() > and there is no reason for that array to be shared. > > Fix that by allocating

[dpdk-dev] [PATCH v3 6/8] vhost: handle VHOST_USER_SEND_RARP request

2016-02-19 Thread Yuanhan Liu
On Fri, Feb 19, 2016 at 02:11:36PM +0800, Tan, Jianfeng wrote: > Hi Yuanhan, > > On 1/29/2016 12:58 PM, Yuanhan Liu wrote: > >While in former patch we enabled GUEST_ANNOUNCE feature, so that the > >guest OS will broadcast a GARP message after migration to notify the > >switch about the new

[dpdk-dev] DPDK-QoS - link sharing across classes

2016-02-19 Thread Dumitrescu, Cristian
From: sreenaath vasudevan [mailto:sreenaat...@gmail.com] Sent: Thursday, February 18, 2016 8:01 PM To: Dumitrescu, Cristian Cc: dev at dpdk.org Subject: Re: [dpdk-dev] DPDK-QoS - link sharing across classes Hi Cristian Thanks for detailed response. Your solution works so long as I have four

[dpdk-dev] snapshot for 2.2.0 problem?

2016-02-19 Thread Thomas F Herbert
Hi, I am not sure if anyone has noticed yet this but is the dpdk snapshot bad today? wget http://dpdk.org/browse/dpdk/snapshot/dpdk-2.2.0.tar.gz --2016-02-19 19:35:23-- http://dpdk.org/browse/dpdk/snapshot/dpdk-2.2.0.tar.gz Resolving dpdk.org (dpdk.org)... 92.243.14.124 Connecting to dpdk.org

[dpdk-dev] [PATCH v7 2/4] virtio: Introduce config RTE_VIRTIO_INC_VECTOR

2016-02-19 Thread Yuanhan Liu
On Fri, Feb 19, 2016 at 10:16:42AM +0530, Santosh Shukla wrote: > On Tue, Feb 16, 2016 at 8:35 AM, Yuanhan Liu > wrote: > > On Mon, Feb 15, 2016 at 04:48:36PM +0530, Santosh Shukla wrote: > >> Hi Yuanhan, > >> > >> On Mon, Feb 15, 2016 at 4:27 PM, Yuanhan Liu > >> wrote: > >> > On Mon, Feb 15,

[dpdk-dev] [PATCH 6/6] mempool: add in the RTE_NEXT_ABI protection for ABI breakages

2016-02-19 Thread Olivier MATZ
Hi David, On 02/16/2016 03:48 PM, David Hunt wrote: > v2: Kept all the NEXT_ABI defs to this patch so as to make the > previous patches easier to read, and also to imake it clear what > code is necessary to keep ABI compatibility when NEXT_ABI is > disabled. > > Signed-off-by: David Hunt > ---

[dpdk-dev] [PATCH 2/6] mempool: add stack (lifo) based external mempool handler

2016-02-19 Thread Olivier MATZ
Hi David, On 02/16/2016 03:48 PM, David Hunt wrote: > adds a simple stack based mempool handler > > Signed-off-by: David Hunt > --- > lib/librte_mempool/Makefile| 2 +- > lib/librte_mempool/rte_mempool.c | 4 +- > lib/librte_mempool/rte_mempool.h | 1 + >

[dpdk-dev] [PATCH 1/6] mempool: add external mempool manager support

2016-02-19 Thread Olivier MATZ
Hi David, On 02/16/2016 03:48 PM, David Hunt wrote: > Adds the new rte_mempool_create_ext api and callback mechanism for > external mempool handlers > > Modifies the existing rte_mempool_create to set up the handler_idx to > the relevant mempool handler based on the handler name: >

[dpdk-dev] [PATCH 0/6] external mempool manager

2016-02-19 Thread Olivier MATZ
Hi, On 02/16/2016 03:48 PM, David Hunt wrote: > Hi list. > > Here's the v2 version of a proposed patch for an external mempool manager Just to notice the "v2" is missing in the title, it would help to have it for next versions of the series. Regards, Olivier

[dpdk-dev] [PATCH v3 6/8] vhost: handle VHOST_USER_SEND_RARP request

2016-02-19 Thread Tan, Jianfeng
Hi Yuanhan, On 1/29/2016 12:58 PM, Yuanhan Liu wrote: > While in former patch we enabled GUEST_ANNOUNCE feature, so that the > guest OS will broadcast a GARP message after migration to notify the > switch about the new location of migrated VM, the thing is that > GUEST_ANNOUNCE is enabled since

[dpdk-dev] [PATCH] tools/dpdk_nic_bind: fix flake8 warnings

2016-02-19 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mauricio Vasquez B > Sent: Thursday, February 18, 2016 10:33 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] tools/dpdk_nic_bind: fix flake8 warnings > > flake8 checks were run for both python 2.7 and

[dpdk-dev] [PATCH RFC v2 3/3] vhost: avoid reordering of used->idx and last_used_idx updating.

2016-02-19 Thread Ilya Maximets
Calling rte_vhost_enqueue_burst() simultaneously from different threads for the same queue_id requires additional SMP memory barrier to avoid reordering of used->idx and last_used_idx updates. In case of virtio_dev_rx() memory barrier rte_mb() simply moved one instruction higher. Signed-off-by:

[dpdk-dev] [PATCH RFC v2 2/3] vhost: make buf vector for scatter RX local.

2016-02-19 Thread Ilya Maximets
Array of buf_vector's is just an array for temporary storing information about available descriptors. It used only locally in virtio_dev_merge_rx() and there is no reason for that array to be shared. Fix that by allocating local buf_vec inside virtio_dev_merge_rx(). buf_vec field of struct

[dpdk-dev] [PATCH RFC v2 1/3] vhost: use SMP barriers instead of compiler ones.

2016-02-19 Thread Ilya Maximets
Since commit 4c02e453cc62 ("eal: introduce SMP memory barriers") virtio uses architecture dependent SMP barriers. vHost should use them too. Fixes: 4c02e453cc62 ("eal: introduce SMP memory barriers") Signed-off-by: Ilya Maximets --- lib/librte_vhost/vhost_rxtx.c | 6 +++--- 1 file changed, 3

[dpdk-dev] [PATCH RFC v2 0/3] Thread safe rte_vhost_enqueue_burst().

2016-02-19 Thread Ilya Maximets
Implementation of rte_vhost_enqueue_burst() based on lockless ring-buffer algorithm and contains almost all to be thread-safe, but it's not. This set adds required changes. First patch in set is a standalone patch that fixes many times discussed issue with barriers on different architectures.

[dpdk-dev] TX performance regression caused by the mbuf cachline split

2016-02-19 Thread Olivier MATZ
Hi Paul, On 02/15/2016 08:15 PM, Paul Emmerich wrote: > The bulk_alloc patch is great and helps. I'd love to see such a function > in DPDK. > A patch has been submitted by Huawei. I guess it will be integrated soon. See http://dpdk.org/dev/patchwork/patch/10122/ Regards, Olivier

[dpdk-dev] [PATCH RFC 4/4] doc: add note about rte_vhost_enqueue_burst thread safety.

2016-02-19 Thread Ilya Maximets
On 19.02.2016 11:36, Xie, Huawei wrote: > On 2/19/2016 3:10 PM, Yuanhan Liu wrote: >> On Fri, Feb 19, 2016 at 09:32:43AM +0300, Ilya Maximets wrote: >>> Signed-off-by: Ilya Maximets >>> --- >>> doc/guides/prog_guide/thread_safety_dpdk_functions.rst | 1 + >>> 1 file changed, 1 insertion(+) >>>

[dpdk-dev] [PATCH v3 2/2] hash: fix CRC32c computation

2016-02-19 Thread Didier Pallard
Fix crc32c hash functions to return a valid crc32c value for data lengthes not multiple of 4 bytes. ARM code is not tested. Signed-off-by: Didier Pallard Acked-by: David Marchand --- doc/guides/rel_notes/release_16_04.rst | 5 ++ lib/librte_hash/rte_crc_arm64.h| 64 +

[dpdk-dev] [PATCH v3 1/2] test: fix CRC hash function autotest

2016-02-19 Thread Didier Pallard
Add some small key lengthes (below 4 bytes), and fix odd key lengthes expected returned values for CRC computation to match real CRC values. Signed-off-by: Didier Pallard --- app/test/test_hash_functions.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git

[dpdk-dev] [PATCH v3 0/2] Fix CRC32c computation

2016-02-19 Thread Didier Pallard
CRC32c computation is not valid when buffer length is not a multiple of 4 bytes. Values returned by rte_hash_crc functions does not match the one computed by a trivial crc32c implementation. First patch fixes crc hash function autotests, to outline the problem. Second patch fixes CRC32c

[dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net

2016-02-19 Thread Thomas Monjalon
2016-02-19 09:56, Yuanhan Liu: > On Thu, Feb 18, 2016 at 04:07:52PM +0200, Panu Matilainen wrote: > > So where do the CC's vanish? > > No idea. I also have met this issue __many__ times before: I made a > group reply, with lots of people CC'ed, later I then received a copy > (from the mailing

[dpdk-dev] [PATCH v2 6/6] bond: do not activate slave twice

2016-02-19 Thread Eric Kinzie
From: Eric Kinzie The current code for detecting link during slave addition can cause a slave interface to be activated twice -- once during slave_configure() and again at the end of __eth_bond_slave_add_lock_free(). This will either cause the active slave count to be

[dpdk-dev] [PATCH v2 5/6] bond: active slaves with no primary

2016-02-19 Thread Eric Kinzie
From: Eric Kinzie If the link state of a slave is "up" when added, it is added to the list of active slaves but, even if it is the only slave, is not selected as the primary interface. Generally, handling of link state interrupts selects an interface to be primary, but only

[dpdk-dev] [PATCH v2 4/6] bond mode 4: allow external state machine

2016-02-19 Thread Eric Kinzie
From: Eric Kinzie Provide functions to allow an external 802.3ad state machine to transmit and recieve LACPDUs and to set the collection/distribution flags on slave interfaces. Signed-off-by: Eric Kinzie Signed-off-by: Stephen Hemminger Acked-by: Declan Doherty ---

[dpdk-dev] [PATCH v2 3/6] bond mode 4: do not ignore multicast

2016-02-19 Thread Eric Kinzie
From: Eric Kinzie The bonding PMD in mode 4 puts all enslaved interfaces into promiscuous mode in order to receive LACPDUs and must filter unwanted packets after the traffic has been "collected". Allow broadcast and multicast through so that ARP and IPv6 neighbor discovery

[dpdk-dev] [PATCH v2 2/6] bond mode 4: copy entire config structure

2016-02-19 Thread Eric Kinzie
From: Eric Kinzie Copy all needed fields from the mode8023ad_private structure in bond_mode_8023ad_conf_get(). This help ensure that a subsequent call to rte_eth_bond_8023ad_setup() is not passed uninitialized data that would result in either incorrect behavior or a failed

[dpdk-dev] [PATCH v2 1/6] bond: use existing enslaved device queues

2016-02-19 Thread Eric Kinzie
This solves issues when an active device is added to a bond. If a device to be enslaved already has transmit and/or receive queues allocated, use those and then create any additional queues that are necessary. Signed-off-by: Eric Kinzie Signed-off-by: Stephen Hemminger Acked-by: Declan Doherty

[dpdk-dev] [PATCH v2 0/6] bonding: fixes and enhancements

2016-02-19 Thread Eric Kinzie
These are bug fixes and some small enhancements to allow bonding to work with external control (teamd). Please consider integrating these into DPDK 2.2 Changes in v2: - remove "bond: handle slaves with fewer queues than bonding device" - remove "bond: per-slave intermediate rx ring" Eric Kinzie

[dpdk-dev] [PATCH v2 2/2] cryptodev: change burst API to be crypto op oriented

2016-02-19 Thread Declan Doherty
This patch modifies the crypto burst enqueue/dequeue APIs to operate on bursts rte_crypto_op's rather than the current implementation which operates on rte_mbuf bursts, this simplifies the burst processing in the crypto PMDs and the use of crypto operations in general. This change set also

[dpdk-dev] [PATCH v2 1/2] cryptodev: API tidy and changes to support future extensions

2016-02-19 Thread Declan Doherty
From: Fiona Trahe This patch splits symmetric specific definitions and functions away from the common crypto APIs to facilitate the future extension and expansion of the cryptodev framework, in order to allow asymmetric crypto operations to be introduced at a later date,

[dpdk-dev] [PATCH v2 0/2] cryptodev API changes

2016-02-19 Thread Declan Doherty
This patch set separates the symmetric crypto operations from generic operations and then modifies the cryptodev burst API to accept bursts of rte_crypto_op rather than rte_mbufs. This patch set is dependent on the following bug fixes patches: aesni_mb: strict-aliasing rule compilation fix

[dpdk-dev] [PATCH RFC 2/4] vhost: make buf vector for scatter RX local.

2016-02-19 Thread Ilya Maximets
On 19.02.2016 10:06, Yuanhan Liu wrote: > On Fri, Feb 19, 2016 at 09:32:41AM +0300, Ilya Maximets wrote: >> Array of buf_vector's is just an array for temporary storing information >> about available descriptors. It used only locally in virtio_dev_merge_rx() >> and there is no reason for that

[dpdk-dev] [PATCH v7 2/4] virtio: Introduce config RTE_VIRTIO_INC_VECTOR

2016-02-19 Thread Santosh Shukla
On Tue, Feb 16, 2016 at 8:35 AM, Yuanhan Liu wrote: > On Mon, Feb 15, 2016 at 04:48:36PM +0530, Santosh Shukla wrote: >> Hi Yuanhan, >> >> On Mon, Feb 15, 2016 at 4:27 PM, Yuanhan Liu >> wrote: >> > On Mon, Feb 15, 2016 at 03:22:11PM +0530, Santosh Shukla wrote: >> >> Hi Yuanhan, >> >> >> >> I

[dpdk-dev] [PATCH v3] vhost: remove vhost_net_device_ops

2016-02-19 Thread Rich Lane
The indirection is unnecessary because there is only one implementation of the vhost common code. Removing it makes the code more readable. Signed-off-by: Rich Lane Acked-by: Yuanhan Liu --- v2->v3: - Rebased. v1->v2: - Fix long lines. examples/vhost_xen/virtio-net.h | 2 -

[dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net

2016-02-19 Thread Yuanhan Liu
On Thu, Feb 18, 2016 at 04:07:52PM +0200, Panu Matilainen wrote: > >I didn't see the author was cc'ed from my email client: > > > > Date: Thu, 18 Feb 2016 11:47:43 +0200 > > From: Panu Matilainen > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH] vhost: add missing build

[dpdk-dev] [dpdk-dev, v3] Implement memcmp using Intel SIMD instrinsics.

2016-02-19 Thread Ravi Kerur
On Wed, Jan 27, 2016 at 7:08 PM, Zhihong Wang wrote: > > diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcmp.h b/lib > > /librte_eal/common/include/arch/x86/rte_memcmp.h > > [...] > > > +#ifdef __cplusplus > > +extern "C" { > > +#endif > > + > > +/** > > + * Compare bytes between two

[dpdk-dev] [dpdk-dev,v2] Clean up rte_memcpy.h file

2016-02-19 Thread Ravi Kerur
On Wed, Jan 27, 2016 at 8:18 PM, Zhihong Wang wrote: > > Remove unnecessary type casting in functions. > > > > Tested on Ubuntu (14.04 x86_64) with "make test". > > "make test" results match the results with baseline. > > "Memcpy perf" results match the results with baseline. > > > >

[dpdk-dev] [PATCH RFC 4/4] doc: add note about rte_vhost_enqueue_burst thread safety.

2016-02-19 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- doc/guides/prog_guide/thread_safety_dpdk_functions.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/prog_guide/thread_safety_dpdk_functions.rst b/doc/guides/prog_guide/thread_safety_dpdk_functions.rst index 403e5fc..13a6c89 100644 ---

[dpdk-dev] [PATCH RFC 3/4] vhost: avoid reordering of used->idx and last_used_idx updating.

2016-02-19 Thread Ilya Maximets
Calling rte_vhost_enqueue_burst() simultaneously from different threads for the same queue_id requires additional SMP memory barrier to avoid reordering of used->idx and last_used_idx updates. In case of virtio_dev_rx() memory barrier rte_mb() simply moved one instruction higher. Signed-off-by:

[dpdk-dev] [PATCH RFC 2/4] vhost: make buf vector for scatter RX local.

2016-02-19 Thread Ilya Maximets
Array of buf_vector's is just an array for temporary storing information about available descriptors. It used only locally in virtio_dev_merge_rx() and there is no reason for that array to be shared. Fix that by allocating local buf_vec inside virtio_dev_merge_rx(). Signed-off-by: Ilya Maximets

[dpdk-dev] [PATCH RFC 1/4] vhost: use SMP barriers instead of compiler ones.

2016-02-19 Thread Ilya Maximets
Since commit 4c02e453cc62 ("eal: introduce SMP memory barriers") virtio uses architecture dependent SMP barriers. vHost should use them too. Fixes: 4c02e453cc62 ("eal: introduce SMP memory barriers") Signed-off-by: Ilya Maximets --- lib/librte_vhost/vhost_rxtx.c | 6 +++--- 1 file changed, 3

[dpdk-dev] [PATCH RFC 0/4] Thread safe rte_vhost_enqueue_burst().

2016-02-19 Thread Ilya Maximets
Implementation of rte_vhost_enqueue_burst() based on lockless ring-buffer algorithm and contains almost all to be thread-safe, but it's not. This set adds required changes. First patch in set is a standalone patch that fixes many times discussed issue with barriers on different architectures.

[dpdk-dev] Future Direction for rte_eth_stats_get()

2016-02-19 Thread Tahhan, Maryam
> From: David Harton (dharton) [mailto:dharton at cisco.com] > Sent: Friday, February 5, 2016 9:16 PM > To: Van Haaren, Harry ; Thomas > Monjalon > Cc: dev at dpdk.org; Tahhan, Maryam ; > Mcnamara, John > Subject: RE: [dpdk-dev] Future Direction for rte_eth_stats_get() > > > > From: Van

[dpdk-dev] [PATCH RFC 4/4] doc: add note about rte_vhost_enqueue_burst thread safety.

2016-02-19 Thread Xie, Huawei
On 2/19/2016 3:10 PM, Yuanhan Liu wrote: > On Fri, Feb 19, 2016 at 09:32:43AM +0300, Ilya Maximets wrote: >> Signed-off-by: Ilya Maximets >> --- >> doc/guides/prog_guide/thread_safety_dpdk_functions.rst | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git

[dpdk-dev] [PATCH RFC 2/4] vhost: make buf vector for scatter RX local.

2016-02-19 Thread Xie, Huawei
On 2/19/2016 3:31 PM, Ilya Maximets wrote: > On 19.02.2016 10:06, Yuanhan Liu wrote: >> On Fri, Feb 19, 2016 at 09:32:41AM +0300, Ilya Maximets wrote: >>> Array of buf_vector's is just an array for temporary storing information >>> about available descriptors. It used only locally in

[dpdk-dev] [PATCH v2] ixgbe: Fix disable interrupt twice

2016-02-19 Thread Qiu, Michael
On 2016/2/2 19:03, Ananyev, Konstantin wrote: > [...] I don't think i40e miss it, because it not the right please to disable interrupt. because all interrupts are enabled in init stage. Actually, ixgbe enable the interrupt in init stage, but in dev_start, it

[dpdk-dev] [PATCH v4 0/3] add lpm support for NEON

2016-02-19 Thread Jerin Jacob
On Thu, Feb 18, 2016 at 10:26:44AM +, Kobylinski, MichalX wrote: > > > > -Original Message- > > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > > Sent: Tuesday, February 16, 2016 5:44 PM > > To: Kobylinski, MichalX > > Cc: dev at dpdk.org; viktorin at rehivetech.com >

[dpdk-dev] [PATCH v2 2/2] i40evf: support interrupt based pf reset request

2016-02-19 Thread Wu, Jingjing
> I reported an issue on ixgbe. Yes, thanks, we also notice such issue on ixgbe. > What you provide here is a workaround for i40e. > I am not even sure this can be applied to ixgbe. > Yes, not just workaround, also a basic one, without the patch, DPDK VF even doesn't know the pf reset happened. I

[dpdk-dev] [PATCH] i40e: add VEB switching support for i40e

2016-02-19 Thread Wu, Jingjing
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhe Tao > Sent: Thursday, January 21, 2016 2:50 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] i40e: add VEB switching support for i40e > > VEB switching feature for i40e is used to enable the

[dpdk-dev] [PATCH v3 00/30] i40e base driver update

2016-02-19 Thread Wu, Jingjing
> -Original Message- > From: Zhang, Helin > Sent: Thursday, February 18, 2016 10:34 PM > To: dev at dpdk.org > Cc: Wu, Jingjing; Zhang, Helin > Subject: [PATCH v3 00/30] i40e base driver update > > i40e base driver is updated, to support new X722 device IDs, and > use rx control AQ

[dpdk-dev] [PATCH v2 2/2] kdp: add virtual PMD for kernel slow data path communication

2016-02-19 Thread Ferruh Yigit
This patch provides slow data path communication to the Linux kernel. Patch is based on librte_kni, and heavily re-uses it. The main difference is librte_kni library converted into a PMD, to provide ease of use for applications. Now any application can use slow path communication without any

[dpdk-dev] [PATCH v2 1/2] kdp: add kernel data path kernel module

2016-02-19 Thread Ferruh Yigit
This kernel module is based on KNI module, but this one is stripped version of it and only for data messages, no control functionality provided. FIFO implementation of the KNI is kept exact same, but ethtool related code removed and virtual network management related code simplified. This module

[dpdk-dev] [PATCH v2 0/2] slow data path communication between DPDK port and Linux

2016-02-19 Thread Ferruh Yigit
This is slow data path communication implementation based on existing KNI. Difference is: librte_kni converted into a PMD, kdp kernel module is almost same except all control path functionality removed and some simplification done. Motivation is to simplify slow path data communication. Now any

[dpdk-dev] [PATCH v4 4/4] app/test-pmd: test tunnel filter for IP in GRE

2016-02-19 Thread Sun, Xutao
Hi Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, February 18, 2016 8:17 PM > To: Sun, Xutao ; dev at dpdk.org > Cc: Zhang, Helin ; Wu, Jingjing > ; Liu, Jijiang > Subject: RE: [PATCH v4 4/4] app/test-pmd: test tunnel filter for IP in GRE > > Hi Xutao, > >