[dpdk-dev] [PATCH] examples/ip_pipeline: fix flow classification pipeline

2016-03-31 Thread Thomas Monjalon
2016-03-31 12:29, Fan Zhang: > Fixes: examples/ip_pipeline: config parser clean-up Fixes: 1a33c5ea2f45 ("examples/ip_pipeline: clean config parser") > This patch fixes the initialization error in flow classification > pipeline. Originally, when there is no key_mask specified in the > CFG file,

[dpdk-dev] [PATCH] examples/ip_pipeline: fix SSE4.2 optimization branch

2016-03-31 Thread Thomas Monjalon
2016-03-30 20:06, Thomas Monjalon: > The branch was disabled because of a typo in the SSE4.2 flag. > Change also the x86_64 flag to use a DPDK one. > > Fixes: 28377375c6c0 ("examples/ip_pipeline: fix build for x86_64 without > SSE4.2") > > Signed-off-by: Thomas Monjalon > Acked-by: Cristian

[dpdk-dev] [PATCH] l3fwd: fix incorrect size for destination port values

2016-03-31 Thread Thomas Monjalon
2016-03-31 14:07, Konstantin Ananyev: > Fixes: dc81ebbacaeb ("lpm: extend IPv4 next hop field") > > Originally l3fwd used 16-bit value to store dest_port value. > To accommodate 24-bit nexthop dest_port was increased to 32-bit, > though some further packet processing code remained unchanged and >

[dpdk-dev] [PATCH] examples/l3fwd: fix some packets lost when stops receiving

2016-03-31 Thread Thomas Monjalon
> > Not all tx ports was included in tx_port_id array, used to periodically > > drain only available ports. This caused that some packets remain in buffer > > when application stops to receiving packets. > > > > Fixes: 52c97adc1f0f ("examples/l3fwd: fix exact match performance") > > > >

[dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix missed headers for FreeBSD

2016-03-31 Thread Thomas Monjalon
2016-03-31 14:02, Sergio Gonzalez Monroy: > On 31/03/2016 13:43, Daniel Mrzyglod wrote: > > In FreeBSD, sys/types.h and netinet/in.h need to be included before > > netinet/ip.h > > > > There were misssed typedef for u_char - > > There were missed network definitions - > > > > Failure #13:

[dpdk-dev] [PATCH v3 0/8] L2fwd-crypto fixes/enhancements

2016-03-31 Thread Thomas Monjalon
> > Pablo de Lara (8): > >l2fwd-crypto: add missing new line character in help > >l2fwd-crypto: rename period parameter > >l2fwd-crypto: add missing string initialization > >l2fwd-crypto: fix length of random IV/AAD > >l2fwd-crypto: fix ambiguous input key size > >

[dpdk-dev] [PATCH] dpdk_qat: fix error message in Makefile

2016-03-31 Thread Thomas Monjalon
2016-03-29 19:28, Pablo de Lara: > When compiling dpdk_qat app with an i686 target on a x86_64 OS, > an error message was shown, saying that it can only be built > on a 32-bit OS, which should be i686 OS, as other 32-bit OS > are not supported. > > Fixes: commit 3460012bcce6 ("examples/qat:

[dpdk-dev] [PATCH] qat: Fix for crash when nb_ops=0 on enqueue_burst

2016-03-31 Thread Thomas Monjalon
2016-03-29 18:10, Fiona Trahe: > Crash seen in qat pmd when nb_ops=0 on rte_cryptodev_enqueue_burst() API > > Signed-off-by: Fiona Trahe Applied, thanks

[dpdk-dev] [PATCH v2 0/2] Out of place operations for symmetric crypto

2016-03-31 Thread Thomas Monjalon
2016-03-30 16:52, John Griffin: > On 29/03/16 15:14, Fiona Trahe wrote: > > From: Arek Kusztal > > > > This patch adds out of place operations for qat symmetric crypto PMD, > > i.e. the result of the operation can be written to the destination buffer > > instead of overwriting the source buffer

[dpdk-dev] [PATCH] vmxnet3: remove asserts that confuse coverity

2016-03-31 Thread Thomas Monjalon
> >These asserts are only for debugging and never fired during > >any testing, but they confuse coverity's null tracking. > > > >Signed-off-by: Stephen Hemminger > > Acked-by: Yong Wang Applied, thanks

[dpdk-dev] [PATCH] doc: fill nics features matrix for mlx4 & mlx5

2016-03-31 Thread Tan, Jianfeng
Hi, On 3/31/2016 7:00 PM, Adrien Mazarguil wrote: > On Thu, Mar 31, 2016 at 06:55:41PM +0800, Tan, Jianfeng wrote: >> Hi, >> >> On 3/31/2016 6:22 PM, Adrien Mazarguil wrote: >>> Signed-off-by: Adrien Mazarguil >>> --- >>> doc/guides/nics/overview.rst | 56 >>>

[dpdk-dev] [PATCH v3] i40e: fix TSO issue for tx function

2016-03-31 Thread Zhe Tao
Issue: when using the following CLI in testpmd to enable ipv6 TSO feature (set --txqflags=0 in the testpmd command) set verbose 1 csum set ip hw 0 csum set udp hw 0 csum set tcp hw 0 csum set sctp hw 0 csum set outer-ip hw 0 csum

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-31 Thread Harish Patil
> >On Wed, 30 Mar 2016 22:16:51 + >Harish Patil wrote: > >> > >> >On Tue, 29 Mar 2016 22:28:20 -0700 >> >Rasesh Mody wrote: >> > >> >> + >> >> +static void qede_print_adapter_info(struct qede_dev *qdev) >> >> +{ >> >> + struct ecore_dev *edev = >edev; >> >> + struct qed_dev_info *info =

[dpdk-dev] [PATCH v5 10/10] qede: Enable PMD build

2016-03-31 Thread Rasesh Mody
This patch enables the QEDE PMD build. Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody Signed-off-by: Sony Chacko --- config/common_base| 14 ++ drivers/net/Makefile |1 + mk/rte.app.mk |2 ++ scripts/test-build.sh |1 + 4 files changed, 18

[dpdk-dev] [PATCH v5 09/10] qede: Add DCBX support

2016-03-31 Thread Rasesh Mody
This patch adds LLDP and DCBX capabilities to the qede PMD. Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody Signed-off-by: Sony Chacko --- drivers/net/qede/Makefile |1 + drivers/net/qede/base/bcm_osal.h |1 + drivers/net/qede/base/ecore.h |

[dpdk-dev] [PATCH v5 08/10] qede: Add attention support

2016-03-31 Thread Rasesh Mody
Physical link is handled by the management Firmware. This patch lays the infrastructure for attention handling in the driver, as link change notifications arrive via async attentions, as well as the handling of such notifications. It adds async event notification handler interfaces to the PMD.

[dpdk-dev] [PATCH v5 07/10] qede: Add SRIOV support

2016-03-31 Thread Rasesh Mody
This patch adds following SRIOV features to qede PMD: - VF configuration - VF intialization/de-initialization - VF PF communications channel - statistics capture and query Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody Signed-off-by: Sony Chacko --- drivers/net/qede/Makefile

[dpdk-dev] [PATCH v5 06/10] qede: Add L2 support

2016-03-31 Thread Rasesh Mody
This patch adds the features to supports configuration of various Layer 2 elements, such as channels and filtering options. Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody Signed-off-by: Sony Chacko --- drivers/net/qede/Makefile|2 + drivers/net/qede/base/ecore_chain.h

[dpdk-dev] [PATCH v5 05/10] qede: Add core driver

2016-03-31 Thread Rasesh Mody
The Qlogic Everest Driver for Ethernet(QEDE) Poll Mode Driver(PMD) is the DPDK specific module for QLogic FastLinQ QL4 25G/40G CNA family of adapters as well as their virtual functions (VF) in SR-IOV context. This patch adds QEDE PMD, which interacts with base driver and initialises the HW.

[dpdk-dev] [PATCH v5 04/10] qede: Add base driver

2016-03-31 Thread Rasesh Mody
The base driver is the backend module for the QLogic FastLinQ QL4 25G/40G CNA family of adapters as well as their virtual functions (VF) in SR-IOV context. The purpose of the base module is to: - provide all the common code that will be shared between the various drivers that would be

[dpdk-dev] [PATCH v5 03/10] qede: Add license file

2016-03-31 Thread Rasesh Mody
Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody Signed-off-by: Sony Chacko --- drivers/net/qede/LICENSE.qede_pmd | 28 1 file changed, 28 insertions(+) create mode 100644 drivers/net/qede/LICENSE.qede_pmd diff --git a/drivers/net/qede/LICENSE.qede_pmd

[dpdk-dev] [PATCH v5 02/10] qede: Add documentation

2016-03-31 Thread Rasesh Mody
Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody Signed-off-by: Sony Chacko --- doc/guides/nics/index.rst|1 + doc/guides/nics/overview.rst | 78 +- doc/guides/nics/qede.rst | 340 ++ 3 files changed, 380 insertions(+), 39

[dpdk-dev] [PATCH v5 01/10] qede: Add maintainers

2016-03-31 Thread Rasesh Mody
Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody Signed-off-by: Sony Chacko --- MAINTAINERS |7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e848ffa..fff6187 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -371,6 +371,13 @@ M: Declan Doherty

[dpdk-dev] [PATCH v5 00/10] qede: Add qede PMD

2016-03-31 Thread Rasesh Mody
Hi Thomas, Bruce, The v5 series incorporates the following review comments: - move adapter_info logs under debug - implement qede_mac_addr_remove() - remove unused rc variable in qede_dev_configure() - fix indentation in qede_dev_info_get() - use c99 style struct init in

[dpdk-dev] [PATCH] doc: fill nics features matrix for mlx4 & mlx5

2016-03-31 Thread Tan, Jianfeng
Hi, On 3/31/2016 6:22 PM, Adrien Mazarguil wrote: > Signed-off-by: Adrien Mazarguil > --- > doc/guides/nics/overview.rst | 56 > ++-- > 1 file changed, 28 insertions(+), 28 deletions(-) > > diff --git a/doc/guides/nics/overview.rst

[dpdk-dev] [PATCH v13 0/8] ethdev: 100G and link speed API refactoring

2016-03-31 Thread Adrien Mazarguil
On Sat, Mar 26, 2016 at 09:11:38AM +0100, Thomas Monjalon wrote: > > v13: > > - Fix startup regression; revert flip of ETH_LINK_SPEED_FIXED and > > ETH_LINK_SPEED_AUTONEG values. ETH_LINK_SPEED_AUTONEG is now 0. > > As commented earlier, I would prefer avoiding this revert. > Comments

[dpdk-dev] [PATCH] vmxnet3: remove asserts that confuse coverity

2016-03-31 Thread Yong Wang
On 3/30/16, 2:38 PM, "Stephen Hemminger" wrote: >These asserts are only for debugging and never fired during >any testing, but they confuse coverity's null tracking. > >Signed-off-by: Stephen Hemminger >--- Acked-by: Yong Wang > drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 -- > 1 file changed,

[dpdk-dev] [PATCH v2 4/4] bnx2x: Update PMD version to 1.0.1.1

2016-03-31 Thread Rasesh Mody
Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index 149fdef..dcd21f8 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -32,18

[dpdk-dev] [PATCH v2 3/4] bnx2x: Enhance stats get routine

2016-03-31 Thread Rasesh Mody
Enhance the stats_get() routine to display drop counters under the control of a debug flag. Fix RX stats. Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x_ethdev.c | 53 ++ drivers/net/bnx2x/bnx2x_rxtx.c |2 ++ 2

[dpdk-dev] [PATCH v2 2/4] bnx2x: Fix Tx Performance

2016-03-31 Thread Rasesh Mody
Change the Tx routine logic to ring the doorbell once per burst and not on every Tx packet. This driver-level optimization is necessary to achieve line rates for larger frame sizes (1k or more). Fixes: 540a211084a7 ("bnx2x: driver core") Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody

[dpdk-dev] [PATCH v2 1/4] bnx2x: Update documentation

2016-03-31 Thread Rasesh Mody
Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody --- doc/guides/nics/bnx2x.rst|1 + doc/guides/nics/overview.rst | 20 ++-- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.rst index

[dpdk-dev] DPDK: receive single packet at a time

2016-03-31 Thread Mohan Prasad
Could not get it working by disabling the vector PMD, Do you have any example where it works? Thanks, Mohan On Wed, Mar 30, 2016 at 11:06 AM, Mohan Prasad wrote: > Hi Bruce, > > Could not get it working by disabling the vector PMD, Do you have any > example where it works? > > Thanks, > Mohan

[dpdk-dev] [PATCH] fm10k: conditionally disable RSS during device initialization

2016-03-31 Thread Thomas Monjalon
> > If the provided configuration does not call for RSS, then RSS is > > explicitly disabled. Without this change, the device continues to > > operate under the previous RSS configuration. > > > > Fixes: 57033cdf8fdc ("fm10k: add PF RSS") > > > > Signed-off-by: Michael Frasca > Acked-by : Jing

[dpdk-dev] [PATCH v2 0/7] Various fixes to compile with gcc6

2016-03-31 Thread Thomas Monjalon
2016-03-22 17:37, Aaron Conole: > This series brings a number of code cleanups to allow building using gcc6, > with various legitimate warnings being fixed. > > Some of these fixes are to the drivers area, making this series a bit > atypical. However, the fixes identified in patches 2 and 3 are

[dpdk-dev] Reg: promiscuous mode on VF

2016-03-31 Thread bharath paulraj
Hi Michael and All, I am unable to set the rule to receive the packet on the VF. Below is my setup. 1. Creating one virtual function with one queue, in one of my port, p2p1. *modprobe ixgbe MQ=1 max_vfs=1 RSS=1 allow_unsupported_sfp=1 * 2. Below is the interface status after

[dpdk-dev] [PATCH] fm10k: conditionally disable RSS during device initialization

2016-03-31 Thread Thomas Monjalon
Please, anyone to confirm that the patch is valid and must be applied? This discussion shows some doubts. 2016-03-24 13:35, Michael Frasca: > Jing, > > Thanks for your assistance. The experiment that you have built should allow > you > to observe the bug. In [5], I would expect that queue 0

[dpdk-dev] [PATCH v4] vhost: use SMP barriers instead of compiler ones.

2016-03-31 Thread Thomas Monjalon
2016-03-23 14:07, Xie, Huawei: > On 3/18/2016 8:24 PM, Ilya Maximets wrote: > > Since commit 4c02e453cc62 ("eal: introduce SMP memory barriers") virtio > > uses architecture dependent SMP barriers. vHost should use them too. > > > > Fixes: 4c02e453cc62 ("eal: introduce SMP memory barriers") > > >

[dpdk-dev] [PATCH 3/4] port: fix full burst checks in f_tx_bulk ops

2016-03-31 Thread Dumitrescu, Cristian
> -Original Message- > From: Robert Sanford [mailto:rsanford2 at gmail.com] > Sent: Monday, March 28, 2016 9:52 PM > To: dev at dpdk.org; Dumitrescu, Cristian > Subject: [PATCH 3/4] port: fix full burst checks in f_tx_bulk ops > > For several f_tx_bulk functions in

[dpdk-dev] [PATCH] vmxnet3: fix txq flags check

2016-03-31 Thread Thomas Monjalon
2016-03-28 15:35, Yong Wang: > Now that vmxnet3 supports TCP/UDP checksum offload, let's update > the default txq flags to allow such offloads. Also fixed the tx > queue setup check to allow TCP/UDP checksum and only error out > if SCTP checksum is requested. > > Fixes: f598fd063bb1 ("vmxnet3:

[dpdk-dev] [PATCH] examples/l3fwd: fix some packets lost when stops receiving

2016-03-31 Thread Tomasz Kulasek
Not all tx ports was included in tx_port_id array, used to periodically drain only available ports. This caused that some packets remain in buffer when application stops to receiving packets. Fixes: 52c97adc1f0f ("examples/l3fwd: fix exact match performance") Signed-off-by: Tomasz Kulasek ---

[dpdk-dev] [PATCH] nfp: copy pci info from pci to ethdev

2016-03-31 Thread Thomas Monjalon
2016-03-29 08:16, Alejandro Lucero: > Hi guys, > > Sorry for the delay but I was on a Easter break. > > That patch is OK for me. In fact, I had one patch ready for upstreaming > with this change needed for supporting hotplug. I was waiting for some > feedback from one internal project needing

[dpdk-dev] [PATCH v2] mlx5: fix RETA table size

2016-03-31 Thread Thomas Monjalon
2016-03-31 11:36, Adrien Mazarguil: > On Thu, Mar 31, 2016 at 12:21:08PM +0300, Yaacov Hazan wrote: > > When the number of RX queues is not a power of two, > > the RETA table is configured to its maximum size for > > better balancing. > > > > Testing showed that limiting its size to 256 improves

[dpdk-dev] [PATCH] doc: fill nics features matrix for mlx4 & mlx5

2016-03-31 Thread Thomas Monjalon
2016-03-31 20:50, Tan, Jianfeng: > Thanks for explanation. I was wrongly treating "X" as "not supported" > previously. I was looking at "TSO", and it indicates by the table that > ixgbe does not support TSO, which does not make sense to me. Or this doc > is not updated efficiently? According

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-31 Thread Stephen Hemminger
On Thu, 31 Mar 2016 19:36:55 + Harish Patil wrote: > > > > >On Wed, 30 Mar 2016 22:16:51 + > >Harish Patil wrote: > > > >> > > >> >On Tue, 29 Mar 2016 22:28:20 -0700 > >> >Rasesh Mody wrote: > >> > > >> >> + > >> >> +static void qede_print_adapter_info(struct qede_dev *qdev) > >> >>

[dpdk-dev] [PATCH] mlx: fix double mbuf free in TX queue clean up function

2016-03-31 Thread Thomas Monjalon
2016-03-31 11:43, Adrien Mazarguil: > Once freed, completed mbufs pointers are not set to NULL in the TX queue. > Clean up function must take this into account. > > Fixes: 2e22920b85d9 ("mlx5: support non-scattered Tx and Rx") > Fixes: 7fae69eeff13 ("mlx4: new poll mode driver") > >

[dpdk-dev] [PATCH] i40e: fix crash when dcb query

2016-03-31 Thread Thomas Monjalon
2016-03-28 15:37, Jingjing Wu: > Calling rte_eth_dev_get_dcb_info to get dcb info from i40e > driver if VMDQ is disabled, results in a segmentation fault. > This patch fixes it by treating VMDQ and No-VMDQ respectively > when querying dcb information. > > Fixes: 5135f3ca49a7 ("i40e: enable DCB in

[dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix missed headers for FreeBSD

2016-03-31 Thread Daniel Mrzyglod
In FreeBSD, sys/types.h and netinet/in.h need to be included before netinet/ip.h There were misssed typedef for u_char - There were missed network definitions - Failure #13: http://dpdk.org/ml/archives/test-report/2016-March/001896.html Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec

[dpdk-dev] [PATCH] doc: announce ABI change for rte_port_source_params structure

2016-03-31 Thread Fan Zhang
Several new fields will be added to structure rte_port_source_params for source port enhancement with pcap file reading support. Signed-off-by: Fan Zhang Acked-by: Cristian Dumitrescu --- doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 insertions(+) diff --git

[dpdk-dev] [PATCH v13 6/8] ethdev: redesign link speed config

2016-03-31 Thread Thomas Monjalon
2016-03-31 00:57, Xing, Beilei: > I?ve verified v13 + the modification, and it works. Please, what have you tested? Which drivers? Which configurations? It is important to test several uses of rte_eth_conf.link_speeds: - ETH_LINK_SPEED_AUTONEG (all speeds) - ETH_LINK_SPEED_FIXED (only one speed)

[dpdk-dev] [PATCH] doc: announce ABI change for rte_port_source_params structure

2016-03-31 Thread Fan Zhang
Several new fields will be added to structure rte_port_source_params for source port enhancement with pcap file reading support. Signed-off-by: Fan Zhang Acked-by: Cristian Dumitrescu --- doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 insertions(+) diff --git

[dpdk-dev] [PATCH v3 0/8] L2fwd-crypto fixes/enhancements

2016-03-31 Thread Thomas Monjalon
2016-03-31 13:14, Bruce Richardson: > On Thu, Mar 31, 2016 at 10:32:06AM +0100, Pablo de Lara wrote: > > This patches fixes some small issues in L2fwd-crypto > > app and also improves the app, making it more flexible > > (accepting different key sizes) > > and readable (information display

[dpdk-dev] [PATCH] igb: change default RX wthresh back

2016-03-31 Thread Wenzhuo Lu
A problem is found on i350 VF. TX will happen once per 4 packets. If only 1~3 packets are received, they will not be forwarded. The reason is the default RX write-back threshold is changed to 4. This patch changes the value back to 0, so every packet can be handled immediately. Fixes:

[dpdk-dev] [PATCH] i40e: Fix a typo in fdir.

2016-03-31 Thread Thomas Monjalon
2016-03-27 13:58, Rami Rosen: > Signed-off-by: Rami Rosen Applied, thanks

[dpdk-dev] [PATCH] fm10k: conditionally disable RSS during device initialization

2016-03-31 Thread Chen, Jing D
Thomas, We've agreed offline that the patch works without side effect. Please kindly apply if possible. > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, March 31, 2016 9:57 PM > To: dev at dpdk.org > Cc: Michael Frasca ; Chen, Jing D >

[dpdk-dev] [PATCH] l3fwd: fix incorrect size for destination port values

2016-03-31 Thread Konstantin Ananyev
Fixes: dc81ebbacaeb ("lpm: extend IPv4 next hop field") Originally l3fwd used 16-bit value to store dest_port value. To accommodate 24-bit nexthop dest_port was increased to 32-bit, though some further packet processing code remained unchanged and still expects dest_port to be 16-bit. That is not

[dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix missed headers for FreeBSD

2016-03-31 Thread Sergio Gonzalez Monroy
On 31/03/2016 13:43, Daniel Mrzyglod wrote: > In FreeBSD, sys/types.h and netinet/in.h need to be included before > netinet/ip.h > > There were misssed typedef for u_char - > There were missed network definitions - > > Failure #13: http://dpdk.org/ml/archives/test-report/2016-March/001896.html >

[dpdk-dev] [PATCH] examples/l3fwd: fix some packets lost when stops receiving

2016-03-31 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tomasz Kulasek > Sent: Thursday, March 31, 2016 2:38 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] examples/l3fwd: fix some packets lost when stops > receiving > > Not all tx ports was included in

[dpdk-dev] [PATCH v3 0/8] L2fwd-crypto fixes/enhancements

2016-03-31 Thread Declan Doherty
On 31/03/16 10:32, Pablo de Lara wrote: > This patches fixes some small issues in L2fwd-crypto > app and also improves the app, making it more flexible > (accepting different key sizes) > and readable (information display improvement). > > Series-tested-by: Min Cao > > > Changes in v3: > > -

[dpdk-dev] [PATCH 4/4] port: fix ethdev writer burst too big

2016-03-31 Thread Dumitrescu, Cristian
> -Original Message- > From: Robert Sanford [mailto:rsanford2 at gmail.com] > Sent: Monday, March 28, 2016 9:52 PM > To: dev at dpdk.org; Dumitrescu, Cristian > Subject: [PATCH 4/4] port: fix ethdev writer burst too big > > For f_tx_bulk functions in rte_port_ethdev.c, we may

[dpdk-dev] [PATCH v3] i40e: fix TSO issue for tx function

2016-03-31 Thread Bruce Richardson
On Thu, Mar 31, 2016 at 08:15:58PM +0800, Zhe Tao wrote: > Issue: > > when using the following CLI in testpmd to enable ipv6 TSO feature > (set --txqflags=0 in the testpmd command) > set verbose 1 > csum set ip hw 0 > csum set udp hw 0 > csum set tcp hw 0 > csum set

[dpdk-dev] [PATCH v3 0/8] L2fwd-crypto fixes/enhancements

2016-03-31 Thread Bruce Richardson
On Thu, Mar 31, 2016 at 10:32:06AM +0100, Pablo de Lara wrote: > This patches fixes some small issues in L2fwd-crypto > app and also improves the app, making it more flexible > (accepting different key sizes) > and readable (information display improvement). > > Series-tested-by: Min Cao > Hi,

[dpdk-dev] [PATCH] virtio: use zeroed memory for simple TX header

2016-03-31 Thread Rich Lane
For simple TX the virtio-net header must be zeroed, but it was using memory that had been initialized with indirect descriptor tables. This resulted in "unsupported gso type" errors from librte_vhost. We can use the same memory for every descriptor to save cachelines in the vswitch.

[dpdk-dev] [PATCH] doc: fill nics features matrix for mlx4 & mlx5

2016-03-31 Thread Adrien Mazarguil
On Thu, Mar 31, 2016 at 06:55:41PM +0800, Tan, Jianfeng wrote: > Hi, > > On 3/31/2016 6:22 PM, Adrien Mazarguil wrote: > >Signed-off-by: Adrien Mazarguil > >--- > > doc/guides/nics/overview.rst | 56 > > ++-- > > 1 file changed, 28 insertions(+), 28

[dpdk-dev] DPDK: receive single packet at a time

2016-03-31 Thread Wiles, Keith
> >From: Mohan Prasad >Date: Thursday, March 31, 2016 at 6:42 AM >To: Bruce Richardson >Cc: Keith Wiles , "dev at dpdk.org" dpdk.org> >Subject: Re: [dpdk-dev] DPDK: receive single packet at a time > > >>Could not get it working by disabling the vector PMD, Do you have any example >>where

[dpdk-dev] DPDK: receive single packet at a time

2016-03-31 Thread Wiles, Keith
From: Mohan Prasad Date: Thursday, March 31, 2016 at 6:42 AM To: Bruce Richardson Cc: Keith Wiles , "dev at dpdk.org" Subject: Re: [dpdk-dev] DPDK: receive single packet at a time >Could not get it working by disabling the vector PMD, Do you have any example

[dpdk-dev] [PATCH] examples/ip_pipeline: fix flow classification pipeline

2016-03-31 Thread Fan Zhang
Fixes: examples/ip_pipeline: config parser clean-up This patch fixes the initialization error in flow classification pipeline. Originally, when there is no key_mask specified in the CFG file, all '0' mask is utilized. Signed-off-by: Fan Zhang Acked-by: Cristian Dumitrescu ---

[dpdk-dev] [PATCH] doc: fill nics features matrix for mlx4 & mlx5

2016-03-31 Thread Adrien Mazarguil
Signed-off-by: Adrien Mazarguil --- doc/guides/nics/overview.rst | 56 ++-- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/doc/guides/nics/overview.rst b/doc/guides/nics/overview.rst index 542479a..5238088 100644 ---

[dpdk-dev] [PATCH] examples/ipsec-secgw: Fix Missed Headers For FreeBSD

2016-03-31 Thread Sergio Gonzalez Monroy
Commit title shouldn't contain capital letters. On 31/03/2016 10:12, Daniel Mrzyglod wrote: > There were misssed typedef for u_char - > There were missed network definitions - Something a bit more descriptive along the lines of: In FreeBSD, sys/types.h and netinet/in.h need to be included

[dpdk-dev] [PATCH v2] mlx5: fix RETA table size

2016-03-31 Thread Yaacov Hazan
When the number of RX queues is not a power of two, the RETA table is configured to its maximum size for better balancing. Testing showed that limiting its size to 256 improves performance noticeably with little to no impact on balancing results. Fixes: ebb30ec64a68 ("mlx5: increase RETA table

[dpdk-dev] [PATCH v2] i40e: fix ipv6 TSO issue for tx function

2016-03-31 Thread Zhe Tao
On Thu, Mar 24, 2016 at 03:00:14PM +, Bruce Richardson wrote: > On Wed, Mar 23, 2016 at 11:27:50AM +0800, Zhe Tao wrote: > > Issue: > > when using the following CLI in testpmd to enable ipv6 TSO feature > > = > > set verbose 1 > > csum set ip hw 0 > > csum set udp hw 0 > > csum set

[dpdk-dev] [PATCH 1/4] lpm: allocation of an existing object should fail

2016-03-31 Thread Bruce Richardson
On Wed, Mar 30, 2016 at 02:46:49PM -0700, Stephen Hemminger wrote: > On Wed, 30 Mar 2016 17:30:24 +0200 > Olivier Matz wrote: > > > diff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c > > index 4c44cd7..9877a30 100644 > > --- a/lib/librte_lpm/rte_lpm6.c > > +++

[dpdk-dev] [PATCH] mlx: fix double mbuf free in TX queue clean up function

2016-03-31 Thread Adrien Mazarguil
Once freed, completed mbufs pointers are not set to NULL in the TX queue. Clean up function must take this into account. Fixes: 2e22920b85d9 ("mlx5: support non-scattered Tx and Rx") Fixes: 7fae69eeff13 ("mlx4: new poll mode driver") Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c

[dpdk-dev] [PATCH v2] mlx5: fix RETA table size

2016-03-31 Thread Adrien Mazarguil
On Thu, Mar 31, 2016 at 12:21:08PM +0300, Yaacov Hazan wrote: > When the number of RX queues is not a power of two, > the RETA table is configured to its maximum size for > better balancing. > > Testing showed that limiting its size to 256 improves performance > noticeably with little to no

[dpdk-dev] [PATCH 2/4] port: fix ring writer buffer overflow

2016-03-31 Thread Dumitrescu, Cristian
> -Original Message- > From: Robert Sanford [mailto:rsanford2 at gmail.com] > Sent: Monday, March 28, 2016 9:52 PM > To: dev at dpdk.org; Dumitrescu, Cristian > Subject: [PATCH 2/4] port: fix ring writer buffer overflow > > Ring writer tx_bulk functions may write past the end of

[dpdk-dev] [PATCH v2 0/8] L2fwd-crypto fixes/enhancements

2016-03-31 Thread Thomas Monjalon
2016-03-31 10:01, Pablo de Lara: > This patches fixes some small issues in L2fwd-crypto > app and also improves the app, making it more flexible > (accepting different key sizes) > and readable (information display improvement). > > Changes in v2: > > - Extended help information The line

[dpdk-dev] [PATCH] examples/ipsec-secgw: Fix Missed Headers For FreeBSD

2016-03-31 Thread Daniel Mrzyglod
There were misssed typedef for u_char - There were missed network definitions - Failure #13: http://dpdk.org/ml/archives/test-report/2016-March/001896.html Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application") Signed-off-by: Daniel Mrzyglod ---

[dpdk-dev] [PATCH] mlx5: fix RETA table size

2016-03-31 Thread Adrien Mazarguil
Yaacov, On Wed, Mar 30, 2016 at 06:27:19PM +0300, Yaacov Hazan wrote: > Change RETA table size to use 256 entries for better performance. > > Fixes: ebb30ec64a68 ("mlx5: increase RETA table size") > > Signed-off-by: Yaacov Hazan > --- > drivers/net/mlx5/mlx5_defs.h | 2 +- > 1 file changed, 1

[dpdk-dev] Must kni be associated with a dpdk port?

2016-03-31 Thread Ferruh Yigit
On 3/30/2016 6:20 PM, ALeX Wang wrote: > Hi, > > I want to use 'rte_kni_alloc()' to create a kernel iface and > use it to test application rx. From the api and example in > 'examples/kni/main.c', i saw the 'conf' argument is assigned > with pci info of a dpdk port. > > Want to ask if this is

[dpdk-dev] [PATCH] bonding: fix bond link detect in non-interrupt mode

2016-03-31 Thread Nelson Escobar
Thomas, Sorry, I should have included the following fixes line: Fixes: a45b288ef21a("bond: support link status polling") Please add it to the commit message when applying if there are no other problems with the patch. Nelson. On 3/31/2016 6:40 AM, Thomas Monjalon wrote: > 2016-03-25 17:44,

[dpdk-dev] [PATCH v3 8/8] l2fwd-crypto: extend crypto information

2016-03-31 Thread Pablo de Lara
Display extra crypto information (algorithms, keys/IV/AAD used, chain...), so user can know exactly what operations are being carried out. Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 84 ++-- 1 file changed, 82 insertions(+), 2

[dpdk-dev] [PATCH v3 7/8] l2fwd-crypto: use key-value list of supported algorithms

2016-03-31 Thread Pablo de Lara
In order to ease the parsing and display of supported algorithms in the application, two new arrays are created, which contains the strings of the different cipher and authentication algorithms, These lists are used to parse the algorithms from the command line, and will be used to display crypto

[dpdk-dev] [PATCH v3 6/8] l2fwd-crypto: clarify key parsing in help

2016-03-31 Thread Pablo de Lara
Cipher/Auth keys, AAD and IV must be passed from command line with ":" between bytes, but help was not clarifying that. Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/l2fwd-crypto/main.c

[dpdk-dev] [PATCH v3 5/8] l2fwd-crypto: fix ambiguous input key size

2016-03-31 Thread Pablo de Lara
Some crypto algorithms support more than one key size (including cipher key, authentication key, IV and AAD), but the app was using always the minimum size. These changes allows the user to use an specific size, either from the string provided with cipher_key, auth_key, iv and ADD parameters, or

[dpdk-dev] [PATCH v3 4/8] l2fwd-crypto: fix length of random IV/AAD

2016-03-31 Thread Pablo de Lara
App was generating a random IV/AAD of only 4 bytes, instead of the actual length, since it was using sizeof(length). Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities") Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[dpdk-dev] [PATCH v3 3/8] l2fwd-crypto: add missing string initialization

2016-03-31 Thread Pablo de Lara
When passing the preferred crypto device type in the command line parameters, the string (HW/SW/ANY) was not being saved, which is used for error information to the user. Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities") Signed-off-by: Pablo de Lara ---

[dpdk-dev] [PATCH v3 2/8] l2fwd-crypto: rename period parameter

2016-03-31 Thread Pablo de Lara
L2fwd-crypto app is based on L2fwd app and it inherits some of its parameters (such as portmask, queues per core...). The parameter period (period of time between statistic updates) is -T in L2fwd, but was -t in L2fwd-crypto, so for consistency, it is changed back to -T Fixes: 387259bd6c67

[dpdk-dev] [PATCH v3 1/8] l2fwd-crypto: add missing new line character in help

2016-03-31 Thread Pablo de Lara
Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application) Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 5fd4ff1..0cb46c2 100644 ---

[dpdk-dev] [PATCH v3 0/8] L2fwd-crypto fixes/enhancements

2016-03-31 Thread Pablo de Lara
This patches fixes some small issues in L2fwd-crypto app and also improves the app, making it more flexible (accepting different key sizes) and readable (information display improvement). Series-tested-by: Min Cao Changes in v3: - Added missing Tested-by line. Changes in v2: - Extended help

[dpdk-dev] [PATCH v2 8/8] l2fwd-crypto: extend crypto information

2016-03-31 Thread Pablo de Lara
Display extra crypto information (algorithms, keys/IV/AAD used, chain...), so user can know exactly what operations are being carried out. Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 84 ++-- 1 file changed, 82 insertions(+), 2

[dpdk-dev] [PATCH v2 7/8] l2fwd-crypto: use key-value list of supported algorithms

2016-03-31 Thread Pablo de Lara
In order to ease the parsing and display of supported algorithms in the application, two new arrays are created, which contains the strings of the different cipher and authentication algorithms, These lists are used to parse the algorithms from the command line, and will be used to display crypto

[dpdk-dev] [PATCH v2 6/8] l2fwd-crypto: clarify key parsing in help

2016-03-31 Thread Pablo de Lara
Cipher/Auth keys, AAD and IV must be passed from command line with ":" between bytes, but help was not clarifying that. Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/l2fwd-crypto/main.c

[dpdk-dev] [PATCH v2 5/8] l2fwd-crypto: fix ambiguous input key size

2016-03-31 Thread Pablo de Lara
Some crypto algorithms support more than one key size (including cipher key, authentication key, IV and AAD), but the app was using always the minimum size. These changes allows the user to use an specific size, either from the string provided with cipher_key, auth_key, iv and ADD parameters, or

[dpdk-dev] [PATCH v2 4/8] l2fwd-crypto: fix length of random IV/AAD

2016-03-31 Thread Pablo de Lara
App was generating a random IV/AAD of only 4 bytes, instead of the actual length, since it was using sizeof(length). Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities") Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[dpdk-dev] [PATCH v2 3/8] l2fwd-crypto: add missing string initialization

2016-03-31 Thread Pablo de Lara
When passing the preferred crypto device type in the command line parameters, the string (HW/SW/ANY) was not being saved, which is used for error information to the user. Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities") Signed-off-by: Pablo de Lara ---

[dpdk-dev] [PATCH v2 2/8] l2fwd-crypto: rename period parameter

2016-03-31 Thread Pablo de Lara
L2fwd-crypto app is based on L2fwd app and it inherits some of its parameters (such as portmask, queues per core...). The parameter period (period of time between statistic updates) is -T in L2fwd, but was -t in L2fwd-crypto, so for consistency, it is changed back to -T Fixes: 387259bd6c67

[dpdk-dev] [PATCH v2 1/8] l2fwd-crypto: add missing new line character in help

2016-03-31 Thread Pablo de Lara
Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application) Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 5fd4ff1..0cb46c2 100644 ---

[dpdk-dev] [PATCH v2 0/8] L2fwd-crypto fixes/enhancements

2016-03-31 Thread Pablo de Lara
This patches fixes some small issues in L2fwd-crypto app and also improves the app, making it more flexible (accepting different key sizes) and readable (information display improvement). Changes in v2: - Extended help information Pablo de Lara (8): l2fwd-crypto: add missing new line

[dpdk-dev] [PATCH 1/2] Fix CPU and memory parameters on IBM POWER8

2016-03-31 Thread Chao Zhu
Thomas, Seems I didn't get the messages from David. Anyway, I sent out an updated patch. Thanks for reminder! -Original Message- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: 2016?3?30? 18:53 To: Chao Zhu Cc: dev at dpdk.org; David Marchand ; Richardson, Bruce ; Panu

[dpdk-dev] [PATCH 0/4] fix lpm and hash creation

2016-03-31 Thread Olivier Matz
On 03/30/2016 05:30 PM, Olivier Matz wrote: > Seen while trying to fix the func_reentrancy autotest. The > series addresses several issues: > > 1/ Hash and lpm return a pointer to an existing object if the user requests > the >creation with an already existing name. This look dangerous:

[dpdk-dev] [PATCH 1/4] lpm: allocation of an existing object should fail

2016-03-31 Thread Olivier Matz
Hi Stephen, On 03/30/2016 11:46 PM, Stephen Hemminger wrote: > On Wed, 30 Mar 2016 17:30:24 +0200 > Olivier Matz wrote: > >> diff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c >> index 4c44cd7..9877a30 100644 >> --- a/lib/librte_lpm/rte_lpm6.c >> +++ b/lib/librte_lpm/rte_lpm6.c

  1   2   >