[dpdk-dev] [dpdk-dev, 07/10] lib: fix missing include dependencies

2016-04-05 Thread Jan Viktorin
Hello Adrien, just quickly skimming through the ARM fixes... On Tue, 5 Apr 2016 16:08:07 +0200 Adrien Mazarguil wrote: > Exported header files for use by applications should be self sufficient and > allow out of order inclusion. Moreover, they must include all the system > headers they need

[dpdk-dev] [RFC] vhost-user public struct refactor (was Re: [PATCH RFC 2/4] vhost: make buf vector for scatter RX) local.

2016-04-05 Thread Yuanhan Liu
On Tue, Apr 05, 2016 at 10:37:13AM +0200, Thomas Monjalon wrote: > 2016-04-05 13:47, Yuanhan Liu: > > So, I was considering to add vhost-user Tx delayed-copy (or zero copy) > > support recently, which comes to yet another ABI violation, as we need > > add a new field to virtio_memory_regions

[dpdk-dev] [PATCH] doc: announce ABI change for rte_port_source_params structure

2016-04-05 Thread Singh, Jasvinder
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Fan Zhang > Sent: Thursday, March 31, 2016 2:29 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] doc: announce ABI change for > rte_port_source_params structure > > Several new fields will be added to

[dpdk-dev] [PATCH] doc: announce xstats api change for 16.07

2016-04-05 Thread Thomas Monjalon
2016-04-05 18:58, Harry van Haaren: > +* ABI change is planned for the xstats API and rte_eth_xstats struct, to > + facilitate updating to an API that allows retrieval of values without any > + string copies or parsing. No backwards compatibility is planned, as it > would > + require code

[dpdk-dev] ovs crash when running traffic from VM to VM over DPDK and vhostuser

2016-04-05 Thread Yi Ba
charset-unspecified text was scrubbed... Name: ovs-ofctl.txt URL: <http://dpdk.org/ml/archives/dev/attachments/20160405/fc6860eb/attachment-0002.txt> -- next part -- An embedded and charset-unspecified text was scrubbed... Name: ovs-vswitchd-gdb.txt URL: <ht

[dpdk-dev] [PATCH] doc: announce xstats api change for 16.07

2016-04-05 Thread Harry van Haaren
This patch adds a notice that the API for the xstats functionality will be modified in the 16.07 release, with no backwards compatibility planned as it would require code duplication in each PMD that supports xstats. Signed-off-by: Harry van Haaren --- doc/guides/rel_notes/deprecation.rst | 5

[dpdk-dev] [PATCH v3 0/4] fix creation of duplicate lpm and hash

2016-04-05 Thread Thomas Monjalon
2016-04-05 13:53, Olivier Matz: > Seen while trying to fix the func_reentrancy autotest. The > series addresses several issues: > > 1/ Hash and lpm return a pointer to an existing object if the user requests > the >creation with an already existing name. This look dangerous: when an object >

[dpdk-dev] [PATCH v2] ixgbe: fix occasional timeouts when starting VF

2016-04-05 Thread Thomas Monjalon
2016-04-05 15:55, Bernard Iremonger: > - poll_ms = 10; > + poll_ms = RTE_IXGBE_REGISTER_POLL_WAIT_15_MS; [...] > #define RTE_IXGBE_REGISTER_POLL_WAIT_10_MS 10 > +#define RTE_IXGBE_REGISTER_POLL_WAIT_15_MS 15 > #define RTE_IXGBE_WAIT_100_US 100 I don't

[dpdk-dev] [PATCH] doc: announce ABI changes for user-owned mempool caches

2016-04-05 Thread Olivier Matz
On 04/05/2016 11:23 AM, Lazaros Koromilas wrote: > Deprecation notice for 16.04 for changes targeting release 16.07. > The changes affect struct rte_mempool, rte_mempool_cache and the > mempool API. > > Signed-off-by: Lazaros Koromilas Acked-by: Olivier Matz

[dpdk-dev] [PATCH v2 1/1] cmdline: add any multi string mode to token string

2016-04-05 Thread Thomas Monjalon
2016-04-05 13:21, Olivier Matz: > > On 04/05/2016 10:47 AM, Piotr Azarewicz wrote: > > While parsing token string there may be several modes: > > - fixed single string > > - multi-choice single string > > - any single string > > > > This patch add one more mode - any multi string. > > > >

[dpdk-dev] [PATCH v3 4/4] bnx2x: Update PMD version to 1.0.1.1

2016-04-05 Thread Rasesh Mody
Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index 149fdef..dcd21f8 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -32,18

[dpdk-dev] [PATCH v3 3/4] bnx2x: Enhance stats get

2016-04-05 Thread Rasesh Mody
Enhance the stats_get() routine to display drop counters under imissed counter. Added extended stats get support to provide additional info. Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x_ethdev.c | 72 ++ drivers/net/bnx2x/bnx2x_rxtx.c |2 ++

[dpdk-dev] [PATCH v3 2/4] bnx2x: Fix Tx Performance

2016-04-05 Thread Rasesh Mody
Change the Tx routine logic to ring the doorbell once per burst and not on every Tx packet. This driver-level optimization is necessary to achieve line rates for larger frame sizes (1k or more). Fixes: 540a211084a7 ("bnx2x: driver core") Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody

[dpdk-dev] [PATCH v3 1/4] bnx2x: Update documentation

2016-04-05 Thread Rasesh Mody
Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody --- doc/guides/nics/bnx2x.rst|1 + doc/guides/nics/overview.rst | 22 +++--- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.rst index

[dpdk-dev] DPDK namespace

2016-04-05 Thread Arnon Warshavsky
On Tue, Apr 5, 2016 at 5:13 PM, Trahe, Fiona wrote: > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Tuesday, April 05, 2016 2:57 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] DPDK namespace > > > > DPDK is going to be

[dpdk-dev] [PATCH v3] PCI: ABI change request for adding new field in rte_pci_id structure

2016-04-05 Thread Thomas Monjalon
> > The purpose of this patch is used to add a new field > > "class" in rte_pci_id structure. The new class field includes > > class_id, subcalss_id, programming interface of a pci device. > > With this field, we can identify pci device by its class info, > > which can be more flexible instead of

[dpdk-dev] [PATCH] doc: mempool ABI deprecation notice for 16.07

2016-04-05 Thread Thomas Monjalon
> >>> Add a deprecation notice for coming changes in mempool for 16.07. > >> [...] > >>> +* librte_mempool: new fixes and features will be added in 16.07: > >>> + allocation of large mempool in several virtual memory chunks, new API > >>> + to populate a mempool, new API to free a mempool,

[dpdk-dev] [PATCH] vhost: Fix retrieval of numa information in PMD

2016-04-05 Thread Ciara Loftus
After some testing, it was found that retrieving numa information about a vhost device via a call to get_mempolicy is more accurate when performed during the new_device callback versus the vring_state_changed callback, in particular upon initial boot of the VM. Performing this check during

[dpdk-dev] Change new libraries to have dpdk_ prefix instead of rte_

2016-04-05 Thread Wiles, Keith
> >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Declan Doherty >> Sent: Tuesday, April 05, 2016 2:29 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] Change new libraries to have dpdk_ prefix instead of rte_ >> >> I'd like people opinion of Thomas

[dpdk-dev] [PATCH] doc: update supported features of virtio

2016-04-05 Thread Tan, Jianfeng
Hi, On 4/5/2016 4:20 PM, Thomas Monjalon wrote: > 2016-04-05 03:58, Jianfeng Tan: >> - ethertype filter X X >> + ethertype filter X X >> X X > Are you sure about ethertype filter in virtio? I do not see it. Sorry,

[dpdk-dev] Change new libraries to have dpdk_ prefix instead of rte_

2016-04-05 Thread Thomas Monjalon
Thanks for commenting and making the debate alive :) 2016-04-05 14:03, Ananyev, Konstantin: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Declan Doherty > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > I think we could change the namespace before making this API

[dpdk-dev] [PATCH 10/10] lib: hide static functions that are never defined

2016-04-05 Thread Adrien Mazarguil
Arch-specific functions not defined for all architectures (missing on x86 in this case) and not used anywhere should not expose a prototype. This commit prevents the following errors: error: `rte_mov48' declared `static' but never defined error: `rte_memcpy_func' declared `static' but never

[dpdk-dev] [PATCH 09/10] lib: remove named variadic macros in exported headers

2016-04-05 Thread Adrien Mazarguil
Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked or removed to avoid warnings and compilation failures. Since there is no way to force named variadic macros as extensions, use a a standard

[dpdk-dev] [PATCH 08/10] lib: add extension keyword to forward reference to enum types

2016-04-05 Thread Adrien Mazarguil
Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked or removed to avoid warnings and compilation failures. This commit prevents the following errors: error: ISO C forbids forward references to

[dpdk-dev] [PATCH 07/10] lib: fix missing include dependencies

2016-04-05 Thread Adrien Mazarguil
Exported header files for use by applications should be self sufficient and allow out of order inclusion. Moreover, they must include all the system headers they need for types and macros. This commit prevents the following errors: error: `RTE_MAX_LCORE' undeclared here (not in a function)

[dpdk-dev] [PATCH 06/10] lib: add extension keyword to unnamed structs/unions

2016-04-05 Thread Adrien Mazarguil
Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked to avoid warnings and compilation failures. Unnamed structs/unions are allowed since C11, however many compiler versions do not use this mode by

[dpdk-dev] [PATCH 05/10] lib: add extension keyword to structs with no members

2016-04-05 Thread Adrien Mazarguil
Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked or removed to avoid warnings and compilation failures. This commit prevents the following errors: error: struct has no members Signed-off-by:

[dpdk-dev] [PATCH 04/10] lib: add extension keyword to nonstandard bit-fields

2016-04-05 Thread Adrien Mazarguil
Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked or removed to avoid warnings and compilation failures. This commit prevents the following errors: error: type of bit-field `[...]' is a GCC

[dpdk-dev] [PATCH 03/10] lib: use C99 syntax for zero-size arrays

2016-04-05 Thread Adrien Mazarguil
Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked or removed to avoid warnings and compilation failures. The extension keyword is used whenever the C99 syntax cannot do it. This commit prevents

[dpdk-dev] [PATCH 02/10] lib: add extension keyword to large enum values

2016-04-05 Thread Adrien Mazarguil
Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked or removed to avoid warnings and compilation failures. This commit prevents the following errors: error: ISO C restricts enumerator values to

[dpdk-dev] [PATCH 01/10] lib: add extension keyword to braced-groups within expressions

2016-04-05 Thread Adrien Mazarguil
Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked or removed to avoid warnings and compilation failures. This commit prevents the following errors: error: ISO C forbids braced-groups within

[dpdk-dev] [PATCH 00/10] Fix build errors related to exported headers

2016-04-05 Thread Adrien Mazarguil
DPDK uses GNU C language extensions in most of its code base. This is fine for internal source files whose compilation flags are controlled by DPDK, however user applications that use exported "public" headers may experience compilation failures when enabling strict error/standard checks (-std and

[dpdk-dev] DPDK namespace

2016-04-05 Thread Thomas Monjalon
DPDK is going to be more popular in Linux distributions. It means people will have some DPDK files in their /usr/include and some DPDK libraries on their system. Let's imagine someone trying to compile an application which needs rte_ethdev.h. He has to figure out that this "rte header" is

[dpdk-dev] [PATCH v2] ixgbe: fix occasional timeouts when starting VF

2016-04-05 Thread Bernard Iremonger
Increase the polling wait time from 10 milleseconds to 15. Fixes: af75078fece3 ("first public release") Signed-off-by: Bernard Iremonger --- Change in v2: added fixes line --- drivers/net/ixgbe/ixgbe_rxtx.c | 6 +++--- drivers/net/ixgbe/ixgbe_rxtx.h | 3 ++- 2 files changed, 5 insertions(+),

[dpdk-dev] Change new libraries to have dpdk_ prefix instead of rte_

2016-04-05 Thread Declan Doherty
I'd like people opinion of Thomas proposal to have all new libraries use a dpdk_ prefix instead of rte_*. Although I agree that dpdk_ would probably make sense, I don't like the ascetics of inconsistent prefixes on dpdk libraries. Any comments? 2016-04-05 09:48, Trahe, Fiona: > From: Thomas

[dpdk-dev] DPDK namespace

2016-04-05 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, April 05, 2016 2:57 PM > To: dev at dpdk.org > Subject: [dpdk-dev] DPDK namespace > > DPDK is going to be more popular in Linux distributions. > It means people will have some

[dpdk-dev] [PATCH] doc: mempool ABI deprecation notice for 16.07

2016-04-05 Thread Wiles, Keith
> >On 4/4/2016 3:38 PM, Thomas Monjalon wrote: >> 2016-03-17 10:05, Olivier Matz: >>> Add a deprecation notice for coming changes in mempool for 16.07. >> [...] >>> +* librte_mempool: new fixes and features will be added in 16.07: >>> + allocation of large mempool in several virtual memory

[dpdk-dev] [PATCH] doc: add mempool mgr ABI deprication notice

2016-04-05 Thread Wiles, Keith
>2016-03-10 13:56, Wiles, Keith: >> >On Thu, Mar 10, 2016 at 01:37:27PM +0100, Olivier MATZ wrote: >> >> Hi David, >> >> >> >> On 03/10/2016 12:55 PM, David Hunt wrote: >> >> > Announce the ABI breakage due to addition of external mempool >> >> > manager functionality which requires changes to

[dpdk-dev] Change new libraries to have dpdk_ prefix instead of rte_

2016-04-05 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Declan Doherty > Sent: Tuesday, April 05, 2016 2:29 PM > To: dev at dpdk.org > Subject: [dpdk-dev] Change new libraries to have dpdk_ prefix instead of rte_ > > I'd like people opinion of Thomas proposal to

[dpdk-dev] [PATCH] vhost: fix coverity defect

2016-04-05 Thread Yuanhan Liu
Fix following coverity defect: 291 void 292 vhost_destroy_device(struct vhost_device_ctx ctx) 293 { 294 struct virtio_net *dev = get_device(ctx); 295 >>> CID 124565: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a null

[dpdk-dev] [PATCH v3 4/4] autotest: fix func reentrancy

2016-04-05 Thread Olivier Matz
The previous code in func_reentrancy autotest was doing in parallel something close to: name = "common_name"; do several times { obj = allocate_an_object(name) // obj = ring, mempool, hash, lpm, ... if (obj == NULL && lookup(name) == NULL) return TEST_FAIL; } This

[dpdk-dev] [PATCH v3 3/4] hash: keep the list locked at creation

2016-04-05 Thread Olivier Matz
To avoid a race condition while creating a new hash object, the list has to be locked before the lookup, and released only once the new object is added in the list. As the lock is held by the rte_ring_create(), move its creation at the beginning of the function and only take the lock after the

[dpdk-dev] [PATCH v3 1/4] lpm: allocation of an existing object should fail

2016-04-05 Thread Olivier Matz
Change rte_lpm*_create() functions to return NULL and set rte_errno to EEXIST when the object name already exists. This is the behavior described in the API documentation in the header file. These functions were returning a pointer to the existing object in that case, but it is a problem as the

[dpdk-dev] [PATCH v3 0/4] fix creation of duplicate lpm and hash

2016-04-05 Thread Olivier Matz
Seen while trying to fix the func_reentrancy autotest. The series addresses several issues: 1/ Hash and lpm return a pointer to an existing object if the user requests the creation with an already existing name. This look dangerous: when an object is returned, the user does not know if it

[dpdk-dev] [RFC] vhost-user public struct refactor (was Re: [PATCH RFC 2/4] vhost: make buf vector for scatter RX) local.

2016-04-05 Thread Yuanhan Liu
On Fri, Feb 19, 2016 at 03:06:50PM +0800, Yuanhan Liu wrote: > On Fri, Feb 19, 2016 at 09:32:41AM +0300, Ilya Maximets wrote: > > Array of buf_vector's is just an array for temporary storing information > > about available descriptors. It used only locally in virtio_dev_merge_rx() > > and there is

[dpdk-dev] [PATCH v2] virtio: use zeroed memory for simple TX header

2016-04-05 Thread Tan, Jianfeng
Hi, On 4/5/2016 12:26 PM, Yuanhan Liu wrote: > On Tue, Apr 05, 2016 at 11:20:05AM +0800, Tan, Jianfeng wrote: >> Hi, >> >> On 4/5/2016 10:11 AM, Rich Lane wrote: >>> For simple TX the virtio-net header must be zeroed, but it was using memory >>> that had been initialized with indirect descriptor

[dpdk-dev] [PATCH v2 1/1] cmdline: add any multi string mode to token string

2016-04-05 Thread Olivier Matz
On 04/05/2016 10:47 AM, Piotr Azarewicz wrote: > While parsing token string there may be several modes: > - fixed single string > - multi-choice single string > - any single string > > This patch add one more mode - any multi string. > > Signed-off-by: Piotr Azarewicz Acked-by: Olivier Matz

[dpdk-dev] [PATCH v2] virtio: use zeroed memory for simple TX header

2016-04-05 Thread Yuanhan Liu
On Tue, Apr 05, 2016 at 11:20:05AM +0800, Tan, Jianfeng wrote: > Hi, > > On 4/5/2016 10:11 AM, Rich Lane wrote: > >For simple TX the virtio-net header must be zeroed, but it was using memory > >that had been initialized with indirect descriptor tables. This resulted in > >"unsupported gso type"

[dpdk-dev] [PATCH v2] virtio: use zeroed memory for simple TX header

2016-04-05 Thread Yuanhan Liu
On Mon, Apr 04, 2016 at 07:11:01PM -0700, Rich Lane wrote: > For simple TX the virtio-net header must be zeroed, but it was using memory > that had been initialized with indirect descriptor tables. This resulted in > "unsupported gso type" errors from librte_vhost. > > We can use the same memory

[dpdk-dev] [PATCH v2 1/2] mempool: allow for user-owned mempool caches

2016-04-05 Thread Lazaros Koromilas
Hi all, I forgot to mention that this series applies on top of: http://www.dpdk.org/dev/patchwork/patch/10492/ Thanks, Lazaros. On Mon, Apr 4, 2016 at 6:43 PM, Lazaros Koromilas wrote: > The mempool cache is only available to EAL threads as a per-lcore > resource. Change this so that the

[dpdk-dev] [PATCH] doc: announce ABI changes for user-owned mempool caches

2016-04-05 Thread Lazaros Koromilas
Deprecation notice for 16.04 for changes targeting release 16.07. The changes affect struct rte_mempool, rte_mempool_cache and the mempool API. Signed-off-by: Lazaros Koromilas --- doc/guides/rel_notes/deprecation.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git

[dpdk-dev] [PATCH] cryptodev: Remove EXPERIMENTAL label

2016-04-05 Thread Thomas Monjalon
2016-04-05 09:48, Trahe, Fiona: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2016-04-05 08:53, Fiona Trahe: > > > The cryptodev API was introduced in the DPDK 2.2 release. > > > Since then it has > > > - been reviewed and iterated for the DPDK 16.04 release > > > - had

[dpdk-dev] [PATCH] examples/l3fwd: fix segfault with gcc 5.x

2016-04-05 Thread Kulasek, TomaszX
> -Original Message- > From: Ananyev, Konstantin > Sent: Monday, April 4, 2016 21:05 > To: Kulasek, TomaszX > Cc: dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH] examples/l3fwd: fix segfault with gcc 5.x > > > > > -Original Message- > > From: Kulasek, TomaszX > > Sent:

[dpdk-dev] [PATCH] ixgbe: fix occasional timeouts when starting VF

2016-04-05 Thread Bernard Iremonger
Increase the polling wait time from 10 milleseconds to 15. Signed-off-by: Bernard Iremonger --- drivers/net/ixgbe/ixgbe_rxtx.c | 6 +++--- drivers/net/ixgbe/ixgbe_rxtx.h | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c

[dpdk-dev] [PATCH] doc: add enic features to nic features matrix

2016-04-05 Thread John Daley
Signed-off-by: John Daley --- doc/guides/nics/overview.rst | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/doc/guides/nics/overview.rst b/doc/guides/nics/overview.rst index ec1af46..f3d374b 100644 --- a/doc/guides/nics/overview.rst +++

[dpdk-dev] [PATCH v2] [PATCH] doc: update supported features of virtio

2016-04-05 Thread Jianfeng Tan
Update the overview.rst for virtio. Note: virtio is a para-virtualization device, which indicates that its features depend on not only front end but also back end. Here by X, we just mean the feature is supported in front end. Signed-off-by: Jianfeng Tan --- v2: - unicast MAC filter (yes) -

[dpdk-dev] [PATCH v2] virtio: use zeroed memory for simple TX header

2016-04-05 Thread Tan, Jianfeng
Hi, On 4/5/2016 10:11 AM, Rich Lane wrote: > For simple TX the virtio-net header must be zeroed, but it was using memory > that had been initialized with indirect descriptor tables. This resulted in > "unsupported gso type" errors from librte_vhost. > > We can use the same memory for every

[dpdk-dev] [PATCH] xstats: fix behavior when a null array is provided

2016-04-05 Thread Van Haaren, Harry
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier Matz > Subject: [dpdk-dev] [PATCH] xstats: fix behavior when a null array is provided > > Coverity reports an issue in ethdev: > > *** CID 124562: Null pointer dereferences (FORWARD_NULL) > /lib/librte_ether/rte_ethdev.c:

[dpdk-dev] [PATCH v2 3/4] hash: keep the list locked at creation

2016-04-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier Matz > Sent: Tuesday, April 05, 2016 8:36 AM > To: dev at dpdk.org > Cc: Richardson, Bruce > Subject: [dpdk-dev] [PATCH v2 3/4] hash: keep the list locked at creation > > To avoid a race condition

[dpdk-dev] [PATCH v2 4/4] autotest: fix func reentrancy

2016-04-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier Matz > Sent: Tuesday, April 05, 2016 8:36 AM > To: dev at dpdk.org > Cc: Richardson, Bruce > Subject: [dpdk-dev] [PATCH v2 4/4] autotest: fix func reentrancy > > The previous code in func_reentrancy

[dpdk-dev] [PATCH v2] doc: update overview

2016-04-05 Thread Wenzhuo Lu
Update the overview.rst for e1000, igb, ixgbe. v2: - Some "X"s are put in the wrong place, correct it. Signed-off-by: Wenzhuo Lu --- doc/guides/nics/overview.rst | 94 ++-- 1 file changed, 47 insertions(+), 47 deletions(-) diff --git

[dpdk-dev] [PATCH v2 1/1] cmdline: add any multi string mode to token string

2016-04-05 Thread Piotr Azarewicz
While parsing token string there may be several modes: - fixed single string - multi-choice single string - any single string This patch add one more mode - any multi string. Signed-off-by: Piotr Azarewicz --- v2 changes: - add cmdline_multi_string_t type for the new mode

[dpdk-dev] [PATCH] cryptodev: Remove EXPERIMENTAL label

2016-04-05 Thread Thomas Monjalon
2016-04-05 08:53, Fiona Trahe: > The cryptodev API was introduced in the DPDK 2.2 release. > Since then it has > - been reviewed and iterated for the DPDK 16.04 release > - had extensive use by the l2fwd-crypto app, > the ipsec-secgw example app, > the

[dpdk-dev] [RFC] vhost-user public struct refactor (was Re: [PATCH RFC 2/4] vhost: make buf vector for scatter RX) local.

2016-04-05 Thread Thomas Monjalon
2016-04-05 13:47, Yuanhan Liu: > So, I was considering to add vhost-user Tx delayed-copy (or zero copy) > support recently, which comes to yet another ABI violation, as we need > add a new field to virtio_memory_regions struct to do guest phys addr > to host phys addr translation. You may ask,

[dpdk-dev] [PATCH] doc: update supported features of virtio

2016-04-05 Thread Thomas Monjalon
2016-04-05 16:30, Tan, Jianfeng: > Hi, > > On 4/5/2016 4:20 PM, Thomas Monjalon wrote: > > 2016-04-05 03:58, Jianfeng Tan: > >> - ethertype filter X X > >> + ethertype filter X X > >> X X > > Are you sure about

[dpdk-dev] [PATCH] doc: mempool ABI deprecation notice for 16.07

2016-04-05 Thread Hunt, David
On 4/4/2016 3:38 PM, Thomas Monjalon wrote: > 2016-03-17 10:05, Olivier Matz: >> Add a deprecation notice for coming changes in mempool for 16.07. > [...] >> +* librte_mempool: new fixes and features will be added in 16.07: >> + allocation of large mempool in several virtual memory chunks, new

[dpdk-dev] [PATCH] gcc compiler option -Og warnings fix

2016-04-05 Thread Thomas Monjalon
2016-04-04 23:03, Wiles, Keith: > >2016-04-01 14:20, Keith Wiles: > >> The new compiler option -Og causes a few warning on variables > >> being used before being set warnings. > > > >Sometimes the compiler is wrong. It seems this option makes it > >even wronger. Why not use -Wno-error with -Og? >

[dpdk-dev] [PATCH] doc: update supported features of virtio

2016-04-05 Thread Thomas Monjalon
2016-04-05 03:58, Jianfeng Tan: > - ethertype filter X X > + ethertype filter X X > X X Are you sure about ethertype filter in virtio? I do not see it. > - Power8

[dpdk-dev] [PATCH] autotests: increase memory for group_2

2016-04-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier Matz > Sent: Tuesday, April 05, 2016 8:37 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] autotests: increase memory for group_2 > > The hash test (located in group_2) may require more than

[dpdk-dev] [PATCH v2] i40evf: fix link info update

2016-04-05 Thread Jingjing Wu
The issue is the VF's link speed kept as 10G and status always was up. It did not change even the physical link's status changed. This patch fixes this issue to make VF's link info consistent with physical link. Fixes: 4861cde46116 (i40e: new poll mode driver) Signed-off-by: Jingjing Wu --- v2

[dpdk-dev] [PATCH] autotests: fix eal flags test

2016-04-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier Matz > Sent: Monday, April 04, 2016 5:20 PM > To: dev at dpdk.org > Cc: chaozhu at linux.vnet.ibm.com > Subject: [dpdk-dev] [PATCH] autotests: fix eal flags test > > Since commit a88ba49e51, values

[dpdk-dev] [PATCH] cryptodev: Remove EXPERIMENTAL label

2016-04-05 Thread Trahe, Fiona
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, April 05, 2016 9:48 AM > To: Trahe, Fiona > Cc: dev at dpdk.org; Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH] cryptodev: Remove EXPERIMENTAL label > > 2016-04-05 08:53, Fiona Trahe:

[dpdk-dev] [PATCH] autotests: increase memory for group_2

2016-04-05 Thread Olivier Matz
The hash test (located in group_2) may require more than 64MB of memory, especially if the memory is physically fragmented, making the test to fail. So increase the memory to 128MB to avoid this issue. Signed-off-by: Olivier Matz --- app/test/autotest_data.py | 2 +- 1 file changed, 1

[dpdk-dev] [PATCH v2 4/4] autotest: fix func reentrancy

2016-04-05 Thread Olivier Matz
The previous code in func_reentrancy autotest was doing in parallel something close to: name = "common_name"; do several times { obj = allocate_an_object(name) // obj = ring, mempool, hash, lpm, ... if (obj == NULL && lookup(name) == NULL) return TEST_FAIL; } This

[dpdk-dev] [PATCH v2 3/4] hash: keep the list locked at creation

2016-04-05 Thread Olivier Matz
To avoid a race condition while creating a new hash object, the list has to be locked before the lookup, and released only once the new object is added in the list. As the lock is held by the rte_ring_create(), move its creation at the beginning of the function and only take the lock after the

[dpdk-dev] [PATCH v2 2/4] hash: allocation of an existing object should fail

2016-04-05 Thread Olivier Matz
Change rte_hash*_create() functions to return NULL and set rte_errno to EEXIST when the object name already exists. This is the behavior described in the API documentation in the header file. These functions were returning a pointer to the existing object in that case, but it is a problem as the

[dpdk-dev] [PATCH v2 1/4] lpm: allocation of an existing object should fail

2016-04-05 Thread Olivier Matz
Change rte_lpm*_create() functions to return NULL and set rte_errno to EEXIST when the object name already exists. This is the behavior described in the API documentation in the header file. These functions were returning a pointer to the existing object in that case, but it is a problem as the

[dpdk-dev] [PATCH v2 0/4] fix creation of duplicate lpm and hash

2016-04-05 Thread Olivier Matz
Seen while trying to fix the func_reentrancy autotest. The series addresses several issues: 1/ Hash and lpm return a pointer to an existing object if the user requests the creation with an already existing name. This look dangerous: when an object is returned, the user does not know if it

[dpdk-dev] [PATCH v2] igb: fix i350 VF RX issue

2016-04-05 Thread Wenzhuo Lu
A problem is found on i350 VF. We found TX will happen once per 4 packets. If only 1~3 packets are received, they will not be forwarded. But the real problem is on RX side. The reason is the default RX write-back threshold is changed to 4, so every first 3 packets may be hung there. This patch

[dpdk-dev] [PATCH] cryptodev: Remove EXPERIMENTAL label

2016-04-05 Thread Fiona Trahe
The cryptodev API was introduced in the DPDK 2.2 release. Since then it has - been reviewed and iterated for the DPDK 16.04 release - had extensive use by the l2fwd-crypto app, the ipsec-secgw example app, the test app. We believe it is now stable

[dpdk-dev] [PATCH v2] doc: update nic overview

2016-04-05 Thread Chen, Jing D
Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Saturday, April 02, 2016 5:40 AM > To: Chen, Jing D > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] doc: update nic overview > > 2016-04-01 16:55, Chen Jing D: > > Add feature

[dpdk-dev] [PATCH] virtio: use zeroed memory for simple TX header

2016-04-05 Thread Yuanhan Liu
On Mon, Apr 04, 2016 at 03:57:11PM -0700, Rich Lane wrote: > On Mon, Apr 4, 2016 at 1:05 PM, Yuanhan Liu > wrote: > > On Mon, Apr 04, 2016 at 03:13:37PM +0200, Thomas Monjalon wrote: > > Huawei, Yuanhan, any comment? > > > > 2016-03-31 13:01, Rich Lane: > > >? ? ? ? ? ? ? ? ?

[dpdk-dev] [PATCH v1 1/1] cmdline: add any multi string mode to token string

2016-04-05 Thread Azarewicz, PiotrX T
Hi Olivier, > -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Monday, April 4, 2016 5:58 PM > >> Using token_len + 1 as the buffer size in the snprintf looks a bit > >> dangerous, as it won't protect from overflows. > >> > >> See the following example: >

[dpdk-dev] ACL trie build incrementally

2016-04-05 Thread Rapelly, Varun
Hi All, Can we build ACL trie in following way [lets say 4000 rules]: [I'm using DPDK 2.1.0] 1. Create context 2. Add 1000 rules, to the context [rte_acl_add_rules] 3. Then build the trie [rte_acl_build]for 1000 rules. 4. Then repeat the steps 2-3 for the remaining

[dpdk-dev] [PATCH] virtio: use zeroed memory for simple TX header

2016-04-05 Thread Yuanhan Liu
On Mon, Apr 04, 2016 at 03:13:37PM +0200, Thomas Monjalon wrote: > Huawei, Yuanhan, any comment? > > 2016-03-31 13:01, Rich Lane: > > vq->vq_ring.desc[i + mid_idx].next = i; > > vq->vq_ring.desc[i + mid_idx].addr = > > -

[dpdk-dev] [PATCH] doc: update supported features of virtio

2016-04-05 Thread Jianfeng Tan
Update the overview.rst for virtio. Signed-off-by: Jianfeng Tan --- doc/guides/nics/overview.rst | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/doc/guides/nics/overview.rst b/doc/guides/nics/overview.rst index ec1af46..bbe1394

[dpdk-dev] [PATCH] gcc compiler option -Og warnings fix

2016-04-05 Thread Yuanhan Liu
On Mon, Apr 04, 2016 at 04:10:54PM +0200, Thomas Monjalon wrote: > --- a/lib/librte_vhost/vhost_rxtx.c > +++ b/lib/librte_vhost/vhost_rxtx.c > @@ -147,8 +147,10 @@ copy_mbuf_to_desc(struct virtio_net *dev, struct > vhost_virtqueue *vq, > struct virtio_net_hdr_mrg_rxbuf virtio_hdr = {{0,

[dpdk-dev] [PATCH] ixgbe: cleanup whitespace and formatting issues

2016-04-05 Thread Lu, Wenzhuo
Hi Stephen, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, April 5, 2016 12:14 AM > To: Zhang, Helin; Ananyev, Konstantin > Cc: dev at dpdk.org; Stephen Hemminger > Subject: [dpdk-dev] [PATCH] ixgbe: cleanup whitespace and

[dpdk-dev] [PATCH] doc: update overview

2016-04-05 Thread Lu, Wenzhuo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Saturday, April 2, 2016 5:33 AM > To: Lu, Wenzhuo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: update overview > > 2016-04-01 16:18, Wenzhuo Lu: > > Update the

[dpdk-dev] [PATCH] igb: fix i350 VF RX issue

2016-04-05 Thread Lu, Wenzhuo
Hi Thomas, > > Missing Signed-off-by Sorry for this mistake, will correct it with a V2.

[dpdk-dev] [PATCH] gcc compiler option -Og warnings fix

2016-04-05 Thread Wiles, Keith
>2016-04-01 14:20, Keith Wiles: >> The new compiler option -Og causes a few warning on variables >> being used before being set warnings. > >Sometimes the compiler is wrong. It seems this option makes it >even wronger. Why not use -Wno-error with -Og? Did you want me to make these changes or just