[dpdk-dev] [PATCH] eal: remove useless internal function from memcpy headers

2016-04-19 Thread Thomas Monjalon
The function rte_memcpy_func() is used in ARM and PPC implementations of rte_memcpy(). There are some useless copies in Tile and some ARM branches. It was also declared without doxygen comment in the generic header. Signed-off-by: Thomas Monjalon ---

[dpdk-dev] [PATCH] remove poisoned flags

2016-04-19 Thread Thomas Monjalon
Some flags were poisoned after having been removed from EAL and mbuf in releases 1.8 (b10eef348d, 62814bc2e9) and 2.0 (4769bc5a27cc). After several releases, they have probably disappeared from the applications. Signed-off-by: Thomas Monjalon --- lib/librte_eal/common/include/rte_pci.h | 2 --

[dpdk-dev] Memory leak when adding/removing vhost_user ports

2016-04-19 Thread Yuanhan Liu
On Tue, Apr 19, 2016 at 06:33:50PM +0200, Christian Ehrhardt wrote: > Hi, > thanks for the patch. > I backported it this way to my DPDK 2.2 based environment for now (see below): > > With that applied one (and only one) of my two guests looses connectivity > after > removing the ports the first

[dpdk-dev] [PATCH] hash: remove aliases for bulk lookup

2016-04-19 Thread Thomas Monjalon
The function rte_hash_lookup_multi() was renamed rte_hash_lookup_bulk() in DPDK 1.4 and was kept as an undocumented alias. Signed-off-by: Thomas Monjalon --- app/test/test_hash.c| 4 ++-- doc/guides/sample_app_ug/l3_forward.rst | 2 +-

[dpdk-dev] basic forwarding example not working

2016-04-19 Thread Subbu CS
I am using two virtio network adapter on VM on KVM host. As in following output, I have bound both interface with igb_uio driver ./dpdk_nic_bind.py --bind=igb_uio 00:0a.0 ./dpdk_nic_bind.py --bind=igb_uio 00:0b.0 [root at localhost tools]# ./dpdk_nic_bind.py --status Network devices using

[dpdk-dev] [PATCH v2 1/2] mempool: allow for user-owned mempool caches

2016-04-19 Thread Lazaros Koromilas
Hi Konstantin, Thanks for the review. Regards, Lazaros. On Mon, Apr 18, 2016 at 4:17 PM, Ananyev, Konstantin wrote: > Hi Lazaros, > > Looks ok to me in general, few comments below. > One more generic question - did you observe any performance impact > caused by these changes? > Konstantin I

[dpdk-dev] Memory leak when adding/removing vhost_user ports

2016-04-19 Thread Christian Ehrhardt
Hi, thanks for the patch. I backported it this way to my DPDK 2.2 based environment for now (see below): With that applied one (and only one) of my two guests looses connectivity after removing the ports the first time. No traffic seems to pass, setting the device in the guest down/up doesn't get

[dpdk-dev] [PATCH 1/1] lib/librte_eal: fix resource leak

2016-04-19 Thread Marcin Kerlin
Fix issue reported by Coverity. Coverity ID 13295, 13296, 13303: Resource leak: The system resource will not be reclaimed and reused, reducing the future availability of the resource. In rte_eal_hugepage_attach: Leak of memory or pointers to system resources. Fixes: af75078fece3 ("first public

[dpdk-dev] lpm rule subsystem's perfomance

2016-04-19 Thread Александр Киселев
Hi. Doing some tests with rte_lpm (adding/deleting bgp full table rules) I noticed that rule subsystem is very slow even considering that probably it was never designed for using in a data forwarding plane. So I want to propose some changes to it. I reimplemented "rule" part ot the lib using

[dpdk-dev] basic forwarding example not working

2016-04-19 Thread Christian Ehrhardt
Hi, for virtio-pci devices you should either just unbind them or bind them to one of the generic drivers like uio_pci_generic. At least I never saw igb_uio on virtio-pci devices. There might be more complete answers, but I think that should get you going. Christian Ehrhardt Software Engineer,

[dpdk-dev] [PATCH v2 1/2] mempool: allow for user-owned mempool caches

2016-04-19 Thread Thomas Monjalon
2016-04-19 18:39, Lazaros Koromilas: > >> Removes the API calls: > >> > >> rte_mempool_sp_put_bulk(mp, obj_table, n) > >> rte_mempool_sc_get_bulk(mp, obj_table, n) > >> rte_mempool_sp_put(mp, obj) > >> rte_mempool_sc_get(mp, obj) > > > > Hmm, shouldn't we deprecate it first for a

[dpdk-dev] [PATCH] scripts: add script for generating customised build config

2016-04-19 Thread Bruce Richardson
On Tue, Apr 19, 2016 at 02:30:08PM +0200, Thomas Monjalon wrote: > Hi Bruce, > > Thanks for pushing this idea. > > 2016-04-19 11:27, Bruce Richardson: > > This patch adds in the dpdk_config.py script file. It can be used > > to generate custom build-time configurations for DPDK either manually

[dpdk-dev] [PATCH] ethdev: remove deprecated statistics

2016-04-19 Thread Thomas Monjalon
2016-04-19 16:03, Thomas Monjalon: > Some statistics were deprecated since release 2.1 (49f386542af4). > > The last deprecated counter to be used was imcasts. > > The new counters should be added to extended statistics. > > Signed-off-by: Thomas Monjalon [...] > ---

[dpdk-dev] [PATCH] ethdev: remove deprecated statistics

2016-04-19 Thread Thomas Monjalon
Some statistics were deprecated since release 2.1 (49f386542af4). The last deprecated counter to be used was imcasts. The new counters should be added to extended statistics. Signed-off-by: Thomas Monjalon --- doc/guides/rel_notes/deprecation.rst | 4

[dpdk-dev] [PATCH] virtio: fix newline under debug mode

2016-04-19 Thread Yuanhan Liu
On Tue, Apr 19, 2016 at 05:22:37AM +, Jianfeng Tan wrote: > Issue: output of appliations and debug info of DPDK may be mixed up > in same line when enabling below debug options of virtio: > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_INIT > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_TX >

[dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-04-19 Thread Bruce Richardson
On Fri, Mar 04, 2016 at 01:05:24PM -0800, Stephen Hurd wrote: > New driver for Broadcom bnxt (NexXtreme C-series) devices. > > Standards-compliant 10/25/50G support with 30MPPS full-duplex throughput > http://www.broadcom.com/press/release.php?id=s923886 > > Signed-off-by: Stephen Hurd > --- >

[dpdk-dev] [PATCH v5 05/10] qede: Add core driver

2016-04-19 Thread Thomas Monjalon
2016-03-31 19:15, Rasesh Mody: > The Qlogic Everest Driver for Ethernet(QEDE) Poll Mode Driver(PMD) is > the DPDK specific module for QLogic FastLinQ QL4 25G/40G CNA family > of adapters as well as their virtual functions (VF) in SR-IOV context. > > This patch adds QEDE PMD, which interacts

[dpdk-dev] Couple of PMD questions

2016-04-19 Thread Jay Rolette
In ixgbe_dev_rx_init(), there is this bit of code: /* * Configure the RX buffer size in the BSIZEPACKET field of * the SRRCTL register of the queue. * The value is in 1 KB resolution. Valid values can be from * 1 KB to 16 KB. */

[dpdk-dev] [PATCH] scripts: ignore bit macro in checkpatch

2016-04-19 Thread Thomas Monjalon
It was suggesting to use a Linux macro: CHECK:BIT_MACRO: Prefer using the BIT macro It is ignored because it is a false positive in DPDK case. Signed-off-by: Thomas Monjalon --- scripts/checkpatches.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatches.sh

[dpdk-dev] [PATCH] scripts: ignore bit macro in checkpatch

2016-04-19 Thread Thomas Monjalon
It was suggesting to use a Linux macro: CHECK:BIT_MACRO: Prefer using the BIT macro It is ignored because it is a false positive in DPDK case. Signed-off-by: Thomas Monjalon --- scripts/checkpatches.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatches.sh

[dpdk-dev] [PATCH 2/2] examples/l2fwd: increase mempool cache size for better performance

2016-04-19 Thread Jerin Jacob
l3fwd sets the mempool cache size to 256, selected the same value for l2fwd Signed-off-by: Jerin Jacob --- examples/l2fwd/main.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index 7bdd1b5..24715e3 100644 ---

[dpdk-dev] [PATCH 1/2] examples/l2fwd: remove number of cycles per second hardcording

2016-04-19 Thread Jerin Jacob
Signed-off-by: Jerin Jacob --- examples/l2fwd/main.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index 1ad9488..7bdd1b5 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c @@ -134,10 +134,9 @@

[dpdk-dev] [PATCH 0/2] l2fwd improvements

2016-04-19 Thread Jerin Jacob
Jerin Jacob (2): examples/l2fwd: remove number of cycles per second hardcording examples/l2fwd: increase mempool cache size for better performance examples/l2fwd/main.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) -- 2.1.0

[dpdk-dev] [PATCH v5 05/10] qede: Add core driver

2016-04-19 Thread Thomas Monjalon
2016-03-31 19:15, Rasesh Mody: > +ifeq ($(OS_TYPE),Linux) > +CFLAGS_ECORE_DRIVER += -Wno-shift-negative-value > +endif I see an error with clang: fatal error: unknown warning option '-Wno-shift-negative-value'; did you mean '-Wno-shift-sign-overflow'?

[dpdk-dev] [PATCH v5 09/10] qede: Add DCBX support

2016-04-19 Thread Thomas Monjalon
2016-03-31 19:15, Rasesh Mody: > - case ECORE_PCI_ETH_ROCE: > - p_ramrod->personality = PERSONALITY_RDMA_AND_ETH; > - break; Better to remove it from the previous patches.

[dpdk-dev] [PATCH v5 05/10] qede: Add core driver

2016-04-19 Thread Thomas Monjalon
2016-03-31 19:15, Rasesh Mody: > +# > +# CFLAGS > +# > +CFLAGS_ECORE_DRIVER = -Wno-unused-parameter > +CFLAGS_ECORE_DRIVER += -Wno-unused-value > +CFLAGS_ECORE_DRIVER += -Wno-sign-compare > +CFLAGS_ECORE_DRIVER += -Wno-missing-prototypes > +CFLAGS_ECORE_DRIVER += -Wno-cast-qual >

[dpdk-dev] [PATCH 1/1] examples/distributor: fix unchecked return value

2016-04-19 Thread Marcin Kerlin
Fix issue reported by Coverity. Coverity ID 13207: Value returned from a function is not checked for errors before being used. Fixes: 07db4a975094 ("examples/distributor: new sample app") Signed-off-by: Marcin Kerlin --- examples/distributor/main.c | 17 + 1 file changed, 13

[dpdk-dev] [PATCH] scripts: add script for generating customised build config

2016-04-19 Thread Thomas Monjalon
Hi Bruce, Thanks for pushing this idea. 2016-04-19 11:27, Bruce Richardson: > This patch adds in the dpdk_config.py script file. It can be used > to generate custom build-time configurations for DPDK either manually on > the commandline or by calling it from other scripts. It takes as parameters

[dpdk-dev] [PATCH] i40e: fix packet stats getting

2016-04-19 Thread Jingjing Wu
The statistics queried by calling rte_eth_stats_get are zero when the API is first called on the port. The root cause is because of offset_loaded flag is not set correctly after device started. This patch fixes this issue by resetting statistics at initialization time, at the meanwhile the

[dpdk-dev] perfomance of rte_lpm rule subsystem

2016-04-19 Thread Александр Киселев
Hi. Doing some test with rte_lpm (adding/deleting bgp full table rules) I noticed that rule subsystem is very slow even considering that probably it was never designed for using in a data forwarding plane. So I want to propose some changes to the "rule" subsystem. I reimplemented rule part ot

[dpdk-dev] [PATCH v3 2/7] lib/librte_eal: Add PCI IDs for Broadcom bnxt

2016-04-19 Thread Bruce Richardson
On Fri, Mar 04, 2016 at 01:05:23PM -0800, Stephen Hurd wrote: > Add Broadcom Vendor ID and RTE_PCI_DEV_ID_DECL_BNXT() macro. > Add Device IDs for Broadcom bnxt devices. > > Signed-off-by: Stephen Hurd > --- > lib/librte_eal/common/include/rte_pci_dev_ids.h | 45 > ++--- > 1

[dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-04-19 Thread Stephen Hurd
On Tue, Apr 19, 2016 at 7:19 AM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Fri, Mar 04, 2016 at 01:05:24PM -0800, Stephen Hurd wrote: > > New driver for Broadcom bnxt (NexXtreme C-series) devices. > > This seems a single huge commit. Can this be split up into separate commits

[dpdk-dev] [PATCH v3 1/7] lib/librte_ether: Add 2/2.5/25/50Gbps link speeds

2016-04-19 Thread Bruce Richardson
On Fri, Mar 04, 2016 at 01:05:22PM -0800, Stephen Hurd wrote: > Add additional ETH_LINK_SPEED_* macros for 2, 2.5, 25, and 50 Gbps links > > Signed-off-by: Stephen Hurd > --- > lib/librte_ether/rte_ethdev.h | 4 > 1 file changed, 4 insertions(+) > > diff --git

[dpdk-dev] rte_hash_del_key crash in multi-process environment

2016-04-19 Thread 张伟
Hi all, In the multi-process environment, before I met a bug when calling rte_hash_lookup_with_hash. Using Dhana's patch fixed my problem. Now I need to remove the flow in the multi-process environment, the system gets crashed when calling rte_hash_del_key function. The following is the gdb

[dpdk-dev] [Announce] A new tree for vhost/virtio

2016-04-19 Thread Victor Kaplansky
Great! Thanks a lot, the tree will allow me to focus on development, and not waste the time on testing and maintenance. -- Victor - Original Message - > From: "Yuanhan Liu" > To: dev at dpdk.org > Cc: "Thomas Monjalon" , "Bruce Richardson" > , "Huawei Xie" > , "Victor Kaplansky" ,

[dpdk-dev] [Announce] A new tree for vhost/virtio

2016-04-19 Thread Tetsuya Mukawa
On 2016/04/19 3:55, Yuanhan Liu wrote: > Hi, > > Here I'd like to announce a new tree for vhost/virtio[0], and I'm > going to be the maintainer. > > [0]: http://dpdk.org/browse/next/dpdk-next-virtio/ > > This is done by a private request to Thomas few days ago (well, I'd > confess this should

[dpdk-dev] [PATCH] scripts: add script for generating customised build config

2016-04-19 Thread Bruce Richardson
This patch adds in the dpdk_config.py script file. It can be used to generate custom build-time configurations for DPDK either manually on the commandline or by calling it from other scripts. It takes as parameters the base config template to use, and output directory to which the modified

[dpdk-dev] [PATCH] examples: fix CID 30693 unchecked return value

2016-04-19 Thread Slawomir Mrozowicz
It fix coverity issue: CID 30693 (#1 of 1): Unchecked return value (CHECKED_RETURN) 2. check_return: Calling rte_meter_srtcm_config without checking return value (as is done elsewhere 16 out of 17 times). Fixes: e6541fdec8b2 ("meter: initial import") Signed-off-by: Slawomir Mrozowicz ---

[dpdk-dev] perfomance of rte_lpm rule subsystem

2016-04-19 Thread Stephen Hemminger
On Tue, 19 Apr 2016 14:11:11 +0300 ? ??? wrote: > Hi. > > Doing some test with rte_lpm (adding/deleting bgp full table rules) I > noticed that > rule subsystem is very slow even considering that probably it was never > designed for using > in a data forwarding plane. So I want to

[dpdk-dev] [PATCH] l2fwd-crypto: fix supported key size check

2016-04-19 Thread Cao, Min
Tested-by: Min Cao - Tested Commit: b3b9719f18ee83773c6ed7adda300c5ac63c37e9 - OS: Fedora20 3.11.10-301.fc20.x86_64 - GCC: gcc (GCC) 4.8.3 - CPU: Intel(R) Xeon(R) CPU E5-2658 v3 @ 2.20GHz - NIC: Niantic - Default x86_64-native-linuxapp-gcc configuration - Prerequisites: - Total 1 cases, 1

[dpdk-dev] rte_hash_del_key crash in multi-process environment

2016-04-19 Thread De Lara Guarch, Pablo
Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of ?? > Sent: Tuesday, April 19, 2016 5:58 AM > To: De Lara Guarch, Pablo > Cc: Thomas Monjalon; Gonzalez Monroy, Sergio; dev at dpdk.org; Dhana > Eadala; Richardson, Bruce; Qiu, Michael > Subject: [dpdk-dev]

[dpdk-dev] [PATCH] i40e: fix packet stats getting

2016-04-19 Thread Zhang, Helin
> -Original Message- > From: Wu, Jingjing > Sent: Tuesday, April 19, 2016 2:11 PM > To: Richardson, Bruce > Cc: dev at dpdk.org; Wu, Jingjing ; Zhang, Helin > > Subject: [PATCH] i40e: fix packet stats getting > > The statistics queried by calling rte_eth_stats_get are zero when the

[dpdk-dev] [PATCH] virtio: fix newline under debug mode

2016-04-19 Thread Jianfeng Tan
Issue: output of appliations and debug info of DPDK may be mixed up in same line when enabling below debug options of virtio: CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_INIT CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_TX CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DRIVER This patch adds "\n" in the tail of definitions like

[dpdk-dev] [PATCH] i40evf: Ignore disabled HW CRC strip for Linux PF hosts

2016-04-19 Thread Zhang, Helin
> -Original Message- > From: Topel, Bjorn > Sent: Tuesday, April 19, 2016 2:47 AM > To: Zhang, Helin ; David Marchand > > Cc: dev at dpdk.org; Wu, Jingjing > Subject: RE: [dpdk-dev] [PATCH] i40evf: Ignore disabled HW CRC strip for > Linux PF > hosts > > >> Not sure this is the right