[dpdk-dev] removing mbuf error flags

2016-04-29 Thread Olivier MATZ
Hi, On 04/29/2016 10:00 PM, Arnon Warshavsky wrote: > > > On Fri, Apr 29, 2016 at 9:24 PM, Jay Rolette > wrote: > > On Fri, Apr 29, 2016 at 1:16 PM, Don Provan > wrote: > > > >From: Olivier Matz [mailto:olivier.matz at

[dpdk-dev] [RFC 0/4] Include resources in tests

2016-04-29 Thread Jan Viktorin
On Fri, 29 Apr 2016 15:42:27 +0100 Bruce Richardson wrote: > On Fri, Apr 29, 2016 at 03:11:32PM +0200, Jan Viktorin wrote: > > Hello, > > > > this patch set introduces a mechanism to include a resource (in general a > > blob) > > into the test binary. This allows to make tests less dependent

[dpdk-dev] Flow Director Example?

2016-04-29 Thread Alex Forster
Hi guys, apologies if this is the wrong list, but the others look pretty bare. We have a 32 core server that has two X520-QDA1's NICs with 2x10G ports plugged into each. I'm using 2016.1 (latest stable) with ixgbe 4.3.15 (latest stable). I'm setting up 8 RX queues per port, and I'd like Flow

[dpdk-dev] [PATCH v2] examples/performance-thread: fix size of destination port ids in l3fwd-thread

2016-04-29 Thread Tomasz Kulasek
After extending IPv4 next hop in lpm library, size of dst_port array was changed from 16 to 32 bits in l3fwd-thread example, without modification of the rest of path written for 16 bit value. This patch uses similar approach for fix, like in commit 8353a36a9b4b ("examples/l3fwd: fix size of

[dpdk-dev] ethtool doesnt work on some interface after unbinding dpdk

2016-04-29 Thread Gopakumar Choorakkot Edakkunni
Just to update this thread. With power management for IGB disabled, this problem is not seen .. So for now thats the "workaround" Rgds, Gopa. On Mon, Apr 18, 2016 at 3:08 AM, Remy Horton wrote: > > On 15/04/2016 23:56, Gopakumar Choorakkot Edakkunni wrote: > >> This time the problem statement

[dpdk-dev] removing mbuf error flags

2016-04-29 Thread Don Provan
>From: Olivier Matz [mailto:olivier.matz at 6wind.com] >Subject: [dpdk-dev] removing mbuf error flags > >My opinion is that invalid packets should not be given to the application and >only a statistic counter should be incremented. The idea of an application that handles bad packets is

[dpdk-dev] [PATCH] ip_frag : Fix double-free of chained mbufs

2016-04-29 Thread Thomas Monjalon
> > If any fragment hole is found in ipv4_frag_reassemble() and > > ipv6_frag_reassemble(), > > whole ip_frag_pkt mbufs are moved to death-row. Any mbufs already chained to > > another mbuf are freed multiple times as there are still in ip_frag_pkt > > array. > > > > Signed-off-by: cychong >

[dpdk-dev] [RFC PATCH] ivshmem ring aliases

2016-04-29 Thread Thomas Monjalon
2016-02-24 11:33, David Verbeiren: > The goal of this parch is to allow VMs to use standard ring names regardless > of the names > given to the rings by host environment. It applies to configurations using > ivshmem. > > With shared memory rings, all VMs share a single namespace for the rings.

[dpdk-dev] [PATCH] examples: remove useless checking

2016-04-29 Thread Mauricio Vasquez B
The rte_eth_dev_count() function will never return a value greater than RTE_MAX_ETHPORTS, so that checking is useless. Signed-off-by: Mauricio Vasquez B --- app/proc_info/main.c | 4 app/test/test_pmd_perf.c | 3 ---

[dpdk-dev] removing mbuf error flags

2016-04-29 Thread John Daley (johndale)
Hi, > -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Friday, April 29, 2016 5:25 AM > To: dev at dpdk.org; Zhang, Helin > Cc: Ananyev, Konstantin ; John Daley > (johndale) > Subject: removing mbuf error flags > > Hi, > > In rte_mbuf.h, some rx flags

[dpdk-dev] [PATCH 0/2] l2fwd improvements

2016-04-29 Thread De Lara Guarch, Pablo
> -Original Message- > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > Sent: Tuesday, April 19, 2016 10:35 AM > To: dev at dpdk.org > Cc: thomas.monjalon at 6wind.com; Richardson, Bruce; De Lara Guarch, > Pablo; Jerin Jacob > Subject: [dpdk-dev] [PATCH 0/2] l2fwd

[dpdk-dev] [PATCH] bond: inherit maximum rx packet length

2016-04-29 Thread Eric Kinzie
On Tue Apr 26 11:51:53 +0100 2016, Declan Doherty wrote: > On 14/04/16 18:23, Eric Kinzie wrote: > > Instead of a hard-coded maximum receive length, allow the bond interface > > to inherit this limit from the first slave added. This allows > > an application that uses jumbo frames to pass

[dpdk-dev] supported packet types

2016-04-29 Thread Olivier Matz
Hi, The following commit introduces a function to list the supported packet types of a device: http://dpdk.org/browse/dpdk/commit/?id=78a38edf66 I would like to know what does "supported" precisely mean. Is it: 1/ - if a ptype is marked as supported, the driver MUST set this ptype if

[dpdk-dev] [PATCH v2] scripts: add script for generating customised build config

2016-04-29 Thread Bruce Richardson
This patch adds in the configure.py script file. It can be used to generate custom build-time configurations for DPDK either manually on the commandline or by calling it from other scripts. It takes as parameters the base config template to use, and output directory to which the modified

[dpdk-dev] [PATCH v2] mem: fix freeing of memzone used by ivshmem

2016-04-29 Thread Thomas Monjalon
2016-04-21 12:21, Sergio Gonzalez Monroy: > On 15/04/2016 09:29, Mauricio Vasquez B wrote: > > although previous implementation returned an error when trying to release a > > memzone assigned to an ivshmem device, it stills freed it. > > > > Fixes: cd10c42eb5bc ("mem: fix ivshmem freeing") > > > >

[dpdk-dev] [PATCH v2] kni: add chained mbufs support

2016-04-29 Thread Thomas Monjalon
> > rx_q fifo may have chained mbufs, merge them into single skb before handing > > to > > the network stack. > > > > Signed-off-by: Ferruh Yigit > Acked-by: Helin Zhang Applied, thanks

[dpdk-dev] [PATCH v3 1/1] cmdline: add any multi string mode to token string

2016-04-29 Thread Piotr Azarewicz
While parsing token string there may be several modes: - fixed single string - multi-choice single string - any single string This patch add one more mode - any multi string. Signed-off-by: Piotr Azarewicz Acked-by: Olivier Matz --- v3 changes: - add a comment above the definiton of

[dpdk-dev] supported packet types

2016-04-29 Thread Ananyev, Konstantin
Hi Olivier, > Hi, > > The following commit introduces a function to list the supported > packet types of a device: > > http://dpdk.org/browse/dpdk/commit/?id=78a38edf66 > > I would like to know what does "supported" precisely mean. > Is it: > > 1/ - if a ptype is marked as supported, the

[dpdk-dev] [PATCH 15/15] vfio: change VFIO init to be extendable

2016-04-29 Thread Jan Viktorin
We can now just OR the vfio_enabled sequentially and so adding new VFIO subsystems (vfio_platform) is possible. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c

[dpdk-dev] [PATCH 14/15] vfio: initialize vfio out of the PCI subsystem

2016-04-29 Thread Jan Viktorin
The VFIO does not depend on the PCI anymore so it can be initialized out of the PCI subsystem. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal.c | 31 ++ lib/librte_eal/linuxapp/eal/eal_pci.c | 17 +---

[dpdk-dev] [PATCH 13/15] vfio: rename and generalize eal_pci_vfio_mp_sync

2016-04-29 Thread Jan Viktorin
The module eal_pci_vfio_mp_sync is quite generic so it shouldn't contain the "pci" string in its name. The internal functions don't need the pci_* prefix. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/Makefile | 4 ++--

[dpdk-dev] [PATCH 12/15] vfio: make vfio_*_dma_map and iommu_types private

2016-04-29 Thread Jan Viktorin
There is no more reason to expose those definitions as nobody uses them. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 15 +-- lib/librte_eal/linuxapp/eal/eal_vfio.h | 11 --- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git

[dpdk-dev] [PATCH 11/15] vfio: move global vfio_cfg to eal_vfio.c

2016-04-29 Thread Jan Viktorin
The vfio_cfg is a module-global variable and so together with this variable, it is necessary to move functions: * pci_vfio_get_group_fd - renamed to vfio_get_group_fd - pci_* version removed (no other call in EAL) * pci_vfio_setup_device - renamed as vfio_setup_device * pci_vfio_enable

[dpdk-dev] [PATCH 10/15] vfio: extract setup logic out of pci_vfio_map_resource

2016-04-29 Thread Jan Viktorin
The setup logic access the global vfio_cfg variable that will be moved in the following commits. We need to separate all accesses to this variable to a general code. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 96 +++--- 1 file changed,

[dpdk-dev] [PATCH 09/15] vfio: generalize pci_vfio_get_group_no

2016-04-29 Thread Jan Viktorin
Generalize the pci_vfio_get_group_no to not be PCI-specific. Move the general implementation to the eal_vfio.c as vfio_get_group_no and leave the original pci_vfio_get_group_no being a wrapper around this to preserve compilation issues. The pci_vfio_get_group_no function will be removed later.

[dpdk-dev] [PATCH 08/15] vfio: generalize pci_vfio_get_container_fd

2016-04-29 Thread Jan Viktorin
The pci_vfio_get_container_fd is not PCI-specific. Move the implementation to the eal_vfio.c as vfio_get_container_fd. No other code seems to call this function. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal_pci_init.h | 1 - lib/librte_eal/linuxapp/eal/eal_pci_vfio.c

[dpdk-dev] [PATCH 07/15] vfio: move vfio-specific SOCKET_* constants

2016-04-29 Thread Jan Viktorin
The constants are not PCI-specific. Move them into the eal_vfio.h. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal_pci_init.h | 7 --- lib/librte_eal/linuxapp/eal/eal_vfio.h | 6 ++ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git

[dpdk-dev] [PATCH 05/15] vfio: generalize pci_vfio_set_iommu_type

2016-04-29 Thread Jan Viktorin
The pci_vfio_set_iommu_type is not PCI-specific and it is a private function of the eal_pci_vfio.c. We just rename the function and make it available even for non-PCI devices. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 25 +

[dpdk-dev] [PATCH 04/15] vfio: move vfio_iommu_type and dma_map functions to eal_vfio

2016-04-29 Thread Jan Viktorin
We make the iommu_types public temporarily here until the depending stuff is refactored. The iommu_types and dma_map functions will be changed to be private inside the eal_vfio module later. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/Makefile | 1 +

[dpdk-dev] [PATCH 03/15] vfio: move common vfio constants to eal_vfio.h

2016-04-29 Thread Jan Viktorin
Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 7 --- lib/librte_eal/linuxapp/eal/eal_vfio.h | 7 +++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c

[dpdk-dev] [PATCH 02/15] vfio: move VFIO-specific stuff to eal_vfio.h

2016-04-29 Thread Jan Viktorin
The common VFIO definitions should be separated from the PCI-specific parts. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal_pci_init.h | 28 lib/librte_eal/linuxapp/eal/eal_vfio.h | 28 2 files changed, 28

[dpdk-dev] [PATCH 01/15] vfio: fix include of eal_private.h to be local

2016-04-29 Thread Jan Viktorin
Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c index 10266f8..257162b 100644 ---

[dpdk-dev] [PATCH 00/15] Make VFIO support independent on PCI

2016-04-29 Thread Jan Viktorin
Hello, here follows several patchs extracting the general VFIO code out of the PCI + VFIO code base. Usually, it's just move and rename of functions. The most complicated ones are: * eal/linux: extract setup logic out of pci_vfio_map_resource - separation of some setup code out of the

[dpdk-dev] [RFC 0/4] Include resources in tests

2016-04-29 Thread Bruce Richardson
On Fri, Apr 29, 2016 at 03:11:32PM +0200, Jan Viktorin wrote: > Hello, > > this patch set introduces a mechanism to include a resource (in general a > blob) > into the test binary. This allows to make tests less dependent on the target > testing environment. The first use case is testing of PCI

[dpdk-dev] [PATCH v2] bond: inherit maximum rx packet length

2016-04-29 Thread Eric Kinzie
Instead of a hard-coded maximum receive length, allow the bond interface to inherit this limit from the first slave added. This allows an application that uses jumbo frames to pass realistic values to rte_eth_dev_configure without causing an error. Signed-off-by: Eric Kinzie ---

[dpdk-dev] [PATCH v2] bond: inherit maximum rx packet length

2016-04-29 Thread Eric Kinzie
v2 changes: - remove type cast on constant - check max_rx_pktlen when adding a slave to make sure it is >= max packet length of existing slave interfaces Eric Kinzie (1): bond: inherit maximum rx packet length drivers/net/bonding/rte_eth_bond_api.c | 12 +++-

[dpdk-dev] [RFC 4/4] app/test: support resources archived by tar

2016-04-29 Thread Jan Viktorin
When needing a more complex resource (a file hierarchy), packing every single file as a single resource would be very ineffective. For that purpose, it is possible to pack the files into a tar archive, extract it before test from the resource and finally clean up all the created files. This patch

[dpdk-dev] [RFC 3/4] app/test: add functions to create files from resources

2016-04-29 Thread Jan Viktorin
A resource can be written into the target filesystem by calling resource_fwrite or resource_fwrite_file. Such file can be created before a test is started and removed after the test finishes. Signed-off-by: Jan Viktorin --- app/test/resource.c | 35 +++

[dpdk-dev] [RFC 2/4] app/test: support resources externally linked

2016-04-29 Thread Jan Viktorin
To include resources from other source that the C source code we can take advantage of the objcopy behaviour, i.e. packing of an arbitrary file as an object file that is linked to the target program. A linked object file is always accessible as a pair extern const char beg_; extern const char

[dpdk-dev] [RFC 1/4] app/test: introduce resources for tests

2016-04-29 Thread Jan Viktorin
Certain internal mechanisms of DPDK access different file system structures (e.g. /sys/bus/pci/devices). It is difficult to test those cases automatically by a unit test when such path is not hard-coded and there is no simple way how to distribute fake ones with the current testing environment.

[dpdk-dev] [RFC 0/4] Include resources in tests

2016-04-29 Thread Jan Viktorin
Hello, this patch set introduces a mechanism to include a resource (in general a blob) into the test binary. This allows to make tests less dependent on the target testing environment. The first use case is testing of PCI bus scan by changing the hard-coded path (/sys/bus/pci/devices) to

[dpdk-dev] removing mbuf error flags

2016-04-29 Thread Olivier Matz
Hi, In rte_mbuf.h, some rx flags are set to 0 since a long time since nearly 2 years. It means nobody use them. They were introduced by the following commit: http://dpdk.org/browse/dpdk/commit/?id=c22265f6 As far as I understand, these flags were introduced to let the application know that a

[dpdk-dev] DPDK Community Call - 16.04 Retrospective - Wednesday May 11th

2016-04-29 Thread O'Driscoll, Tim
At the end of each release, we typically hold a retrospective within our development team to discuss what went well, what could be improved etc. For 16.04, we thought it would be a good idea to try doing this with the open source community, so that everybody involved in the project can provide

[dpdk-dev] [RFC PATCH v1 2/3] drivers/net/ixgbe: change xstats to use integers

2016-04-29 Thread David Harton (dharton)
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton > Sent: Friday, April 15, 2016 10:44 AM > To: dev at dpdk.org; Helin Zhang > Subject: [dpdk-dev] [RFC PATCH v1 2/3] drivers/net/ixgbe: change xstats to > use integers > > Signed-off-by: Remy

[dpdk-dev] [PATCH v3] i40evf: Report error if HW CRC strip is disabled for non-DPDK PF hosts

2016-04-29 Thread Zhang, Helin
> -Original Message- > From: Topel, Bjorn > Sent: Friday, April 22, 2016 1:39 PM > To: dev at dpdk.org > Cc: Zhang, Helin; Wu, Jingjing; Topel, Bjorn > Subject: [PATCH v3] i40evf: Report error if HW CRC strip is disabled for non- > DPDK PF hosts > > On hosts running a non-DPDK PF

[dpdk-dev] [RFC PATCH v1 1/3] rte: change xstats to use integer keys

2016-04-29 Thread David Harton (dharton)
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton > Sent: Friday, April 15, 2016 10:44 AM > To: dev at dpdk.org; Thomas Monjalon > Subject: [dpdk-dev] [RFC PATCH v1 1/3] rte: change xstats to use integer > keys > > Signed-off-by: Remy Horton >

[dpdk-dev] [RFC PATCH v1 0/3] Remove string operations from xstats

2016-04-29 Thread David Harton (dharton)
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton > Sent: Friday, April 15, 2016 10:44 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [RFC PATCH v1 0/3] Remove string operations from > xstats > > The current extended ethernet statistics fetching

[dpdk-dev] [RFC PATCH v1 0/3] Remove string operations from xstats

2016-04-29 Thread David Harton (dharton)
Happy Friday, > -Original Message- > From: Remy Horton [mailto:remy.horton at intel.com] > Sent: Friday, April 29, 2016 6:22 AM > To: David Harton (dharton) ; Tahhan, Maryam > ; dev at dpdk.org > Cc: Mcnamara, John ; Van Haaren, Harry > > Subject: Re: [dpdk-dev] [RFC PATCH v1 0/3] Remove

[dpdk-dev] [RFC PATCH v1 0/3] Remove string operations from xstats

2016-04-29 Thread Remy Horton
Morning, On 28/04/2016 16:58, David Harton (dharton) wrote: [..] *) id-name & id-value pairs for both lookup and query Permits out-of-order and non-contigious returning of names/ids/values, even though expected implmentations would in practice return items in sorted order by

[dpdk-dev] [PATCH] mk: add build-time library directory to linker path

2016-04-29 Thread Yuanhan Liu
On Thu, Apr 28, 2016 at 03:43:48PM +0900, Tetsuya Mukawa wrote: > On 2016/04/27 20:02, Panu Matilainen wrote: > > This is a pre-requisite for adding DT_NEEDED dependencies > > between internal libraries. > > > > Signed-off-by: Panu Matilainen > > --- > > mk/rte.lib.mk | 4 ++-- > > 1 file

[dpdk-dev] [PATCH 4/4] eal: add assert macro for debug

2016-04-29 Thread Thomas Monjalon
2016-04-22 15:42, Stephen Hemminger: > On Fri, 22 Apr 2016 15:08:50 -0700 > Yuanhan Liu wrote: > > On Fri, Apr 22, 2016 at 11:14:35PM +0200, Thomas Monjalon wrote: > > > rxd = (Vmxnet3_RxDesc *)rxq->cmd_ring[ring_idx].base + > > > idx; > > > + RTE_SET_USED(rxd); /*

[dpdk-dev] [PATCH] ip_pipeline: add rss support

2016-04-29 Thread Jasvinder Singh
This patch enables rss (receive side scaling) per network interface through the configuration file. The user can specify following parameters in LINK section for enabling the rss feature - rss_qs, rss_proto_ipv4, rss_proto_ipv6 and ip_proto_l2. The "rss_qs" is mandatory parameter which indicates

[dpdk-dev] Byte order of vlan_tci of rte_mbuf is different on different source

2016-04-29 Thread Olivier Matz
Hi, On 04/25/2016 04:35 AM, zhang.xinghua1 at zte.com.cn wrote: > When using I350 working on SR-IOV mode, we got confused that byte order > of vlan_tci in the VF received packet descriptor is different when the > packet source is different. > > 1) Packets from VF to VF, the byte order is

[dpdk-dev] [PATCH v2 1/1] cmdline: add any multi string mode to token string

2016-04-29 Thread Azarewicz, PiotrX T
> But I agree that a comment could be added above the definition of > TOKEN_STRING_MULTI that would explain what is the behavior in that case. > > Piotr, do you think this is something you can do? Okay, I will. Regards, Piotr

[dpdk-dev] [PATCH v1 3/3] doc: add keepalive enhancement documentation

2016-04-29 Thread Remy Horton
Signed-off-by: Remy Horton --- doc/guides/rel_notes/release_16_07.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_16_07.rst b/doc/guides/rel_notes/release_16_07.rst index 83c841b..7309877 100644 --- a/doc/guides/rel_notes/release_16_07.rst +++

[dpdk-dev] [PATCH v1 2/3] examples/l2fwd-keepalive: add IPC liveness reporting

2016-04-29 Thread Remy Horton
Signed-off-by: Remy Horton --- examples/Makefile | 1 + examples/l2fwd-keepalive/Makefile | 4 +- examples/l2fwd-keepalive/ka-agent/Makefile | 51 +++ examples/l2fwd-keepalive/ka-agent/main.c | 128

[dpdk-dev] [PATCH v1 1/3] eal: add new keepalive state & callback hook

2016-04-29 Thread Remy Horton
Signed-off-by: Remy Horton --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 7 + lib/librte_eal/common/include/rte_keepalive.h | 40 + lib/librte_eal/common/rte_keepalive.c | 35 -- lib/librte_eal/linuxapp/eal/rte_eal_version.map

[dpdk-dev] [PATCH v1 0/3] Keep-alive enhancements

2016-04-29 Thread Remy Horton
This patchset adds enhancements to the keepalive core monitoring and reporting sub-system. The first is support for idled (sleeping and frequency-stepped) CPU cores, and the second is support for applications to be notified of active as well as faulted cores. The latter is to allow core state to

[dpdk-dev] [PATCH v4 0/8] virtio support for container

2016-04-29 Thread Tan, Jianfeng
Sorry, forget to mention, this patchset depends on: - [PATCH v2] virtio: fix modify drv_flags for specific device - [PATCH v3 0/2] virtio: fix memory leak of virtqueue memzones Thanks, Jianfeng > -Original Message- > From: Tan, Jianfeng > Sent: Friday, April 29, 2016 9:18 AM > To:

[dpdk-dev] [PATCH v3 02/13] ixgbe: move pci device ids to driver

2016-04-29 Thread Wu, Jingjing
Hi, David For the changes on igb, ixgbe, I saw you create a new header file called **__pci_dev_ids.h to replace the rte_pci_dev_ids.h for each driver. But for the changes on i40e, you didn't do that way. If you look into the base code, you will find for each Intel NIC, the device ids are

[dpdk-dev] [PATCH v4 8/8] doc: update doc for virtio-user

2016-04-29 Thread Jianfeng Tan
Signed-off-by: Huawei Xie Signed-off-by: Jianfeng Tan Acked-By: Neil Horman --- doc/guides/nics/overview.rst | 64 +- doc/guides/rel_notes/release_16_07.rst | 4 +++ 2 files changed, 36 insertions(+), 32 deletions(-) diff --git

[dpdk-dev] [PATCH v4 7/8] virtio-user: add a new virtual device named virtio-user

2016-04-29 Thread Jianfeng Tan
Add a new virtual device named vhost-user, which can be used just like eth_ring, eth_null, etc. To reuse the code of original virtio, we do some adjustment in virtio_ethdev.c, such as remove key _static_ of eth_virtio_dev_init() so that it can be reused in virtual device; and we add some check to

[dpdk-dev] [PATCH v4 6/8] virtio-user: add new virtual pci driver for virtio

2016-04-29 Thread Jianfeng Tan
This patch implements another new instance of struct virtio_pci_ops to drive the virtio-user virtual device. Instead of rd/wr ioport or PCI configuration space, this virtual pci driver will rd/wr the virtual device struct virtio_user_hw, and when necessary, invokes APIs provided by device

[dpdk-dev] [PATCH v4 5/8] virtio-user: add device emulation layer APIs

2016-04-29 Thread Jianfeng Tan
Two device emulation layer APIs are added for virtio driver to call: - virtio_user_start_device() - virtio_user_stop_device() These APIs will get called by virtio driver, and they call vhost adapter layer APIs to implement the functionality. Besides, this patch defines a struct named

[dpdk-dev] [PATCH v4 4/8] virtio-user: add vhost adapter layer

2016-04-29 Thread Jianfeng Tan
This patch is to provide vhost adapter layer implementations. Instead of relying on a hypervisor to translate between device emulation and vhost backend, here we directly talk with vhost backend through the vhost file. Depending on the type of vhost file, - vhost-user is used if the given path

[dpdk-dev] [PATCH v4 3/8] virtio: enable use virtual address to fill desc

2016-04-29 Thread Jianfeng Tan
This patch is related to how to calculate relative address for vhost backend. The principle is that: based on one or multiple shared memory segments, vhost maintains a reference system with the base addresses and length for each segment so that an address from VM comes (usually GPA, Guest

[dpdk-dev] [PATCH v4 2/8] virtio: abstract vring hdr desc init as a method

2016-04-29 Thread Jianfeng Tan
To make it reusable, here we abstract the initialization of vring header into a method. Signed-off-by: Huawei Xie Signed-off-by: Jianfeng Tan Acked-By: Neil Horman --- drivers/net/virtio/virtio_ethdev.c | 22 -- drivers/net/virtio/virtqueue.h | 20

[dpdk-dev] [PATCH v4 1/8] virtio: hide phys addr check inside pci ops

2016-04-29 Thread Jianfeng Tan
This patch is to move phys addr check from virtio_dev_queue_setup to pci ops. To makt that happen, make sure virtio_ops.setup_queue return the result if we pass through the check. Signed-off-by: Huawei Xie Signed-off-by: Jianfeng Tan Acked-By: Neil Horman ---

[dpdk-dev] [PATCH v4 0/8] virtio support for container

2016-04-29 Thread Jianfeng Tan
v4: - Avoid using dev_type, instead use (eth_dev->pci_device is NULL) to judge if it's virtual device or physical device. - Change the added device name to virtio-user. - Split into vhost_user.c, vhost_kernel.c, vhost.c, virtio_user_pci.c, virtio_user_dev.c. - Move virtio-user specific

[dpdk-dev] [PATCH v3 2/2] virtio: fix memory leak of virtqueue memzones

2016-04-29 Thread Jianfeng Tan
Issue: When virtio was proposed in DPDK, there is no API to free memzones. But this has changed since rte_memzone_free() has been implemented by commit ff909fe21f0a ("mem: introduce memzone freeing"). This patch is to make sure memzones in struct virtqueue, like mz and virtio_net_hdr_mz, are

[dpdk-dev] [PATCH v3 1/2] virtio: cleanup virtio_dev_queue_setup()

2016-04-29 Thread Jianfeng Tan
Signed-off-by: Jianfeng Tan --- drivers/net/virtio/virtio_ethdev.c | 47 +++--- 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 1fe90ae..b3f4158 100644 ---

[dpdk-dev] [PATCH v3 0/2] virtio: fix memory leak of virtqueue memzones

2016-04-29 Thread Jianfeng Tan
Patch 1: Do some cleanup in virtio_dev_queue_setup(); Patch 2: Fix the memory leak bug. Jianfeng Tan (2): v3: Fix a typo in the queue_type check. v2: split cleanup and fix into two patches. virtio: cleanup virtio_dev_queue_setup() virtio: fix memory leak of virtqueue memzones