[dpdk-dev] [PATCH] mbuf: add helpers to prefetch mbuf

>diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h >index 529debb..e3ee0b3 100644 >--- a/lib/librte_mbuf/rte_mbuf.h >+++ b/lib/librte_mbuf/rte_mbuf.h >@@ -842,6 +842,44 @@ struct rte_mbuf { > uint16_t timesync; > } __rte_cache_aligned; > >+/** >+ * Prefetch the first part

[dpdk-dev] [PATCH] mk: Introduce NXP dpaa2 architecture based on armv8-a

On Mon, May 09, 2016 at 11:22:15PM +0800, Jianbo Liu wrote: > On 9 May 2016 at 20:11, Jerin Jacob wrote: > > On Mon, May 09, 2016 at 07:02:36PM +0800, Jianbo Liu wrote: > >> On 9 May 2016 at 17:06, Jerin Jacob > >> wrote: > >> > On Mon, May 09, 2016 at 07:18:22PM +0530, Hemant Agrawal wrote: >

[dpdk-dev] [PATCH] mbuf: add helpers to prefetch mbuf

2016-05-09 18:18, Olivier Matz: > +/** > + * Prefetch the second part of the mbuf > + * > + * The next 64 bytes of the mbuf corresponds to fields that are used in the > + * transmit path. If the cache line of the architecture is higher than 64B, > + * this function does nothing as it is expected

[dpdk-dev] [PATCH] mk: Introduce NXP dpaa2 architecture based on armv8-a

This patch introduces dpaa2 machine target to address difference in cpu parameter, number of core to 8 and no numa support w.r.t default armv8-a machine Signed-off-by: Hemant Agrawal --- config/defconfig_arm64-dpaa2-linuxapp-gcc | 44 +++ mk/machine/dpaa2/rte.vars.mk

[dpdk-dev] [PATCH] mk: Introduce NXP dpaa2 architecture based on armv8-a

On 9 May 2016 at 17:06, Jerin Jacob wrote: > On Mon, May 09, 2016 at 07:18:22PM +0530, Hemant Agrawal wrote: >> This patch introduces dpaa2 machine target to address difference >> in cpu parameter, number of core to 8 and no numa support >> w.r.t default armv8-a machine >> >> Signed-off-by:

[dpdk-dev] [PATCH] virtio: check mbuf is direct when using any layout

The commit dd856dfcb9e74 introduced an optimization that prepends virtio header to mbuf data. It can be used when the tx mbuf is writeable, so we need to check that the mbuf is direct (i.e. it embeds its own data). Fixes: dd856dfcb9e74 "virtio: use any layout on Tx" Signed-off-by: Olivier Matz

[dpdk-dev] [PATCH] mbuf: add helpers to prefetch mbuf

Some architectures (ex: Power8) have a cache line size of 128 bytes, so the drivers should not expect that prefetching the second part of the mbuf is valid. This commit add helpers that can be used by drivers to prefetch the rx or tx part of the mbuf, whatever the cache line size. Signed-off-by:

[dpdk-dev] [PATCH] eal: fix log level/type retrieving on a standard pthread

From: Maxime Leroy The functions rte_log_cur_msg_loglevel() and rte_log_cur_msg_logtype() return the current log level/type for the message being processed. They are used when implementing a user-defined logging stream. The current log levels and types were stored in a

[dpdk-dev] [PATCH 6/9] qede: add support for xstats

Hi Rasesh, Some comments about xstats strings below, please refer to the docs here: http://dpdk.org/doc/guides/prog_guide/poll_mode_drv.html#extended-statistics-api Due to my familiarity with ixgbe, I will use it as an example: other PMDs should be identical. I understand these may seem trivial

[dpdk-dev] [PATCH] mk: Introduce NXP dpaa2 architecture based on armv8-a

On Mon, May 09, 2016 at 07:02:36PM +0800, Jianbo Liu wrote: > On 9 May 2016 at 17:06, Jerin Jacob wrote: > > On Mon, May 09, 2016 at 07:18:22PM +0530, Hemant Agrawal wrote: > >> This patch introduces dpaa2 machine target to address difference > >> in cpu parameter, number of core to 8 and no numa

[dpdk-dev] [PATCH v1 01/10] app/test: introduce resources for tests

On Fri, 06 May 2016 16:01:08 +0200 Thomas Monjalon wrote: > 2016-05-06 12:48, Jan Viktorin: > > --- /dev/null > > +++ b/app/test/resource.h > > @@ -0,0 +1,61 @@ > > +/*- > > + * BSD LICENSE > [...] > > + */ > > Please include a multi-line comment here to explain what is a resource > and

[dpdk-dev] [PATCH v1 02/10] app/test: support resources externally linked

On Fri, 06 May 2016 16:32:53 +0200 Thomas Monjalon wrote: > It looks a lot too much tricky to be integrated without code comments ;) > Please make a documentation effort. > [...] Thomas, is it OK to include the PCI test enhancements? Or should I post only the fixed "resource framework"?

[dpdk-dev] [PATCH 01/15] i40e/base: remove HMC AQ APIs

On Mon, May 09, 2016 at 05:14:59PM +0100, Bruce Richardson wrote: > On Thu, May 05, 2016 at 04:53:30PM +0800, Helin Zhang wrote: > > HMC AQ APIs were removed from the latest datasheet, and > > hence remove its implementations and relevant. > > > > Signed-off-by: Helin Zhang > > Hi Helin, > >

[dpdk-dev] [PATCH 01/15] i40e/base: remove HMC AQ APIs

On Thu, May 05, 2016 at 04:53:30PM +0800, Helin Zhang wrote: > HMC AQ APIs were removed from the latest datasheet, and > hence remove its implementations and relevant. > > Signed-off-by: Helin Zhang Hi Helin, what is HMC? I assume AQ is short for admin queue. These abbreviations are pretty

[dpdk-dev] [PATCH v1] hash: add tsx support for cuckoo hash

Hi Stephen, Greetings. Thanks for your great feedback. Let?s me address your concern here. 1) It changes ABI, so it breaks old programs The patch uses the extra_flag field in the rte_hash_parameters struct to set the default insertion behavior. Today there is only one bit used by this flag

[dpdk-dev] [PATCH 3/6] vhost: add reconnect ability

On 5/7/2016 2:36 PM, Yuanhan Liu wrote: > +static void * > +vhost_user_client_reconnect(void *arg) > +{ > + struct reconnect_info *reconn = arg; > + int ret; > + > + RTE_LOG(ERR, VHOST_CONFIG, "reconnecting...\n"); > + while (1) { > + ret = connect(reconn->fd, (struct

[dpdk-dev] [PATCH 4/6] vhost: workaround stale vring base

On 5/7/2016 2:36 PM, Yuanhan Liu wrote: > However, Michael claims some concerns: he made a good point: a crash > is happening means some memory is corrupted, and it could be the virtio > memory being corrupted. In such case, nothing will work without the > reset. I don't get this point. What is

[dpdk-dev] [PATCH 1/1] examples/distributor: fix unchecked return value

> -Original Message- > From: Kerlin, MarcinX > Sent: Tuesday, April 19, 2016 1:32 PM > To: dev at dpdk.org > Cc: Richardson, Bruce ; Pattan, Reshma > ; Kerlin, MarcinX > Subject: [PATCH 1/1] examples/distributor: fix unchecked return value > > Fix issue reported by Coverity. > >

[dpdk-dev] [PATCH 4/6] vhost: workaround stale vring base

On Fri, May 06, 2016 at 11:40:22PM -0700, Yuanhan Liu wrote: > When DPDK app crashes (or quits, or gets killed), and when QEMU supports > reconnecting (patches have been sent, not merged yet), a restart of DPDK > app would get stale vring base from QEMU. That would break the kernel > virtio net

[dpdk-dev] [PATCH 19/20] thunderx/nicvf: updated driver documentation and release notes

On Mon, May 09, 2016 at 10:47:08AM +0200, Thomas Monjalon wrote: > 2016-05-07 20:46, Jerin Jacob: > > --- a/doc/guides/nics/overview.rst > > +++ b/doc/guides/nics/overview.rst > > + = = = = = = = = = = = = = = = = = = = = = = = = = > > = = = = = = = = = = = > > + Feature

[dpdk-dev] [PATCH] mk: Introduce NXP dpaa2 architecture based on armv8-a

On Mon, May 9, 2016 at 2:36 PM, Jerin Jacob wrote: > On Mon, May 09, 2016 at 07:18:22PM +0530, Hemant Agrawal wrote: > > This patch introduces dpaa2 machine target to address difference > > in cpu parameter, number of core to 8 and no numa support > > w.r.t default armv8-a machine > > > >

[dpdk-dev] [PATCH] mk: Introduce NXP dpaa2 architecture based on armv8-a

On Mon, May 09, 2016 at 07:18:22PM +0530, Hemant Agrawal wrote: > This patch introduces dpaa2 machine target to address difference > in cpu parameter, number of core to 8 and no numa support > w.r.t default armv8-a machine > > Signed-off-by: Hemant Agrawal > --- >

[dpdk-dev] [PATCH] vhost: add support for dynamic vhost PMD creation

On Thu, May 05, 2016 at 07:11:09PM +0100, Ferruh Yigit wrote: > Add rte_eth_from_vhost() API to create vhost PMD dynamically from > applications. This sounds a good idea to me. It could be better if you name a good usage of it though. > > Signed-off-by: Ferruh Yigit > --- >

[dpdk-dev] [RFC PATCH v2 3/3] examples/ethtool: add xstats display command

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton > Sent: Friday, May 06, 2016 7:11 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [RFC PATCH v2 3/3] examples/ethtool: add xstats > display command > > Signed-off-by: Remy Horton > --- >

[dpdk-dev] [RFC PATCH v2 2/3] drivers/net/ixgbe: change xstats to use integer id

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton > Sent: Friday, May 06, 2016 7:11 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [RFC PATCH v2 2/3] drivers/net/ixgbe: change xstats to > use integer id > > Signed-off-by: Remy Horton > --- >

[dpdk-dev] [RFC PATCH v2 1/3] rte: change xstats to use integer keys

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton > Sent: Friday, May 06, 2016 7:11 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [RFC PATCH v2 1/3] rte: change xstats to use integer > keys > > Signed-off-by: Remy Horton > --- >

[dpdk-dev] [PATCH] mk: Introduce NXP dpaa2 architecture based on armv8-a

On Mon, May 9, 2016 at 7:18 PM, Hemant Agrawal wrote: > This patch introduces dpaa2 machine target to address difference > in cpu parameter, number of core to 8 and no numa support > w.r.t default armv8-a machine > > Signed-off-by: Hemant Agrawal > --- >

[dpdk-dev] [PATCH 4/6] vhost: workaround stale vring base

On 5/9/2016 6:45 PM, Victor Kaplansky wrote: >> diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c >> > index c88aaa3..df103aa 100644 >> > --- a/lib/librte_vhost/virtio-net.c >> > +++ b/lib/librte_vhost/virtio-net.c >> > @@ -560,6 +560,14 @@ vhost_set_vring_addr(int vid,

[dpdk-dev] [PATCH 2/6] vhost: add vhost-user client mode

On Mon, May 09, 2016 at 06:33:45AM -0400, Victor Kaplansky wrote: > Adding a flag for a future extension seems fine to me. > Could we manage without adding a flag? > For example, could we always try a client mode for a while at first, > and if unsuccessful, then come up with server mode? It's

[dpdk-dev] rte_malloc

Hello All, I had a problem regarding use the rte_malloc. I want to know if I want to use rte_malloc instead of malloc just mak change like this struct lcore_params *p = malloc (sizeof(*p)); ==> struct lcore_params *p

[dpdk-dev] [PATCH] examples/kni: unchecked return value

Fix issue reported by Coverity. Coverity ID 30692 If the function returns an error value, the error value may be mistaken for a normal value. In kni_free_kni: Value returned from a function is not checked for errors before being used Fixes: b475eb0bc400 ("examples/kni: new parameters")

[dpdk-dev] [PATCH 6/6] vhost: add pmd client and reconnect option

On Mon, May 09, 2016 at 06:54:04AM -0400, Victor Kaplansky wrote: > Looks OK to me. I didn't quite get why open_int() is called so. > What does it open? Thanks for review. It's a callback for key-value arg processing. It turns the value string into a number. --yliu

[dpdk-dev] [PATCH 4/6] vhost: workaround stale vring base

On Mon, May 09, 2016 at 01:39:25PM +, Xie, Huawei wrote: > On 5/9/2016 6:45 PM, Victor Kaplansky wrote: > >> diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c > >> > index c88aaa3..df103aa 100644 > >> > --- a/lib/librte_vhost/virtio-net.c > >> > +++

[dpdk-dev] [PATCH 4/6] vhost: workaround stale vring base

On Mon, May 09, 2016 at 04:25:38PM +, Xie, Huawei wrote: > On 5/7/2016 2:36 PM, Yuanhan Liu wrote: > > However, Michael claims some concerns: he made a good point: a crash > > is happening means some memory is corrupted, and it could be the virtio > > memory being corrupted. In such case,

[dpdk-dev] [PATCH 3/6] vhost: add reconnect ability

On Mon, May 09, 2016 at 04:47:02PM +, Xie, Huawei wrote: > On 5/7/2016 2:36 PM, Yuanhan Liu wrote: > > +static void * > > +vhost_user_client_reconnect(void *arg) > > +{ > > + struct reconnect_info *reconn = arg; > > + int ret; > > + > > + RTE_LOG(ERR, VHOST_CONFIG, "reconnecting...\n");

[dpdk-dev] [PATCH v2 0/8] vhost/example cleanup/fix

Series applied to dpdk-next-virtio. --yliu On Mon, May 02, 2016 at 02:23:42PM -0700, Yuanhan Liu wrote: > I'm starting to work on the vhost ABI refactoring, that I also have to > touch the vhost example code. The vhost example code, however, is very > messy, full of __very__ long lines.

[dpdk-dev] [PATCH v3 1/2] virtio: cleanup virtio_dev_queue_setup()

On Mon, May 09, 2016 at 07:58:26AM +, Tan, Jianfeng wrote: > Hi Yuanhan, > > > -Original Message- > > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > > Sent: Thursday, May 5, 2016 11:20 AM > > To: Tan, Jianfeng > > Cc: dev at dpdk.org; Xie, Huawei > > Subject: Re: [PATCH

[dpdk-dev] [PATCH v2] virtio: fix modify drv_flags for specific device

On Mon, May 09, 2016 at 09:14:41AM +, Tan, Jianfeng wrote: > When two virtio devices have different flags, it may lead to wrong > result. Then some unexpected behaviors happen, such as virtio would > set irq config when it's not supported. Yes, that's the issue; and that's exactly

[dpdk-dev] [PATCH 20/20] maintainers: claim responsibility for the ThunderX nicvf PMD

2016-05-07 20:46, Jerin Jacob: > --- a/MAINTAINERS > +++ b/MAINTAINERS > +Thunderx nicvf Cavium ThunderX nicvf?

[dpdk-dev] [PATCH v3] eal: make hugetlb initialization more robust

This patch adds an option, --huge-trybest, to use a recover mechanism to the case that there are not so many hugepages (declared in sysfs), which can be used. It relys on a mem access to fault-in hugepages, and if fails with SIGBUS, recover to previously saved stack environment with siglongjmp().

[dpdk-dev] [PATCH 19/20] thunderx/nicvf: updated driver documentation and release notes

2016-05-07 20:46, Jerin Jacob: > --- a/doc/guides/nics/overview.rst > +++ b/doc/guides/nics/overview.rst > + = = = = = = = = = = = = = = = = = = = = = = = = = = > = = = = = = = = = = > + Feature a b b b c e e e i i i i i i i i i i f f f f m m m n > n p r s t

[dpdk-dev] [PATCH 02/20] thunderx/nicvf: add pmd skeleton

On Sat, 7 May 2016 20:46:20 +0530 Jerin Jacob wrote: > + > +static inline struct nicvf* > +nicvf_pmd_priv(struct rte_eth_dev *eth_dev) > +{ > + return (struct nicvf *)eth_dev->data->dev_private; > +} Cast here is unnecessary because dev_private is void *

[dpdk-dev] [PATCH 02/20] thunderx/nicvf: add pmd skeleton

On Sat, 7 May 2016 20:46:20 +0530 Jerin Jacob wrote: > + > +static struct rte_pci_id pci_id_nicvf_map[] = { > + { Another table that should be const

[dpdk-dev] [PATCH] mk: Introduce NXP dpaa2 architecture based on armv8-a

2016-05-09 19:18, Hemant Agrawal: > This patch introduces dpaa2 machine target to address difference > in cpu parameter, number of core to 8 and no numa support > w.r.t default armv8-a machine > > Signed-off-by: Hemant Agrawal [...] > --- /dev/null > +++ b/mk/machine/dpaa2/rte.vars.mk > +# ARCH

[dpdk-dev] [PATCH v3] examples/qos_meter: fix unchecked return value

Fix issue reported by Coverity. Coverity ID 30693: Unchecked return value check_return: Calling rte_meter_srtcm_config without checking return value. Fixes: e6541fdec8b2 ("meter: initial import") Signed-off-by: Slawomir Mrozowicz --- examples/qos_meter/main.c | 15 ++-

[dpdk-dev] [PATCH 01/20] thunderx/nicvf/base: add hardware API for ThunderX nicvf inbuilt NIC

On Sat, 7 May 2016 20:46:19 +0530 Jerin Jacob wrote: > +static struct nicvf_reg_info nicvf_reg_tbl[] = { > + NICVF_REG_INFO(NIC_VF_CFG), > + NICVF_REG_INFO(NIC_VF_PF_MAILBOX_0_1), > + NICVF_REG_INFO(NIC_VF_INT), > + NICVF_REG_INFO(NIC_VF_INT_W1S), > +

[dpdk-dev] [PATCH] mk: Introduce NXP dpaa2 architecture based on armv8-a

From: Santosh Shukla [mailto:sshu...@mvista.com] Sent: Monday, May 09, 2016 2:44 PM To: Jerin Jacob Cc: Hemant Agrawal ; dpdk ; Jianbo Liu ; Shukla, Santosh Subject: Re: [dpdk-dev] [PATCH] mk: Introduce NXP dpaa2 architecture based on armv8-a On Mon, May 9, 2016 at 2:36 PM, Jerin Jacob

[dpdk-dev] [PATCH v2] virtio: fix modify drv_flags for specific device

Hi David and Yuanhan, > -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Thursday, May 5, 2016 7:18 AM > To: Tan, Jianfeng > Cc: David Marchand; dev at dpdk.org; Xie, Huawei > Subject: Re: [PATCH v2] virtio: fix modify drv_flags for specific device >

[dpdk-dev] [PATCH] mk: Introduce NXP dpaa2 architecture based on armv8-a

-Original Message- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Monday, May 09, 2016 2:10 PM To: Hemant Agrawal Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: Introduce NXP dpaa2 architecture based on armv8-a 2016-05-09 19:18, Hemant Agrawal: > This patch

[dpdk-dev] [PATCH] virtio: split virtio rx/tx queue

On Mon, May 09, 2016 at 05:44:03AM +, Xie, Huawei wrote: > > > > -Original Message- > > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > > Sent: Monday, May 09, 2016 1:15 PM > > To: Xie, Huawei > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] virtio: split

[dpdk-dev] [PATCH] examples/kni: unchecked return value

> -Original Message- > From: Mrzyglod, DanielX T > Sent: Monday, May 9, 2016 5:39 PM > To: Zhang, Helin > Cc: dev at dpdk.org; Mrzyglod, DanielX T > Subject: [PATCH] examples/kni: unchecked return value > > Fix issue reported by Coverity. > Coverity ID 30692 > > If the function

[dpdk-dev] [PATCH v3 1/2] virtio: cleanup virtio_dev_queue_setup()

Hi Yuanhan, > -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Thursday, May 5, 2016 11:20 AM > To: Tan, Jianfeng > Cc: dev at dpdk.org; Xie, Huawei > Subject: Re: [PATCH v3 1/2] virtio: cleanup virtio_dev_queue_setup() > > On Fri, Apr 29, 2016 at

[dpdk-dev] [PATCH 6/6] vhost: add pmd client and reconnect option

Looks OK to me. I didn't quite get why open_int() is called so. What does it open? -- Victor - Original Message - > From: "Yuanhan Liu" > To: dev at dpdk.org > Cc: "huawei xie" , "Yuanhan Liu" linux.intel.com>, "Tetsuya Mukawa" > > Sent: Saturday, May 7, 2016 9:40:24 AM > Subject:

[dpdk-dev] [PATCH 5/6] examples/vhost: add client and reconnect option

Again, it may be useful to add mixed --client-server option, when backend tries to connect as client and if failed, comes up as a server... Just a suggestion from user point of view... - Original Message - > From: "Yuanhan Liu" > To: dev at dpdk.org > Cc: "huawei xie" , "Yuanhan Liu"

[dpdk-dev] [PATCH 4/6] vhost: workaround stale vring base

- Original Message - > From: "Yuanhan Liu" > To: dev at dpdk.org > Cc: "huawei xie" , "Yuanhan Liu" linux.intel.com>, "Michael S. Tsirkin" > > Sent: Saturday, May 7, 2016 9:40:22 AM > Subject: [dpdk-dev] [PATCH 4/6] vhost: workaround stale vring base > > When DPDK app crashes (or

[dpdk-dev] [PATCH 2/6] vhost: add vhost-user client mode

Adding a flag for a future extension seems fine to me. Could we manage without adding a flag? For example, could we always try a client mode for a while at first, and if unsuccessful, then come up with server mode? -- Victor - Original Message - > From: "Yuanhan Liu" > To: dev at

[dpdk-dev] [PATCH] virtio: split virtio rx/tx queue

> -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Monday, May 09, 2016 1:15 PM > To: Xie, Huawei > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] virtio: split virtio rx/tx queue > > On Thu, May 05, 2016 at 05:29:27AM +, Xie, Huawei

[dpdk-dev] [PATCH] i40evf: fix return value if command fails

> -Original Message- > From: Richardson, Bruce > Sent: Friday, May 06, 2016 11:14 PM > To: Wu, Jingjing > Cc: Zhang, Helin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] i40evf: fix return value if command fails > > On Thu, May 05, 2016 at 02:22:54PM +0800, Jingjing Wu wrote: > >