This patch accumulates crypto AES test vectors into a new header file.
Signed-off-by: Fan Zhang
---
app/test/test_cryptodev_aes.h | 822 ++
1 file changed, 822 insertions(+)
create mode 100755 app/test/test_cryptodev_aes.h
diff --git
This patchset reworks the crypto AES unit test by introducing a new
unified test function.
This patchset depends on the following patches/patchsets:
"qat: fix phys address of content descriptor"
(http://dpdk.org/dev/patchwork/patch/13137/)
and
"Add AES Counter mode support for AES-NI MB PMD"
We can now just OR the vfio_enabled sequentially and so adding new VFIO
subsystems (vfio_platform) is possible.
Signed-off-by: Jan Viktorin
---
lib/librte_eal/linuxapp/eal/eal.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal.c
The VFIO does not depend on the PCI anymore so it can be initialized out of
the PCI subsystem.
Signed-off-by: Jan Viktorin
---
lib/librte_eal/linuxapp/eal/eal.c | 31 ++
lib/librte_eal/linuxapp/eal/eal_pci.c | 17 +---
The module eal_pci_vfio_mp_sync is quite generic so it shouldn't contain the
"pci" string in its name. The internal functions don't need the pci_* prefix.
Signed-off-by: Jan Viktorin
---
lib/librte_eal/linuxapp/eal/Makefile | 4 ++--
There is no more reason to expose those definitions as nobody uses them.
Signed-off-by: Jan Viktorin
---
lib/librte_eal/linuxapp/eal/eal_vfio.c | 15 +--
lib/librte_eal/linuxapp/eal/eal_vfio.h | 11 ---
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git
Signed-off-by: Jan Viktorin
Suggested-by: Anatoly Burakov
---
lib/librte_eal/linuxapp/eal/eal_vfio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.h
b/lib/librte_eal/linuxapp/eal/eal_vfio.h
index d4532a5..4ca0fa3 100644
---
The vfio_cfg is a module-global variable and so together with this
variable, it is necessary to move functions:
* pci_vfio_get_group_fd
- renamed to vfio_get_group_fd
- pci_* version removed (no other call in EAL)
* pci_vfio_setup_device
- renamed as vfio_setup_device
* pci_vfio_enable
The setup logic access the global vfio_cfg variable that will be moved in the
following commits. We need to separate all accesses to this variable to a
general code.
Signed-off-by: Jan Viktorin
---
v2
* fixed lost viable code (A. Burakov)
---
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 85
Generalize the pci_vfio_get_group_no to not be PCI-specific. Move the general
implementation to the eal_vfio.c as vfio_get_group_no and leave the original
pci_vfio_get_group_no being a wrapper around this to preserve compilation
issues. The pci_vfio_get_group_no function will be removed later.
The pci_vfio_get_container_fd is not PCI-specific. Move the implementation to
the eal_vfio.c as vfio_get_container_fd. No other code seems to call this
function.
Signed-off-by: Jan Viktorin
---
lib/librte_eal/linuxapp/eal/eal_pci_init.h | 1 -
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
The constants are not PCI-specific. Move them into the eal_vfio.h.
Signed-off-by: Jan Viktorin
---
lib/librte_eal/linuxapp/eal/eal_pci_init.h | 7 ---
lib/librte_eal/linuxapp/eal/eal_vfio.h | 6 ++
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git
The pci_vfio_has_supported_extensions is not PCI-specific and it is a private
function of the eal_pci_vfio.c. We just rename the function and make it
available even for non-PCI devices.
Signed-off-by: Jan Viktorin
---
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 36
The pci_vfio_set_iommu_type is not PCI-specific and it is a private function
of the eal_pci_vfio.c. We just rename the function and make it available even
for non-PCI devices.
Signed-off-by: Jan Viktorin
---
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 25 +
We make the iommu_types public temporarily here until the depending stuff is
refactored. The iommu_types and dma_map functions will be changed to be private
inside the eal_vfio module later.
Signed-off-by: Jan Viktorin
---
lib/librte_eal/linuxapp/eal/Makefile | 1 +
Signed-off-by: Jan Viktorin
---
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 7 ---
lib/librte_eal/linuxapp/eal/eal_vfio.h | 7 +++
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
The common VFIO definitions should be separated from the PCI-specific parts.
Signed-off-by: Jan Viktorin
---
lib/librte_eal/linuxapp/eal/eal_pci_init.h | 28
lib/librte_eal/linuxapp/eal/eal_vfio.h | 28
2 files changed, 28
Signed-off-by: Jan Viktorin
---
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
index 10266f8..257162b 100644
---
Hello,
here follows several patchs extracting the general VFIO code out of the
PCI + VFIO code base. Usually, it's just move and rename of functions.
The goal is to be able to extend for other Linux VFIO drivers then
vfio-pci. That is especially vfio-platform. However, just the
vfio-platform
On Mon, Jun 13, 2016 at 12:39:33PM +, Ananyev, Konstantin wrote:
>
>
> > -Original Message-
> > From: Olivier Matz [mailto:olivier.matz at 6wind.com]
> > Sent: Monday, May 23, 2016 8:56 AM
> > To: dev at dpdk.org
> > Cc: johndale at cisco.com; Ananyev, Konstantin; Zhang, Helin; arnon
On Fri, May 27, 2016 at 04:13:04PM +, Iremonger, Bernard wrote:
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michal Jastrzebski
> > Sent: Friday, May 27, 2016 4:21 PM
> > To: dev at dpdk.org
> > Subject: [dpdk-dev] [PATCH] bond: replace rte_panic
Hi Konstantin,
On 06/13/2016 02:42 PM, Ananyev, Konstantin wrote:
>
> Hi Olivier,
>
>>> -Original Message-
>>> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
>>> Sent: Monday, May 23, 2016 8:56 AM
>>> To: dev at dpdk.org
>>> Cc: johndale at cisco.com; Ananyev, Konstantin; Zhang,
Hi Olivier,
On 13/6/2016 1:16 PM, Olivier Matz wrote:
> Hi David,
>
> Some comments below.
>
> On 06/10/2016 05:16 PM, David Hunt wrote:
>> Until now, the objects stored in a mempool were internally stored in a
>> ring. This patch introduces the possibility to register external handlers
>>
On Mon, May 30, 2016 at 03:48:03PM +0900, Tetsuya Mukawa wrote:
> On 2016/05/27 21:28, Mcnamara, John wrote:
> >> -Original Message-
> >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sean Harte
> >> Sent: Friday, May 27, 2016 1:27 PM
> >> To: mukawa at igel.co.jp
> >> Cc: dev at
To enable this feature, the user should pass a devargs parameter to the EAL
like "-w 84:00.0,enable_floating=1", and the application will make sure the PMD
will use the floating VEB feature for all the VFs created by this PF device.
Also you can specifiy which VF need to connect to this floating
This patch add the support for floating VEB in i40e.
All the VFs VSIs can decide whether to connect to the legacy VEB/VEPA or
the floating VEB. When connect to the floating VEB a new floating VEB is
created. Now all the VFs need to connect to floating VEB or legacy VEB,
cannot connect to both of
Add the new floating related argument option in the devarg.
Using this parameter, all the samples can decide whether to use legacy VEB/VEPA
or floating VEB.
To enable this feature, the user should pass a devargs parameter to the EAL
like "-w 84:00.0,enable_floatingVEB=1", and the application will
This patch-set add the support for floating VEB in i40e.
All the VFs VSIs can decide whether to connect to the legacy VEB/VEPA or
the floating VEB. When connect to the floating VEB a new floating VEB is
created. Now all the VFs need to connect to floating VEB or legacy VEB,
cannot connect to both
Hi Olivier,
>
> The behavior of PKT_RX_VLAN_PKT was not very well defined, resulting in
> PMDs not advertising the same flags in similar conditions.
>
> Following discussion in [1], introduce 2 new flags PKT_RX_VLAN_STRIPPED
> and PKT_RX_QINQ_STRIPPED that are better defined:
>
>
On Mon, Jun 13, 2016 at 02:49:41PM +0200, Olivier Matz wrote:
> Hi Konstantin,
>
> On 06/13/2016 02:42 PM, Ananyev, Konstantin wrote:
> >
> > Hi Olivier,
> >
> >>> -Original Message-
> >>> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
> >>> Sent: Monday, May 23, 2016 8:56 AM
>
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jan Viktorin
> Sent: Friday, May 06, 2016 7:18 PM
> To: dev at dpdk.org
> Cc: Jan Viktorin ; David Marchand
> ; Thomas Monjalon ;
> Bruce Richardson ; Declan Doherty
> ; jianbo.liu at linaro.org;
> jerin.jacob
Hi Lazaros,
On 05/11/2016 11:56 AM, Olivier MATZ wrote:
> Hi Lazaros,
>
> Sorry for the late review. Please find some comments,
> in addition to what Konstantin already said.
>
Will you have the time to send a v3 before the end of the
integration deadline at the end of the week?
I think it
Another trivial comment inlined:
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jan Viktorin
> Sent: Friday, May 06, 2016 7:18 PM
> To: dev at dpdk.org
> Cc: Jan Viktorin ; David Marchand
> ; Thomas Monjalon ;
> Bruce Richardson ; Declan Doherty
> ;
Hi Jan,
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jan Viktorin
> Sent: Friday, May 06, 2016 7:18 PM
> To: dev at dpdk.org
> Cc: Jan Viktorin ; David Marchand
> ; Thomas Monjalon ;
> Bruce Richardson ; Declan Doherty
> ; jianbo.liu at linaro.org;
>
Hi David,
Some comments below.
On 06/10/2016 05:16 PM, David Hunt wrote:
> Until now, the objects stored in a mempool were internally stored in a
> ring. This patch introduces the possibility to register external handlers
> replacing the ring.
>
> The default behavior remains unchanged, but
On Mon, Jun 13, 2016 at 01:53:28PM +0100, Bruce Richardson wrote:
> On Fri, Jun 10, 2016 at 05:09:31PM +0200, Adrien Mazarguil wrote:
> > Various BSD ioctl macros are not exposed anymore when _XOPEN_SOURCE is
> > defined, and linux/if.h now conflicts with net/if.h.
> >
> > Suggested-by: Bruce
On 6/13/2016 12:50 PM, Christian Ehrhardt wrote:
> Hi,
> I wondered multiple times now when changing a config symbol that some of
> them are in the .config file multiple times.
> I totally feel like I'm overlooking something, but still it might be worth
> to ask.
>
> In particular:
> awk -F "="
Hello Alexander,
On Tue, Jun 7, 2016 at 11:31 PM, Alexander Duyck
wrote:
> On Tue, Jun 7, 2016 at 1:49 PM, Mauricio V?squez
> wrote:
> > Dear All,
> >
> > I implemented a program that uses flow director to forward packets to a
> > specific virtual function, however I faced the problem that I
Yeah, working now - thanks for the fast update!
Kind Regards,
Christian
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd
On Mon, Jun 13, 2016 at 1:24 PM, Olivier Matz
wrote:
> The field elt_va_start has been removed from the mempool structure,
> and it was not replaced in
This patch adds the HMAC-SHA224 and HMAC-SHA384 digest generation and
verification tests to crypto
Signed-off-by: Fan Zhang
---
app/test/test_cryptodev_aes.c | 26
app/test/test_cryptodev_aes.h | 296 ++
2 files changed, 322 insertions(+)
diff
This patch replaces the AES test code with new unified crypto AES test
function.
Signed-off-by: Fan Zhang
---
app/test/test_cryptodev.c | 1613 ++--
app/test/test_cryptodev_aes.c |6 +-
app/test/test_cryptodev_aes_ctr_test_vectors.h
This patch adds a new crypto AES unified test function.
Signed-off-by: Fan Zhang
---
app/test/Makefile | 1 +
app/test/test_cryptodev_aes.c | 663 ++
app/test/test_cryptodev_aes.h | 6 +
3 files changed, 670 insertions(+)
create mode
This patch accumulates crypto AES test vectors into a new header file.
Signed-off-by: Fan Zhang
---
app/test/test_cryptodev_aes.h | 822 ++
1 file changed, 822 insertions(+)
create mode 100755 app/test/test_cryptodev_aes.h
diff --git
This patchset reworks the crypto AES unit test by introducing a new
unified test function.
This patchset depends on the following patches/patchsets:
"qat: fix phys address of content descriptor"
(http://dpdk.org/dev/patchwork/patch/13137/)
and
"Add AES Counter mode support for AES-NI MB PMD"
On Fri, Jun 10, 2016 at 05:09:31PM +0200, Adrien Mazarguil wrote:
> Various BSD ioctl macros are not exposed anymore when _XOPEN_SOURCE is
> defined, and linux/if.h now conflicts with net/if.h.
>
> Suggested-by: Bruce Richardson
> Signed-off-by: Adrien Mazarguil
Acked-by: Bruce Richardson
Hi,
I wondered multiple times now when changing a config symbol that some of
them are in the .config file multiple times.
I totally feel like I'm overlooking something, but still it might be worth
to ask.
In particular:
awk -F "=" '/=/ {print $1}' debian/build/static-root/.config | sort | uniq
-c
Hi,
On 05/27/2016 04:33 PM, Olivier Matz wrote:
> The behavior of PKT_RX_VLAN_PKT was not very well defined, resulting in
> PMDs not advertising the same flags in similar conditions.
>
> Following discussion in [1], introduce 2 new flags PKT_RX_VLAN_STRIPPED
> and PKT_RX_QINQ_STRIPPED that are
Hi,
On 05/23/2016 09:56 AM, Olivier Matz wrote:
> Following the discussions from:
> http://dpdk.org/ml/archives/dev/2015-July/021721.html
> http://dpdk.org/ml/archives/dev/2016-April/038143.html
>
> The value of these flags is 0, making them useless. Today, no example
> application checks them
The field elt_va_start has been removed from the mempool structure,
and it was not replaced in xenvirt.
Fix this by getting the mempool objects address by using the address of
the first memory chunk list.
Note that it won't work with mempool composed of several chunks,
but it was already the
Hi Ethan,
Great, we?ll wait for your patch later this week then. I recommend you add any
other changes that you might have on top of the latest code that I just send,
as this will minimize your work, my work to further code reviews and number of
future iterations to merge this patch.
Answers
This patch adds missing DEPDIRS to avoid any library referring to
symbols they are not linked against.
Signed-off-by: Christian Ehrhardt
---
drivers/crypto/null/Makefile | 2 ++
drivers/net/af_packet/Makefile | 1 +
drivers/net/bonding/Makefile | 2 ++
drivers/net/fm10k/Makefile | 1 +
Add the missing external dependency to pthread to avoid referring to
symbols the library is not linked against.
Signed-off-by: Christian Ehrhardt
---
drivers/net/vhost/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/vhost/Makefile b/drivers/net/vhost/Makefile
index
After several cleanups libraries are now linked against the libs they
refer as DEPDIR which is great.
But that now also made it visible that some references where still missing.
The following two patches try to fix that:
[PATCH v2 1/2] mk: fix missing vhost dependency to pthread to avoid
[PATCH
2016-06-13 11:26, Tomasz Kantecki:
> 'red_autotest' changed to run only functional tests without test #4 which was
> taking ~53 seconds. 'red_autotest' takes ~2[s] now.
> 'red_perf' has been added to run performance tests only).
> 'red_all' has been added to run all functional tests (including #4)
Hi Olivier,
> > -Original Message-
> > From: Olivier Matz [mailto:olivier.matz at 6wind.com]
> > Sent: Monday, May 23, 2016 8:56 AM
> > To: dev at dpdk.org
> > Cc: johndale at cisco.com; Ananyev, Konstantin; Zhang, Helin; arnon at
> > qwilt.com; rolette at infinite.io; Chen, Jing D; Wu,
> -Original Message-
> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
> Sent: Monday, May 23, 2016 8:56 AM
> To: dev at dpdk.org
> Cc: johndale at cisco.com; Ananyev, Konstantin; Zhang, Helin; arnon at
> qwilt.com; rolette at infinite.io; Chen, Jing D; Wu, Jingjing
> Subject:
Hi Bruce,
> Subject: Re: [dpdk-dev] [PATCH v3 3/4] bonding: take queue spinlock in rx/tx
> burst functions
>
> On Sun, Jun 12, 2016 at 06:11:28PM +0100, Bernard Iremonger wrote:
> > Use rte_spinlock_trylock() in the rx/tx burst functions to take the
> > queue spinlock.
> >
> > Signed-off-by:
Hi,
On 05/23/2016 09:43 AM, Olivier Matz wrote:
> Hi Panu, Thomas,
>
> On 05/20/2016 11:09 AM, Thomas Monjalon wrote:
>> 2016-05-20 11:42, Panu Matilainen:
>>> Just noticed this series "breaks" --no-huge as a regular user, commit
>>> 593a084afc2b to be exact:
>>>
>>> mmap(NULL, 4194304,
Since recently [1], it is not possible to run the dpdk with user
(non-root) privileges and the --no-huge option. This is because the eal
layer tries to lock the memory. Using locked memory is mandatory for
physical devices because they reference physical addresses.
But a user may want to start
2016-06-13 11:04, Ferruh Yigit:
> On 6/13/2016 10:29 AM, Thomas Monjalon wrote:
> > 2016-06-10 19:32, Ferruh Yigit:
> >> As stated in the comment:
> >> Order is important: from higher level to lower level
> >>
> >> This is an attempt to make the layering order better respected.
> >>
> >> Limit
On Mon, Jun 13, 2016 at 12:08 PM, Thomas Monjalon wrote:
> 2016-06-13 11:48, Christian Ehrhardt:
> > --- a/drivers/net/af_packet/Makefile
> > +++ b/drivers/net/af_packet/Makefile
> > @@ -54,5 +54,6 @@ SRCS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) +=
> rte_eth_af_packet.c
> >
On 12 June 2016 at 11:30, Rosen, Rami wrote:
> Hi Thiago,
>
> > Any clue?
>
> Sure. This is the reason: in dpdk-16.04/lib/librte_eal/linuxapp/igb_uio we
> have:
>
> #ifndef PCI_MSIX_ENTRY_SIZE
> #define PCI_MSIX_ENTRY_SIZE 16
> #define PCI_MSIX_ENTRY_LOWER_ADDR 0
> #define
2016-06-13 11:48, Christian Ehrhardt:
> --- a/drivers/net/af_packet/Makefile
> +++ b/drivers/net/af_packet/Makefile
> @@ -54,5 +54,6 @@ SRCS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) +=
> rte_eth_af_packet.c
> DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_mbuf
>
On Fri, May 27, 2016 at 01:06:20PM +0100, Reshma Pattan wrote:
> Testpmd application will crash in fclose() upon quit after running
> the below command.
>
> "sudo gdb --args ./x86_64-native-linuxapp-gcc/app/testpmd -c 0xf0 -n 4
> --vdev
On Fri, May 27, 2016 at 04:05:45PM +0800, Jingjing Wu wrote:
> Vlan filter didn't work if promiscuous mode is enabled. That is
> because i40e driver uses MAC VLAN table for the l2 filtering and
> internal switch. And the vlan table is disabled by default, till
> the first time to add rule in vlan
> Enhance mlx5 with a data path that bypasses Verbs.
>
> The first half of this patchset removes support for functionality
completely
> rewritten in the second half (scatter/gather, inline send), while the data
> path is refactored without Verbs.
>
> The PMD remains usable during the transition.
>
After several cleanups libraries are now linked against the libs the
refer as DEPDIR which is great. But that now made it visible that some DEPDIRS
where still missing.
This patch is adding the missing depdirs to avoid any library referring to
symbols they are not linked against (found with
Signed-off-by: Ferruh Yigit
---
drivers/net/bnx2x/Makefile | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/bnx2x/Makefile b/drivers/net/bnx2x/Makefile
index 6f1f385..c2ddd8d 100644
--- a/drivers/net/bnx2x/Makefile
+++ b/drivers/net/bnx2x/Makefile
@@ -14,6 +14,10 @@ EXPORT_MAP
When starting the ip_fragmentation or ip_reassembly example
on several sockets, it fails.
The name of the lpm6 table is the same on every socket,
resulting in a table creation failure (-EEXIST). The failure
appeared after:
commit f82f705b635d ("lpm: fix allocation of an existing object")
Indeed,
Return value of function app_pipeline_type_find is not checking before
dereference. Fix this problem by adding checking condition.
Coverity issue: 127196
Fixes: b4aee0fb9c6d ("examples/ip_pipeline: reconfigure thread binding
dynamically")
Signed-off-by: Marcin Kerlin
---
On 6/10/2016 11:08 AM, Ferruh Yigit wrote:
> On 6/8/2016 5:15 PM, Bruce Richardson wrote:
>> On Wed, May 11, 2016 at 05:06:21PM -0700, Rasesh Mody wrote:
>>> Fix stats_get() routine to display drop counters under imissed counter.
>>>
>>> Fixes: 540a211084a7 ("bnx2x: driver core")
>>>
>>>
On 6/13/2016 11:21 AM, Thomas Monjalon wrote:
> 2016-06-13 11:04, Ferruh Yigit:
>> On 6/13/2016 10:29 AM, Thomas Monjalon wrote:
>>> 2016-06-10 19:32, Ferruh Yigit:
As stated in the comment:
Order is important: from higher level to lower level
This is an attempt to make the
2016-06-10 19:32, Ferruh Yigit:
> As stated in the comment:
> Order is important: from higher level to lower level
>
> This is an attempt to make the layering order better respected.
>
> Limit scope of --whole-archive to pmd libraries
Compared to the link order in the v2, you did two
'red_autotest' changed to run only functional tests without test #4 which was
taking ~53 seconds. 'red_autotest' takes ~2[s] now.
'red_perf' has been added to run performance tests only).
'red_all' has been added to run all functional tests (including #4) and
perfromance tests. This reflects
Hi,
great work on cleaning that up already.
I applied v3 of the series and see already much better results.
But I found some more that should be part of this.
I don't know how generally available a similar solution is, but usually in
our build dpkg-shlibdeps checks for under/overlinking issues.
I
On Fri, May 27, 2016 at 12:44:04PM -0700, Eric Kinzie wrote:
Ping for review. Maintainer, any comments?
> This patchset introduces the ability to use an external 802.3ad state
> machine for mode 4 bonding. Functions to alter the mux state and to
> allow LACPDUs to be sent and received from
> -Original Message-
> From: Kerlin, MarcinX
> Sent: Monday, June 13, 2016 10:36 AM
> To: dev at dpdk.org
> Cc: Azarewicz, PiotrX T ; Dumitrescu,
> Cristian
> ; Kerlin, MarcinX
>
> Subject: [PATCH 1/1] ip_pipeline: fix null pointer dereference
>
> Return value of function
Hi John and Nelson,
I have a question regarding Coverity defects:
File: /drivers/net/enic/enic_ethdev.c
Line: 379
CID 13197: Unchecked return value
(CHECKED_RETURN)1.?check_return:?Calling?rte_atomic64_cmpset?without checking
return value (as is done elsewhere 15 out of 17 times)
Can I mark
On 06/13/2016 11:10 AM, Christian Ehrhardt wrote:
> Hmm,
> Hi again Oliver.
>
> I was too fast saying yes.
> I don't know what is different now but I clearly tested it wrong the
> first time.
> Now I get:
>
> CC rte_xen_lib.o
>
Hmm,
Hi again Oliver.
I was too fast saying yes.
I don't know what is different now but I clearly tested it wrong the first
time.
Now I get:
CC rte_xen_lib.o
/mnt/nvme/dpdk-16-07-pre-linking/drivers/net/xenvirt/rte_xen_lib.c: In
function ?grant_gntalloc_mbuf_pool?:
On Tue, May 24, 2016 at 09:25:34AM +0200, Daniel Mrzyglod wrote:
> Calling i40e_switch_rx_queue without checking return value.
> Fixed by add warning log information if return failed.
>
> Fixes: 71d35259ff67 ("i40e: tear down flow director")
> Coverity ID 13198
>
> Signed-off-by: Daniel Mrzyglod
Problem:
The flag for RSS and flow director is not set correctly in the
vector RX function, so the upper layer APP which base on the related
flags will not work correctly.
Fix this problem by change the shuffle table. the original shuffle
table is not correct.
Fixes: 9ed94 (i40e: add vector Rx)
On 6/13/2016 10:29 AM, Thomas Monjalon wrote:
> 2016-06-10 19:32, Ferruh Yigit:
>> As stated in the comment:
>> Order is important: from higher level to lower level
>>
>> This is an attempt to make the layering order better respected.
>>
>> Limit scope of --whole-archive to pmd libraries
>
>
On Mon, May 23, 2016 at 02:25:15PM +0200, Slawomir Mrozowicz wrote:
> Calling i40e_switch_tx_queue without checking return value.
> Fixed by add warning log information if return failed.
>
> Fixes: 71d35259ff67 ("i40e: tear down flow director")
> Coverity ID 13208
>
> Signed-off-by: Slawomir
Hi Oliver,
thanks for the fast response!
It fixes the compilation issue and I totally agree to your argument of the
multi-chunk issues being out of scope for this as they never worked.
Unfortunately I lack an environment to actually test this in real-life if
we need any more follow up than this.
Hi Wenzhuo,
> > > > >
> > > > >
> > > > > >
> > > > > > 3. I thought the plan was to introduce a locking in all
> > > > > > appropriate control path functions (dev_start/dev_stop etc.)
> > > > > > Without that locking version of RX/TX seems a bit useless.
> > > > > > Yes, I understand that you
Hi,
On 06/13/2016 09:41 AM, Ding, HengX wrote:
> The following command will cause ip_fragmentation app fail:
> examples/ip_fragmentation/build/ip_fragmentation -c 0x40002 -n 4 -- -p 0x3 -q
> 2
> while setting core mask to 0x2 or 0x4 will not cause this issue.
>
> error message is shown
On Mon, Jun 13, 2016 at 10:14 AM, Olivier Matz
wrote:
> Hi Christian,
>
> On 06/13/2016 09:34 AM, Christian Ehrhardt wrote:
> > Hi David,
>
> I guess this mail is for me, not for David :)
>
Absolutely yes, sorry to both of you to - probably read too much patch
headers this morning :-)
> > it
Hi Ethan,
In the process of testing your patch, I actually had to do the rebase on the
latest code and fix all the comments that I previously sent as part of my
reply. I also did a few other cosmetic changes and fixes required by the latest
code (see below), therefore I think it makes sense to
The field elt_va_start has been removed from the mempool structure,
and it was not replaced in xenvirt.
Fix this by getting the mempool objects address by using the address of
the first memory chunk list.
Note that it won't work with mempool composed of several chunks,
but it was already the
Oh, I forgot to rebase on the very last HEAD, there is a trivial
merge conflict with
commit a3f34a98b7217f4ff2a8636096984f566a4e7cab
Author: Thomas Monjalon
Date: Thu Jun 9 15:49:48 2016 +0200
log: deprecate history dump
Should I repost it?
Regards
Jan
On Mon, 13 Jun 2016 10:12:20
> -Original Message-
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Monday, June 13, 2016 6:14 PM
> To: Tan, Jianfeng
> Cc: dev at dpdk.org; rich.lane at bigswitch.com; mst at redhat.com;
> nakajima.yoshihiro at lab.ntt.co.jp; p.fedin at samsung.com;
>
On Sun, Jun 12, 2016 at 06:11:28PM +0100, Bernard Iremonger wrote:
> Use rte_spinlock_trylock() in the rx/tx burst functions to
> take the queue spinlock.
>
> Signed-off-by: Bernard Iremonger
> Acked-by: Konstantin Ananyev
> ---
Why does this particular PMD need spinlocks when doing RX and TX,
Hi Christian,
On 06/13/2016 09:34 AM, Christian Ehrhardt wrote:
> Hi David,
I guess this mail is for me, not for David :)
> it seems to be the first time I compiled with
> CONFIG_RTE_LIBRTE_PMD_XENVIRT=y sinec the bigger mempool changes around
> "587d684d doc: update release notes about mempool
Dumping of devices in a unittest is useless. Instead, test whether
the test has been set up well - i.e. there are no devices.
Signed-off-by: Jan Viktorin
---
app/test/test_pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/test/test_pci.c b/app/test/test_pci.c
index
The SYSFS_PCI_DEVICES is a constant that makes the PCI testing
difficult as it points to an absolute path. We remove using this
constant and introducing a function pci_get_sysfs_path that gives
the same value. However, the user can pass a SYSFS_PCI_DEVICES env
variable to override the path. It is
The current test_pci is just a single test case that tests the
blacklisting of devices. Rename it to test_pci_blacklist and call it
from the test_pci. The setup and cleanup are moved out of the
test_pci_blacklist entirely to cover all other tests.
Signed-off-by: Jan Viktorin
---
v4
* the
Signed-off-by: Jan Viktorin
---
app/test/test_pci.c | 47 ++-
1 file changed, 34 insertions(+), 13 deletions(-)
diff --git a/app/test/test_pci.c b/app/test/test_pci.c
index 8b7c8bb..50078a0 100644
--- a/app/test/test_pci.c
+++ b/app/test/test_pci.c
@@
The test unregisters all drivers before start. The drivers were stored
into a fixed-sized array. This is inflexible. This patch change this to
utilize a linked list for the same purpose.
Signed-off-by: Jan Viktorin
---
v3:
* fixed commit message
* used "backup" to describe the
When a more complex resource (a file hierarchy) is needed, packing
every single file as a single resource would be very ineffective. For
that purpose, it is possible to pack the files into a tar archive,
extract it before test from the resource and finally clean up all the
created files.
This
101 - 200 of 231 matches
Mail list logo
