[dpdk-dev] [PATCH v5 5/5] app/pdump: fix type casting of ring size

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Reshma Pattan > Sent: Friday, June 24, 2016 5:36 PM > To: dev at dpdk.org > Cc: Pattan, Reshma > Subject: [dpdk-dev] [PATCH v5 5/5] app/pdump: fix type casting of ring > size > > ring_size value is wrongly

[dpdk-dev] [PATCH v5 4/5] app/pdump: fix string overflow

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Reshma Pattan > Sent: Friday, June 24, 2016 5:36 PM > To: dev at dpdk.org > Cc: Pattan, Reshma > Subject: [dpdk-dev] [PATCH v5 4/5] app/pdump: fix string overflow > > replaced strncpy with snprintf for safely

[dpdk-dev] [PATCH v5 3/5] pdump: fix string overflow

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Reshma Pattan > Sent: Friday, June 24, 2016 5:36 PM > To: dev at dpdk.org > Cc: Pattan, Reshma > Subject: [dpdk-dev] [PATCH v5 3/5] pdump: fix string overflow > > replaced strncpy with snprintf for safely

[dpdk-dev] [PATCH v5 2/5] pdump: check getenv return value

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Reshma Pattan > Sent: Friday, June 24, 2016 5:36 PM > To: dev at dpdk.org > Cc: Pattan, Reshma > Subject: [dpdk-dev] [PATCH v5 2/5] pdump: check getenv return value > > inside pdump_get_socket_path(), getenv

[dpdk-dev] [PATCH v5 1/5] pdump: fix default socket path

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Reshma Pattan > Sent: Friday, June 24, 2016 5:36 PM > To: dev at dpdk.org > Cc: Pattan, Reshma > Subject: [dpdk-dev] [PATCH v5 1/5] pdump: fix default socket path > > SOCKET_PATH_HOME is to specify

[dpdk-dev] [PATCH 2/4] enic: set the max allowed MTU for the NIC

Hi Bruce, > > * What was the MTU set to by default before this patch is applied? Was > > it just set to 1518 or something else? > > * What happens, if anything, if buffers bigger than the MTU size are sent > down? > This is obviously referring to buffers bigger than MTU on TX. There is also >

[dpdk-dev] [PATCH v2] mempool: replace c memcpy code semantics with optimized rte_memcpy

On 06/17/2016 12:40 PM, Olivier Matz wrote: > Hi Jerin, > > On 06/03/2016 09:02 AM, Jerin Jacob wrote: >> On Thu, Jun 02, 2016 at 11:16:16PM +0200, Olivier MATZ wrote: >> Hi Olivier, >> >>> This is probably more a measure of the pure CPU cost of the mempool >>> function, without considering the

[dpdk-dev] [PATCH] mbuf: replace c memcpy code semantics with optimized rte_memcpy

Hi Dave, On 06/24/2016 05:56 PM, Hunt, David wrote: > Hi Jerin, > > I just ran a couple of tests on this patch on the latest master head on > a couple of machines. An older quad socket E5-4650 and a quad socket > E5-2699 v3 > > E5-4650: > I'm seeing a gain of 2% for un-cached tests and a gain

[dpdk-dev] librte_meter compilation fails on IBM Power8

I can repeat this problem by "export EXTRA_CFLAGS="-O0 -g"" on Power8. But I'm not sure why this happens. The "-O3 -g" option works properly. I'll investigate more. -Original Message- From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] Sent: 2016?6?24? 1:26 To: N?lio

[dpdk-dev] [PATCH] cryptodev: uninline parameter parsing

There is no need to have this parsing inlined in the header. It brings kvargs dependency to every crypto drivers. The functions are moved into rte_cryptodev.c. Signed-off-by: Thomas Monjalon --- lib/librte_cryptodev/rte_cryptodev.c | 91 ++

[dpdk-dev] [PATCH] pci:don't insert an unbound device to pci_device_list in pci_scan_one

If a device isn't bound by any uio driver (vfio-pci, igb_uio, uio_pci_generic) and is expected to owned by a kernel space driver, here it's still inserted to pci_device_list. This may cause application based on dpdk fetch the device by accident and then the device is hanlded by dpdk. For safe,

[dpdk-dev] [PATCH] vmxnet3: remove 0x prefix for %p format

On Thu, Jun 23, 2016 at 01:45:43PM -0700, Yong Wang wrote: > > On Jun 23, 2016, at 3:52 AM, Ferruh Yigit wrote: > > > > To prevent double 0x in logs The commit message would be better as the title and vice versa, I think. > > > > Signed-off-by: Ferruh Yigit > > ? > > Acked-by: Yong Wang >

[dpdk-dev] [PATCH] nfp: modifying guide about using uio modules

On Fri, Jun 24, 2016 at 02:37:41PM +0100, Mcnamara, John wrote: > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Alejandro Lucero > > Sent: Tuesday, April 26, 2016 12:37 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH] nfp: modifying guide about

[dpdk-dev] [PATCH v5 5/5] app/pdump: fix type casting of ring size

ring_size value is wrongly type casted to uint16_t. It should be type casted to uint32_t, as maximum ring size is 28bit long. Wrong type cast wrapping around the ring size values bigger than 65535. Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing") Signed-off-by: Reshma Pattan ---

[dpdk-dev] [PATCH v5 4/5] app/pdump: fix string overflow

replaced strncpy with snprintf for safely copying the strings. Coverity issue 127351: string overflow Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing") Signed-off-by: Reshma Pattan --- app/pdump/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[dpdk-dev] [PATCH v5 3/5] pdump: fix string overflow

replaced strncpy with snprintf for safely copying the strings. Cverity issue 127350: string overflow Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Reshma Pattan --- lib/librte_pdump/rte_pdump.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[dpdk-dev] [PATCH v5 2/5] pdump: check getenv return value

inside pdump_get_socket_path(), getenv can return a NULL pointer if the match for SOCKET_PATH_HOME is not found in the environment. NULL check is added to return -1 immediately. Since pdump_get_socket_path() returns -1 now, wherever this function is called there the return value is checked and

[dpdk-dev] [PATCH v5 1/5] pdump: fix default socket path

SOCKET_PATH_HOME is to specify environment variable "HOME", so it should not contain "/pdump_sockets" in the macro. So removed "/pdump_sockets" from SOCKET_PATH_HOME and SOCKET_PATH_VAR_RUN. New changes will create pdump sockets under /var/run/.dpdk/pdump_sockets for root users and under

[dpdk-dev] [PATCH v5 0/5] fix issues in packet capture framework

This patchset includes listed fixes 1)fix default socket path in pdump library. 2)fix coverity issues in pdump library. 3)fix coverity issues in pdump tool. 4)fix wrong typecast of ring size in pdump tool. v5: changes are done to default socket paths now default socket path will be

[dpdk-dev] [PATCH v4] ixgbe: configure VLAN TPID

On Thu, Jun 23, 2016 at 11:11:58PM +0800, Beilei Xing wrote: > Previously, a single VLAN header is treated as inner VLAN, > but generally, a single VLAN header is treated as the outer > VLAN header. > The patch fixes the ether type of a single VLAN type, and > enables configuring inner and outer

[dpdk-dev] [PATCH v2] mk: fix parallel build of test resources

|...] > > OK alright :) > > Acked-by: Olivier Matz Applied

[dpdk-dev] [PATCH] mbuf: replace c memcpy code semantics with optimized rte_memcpy

Hi Jerin, I just ran a couple of tests on this patch on the latest master head on a couple of machines. An older quad socket E5-4650 and a quad socket E5-2699 v3 E5-4650: I'm seeing a gain of 2% for un-cached tests and a gain of 9% on the cached tests. E5-2699 v3: I'm seeing a loss of 0.1%

[dpdk-dev] [PATCH v4 1/5] pdump: fix default socket path

2016-06-24 14:54, Reshma Pattan: > +#define SOCKET_DIR "/pdump_sockets" I think the default socket directory should contain dpdk as prefix. Like dpdk-pdump-sockets (I think dash is preferred for filenames). I wonder whether it should be a hidden directory: ~/.dpdk-pdump-sockets And

[dpdk-dev] [PATCH v4 1/5] pdump: fix default socket path

> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, June 24, 2016 3:55 PM > To: Pattan, Reshma > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 1/5] pdump: fix default socket path > > 2016-06-24 14:54, Reshma Pattan: > > +#define

[dpdk-dev] [PATCH v12 2/2] i40e: add floating VEB support in i40e

This patch add the support for floating VEB in i40e. All the VFs VSIs can decide whether to connect to the legacy VEB/VEPA or the floating VEB. When connect to the floating VEB a new floating VEB is created. Now all the VFs need to connect to floating VEB or legacy VEB, cannot connect to both of

[dpdk-dev] [PATCH v12 1/2] i40e: support floating VEB config

Add the new floating VEB related arguments option in the devarg. Using this parameter, all the applications can decide whether to use legacy VEB/VEPA or floating VEB. To enable this feature, the user should pass a devargs parameter to the EAL like "-w 84:00.0,enable_floating_veb=1", and the

[dpdk-dev] [PATCH v12 0/2] i40e: add floating VEB support for i40e

This patch-set add the support for floating VEB in i40e. All the VFs VSIs can decide whether to connect to the legacy VEB/VEPA or the floating VEB. When connect to the floating VEB a new floating VEB is created. Now all the VFs need to connect to floating VEB or legacy VEB, cannot connect to both

[dpdk-dev] [PATCH v2] mk: fix parallel build of test resources

On 06/24/2016 04:19 PM, Thomas Monjalon wrote: > 2016-06-24 16:06, Olivier Matz: >> Hi Thomas, >> >> On 06/24/2016 01:22 PM, Thomas Monjalon wrote: >>> --- a/app/test/Makefile >>> +++ b/app/test/Makefile >>> @@ -43,14 +43,14 @@ define linked_resource >>> SRCS-y += $(1).res.o >>> $(1).res.o:

[dpdk-dev] [PATCH v2] mk: fix parallel build of test resources

2016-06-24 16:06, Olivier Matz: > Hi Thomas, > > On 06/24/2016 01:22 PM, Thomas Monjalon wrote: > > --- a/app/test/Makefile > > +++ b/app/test/Makefile > > @@ -43,14 +43,14 @@ define linked_resource > > SRCS-y += $(1).res.o > > $(1).res.o: $(2) > > @ echo ' MKRES $$@' > > - $Q ln -fs

[dpdk-dev] [PATCH v3] rte_hash: add scalable multi-writer insertion w/ Intel TSX

> > This patch introduced scalable multi-writer Cuckoo Hash insertion > > based on a split Cuckoo Search and Move operation using Intel > > TSX. It can do scalable hash insertion with 22 cores with little > > performance loss and negligible TSX abortion rate. > > > > * Added an extra rte_hash

[dpdk-dev] [PATCH v2] mk: fix parallel build of test resources

Hi Thomas, On 06/24/2016 01:22 PM, Thomas Monjalon wrote: > --- a/app/test/Makefile > +++ b/app/test/Makefile > @@ -43,14 +43,14 @@ define linked_resource > SRCS-y += $(1).res.o > $(1).res.o: $(2) > @ echo ' MKRES $$@' > - $Q ln -fs $$< resource.tmp > + $Q [ "$$(

[dpdk-dev] [PATCH v2] doc: virtio pmd versions

> -Original Message- > From: Wang, Zhihong > Sent: Wednesday, June 15, 2016 12:53 AM > To: dev at dpdk.org > Cc: Richardson, Bruce ; Mcnamara, John > ; Wang, Zhihong > Subject: [PATCH v2] doc: virtio pmd versions > > This patch explains all the versions of current virtio pmd

[dpdk-dev] [PATCH v2 12/16] vfio: fix typo in doc for vfio_setup_device

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jan Viktorin > Sent: Monday, June 13, 2016 2:02 PM > To: dev at dpdk.org > Cc: Jan Viktorin ; Burakov, Anatoly > ; David Marchand ; > Wiles, Keith ; Santosh Shukla mvista.com>; > Stephen Hemminger ; Shreyansh

[dpdk-dev] [PATCH] doc: update vhost guide

Mainly on updating vhost-user part: we now support client mode. Also refine some words, and add a bit more explanation. And made an emphatic statement that you are suggested to use vhost-user instead of vhost-cuse, because we have enhanced vhost-user a lot since v2.2 (Actually, I doubt there are

[dpdk-dev] [RFC] librte_vhost: Add unix domain socket fd registration

On Fri, Jun 24, 2016 at 07:43:29AM +, Loftus, Ciara wrote: > > > > On Tue, Jun 21, 2016 at 09:15:03AM -0400, Aaron Conole wrote: > > > Yuanhan Liu writes: > > > > > > > On Fri, Jun 17, 2016 at 11:32:36AM -0400, Aaron Conole wrote: > > > >> Prior to this commit, the only way to add a

[dpdk-dev] [PATCH] examples/l3fwd: update documentation

> -Original Message- > From: Xing, Beilei > Sent: Thursday, June 23, 2016 10:05 AM > To: Mcnamara, John > Cc: dev at dpdk.org; Xing, Beilei > Subject: [PATCH] examples/l3fwd: update documentation > > Update l3fwd documentation with -E, -L and --eth-dest options. > Hi, Thanks for the

[dpdk-dev] [PATCH] enic: fix issues when using Rx scatter with multiple RQs

The Rx scatter patch failed to make a few changes and resulted in problems when using multiple RQs since the wrong RQ or CQ was being used. Fixes: 14a261bf0520 ("enic: add scattered Rx support") Signed-off-by: Nelson Escobar Reviewed-by: John Daley --- drivers/net/enic/enic.h | 2 +-

[dpdk-dev] [PATCH v2 2/2] enic: add an update MTU function for non-Rx scatter mode

Provide an update MTU callback. The function returns -ENOTSUP if Rx scatter is enabled. Updating the MTU to be greater than the value configured via the Cisco CIMC/UCSM management interface is allowed provided it is still less than the maximum egress packet size allowed by the NIC minus the size

[dpdk-dev] [PATCH v2 1/2] enic: determine max egress packet size and max MTU

Pull in common VNIC code which enables querying for max egress packet size with newer firmware via a device command. If the field is non-zero, it is the max egress packet size. If it is 0, the default value (9022) can safely be assumed. The value for 1300 series VICS using firmware versions >=

[dpdk-dev] [PATCH v7 25/25] mlx5: resurrect Rx scatter support

This commit brings back Rx scatter and related support by the MTU update function. The maximum number of segments per packet is not a fixed value anymore (previously MLX5_PMD_SGE_WR_N, set to 4 by default) as it caused performance issues when fewer segments were actually needed as well as

[dpdk-dev] [PATCH v7 24/25] mlx5: make Rx queue reinitialization safer

From: Adrien Mazarguil The primary purpose of rxq_rehash() function is to stop and restart reception on a queue after re-posting buffers. This may fail if the array that temporarily stores existing buffers for reuse cannot be allocated. Update rxq_rehash() to work on

[dpdk-dev] [PATCH v7 22/25] mlx5: work around spurious compilation errors

From: Adrien Mazarguil Since commit "mlx5: resurrect Tx gather support", older GCC versions (such as 4.8.5) may complain about the following: mlx5_rxtx.c: In function `mlx5_tx_burst': mlx5_rxtx.c:705:25: error: `wqe' may be used uninitialized in this function

[dpdk-dev] [PATCH v7 21/25] mlx5: resurrect Tx gather support

From: Adrien Mazarguil Compared to its previous incarnation, the software limit on the number of mbuf segments is no more (previously MLX5_PMD_SGE_WR_N, set to 4 by default) hence no need for linearization code and related buffers that permanently consumed a non

[dpdk-dev] [PATCH v7 20/25] mlx5: check remaining space while processing Tx burst

From: Adrien Mazarguil The space necessary to store segmented packets cannot be known in advance and must be verified for each of them. Signed-off-by: Adrien Mazarguil Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx.c | 144

[dpdk-dev] [PATCH v7 19/25] mlx5: add debugging information about Tx queues capabilities

From: Adrien Mazarguil Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_txq.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c index 4f17fb0..bae9f3d 100644 --- a/drivers/net/mlx5/mlx5_txq.c

[dpdk-dev] [PATCH v7 18/25] mlx5: add support for multi-packet send

This feature enables the TX burst function to emit up to 5 packets using only two WQEs on devices that support it. Saves PCI bandwidth and improves performance. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil Signed-off-by: Olga Shern --- doc/guides/nics/mlx5.rst | 10 +

[dpdk-dev] [PATCH v7 17/25] mlx5: add support for inline send

From: Yaacov Hazan Implement send inline feature which copies packet data directly into WQEs for improved latency. The maximum packet size and the minimum number of Tx queues to qualify for inline send are user-configurable. This feature is effective when HW causes a

[dpdk-dev] [PATCH v7 16/25] mlx5: replace countdown with threshold for Tx completions

From: Adrien Mazarguil Replacing the variable countdown (which depends on the number of descriptors) with a fixed relative threshold known at compile time improves performance by reducing the TX queue structure footprint and the amount of code to manage completions

[dpdk-dev] [PATCH v7 15/25] mlx5: handle Rx CQE compression

Mini (compressed) CQEs are returned by the NIC when PCI back pressure is detected, in which case the first CQE64 contains common packet information followed by a number of CQE8 providing the rest, followed by a matching number of empty CQE64 entries to be used by software for decompression.

[dpdk-dev] [PATCH v7 14/25] mlx5: refactor Tx data path

Bypass Verbs to improve Tx performance. Signed-off-by: Nelio Laranjeiro Signed-off-by: Yaacov Hazan Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/Makefile | 5 - drivers/net/mlx5/mlx5_ethdev.c | 10 +- drivers/net/mlx5/mlx5_mr.c | 4 +- drivers/net/mlx5/mlx5_rxtx.c |

[dpdk-dev] [PATCH v7 13/25] mlx5: refactor Rx data path

Bypass Verbs to improve RX performance. Signed-off-by: Nelio Laranjeiro Signed-off-by: Yaacov Hazan Signed-off-by: Adrien Mazarguil Signed-off-by: Vasily Philipov --- drivers/net/mlx5/mlx5_ethdev.c | 4 +- drivers/net/mlx5/mlx5_fdir.c | 2 +- drivers/net/mlx5/mlx5_rxq.c| 303

[dpdk-dev] [PATCH v7 12/25] mlx5: add Tx/Rx burst function selection wrapper

These wrappers are meant to prevent code duplication later. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.h| 2 ++ drivers/net/mlx5/mlx5_ethdev.c | 34 -- drivers/net/mlx5/mlx5_txq.c| 2 +- 3 files

[dpdk-dev] [PATCH v7 11/25] mlx5: add support for configuration through kvargs

The intent is to replace the remaining compile-time options and environment variables with a common mean of runtime configuration. This commit only adds the kvargs handling code, subsequent commits will update the rest. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil ---

[dpdk-dev] [PATCH v7 10/25] mlx5: add definitions for data path without Verbs

These structures and macros extend those exposed by libmlx5 (in mlx5_hw.h) to let the PMD manage work queue and completion queue elements directly. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_prm.h | 163

[dpdk-dev] [PATCH v7 09/25] mlx5: update prerequisites for upcoming enhancements

The latest version of Mellanox OFED exposes hardware definitions necessary to implement data path operation bypassing Verbs. Update the minimum version requirement to MLNX_OFED >= 3.3 and clean up compatibility checks for previous releases. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien

[dpdk-dev] [PATCH v7 08/25] mlx5: split Rx queue structure

To keep the data path as efficient as possible, move fields only useful to the control path into new structure rxq_ctrl. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c | 6 +- drivers/net/mlx5/mlx5_fdir.c | 8 +- drivers/net/mlx5/mlx5_rxq.c

[dpdk-dev] [PATCH v7 07/25] mlx5: split Tx queue structure

To keep the data path as efficient as possible, move fields only useful to the control path into new structure txq_ctrl. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c| 21 +++-- drivers/net/mlx5/mlx5_ethdev.c | 28 +++---

[dpdk-dev] [PATCH v7 06/25] mlx5: remove inline Tx support

Inline TX will be fully managed by the PMD after Verbs is bypassed in the data path. Remove the current code until then. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- config/common_base | 1 - doc/guides/nics/mlx5.rst | 10 -- drivers/net/mlx5/Makefile

[dpdk-dev] [PATCH v7 05/25] mlx5: remove configuration variable

There is no scatter/gather support anymore, CONFIG_RTE_LIBRTE_MLX5_SGE_WR_N has no purpose and can be removed. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- config/common_base | 1 - doc/guides/nics/mlx5.rst | 7 --- drivers/net/mlx5/Makefile| 4

[dpdk-dev] [PATCH v7 04/25] mlx5: remove Rx scatter support

This is done in preparation of bypassing Verbs entirely for the data path as a performance improvement. RX scatter cannot be maintained during the transition and will be reimplemented later. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_ethdev.c |

[dpdk-dev] [PATCH v7 03/25] mlx5: remove Tx gather support

This is done in preparation of bypassing Verbs entirely for the data path as a performance improvement. TX gather cannot be maintained during the transition and will be reimplemented later. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_ethdev.c | 2

[dpdk-dev] [PATCH v7 02/25] mlx5: split memory registration function

Except for the first time when memory registration occurs, the lkey is always cached. Since memory registration is slow and performs system calls, performance can be improved by moving that code to its own function outside of the data path so only the lookup code is left in the original inlined

[dpdk-dev] [PATCH v7 01/25] drivers: fix PCI class id support

Fixes: 701c8d80c820 ("pci: support class id probing") Signed-off-by: Nelio Laranjeiro --- drivers/crypto/qat/rte_qat_cryptodev.c | 5 + drivers/net/mlx4/mlx4.c| 18 ++ drivers/net/mlx5/mlx5.c| 24

[dpdk-dev] [PATCH v7 00/25] Refactor mlx5 to improve performance

Enhance mlx5 with a data path that bypasses Verbs. The first half of this patchset removes support for functionality completely rewritten in the second half (scatter/gather, inline send), while the data path is refactored without Verbs. The PMD remains usable during the transition. This

[dpdk-dev] [PATCH v16 0/3] mempool: add mempool handler feature

On Fri, 24 Jun 2016 13:24:56 +0200 Thomas Monjalon wrote: > 2016-06-24 13:20, Jan Viktorin: > > thanks for the patchset. I am sorry, I didn't have any time for DPDK this > > week > > and didn't test it before applying. The current master produces the > > following > > error in my regular

[dpdk-dev] [PATCH v4 1/5] pdump: fix default socket path

> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, June 24, 2016 3:55 PM > To: Pattan, Reshma > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 1/5] pdump: fix default socket path > > 2016-06-24 14:54, Reshma Pattan: > > +#define

[dpdk-dev] [PATCH v6 00/25] Refactor mlx5 to improve performance

Sorry about this, it will need a v7, a bug was introduced in the previous version to fix a checkpatch warning. kvargs were no more interpreted. I will resend a v7 after verifying everything. Regards, -- N?lio Laranjeiro 6WIND

[dpdk-dev] [PATCH v4 5/5] app/pdump: fix type casting of ring size

ring_size value is wrongly type casted to uint16_t. It should be type casted to uint32_t, as maximum ring size is 28bit long. Wrong type cast wrapping around the ring size values bigger than 65535. Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing") Signed-off-by: Reshma Pattan ---

[dpdk-dev] [PATCH v4 4/5] app/pdump: fix string overflow

replaced strncpy with snprintf for safely copying the strings. Coverity issue 127351: string overflow Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing") Signed-off-by: Reshma Pattan --- app/pdump/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[dpdk-dev] [PATCH v4 3/5] pdump: fix string overflow

replaced strncpy with snprintf for safely copying the strings. Cverity issue 127350: string overflow Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Reshma Pattan --- lib/librte_pdump/rte_pdump.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[dpdk-dev] [PATCH v4 2/5] pdump: check getenv return value

inside pdump_get_socket_path(), getenv can return a NULL pointer if the match for SOCKET_PATH_HOME is not found in the environment. NULL check is added to return -1 immediately. Since pdump_get_socket_path() returns -1 now, wherever this function is called there the return value is checked and

[dpdk-dev] [PATCH v4 1/5] pdump: fix default socket path

SOCKET_PATH_HOME is to specify environment variable "HOME", so it should not contain "/pdump_sockets" in the macro. So remove "/pdump_sockets" from SOCKET_PATH_HOME and create new macro for "/pdump_sockets". Similary removed "/pdump_sockets" from SOCKET_PATH_VAR_RUN. Changes are done in

[dpdk-dev] [PATCH v4 0/5] fix issues in packet capture framework

This patchset includes listed fixes 1)fix default socket path in pdump library. 2)fix coverity issues in pdump library. 3)fix coverity issues in pdump tool. 4)fix wrong typecast of ring size in pdump tool. v4: added new patch for fixing wrong typecast of ring size in pdump tool. v3: added new

[dpdk-dev] [PATCH] app/test: fix PCI class probing

The PCI test was failing because some fake devices had no PCI class. Fixes: 1dbba1650c89 ("app/test: remove real PCI ids") Signed-off-by: Thomas Monjalon --- app/test/test_pci_sysfs/bus/pci/devices/:01:02.0/class | 1 + app/test/test_pci_sysfs/bus/pci/devices/:02:ab.0/class | 1 + 2

[dpdk-dev] [PATCH] nfp: modifying guide about using uio modules

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Alejandro Lucero > Sent: Tuesday, April 26, 2016 12:37 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] nfp: modifying guide about using uio modules > > - Removing dependency on nfp_uio kernel module.

[dpdk-dev] [PATCH] bnxt: Add Cumulus+ PCI ID

On Fri, Jun 24, 2016 at 6:59 AM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Tue, Jun 21, 2016 at 04:58:20PM -0500, Ajit Khaparde wrote: > > This patch adds support for Cumulus+ Ethernet adapters. > > These Cumulus+ Ethernet adapters support 10Gb/25Gb/40Gb/50Gb speeds. > > > >

[dpdk-dev] [PATCH v16 0/3] mempool: add mempool handler feature

2016-06-24 13:20, Jan Viktorin: > thanks for the patchset. I am sorry, I didn't have any time for DPDK this week > and didn't test it before applying. The current master produces the following > error in my regular builds: > > INSTALL-LIB librte_eal.a > == Build lib/librte_ring > CC

[dpdk-dev] [PATCH v2] mk: fix parallel build of test resources

The build was failing sometimes when building with multiple parallel jobs: # rm build/build/app/test/*res* # make -j6 objcopy: 'resource.tmp': No such file The reason is that each resource was built from the same temporary file. The failure is seen because of a race condition when

[dpdk-dev] [PATCH v16 0/3] mempool: add mempool handler feature

On Fri, 24 Jun 2016 04:55:39 + "Wiles, Keith" wrote: > On 6/23/16, 11:22 PM, "dev on behalf of Thomas Monjalon" dpdk.org on behalf of thomas.monjalon at 6wind.com> wrote: > > >> David Hunt (2): > >> mempool: support mempool handler operations > >> app/test: test mempool handler > >>

[dpdk-dev] [PATCH v3] i40e: fix the type issue of a single VLAN type

On Wed, Jun 22, 2016 at 10:53:51AM +0800, Beilei Xing wrote: > In current i40e codebase, if single VLAN header is added in a packet, > it's treated as inner VLAN. Generally, a single VLAN header is > treated as the outer VLAN header. So change corresponding register > for single VLAN. > > Fixes:

[dpdk-dev] [PATCH] bnxt: Add Cumulus+ PCI ID

On Tue, Jun 21, 2016 at 04:58:20PM -0500, Ajit Khaparde wrote: > This patch adds support for Cumulus+ Ethernet adapters. > These Cumulus+ Ethernet adapters support 10Gb/25Gb/40Gb/50Gb speeds. > > Signed-off-by: Ajit Khaparde Applied to dpdk-next-net/rel_16_07 /Bruce

[dpdk-dev] [PATCH v2 0/6] ena: update PMD to cooperate with latest ENA firmware

On Tue, Jun 21, 2016 at 02:05:57PM +0200, Jan Medala wrote: > As requested, big patch splitted into logical pieces for easier review. > Improved style and fixed icc compiler issues. > Thanks for the patch split. However, many of the patches don't have a commit message describing (at a high

[dpdk-dev] [PATCH v2] enic: negative array index write

On Mon, Jun 20, 2016 at 12:27:46PM -0700, John Daley wrote: > Negative array index write using variable pos as an index to array > enic->fdir.nodes. Fixed by add array index check. > > Fixes: fefed3d1e62c ("enic: new driver") Coverity ID 13270 > Signed-off-by: John Daley > --- > Applied to

[dpdk-dev] [PATCH] scripts: add verbose option in build test help

The verbose option was available but not advertised. Fixes: 6e38dfe21389 ("scripts: add verbose test build option") Signed-off-by: Thomas Monjalon --- scripts/test-build.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/test-build.sh b/scripts/test-build.sh index 31d5583..7a9f623

[dpdk-dev] [PATCH v12 1/2] i40e: support floating VEB config

Hi Zhe, On 6/24/2016 9:29 AM, Zhe Tao wrote: > Add the new floating VEB related arguments option in the devarg. > Using this parameter, all the applications can decide whether to use legacy > VEB/VEPA or floating VEB. > To enable this feature, the user should pass a devargs parameter to the > EAL

[dpdk-dev] [PATCH] vhost: fix Tx error counting of vhost PMD

On 2016/06/24 11:17, Yuanhan Liu wrote: > On Fri, Jun 24, 2016 at 11:04:20AM +0900, Tetsuya Mukawa wrote: >> According to 'rte_eth_stats' structure comments, 'imissed' >> should represent RX error counting, but currently 'imissed' is >> used to count TX error. >> The patch replaces 'imissed' by

[dpdk-dev] backtracing from within the code

2016-06-24 09:25, Dumitrescu, Cristian: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Catalin Vasile > > I'm trying to add a feature to DPDK and I'm having a hard time printing a > > backtrace. > > I tried using this[1] functions for printing, but it does not print more > > than one >

[dpdk-dev] [PATCH] ixgbe: use rte_mbuf_prefetch_part2 for cacheline1 access

On Mon, Jun 20, 2016 at 11:19:19AM +0800, Jianbo Liu wrote: > On 17 June 2016 at 22:06, Jerin Jacob > wrote: > > made second cache line access behavior same as IA > > > > Signed-off-by: Jerin Jacob > > --- > > drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 8 > > 1 file changed, 4

[dpdk-dev] [PATCH 4/4] doc: add MTU update to feature matrix for enic

On Thu, Jun 16, 2016 at 10:22:49PM -0700, John Daley wrote: > Signed-off-by: John Daley > --- This patch should be squashed into the previous one. /Bruce

[dpdk-dev] [PATCH 2/4] enic: set the max allowed MTU for the NIC

On Fri, Jun 24, 2016 at 11:59:19AM +0100, Bruce Richardson wrote: > On Thu, Jun 16, 2016 at 10:22:47PM -0700, John Daley wrote: > > The max MTU is set to the max egress packet size allowed by the VIC > > minus the size of a an IPv4 L2 header with .1Q (18 bytes). > > > > I think a bit more detail

[dpdk-dev] [PATCH 2/4] enic: set the max allowed MTU for the NIC

On Thu, Jun 16, 2016 at 10:22:47PM -0700, John Daley wrote: > The max MTU is set to the max egress packet size allowed by the VIC > minus the size of a an IPv4 L2 header with .1Q (18 bytes). > I think a bit more detail might be needed here. For example: * What was the MTU set to by default

[dpdk-dev] [PATCH 1/4] enic: enable NIC max packet size discovery

On Thu, Jun 16, 2016 at 10:22:46PM -0700, John Daley wrote: > Pull in common VNIC code which enables querying for max egress > packet size. > With this patch applied is the user able to query the max packet size, or is it just that the driver is able to do so for use by other functions? /Bruce

[dpdk-dev] [PATCH] bnx2x: Don't reset buf_len in RX mbufs

On Fri, Jun 17, 2016 at 06:32:06AM +, Harish Patil wrote: > > > >Fixes: 540a211084a7 ("bnx2x: driver core") > > > >Signed-off-by: Chas Williams <3chas3 at gmail.com> > >--- > > drivers/net/bnx2x/bnx2x_rxtx.c | 1 - > > 1 file changed, 1 deletion(-) > > > >diff --git

[dpdk-dev] [PATCH v2] enic: scattered Rx

On Thu, Jun 16, 2016 at 12:19:05PM -0700, Nelson Escobar wrote: > For performance reasons, this patch uses 2 VIC RQs per RQ presented to > DPDK. > > The VIC requires that each descriptor be marked as either a start of > packet (SOP) descriptor or a non-SOP descriptor. A one RQ solution >

[dpdk-dev] NIC support for HPE Ethernet 10Gb 2-port 560FLR-SFP+ Adapter

Hi, One of my customers intends to buy HPE Ethernet 10Gb 2-port 560FLR-SFP+ Adapter (http://www8.hp.com/h20195/v2/getpdf.aspx/c04111435.pdf?ver=8) for running a DPDK based app. I have never tested my app with the above NIC (always used X520 to test my app) If someone has already tried with this

[dpdk-dev] [PATCH] vhost: fix Tx error counting of vhost PMD

According to 'rte_eth_stats' structure comments, 'imissed' should represent RX error counting, but currently 'imissed' is used to count TX error. The patch replaces 'imissed' by 'oerrors'. Fixes: ee584e9710b9 ("vhost: add driver on top of the library") Signed-off-by: Tetsuya Mukawa ---

[dpdk-dev] [PATCH v4] e1000: configure VLAN TPID

On Thu, Jun 16, 2016 at 01:59:46PM +, Zhang, Helin wrote: > > > > -Original Message- > > From: Xing, Beilei > > Sent: Thursday, June 16, 2016 9:36 PM > > To: Zhang, Helin > > Cc: dev at dpdk.org; Xing, Beilei > > Subject: [PATCH v4] e1000: configure VLAN TPID > > > > This patch

[dpdk-dev] [PATCH v6 25/25] mlx5: resurrect Rx scatter support

This commit brings back Rx scatter and related support by the MTU update function. The maximum number of segments per packet is not a fixed value anymore (previously MLX5_PMD_SGE_WR_N, set to 4 by default) as it caused performance issues when fewer segments were actually needed as well as

[dpdk-dev] [PATCH v6 24/25] mlx5: make Rx queue reinitialization safer

From: Adrien Mazarguil The primary purpose of rxq_rehash() function is to stop and restart reception on a queue after re-posting buffers. This may fail if the array that temporarily stores existing buffers for reuse cannot be allocated. Update rxq_rehash() to work on

[dpdk-dev] [PATCH v6 23/25] mlx5: remove redundant Rx queue initialization code

From: Adrien Mazarguil Toggling RX checksum offloads is already done at initialization time. This code does not belong in rxq_rehash(). Signed-off-by: Adrien Mazarguil Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxq.c | 11 --- 1 file

  1   2   >