[dpdk-dev] [PATCH] app/test: increase memory allocated for greedy autotests

2016-07-19 Thread Thomas Monjalon
The autotest lists, requirements and distribution needs a big rework to reduce the amount of cores and memory required. The root cause is not addressed yet. This patch just increase some memory allocation for some greedy tests which often fail because of memory fragmentation: LPM6 and reentrancy

[dpdk-dev] [PATCH] app/test: disable filtering with stripped binary

2016-07-19 Thread Thomas Monjalon
The unavailable tests are filtered out by autotest by looking for the symbols in the binary: PCI autotest: Skipped [Not Available] [00m 00s] Malloc autotest: Success [00m 00s] It results to skip everything if the binary has no symbol

[dpdk-dev] [PATCH] mempool: adjust name string size in related data types

2016-07-19 Thread Olivier Matz
Hi Zoltan, On 07/19/2016 05:59 PM, Zoltan Kiss wrote: > > > On 19/07/16 16:37, Olivier Matz wrote: >> Hi Zoltan, >> >> On 07/19/2016 04:37 PM, Zoltan Kiss wrote: >>> A recent fix brought up an issue about the size of the 'name' fields: >>> >>> 85cf0079 mem: avoid memzone/mempool/ring name

[dpdk-dev] using virtio driver in dpdk release 2.0

2016-07-19 Thread Shirley Avishour
Hi, We are using KVM for loading our VM using e1000 driver for the VM interface. we noticed that the maximum rate (rx/tx) I get is 10Mbps. I am currently attempting to move to virtio driver using dpdk release 2.0. >From the documentation it seems that I have to load my dpdk application with

[dpdk-dev] [PATCH] ixgbe: support checksum flags in sse vector Rx function

2016-07-19 Thread Olivier Matz
Hi Sugesh, On 07/14/2016 11:24 AM, Chandran, Sugesh wrote: > Hi Olivier, > Thank you for working on this. > We tried to enable checksum offload in OVS-DPDK and couldn't proceed due to > the performance impact. > I assume this patch will fix that issue by enabling checksum offloading with >

[dpdk-dev] [PATCH] mempool: adjust name string size in related data types

2016-07-19 Thread Olivier Matz
Hi Zoltan, On 07/19/2016 04:37 PM, Zoltan Kiss wrote: > A recent fix brought up an issue about the size of the 'name' fields: > > 85cf0079 mem: avoid memzone/mempool/ring name truncation > > These relations should be observed: > > RTE_RING_NAMESIZE <= RTE_MEMZONE_NAMESIZE -

[dpdk-dev] [PATCH] doc: announce ABI change for mbuf structure

2016-07-19 Thread Olivier Matz
On 07/19/2016 05:07 PM, Richardson, Bruce wrote: > > >> -Original Message- >> From: Olivier Matz [mailto:olivier.matz at 6wind.com] >> Sent: Tuesday, July 19, 2016 4:04 PM >> To: Richardson, Bruce >> Cc: dev at dpdk.org; jerin.jacob at caviumnetworks.com; >> thomas.monjalon at

[dpdk-dev] [PATCH] mempool: fix lack of free() registration

2016-07-19 Thread Olivier Matz
Hi Zoltan, I ran ./scripts/check-git-log.sh on your patch, showing some minor styling issues: On 07/19/2016 04:37 PM, Zoltan Kiss wrote: > [PATCH] mempool: fix lack of free() registration "()" should be removed > The new mempool handler interface forgets to register the free() function > of

[dpdk-dev] [PATCH] mempool: fix lack of free() registration

2016-07-19 Thread Zoltan Kiss
On 19/07/16 16:26, Olivier Matz wrote: > Hi Zoltan, > > I ran ./scripts/check-git-log.sh on your patch, showing some minor > styling issues: Thanks, do you want me to resend it, or could Thomas fix them upon commiting? > > On 07/19/2016 04:37 PM, Zoltan Kiss wrote: >> [PATCH] mempool: fix

[dpdk-dev] capture packets on VM

2016-07-19 Thread Raja Jayapal
Hi Reshma, Thanks for your information. I have been trying to run the testpmd app and would like to get some idea on the packet flow in testpmd. br0 -vnet0- (port0)VM NIC br1--vnet1--(port1)VM NIC br2--vnet2--(port2)VM NIC br0 IP and MAC: fe:54:00:0d:af:af -

[dpdk-dev] [PATCH] doc: announce ABI change for mbuf structure

2016-07-19 Thread Olivier Matz
Hi Bruce, On 07/19/2016 04:40 PM, Bruce Richardson wrote: > On Tue, Jul 19, 2016 at 04:01:15PM +0200, Olivier Matz wrote: >> For 16.11, the mbuf structure will be modified implying ABI breakage. >> Some discussions already took place here: >> http://www.dpdk.org/dev/patchwork/patch/12878/ >> >>

[dpdk-dev] [PATCH] mempool: adjust name string size in related data types

2016-07-19 Thread Zoltan Kiss
On 19/07/16 16:37, Olivier Matz wrote: > Hi Zoltan, > > On 07/19/2016 04:37 PM, Zoltan Kiss wrote: >> A recent fix brought up an issue about the size of the 'name' fields: >> >> 85cf0079 mem: avoid memzone/mempool/ring name truncation >> >> These relations should be observed: >> >>

[dpdk-dev] [dpdk-users] RSS Hash not working for XL710/X710 NICs for some RX mbuf sizes

2016-07-19 Thread Take Ceara
Hi Beilei, On Tue, Jul 19, 2016 at 11:31 AM, Xing, Beilei wrote: > Hi Ceara, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Take Ceara >> Sent: Tuesday, July 19, 2016 12:14 AM >> To: Zhang, Helin >> Cc: Wu, Jingjing ; dev at dpdk.org >> Subject: Re:

[dpdk-dev] [PATCH v4] doc: flow bifurcation guide on Linux

2016-07-19 Thread Mcnamara, John
> -Original Message- > From: Wu, Jingjing > Sent: Tuesday, July 19, 2016 4:31 AM > To: Mcnamara, John > Cc: dev at dpdk.org; Wu, Jingjing ; Liu, Yong > ; Zhang, Helin > Subject: [PATCH v4] doc: flow bifurcation guide on Linux > > Flow Bifurcation is a mechanism which uses features of

[dpdk-dev] [PATCH v3] mk: fix FreeBSD build

2016-07-19 Thread Christian Ehrhardt
Hi, the order changed, but IMHO actually it improved. Things are now at the place they were before, but with the overwriting config value that came later - that is the best of both worlds. Tested a few config runs pre/post patch and compared them sorted (equal) and unsorted - now configs slotted

[dpdk-dev] [PATCH] doc: fix vhost setup in tep-termination app guide

2016-07-19 Thread Mark Kavanagh
- Fix vhost setup flags - Add minor edits to improve readability and consistency Signed-off-by: Mark Kavanagh --- doc/guides/sample_app_ug/tep_termination.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) mode change 100644 => 100755 doc/guides/sample_app_ug/tep_termination.rst

[dpdk-dev] [PATCH v3 2/2] doc: add vhost_user live migration image

2016-07-19 Thread Mcnamara, John
> -Original Message- > From: Iremonger, Bernard > Sent: Monday, July 18, 2016 3:30 PM > To: Mcnamara, John ; dev at dpdk.org > Cc: Liu, Yong ; Xu, Qian Q ; > yuanhan.liu at linux.intel.com; Iremonger, Bernard > > Subject: [PATCH v3 2/2] doc: add vhost_user live migration image > > This

[dpdk-dev] [PATCH v3 1/2] doc: live migration of VM with vhost_user on host

2016-07-19 Thread Mcnamara, John
> -Original Message- > From: Iremonger, Bernard > Sent: Monday, July 18, 2016 3:30 PM > To: Mcnamara, John ; dev at dpdk.org > Cc: Liu, Yong ; Xu, Qian Q ; > yuanhan.liu at linux.intel.com; Iremonger, Bernard > > Subject: [PATCH v3 1/2] doc: live migration of VM with vhost_user on host

[dpdk-dev] [PATCH v5 2/2] doc: add live migration virtio sriov image

2016-07-19 Thread Mcnamara, John
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, July 19, 2016 4:09 PM > To: Mcnamara, John ; dev at dpdk.org > Cc: Liu, Yong ; Xu, Qian Q ; > yuanhan.liu at linux.intel.com; Iremonger, Bernard > > Subject: [PATCH v5 2/2] doc: add live migration virtio sriov image > >

[dpdk-dev] [PATCH v5 1/2] doc: live migration of VM with Virtio and VF

2016-07-19 Thread Mcnamara, John
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, July 19, 2016 4:09 PM > To: Mcnamara, John ; dev at dpdk.org > Cc: Liu, Yong ; Xu, Qian Q ; > yuanhan.liu at linux.intel.com; Iremonger, Bernard > > Subject: [PATCH v5 1/2] doc: live migration of VM with Virtio and VF > >

[dpdk-dev] [PATCH v5 2/2] doc: add live migration virtio sriov image

2016-07-19 Thread Bernard Iremonger
This patch adds an image of the Live Migration for virtio and sriov test configuration. Signed-off-by: Bernard Iremonger --- doc/guides/howto/img/lm_bond_virtio_sriov.svg | 666 ++ doc/guides/howto/lm_bond_virtio_sriov.rst | 4 + 2 files changed, 670 insertions(+)

[dpdk-dev] [PATCH v5 1/2] doc: live migration of VM with Virtio and VF

2016-07-19 Thread Bernard Iremonger
This patch describes the procedure to be be followed to perform Live Migration of a VM with Virtio and VF PMD's using the bonding PMD. It includes sample host and VM scripts used in the procedure, and a sample switch configuration. Signed-off-by: Bernard Iremonger ---

[dpdk-dev] [PATCH v5 0/2] doc: live migration procedure

2016-07-19 Thread Bernard Iremonger
This patch set describes the procedure to Live migrate a VM with Virtio and VF PMD's using the bonding PMD. Changes in v5: restore missing image file change Guide to Guides in heading Changes in v4: rename image file and patch added links to rst file updated rst file in line with comments

[dpdk-dev] [PATCH v3] mk: fix FreeBSD build

2016-07-19 Thread Ferruh Yigit
On 7/19/2016 3:30 PM, Christian Ehrhardt wrote: > Hi, > the order changed, but IMHO actually it improved. > Things are now at the place they were before, but with the overwriting > config value that came later - that is the best of both worlds. Agreed, this is a good solution. Also fixes multiple

[dpdk-dev] [PATCH] doc: announce ABI change for mbuf structure

2016-07-19 Thread Olivier Matz
For 16.11, the mbuf structure will be modified implying ABI breakage. Some discussions already took place here: http://www.dpdk.org/dev/patchwork/patch/12878/ Signed-off-by: Olivier Matz --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git

[dpdk-dev] [PATCH] virtio: fix packet corruption

2016-07-19 Thread Olivier Matz
Hi, On 07/19/2016 03:57 PM, Tan, Jianfeng wrote: > > >> -Original Message- >> From: Olivier Matz [mailto:olivier.matz at 6wind.com] >> Sent: Tuesday, July 19, 2016 9:11 PM >> To: Tan, Jianfeng; dev at dpdk.org; Xie, Huawei; yuanhan.liu at >> linux.intel.com >> Subject: Re: [PATCH]

[dpdk-dev] [PATCH v2] Memory leak when adding/removing vhost_user ports

2016-07-19 Thread Christian Ehrhardt
Hi, thanks for evaluating. I'll need a few days until I'm ready for OVS again and until OVS is ready for DPDK 16.07. Then I can run an adapted version of my old testcase to be sure. In the worst cases it will be in 16.11 and I'll backport to 16.07 as distributed. I'll let you know then.

[dpdk-dev] [PATCH] net/enic: heed VLAN strip flag in device configure function

2016-07-19 Thread John Daley
The configure function enicpmd_dev_configure() was not paying attention to the rxmode VLAN strip bit. Set the VLAN strip mode according to the bit. Fixes: fefed3d1e62c ("enic: new driver") Signed-off-by: John Daley --- Although not critical, it is low risk and would be nice to have in 16_07.

[dpdk-dev] [PATCH] net/enic: fix possible Rx corruption

2016-07-19 Thread John Daley
Initialize the mbuf data offset to RTE_PKTMBUF_HEADROOM as the enic takes ownership of them. If allocated mbufs had some offset other than RTE_PKTMBUF_HEADROOM, the application would read mbuf data starting at the wrong place and misinterpret the packet. Fixes: 856d7ba7ed22 ("net/enic: support

[dpdk-dev] [PATCH] doc: announce ABI change for mbuf structure

2016-07-19 Thread Bruce Richardson
On Tue, Jul 19, 2016 at 04:01:15PM +0200, Olivier Matz wrote: > For 16.11, the mbuf structure will be modified implying ABI breakage. > Some discussions already took place here: > http://www.dpdk.org/dev/patchwork/patch/12878/ > > Signed-off-by: Olivier Matz > --- >

[dpdk-dev] [PATCH] mempool: adjust name string size in related data types

2016-07-19 Thread Zoltan Kiss
A recent fix brought up an issue about the size of the 'name' fields: 85cf0079 mem: avoid memzone/mempool/ring name truncation These relations should be observed: RTE_RING_NAMESIZE <= RTE_MEMZONE_NAMESIZE - strlen(RTE_RING_MZ_PREFIX) RTE_MEMPOOL_NAMESIZE <= RTE_RING_NAMESIZE -

[dpdk-dev] [PATCH] mempool: fix lack of free() registration

2016-07-19 Thread Zoltan Kiss
The new mempool handler interface forgets to register the free() function of the ops. Introduced in this patch: 449c49b9 mempool: support handler operations Signed-off-by: Zoltan Kiss --- lib/librte_mempool/rte_mempool_ops.c | 1 + 1 file changed, 1 insertion(+) diff --git

[dpdk-dev] [RFC PATCH] i40: remove weak version of i40e_rx_vec_dev_conf_condition_check()

2016-07-19 Thread Zoltan Kiss
Using weak symbols have a few issues with static linking: - normally the linker searches the .o files already linked, if your weak one is there, it won't check if there is a strong version - unless the symbol is directly referred, but it's not the right thing to rely on - or --whole-archive

[dpdk-dev] [PATCH] doc: fix vhost setup in tep-termination app guide

2016-07-19 Thread Kavanagh, Mark B
Please disregard this patch - I'll push it again, this time with the correct subject line format. Apologies - Mark. > >- Fix vhost setup flags >- Add minor edits to improve readability and consistency > >Signed-off-by: Mark Kavanagh >--- > doc/guides/sample_app_ug/tep_termination.rst | 8

[dpdk-dev] [PATCH] rte_delay_us can be replaced with user function

2016-07-19 Thread Thomas Monjalon
Hi, 2016-07-19 14:42, jozmarti at cisco.com: > when running single-core, some drivers tend to call rte_delay_us for a > long time, and that is causing packet drops. > Attached patch introduces 2 new functions: > > void rte_delay_us_callback_register(void(*userfunc)(unsigned)); > void

[dpdk-dev] SRIOV hot unplug

2016-07-19 Thread Declan Doherty
On 07/19/2016 12:18 PM, Eli Britstein wrote: > > >> -Original Message- >> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] >> Sent: Tuesday, 19 July, 2016 5:49 AM >> To: Eli Britstein; dev at dpdk.org >> Cc: Iremonger, Bernard >> Subject: Re: [dpdk-dev] SRIOV hot unplug >> >> Hi Eli, >>

[dpdk-dev] [RFC] Generic flow director/filtering/classification API

2016-07-19 Thread Adrien Mazarguil
On Tue, Jul 19, 2016 at 08:11:48AM +, Lu, Wenzhuo wrote: > Hi Adrien, > Thanks for your clarification. Most of my questions are clear, but still > something may need to be discussed, comment below. Hi Wenzhuo, Please see below. [...] > > > > Requirements for a new API: > > > > > > > > -

[dpdk-dev] [PATCH] virtio: fix packet corruption

2016-07-19 Thread Olivier Matz
Hi Jianfeng, On 07/19/2016 03:03 PM, Tan, Jianfeng wrote: > Hi Oliver, > >> -Original Message- >> From: Olivier Matz [mailto:olivier.matz at 6wind.com] >> Sent: Tuesday, July 19, 2016 8:32 PM >> To: dev at dpdk.org; Tan, Jianfeng; Xie, Huawei; yuanhan.liu at >> linux.intel.com >>

[dpdk-dev] [PATCH] doc: announce ABI change for mbuf structure

2016-07-19 Thread Richardson, Bruce
> -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Tuesday, July 19, 2016 4:04 PM > To: Richardson, Bruce > Cc: dev at dpdk.org; jerin.jacob at caviumnetworks.com; > thomas.monjalon at 6wind.com > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change

[dpdk-dev] [PATCH] eal: fix rte_intr_dp_is_en() check

2016-07-19 Thread Yong Wang
> On Jul 18, 2016, at 2:21 AM, Thomas Monjalon > wrote: > > Hi Yong, > > I think the interrupt management should be simpler. > If you want to invest some time to rework this API, you > are very welcome. > > > 2016-07-18 14:19, Liang, Cunming: >> Hi Yong, >> >> rte_intr_dp_is_en() returns

[dpdk-dev] [PATCH] rte_delay_us can be replaced with user function

2016-07-19 Thread jozma...@cisco.com
From: Jozef Martiniak when running single-core, some drivers tend to call rte_delay_us for a long time, and that is causing packet drops. Attached patch introduces 2 new functions: void rte_delay_us_callback_register(void(*userfunc)(unsigned)); void

[dpdk-dev] [PATCH v3] mk: fix FreeBSD build

2016-07-19 Thread Sergio Gonzalez Monroy
The sed syntax of '0,/regexp/' is GNU specific and fails with non GNU sed in FreeBSD. To solve the issue we can use awk instead to remove duplicates. The awk script basically keeps the last config value, while maintaining order and comments from original config file. Fixes: b2063f104db7 ("mk:

[dpdk-dev] SRIOV hot unplug

2016-07-19 Thread Eli Britstein
> -Original Message- > From: Declan Doherty [mailto:declan.doherty at intel.com] > Sent: Tuesday, 19 July, 2016 5:15 PM > To: Eli Britstein; Tetsuya Mukawa; dev at dpdk.org > Cc: Iremonger, Bernard > Subject: Re: [dpdk-dev] SRIOV hot unplug > > On 07/19/2016 12:18 PM, Eli Britstein

[dpdk-dev] [PATCH] virtio: fix packet corruption

2016-07-19 Thread Olivier Matz
The support of virtio-user changed the way the mbuf dma address is retrieved, using a physical address in case of virtio-pci and a virtual address in case of virtio-user. This change introduced some possible memory corruption in packets, replacing: m->buf_physaddr + RTE_PKTMBUF_HEADROOM by:

[dpdk-dev] [PATCH v4 2/2] doc: add live migration virtio sriov image

2016-07-19 Thread Iremonger, Bernard
Hi John, > -Original Message- > From: Mcnamara, John > Sent: Tuesday, July 19, 2016 3:09 PM > To: Iremonger, Bernard ; dev at dpdk.org > Cc: Liu, Yong ; Xu, Qian Q ; > yuanhan.liu at linux.intel.com > Subject: RE: [PATCH v4 2/2] doc: add live migration virtio sriov image > > > > >

[dpdk-dev] [PATCH v4 1/2] doc: live migration of VM with Virtio and VF

2016-07-19 Thread Iremonger, Bernard
Hi John, > -Original Message- > From: Mcnamara, John > Sent: Tuesday, July 19, 2016 3:09 PM > To: Iremonger, Bernard ; dev at dpdk.org > Cc: Liu, Yong ; Xu, Qian Q ; > yuanhan.liu at linux.intel.com > Subject: RE: [PATCH v4 1/2] doc: live migration of VM with Virtio and VF > > >

[dpdk-dev] [PATCH] virtio: fix packet corruption

2016-07-19 Thread Tan, Jianfeng
Hi Oliver, > -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Tuesday, July 19, 2016 10:00 PM > To: Tan, Jianfeng; dev at dpdk.org; Xie, Huawei; yuanhan.liu at > linux.intel.com > Subject: Re: [PATCH] virtio: fix packet corruption > > Hi, > > On

[dpdk-dev] [PATCH v1] doc: fix release notes for 16.07

2016-07-19 Thread John McNamara
Fix grammar, spelling and formatting of DPDK 16.07 release notes. Signed-off-by: John McNamara --- doc/guides/rel_notes/release_16_07.rst | 134 + 1 file changed, 71 insertions(+), 63 deletions(-) diff --git a/doc/guides/rel_notes/release_16_07.rst

[dpdk-dev] [PATCH v4 2/2] doc: add live migration virtio sriov image

2016-07-19 Thread Mcnamara, John
> -Original Message- > From: Iremonger, Bernard > Sent: Monday, July 18, 2016 11:17 AM > To: Mcnamara, John ; dev at dpdk.org > Cc: Liu, Yong ; Xu, Qian Q ; > yuanhan.liu at linux.intel.com; Iremonger, Bernard > > Subject: [PATCH v4 2/2] doc: add live migration virtio sriov image > >

[dpdk-dev] [PATCH v4 1/2] doc: live migration of VM with Virtio and VF

2016-07-19 Thread Mcnamara, John
> -Original Message- > From: Iremonger, Bernard > Sent: Monday, July 18, 2016 11:17 AM > To: Mcnamara, John ; dev at dpdk.org > Cc: Liu, Yong ; Xu, Qian Q ; > yuanhan.liu at linux.intel.com; Iremonger, Bernard > > Subject: [PATCH v4 1/2] doc: live migration of VM with Virtio and VF > > +

[dpdk-dev] [PATCH v2] doc: autogenerate nic overview table from ini files

2016-07-19 Thread Ferruh Yigit
On 7/17/2016 1:59 PM, John McNamara wrote: > Convert the NIC feature table in the overview doc into a set of ini > files and add functions into the Sphinx conf.py file to auto-generate > them back into an RST table. > > The reason for doing this is to make it easier for PMD maintainers to >

[dpdk-dev] [PATCH] doc: add section on tested platforms and nics and OS

2016-07-19 Thread Yulong Pei
Add new section on tested platforms and nics and OS to the release notes. Signed-off-by: Yulong Pei --- doc/guides/rel_notes/release_16_07.rst | 117 + 1 file changed, 106 insertions(+), 11 deletions(-) diff --git a/doc/guides/rel_notes/release_16_07.rst

[dpdk-dev] [PATCH] virtio: fix packet corruption

2016-07-19 Thread Tan, Jianfeng
> -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Tuesday, July 19, 2016 9:11 PM > To: Tan, Jianfeng; dev at dpdk.org; Xie, Huawei; yuanhan.liu at > linux.intel.com > Subject: Re: [PATCH] virtio: fix packet corruption > > Hi Jianfeng, > > On

[dpdk-dev] [PATCH] doc: note a pitfall on reconnect feature

2016-07-19 Thread Mcnamara, John
> - Note: the "reconnect" feature requires **QEMU v2.7** (or above). > + .. Note:: > + * The "reconnect" feature requires **QEMU v2.7** (or above). > + > + * The vhost supported features must be exactly the same before and > + after the restart. For example, if TSO is disabled and

[dpdk-dev] [PATCH] examples/vhost: fix perf regression

2016-07-19 Thread Jianfeng Tan
We find significant perfermance drop introduced by below commit, when vhost example is started with --mergeable 0 and inside vm, kernel virtio-net driver is used to do ip based forwarding. The root cause is that below commit adds support for VIRTIO_NET_F_GUEST_TSO4 and VIRTIO_NET_F_GUEST_TSO6,

[dpdk-dev] [PATCH] rte_delay_us can be replaced with user function

2016-07-19 Thread Jozef Martiniak -X (jozmarti - PANTHEON TECHNOLOGIES@Cisco)
Hi, On Tue, 2016-07-19 at 15:21 +0200, Thomas Monjalon wrote: Hi, > > 2016-07-19 14:42, jozmarti at cisco.com: > > when running single-core, some drivers tend to call rte_delay_us for a > > long time, and that is causing packet drops. > > Attached patch introduces 2 new functions: > > > > void

[dpdk-dev] DPDK Coverity issue 127559

2016-07-19 Thread Rahul Lakkireddy
Hi all, On Monday, July 07/04/16, 2016 at 08:29:49 -0700, john.mcnamara at intel.com wrote: > Hi Rahul, > > This is an automated email in relation to a new Coverity static code analysis > issue in DPDK. Details of the issue are below. > [...] > Git commit data and Coverity defect information

[dpdk-dev] [PATCH] doc: add section on tested platforms and nics and OS

2016-07-19 Thread Mcnamara, John
> -Original Message- > From: Pei, Yulong > Sent: Tuesday, July 19, 2016 7:04 AM > To: dev at dpdk.org; Mcnamara, John > Cc: thomas.monjalon at 6wind.com; Pei, Yulong > Subject: [PATCH] doc: add section on tested platforms and nics and OS > > Add new section on tested platforms and nics

[dpdk-dev] [PATCH] net: virtio: clear reserved vring properly at setup time

2016-07-19 Thread Yuanhan Liu
On Tue, Jul 19, 2016 at 07:31:35AM +0200, Maxime Coquelin wrote: > >And to Thomas, I don't find a good reason to have this in 16.07. Let's > >delay the apply to v16.11. > Yes, that's why I mentioned it didn't fixed any problem on my side. > > So I propose we skip this patch, I'll resend one

[dpdk-dev] [PATCH] net/ena: fix icc compile error

2016-07-19 Thread Jan Mędala
Ferruh, Actually we can stay with this patch. It's ok. Acked-by: Jan Medala Jan 2016-07-19 12:48 GMT+02:00 Ferruh Yigit : > On 7/19/2016 10:33 AM, Ferruh Yigit wrote: > > compile error: > > CC ena_com.o > > .../drivers/net/ena/base/ena_com.c(346): > > error #3656: variable "dev_node" may

[dpdk-dev] [PATCH] rte_delay_us can be replaced with user function

2016-07-19 Thread Wiles, Keith
Hi Jozef, I have two quick comments inline. > On Jul 19, 2016, at 7:42 AM, jozmarti at cisco.com wrote: > > From: Jozef Martiniak > > when running single-core, some drivers tend to call rte_delay_us for a > long time, and that is causing packet drops. > Attached patch introduces 2 new

[dpdk-dev] [PATCH] virtio: fix packet corruption

2016-07-19 Thread Tan, Jianfeng
Hi Oliver, > -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Tuesday, July 19, 2016 8:32 PM > To: dev at dpdk.org; Tan, Jianfeng; Xie, Huawei; yuanhan.liu at > linux.intel.com > Subject: [PATCH] virtio: fix packet corruption > > The support of

[dpdk-dev] [PATCH v2] mk: fix FreeBSD build

2016-07-19 Thread Christian Ehrhardt
Hi, I haven't tested the new suggested way, just went into explaining what formerly were the reasons. But I'd strongly vote against reordering and dropping comments. Sergio - v3 had still awk for some parts. It doesn't have the "0,..." you mentioned. Could you check if that is already using

[dpdk-dev] [PATCH v2] mk: fix FreeBSD build

2016-07-19 Thread Sergio Gonzalez Monroy
Sorry Christian, I did miss your previous patches. On 19/07/2016 12:01, Christian Ehrhardt wrote: > Hi, > I haven't tested the new suggested way, just went into explaining what > formerly were the reasons. > But I'd strongly vote against reordering and dropping comments. > Fair enough. We would

[dpdk-dev] [PATCH RFC] maintainers: add git tree for virtio/vhost

2016-07-19 Thread Yuanhan Liu
Add a git tree line for the virtio/vhost section, to make an explicit statement that the developers are suggested to make patches based on that tree. Signed-off-by: Yuanhan Liu --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9c76352..433ddd8

[dpdk-dev] [PATCH] doc: note a pitfall on reconnect feature

2016-07-19 Thread Yuanhan Liu
The vhost feature negotiation only happens at virtio reset stage, say when a virtio-net device is firstly initiated, or when DPDK virtio PMD initiates. That means, if vhost APP restarts after the negotiation and reconnects, the feature negotiation process will not be triggered again, meaning the

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix GCC 4.5.x build error

2016-07-19 Thread Sergio Gonzalez Monroy
GCC 4.5.x does not handle well initializing anonymous union and/or structs. To make the compiler happy we name those anonymous union/struct. Fixes: 906257e965b7 ("examples/ipsec-secgw: support IPv6") Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/ipip.h | 4 +--

[dpdk-dev] [PATCH v1] ether: fix overwriting driver-specific stats

2016-07-19 Thread Remy Horton
After doing a driver callout to fill in the driver specific parts of struct rte_eth_stats, rte_eth_stats_get() overwrites the rx_nombuf member regardless of whether the driver itself has assigned a value. Any driver-assigned value should take priority. Fixes: af75078fece3 ("first public release")

[dpdk-dev] SRIOV hot unplug

2016-07-19 Thread Tetsuya Mukawa
Hi Eli, On 2016/07/18 17:47, Eli Britstein wrote: > Hi Bernard, > > Thank you for your answer. > However, to do this, I have to have some communication protocol to the VM's > application in order for it to do this sequence and acknowledge that it is > now safe to proceed with detaching the

[dpdk-dev] [PATCH] net/ena: fix icc compile error

2016-07-19 Thread Ferruh Yigit
On 7/19/2016 10:33 AM, Ferruh Yigit wrote: > compile error: > CC ena_com.o > .../drivers/net/ena/base/ena_com.c(346): > error #3656: variable "dev_node" may be used before its value is set > ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev, > ^ > >

[dpdk-dev] [PATCH v2] mk: fix FreeBSD build

2016-07-19 Thread Ferruh Yigit
On 7/18/2016 5:06 PM, Sergio Gonzalez Monroy wrote: > The sed syntax of '0,/regexp/' is GNU specific and fails with > non GNU sed in FreeBSD. > > To solve the issue we can use awk instead to remove duplicates. > > Fixes: b2063f104db7 ("mk: filter duplicate configuration entries") > >

[dpdk-dev] purifier

2016-07-19 Thread Vladimir Medvedkin
Hi all! I decided to open my project's code. It is fast scalable transparent statefull firewall which helps to mitigate transport layer DDoS attacks in datacenter environment. https://github.com/medvedv/purifier It was written with dpdk1.7.1 and I hope to rewrite it with the current stable

[dpdk-dev] [PATCH v4] doc: flow bifurcation guide on Linux

2016-07-19 Thread Jingjing Wu
Flow Bifurcation is a mechanism which uses features of advanced Ethernet devices to split traffic between queues. It provides the capability to let the kernel driver and DPDK driver co-exist and take advantage of both. It is achieved by using SR-IOV and the NIC's advanced filtering. This patch

[dpdk-dev] SRIOV hot unplug

2016-07-19 Thread Eli Britstein
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Tuesday, 19 July, 2016 5:49 AM > To: Eli Britstein; dev at dpdk.org > Cc: Iremonger, Bernard > Subject: Re: [dpdk-dev] SRIOV hot unplug > > Hi Eli, > > On 2016/07/18 17:47, Eli Britstein wrote: > > Hi

[dpdk-dev] [PATCH] net/virtio: fix crash on null dereference

2016-07-19 Thread Yuanhan Liu
The rxq/txq for the queue_release callback could be NULL, say when rte_eth_dev_configure() fails that the queue is not setup at all. Do a simple NULL check would fix the crash issue. Fixes: 01ad44fd374f ("net/virtio: split Rx/Tx queue") Reported-by: Olivier Matz Signed-off-by: Yuanhan Liu ---

[dpdk-dev] crash in virtio pmd

2016-07-19 Thread Yuanhan Liu
On Mon, Jul 18, 2016 at 06:06:53PM +0200, Olivier Matz wrote: > Hi, > > On 16.07-rc3, when I start testpmd with a virtio driver in a VM, > requesting options that are not implemented (rx checksum), it crashes: > ... > Sorry, I have not a lot of time to investigate further, hope you can > find

[dpdk-dev] [PATCH] net/ena: fix icc compile error

2016-07-19 Thread Ferruh Yigit
compile error: CC ena_com.o .../drivers/net/ena/base/ena_com.c(346): error #3656: variable "dev_node" may be used before its value is set ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev, ^ .../drivers/net/ena/base/ena_com.c(399): error #3656: variable "prev_node" may

[dpdk-dev] [PATCH v3] i40: fix the VXLAN TSO issue

2016-07-19 Thread Ananyev, Konstantin
> > Problem: > When using the TSO + VXLAN feature in i40e, the outer UDP length fields in > the multiple UDP segments which are TSOed by the i40e will > have a wrong value. > > Fix this problem by adding the tunnel type field in the i40e descriptor which > was missed before. > > Fixes:

[dpdk-dev] dpdk daily build error on dpdk16.07-rc2

2016-07-19 Thread Liu, Yu Y
Hi All, Patches for below two issues are verified by Yongjie. dpdk16.07-rc2 compile error on FC18 & UB1204 ena compile error on UB1404 & FC20 Best Regards, Yu Liu From: Gu, YongjieX Sent: Thursday, July 14, 2016 5:23 PM To: thomas.monjalon at 6wind.com; Richardson, Bruce ; Yigit, Ferruh ;

[dpdk-dev] [dpdk-users] RSS Hash not working for XL710/X710 NICs for some RX mbuf sizes

2016-07-19 Thread Xing, Beilei
Hi Ceara, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Take Ceara > Sent: Tuesday, July 19, 2016 12:14 AM > To: Zhang, Helin > Cc: Wu, Jingjing ; dev at dpdk.org > Subject: Re: [dpdk-dev] [dpdk-users] RSS Hash not working for XL710/X710 > NICs for some

[dpdk-dev] [PATCH v3 1/2] examples/ipsec-secgw: add configuration file support

2016-07-19 Thread Sergio Gonzalez Monroy
On 12/07/2016 10:44, Fan Zhang wrote: > This patch adds the configuration file support to ipsec_secgw > sample application. Instead of hard-coded rules, the users can > specify their own SP, SA, and routing rules in the configuration > file. An command line option "-f" is added to pass the >

[dpdk-dev] DPDK Coverity issue 127559

2016-07-19 Thread Mcnamara, John
> -Original Message- > From: Rahul Lakkireddy [mailto:rahul.lakkireddy at chelsio.com] > Sent: Tuesday, July 19, 2016 9:16 AM > To: Mcnamara, John ; dev at dpdk.org > Cc: Kumar Sanghvi ; Nirranjan Kirubaharan > ; Arjun V > Subject: Re: DPDK Coverity issue 127559 > > Hi all, > > > 907

[dpdk-dev] [RFC] Generic flow director/filtering/classification API

2016-07-19 Thread Lu, Wenzhuo
Hi Adrien, Thanks for your clarification. Most of my questions are clear, but still something may need to be discussed, comment below. > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com] > Sent: Thursday, July 7, 2016 6:27 PM > To: Lu, Wenzhuo > Cc: dev

[dpdk-dev] [PATCH] net: virtio: clear reserved vring properly at setup time

2016-07-19 Thread Maxime Coquelin
On 07/19/2016 03:39 AM, Yuanhan Liu wrote: > On Mon, Jul 18, 2016 at 07:09:24PM +0200, Maxime Coquelin wrote: >> After vring reservation, only the first bytes of the vring were >> cleared. >> >> This patch fixes this to clear the real size fo the vring. >> >> Signed-off-by: Maxime Coquelin >>