[dpdk-dev] [PATCH] app/test: increase memory allocated for greedy autotests

2016-07-21 Thread Olivier Matz
On 07/19/2016 07:21 PM, Thomas Monjalon wrote: > The autotest lists, requirements and distribution needs a big rework > to reduce the amount of cores and memory required. > The root cause is not addressed yet. > > This patch just increase some memory allocation for some greedy tests > which

[dpdk-dev] [RFC] Generic flow director/filtering/classification API

2016-07-21 Thread Chandran, Sugesh
Hi Adrien, Please find my comments below Regards _Sugesh > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com] > Sent: Wednesday, July 20, 2016 6:11 PM > To: Chandran, Sugesh > Cc: dev at dpdk.org; Thomas Monjalon ; > Zhang, Helin ; Wu, Jingjing > ;

[dpdk-dev] [PATCH] validate_abi: build faster by augmenting make with job count

2016-07-21 Thread Neil Horman
On Thu, Jul 21, 2016 at 02:09:19PM +, Wiles, Keith wrote: > > > On Jul 21, 2016, at 8:54 AM, Neil Horman wrote: > > > > On Wed, Jul 20, 2016 at 10:32:28PM +, Wiles, Keith wrote: > >> > >>> On Jul 20, 2016, at 3:16 PM, Neil Horman wrote: > >>> > >>> On Wed, Jul 20, 2016 at 07:47:32PM

[dpdk-dev] [PATCH 04/12] mbuf: add function to calculate a checksum

2016-07-21 Thread Ananyev, Konstantin
Hi Olivier, > > This function can be used to calculate the checksum of data embedded in mbuf, > that can be composed of several segments. > > This function will be used by the virtio pmd in next commits to calculate the > checksum in software in case the protocol is not recognized. > >

[dpdk-dev] [PATCH v3] mk: fix FreeBSD build

2016-07-21 Thread Thomas Monjalon
> > The sed syntax of '0,/regexp/' is GNU specific and fails with > > non GNU sed in FreeBSD. > > > > To solve the issue we can use awk instead to remove duplicates. > > > > The awk script basically keeps the last config value, while > > maintaining order and comments from original config file. >

[dpdk-dev] [PATCH] mk: fix static link with glibc < 2.17

2016-07-21 Thread Thomas Monjalon
> Tested-by: Yongjie Gu Applied

[dpdk-dev] [PATCH 12/12] virtio: add Tso support

2016-07-21 Thread Olivier Matz
Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 6 ++ drivers/net/virtio/virtio_ethdev.h | 2 + drivers/net/virtio/virtio_rxtx.c | 129 - 3 files changed, 134 insertions(+), 3 deletions(-) diff --git

[dpdk-dev] [PATCH 11/12] virtio: add Lro support

2016-07-21 Thread Olivier Matz
Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 7 ++- drivers/net/virtio/virtio_ethdev.h | 9 - drivers/net/virtio/virtio_rxtx.c | 21 + 3 files changed, 27 insertions(+), 10 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c

[dpdk-dev] [PATCH 10/12] virtio: add Tx checksum offload support

2016-07-21 Thread Olivier Matz
Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 7 + drivers/net/virtio/virtio_ethdev.h | 1 + drivers/net/virtio/virtio_rxtx.c | 57 +- 3 files changed, 45 insertions(+), 20 deletions(-) diff --git

[dpdk-dev] [PATCH 09/12] virtio: add Rx checksum offload support

2016-07-21 Thread Olivier Matz
Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 14 drivers/net/virtio/virtio_ethdev.h | 2 +- drivers/net/virtio/virtio_rxtx.c | 66 ++ drivers/net/virtio/virtqueue.h | 1 + 4 files changed, 75 insertions(+), 8

[dpdk-dev] [PATCH 08/12] app/testpmd: display lro segment size

2016-07-21 Thread Olivier Matz
In csumonly engine, display the value of LRO segment if the LRO flag is set. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 34a2591..3455a7e 100644 ---

[dpdk-dev] [PATCH 07/12] mbuf: new flag for LRO

2016-07-21 Thread Olivier Matz
When receiving coalesced packets in virtio, the original size of the segments is provided. This is a useful information because it allows to resegment with the same size. Add a RX new flag in mbuf, that can be set when packets are coalesced by a hardware or virtual driver when the m->tso_segsz

[dpdk-dev] [PATCH 06/12] app/testpmd: fix checksum stats in csum engine

2016-07-21 Thread Olivier Matz
--- app/test-pmd/csumonly.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 4b36d74..34a2591 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -680,8 +680,10 @@ pkt_burst_checksum_forward(struct

[dpdk-dev] [PATCH 05/12] mbuf: add new Rx checksum mbuf flags

2016-07-21 Thread Olivier Matz
Following discussions in [1] and [2], introduce a new bit to describe the Rx checksum status in mbuf. Before this patch, only one flag was available: PKT_RX_L4_CKSUM_BAD: L4 cksum of RX pkt. is not OK. And same for L3: PKT_RX_IP_CKSUM_BAD: IP cksum of RX pkt. is not OK. This had 2 issues: -

[dpdk-dev] [PATCH 04/12] mbuf: add function to calculate a checksum

2016-07-21 Thread Olivier Matz
This function can be used to calculate the checksum of data embedded in mbuf, that can be composed of several segments. This function will be used by the virtio pmd in next commits to calculate the checksum in software in case the protocol is not recognized. Signed-off-by: Olivier Matz ---

[dpdk-dev] [PATCH 03/12] virtio: reinitialize the device in configure callback

2016-07-21 Thread Olivier Matz
Add the ability to reset the virtio device in the configure callback if the features flag changed since previous reset. This will be possible with the introduction of offload support in next commits. Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 26

[dpdk-dev] [PATCH 02/12] virtio: setup and start cq in configure callback

2016-07-21 Thread Olivier Matz
Move the configuration of control queue in the configure callback. This is needed by next commit, which introduces the reinitialization of the device in the configure callback to change the feature flags. Therefore, the control queue will have to be restarted at the same place. As

[dpdk-dev] [PATCH 01/12] virtio: move device initialization in a function

2016-07-21 Thread Olivier Matz
Move all code related to device initialization in a new function virtio_init_device(). This commit brings no functional change, it prepares the next commits that will add the offload support. For that, it will be needed to reinitialize the device from ethdev->configure(), using this new function.

[dpdk-dev] [PATCH 00/12] net/virtio: add offload support

2016-07-21 Thread Olivier Matz
This patchset, targetted for 16.11, introduces the support of rx and tx offload in virtio pmd. To achieve this, some new mbuf flags must be introduced, as discussed in [1]. It applies on top of: - 16.07-rc3 - software packet type [2] - testpmd enhancements [3] - virtio packet corruption fix [4]

[dpdk-dev] [PATCH] validate_abi: build faster by augmenting make with job count

2016-07-21 Thread Neil Horman
On Wed, Jul 20, 2016 at 10:32:28PM +, Wiles, Keith wrote: > > > On Jul 20, 2016, at 3:16 PM, Neil Horman wrote: > > > > On Wed, Jul 20, 2016 at 07:47:32PM +, Wiles, Keith wrote: > >> > >>> On Jul 20, 2016, at 12:48 PM, Neil Horman wrote: > >>> > >>> On Wed, Jul 20, 2016 at 07:40:49PM

[dpdk-dev] [PATCH] net/fm10k: fix RSS hash config

2016-07-21 Thread Wang, Xiao W
Hi Mark, > -Original Message- > From: Chen, Jing D > Sent: Thursday, July 21, 2016 4:48 PM > To: Wang, Xiao W ; dev at dpdk.org > Cc: Lin, Xueqin > Subject: RE: [PATCH] net/fm10k: fix RSS hash config > > Hi, > > > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > >

[dpdk-dev] [PATCH v3] examples/vhost: fix perf regression

2016-07-21 Thread Yuanhan Liu
On Thu, Jul 21, 2016 at 12:42:45AM +, Jianfeng Tan wrote: > We find significant perfermance drop introduced by below commit, > when vhost example is started with --mergeable 0 and inside vm, > kernel virtio-net driver is used to do ip based forwarding. > > The commit, 859b480d5afd ("vhost:

[dpdk-dev] [PATCH] net/fm10k: fix RSS hash config

2016-07-21 Thread Chen, Jing D
Hi, > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > b/drivers/net/fm10k/fm10k_ethdev.c > index 144b2de..01f4a72 100644 > --- a/drivers/net/fm10k/fm10k_ethdev.c > +++ b/drivers/net/fm10k/fm10k_ethdev.c > @@ -2159,8 +2159,8 @@ fm10k_rss_hash_update(struct rte_eth_dev *dev, > >

[dpdk-dev] [RFC] Generic flow director/filtering/classification API

2016-07-21 Thread Lu, Wenzhuo
Hi Adrien, > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com] > Sent: Wednesday, July 20, 2016 6:41 PM > To: Lu, Wenzhuo > Cc: dev at dpdk.org; Thomas Monjalon; Zhang, Helin; Wu, Jingjing; Rasesh Mody; > Ajit Khaparde; Rahul Lakkireddy; Jan Medala; John

[dpdk-dev] [PATCH] doc: update 16.07 release notes and nic guide for enic

2016-07-21 Thread John Daley
Signed-off-by: John Daley --- doc/guides/nics/enic.rst | 9 +++-- doc/guides/nics/overview.rst | 2 +- doc/guides/rel_notes/release_16_07.rst | 23 +++ 3 files changed, 27 insertions(+), 7 deletions(-) diff --git a/doc/guides/nics/enic.rst

[dpdk-dev] [PATCH v3] examples/vhost: fix perf regression

2016-07-21 Thread Xu, Qian Q
Add the tested-by:) Tested-by: Qian Xu - Test Commit: 608487f3fc96704271c624d0f3fe9d7fb2187aea - OS/Kernel: Fedora 21/4.1.13 - GCC: gcc (GCC) 4.9.2 20141101 (Red Hat 4.9.2-1) - CPU: Intel(R) Xeon(R) CPU E5-2695 v4 @ 2.10 - NIC: Intel(R) Ethernet Controller X710 for 10GbE SFP+ - Total 2 cases, 2

[dpdk-dev] [PATCH v3] examples/vhost: fix perf regression

2016-07-21 Thread Jianfeng Tan
We find significant perfermance drop introduced by below commit, when vhost example is started with --mergeable 0 and inside vm, kernel virtio-net driver is used to do ip based forwarding. The commit, 859b480d5afd ("vhost: add guest offload setting"), adds support for VIRTIO_NET_F_GUEST_TSO4 and

[dpdk-dev] [PATCH v2] examples/vhost: fix perf regression

2016-07-21 Thread Tan, Jianfeng
Self-Nack this patch because the commit log needs change further. > -Original Message- > From: Tan, Jianfeng > Sent: Thursday, July 21, 2016 8:24 AM > To: dev at dpdk.org > Cc: yuanhan.liu at linux.intel.com; Wang, Zhihong; Xu, Qian Q; Tan, Jianfeng > Subject: [PATCH v2] examples/vhost:

[dpdk-dev] [PATCH v2] examples/vhost: fix perf regression

2016-07-21 Thread Jianfeng Tan
We find significant perfermance drop introduced by below commit, when vhost example is started with --mergeable 0 and inside vm, kernel virtio-net driver is used to do ip based forwarding. The root cause is that below commit adds support for VIRTIO_NET_F_GUEST_TSO4 and VIRTIO_NET_F_GUEST_TSO6,

<    1   2