[dpdk-dev] [PATCH 0/6] vhost: add Tx zero copy support

2016-08-23 Thread Yuanhan Liu
BTW, I really appreicate your efforts on reviewing this patchset. It would be great if you could take some time to review my another patchset :) [PATCH 0/7] vhost: vhost-cuse removal and code path refactoring It touchs a large of code base, that I wish I could apply it ASAP. So that the

[dpdk-dev] [PATCH 6/6] examples/vhost: add an option to enable Tx zero copy

2016-08-23 Thread Yuanhan Liu
On Tue, Aug 23, 2016 at 04:14:44PM +0200, Maxime Coquelin wrote: > > /* Specify timeout (in useconds) between retries on RX. */ > > static uint32_t burst_rx_delay_time = BURST_RX_WAIT_US; > >@@ -297,6 +298,17 @@ port_init(uint8_t port) > > > > rx_ring_size = RTE_TEST_RX_DESC_DEFAULT; > >

[dpdk-dev] [PATCH 0/6] vhost: add Tx zero copy support

2016-08-23 Thread Yuanhan Liu
On Tue, Aug 23, 2016 at 04:18:40PM +0200, Maxime Coquelin wrote: > > > On 08/23/2016 10:10 AM, Yuanhan Liu wrote: > >This patch set enables vhost Tx zero copy. The majority work goes to > >patch 4: vhost: add Tx zero copy. > > > >The basic idea of Tx zero copy is, instead of copying data from

[dpdk-dev] [PATCH 4/4] app/test: add kasumi f8 test into QAT testsuite

2016-08-23 Thread Deepak Kumar Jain
Signed-off-by: Deepak Kumar Jain --- app/test/test_cryptodev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 9cf4504..fdcdbeb 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c @@ -4145,6 +4145,11 @@

[dpdk-dev] [PATCH 3/4] crypto/qat: enable support of Kasumi F8 in QAT cryptodev

2016-08-23 Thread Deepak Kumar Jain
This patch enables the support of Kasumi F8 for Intel Quick Assist Technology. Signed-off-by: Deepak Kumar Jain --- drivers/crypto/qat/qat_adf/qat_algs.h| 3 +- drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 44 +--- drivers/crypto/qat/qat_crypto.c

[dpdk-dev] [PATCH 2/4] app/test: add Kasumi f9 tests in QAT test suite

2016-08-23 Thread Deepak Kumar Jain
This patch adds Kausmi f9 tests in the QAT tesuite and add an additional test for Kasumi F9. Signed-off-by: Deepak Kumar Jain --- app/test/test_cryptodev.c | 11 ++ app/test/test_cryptodev_kasumi_hash_test_vectors.h | 43 ++ 2 files changed, 54

[dpdk-dev] [PATCH 1/4] crypto/qat: enable Kasumi F9 support in QAT driver

2016-08-23 Thread Deepak Kumar Jain
The changes in this patch enables the Kasumi F9 functionality for Intel Quick Assist Technology Signed-off-by: Deepak Kumar Jain --- drivers/crypto/qat/qat_adf/qat_algs.h| 7 ++ drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 30 ++--

[dpdk-dev] [PATCH 0/4] add kasumi in Intel(R) QuickAssist driver

2016-08-23 Thread Deepak Kumar Jain
This patchset contains patches to enable kasumi cipher only and hash only functionality in Intel(R) QuickAsisst Technology Driver. This patchset depends on following patch: "crypto/qat: add NULL capability to Intel QAT driver" (http://dpdk.org/dev/patchwork/patch/15230/) Deepak Kumar Jain (4):

[dpdk-dev] [PATCH 4/6] vhost: add Tx zero copy

2016-08-23 Thread Yuanhan Liu
On Tue, Aug 23, 2016 at 04:04:30PM +0200, Maxime Coquelin wrote: > > > On 08/23/2016 10:10 AM, Yuanhan Liu wrote: > >The basic idea of Tx zero copy is, instead of copying data from the > >desc buf, here we let the mbuf reference the desc buf addr directly. > > > >Doing so, however, has one major

[dpdk-dev] [PATCH 2/6] vhost: get guest/host physical address mappings

2016-08-23 Thread Yuanhan Liu
On Tue, Aug 23, 2016 at 03:25:33PM +0200, Maxime Coquelin wrote: > > > On 08/23/2016 02:32 PM, Yuanhan Liu wrote: > >>>+ > >+ /* FIXME */ > >+ RTE_LOG(INFO, VHOST_CONFIG, ":: %u ::\n", pre_read); > >>> For my information, what is the purpose of pre_read? > >Again, I put a

[dpdk-dev] [PATCH] doc: remove useless file listings

2016-08-23 Thread Yuanhan Liu
On Tue, Aug 23, 2016 at 02:45:14PM +0200, Thomas Monjalon wrote: > Lists of DPDK files are hard to maintain up to date and does not bring > much information. > > Signed-off-by: Thomas Monjalon Reviewed-by: Yuanhan Liu --yliu

[dpdk-dev] [PATCH 6/6] examples/vhost: add an option to enable Tx zero copy

2016-08-23 Thread Yuanhan Liu
On Tue, Aug 23, 2016 at 11:31:08AM +0200, Thomas Monjalon wrote: > 2016-08-23 16:10, Yuanhan Liu: > > One thing worth noting while using Tx zero copy is the nb_tx_desc has > > to be small enough so that the eth driver will hit the mbuf free > > threshold easily and thus free mbuf more frequently.

[dpdk-dev] [PATCH 2/6] vhost: get guest/host physical address mappings

2016-08-23 Thread Yuanhan Liu
On Tue, Aug 23, 2016 at 11:58:42AM +0200, Maxime Coquelin wrote: > > > >+/* Convert guest physical address to host physical address */ > >+static inline phys_addr_t __attribute__((always_inline)) > >+gpa_to_hpa(struct virtio_net *dev, uint64_t gpa, uint64_t size) > >+{ > >+uint32_t i; > >+

[dpdk-dev] [PATCH] examples/l3fwd: enabling 4m hash for all 64 bit archs

2016-08-23 Thread Hemant Agrawal
This patch enables the support for 4 million hash entries for all 64 bit architectures. Signed-off-by: Hemant Agrawal --- examples/l3fwd/l3fwd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l3fwd/l3fwd.h b/examples/l3fwd/l3fwd.h index d8798b7..011ba14 100644 ---

[dpdk-dev] [PATCH] examples/l3fwd: em path hash offload to machine

2016-08-23 Thread Hemant Agrawal
if machine level CRC extension are available, offload the hash to machine provided functions e.g. armv8-a CRC extensions support it Signed-off-by: Hemant Agrawal --- examples/l3fwd/l3fwd_em.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-08-23 Thread Yuanhan Liu
On Tue, Aug 23, 2016 at 10:43:36AM +, Wang, Zhihong wrote: > > > I forgot to add that before this series, I think we should first fix the > > > windows > > bug. > > > Else we will need a dedicated fix for the stable branch. > > > > Okay I'll try to fix it, though I can't make any promises at

[dpdk-dev] [PATCH 3/4] net/bonding: another fix to LACP mempool size

2016-08-23 Thread Sanford, Robert
Hi Olivier, On 8/23/16, 11:09 AM, "Olivier MATZ" wrote: Hi Robert, On 08/01/2016 10:42 PM, Robert Sanford wrote: > The following log message may appear after a slave is idle (or nearly > idle) for a few minutes: "PMD: Failed to allocate LACP packet from > pool". > >

[dpdk-dev] [PATCH v1] doc: fix broken link in docs

2016-08-23 Thread Thomas Monjalon
> > From: Deirdre O'Connor > > > > Fixes: 58abf6e77c6b ("doc: add contributors guide") > > > > Suggested-by: Jon Loeliger > > Signed-off-by: Deirdre O'Connor > > Acked-by: John McNamara Applied, thanks

[dpdk-dev] [PATCH 0/6] vhost: add Tx zero copy support

2016-08-23 Thread Maxime Coquelin
On 08/23/2016 04:53 PM, Yuanhan Liu wrote: > BTW, I really appreicate your efforts on reviewing this patchset. > > It would be great if you could take some time to review my another > patchset :) > > [PATCH 0/7] vhost: vhost-cuse removal and code path refactoring > > It touchs a large of

[dpdk-dev] [PATCH v4 00/10] Fix build errors related to exported headers

2016-08-23 Thread Thomas Monjalon
After rebasing the patchset, the compilation of each patch seems good. But the new checks fail with clang: rte_memcpy.h:814:2: error: implicit declaration of function '_mm_alignr_epi8' is invalid in C99 Other comments about the script: - it is too long (can it be

[dpdk-dev] [PATCH 3/3] examples/ipsec-secgw: add AES-GCM support

2016-08-23 Thread Sergio Gonzalez Monroy
Add support for AES-GCM (Galois-Counter Mode). RFC4106: The Use of Galois-Counter Mode (GCM) in IPSec ESP. Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/esp.c | 59 ++-- examples/ipsec-secgw/ipsec.h | 9 +++

[dpdk-dev] [PATCH 2/3] examples/ipsec-secgw: reset crypto operation status

2016-08-23 Thread Sergio Gonzalez Monroy
Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/ipsec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c index 1e87d0d..f49143b 100644 --- a/examples/ipsec-secgw/ipsec.c +++ b/examples/ipsec-secgw/ipsec.c @@ -124,6

[dpdk-dev] [PATCH 1/3] examples/ipsec-secgw: change CBC IV generation

2016-08-23 Thread Sergio Gonzalez Monroy
NIST SP800-38A recommends two methods to generate unpredictable IVs (Initilisation Vector) for CBC mode: 1) Apply the forward function to a nonce (ie. counter) 2) Use a FIPS-approved random number generator This patch implements the first recommended method by using the forward function to

[dpdk-dev] [PATCH 0/3] IPSec AES-GCM support

2016-08-23 Thread Sergio Gonzalez Monroy
This patch set mainly introduces support for AES-GCM. It also changes the IV generation for AES-CBC mode using the forward function instead of randomly generating the IV. Dependencies: examples/ipsec-secgw: add configuration file support http://dpdk.org/dev/patchwork/patch/15269/

[dpdk-dev] [PATCH v2] net/i40e: fix parsing QinQ packets type issue

2016-08-23 Thread Beilei Xing
Previously, PTYPE filed in the RX descriptors is not set properly for QinQ packets, wrong PTYPE is generated because outer Tag did not have ORT/PIT configured. Fix this issue by configuring ORT/PIT. Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Beilei Xing --- v2 changes:

[dpdk-dev] [PATCH 4/6] vhost: add Tx zero copy

2016-08-23 Thread Maxime Coquelin
On 08/23/2016 04:31 PM, Yuanhan Liu wrote: > On Tue, Aug 23, 2016 at 04:04:30PM +0200, Maxime Coquelin wrote: >> >> >> On 08/23/2016 10:10 AM, Yuanhan Liu wrote: >>> The basic idea of Tx zero copy is, instead of copying data from the >>> desc buf, here we let the mbuf reference the desc buf addr

[dpdk-dev] [PATCH 3/4] net/bonding: another fix to LACP mempool size

2016-08-23 Thread Olivier MATZ
Hi Robert, On 08/01/2016 10:42 PM, Robert Sanford wrote: > The following log message may appear after a slave is idle (or nearly > idle) for a few minutes: "PMD: Failed to allocate LACP packet from > pool". > > Problem: All mbufs from a slave's private pool (used exclusively for > transmitting

[dpdk-dev] [PATCH 2/4] mempool: make cache flush threshold macro public

2016-08-23 Thread Olivier MATZ
Hi Robert, On 08/01/2016 10:42 PM, Robert Sanford wrote: > Rename macros that calculate a mempool cache flush threshold, and > move them from rte_mempool.c to rte_mempool.h, so that the bonding > driver can accurately calculate its mbuf requirements. > > Signed-off-by: Robert Sanford > --- >

[dpdk-dev] [PATCH v2 6/6] net/vmxnet3: enable lro

2016-08-23 Thread Yong Wang
The current implementation of jumbo frame rx can be used for LRO directly without changes. This change enables device LRO if requested. Note that since jumbo frame uses both ring0 and ring1, it cannot be enabled in UPT (VMDirectPath) mode. Signed-off-by: Yong Wang ---

[dpdk-dev] [PATCH v2 5/6] net/vmxnet3: update nic doc

2016-08-23 Thread Yong Wang
Signed-off-by: Yong Wang --- doc/guides/nics/vmxnet3.rst | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/doc/guides/nics/vmxnet3.rst b/doc/guides/nics/vmxnet3.rst index e919088..bf84594 100644 --- a/doc/guides/nics/vmxnet3.rst +++ b/doc/guides/nics/vmxnet3.rst

[dpdk-dev] [PATCH v2 4/6] net/vmxnet3: update feature doc

2016-08-23 Thread Yong Wang
Signed-off-by: Yong Wang --- doc/guides/nics/features/vmxnet3.ini | 21 + 1 file changed, 21 insertions(+) diff --git a/doc/guides/nics/features/vmxnet3.ini b/doc/guides/nics/features/vmxnet3.ini index 20a4c32..c5c75ad 100644 --- a/doc/guides/nics/features/vmxnet3.ini +++

[dpdk-dev] [PATCH v2 3/6] net/vmxnet3: reallocate shared memzone on re-config

2016-08-23 Thread Yong Wang
When adding a DPDK port to a bridge using ovs-vswitchd with DPDK, the vmxnet3 device fails to activate due to mismatched magic number. Doing this will incur the following operations: start the port, stop the port, reconfigure and re-start the port. The reconfig could request different number of

[dpdk-dev] [PATCH v2 2/6] net/vmxnet3: coding style changes

2016-08-23 Thread Yong Wang
Signed-off-by: Yong Wang --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 69 ++-- drivers/net/vmxnet3/vmxnet3_ethdev.h | 32 - drivers/net/vmxnet3/vmxnet3_ring.h | 22 ++-- drivers/net/vmxnet3/vmxnet3_rxtx.c | 59

[dpdk-dev] [PATCH v2 1/6] net/vmxnet3: improve error checks and return values

2016-08-23 Thread Yong Wang
Signed-off-by: Yong Wang --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index 5874215..f5035bb 100644 ---

[dpdk-dev] [PATCH v2 0/6] various vmxnet3 fixes and enhancement

2016-08-23 Thread Yong Wang
v2: * updated vmxnet3 feature doc. * updated vmxnet3 guide to remove stale information. v1: This patchset includes a few bug fixes and some enhancement. * Fixed a bug with dev_configure memzone size; * Enhanced error checks during device start. * the driver will now report error if the rx

[dpdk-dev] [PATCH 0/6] vhost: add Tx zero copy support

2016-08-23 Thread Maxime Coquelin
On 08/23/2016 10:10 AM, Yuanhan Liu wrote: > This patch set enables vhost Tx zero copy. The majority work goes to > patch 4: vhost: add Tx zero copy. > > The basic idea of Tx zero copy is, instead of copying data from the > desc buf, here we let the mbuf reference the desc buf addr directly. > >

[dpdk-dev] [PATCH 6/6] examples/vhost: add an option to enable Tx zero copy

2016-08-23 Thread Maxime Coquelin
On 08/23/2016 10:10 AM, Yuanhan Liu wrote: > Add an option, --tx-zero-copy, to enable Tx zero copy. > > One thing worth noting while using Tx zero copy is the nb_tx_desc has > to be small enough so that the eth driver will hit the mbuf free > threshold easily and thus free mbuf more frequently.

[dpdk-dev] [PATCH 6/6] examples/vhost: add an option to enable Tx zero copy

2016-08-23 Thread Yuanhan Liu
Add an option, --tx-zero-copy, to enable Tx zero copy. One thing worth noting while using Tx zero copy is the nb_tx_desc has to be small enough so that the eth driver will hit the mbuf free threshold easily and thus free mbuf more frequently. The reason behind that is, when Tx zero copy is

[dpdk-dev] [PATCH 5/6] vhost: add a flag to enable Tx zero copy

2016-08-23 Thread Yuanhan Liu
Add a new flag ``RTE_VHOST_USER_TX_ZERO_COPY`` to explictily enable Tx zero copy. If not given, Tx zero copy is disabled by default. Signed-off-by: Yuanhan Liu --- doc/guides/prog_guide/vhost_lib.rst | 7 ++- lib/librte_vhost/rte_virtio_net.h | 1 + lib/librte_vhost/socket.c |

[dpdk-dev] [PATCH 4/6] vhost: add Tx zero copy

2016-08-23 Thread Yuanhan Liu
The basic idea of Tx zero copy is, instead of copying data from the desc buf, here we let the mbuf reference the desc buf addr directly. Doing so, however, has one major issue: we can't update the used ring at the end of rte_vhost_dequeue_burst. Because we don't do the copy here, an update of the

[dpdk-dev] [PATCH 3/6] vhost: introduce last avail idx for Tx

2016-08-23 Thread Yuanhan Liu
So far, we retrieve both the used ring avail ring idx by last_used_idx var; it won't be a problem because we used ring is updated immediately after those avail entries are consumed. But that's not true when Tx zero copy is enabled, that used ring is updated only when the mbuf is consumed. Thus,

[dpdk-dev] [PATCH 2/6] vhost: get guest/host physical address mappings

2016-08-23 Thread Yuanhan Liu
So that we can convert a guest physical address to host physical address, which will be used in later Tx zero copy implementation. Signed-off-by: Yuanhan Liu --- lib/librte_vhost/vhost.h | 30 +++ lib/librte_vhost/vhost_user.c | 86 +++ 2

[dpdk-dev] [PATCH 1/6] vhost: simplify memory regions handling

2016-08-23 Thread Yuanhan Liu
Due to history reason (that vhost-cuse comes before vhost-user), some fields for maintaining the vhost-user memory mappings (such as mmapped address and size, with those we then can unmap on destroy) are kept in "orig_region_map" struct, a structure that is defined only in vhost-user source file.

[dpdk-dev] [PATCH 0/6] vhost: add Tx zero copy support

2016-08-23 Thread Yuanhan Liu
This patch set enables vhost Tx zero copy. The majority work goes to patch 4: vhost: add Tx zero copy. The basic idea of Tx zero copy is, instead of copying data from the desc buf, here we let the mbuf reference the desc buf addr directly. The major issue behind that is how and when to update

[dpdk-dev] [PATCH 2/4] mempool: make cache flush threshold macro public

2016-08-23 Thread Sanford, Robert
Hi Olivier, On 8/23/16, 11:09 AM, "Olivier MATZ" wrote: Hi Robert, On 08/01/2016 10:42 PM, Robert Sanford wrote: > Rename macros that calculate a mempool cache flush threshold, and > move them from rte_mempool.c to rte_mempool.h, so that the bonding > driver can accurately

[dpdk-dev] [PATCH 2/6] vhost: get guest/host physical address mappings

2016-08-23 Thread Maxime Coquelin
On 08/23/2016 03:49 PM, Yuanhan Liu wrote: > On Tue, Aug 23, 2016 at 03:25:33PM +0200, Maxime Coquelin wrote: >> >> >> On 08/23/2016 02:32 PM, Yuanhan Liu wrote: > + >>> + /* FIXME */ >>> + RTE_LOG(INFO, VHOST_CONFIG, ":: %u ::\n", pre_read); > For my information,

[dpdk-dev] [PATCH 4/6] vhost: add Tx zero copy

2016-08-23 Thread Maxime Coquelin
On 08/23/2016 10:10 AM, Yuanhan Liu wrote: > The basic idea of Tx zero copy is, instead of copying data from the > desc buf, here we let the mbuf reference the desc buf addr directly. > > Doing so, however, has one major issue: we can't update the used ring > at the end of

[dpdk-dev] [PATCH] crypto/qat: add Intel QuickAssist C62x device

2016-08-23 Thread Deepak Kumar Jain
Signed-off-by: Deepak Kumar Jain --- doc/guides/cryptodevs/qat.rst | 82 -- drivers/crypto/qat/rte_qat_cryptodev.c | 3 ++ 2 files changed, 81 insertions(+), 4 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index

[dpdk-dev] [PATCH v6 2/2] examples/ipsec-secgw: add sample configuration files

2016-08-23 Thread Fan Zhang
This patch adds two sample configuration files to ipsec-secgw sample application. The sample configuration files shows how to set-up systems back-to-back that would forward traffic through an IPsec tunnel. Signed-off-by: Fan Zhang --- examples/ipsec-secgw/ep0.cfg | 160

[dpdk-dev] [PATCH v6 1/2] examples/ipsec-secgw: add configuration file support

2016-08-23 Thread Fan Zhang
This patch adds the configuration file support to ipsec_secgw sample application. Instead of hard-coded rules, the users can specify their own SP, SA, and routing rules in the configuration file. An command line option "-f" is added to pass the configuration file location to the application.

[dpdk-dev] [PATCH v6 0/2] [PATCH 0/2] examples/ipsec_secgw: add configuration file support

2016-08-23 Thread Fan Zhang
This patchset adds the configuration file supported to ipsec_secgw sample application. Two sample configuration files, ep0.cfg and ep1.cfg are also added to show how to configure two systems back-to-back that would forward traffic through an IPsec tunnel v6 change: - fix SA digest key always 0

[dpdk-dev] [PATCH v3 2/4] virtio: move SSE based Rx implementation to separate file

2016-08-23 Thread Yuanhan Liu
On Fri, Aug 19, 2016 at 08:54:00AM +0530, Jerin Jacob wrote: > On Thu, Aug 18, 2016 at 02:52:31PM +0800, Yuanhan Liu wrote: > > On Tue, Jul 05, 2016 at 06:19:24PM +0530, Jerin Jacob wrote: > > > Split out SSE instruction based virtio simple Rx > > > implementation to a separate file > > > > > >

[dpdk-dev] [PATCH] vhost: add back support for concurrent enqueue

2016-08-23 Thread Rich Lane
On Mon, Aug 22, 2016 at 7:16 AM, Yuanhan Liu wrote: > On Thu, Aug 18, 2016 at 11:27:06AM -0700, Rich Lane wrote: > > On Mon, Aug 15, 2016 at 7:37 PM, Yuanhan Liu < > yuanhan.liu at linux.intel.com> > > wrote: > > > > On Mon, Aug 15, 2016 at 01:00:24PM -0700, Rich Lane wrote: > > >

[dpdk-dev] [PATCH] net/virtio: fix build error with clang

2016-08-23 Thread Yuanhan Liu
Interestingly, clang and gcc has different prototype for _mm_prefetch(). For gcc, we have _mm_prefetch (const void *__P, enum _mm_hint __I) While for clang, it's #define _mm_prefetch(a, sel) (__builtin_prefetch((void *)(a), 0, (sel))) That how the following error comes with clang:

[dpdk-dev] [PATCH 0/3] remove rte_pci_dev_ids.h

2016-08-23 Thread Thomas Monjalon
2016-08-05 15:09, Ferruh Yigit: > This patchset moves remaining PCI device ids for ixgbe and igb drivers, > updates KNI code which uses these ids to use pci_device_ids from kni/ethtool > drivers, > and finally removes the rte_pci_dev_ids.h and updates document refers it. > > Ferruh Yigit (3): >

[dpdk-dev] [PATCH 3/3] eal: remove rte_pci_dev_ids.h

2016-08-23 Thread Thomas Monjalon
2016-08-08 08:20, David Marchand: > On Sat, Aug 6, 2016 at 2:55 PM, Thomas Monjalon > wrote: > > What do you think about this list? I would say we can remove it. > > Yes, we already discussed this with John. > http://dpdk.org/ml/archives/dev/2016-January/031595.html Done:

[dpdk-dev] [PATCH 2/6] vhost: get guest/host physical address mappings

2016-08-23 Thread Maxime Coquelin
On 08/23/2016 02:32 PM, Yuanhan Liu wrote: >>> + >>> > >+/* FIXME */ >>> > >+RTE_LOG(INFO, VHOST_CONFIG, ":: %u ::\n", pre_read); >> > For my information, what is the purpose of pre_read? > Again, I put a FIXME here, but I forgot to add some explanation. > > Here is the thing:

[dpdk-dev] [PATCH] doc: remove useless file listings

2016-08-23 Thread Thomas Monjalon
> > Lists of DPDK files are hard to maintain up to date and does not bring > > much information. > > > > Signed-off-by: Thomas Monjalon > > Acked-by: John McNamara Applied

[dpdk-dev] [PATCH] doc: remove useless file listings

2016-08-23 Thread Thomas Monjalon
Lists of DPDK files are hard to maintain up to date and does not bring much information. Signed-off-by: Thomas Monjalon --- doc/guides/freebsd_gsg/build_dpdk.rst | 13 +- doc/guides/linux_gsg/build_dpdk.rst| 10 - doc/guides/prog_guide/dev_kit_build_system.rst | 57

[dpdk-dev] [PATCH 3/6] vhost: introduce last avail idx for Tx

2016-08-23 Thread Maxime Coquelin
On 08/23/2016 10:10 AM, Yuanhan Liu wrote: > So far, we retrieve both the used ring avail ring idx by last_used_idx > var; it won't be a problem because we used ring is updated immediately > after those avail entries are consumed. > > But that's not true when Tx zero copy is enabled, that used

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-08-23 Thread Maxime Coquelin
On 08/23/2016 12:43 PM, Wang, Zhihong wrote: > > >> -Original Message- >> From: Wang, Zhihong >> Sent: Tuesday, August 23, 2016 10:31 AM >> To: Maxime Coquelin ; dev at dpdk.org >> Cc: yuanhan.liu at linux.intel.com >> Subject: RE: [PATCH v3 0/5] vhost: optimize enqueue >> >> >> >>>

[dpdk-dev] [PATCH] examples/vhost: remove VLAN strip option

2016-08-23 Thread Yuanhan Liu
On Thu, Aug 18, 2016 at 10:19:15AM +, Tan, Jianfeng wrote: > > > +VLAN strip option is removed, because different NICs have different > > behaviors > > > +when disabling VLAN strip. Such feature, which heavily depends on > > hardware, > > > +should be removed from this example to deduce

[dpdk-dev] [PATCH 2/2] examples/vhost: support multiple socket files

2016-08-23 Thread Yuanhan Liu
On Sat, Aug 20, 2016 at 06:11:36AM -0400, Jiayu Hu wrote: > When examples/vhost runs in client mode, only one QEMU can be connected. > This is because that examples/vhost just supports one socket file. This > patch is to add multiple sockets support for examples/vhost. > > Signed-off-by: Jiayu Hu

[dpdk-dev] [PATCH 1/2] examples/vhost: rename dev-basename

2016-08-23 Thread Yuanhan Liu
On Sat, Aug 20, 2016 at 06:10:33AM -0400, Jiayu Hu wrote: > In examples/vhost, "dev-basename" is a program option, which is to set > the vhost-net socket used by vhost-user, or the character device used > by vhost-cuse. Since vhost-cuse should be dropped, and "dev-basename" > is not a suitable

[dpdk-dev] [PATCH] doc: remove useless file listings

2016-08-23 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, August 23, 2016 1:45 PM > To: Mcnamara, John > Cc: dev at dpdk.org > Subject: [PATCH] doc: remove useless file listings > > Lists of DPDK files are hard to maintain up to date and does not

[dpdk-dev] [PATCH] vhost: add pmd xstats

2016-08-23 Thread Panu Matilainen
On 08/23/2016 11:04 AM, Yang, Zhiyong wrote: > Hi, Panu: > >> -Original Message- >> From: Panu Matilainen [mailto:pmatilai at redhat.com] >> Sent: Monday, August 22, 2016 3:53 PM >> To: Yang, Zhiyong ; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] vhost: add pmd xstats >> >> On

[dpdk-dev] PA to VA address conversion API in DPDK

2016-08-23 Thread Devendra Rawat
Hi, I am implementing a PMD driver for my ethernet device in DPDK. I have allocated HW desc. queue for receiving packets. For each desc. there's a corresponding rte_mbuf allocated and the PA of that mbuf is put in the desc. In the RX callback function, On packet reception I will get the PA from

[dpdk-dev] [PATCH] ivshmem: remove integration in dpdk

2016-08-23 Thread Thomas Monjalon
> > Following discussions on the mailing list [1] and since nobody stood up to > > implement the necessary cleanups, here is the ivshmem integration removal. > > > > There is not much to say about this patch, a lot of code is being removed. > > The default configuration file for packet_ordering

[dpdk-dev] [PATCH 2/6] vhost: get guest/host physical address mappings

2016-08-23 Thread Maxime Coquelin
On 08/23/2016 10:10 AM, Yuanhan Liu wrote: > So that we can convert a guest physical address to host physical > address, which will be used in later Tx zero copy implementation. > > Signed-off-by: Yuanhan Liu > --- > lib/librte_vhost/vhost.h | 30 +++ >

[dpdk-dev] [PATCH 6/6] examples/vhost: add an option to enable Tx zero copy

2016-08-23 Thread Thomas Monjalon
2016-08-23 16:10, Yuanhan Liu: > One thing worth noting while using Tx zero copy is the nb_tx_desc has > to be small enough so that the eth driver will hit the mbuf free > threshold easily and thus free mbuf more frequently. > > The reason behind that is, when Tx zero copy is enabled, guest Tx

[dpdk-dev] [PATCH 1/6] vhost: simplify memory regions handling

2016-08-23 Thread Maxime Coquelin
On 08/23/2016 10:10 AM, Yuanhan Liu wrote: > Due to history reason (that vhost-cuse comes before vhost-user), some > fields for maintaining the vhost-user memory mappings (such as mmapped > address and size, with those we then can unmap on destroy) are kept in > "orig_region_map" struct, a

[dpdk-dev] [PATCH] testpmd: fix fdir command on MAC and tunnel modes

2016-08-23 Thread frederico.cadete-...@oneaccess-net.com
From: Frederico Cadete The flow_director_filter commands has a pf|vf option for most modes except for MAC-VLAN and tunnel. On Intel NIC's these modes are not supported under virtualized environments. But the application was checking that this field was

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-08-23 Thread Wang, Zhihong
> -Original Message- > From: Wang, Zhihong > Sent: Tuesday, August 23, 2016 10:31 AM > To: Maxime Coquelin ; dev at dpdk.org > Cc: yuanhan.liu at linux.intel.com > Subject: RE: [PATCH v3 0/5] vhost: optimize enqueue > > > > > -Original Message- > > From: Maxime Coquelin

[dpdk-dev] [PATCH] eal/armv8: high-resolution cycle counter

2016-08-23 Thread Hemant Agrawal
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jerin Jacob > Sent: Thursday, August 18, 2016 5:22 PM > To: dev at dpdk.org > Cc: thomas.monjalon at 6wind.com; jianbo.liu at linaro.org; > viktorin at rehivetech.com; Jerin Jacob > Subject: [dpdk-dev] [PATCH]

[dpdk-dev] [PATCH v1] doc: fix broken link in docs

2016-08-23 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of O Connor, Deirdre > Sent: Monday, August 22, 2016 5:20 PM > To: dev at dpdk.org > Cc: O Connor, Deirdre > Subject: [dpdk-dev] [PATCH v1] doc: fix broken link in docs > > From: Deirdre O'Connor > > Fixes:

[dpdk-dev] [PATCH] vhost: add pmd xstats

2016-08-23 Thread Yang, Zhiyong
Hi, Panu: > -Original Message- > From: Panu Matilainen [mailto:pmatilai at redhat.com] > Sent: Monday, August 22, 2016 3:53 PM > To: Yang, Zhiyong ; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] vhost: add pmd xstats > > On 08/19/2016 03:16 PM, Zhiyong Yang wrote: > > This feature

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-08-23 Thread Wang, Zhihong
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com] > Sent: Monday, August 22, 2016 6:02 PM > To: Wang, Zhihong ; dev at dpdk.org > Cc: yuanhan.liu at linux.intel.com > Subject: Re: [PATCH v3 0/5] vhost: optimize enqueue > > > On 08/22/2016 10:11 AM,

[dpdk-dev] [PATCH v3 1/5] vhost: rewrite enqueue

2016-08-23 Thread Wang, Zhihong
Hi Maxime, Thanks very much for the detailed review. > -Original Message- > From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com] > Sent: Monday, August 22, 2016 5:36 PM > To: Wang, Zhihong ; dev at dpdk.org > Cc: yuanhan.liu at linux.intel.com > Subject: Re: [PATCH v3 1/5] vhost:

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-08-23 Thread Wang, Zhihong
> Subject: Re: [PATCH v3 0/5] vhost: optimize enqueue > > Hi Zhihong, > [...] > > The main optimization techniques are: > > > > 1. Reorder code to reduce CPU pipeline stall cycles. > > > > 2. Batch update the used ring for better efficiency. > > > > 3. Prefetch descriptor to hide cache

[dpdk-dev] [PATCH] maintainers: add staging tree for network drivers

2016-08-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Monday, July 25, 2016 9:22 AM > To: Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] maintainers: add staging tree for network > drivers > > On Mon, Jul 25,

[dpdk-dev] [PATCH] doc: fix old dpdk-nic-bind.py references

2016-08-23 Thread Thomas Monjalon
> > dpdk-nic-bind.py script has been renamed to dpdk-devbind.py, > > but some references to the old script have remained. > > This commit completes the renaming. > > > > Fixes: a5d7a3f77ddc ("unify tools naming") > > > > Signed-off-by: Pablo de Lara > > I like the cleanups for consistency! > >