[dpdk-dev] [PATCH 3/3] hash: modify lookup bulk pipeline

2016-08-26 Thread Pablo de Lara
From: Byron Marohn This patch replaces the pipelined rte_hash lookup mechanism with a loop-and-jump model, which performs significantly better, especially for smaller table sizes and smaller table occupancies. Signed-off-by: Byron Marohn Signed-off-by: Saikrishna

[dpdk-dev] [PATCH 2/3] hash: add vectorized comparison

2016-08-26 Thread Pablo de Lara
From: Byron Marohn In lookup bulk function, the signatures of all entries are compared against the signature of the key that is being looked up. Now that all the signatures are together, they can be compared with vector instructions (SSE, AVX2), achieving higher lookup

[dpdk-dev] [PATCH 1/3] hash: reorganize bucket structure

2016-08-26 Thread Pablo de Lara
From: Byron Marohn Move current signatures of all entries together in the bucket and same with all alternative signatures, instead of having current and alternative signatures together per entry in the bucket. This will be benefitial in the next commits, where a

[dpdk-dev] [PATCH 3/3] hash: check if slot is empty with key index

2016-08-26 Thread Pablo de Lara
Instead of checking if the current and alternative signatures are 0, it is faster to check if the key index associated to an entry is 0, meaning that the slot is empty. Signed-off-by: Pablo de Lara --- lib/librte_hash/rte_cuckoo_hash.c | 16

[dpdk-dev] [PATCH 2/3] hash: fix false zero signature key hit lookup

2016-08-26 Thread Pablo de Lara
This commit fixes a corner case scenario. When a key is deleted, its signature in the hash table gets clear, which should prevent a lookup of that same key, unless the signature of the key is all zeroes. In that case, there will be a match, and key would be compared against the key that is in the

[dpdk-dev] [PATCH 1/3] hash: fix ring size

2016-08-26 Thread Pablo de Lara
Ring stores the free slots available to be used in the key table. The ring size was being increased by 1, because of the dummy slot, used for key misses, but this is not actually stored in the ring, so there is no need to increase it. Fixes: 5915699153d7 ("hash: fix scaling by reducing

[dpdk-dev] [PATCH 0/3] Hash library fixes

2016-08-26 Thread Pablo de Lara
This patchset includes some minor fixes to the hash library, plus a small improvement in checking for an empty slot when performing different hash operations. Pablo de Lara (3): hash: fix ring size hash: fix false zero signature key hit lookup hash: check if slot is empty with key index

[dpdk-dev] [PATCH 2/2] ip_pipeline: enable swap action in network layers configuration file

2016-08-26 Thread Jasvinder Singh
The network_layers configuration file (config/network_layers.cfg) demonstrates the various network layer components such as TCP, UDP, ICMP etc, which can be easily integrated into ip pipeline infrastructure. The loopback function (implemented using passthrough pipeline) is updated to perform swap

[dpdk-dev] [PATCH 1/2] ip_pipeline: add packet fields swap action to pass-through pipeline

2016-08-26 Thread Jasvinder Singh
Pass-through pipeline is updated with addition of packet fields swap action. To enable swap action, new entry i.e 'swap' is required in the passthrough pipeline section of the configuration file, and this entry contains the offsets (in bytes) of the packet fields to be swapped. Each swap entry

[dpdk-dev] [PATCH v1] add mtu set in virtio

2016-08-26 Thread souvikdey33
This functionality is required mostly in the cloud infrastructure. For example, if we use gre or vxlan network between compute and controller, then we should not use 1500 mtu in the guest as with encapsulation the sixe of the packet will be more and will get dropped in the infrastructure. So, in

[dpdk-dev] [PATCH v8 25/25] eal/pci: Create rte_device list and fallback on its members

2016-08-26 Thread Shreyansh Jain
Now that rte_device is available, drivers can start using its members (numa, name) as well as link themselves into another rte_device list. As of now no one is using this list, but can be used for moving over all devices (pdev/vdev/Xdev) and perform bulk actions (like cleanup). Signed-off-by:

[dpdk-dev] [PATCH v8 24/25] eal: introduce rte_device

2016-08-26 Thread Shreyansh Jain
Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_dev.c | 13 + lib/librte_eal/common/include/rte_dev.h | 31 +++ 2 files changed, 44 insertions(+) diff --git a/lib/librte_eal/common/eal_common_dev.c

[dpdk-dev] [PATCH v8 23/25] eal: call rte_eal_driver_register

2016-08-26 Thread Shreyansh Jain
To register both vdev and pci drivers into the list of all rte_driver, we have to call rte_eal_driver_register explicitly. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_pci.c | 2 ++ lib/librte_eal/common/eal_common_vdev.c | 2 ++ 2 files

[dpdk-dev] [PATCH v8 22/25] eal/pci: inherit rte_driver by rte_pci_driver

2016-08-26 Thread Shreyansh Jain
Remove the 'name' member from rte_pci_driver and move to generic rte_driver. Most of the PMD drivers were initially using DRIVER_REGISTER_PCI(..) as well as assigning a name to eth_driver.pci_drv.name member. In this patch, only the original DRIVER_REGISTER_PCI(..) name has been populated into

[dpdk-dev] [PATCH v8 21/25] eal: rename and move rte_pci_resource

2016-08-26 Thread Shreyansh Jain
There is no need to have a custom memory resource representation for each infrastructure (PCI, ...) as it would always have the same members. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain --- drivers/net/szedata2/rte_eth_szedata2.c | 4 ++-- lib/librte_eal/common/include/rte_dev.h

[dpdk-dev] [PATCH v8 20/25] eal: rte_pci.h includes rte_dev.h

2016-08-26 Thread Shreyansh Jain
Further refactoring and generalization of PCI infrastructure will require access to the rte_dev.h contents. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/include/rte_pci.h | 1 + 1 file changed, 1 insertion(+) diff --git

[dpdk-dev] [PATCH v8 19/25] eal: remove PMD_DRIVER_REGISTER and unused pmd_types

2016-08-26 Thread Shreyansh Jain
- All devices register themselfs by calling a kind of DRIVER_REGISTER_XXX. The PMD_REGISTER_DRIVER is not used anymore. - PMD_VDEV type is also not being used - can be removed from all VDEVs. Note: PMD_REGISTER_DRIVER usage by PMDINFO tool and its documentation has not yet been removed.

[dpdk-dev] [PATCH v8 18/25] eal: move init/uninit to rte_vdev_driver

2016-08-26 Thread Shreyansh Jain
These functions are virtual-device specific and they are never called for any PCI driver (after introducing DRIVER_REGISTER_PCI, there is no way to do it). All affected drivers are updated. The prototypes are renamed to rte_vdev_init_t and rte_vdev_uninit_t. Signed-off-by: Jan Viktorin

[dpdk-dev] [PATCH v8 17/25] drivers: convert PMD_VDEV drivers to use rte_vdev_driver

2016-08-26 Thread Shreyansh Jain
All PMD_VDEV drivers can now use rte_vdev_driver instead of the rte_driver (which is embedded in the rte_vdev_driver). Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain --- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 14 -- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 14

[dpdk-dev] [PATCH v8 16/25] eal: Remove PDEV/VDEV unused code

2016-08-26 Thread Shreyansh Jain
- Remove checks for VDEV from rte_eal_vdev_(init/uninint) as all devices are inherently virtual here. - PDEVs perform PCI specific inits - rte_eal_dev_init() need not call rte_driver->init(); Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain ---

[dpdk-dev] [PATCH v8 15/25] eal: extract vdev infra

2016-08-26 Thread Shreyansh Jain
Move all PMD_VDEV-specific code into a separate module and header file to not polute the generic code anymore. There is now a list of virtual devices available. The rte_vdev_driver integrates the original rte_driver inside (C inheritance). The rte_driver will be however change in the future to

[dpdk-dev] [PATCH v8 14/25] ethdev: get rid of device type

2016-08-26 Thread Shreyansh Jain
Now that hotplug has been moved to eal, there is no reason to keep the device type in this layer. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- app/test/virtual_pmd.c| 2 +- drivers/net/af_packet/rte_eth_af_packet.c | 2 +-

[dpdk-dev] [PATCH v8 13/25] ethdev: convert to eal hotplug

2016-08-26 Thread Shreyansh Jain
Remove bus logic from ethdev hotplug by using eal for this. Current api is preserved: - the last port that has been created is tracked to return it to the application when attaching, - the internal device name is reused when detaching. We can not get rid of ethdev hotplug yet since we still

[dpdk-dev] [PATCH v8 12/25] eal: add hotplug operations for pci and vdev

2016-08-26 Thread Shreyansh Jain
Hotplug invocations, which deals with devices, should come from the layer that already handles them, i.e. EAL. For both attach and detach operations, 'name' is used to select the bus that will handle the request. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain ---

[dpdk-dev] [PATCH v8 11/25] ethdev: do not scan all pci devices on attach

2016-08-26 Thread Shreyansh Jain
No need to scan all devices, we only need to update the device being attached. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_pci.c | 11 --- lib/librte_ether/rte_ethdev.c | 3 --- 2 files changed, 8 insertions(+), 6

[dpdk-dev] [PATCH v8 10/25] eal/pci: Helpers for device name parsing/update

2016-08-26 Thread Shreyansh Jain
- Move rte_eth_dev_create_unique_device_name() from ether/rte_ethdev.c to common/include/rte_pci.h as rte_eal_pci_device_name(). Being a common method, can be used across crypto/net PCI PMDs. - Remove crypto specific routine and fallback to common name function. - Introduce a eal private

[dpdk-dev] [PATCH v8 09/25] driver: Remove driver register callbacks for crypto/net

2016-08-26 Thread Shreyansh Jain
Now that all pdev are pci drivers, we don't need to register crypto and ethdev drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 22 --- lib/librte_cryptodev/rte_cryptodev_pmd.h

[dpdk-dev] [PATCH v8 08/25] drivers: convert all pdev drivers as pci drivers

2016-08-26 Thread Shreyansh Jain
Simplify crypto and ethdev pci drivers init by using newly introduced init macros and helpers. Those drivers then don't need to register as "rte_driver"s anymore. Exceptions: - virtio and mlx* use RTE_INIT directly as they have custom initialization steps. - VDEV devices are not modified - they

[dpdk-dev] [PATCH v8 07/25] driver: init/uninit common wrappers for PCI drivers

2016-08-26 Thread Shreyansh Jain
crypto and ethdev drivers aligned to PCI probe/remove. Existing handlers for init/uninit can be easily reused for this. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 16 lib/librte_cryptodev/rte_cryptodev_pmd.h

[dpdk-dev] [PATCH v8 06/25] eal: introduce init macros

2016-08-26 Thread Shreyansh Jain
Introduce a RTE_INIT macro used to mark an init function as a constructor. Current eal macros have been converted to use this (no functional impact). DRIVER_REGISTER_PCI is added as a helper for pci drivers. Suggested-by: Jan Viktorin Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain

[dpdk-dev] [PATCH v8 05/25] drivers: align pci driver definitions

2016-08-26 Thread Shreyansh Jain
Pure coding style, but it might make it easier later if we want to move fields in rte_cryptodev_driver and eth_driver structures. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- drivers/crypto/qat/rte_qat_cryptodev.c | 2 +- drivers/net/ena/ena_ethdev.c | 2 +-

[dpdk-dev] [PATCH v8 04/25] crypto: no need for a crypto pmd type

2016-08-26 Thread Shreyansh Jain
This information is not used and just adds noise. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 8 +++- lib/librte_cryptodev/rte_cryptodev.h | 2 -- lib/librte_cryptodev/rte_cryptodev_pmd.h | 3 +-- 3 files changed, 4

[dpdk-dev] [PATCH v8 03/25] pci: no need for dynamic tailq init

2016-08-26 Thread Shreyansh Jain
These lists can be initialized once and for all at build time. With this, those lists are only manipulated in a common place (and we could even make them private). A nice side effect is that pci drivers can now register in constructors. Signed-off-by: David Marchand Reviewed-by: Jan Viktorin

[dpdk-dev] [PATCH v8 02/25] eal: remove duplicate function declaration

2016-08-26 Thread Shreyansh Jain
rte_eal_dev_init is declared in both eal_private.h and rte_dev.h since its introduction. This function has been exported in ABI, so remove it from eal_private.h Fixes: e57f20e05177 ("eal: make vdev init path generic for both virtual and pci devices") Signed-off-by: David Marchand Signed-off-by:

[dpdk-dev] [PATCH v8 01/25] eal: define macro container_of

2016-08-26 Thread Shreyansh Jain
Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/include/rte_common.h | 16 1 file changed, 16 insertions(+) diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h index 332f2a4..a9b6792 100644

[dpdk-dev] [PATCH v8 00/25] Introducing rte_driver/rte_device generalization

2016-08-26 Thread Shreyansh Jain
Based on master (e22856313fff2) Background: === It includes two different patch-sets floated on ML earlier: * Original patch series is from David Marchand [1], [2]. `- This focused mainly on PCI (PDEV) part `- v7 of this was posted by me [8] in August/2016 * Patch series [4] from

[dpdk-dev] [RFC][PATCH 0/3] example/vhost: Introduce Vswitch Framework

2016-08-26 Thread Maxime Coquelin
On 08/27/2016 06:26 PM, Pankaj Chauhan wrote: > Introduce generic vswitch framework in vhost-switch application. Following > are the goals/aim of the framework: > > 1. Make vhost-switch application generic so that it can support devices > which don't support VMDQ. > > 2. Provide a framework so

[dpdk-dev] FW: [PATCH v6 0/9] enable lpm, acl and other missing libraries in ppc64le

2016-08-26 Thread Chao Zhu
Thomas, Any comments of this patch set? Are we waiting for more acks? Thank you! -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chao Zhu Sent: 2016?8?17? 16:49 To: 'Gowrishankar Muthukrishnan' ; dev at dpdk.org Cc: 'Bruce Richardson' ; 'Konstantin Ananyev' ;

[dpdk-dev] [PATCH 13/13] net/thunderx: document secondary queue set support

2016-08-26 Thread Kamil Rytarowski
From: Kamil Rytarowski Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki Signed-off-by: Jerin Jacob --- doc/guides/nics/thunderx.rst | 114

[dpdk-dev] [PATCH 12/13] net/thunderx: add final bits for secondary queue support

2016-08-26 Thread Kamil Rytarowski
From: Kamil Rytarowski Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki Signed-off-by: Jerin Jacob --- drivers/net/thunderx/nicvf_ethdev.c | 178

[dpdk-dev] [PATCH 11/13] net/thunderx: add secondary qset support in device configure

2016-08-26 Thread Kamil Rytarowski
From: Kamil Rytarowski Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki Signed-off-by: Jerin Jacob --- drivers/net/thunderx/nicvf_ethdev.c | 65

[dpdk-dev] [PATCH 10/13] net/thunderx: add secondary qset support in device start

2016-08-26 Thread Kamil Rytarowski
From: Kamil Rytarowski Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki Signed-off-by: Jerin Jacob --- drivers/net/thunderx/nicvf_ethdev.c | 266

[dpdk-dev] [PATCH 09/13] net/thunderx: add secondary qset support in dev stop/close

2016-08-26 Thread Kamil Rytarowski
From: Kamil Rytarowski Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki Signed-off-by: Jerin Jacob --- drivers/net/thunderx/nicvf_ethdev.c | 142

[dpdk-dev] [PATCH 08/13] net/thunderx: add helper utils for secondary qset support

2016-08-26 Thread Kamil Rytarowski
From: Kamil Rytarowski Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki Signed-off-by: Jerin Jacob --- drivers/net/thunderx/nicvf_ethdev.h | 39

[dpdk-dev] [PATCH 07/13] net/thunderx: fix multiprocess support in stats

2016-08-26 Thread Kamil Rytarowski
From: Kamil Rytarowski In case of the multiprocess mode a shared nicvf struct between processes cannot point with the eth_dev pointer to master device, therefore remove it allong with references to it refactoring the code where needed. Fixes: 7413feee662d

[dpdk-dev] [PATCH 06/13] net/thunderx: add secondary queue set in interrupt functions

2016-08-26 Thread Kamil Rytarowski
From: Kamil Rytarowski Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki Signed-off-by: Jerin Jacob --- drivers/net/thunderx/nicvf_ethdev.c | 41

[dpdk-dev] [PATCH 05/13] net/thunderx: add family of functions to store DPDK qsets

2016-08-26 Thread Kamil Rytarowski
From: Kamil Rytarowski These functions (nicvf_svf) are DPDK specialization of base/nicvf_bsvf.[ch] ones. Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw

[dpdk-dev] [PATCH 04/13] net/thunderx/base: add secondary queue set support

2016-08-26 Thread Kamil Rytarowski
From: Kamil Rytarowski Changes: - add new message sqs_alloc in mailbox - add a queue container to hold secondary qsets. - add nicvf_mbox_request_sqs - handle new mailbox messages for secondary queue set support - register secondary queue sets for furthe

[dpdk-dev] [PATCH 03/13] net/thunderx/base: add family of functions to store qsets

2016-08-26 Thread Kamil Rytarowski
From: Kamil Rytarowski This interface (nicvf_bsvf) will be used for secondary queue set support. Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki

[dpdk-dev] [PATCH 02/13] net/thunderx: correct transmit checksum handling

2016-08-26 Thread Kamil Rytarowski
From: Kamil Rytarowski The symbols PKT_TX_TCP_CKSUM and PKT_TX_UDP_CKSUM are not bits on a bitmask. Set l3_offset always for TX offloads, not just for PKT_TX_IP_CKSUM being true. Fixes: 1c421f18e095 ("net/thunderx: add single and multi-segment Tx")

[dpdk-dev] [PATCH 01/13] net/thunderx: cleanup the driver before adding new features

2016-08-26 Thread Kamil Rytarowski
From: Kamil Rytarowski Refactored features: - enable nicvf_qset_rbdr_precharge to handle handle secondary queue sets - rte_free already handles NULL pointer - check mempool flags to predict being contiguous in memory - allow to use mempool with multiple

[dpdk-dev] [PATCH 00/13] Add support for secondary queue set in nicvf thunderx driver

2016-08-26 Thread Kamil Rytarowski
This series of patches adds support for secondary queue set in nicvf thunderx driver There are two types of VFs: - Primary VF - Secondary VF Each port consist of a primary VF and n secondary VF(s). Each VF provides 8 Tx/Rx queues to a port. In case port is configured to use more than 8 queues,

[dpdk-dev] [PATCH] app/test: add 3DES tests into QuickAssist PMD testsuite

2016-08-26 Thread Fiona Trahe (fiona.tr...@intel.com)
From: Fiona Trahe This patch depends on * 3DES QuickAssist driver patch: http://dpdk.org/dev/patchwork/patch/15413/ * libcrypto test patch: http://dpdk.org/dev/patchwork/patch/15344/ Signed-off-by: Fiona Trahe --- app/test/test_cryptodev.c | 68

[dpdk-dev] [PATCH 6/6] testpmd: add txprep engine

2016-08-26 Thread Tomasz Kulasek
This patch adds txprep engine to the testpmd application. Txprep engine is intended to verify Tx preparation functionality implemented in pmd driver. It's based on the default "io" engine with the folowing changes: - Tx HW offloads are reset in incoming packet, - burst is passed to the Tx

[dpdk-dev] [PATCH 5/6] ixgbe: add Tx preparation

2016-08-26 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek --- drivers/net/ixgbe/ixgbe_ethdev.c |3 ++ drivers/net/ixgbe/ixgbe_ethdev.h |8 +++- drivers/net/ixgbe/ixgbe_rxtx.c | 83 +- drivers/net/ixgbe/ixgbe_rxtx.h |2 + 4 files changed, 94 insertions(+), 2 deletions(-)

[dpdk-dev] [PATCH 4/6] i40e: add Tx preparation

2016-08-26 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek --- drivers/net/i40e/i40e_ethdev.c |3 ++ drivers/net/i40e/i40e_rxtx.c | 98 +++- drivers/net/i40e/i40e_rxtx.h | 10 3 files changed, 110 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c

[dpdk-dev] [PATCH 3/6] fm10k: add Tx preparation

2016-08-26 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek --- drivers/net/fm10k/fm10k.h|9 drivers/net/fm10k/fm10k_ethdev.c |5 +++ drivers/net/fm10k/fm10k_rxtx.c | 87 +- 3 files changed, 100 insertions(+), 1 deletion(-) diff --git a/drivers/net/fm10k/fm10k.h

[dpdk-dev] [PATCH 1/6] ethdev: add Tx preparation

2016-08-26 Thread Tomasz Kulasek
Added API for `rte_eth_tx_prep` uint16_t rte_eth_tx_prep(uint8_t port_id, uint16_t queue_id, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) Added fields to the `struct rte_eth_desc_lim`: uint16_t nb_seg_max; /**< Max number of segments per whole packet. */

[dpdk-dev] [PATCH 0/6] add Tx preparation

2016-08-26 Thread Tomasz Kulasek
As discussed in that thread: http://dpdk.org/ml/archives/dev/2015-September/023603.html Different NIC models depending on HW offload requested might impose different requirements on packets to be TX-ed in terms of: - Max number of fragments per packet allowed - Max number of fragments per TSO

[dpdk-dev] [PATCH] ethdev: fix statistics description

2016-08-26 Thread Wei Dai
Add comments to describe that not all statistics fields in struct rte_eth_stats are supported by any type of network interface card. If any statistics field is not supported, its value is 0. Fixes: af75078fece3 ("first public release") Signed-off-by: Wei Dai --- lib/librte_ether/rte_ethdev.h |

[dpdk-dev] [PATCH 0/6] add Tx preparation

2016-08-26 Thread Tomasz Kulasek
As discussed in that thread: http://dpdk.org/ml/archives/dev/2015-September/023603.html Different NIC models depending on HW offload requested might impose different requirements on packets to be TX-ed in terms of: - Max number of fragments per packet allowed - Max number of fragments per TSO

[dpdk-dev] FW: [PATCH v6 0/9] enable lpm, acl and other missing libraries in ppc64le

2016-08-26 Thread Thomas Monjalon
2016-08-26 18:55, Chao Zhu: > Thomas, > > Any comments of this patch set? Are we waiting for more acks? Yes, especially for lpm and acl, a review from respective maintainers may be needed. Konstantin? Bruce? If no review is done in 1 week, it will be applied as-is. Gowrishankar, using

[dpdk-dev] [PATCH 3/3] app/test: adding cuckoo hash table for testing

2016-08-26 Thread Sankar Chokkalingam
This patch includes cuckoo has table for testing all the APIs The cuckoo hash is added for both test_table_tables and test_table_combined cases. The testing is completed and the results are OK. Signed-off-by: Sankar Chokkalingam Signed-off-by: Guruprasad Rao --- app/test/test_table_combined.c

[dpdk-dev] [PATCH 2/3] app/test-pipeline: added cuckoo hash for benchmarking

2016-08-26 Thread Sankar Chokkalingam
This patch inclides cuckoo hash table into test-pipeline This allows to benchmark the performance of the cuckoo hash table The following key sizes are supported for cuckoo hash table 8, 16, 32, 48, 64, 80, 96, 112 and 128. The test-pipeline can be run using the following command

[dpdk-dev] [PATCH 1/3] lib/librte_table: enabling cuckoo hash into table library

2016-08-26 Thread Sankar Chokkalingam
This patch provides table apis for dosig version of cuckoo hash via rte_table_hash_cuckoo_dosig_ops The following apis are implemented for cuckoo hash rte_table_hash_cuckoo_create rte_table_hash_cuckoo_free rte_table_hash_cuckoo_entry_add

[dpdk-dev] [PATCH 0/3] Enable cuckoo hash in table library

2016-08-26 Thread Sankar Chokkalingam
This patchset implements the table APIs for cuckoo hash. This will enable any dpdk application to use the cuckoo hash table apis instead of the direct apis from lib/librte_hash The dosig version of the cuckoo hash is implemented in this patch with the following APIs

[dpdk-dev] [PATCH v2 2/2] crypto/qat: adding support for 3DES cipher algorithm

2016-08-26 Thread Fiona Trahe (fiona.tr...@intel.com)
From: Fiona Trahe 3DES support added to QuickAssist PMD With CTR and CBC mode. Both cipher-only and chained with HMAC_SHAx This patch depends on following patch : crypto/qat: enable support of Kasumi F8 in QAT cryptodev http://dpdk.org/dev/patchwork/patch/15320/

[dpdk-dev] [PATCH v2 1/2] crypto/qat: code cleanup

2016-08-26 Thread Fiona Trahe (fiona.tr...@intel.com)
From: Fiona Trahe Cleanup of unused code. Rename and simplify a badly named struct element, was aes, but used for all types of ciphers Print correct error msg (Unsupported rather than Undefined) for all ciphers not supported by qat PMD. Signed-off-by: Fiona Trahe ---

[dpdk-dev] [PATCH v2 0/2] Add 3DES support to Quickassist PMD

2016-08-26 Thread Fiona Trahe (fiona.tr...@intel.com)
From: Fiona Trahe Some preparatory cleanup done in QAT PMD for adding 3DES 3DES support added to QuickAssist PMD With CTR and CBC mode. Both cipher-only and chained with HMAC_SHAx 3DES test code is dependent on the libcrypto patch, so will be sent separately after that

[dpdk-dev] [PATCH] kni: add support for older kernels

2016-08-26 Thread Thomas Monjalon
> +#if (defined(RHEL_RELEASE_CODE) && \ > + (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(6, 8)) && \ > + (LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 34))) > +#undef NET_NAME_UNKNOWN > +#endif Should the title be "kni: support RHEL 6.8"?

[dpdk-dev] [PATCH] ntnic: add PMD driver

2016-08-26 Thread Thomas Monjalon
Welcome, 2016-08-26 13:44, Finn Christensen: > +NTNIC Poll Mode Driver > +== > + > +The NTNIC poll mode driver library (**librte_pmd_ntnic**) implements support > +for **Napatech NIC** 40/50 Gbps adapters. > +This PMD is implemented as a pure software virtual device and must

[dpdk-dev] [PATCH] ntnic: add PMD driver

2016-08-26 Thread Finn Christensen
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: 26. august 2016 16:44 > To: Finn Christensen > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ntnic: add PMD driver > > Welcome, Thanks! > > 2016-08-26 13:44, Finn Christensen: > > +NTNIC Poll Mode Driver > >

[dpdk-dev] [PATCH 2/5] i40e: implement vector PMD for ARM architecture

2016-08-26 Thread Thomas Monjalon
Hi Jianbo (and other developers of vectorized PMDs), 2016-08-24 15:23, Jianbo Liu: > Use ARM NEON intrinsic to implement i40e vPMD Have you tried to use the generic SIMD intrinsics? We could maintain only one vectorized implementation by using __attribute__ ((vector_size (n))) as

[dpdk-dev] [PATCH] scripts: disable optimization for ABI validation

2016-08-26 Thread Ferruh Yigit
abi-dumper giving following warning: WARNING: incompatible build option detected: -O3 Although this patch won't fix warning, it is to ensure code compiled with optimization disabled. Signed-off-by: Ferruh Yigit --- scripts/validate-abi.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[dpdk-dev] [PATCH v2 0/2] Add 3DES support to Quickassist PMD

2016-08-26 Thread Trahe, Fiona
Oops, sorry, typo in email address ! - will resend -Original Message- From: y at ecsmtp.ir.intel.com [mailto:y...@ecsmtp.ir.intel.com] Sent: Friday, August 26, 2016 4:40 PM To: dev at dpdk.org Cc: De Lara Guarch, Pablo ; Griffin, John ; Jain, Deepak K ; Kusztal, ArkadiuszX ; Trahe,

[dpdk-dev] [RFC] drivers: advertise kmod dependencies in pmdinfo

2016-08-26 Thread Olivier Matz
Add a new macro DRIVER_REGISTER_KMOD_DEP() that allows a driver to declare the list of kernel modules required to run properly. Today, most PCI drivers require uio/vfio. Signed-off-by: Olivier Matz --- In this RFC, I supposed that all PCI drivers require a the loading of a uio/vfio module

[dpdk-dev] [PATCH] tools: fix json output of pmdinfo

2016-08-26 Thread Olivier Matz
Using dpdk-pmdinfo with the '-r' flag does not produce a json output as documented. Instead, the python representation of the json object is shown, which is nearly the same, but cannot be properly parsed by a json parser. python repr (before): {u'pci_ids': [[5549, 1968, 65535, 65535]], u'name':

[dpdk-dev] [PATCH] app/testpmd: configure flowgen packet size though --txpkts

2016-08-26 Thread maciej.cze...@caviumnetworks.com
From: Maciej Czekaj "flowgen" forwarding mode has fixed packet size (300). Let it re-use --txpkts option for specifying generated packet size. Signed-off-by: Maciej Czekaj --- app/test-pmd/config.c | 2 +-

[dpdk-dev] [PATCH] ntnic: add PMD driver

2016-08-26 Thread Finn Christensen
This is the Napatech NTNIC Poll Mode Driver (PMD) for DPDK. This patch adds support for Napatech NICs to DPDK. This is the inital implementation. Signed-off-by: Finn Christensen --- MAINTAINERS | 5 + config/common_base | 6 +

[dpdk-dev] [RFC PATCH v1] rte: add bit-rate metrics to xstats

2016-08-26 Thread Pattan, Reshma
Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton > Sent: Wednesday, August 24, 2016 3:58 PM > To: thomas.monjalon at 6wind.com > Cc: dev at dpdk.org > Subject: [dpdk-dev] [RFC PATCH v1] rte: add bit-rate metrics to xstats > > This patch adds

[dpdk-dev] [PATCH] crypto/qat: add Intel(R) QuickAssist C3xxx device

2016-08-26 Thread Deepak Kumar Jain
Signed-off-by: Deepak Kumar Jain --- doc/guides/cryptodevs/qat.rst | 71 -- drivers/crypto/qat/rte_qat_cryptodev.c | 3 ++ 2 files changed, 71 insertions(+), 3 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index

[dpdk-dev] [PATCH] kni: add support for older kernels

2016-08-26 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- lib/librte_eal/linuxapp/kni/compat.h| 13 + lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 13 + lib/librte_eal/linuxapp/kni/ethtool/ixgbe/kcompat.h | 12 3 files changed, 38 insertions(+) diff --git

[dpdk-dev] [PATCH] crypto/qat: add Intel(R) QuickAssist C3xxx device

2016-08-26 Thread Trahe, Fiona
-Original Message- From: Jain, Deepak K Sent: Friday, August 26, 2016 1:28 PM To: Trahe, Fiona ; Griffin, John ; De Lara Guarch, Pablo Cc: dev at dpdk.org; Jain, Deepak K Subject: [PATCH] crypto/qat: add Intel(R) QuickAssist C3xxx device Signed-off-by: Deepak Kumar Jain Acked-by:

[dpdk-dev] [PATCH v6 0/4] support reset of VF link

2016-08-26 Thread Luca Boccassi
On Mon, 2016-07-11 at 15:43 +, Luca Boccassi wrote: > On Mon, 2016-07-11 at 13:02 +0100, Luca Boccassi wrote: > > On Mon, 2016-07-11 at 01:32 +, Lu, Wenzhuo wrote: > > > > > > > > Unfortunately I found one issue: if PF is down, and then the VF on the > > > > guest is > > > > down as well

[dpdk-dev] [PATCH 22/22] net/pcap: fix checkpatch warnings

2016-08-26 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- drivers/net/pcap/rte_eth_pcap.c | 81 ++--- 1 file changed, 43 insertions(+), 38 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 782ee4d..35ea2cd 100644 ---

[dpdk-dev] [PATCH 21/22] net/pcap: remove rte prefix from static functions

2016-08-26 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- drivers/net/pcap/rte_eth_pcap.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 1716512..782ee4d 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++

[dpdk-dev] [PATCH 20/22] net/pcap: coding convention updates

2016-08-26 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- drivers/net/pcap/rte_eth_pcap.c | 64 - 1 file changed, 31 insertions(+), 33 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 5a2a194..1716512 100644 ---

[dpdk-dev] [PATCH 19/22] net/pcap: fix missing Tx iface assignment

2016-08-26 Thread Ferruh Yigit
Missing pcap assignment may cause pcap opened again, and previous one not closed at all. Fixes: 1e38a7c66923 ("pcap: fix storage of name and type in queues") Signed-off-by: Ferruh Yigit --- drivers/net/pcap/rte_eth_pcap.c | 1 + 1 file changed, 1 insertion(+) diff --git

[dpdk-dev] [PATCH 18/22] net/pcap: simplify function

2016-08-26 Thread Ferruh Yigit
simplify function rte_eth_from_pcaps_common by using interim variables. Signed-off-by: Ferruh Yigit --- drivers/net/pcap/rte_eth_pcap.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c

[dpdk-dev] [PATCH 17/22] net/pcap: remove redundant assignment

2016-08-26 Thread Ferruh Yigit
data->name assigned twice. Signed-off-by: Ferruh Yigit --- drivers/net/pcap/rte_eth_pcap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 0dd2dc5..0f9da4c 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++

[dpdk-dev] [PATCH 16/22] net/pcap: remove unnecessary check

2016-08-26 Thread Ferruh Yigit
Both fields are fields of same type of struct, one's size can't be bigger than others. Signed-off-by: Ferruh Yigit --- drivers/net/pcap/rte_eth_pcap.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 8b312a9..0dd2dc5

[dpdk-dev] [PATCH 15/22] net/pcap: update how single iface handled

2016-08-26 Thread Ferruh Yigit
Remove hardcoded single interface values, make it more obvious. Signed-off-by: Ferruh Yigit --- drivers/net/pcap/rte_eth_pcap.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index

[dpdk-dev] [PATCH 14/22] net/pcap: reorder functions

2016-08-26 Thread Ferruh Yigit
Reorder functions to be able to remove function declarations in .c file. Function definitions not modified. Signed-off-by: Ferruh Yigit --- drivers/net/pcap/rte_eth_pcap.c | 129 1 file changed, 64 insertions(+), 65 deletions(-) diff --git

[dpdk-dev] [PATCH 13/22] net/pcap: reorder header files

2016-08-26 Thread Ferruh Yigit
Remove unused and sort remaining. Signed-off-by: Ferruh Yigit --- drivers/net/pcap/rte_eth_pcap.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index bdc5a5e..57c8e57 100644 ---

[dpdk-dev] [PATCH 12/22] net/pcap: make const array static

2016-08-26 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- drivers/net/pcap/rte_eth_pcap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index f88a598..bdc5a5e 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++

[dpdk-dev] [PATCH 11/22] net/pcap: group stats related fields into a struct

2016-08-26 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- drivers/net/pcap/rte_eth_pcap.c | 72 + 1 file changed, 37 insertions(+), 35 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index b749af0..f88a598 100644 ---

[dpdk-dev] [PATCH 09/22] net/pcap: remove duplicated max queue number check

2016-08-26 Thread Ferruh Yigit
Remove duplicated check by reorganizing the code, no functional change. Signed-off-by: Ferruh Yigit --- drivers/net/pcap/rte_eth_pcap.c | 49 ++--- 1 file changed, 22 insertions(+), 27 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c

[dpdk-dev] [PATCH 08/22] net/pcap: move comment to correct place

2016-08-26 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- drivers/net/pcap/rte_eth_pcap.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 0135266..ff61d62 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++

[dpdk-dev] [PATCH 07/22] net/pcap: don't carry kvlist argument

2016-08-26 Thread Ferruh Yigit
Don't carry kvlist argument into sub function and used it, use kvlist argument in upper level of call stack. Signed-off-by: Ferruh Yigit --- drivers/net/pcap/rte_eth_pcap.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git

[dpdk-dev] [PATCH 06/22] net/pcap: don't carry numa_node argument

2016-08-26 Thread Ferruh Yigit
Instead of defining numa_node variable upper level of call stack and carry into sub function, set it where needs to be used. Signed-off-by: Ferruh Yigit --- drivers/net/pcap/rte_eth_pcap.c | 40 +--- 1 file changed, 17 insertions(+), 23 deletions(-) diff

  1   2   >