[PATCH v5] event/cnxk: add event vector adapter support

2025-06-13 Thread pbhagavatula
From: Pavan Nikhilesh Add event vector adapter support to CN20K event device. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Add depends on series tag. - Fix compilation. v3 Changes: - Rebase. - Fix errors from check-meson.py v4 Changes: - Rebase. v5 Changes: - Update documentation and

[PATCH] doc: fix missing feature matrix for event device

2025-06-13 Thread pbhagavatula
From: Pavan Nikhilesh Fix missing feature matrix addition for event device DMA and vector adapters. Fixes: 66a30a29387a ("eventdev/dma: introduce DMA adapter") Fixes: e12c3754da7a ("eventdev/vector: introduce event vector adapter") Signed-off-by: Pavan Nikhilesh --- .gitignore

Re: [PATCH] common/mlx5: fix dependency detection on Windows

2025-06-13 Thread Patrick Robb
Good catch David on this system having a partial install of mlx5dev header/library. NVIDIA guys, do any of you have a link to the current install procedure or package? If not I can probably find whatever is correct. Thanks. Either way we'll update devx on the Windows system Monday - thanks for yo

Re: [PATCH v3 3/3] drivers: enable drivers to be compiled with MSVC

2025-06-13 Thread Patrick Robb
Recheck-request: iol-compile-amd64-testing Just sending this recheck request to ensure that our reporting script is fixed and that it reports a FAIL instead of a WARN. Once that's done, we'll upgrade the meson version on the system and do another retest.

RE: [PATCH] test_bbdev: enable to be compiled on Windows

2025-06-13 Thread Chautru, Nicolas
> -Original Message- > From: Andre Muezerie > Sent: Thursday, June 12, 2025 8:25 AM > To: Chautru, Nicolas ; Dmitry Kozlyuk > ; Tyler Retzlaff > Cc: dev@dpdk.org; Andre Muezerie > Subject: [PATCH] test_bbdev: enable to be compiled on Windows > > This patch fixes a few issues which wer

[PATCH] buildtools: allow a different minimum meson version for Windows

2025-06-13 Thread Andre Muezerie
There is a minimum meson version specified in the DPDK meson project section, which has been documented. This string is parsed by buildtools\get-min-meson-version.py and this information is used by lab automation to install the corresponding meson package on the build machine. Turns out that the m

Re: 回复:[PATCH v1 10/17] net/nbl: bus/pci: introduce get_iova_mode for pci dev

2025-06-13 Thread Stephen Hemminger
On Fri, 13 Jun 2025 10:28:06 +0800 "Kyo.Liu" wrote: > Hello, Stephen: > Thanks for your review. This patch is particularly important for our NBL > driver because our coexistence implementation depends on it. > Unlike RDMA devices that support hardware page table translation, our > hardware req

Re: [PATCH v3 1/4] eal: deprecate old coremask-based EAL parameters

2025-06-13 Thread Bruce Richardson
On Fri, May 02, 2025 at 08:51:22AM -0700, Stephen Hemminger wrote: > On Fri, 2 May 2025 16:11:31 +0100 > Bruce Richardson wrote: > > > As the number of cores/cpus on platforms has increased over the years, > > the use of coremasks rather than core-lists for identifying DPDK cores > > has become

Re: [PATCH v5 0/3] lcore options cleanup

2025-06-13 Thread Bruce Richardson
On Tue, Jun 10, 2025 at 11:08:44AM +, Varghese, Vipin wrote: > [Public] > > Snipped > > > > > Caution: This message originated from an External Source. Use proper caution > > when opening attachments, clicking links, or responding. > > > > > > 27/05/2025 17:29, Bruce Richardson: > > > This pa

Re: [PATCH v7 00/33] Intel PMD drivers Rx cleanup

2025-06-13 Thread Bruce Richardson
On Thu, Jun 12, 2025 at 12:11:06PM +0100, Anatoly Burakov wrote: > There is certain amount of duplication between different ixgbe, i40e, ice, and > iavf. This patchset specifically focuses on laying groundwork for > deduplicating > the Rx side of things - providing common queue definitions, using

RE: [PATCH 0/2] Latencystat optimization and fix

2025-06-13 Thread Varghese, Vipin
[Public] > -Original Message- > From: Stephen Hemminger > Sent: Friday, June 13, 2025 6:04 AM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [PATCH 0/2] Latencystat optimization and fix > > Caution: This message originated from an External Source. Use proper caution > when opening

[dpdk-dev v1] app/test-crypto-perf: remove unsupported test cases from perf json

2025-06-13 Thread Kai Ji
Remove all unsupported test cases in json files Signed-off-by: Kai Ji --- .../configs/crypto-perf-aesni-gcm.json| 29 --- .../configs/crypto-perf-aesni-mb.json | 7 --- .../configs/crypto-perf-qat.json | 51 ++- 3 files changed, 16 insertions

Proposal: AI-Based Code Review for DPDK

2025-06-13 Thread Jerin Jacob
Goals --- # Leverage modern AI-powered code review tools to accelerate and supplement human review efforts. # Prevent AI-generated comments from cluttering the mailing list or polluting the main DPDK GitHub repository. Setup --- # Create a dedicated repository: Set up a new repositor

Re: [PATCH v2] eal: handle sysconf(_SC_PAGESIZE) negative return value

2025-06-13 Thread Burakov, Anatoly
On 6/12/2025 4:06 PM, Morten Brørup wrote: eal: handle sysconf(_SC_PAGESIZE) negative return value Coverity reports some defects, where the root cause seems to be negative return value from sysconf(_SC_PAGESIZE) not being handled. rte_mem_page_size() was updated to handle negative return value

Minutes of Technical Board Meeting, 2025-June-11

2025-06-13 Thread Kevin Traynor
Minutes of Technical Board Meeting, 2025-June-11 Members Attending - -Aaron -Bruce -Jerin -Kevin -Morten -Stephen -Thomas NOTE: The technical board meetings every second Wednesday at https://zoom-lfx.platform.linuxfoundation.org/meeting/96459488340?password=d808f1f6-0a28-4165-929e

Re: [PATCH] common/mlx5: fix dependency detection on Windows

2025-06-13 Thread David Marchand
On Fri, Jun 13, 2025 at 10:10 AM David Marchand wrote: > > Don't *require* mlx5dev library when testing its presence. For the record, this was seen in a UNH env that seems to have partially installed mlx5 dependencies. Has header "mlx5devx.h" : YES drivers\common\mlx5\windows\meson.build:10:0: E

[PATCH v3 14/17] net/ngbe: fix incorrect device statistics

2025-06-13 Thread Jiawen Wu
The extend statistic "rx_undersize_errors" is incorrectly read as the counter of frames received with a length error, which names "rx_length_error". And "rx_undersize_errors" is the counter of shorter-than-64B frames received without any errors. In addition, "tx_broadcast_packets" should use rd64(

[PATCH v3 12/17] net/ngbe: fix MAC control frame forwarding

2025-06-13 Thread Jiawen Wu
Test failure on the case "test_pause_fwd_port_stop_start", which expect MAC control frame forwarding setting still working after port stop/start. Fix the bug to pass the test case. Fixes: f40e9f0e2278 ("net/ngbe: support flow control") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/ne

[PATCH v3 17/17] net/txgbe: add missing LRO flag in mbuf when LRO enabled

2025-06-13 Thread Jiawen Wu
When LRO is enabled, the driver must set the LRO flag in received aggregated packets to indicate LRO processing to upper-layer applications. Add the missing LRO flag into the ol_flags field of mbuf to fix it. Fixes: 0e484278c85f ("net/txgbe: support Rx") Cc: sta...@dpdk.org Signed-off-by: Jiawen

[PATCH v3 16/17] net/ngbe: restrict VLAN strip configuration on VF

2025-06-13 Thread Jiawen Wu
Fix the same issue as PF in commit baca8ec066dc ("net/ngbe: restrict configuration of VLAN strip offload"). There is a hardware limitation that Rx ring config register is not writable when Rx ring is enabled, i.e. the TXGBE_RXCFG_ENA bit is set. But disabling the ring when there is traffic will ca

[PATCH v3 15/17] net/txgbe: restrict VLAN strip configuration on VF

2025-06-13 Thread Jiawen Wu
Fix the same issue as PF in commit 66364efcf958 ("net/txgbe: restrict configuration of VLAN strip offload"). There is a hardware limitation that Rx ring config register is not writable when Rx ring is enabled, i.e. the TXGBE_RXCFG_ENA bit is set. But disabling the ring when there is traffic will c

[PATCH v3 13/17] net/txgbe: fix incorrect device statistics

2025-06-13 Thread Jiawen Wu
The extend statistic "rx_undersize_errors" is incorrectly read as the counter of frames received with a length error, which names "rx_length_error". And "rx_undersize_errors" is the counter of shorter-than-64B frames received without any errors. In addition, "tx_broadcast_packets" should use rd64(

[PATCH v3 11/17] net/txgbe: fix MAC control frame forwarding

2025-06-13 Thread Jiawen Wu
Test Failure on the case "test_pause_fwd_port_stop_start", which expect MAC control frame forwarding setting still working after port stop/start. Fix the bug to pass the test case. Fixes: 69ce8c8a4ce3 ("net/txgbe: support flow control") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/n

[PATCH v3 10/17] net/ngbe: support RSS offload for SCTP port

2025-06-13 Thread Jiawen Wu
Add support for IPv4/IPv6 SCTP RSS offload. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_regs.h | 2 ++ drivers/net/ngbe/ngbe_ethdev.h| 2 ++ drivers/net/ngbe/ngbe_rxtx.c | 8 3 files changed, 12 insertions(+) diff --git a/drivers/net/ngbe/base/ngbe_regs.h b/driver

[PATCH v3 09/17] net/txgbe: support RSS offload for SCTP port

2025-06-13 Thread Jiawen Wu
Add support for IPv4/IPv6 SCTP RSS offload. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_regs.h | 4 drivers/net/txgbe/txgbe_ethdev.h| 2 ++ drivers/net/txgbe/txgbe_rxtx.c | 16 3 files changed, 22 insertions(+) diff --git a/drivers/net/txgbe/base/t

[PATCH v3 04/17] net/txgbe: fix packet type for FDIR filters

2025-06-13 Thread Jiawen Wu
To match the packet type more flexibly when the pattern is default, add packet type mask for FDIR filters. Fixes: b973ee26747a ("net/txgbe: parse flow director filter") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_type.h | 20 +-- drivers/net/txgbe/txgbe_ethdev

[PATCH v3 05/17] net/txgbe: fix to create FDIR filters for SCTP packets

2025-06-13 Thread Jiawen Wu
The check for the mask of SCTP item is repeated and wrong, fix it to make it work. Fixes: b973ee26747a ("net/txgbe: parse flow director filter") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_flow.c | 13 - 1 file changed, 13 deletions(-) diff --git a/driv

[PATCH v3 07/17] net/txgbe: fix to create FDIR filters for tunnel packets

2025-06-13 Thread Jiawen Wu
Fix to create FDIR rules for VXLAN/GRE/NVGRE/GENEVE packets, they will match the rules in the inner layers. Fixes: b973ee26747a ("net/txgbe: parse flow director filter") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 2 + drivers/net/txgbe/txgbe_ethdev.h

[PATCH v3 08/17] net/txgbe: fix reserved extra FDIR headroom

2025-06-13 Thread Jiawen Wu
Remove redundant 256KB FDIR headroom reservation. FDIR headroom was already allocated in txgbe_fdir_configure() when FDIR is enabled, the second reservation resulted in 256KB less available RX packet buffer than the theoretical size. Fixes: 8bdc7882f376 ("net/txgbe: support DCB") Cc: sta...@dpdk.o

[PATCH v3 06/17] net/txgbe: fix FDIR perfect mode for IPv6 packets

2025-06-13 Thread Jiawen Wu
Perfect mode of FDIR rules to filter IPv6 packets is supported by hardware. Remove the restriction and fix the setting. Fixes: b973ee26747a ("net/txgbe: parse flow director filter") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_fdir.c | 22 -- driv

[PATCH v3 02/17] net/txgbe: fix incorrect parsing to ntuple filter

2025-06-13 Thread Jiawen Wu
The rule is incorrectly parsed to ntuple filter when setting the pattern likes: flow create ... ipv4 / udp dst is ... / raw ... / end actions ... / end It causes the rule to be created successfully, but not works. Fix it to parse for FDIR rules. Fixes: b7eeecb17556 ("net/txgbe: parse n-tuple filt

[PATCH v3 03/17] net/txgbe: fix raw pattern match for FDIR rules

2025-06-13 Thread Jiawen Wu
The raw patthern is required to be two hex bytes on hardware, but it is string in the raw item. So the length of raw spec should be 4, and the string should be converted to the two hex bytes. And relative of raw spec is supported to be optical. Fixes: b973ee26747a ("net/txgbe: parse flow director

[PATCH v3 01/17] net/txgbe: support flow filter for VF

2025-06-13 Thread Jiawen Wu
Add 5-tuple filter for VF driver, which request PF driver to write the hardware configurations. So add new PF-VF mailbox API version 2.1 to implement it. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 10 drivers/net/txgbe/base/txgbe_hw.h | 1 + drivers/net/txgbe/base

[PATCH v3 00/17] Fixes and supports for Wangxun NICs

2025-06-13 Thread Jiawen Wu
Fix some bugs and improve flow filters. v2 -> v3: - Split the patch 2/12 for various changes v1 -> v2: - Add new flow feature geneve and gre into txgbe.ini Jiawen Wu (17): net/txgbe: support flow filter for VF net/txgbe: fix incorrect parsing to ntuple filter net/txgbe: fix raw pattern mat

Minutes of Technical Board Meeting, 2025-May-28

2025-06-13 Thread Jerin Jacob
Minutes of Technical Board Meeting, 2025-May-28   Members Attending - -Aaron -Bruce -Hemant -Jerin -Kevin (Next Chair) -Konstantin -Maxime -Morten -Stephen -Thomas      NOTE: The technical board meetings every second Wednesday at https://zoom-lfx.platform.linuxfoundation.org/mee

[PATCH] common/mlx5: fix dependency detection on Windows

2025-06-13 Thread David Marchand
Don't *require* mlx5dev library when testing its presence. Fixes: 85c51a4ffab8 ("common/mlx5: get Windows dependency from standard variables") Signed-off-by: David Marchand --- drivers/common/mlx5/windows/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/c

Re: [PATCH] net/virtio: Fix check of threshold for Tx freeing

2025-06-13 Thread Maxime Coquelin
On 6/9/25 9:23 AM, Hengqi Chen wrote: Like most dirvers, make the fast path of virtio_xmit_cleanup() behave as described by the comments of rte_eth_txconf::tx_free_thresh ([0]): Start freeing Tx buffers if there are less free descriptors than this value. The rationale behind this ch

Re: [PATCH] vhost: fix net control virtqueue used length

2025-06-13 Thread Maxime Coquelin
On 6/5/25 1:35 PM, Eugenio Pérez wrote: By the standard this is the number of bytes written. Fixes: 474f4d7840ad ("vhost: add control virtqueue") Cc: sta...@dpdk.org Signed-off-by: Eugenio Pérez --- lib/vhost/virtio_net_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [PATCH 2/2] vhost: search the packed vq driver area in RO areas

2025-06-13 Thread Maxime Coquelin
On 6/5/25 1:35 PM, Eugenio Pérez wrote: QEMU's shadow virtqueue and VDUSE exposes this as read-only. If we don't change it, vhost_iova_to_vva do not consider them as valid and returns that they're not found. Fixes: 2d1541e2b6b3 ("vhost: add vring address setup for packed queues") Cc: sta...@d

Re: [PATCH 0/2] Search the split vq desc and avail in RO areas

2025-06-13 Thread Maxime Coquelin
On 6/5/25 1:35 PM, Eugenio Pérez wrote: QEMU's shadow virtqueue and VDUSE exposes these areas as read-only. If we don't change it, vhost_iova_to_vva do not consider them as valid and returns that they're not found. Eugenio Pérez (2): vhost: search the split vq desc and avail in RO areas

Re: [PATCH v1 10/17] net/nbl: bus/pci: introduce get_iova_mode for pci dev

2025-06-13 Thread David Marchand
On Fri, Jun 13, 2025 at 4:28 AM Kyo.Liu wrote: > > Hello, Stephen: > Thanks for your review. This patch is particularly important for > our NBL driver because our coexistence implementation depends on it. "important" is different from "required". It seems safer to plan for an integrati