[dpdk-dev] [PATCH v6 3/4] app/test: added tests for libcrypto PMD

2016-10-06 Thread Azarewicz, PiotrX T
Hi Fiona, > This patch breaks autotests for all PMDs, due to increasing the MBUF size to > UNIT16_MAX. > USER1: Can't create CRYPTO_MBUFPOOL > > It needs more than 500MBs in the MBUFPOOL to run this test. > Setting this back to MBUF_SIZE fixes the issue, but breaks 2 tests in >

[dpdk-dev] [PATCH] mk: fix static link with glibc < 2.17

2016-07-26 Thread Azarewicz, PiotrX T
> > > The problem is that -lrt appears before -lrte_eal. > > > The question is: where does it come from? > > > It is even before _LDLIBS-y += -L$(RTE_SDK_BIN)/lib... mystery > > > > root cause: > > commit c7cda4d8b4ea9cb0f209dda36882d225354b1db9 > > The error is seen after this commit, yes.

[dpdk-dev] [PATCH] mk: fix static link with glibc < 2.17

2016-07-25 Thread Azarewicz, PiotrX T
> The problem is that -lrt appears before -lrte_eal. > The question is: where does it come from? > It is even before _LDLIBS-y += -L$(RTE_SDK_BIN)/lib... mystery root cause: commit c7cda4d8b4ea9cb0f209dda36882d225354b1db9 and my workaround is: /app/test/Makefile ifeq

[dpdk-dev] [PATCH] mk: fix static link with glibc < 2.17

2016-07-22 Thread Azarewicz, PiotrX T
> > > > > > Tested-by: Yongjie Gu > > > > > > > > > > Applied > > > > > > > > OS: UB1204 > > > > GCC: 4.6.4 > > > > Kernel: 3.13.0-45 > > > > glibc 2.15 > > > > > > > > x86_64-native-linuxapp-gcc: FAIL > > > > > > Please don't be a bot and explain us the error you see. > > > > I was trying rc3 +

[dpdk-dev] [PATCH] mk: fix static link with glibc < 2.17

2016-07-22 Thread Azarewicz, PiotrX T
> > > > Tested-by: Yongjie Gu > > > > > > Applied > > > > OS: UB1204 > > GCC: 4.6.4 > > Kernel: 3.13.0-45 > > glibc 2.15 > > > > x86_64-native-linuxapp-gcc: FAIL > > Please don't be a bot and explain us the error you see. I was trying rc3 + fix and latest (today) dpdk version. The same fail

[dpdk-dev] [PATCH] mk: fix static link with glibc < 2.17

2016-07-22 Thread Azarewicz, PiotrX T
> > Tested-by: Yongjie Gu > > Applied OS: UB1204 GCC: 4.6.4 Kernel: 3.13.0-45 glibc 2.15 x86_64-native-linuxapp-gcc: FAIL

[dpdk-dev] [PATCH v1 1/1] examples/bond: fix unchecked return value

2016-06-30 Thread Azarewicz, PiotrX T
> The example is calling rte_eal_wait_lcore without checking return value. > Now it is fixed by checking the value and print proper message. > > Coverity issue: 37789 > Coverity issue: 37790 > Fixes: cc7e8ae84faa ("examples/bond: add example application for link > bonding mode 6") > >

[dpdk-dev] [PATCH v3] i40e: fix olflags for vector Rx

2016-06-14 Thread Azarewicz, PiotrX T
> Problem: > The flag for RSS and flow director is not set correctly in the vector Rx > function, so the upper layer APP which base on the related flags will not work > correctly. > > Fix this problem by change the shuffle table. the original shuffle table is > not > correct. > > Fixes:

[dpdk-dev] [PATCH v2] i40e: fix olflags for vector RX

2016-06-13 Thread Azarewicz, PiotrX T
> Problem: > The flag for RSS and flow director is not set correctly in the vector RX > function, so the upper layer APP which base on the related flags will not work > correctly. > > Fix this problem by change the shuffle table. the original shuffle table is > not > correct. > > Fixes: 9ed94

[dpdk-dev] [PATCH v2 0/7] examples/ip_pipeline: CLI rework and improvements

2016-06-08 Thread Azarewicz, PiotrX T
> > Piotr Azarewicz (7): > > examples/ip_pipeline: add helper functions for parsing string > > examples/ip_pipeline: modifies common pipeline CLI > > examples/ip_pipeline: modifies firewall pipeline CLI > > examples/ip_pipeline: modifies flow classifications pipeline CLI > >

[dpdk-dev] [PATCH v1 1/1] examples/l2fwd-crypto: improve random key generator

2016-06-08 Thread Azarewicz, PiotrX T
> 2016-05-25 15:34, Piotr Azarewicz: > > This patch improve generate_random_key() function by replacing rand() > > function with reading from /dev/urandom. > > > > CID 120136 : Calling risky function (DC.WEAK_CRYPTO) > > dont_call: rand should not be used for security related applications, > > as

[dpdk-dev] [PATCH v3 12/13] enic: expand local Tx mbuf flags variable to 64-bits

2016-06-03 Thread Azarewicz, PiotrX T
> Coverity issue: 13218 > Fixes: fefed3d1e62c ("enic: new driver") > > Suggested-by: Piotr Azarewicz > Signed-off-by: John Daley > --- > This is essentially patch http://www.dpdk.org/dev/patchwork/patch/12642 > applied after the enic_send_packet function was melded into the main > transmit

[dpdk-dev] [PATCH v2 09/11] enic: optimize the Tx function

2016-05-30 Thread Azarewicz, PiotrX T
Hi, > uint16_t enic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, > uint16_t nb_pkts) > { > uint16_t index; > - unsigned int frags; > - unsigned int pkt_len; > - unsigned int seg_len; > - unsigned int inc_len; > + unsigned int pkt_len, data_len; >

[dpdk-dev] [PATCH] lpm: unchecked return value

2016-05-12 Thread Azarewicz, PiotrX T
Hi, I handle Coverity defect ID 13201. It is about unchecked return value from rte_lpm6_delete() instances in rte_lpm6_add() function. Next I found this thread and I see that both defects (ID 13205 and ID 13201) may be resolved all together. > >> Fix issue reported by Coverity. > >> > >>

[dpdk-dev] [PATCH v2 1/1] cmdline: add any multi string mode to token string

2016-04-29 Thread Azarewicz, PiotrX T
> But I agree that a comment could be added above the definition of > TOKEN_STRING_MULTI that would explain what is the behavior in that case. > > Piotr, do you think this is something you can do? Okay, I will. Regards, Piotr

[dpdk-dev] [PATCH] doc: announce ABI change for rte_port_source_params structure

2016-04-06 Thread Azarewicz, PiotrX T
> > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Fan Zhang > > Sent: Thursday, March 31, 2016 2:29 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH] doc: announce ABI change for > > rte_port_source_params structure > > > > Several new fields will

[dpdk-dev] [PATCH v1 1/1] cmdline: add any multi string mode to token string

2016-04-05 Thread Azarewicz, PiotrX T
Hi Olivier, > -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Monday, April 4, 2016 5:58 PM > >> Using token_len + 1 as the buffer size in the snprintf looks a bit > >> dangerous, as it won't protect from overflows. > >> > >> See the following example: >

[dpdk-dev] [PATCH v1 1/1] cmdline: add any multi string mode to token string

2016-04-04 Thread Azarewicz, PiotrX T
Hi Olivier, > -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Monday, April 4, 2016 10:01 AM > To: Azarewicz, PiotrX T > Cc: dev at dpdk.org > Subject: Re: [PATCH v1 1/1] cmdline: add any multi string mode to token >

[dpdk-dev] [PATCH v3 1/1] examples/l3fwd: modify and modularize l3fwd code

2016-02-24 Thread Azarewicz, PiotrX T
> > Hi, > > When compiling for i686, there are some errors: > > 2016-02-18 10:08, Piotr Azarewicz: > > + printf("Hash: Adding 0x%" PRIx64 " keys\n", > IPV4_L3FWD_EM_NUM_ROUTES); > [...] > > + printf("Hash: Adding 0x%" PRIx64 "keys\n", > IPV6_L3FWD_EM_NUM_ROUTES); > >

[dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy issue

2015-12-09 Thread Azarewicz, PiotrX T
> -Original Message- > From: Mcnamara, John > Sent: Tuesday, December 8, 2015 6:00 PM > To: Mcnamara, John ; Azarewicz, PiotrX T > ; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy > issue > > > -Original Message-

[dpdk-dev] [PATCH v2 5/5] doc: modify release notes and deprecation notice for table and pipeline

2015-10-12 Thread Azarewicz, PiotrX T
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, October 12, 2015 10:23 AM > To: Azarewicz, PiotrX T > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 5/5] doc: modify release notes and > deprecation notice f

[dpdk-dev] [PATCH v2 2/5] pipeline: added bulk add/delete functions for table

2015-10-12 Thread Azarewicz, PiotrX T
Hi Thomas, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, October 8, 2015 1:42 PM > To: Gajdzica, MaciejX T > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 2/5] pipeline: added bulk add/delete > functions for

[dpdk-dev] [PATCH v2 5/5] doc: modify release notes and deprecation notice for table and pipeline

2015-10-12 Thread Azarewicz, PiotrX T
Hi Thomas, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, October 8, 2015 1:42 PM > To: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 5/5] doc: modify release notes and > deprecation notice for table and pipeline > >

[dpdk-dev] [PATCH] doc: ip_pipeline app user guide

2015-08-06 Thread Azarewicz, PiotrX T
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cristian Dumitrescu > Sent: Thursday, August 6, 2015 3:48 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] doc: ip_pipeline app user guide > > Added more extensive documentation for ip_pipeline