Re: [PATCH] raw/cnxk_bphy: switch to dynamic logging

elftest(uint16_t dev_id) > goto err_desc; > if (descs != 1) { > ret = -ENODEV; > - plt_err("Wrong number of descs reported\n"); > + BPHY_LOG(ERR, "Wrong number of descs reported\n"); I think it is the only occurence in this patch, please remove trailing \n since BPHY_LOG appends one. Thanks. -- David Marchand

[PATCH 5/5] doc: use ordered lists

Prefer automatically ordered lists by using #. Signed-off-by: David Marchand --- doc/guides/eventdevs/dlb2.rst | 29 ++- doc/guides/eventdevs/dpaa.rst | 2 +- .../linux_gsg/nic_perf_intel_platform.rst | 10 ++-- doc/guides/nics/cnxk.rst

[PATCH 4/5] doc: remove number of commands in vDPA guide

There are now 5 supported commands. Fixes: 6505865aa8ed ("examples/vdpa: add statistics show command") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- doc/guides/sample_app_ug/vdpa.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/doc/guides/sample_app_u

[PATCH 3/5] doc: fix some ordered lists

grammer's guide") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- doc/guides/nics/mlx5.rst | 21 +-- doc/guides/nics/virtio.rst| 12 +++ doc/guides/platform/cnxk.rst | 3 +++ .../generic_segment

[PATCH 2/5] doc: enhance readability in memif example commands

'#.' is a token for ordered lists in RST. Add a space in those example commands. Signed-off-by: David Marchand --- doc/guides/nics/memif.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/guides/nics/memif.rst b/doc/guides/nics/memif.rst index

[PATCH 1/5] doc: remove restriction on ixgbe vector support

The ixgbe driver has vector support for different architectures for a while now. Fixes: b20971b6cca0 ("net/ixgbe: implement vector driver for ARM") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- doc/guides/nics/ixgbe.rst | 2 -- 1 file changed, 2 deletions(-) diff --git a/

[PATCH 0/5] Some documentation fixes

Not urgent for the release (especially the last patch which is scary by its size) but here are some cleanups in the documentation. -- David Marchand David Marchand (5): doc: remove restriction on ixgbe vector support doc: enhance readability in memif example commands doc: fix some

[PATCH 2/2] devtools: remove ABI exception for crypto asym operations

Those API are now stable. Fixes: 79a4c2cda131 ("cryptodev: promote some functions as stable") Signed-off-by: David Marchand --- devtools/libabigail.abignore | 7 --- 1 file changed, 7 deletions(-) diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore index

[PATCH 1/2] devtools: remove ABI exception for baseband FFT

Those API are now stable. Fixes: c96b519bd1c3 ("bbdev: promote some functions as stable") Signed-off-by: David Marchand --- devtools/libabigail.abignore | 4 1 file changed, 4 deletions(-) diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore index

Re: [PATCH] eal/windows: fix memory management macros usage

. > > Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management") > Cc: sta...@dpdk.org > > Signed-off-by: Gregory Etelson Acked-by: Tyler Retzlaff Acked-by: Dmitry Kozlyuk Acked-by: Thomas Monjalon For the record, the same issue has been reported with Ubuntu 23.10. Applied, thanks. -- David Marchand

Re: [PATCH] build: riscv is not a valid -march value

On Wed, Nov 22, 2023 at 5:17 PM Bruce Richardson wrote: > > On Wed, Nov 22, 2023 at 05:02:56PM +0100, David Marchand wrote: > > On Tue, Nov 21, 2023 at 5:49 PM wrote: > > > > > > From: Christian Ehrhardt > > > > > > If building riscv nat

Re: [PATCH] build: riscv is not a valid -march value

nfig: verify machine arch flag") > Fixes: f22e705ebf12 ("eal/riscv: support RISC-V architecture") > > Signed-off-by: Christian Ehrhardt Acked-by: Sivaprasad Tummala Applied, thanks. -- David Marchand

Re: [PATCH] eal/windows: fix mingw build

ement basic memory management") > Cc: dmitry.kozl...@gmail.com > Cc: sta...@dpdk.org > > Signed-off-by: Bruce Richardson Probably a duplicate of https://patchwork.dpdk.org/project/dpdk/patch/20231114170529.176665-1-getel...@nvidia.com/ -- David Marchand

Re: [PATCH] build: riscv is not a valid -march value

ete fix would be to set this here to generic. And do the march validation in config/riscv/meson.build in a similar fashion to ARM. Or maybe the validation added in b7676fcccab4 ("config: verify machine arch flag") should be moved after subdir(arch_subdir). Bruce, opinion? -- David Marchand

Re: [PATCH] examples/ipsec-secgw: fix cmp_sa_key bug

No need to send 5 mails for the same patch. All 5 were blocked, waiting in the moderation queue because you did not register to the dev@ mailing list. In the future, and before sending new revisions, please have a look at: https://doc.dpdk.org/guides/contributing/patches.html Thanks. -- David Marchand

Re: [RFC 0/3] Detect superfluous newline in logs

On Fri, Nov 17, 2023 at 3:11 PM Bruce Richardson wrote: > > On Fri, Nov 17, 2023 at 02:48:25PM +0100, David Marchand wrote: > > On Fri, Nov 17, 2023 at 2:27 PM Bruce Richardson > > wrote: > > > > > > On Fri, Nov 17, 2023 at 02:18:21PM +0100, David Marchand

Re: [RFC 0/3] Detect superfluous newline in logs

On Fri, Nov 17, 2023 at 2:47 PM Morten Brørup wrote: > > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Friday, 17 November 2023 14.18 > > > > Getting readable and consistent logs is important when running a DPDK > > application, especially w

Re: [RFC 0/3] Detect superfluous newline in logs

On Fri, Nov 17, 2023 at 2:27 PM Bruce Richardson wrote: > > On Fri, Nov 17, 2023 at 02:18:21PM +0100, David Marchand wrote: > > Getting readable and consistent logs is important when running a DPDK > > application, especially when troubleshooting. > > A common issue

[RFC 3/3] lib: use per line logging

Use RTE_LOG_LINE in existing macros that append a \n. Signed-off-by: David Marchand --- lib/bbdev/rte_bbdev.c | 3 ++- lib/cfgfile/rte_cfgfile.c | 4 ++-- lib/compressdev/rte_compressdev_internal.h | 5 +++-- lib/cryptodev/rte_cryptodev.h

[RFC 2/3] log: add a per line log helper

gcc builtin __builtin_strchr can be used as a static assertion to check whether passed format strings contain a \n. This can be useful to detect double \n in log messages. Signed-off-by: David Marchand --- lib/log/rte_log.h | 21 + 1 file changed, 21 insertions(+) diff

[RFC 1/3] lib: remove redundant newline from logs

Fix places where two newline characters may be logged. Also fix some direct calls to printf or RTE_LOG when a dedicated log helper for a library existed. Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 2 +- lib/bbdev/rte_bbdev.c

[RFC 0/3] Detect superfluous newline in logs

: splitting it into per library commits with correct Fixes: tags is a tedious work. I would split it for a non RFC series. For now, it is enough to show case the idea. - the last patch shows how an existing log macro is converted, -- David Marchand David Marchand (3): lib: remove redundant

Re: [PATCH v12 02/16] baseband/acc100: refactor to segregate common code

UFFIX(acc100_logtype, acc100, NOTICE); # mapped to pmd.bb.acc.acc100 RTE_LOG_REGISTER_SUFFIX(vrb_logtype, vrb, NOTICE); # mapped to pmd.bb.acc.vrb RTE_LOG_REGISTER_SUFFIX(acc_common_logtype, common, NOTICE); # mapped to pmd.bb.acc.common -- David Marchand

[PATCH v5 2/2] devtools: list symbols by version

EXPERIMENTAL rte_dev_hotplug_handle_enable Signed-off-by: David Marchand Acked-by: Stephen Hemminger --- buildtools/map-list-symbol.sh | 39 ++- 1 file changed, 25 insertions(+), 14 deletions(-) diff --git a/buildtools/map-list-symbol.sh b/buildtools/map-list

[PATCH v5 1/2] devtools: add check on symbol maps format

Add a check on symbol maps format. This will be required by a next commit. Signed-off-by: David Marchand --- Changes since v4: - rebased, - handled next abi version in the check, Changes since v3: - fixed Alpine build (same issue with { in awk expression than commit e1ab26df4862 ("build

Re: [PATCH v2 00/14] eal: mark older API's as stable

| 21 > lib/eal/include/rte_service.h | 1 - > lib/eal/include/rte_version.h | 6 -- > lib/eal/version.map | 96 --- > lib/eal/x86/include/rte_atomic_64.h | 1 - > 19 files changed, 38 insertions(+), 277 deletions(-) Series applied. Thanks. -- David Marchand

Re: [PATCH v7 00/25] Promote 22.11 and older API's to stable

s do keep the experimental tag for good reasons. The topic of such a rule is to be discussed in a later techboard meeting. In any case, there is enough acks on this series. I fixed the lib/node patch, sorted version.map files content and removed inclusion of rte_compat as I had requested in a previo

Re: [PATCH] graph: mark API's as stable

> > > > > Signed-off-by: Stephen Hemminger > > Acked-by: Jerin Jacob > Acked-by: Zhirun Yan Applied, thanks. -- David Marchand

Re: [PATCH v2] vhost: make experimental API's stable

d-off-by: Maxime Coquelin I have one comment below, but this can probably be fixed when applying. Reviewed-by: David Marchand > diff --git a/lib/vhost/rte_vhost_crypto.h b/lib/vhost/rte_vhost_crypto.h > index 2b01ecda08..71a30ba202 100644 > --- a/lib/vhost/rte_vhost_crypto.h > +++ b

Re: [PATCH v7 23/25] node: remove some of the experimental tags

to remove rte_node_logtype from version.map. This can be fixed when applying. > > Signed-off-by: Stephen Hemminger -- David Marchand

Re: [PATCH v7 0/9] document and simplify use of cmdline

he new script is used when building examples out of dpdk tree, - the examples/bond patch contained a change belonging to a previous patch, - some meson.build updates contained tabs, - the documentation and the new script were not referenced in the MAINTAINERS file, - the cmdline documentation used explicitly numbered items while the coding style for the doc recommends use of #., For the series, Acked-by: David Marchand Series applied, thanks for this nice cleanup/improvement. -- David Marchand

Re: [PATCH v7 1/2] bus/pci: support PASID control

*/ -#define RTE_PCI_EXT_CAP_ID_PASID 0x1B/* Process Address Space ID */ +#define RTE_PCI_EXT_CAP_ID_PASID 0x1b/* Process Address Space ID */ /* Advanced Error Reporting (RTE_PCI_EXT_CAP_ID_ERR) */ #define RTE_PCI_ERR_UNCOR_STATUS 0x04/* Uncorrectable Error Status */ -- David Marchand

Re: [PATCH v2] lpm: improve performance with copious IPv4 peering routes

++ > lib/lpm/rte_lpm.h | 6 + Seeing how no other .c is touched and no exposed symbol use it, exposing the rte_lpm_rule_key structure in the public API is unneeded. > 2 files changed, 149 insertions(+), 163 deletions(-) -- David Marchand

Re: [PATCH v7 1/2] bus/pci: support PASID control

nabled by default, which * breaks the DLB if enabled. */ - off = DLB2_PCI_PASID_CAP_OFFSET + RTE_PCI_PASID_CTRL; - if (rte_pci_pasid_set_state(pdev, off, false)) { + if (rte_pci_pasid_set_state(pdev, false)) { DLB2_LOG_ERR("[%s()] failed to write the pcie config space at offset %d\n", __func__, (int)off); return -1; -- David Marchand

Re: [PATCH v5 1/1] build: add libarchive to external deps

On Mon, Nov 6, 2023 at 5:24 PM Bruce Richardson wrote: > > On Mon, Nov 06, 2023 at 05:03:10PM +0100, David Marchand wrote: > > On Mon, Nov 6, 2023 at 5:12 AM Srikanth Yalavarthi > > wrote: > > > > > > In order to avoid linking with Libs.private, libarchive i

Re: [PATCH v5 1/1] build: add libarchive to external deps

This breaks static compilation of applications. This can be reproduced with test-meson-builds.sh and in GHA (which was not linking examples statically, I added a patch in my github repo): https://github.com/david-marchand/dpdk/actions/runs/6772879600/job/18406442129#step:19:19572 -- David Marchand

Re: [PATCH v2 0/2] make dpdk buildable with latest msvc

rd c atomics support check for MSVC > > config/meson.build | 5 + > lib/eal/include/rte_stdatomic.h | 2 ++ > 2 files changed, 7 insertions(+) > Series applied, thanks. -- David Marchand

Re: [PATCH v3 00/19] use rte optional stdatomic API

18 ++--- > lib/timer/rte_timer.c | 50 +++--- > lib/timer/rte_timer.h | 6 +- > lib/vhost/vdpa.c | 3 +- > lib/vhost/vhost.c | 42 ++-- > lib/vhost/vhost.h | 39 ++- > lib/vhost/vhost_user.c | 6 +- > lib/vhost/virtio_net.c | 58 +--- > lib/vhost/virtio_net_ctrl.c| 6 +- > 65 files changed, 684 insertions(+), 653 deletions(-) > Series applied, thanks. -- David Marchand

Re: [PATCH] maintainers: update ena maintainers list

Evgeny Schemeilin > -M: Igor Chauskin > M: Ron Beider > +M: Amit Bernstein > +M: Wajeeh Atrash > F: drivers/net/ena/ > F: doc/guides/nics/ena.rst > F: doc/guides/nics/features/ena.ini Amit, Wejaeeh, please register to the dev@ mailing list. Thanks. -- David Marchand

[PATCH] net/af_xdp: avoid error log for virtual interfaces

e=ovs-tap1' attached to DPDK Avoid this error by checking if the sysfs file exists, like what is done in DPDK bus drivers using eal_parse_sysfs_value(). Fixes: 3d28387cbc48 ("net/af_xdp: parse NUMA node ID from sysfs") Signed-off-by: David Marchand --- drivers/net/af_xdp/rte_et

Re: [PATCH 2/3] vhost: fix virtqueue access lock in datapath

>access_ok) > > + vring_translate(dev, vq); > > + vhost_user_iotlb_rd_unlock(vq); > > + rte_rwlock_write_unlock(&vq->access_lock); > > +} > > + -- David Marchand

Re: [PATCH] eal/unix: lower log level for reading files

On Fri, Oct 27, 2023 at 11:00 AM Morten Brørup wrote: > > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Friday, 27 October 2023 10.01 > > > > The eal_parse_sysfs_value helper both returns an error code and logs an > > error level message

[PATCH] mem: explicitly initialise shared locks

Monjalon Signed-off-by: David Marchand --- lib/eal/common/eal_common_config.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_config.c b/lib/eal/common/eal_common_config.c index 0daf0f3188..2d6c04a49a 100644 --- a/lib/eal/common

[PATCH] eal/unix: lower log level for reading files

optional feature), or add their own error logging when reading the file actually matters. Lower this helper log messages to debug level as it provides no useful information to final DPDK users. Signed-off-by: David Marchand --- lib/eal/unix/eal_filesystem.c | 6 +++--- 1 file changed, 3 insertions

Re: [PATCH] testpmd: fix early exit from signal

rrno == EINTR) > + continue; > + rte_exit(EXIT_FAILURE, "Read failed: %s\n", > +strerror(errno)); Just a nit here. Indent seems odd, I see an extra whitespace. Otherwise the fix lgtm and resolves the issue reported in bz. Reviewed-by: David Marchand -- David Marchand

Re: [PATCH] net/iavf: fix crash on closing representor ports

ine. > return &dcf_adapter->real_hw; > } > > @@ -414,6 +415,7 @@ ice_dcf_vf_repr_init(struct rte_eth_dev *vf_rep_eth_dev, > void *init_param) > repr->dcf_eth_dev = param->dcf_eth_dev; > repr->switch_domain_id = param->switch_domain_id; > repr->vf_id = param->vf_id; > + repr->dcf_valid = true; > repr->outer_vlan_info.port_vlan_ena = false; > repr->outer_vlan_info.stripping_ena = false; > repr->outer_vlan_info.tpid = RTE_ETHER_TYPE_VLAN; > -- > 2.25.1 > Thanks. -- David Marchand

Re: [PATCH v3 0/2] allow creating thread with real-time priority

und 50 us. So you need to > sleep longer than that for your thread not to be runnable when the > nanosleep() wakes up again, because 50 us has already passed in "nanosleep > overhead". You may want to read manual for prctl and look for PR_SET_TIMERSLACK. https://github.com/openvswitch/ovs/commit/f62629a55894546ff043e8a116c3c57aff73c285 > 10 milliseconds provides plenty of margin, and corresponds to 10 jiffies on a > 1000 Hz kernel. (I don't know if it makes any difference for the kernel > scheduler if the timer crosses a jiffy border or not.) -- David Marchand

Re: [PATCH v3 00/19] use rte optional stdatomic API

> lib/vhost/vhost_user.c | 6 +- > lib/vhost/virtio_net.c | 58 +--- > lib/vhost/virtio_net_ctrl.c | 6 +- > 65 files changed, 684 insertions(+), 653 deletions(-) The conversion looks correct to me and the CI looks happy. There are a few acks (from Konstantin) that are missing in the v3 (but I can fix this myself, no need for a new revision just for this). For the series, Acked-by: David Marchand -- David Marchand

Re: [PATCH] eal: fix compile failure of asm on MSVC toolchain

tead. > > Fixes: c7ed1ce04704 ("eal/x86: add power intrinsics for AMD") > > Signed-off-by: Tyler Retzlaff Acked-by: David Marchand Applied, thanks. -- David Marchand

Re: [PATCH] eal: remove return from functions declared void return type

rn type of void so they shouldn't return a value. > > > > Signed-off-by: Tyler Retzlaff > Reviewed-by: Morten Brørup Applied, thanks. -- David Marchand

Re: [PATCH] bus/ifpga: fix driver header dependency

On Tue, Oct 24, 2023 at 2:23 AM Xu, Rosen wrote: > > The driver header bus_ifpga_driver.h was not self sufficient. > > Fix this by including dev_driver.h. > > > > Fixes: 925c074e377b ("bus/ifpga: make driver-only headers private") > > Cc: sta...@dpdk.o

Re: [PATCH] hash: fix build with GFNI

On Wed, Oct 18, 2023 at 11:32 AM David Marchand wrote: > > As an external header, rte_thash_x86_gfni.h should be self sufficient. > > Fixes: 3d4e27fd7ff0 ("use abstracted bit count functions") > > Signed-off-by: David Marchand Applied. -- David Marchand

Re: [PATCH v2] net/iavf: fix Tx offloading flags check

On Wed, Oct 25, 2023 at 11:13 AM Radu Nicolau wrote: > > Relax the check in the previous fix to allow packets > with security offload flag set. > > Fixes: 3c715591ece0 ("net/iavf: fix checksum offloading") > Cc: sta...@dpdk.org > > Signed-off-by: Radu

[PATCH] net/iavf: fix indent in Tx path

Fix confusing indentations. Fixes: 1e728b01120c ("net/iavf: rework Tx path") Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/iavf/iavf_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

Re: [PATCH v2 0/7] vhost: ensure virtqueue access status is checked

+---- > 1 file changed, 85 insertions(+), 7 deletions(-) For the series, Acked-by: David Marchand -- David Marchand

Re: [Bug 1304] l3fwd-power example fails to run with uncore options, -U -u and -i

t; -u > .//examples/dpdk-l3fwd-power -c 0x6 -n 1 -- -p 0x1 -P > --config="(0,0,2)" -i 2 > Error: > EAL: Error - exiting with code: 1 > Cause: Invalid L3FWD parameters Please register to dpdk.org bugzilla, and have a look at this report. Thanks. -- David Marchand

Re: [PATCH] net/iavf: fix IAVF_TX_OFFLOAD_MASK definition

t;>> -Original Message- > >>>> From: Radu Nicolau > >>>> Sent: Tuesday, October 24, 2023 6:23 PM > >>>> To: Marchand, David > >>>> Cc: Wu, Jingjing ; Xing, Beilei > >>>> ; dev@dpdk.org; sta...@dpdk.org &g

Re: [PATCH] net/iavf: fix IAVF_TX_OFFLOAD_MASK definition

> > Signed-off-by: Radu Nicolau Something is not clear to me. How was the IPsec inline crypto feature supposed to work with this driver so far? Any packet with the RTE_MBUF_F_TX_SEC_OFFLOAD flag should have been refused in iavf_prep_pkts. -- David Marchand

Re: [PATCH] net/iavf: fix Tx offloading flags check

On Tue, Oct 24, 2023 at 11:04 AM Radu Nicolau wrote: > On 24-Oct-23 9:44 AM, David Marchand wrote: > > On Tue, Oct 24, 2023 at 10:40 AM Radu Nicolau > > wrote: > >> > >> On 24-Oct-23 6:42 AM, Zhang, Qi Z wrote: > >>>> -Original Message-

Re: [PATCH] net/iavf: fix Tx offloading flags check

> >> +if ((m->ol_flags & IAVF_TX_OFFLOAD_MASK) == 0) > > Not sure if this will break previous fix. > > Could you please provide some clarification regarding the specific offload > > flags that not in IAVF_TX_CKSUM_OFFLOAD_MASK, but you still don't want to > > skip? > > A specific flag is RTE_ETH_TX_OFFLOAD_SECURITY, and because this is not > contained in IAVF_TX_OFFLOAD_MASK the previous fix broke the inline > crypto feature. RTE_ETH_TX_OFFLOAD_SECURITY is a ethdev level flag. This is not supposed to be in a mbuf ol_flags, is it? -- David Marchand

[PATCH] bus/ifpga: fix driver header dependency

The driver header bus_ifpga_driver.h was not self sufficient. Fix this by including dev_driver.h. Fixes: 925c074e377b ("bus/ifpga: make driver-only headers private") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/bus/ifpga/bus_ifpga_driver.h | 1 + 1 file changed, 1

Re: [PATCH] bitops: mark new symbols as stable

o change. > >> > >> Mark those symbols as stable. > >> > >> Fixes: 18898c4d06f9 ("eal: use abstracted bit count functions") > >> > >> Signed-off-by: David Marchand > > Reviewed-by: Joyce Kong > Acked-by: Kevin Traynor Applied, thanks. -- David Marchand

Re: [PATCH v5 19/26] security: remove experimental flag from macsec

gt; rte_security_macsec_sc_stats_get; > rte_security_session_stats_get; > rte_security_session_update; > - rte_security_oop_dynfield_offset; > > + local: *; > +}; > + > +EXPERIMENTAL { > + global: > + > + # Added in 23.11 > + rte_security_oop_dynfield_offset; > rte_security_rx_inject_configure; > rte_security_inb_pkt_rx_inject; Alphabetical order in the experimental section please. -- David Marchand

Re: [PATCH v2 0/7] vhost: ensure virtqueue access status is checked

k. For those interested: https://patchwork.dpdk.org/project/dpdk/list/?series=29950&state=%2A&archive=both -- David Marchand

[PATCH 2/3] vhost: fix virtqueue access lock in datapath

hange virtqueue access lock to a read/write one") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- lib/vhost/virtio_net.c | 60 +++--- 1 file changed, 44 insertions(+), 16 deletions(-) diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_n

[PATCH 3/3] vhost: annotate virtqueue access checks

Modifying vq->access_ok should be done with a write lock taken. Annotate vring_translate() and vring_invalidate() and add missing locks. Signed-off-by: David Marchand --- lib/vhost/vduse.c | 4 lib/vhost/vhost.h | 7 +-- lib/vhost/vhost_user.c | 10 ++ 3 fi

[PATCH 1/3] vhost: robustify virtqueue access lock asserts

A simple comment in vhost_user_msg_handler() is not that robust. Add a lock_all_qps property to message handlers so that their implementation can add a build check and assert a vq is locked. Signed-off-by: David Marchand --- lib/vhost/vhost_user.c | 110

Re: [PATCH v8 0/3] Split logging functionality out of EAL

On Fri, Aug 11, 2023 at 2:46 PM David Marchand wrote: > > On Wed, Aug 9, 2023 at 3:36 PM Bruce Richardson > wrote: > > > > There is a general desire to reduce the size and scope of EAL. To this > > end, this patchset makes a (very) small step in that directio

Re: [PATCH v5 14/26] meter: remove experimental warning from comments

object to this removal, I mentionned in previous mail that this commitlog is wrong. Those API were properly flagged as experimental. I'll update the commitlog myself... > > Signed-off-by: Stephen Hemminger > Acked-by: Bruce Richardson > Acked-by: Cristian Dumitrescu -- David Marchand

Re: [PATCH v5 15/26] power: remove experimental from API's

> - # added in 23.11 > - rte_power_get_uncore_env; > - rte_power_set_uncore_env; > - rte_power_uncore_freqs; > + rte_power_unset_env; > rte_power_unset_uncore_env; > + > + local: *; Those symbols were introduced last week in ac1edcb6621a ("pow

[PATCH] ethdev: refresh shared memory reference in secondary process

port. Bugzilla ID: 1303 Fixes: 36c46e738120 ("ethdev: cleanup shared data with the last port") Signed-off-by: David Marchand --- lib/ethdev/ethdev_private.c | 46 - 1 file changed, 30 insertions(+), 16 deletions(-) diff --git a/lib/ethdev/ethdev_

Re: [PATCH] maintainers: update email address

leave your intel mail address. Chenbo Xia This will help get-maintainers.sh, when copying you about past changes for example. -- David Marchand

Re: [PATCH 0/7] vhost: ensure vitqueue access status is checked

rotection in power monitor API > vhost: fix checking virtqueue access ins stats API This series needs some rebasing, and I had a small comment on a first patch Fixes: tag, but otherwise it lgtm. -- David Marchand

Re: [PATCH 1/7] vhost: fix missing vring call check on virtqueue access

6c299bb7322f ("vhost: introduce vring call API") > > Fixes: c5736998305d ("vhost: fix missing virtqueue lock protection") > Fixes: 830f7e790732 ("vhost: add non-blocking API for posting interrupt") > Cc: sta...@dpdk.org > > Reported-by: Li Feng > Signed-off-by: Maxime Coquelin -- David Marchand

Re: [PATCH] devtools: extend check on compiler builtin atomics

On Tue, Oct 17, 2023 at 1:34 PM Tyler Retzlaff wrote: > > On Tue, Oct 17, 2023 at 01:31:25PM +0200, David Marchand wrote: > > rte_memory_order_* should be used when calling the new stdatomic API. > > Add a check on __ATOMIC_* tokens. > > > > Signed-off-by: Dav

Re: [PATCH v2 15/29] meter: remove experimental warning from comments

er: support RFC4115 trTCM"). The only thing wrong here is that when this API was marked stable, we forgot to remove those banners in the comments. > an experimental comment in the docbook comment. > Remove the comment. > > Signed-off-by: Stephen Hemminger -- David Marchand

Re: [PATCH v2 00/29] promote many API's to stable

On Wed, Oct 18, 2023 at 9:14 PM David Marchand wrote: > > Hello Stephen, > > On Wed, Aug 9, 2023 at 2:10 AM Stephen Hemminger > wrote: > > > > Since 23.11 is an LTS release it is time to remove the experimental > > bandaid off many API's. There are about 850

Re: [PATCH 00/15] eal: mark older API's stable

> eal: mark rte_intr_XXX API's as stable > eal: mark rte_atomic128_cmp_exchange as stable > eal: make most rte_thread API's stable > eal: mark rte_power API's stable > eal: mark rte_eal_vfio_get_token stable > eal: mark rte_vect simd bandwidth API as stable This needs some rebasing too. -- David Marchand

Re: [PATCH v2 00/29] promote many API's to stable

more libraries to the mix >- remove EXPERIMENTAL where tagged in MAINTAINERS There were some API updates merged in -rc1. Could you please rebase this series? Thanks. -- David Marchand

Re: [PATCH v4] bus/pci: fix legacy device IO port map in secondary process

On Wed, Oct 18, 2023 at 2:39 PM Gupta, Nipun wrote: > On 10/18/2023 3:35 PM, David Marchand wrote: > > On Mon, Oct 9, 2023 at 5:06 AM Ma, WenwuX wrote: > >>> From a pci bus API pov, nothing prevents a driver from mixing memory > >>> mapped with vfio an

Re: [PATCH v4 1/2] event/*: set device pointer for vdev-based eventdevs

a: introduce PMD") > Fixes: 8a5d7a8ec74b ("event/dpaa2: initialize device") > Fixes: 34498de6000f ("event/octeontx: add octeontx eventdev driver") > Cc: sta...@dpdk.org > > Signed-off-by: Bruce Richardson Acked-by: David Marchand -- David Marchand

[PATCH] test/crypto: move some tests to driver-tests suite

Some cryptodev driver specific tests were in the "driver-tests" suite, while similar tests for other drivers were not. Signed-off-by: David Marchand --- app/test/test_cryptodev.c | 20 ++-- app/test/test_cryptodev_asym.c | 9 +++-- 2 files changed, 13 inserti

Re: [PATCH v4 2/2] event/skeleton: set driver name string

dev_info->driver_name = dev->dev->driver->name; rte_eventdev_trace_info_get(dev_id, dev_info, dev_info->dev); -- David Marchand

Re: [PATCH v4 0/7] document and simplify use of cmdline

arsed(...) > show port _n --> void cmd_show_port_n_parsed(...) > I think I get what you mean, and it seems acceptable. > Prefixes on strings beyond initial tokens could just be silently stripped. By initial tokens, do you mean fixed strings token before a <> typed token ? -- David Marchand

Re: [PATCH] ci: test manuals generation in GHA

On Tue, Oct 17, 2023 at 2:29 PM Aaron Conole wrote: > David Marchand writes: > > Add missing package so manuals are generated as part of the docs check. > > > > Signed-off-by: David Marchand > Reviewed-by: Aaron Conole Applied, thanks. -- David Marchand

Re: [PATCH v1] bus/pci: get PCI address from rte_device

On Wed, May 31, 2023 at 11:52 AM David Marchand wrote: > > (I reformatted the mail a bit) > > On Wed, May 31, 2023 at 10:51 AM Elena Agostini wrote: > > > On Wed, May 31, 2023 at 10:44 AM Elena Agostini eagost...@nvidia.com > > > wrote: > > > >

Re: [PATCH v1 1/2] baseband/acc: support ACC100 deRM corner case SDK

ifier: BSD-3-Clause > # Copyright(c) 2020 Intel Corporation > > -deps += ['bus_pci'] ... > +deps += ['bbdev', 'bus_pci'] This part is likely a rebase damage. See: b7b8de26f34d ("drivers: add dependencies for some classes") -- David Marchand

Re: [PATCH v4] bus/pci: fix legacy device IO port map in secondary process

ci_vfio_fill_regions is done. > This avoids reference counting operations, do you think it works? Afaics, rte_vfio_setup_device should not be called if a call to rte_pci_map_device for this device was successful (rte_pci_map_device itself calls rte_vfio_setup_device). And as a consequence, calling rte_vfio_release_device cannot be done unconditionnally neither. -- David Marchand

[PATCH] hash: fix build with GFNI

As an external header, rte_thash_x86_gfni.h should be self sufficient. Fixes: 3d4e27fd7ff0 ("use abstracted bit count functions") Signed-off-by: David Marchand --- lib/hash/rte_thash_x86_gfni.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/hash/rte_thash_x86_gfni.h

[PATCH] ml/cnxk: don't export internal headers

driver_sdk_headers is used to expose headers that may be used by external drivers. Don't export ml/cnxk internal headers. Fixes: fe83ffd9ec2e ("ml/cnxk: add skeleton") Signed-off-by: David Marchand --- drivers/ml/cnxk/meson.build | 7 --- 1 file changed, 7 deletions(-

[PATCH] bitops: mark new symbols as stable

are inline helpers for abstracting common bit counting functions. This part of the API is unlikely to change. Mark those symbols as stable. Fixes: 18898c4d06f9 ("eal: use abstracted bit count functions") Signed-off-by: David Marchand --- Copying Techboard for info, as this goes against

Re: [PATCH v4 0/7] document and simplify use of cmdline

g with the separator, we should avoid having to provide the > STRING type at all. ... and as a consequence, I find <|all confusing, it is like an empty value would be acceptable. About skipping the token type for such lists, I had considered it, but I thought other types took an optional list of allowed values... Now looking at the cmdline types, it is not the case. Maybe I mixed with some other cli framework I played with in the past... All of this to say, ok for me to omit the type. > > To my previous point on not liking to have a prefix-specifier, the > alternative to making testpmd work with the script is to tweak very > slightly the "help ". > > help # show general help > help on <|all|control|display|config|ports|>section > > By making the command "help on ports" rather than "help ports" we would > avoid the need for the prefix syntax. There are other cases where a "chain of command" returns the value of a parameter. And the same parameter may be set via "chain of command value". -- David Marchand

Re: [PATCH] event/dsw: fix missing device pointer

) > > Cc: mattias.ronnb...@ericsson.com > > > > Signed-off-by: Bruce Richardson > > Is this issue for all "vdev" devices? if so, Please check for > drivers/event/skeleton too. Should we add some eventdev wrappers for shared code like this? Something like rte_eth_dev_pci_generic_probe() / rte_eth_vdev_allocate(). -- David Marchand

[PATCH] event/cnxk: fix symbol map

Caught while rebasing a series that check map files. Remove superfluous whitespace. Current ABI number is 24. Sort experimental symbols and annotate them with the version they are introduced in. Fixes: 03714a41bd26 ("event/cnxk: add event port flow context API") Signed-off-by: Davi

[PATCH] devtools: extend check on compiler builtin atomics

rte_memory_order_* should be used when calling the new stdatomic API. Add a check on __ATOMIC_* tokens. Signed-off-by: David Marchand --- devtools/checkpatches.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index

Re: [PATCH v2] ci: test stdatomic API

On Tue, Oct 17, 2023 at 9:15 AM David Marchand wrote: > > Add some compilation tests with C11 atomics enabled. > The headers check can't be enabled (as gcc and clang don't provide > stdatomic before C++23). > > Signed-off-by: David Marchand > Reviewed-by:

[PATCH] ci: test manuals generation in GHA

Add missing package so manuals are generated as part of the docs check. Signed-off-by: David Marchand --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7a2ac0ceee..e6c6267eb4 100644

Re: [PATCH v2 1/2] power: refactor uncore power management interfaces

> "power_intel_uncore" along with functions. > > Signed-off-by: Sivaprasad Tummala No news from the maintainers is not a good news... But, given Anatoly was not against it, I took this series for rc1. Applied with some fixes on doc and style, and added an entry in the RN, thanks. -- David Marchand

[PATCH v2] ci: test stdatomic API

Add some compilation tests with C11 atomics enabled. The headers check can't be enabled (as gcc and clang don't provide stdatomic before C++23). Signed-off-by: David Marchand Reviewed-by: Aaron Conole --- Changelog from v1: - following Thomas offlist review, tweaked coverage in

Re: [PATCH v4 0/7] document and simplify use of cmdline

1) instances.append(process_command(tokens.strip().split(), cfile, comment.strip())) print(f'static __rte_used cmdline_parse_ctx_t {ctxname}[] = {{') Which translates as: cmd_brief:help # help: Show help help section # help: Show help > > The "cmdline" example itself, is not converted over, as it should > probably remain as a simple example of direct library use without the > script. +1 -- David Marchand

<    2   3   4   5   6   7   8   9   10   11   >