Re: [dpdk-dev] [PATCH v2 00/55] Solarflare libefx-based PMD

2016-12-02 Thread Ferruh Yigit
rt and stop operations > net/sfc: implement device callback to Rx burst of packets > net/sfc: discard scattered packet on Rx correctly > > Artem Andreev (2): > net/sfc: include libefx in build > net/sfc: implement device operation to retrieve link info > > Ivan Malov (5): > net/sfc: provide basic stubs for Tx subsystem > net/sfc: add function to check configured Tx mode > net/sfc: add callbacks to set up and release Tx queues > net/sfc: implement transmit path start / stop > net/sfc: add callback to send bursts of packets > Series Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com>

Re: [dpdk-dev] [PATCH 30/31] net/i40e: support Linux VF to configure IRQ link list

2016-12-02 Thread Ferruh Yigit
On 12/2/2016 12:12 AM, Wenzhuo Lu wrote: > i40e PF host only support to work with DPDK VF driver, Linux > VF driver is not supported. This change will enhance in > configuring IRQ link list. > > This Change will identify VF client by number of vector > requested. DPDK VF will ask only single one

Re: [dpdk-dev] [PATCH 12/31] net/i40e: set VF MAC from PF support

2016-12-02 Thread Ferruh Yigit
On 12/2/2016 12:11 AM, Wenzhuo Lu wrote: > Support setting VF MAC address from PF. > User can call the API on PF to set a speific VF's s/speific/specific > MAC address. > > Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com> <..>

Re: [dpdk-dev] [PATCH 05/31] net/i40e: set TX loopback from PF

2016-12-02 Thread Ferruh Yigit
On 12/2/2016 12:11 AM, Wenzhuo Lu wrote: > Support enabling/disabling TX loopback from PF. > User can call the API on PF to enable/disable TX loopback > for all the PF and VFs. > > Signed-off-by: Wenzhuo Lu > --- > drivers/net/i40e/i40e_ethdev.c| 219 >

[dpdk-dev] [PATCH v2] scripts: check cc stable mailing list in commit

2016-12-01 Thread Ferruh Yigit
commit message. > > Signed-off-by: Thomas Monjalon Tested-by: Ferruh Yigit

[dpdk-dev] [PATCH v2] doc: add pdump library to API doxygen

2016-12-01 Thread Ferruh Yigit
From: Reshma Pattan Add pdump library to API doxygen. Signed-off-by: Reshma Pattan --- v2: * Move pdump higher position in the index --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf | 1 + 2 files changed, 2 insertions(+) diff --git

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-01 Thread Ferruh Yigit
On 11/30/2016 6:26 PM, Thomas Monjalon wrote: > 2016-11-30 17:42, Ananyev, Konstantin: Please, we need a comment for each driver saying "it is OK, we do not need any checksum preparation for TSO" or "yes we have to implement tx_prepare or TSO will not work in this mode"

[dpdk-dev] apply commit e30a0178d290a4e83dc01f9c2170d4859339c9cf "kni: support RHEL 7.3" to dpdk-stable?

2016-12-01 Thread Ferruh Yigit
On 11/30/2016 8:54 PM, Roberts, Lee A. wrote: > Does it make sense to apply the commit for "kni: support RHEL 7.3" > (http://www.dpdk.org/browse/dpdk/commit/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h?id=e30a0178d290a4e83dc01f9c2170d4859339c9cf) > to the stable tree to enable clean

[dpdk-dev] [PATCH v4] net/kni: add KNI PMD

2016-11-30 Thread Ferruh Yigit
Add KNI PMD which wraps librte_kni for ease of use. KNI PMD can be used as any regular PMD to send / receive packets to the Linux networking stack. Signed-off-by: Ferruh Yigit --- v4: * allow only single queue * use driver.name as name v3: * rebase on top of latest master v2: * updated

[dpdk-dev] [PATCH] scripts: check cc stable mailing list in commit

2016-11-30 Thread Ferruh Yigit
On 11/21/2016 10:43 PM, Thomas Monjalon wrote: > Add a check for commits fixing a released bug. > Such commits are found thanks to scripts/git-log-fixes.sh. > They must be sent CC: stable at dpdk.org. > In order to avoid forgetting CC, this mail header can be written > in the git commit message. >

[dpdk-dev] [PATCH v2] net/i40evf: fix casting between structs

2016-11-30 Thread Ferruh Yigit
On 11/30/2016 2:02 AM, Jingjing Wu wrote: > Casting from structs which lay out data in typed members > to structs which have flat memory buffers, will cause > problems if the alignment of the former isn't as expected. > This patch removes the casting between structs. > > Fixes: ae19955e7c86

[dpdk-dev] [PATCH] e1000/base: announce supported NICs

2016-11-30 Thread Ferruh Yigit
On 11/27/2016 6:11 PM, Wenzhuo Lu wrote: > Announce the support of I219 NICs. Also add all the > other supported NICs. > > Add Intel I219 NICs support in release note too. > > Signed-off-by: Wenzhuo Lu Commit log and release notes wording updated. Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH v2 1/1] net/i40e: enable auto link update for 25G

2016-11-30 Thread Ferruh Yigit
On 11/29/2016 8:26 PM, Qi Zhang wrote: > In previous patch for 25G (XXV710) enable > 75d133dd329: ("net/i40e: enable 25G device"), > we intend to disable the auto linke update as a work around > for the issue that link can't be turn on when auto link update > is enabled. Now we know the root

[dpdk-dev] [PATCH 1/1] net/i40e: enable auto link update for XXV710

2016-11-30 Thread Ferruh Yigit
On 11/30/2016 2:26 AM, Zhang, Qi Z wrote: > Hi Ferruh: > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, November 30, 2016 1:46 AM >> To: Zhang, Qi Z ; Wu, Jingjing > intel.com>; >> Zhang, Helin >> Cc: dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 1/1] net/i40e:

[dpdk-dev] [PATCH 1/1] net/i40e: enable auto link update for XXV710

2016-11-29 Thread Ferruh Yigit
Hi Qi, On 11/24/2016 11:43 PM, Qi Zhang wrote: > This patch remove the limitation that XXV710 device does XXV710 is 25G device, and support added in 16.11 (please correct me if this is wrong.), but I can't find any DPDK documentation for this device. Can you please add some documentation, at

[dpdk-dev] [PATCH] i40evf: add set maximum frame size support

2016-11-29 Thread Ferruh Yigit
On 11/25/2016 8:47 PM, Michael Bieniek wrote: > This adds the ability to set maximum frame size for an i40e virtual > interface. This patch is based on the i40e physical function maximum > frame size implementation. This was tested on an system configured with > multiple i40e virtual functions.

[dpdk-dev] [PATCH] net/i40evf: fix casting between structs

2016-11-29 Thread Ferruh Yigit
On 11/27/2016 9:35 AM, Jingjing Wu wrote: > Casting from structs which lay out data in typed members > to structs which have flat memory buffers, will cause > problems if the alignment of the former isn't as expected. > This patch removes the casting between structs. > > Fixes: ae19955e7c86

[dpdk-dev] [PATCH] net/i40e: fix log when check Tx free thresh

2016-11-29 Thread Ferruh Yigit
On 11/27/2016 9:11 AM, Jingjing Wu wrote: > Fixes: 4861cde46116 ("i40e: new poll mode driver") > Signed-off-by: Jingjing Wu Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH 00/16] e1000 base code update

2016-11-25 Thread Ferruh Yigit
Hi Wenzhuo, On 11/23/2016 5:22 PM, Wenzhuo Lu wrote: > Updated e1000 base code to fix several bugs and support > i219 NICs. > > Wenzhuo Lu (16): > e1000/base: increased ULP timer > e1000/base: increase PHY PLL clock gate timing > e1000/base: try more times to get HW mailbox lock >

[dpdk-dev] [PATCH 00/16] e1000 base code update

2016-11-25 Thread Ferruh Yigit
On 11/23/2016 5:22 PM, Wenzhuo Lu wrote: > Updated e1000 base code to fix several bugs and support > i219 NICs. > > Wenzhuo Lu (16): > e1000/base: increased ULP timer > e1000/base: increase PHY PLL clock gate timing > e1000/base: try more times to get HW mailbox lock > e1000/base: add

[dpdk-dev] [PATCH 00/56] Solarflare libefx-based PMD

2016-11-25 Thread Ferruh Yigit
On 11/25/2016 12:02 PM, Andrew Rybchenko wrote: > On 11/25/2016 01:24 PM, Ferruh Yigit wrote: >> On 11/23/2016 7:49 AM, Andrew Rybchenko wrote: >>> On 11/23/2016 03:02 AM, Ferruh Yigit wrote: >>>> On 11/21/2016 3:00 PM, Andrew Rybchenko wrote: >>>>>

[dpdk-dev] [PATCH v3] kni: avoid using lsb_release script

2016-11-25 Thread Ferruh Yigit
gt; base-files: /etc/lsb-release > > Read the file if present and use the variables defined in it. > > Signed-off-by: Robin Jarry Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH v2] kni: avoid using lsb_release script

2016-11-25 Thread Ferruh Yigit
On 11/25/2016 11:33 AM, Robin Jarry wrote: > The lsb_release script is part of an optional package which is not > always installed. On the other hand, /etc/lsb-release is always present > even on minimal Ubuntu installations. > > root at ubuntu1604:~# dpkg -S /etc/lsb-release >

[dpdk-dev] [PATCH] kni: avoid using lsb_release script

2016-11-25 Thread Ferruh Yigit
On 11/25/2016 9:52 AM, Robin Jarry wrote: > The lsb_release script is part of an optional package which is not > always installed. On the other hand, /etc/lsb-release is always present > even on minimal Ubuntu installations. > > root at ubuntu1604:~# dpkg -S /etc/lsb-release > base-files:

[dpdk-dev] [PATCH 00/56] Solarflare libefx-based PMD

2016-11-25 Thread Ferruh Yigit
On 11/24/2016 4:15 PM, Andrew Rybchenko wrote: > On 11/23/2016 06:29 PM, Ferruh Yigit wrote: >> On 11/21/2016 3:00 PM, Andrew Rybchenko wrote: >>> The patch series adds Solarflare libefx-based network PMD. >>> >>> This version of the driver supports Solarfl

[dpdk-dev] [PATCH 00/56] Solarflare libefx-based PMD

2016-11-25 Thread Ferruh Yigit
On 11/23/2016 7:49 AM, Andrew Rybchenko wrote: > On 11/23/2016 03:02 AM, Ferruh Yigit wrote: >> On 11/21/2016 3:00 PM, Andrew Rybchenko wrote: >>> The patch series adds Solarflare libefx-based network PMD. >>> >>> This version of the driver supports Solarfl

[dpdk-dev] [PATCH 30/56] net/sfc: include libefx in build

2016-11-25 Thread Ferruh Yigit
On 11/24/2016 3:44 PM, Andrew Rybchenko wrote: > See one question below. > > On 11/23/2016 06:26 PM, Ferruh Yigit wrote: >> On 11/21/2016 3:00 PM, Andrew Rybchenko wrote: >>> From: Artem Andreev >>> >>> Implement efsys.h for the PMD. >>> >

[dpdk-dev] [PATCH v2 1/2] net: remove dead driver names

2016-11-24 Thread Ferruh Yigit
oes not properly report a driver name (fixed in > next commit). > > Signed-off-by: David Marchand > Reviewed-by: Ferruh Yigit > Reviewed-by: Jan Blunck Series applied to dpdk-next-net/master, thanks.

[dpdk-dev] [RFC 2/9] ethdev: move queue id check in generic layer

2016-11-24 Thread Ferruh Yigit
On 11/24/2016 9:54 AM, Olivier Matz wrote: > The check of queue_id is done in all drivers implementing > rte_eth_rx_queue_count(). Factorize this check in the generic function. > > Note that the nfp driver was doing the check differently, which could > induce crashes if the queue index was too

[dpdk-dev] [RFC 1/9] ethdev: clarify api comments of rx queue count

2016-11-24 Thread Ferruh Yigit
gt; Acked-by: Ivan Boule Acked-by: Ferruh Yigit

[dpdk-dev] Proposal for a new Committer model

2016-11-23 Thread Ferruh Yigit
On 11/23/2016 3:33 PM, Neil Horman wrote: > On Wed, Nov 23, 2016 at 02:01:44PM +0000, Ferruh Yigit wrote: >> On 11/23/2016 1:48 PM, Neil Horman wrote: >>> On Tue, Nov 22, 2016 at 08:56:23PM +, Ferruh Yigit wrote: >>>> On 11/22/2016 7:52 PM, Neil Horman wrote: &g

[dpdk-dev] [PATCH] examples: fix ip_pipeline makefile typo

2016-11-23 Thread Ferruh Yigit
On 11/23/2016 12:56 PM, Ilya Matveychikov wrote: > Signed-off-by: Ilya V. Matveychikov > --- > examples/ip_pipeline/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/ip_pipeline/Makefile b/examples/ip_pipeline/Makefile > index 5827117..6657237 100644 >

[dpdk-dev] [PATCH 00/56] Solarflare libefx-based PMD

2016-11-23 Thread Ferruh Yigit
On 11/21/2016 3:00 PM, Andrew Rybchenko wrote: > The patch series adds Solarflare libefx-based network PMD. > > This version of the driver supports Solarflare SFN7xxx and SFN8xxx > families of 10/40 Gbps adapters. > > libefx is a platform-independent library to implement drivers for > Solarflare

[dpdk-dev] [PATCH 33/56] net/sfc: add device configure and close stubs

2016-11-23 Thread Ferruh Yigit
On 11/21/2016 3:00 PM, Andrew Rybchenko wrote: > Reviewed-by: Andy Moreton > Signed-off-by: Andrew Rybchenko > --- <...> > diff --git a/drivers/net/sfc/efx/sfc.h b/drivers/net/sfc/efx/sfc.h > index 01d652d..d040f98 100644 > --- a/drivers/net/sfc/efx/sfc.h > +++ b/drivers/net/sfc/efx/sfc.h

[dpdk-dev] [PATCH 32/56] net/sfc: implement driver operation to init device on attach

2016-11-23 Thread Ferruh Yigit
On 11/21/2016 3:00 PM, Andrew Rybchenko wrote: > The setup and configuration of the PMD is not performance sensitive, > but is not thread safe either. It is possible that the multiple > read/writes during PMD setup and configuration could be corrupted > in a multi-thread environment. Right,

[dpdk-dev] [PATCH 31/56] net/sfc: implement dummy callback to get device information

2016-11-23 Thread Ferruh Yigit
On 11/21/2016 3:00 PM, Andrew Rybchenko wrote: > Just a stub to be filled in when corresponding functionality is > implemented. What about merging this stub with real implementation? Or perhaps replace with code that adds dummy .dev_configure? > > Reviewed-by: Andy Moreton > Signed-off-by:

[dpdk-dev] [PATCH 30/56] net/sfc: include libefx in build

2016-11-23 Thread Ferruh Yigit
On 11/21/2016 3:00 PM, Andrew Rybchenko wrote: > From: Artem Andreev > > Implement efsys.h for the PMD. > > Reviewed-by: Andy Moreton > Signed-off-by: Artem Andreev > Signed-off-by: Andrew Rybchenko > --- > drivers/net/sfc/efx/Makefile | 54 +++ > drivers/net/sfc/efx/efsys.h | 767 >

[dpdk-dev] [PATCH 01/56] net/sfc: libefx-based PMD stub sufficient to build and init

2016-11-23 Thread Ferruh Yigit
On 11/21/2016 3:00 PM, Andrew Rybchenko wrote: > The PMD is put into the sfc/efx subdirectory to have a place for > the second PMD and library shared by both. > > Enable the PMD by default on supported configuratons. > > Reviewed-by: Andy Moreton > Signed-off-by: Andrew Rybchenko > --- >

[dpdk-dev] Proposal for a new Committer model

2016-11-23 Thread Ferruh Yigit
On 11/23/2016 1:48 PM, Neil Horman wrote: > On Tue, Nov 22, 2016 at 08:56:23PM +0000, Ferruh Yigit wrote: >> On 11/22/2016 7:52 PM, Neil Horman wrote: >>> On Mon, Nov 21, 2016 at 09:52:41AM +0100, Thomas Monjalon wrote: >>>> 2016-11-18 13:09, Neil Horman: &g

[dpdk-dev] [PATCH 00/56] Solarflare libefx-based PMD

2016-11-23 Thread Ferruh Yigit
On 11/23/2016 12:02 AM, Ferruh Yigit wrote: > On 11/21/2016 3:00 PM, Andrew Rybchenko wrote: >> The patch series adds Solarflare libefx-based network PMD. >> >> This version of the driver supports Solarflare SFN7xxx and SFN8xxx >> families of 10/40 Gbps adapters.

[dpdk-dev] [PATCH 00/56] Solarflare libefx-based PMD

2016-11-23 Thread Ferruh Yigit
On 11/21/2016 3:00 PM, Andrew Rybchenko wrote: > The patch series adds Solarflare libefx-based network PMD. > > This version of the driver supports Solarflare SFN7xxx and SFN8xxx > families of 10/40 Gbps adapters. > > libefx is a platform-independent library to implement drivers for > Solarflare

[dpdk-dev] Proposal for a new Committer model

2016-11-22 Thread Ferruh Yigit
On 11/22/2016 7:52 PM, Neil Horman wrote: > On Mon, Nov 21, 2016 at 09:52:41AM +0100, Thomas Monjalon wrote: >> 2016-11-18 13:09, Neil Horman: >>> A) Further promote subtree maintainership. This was a conversation that I >>> proposed some time ago, but my proposed granularity was discarded in

[dpdk-dev] [PATCH] mk: remove make target for examples

2016-11-22 Thread Ferruh Yigit
On 11/22/2016 9:38 AM, Thomas Monjalon wrote: > 2016-11-22 00:34, Ferruh Yigit: >> On 11/21/2016 11:47 PM, Thomas Monjalon wrote: >>> The command >>> make examples >>> works only if target directories have the exact name of configs. >>> >>

[dpdk-dev] [PATCH] mk: remove make target for examples

2016-11-22 Thread Ferruh Yigit
On 11/21/2016 11:47 PM, Thomas Monjalon wrote: > The command > make examples > works only if target directories have the exact name of configs. > > It is more flexible to use > make -C examples RTE_SDK=$(pwd) RTE_TARGET=build > > Signed-off-by: Thomas Monjalon Instead of removing examples

[dpdk-dev] [PATCH] eal: postpone vdev initialization

2016-11-21 Thread Ferruh Yigit
On 11/21/2016 5:02 PM, Jerin Jacob wrote: > On Mon, Nov 21, 2016 at 09:54:57AM +0000, Ferruh Yigit wrote: >> On 11/20/2016 8:00 AM, Jerin Jacob wrote: >>> Some platform like octeontx may use pci and >>> vdev based combined device to represent a logical >>>

[dpdk-dev] [PATCH RFC 0/2] Allow vectorized Rx with 4096 desc ring size on Intel NICs.

2016-11-21 Thread Ferruh Yigit
On 10/19/2016 3:30 PM, Ferruh Yigit wrote: > On 10/19/2016 3:07 PM, Ilya Maximets wrote: >> Ilya Maximets (2): >> net/i40e: allow bulk alloc for the max size desc ring >> net/ixgbe: allow bulk alloc for the max size desc ring >> >> dr

[dpdk-dev] [PATCH v3] ntnic: add PMD driver

2016-11-21 Thread Ferruh Yigit
On 9/12/2016 8:34 AM, fc at napatech.com (Finn Christensen) wrote: >> -Original Message- >> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >> Sent: 10. september 2016 10:20 >> To: Finn Christensen >> Cc: Neil Horman ; dev at dpdk.org; >> stephen at networkplumber.org >>

[dpdk-dev] [PATCH v9] drivers/net:new PMD using tun/tap host interface

2016-11-21 Thread Ferruh Yigit
On 10/13/2016 11:03 PM, Keith Wiles wrote: > The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces > on the local host. The PMD allows for DPDK and the host to > communicate using a raw device interface on the host and in > the DPDK application. The device created is a Tap device with >

[dpdk-dev] [dpdk-stable] [PATCH] Revert "bonding: use existing enslaved device queues"

2016-11-21 Thread Ferruh Yigit
On 10/25/2016 3:00 PM, Bruce Richardson wrote: > On Tue, Oct 25, 2016 at 02:48:04PM +0100, Declan Doherty wrote: >> On 25/10/16 13:57, Bruce Richardson wrote: >>> On Mon, Oct 24, 2016 at 04:07:17PM +0100, Declan Doherty wrote: On 24/10/16 15:51, Jan Blunck wrote: > On Mon, Oct 24, 2016 at

[dpdk-dev] [PATCH v2] nfp: report link speed using hardware info

2016-11-21 Thread Ferruh Yigit
On 11/18/2016 4:06 PM, Alejandro Lucero wrote: > Previous reported speed was hardcoded. > > Signed-off-by: Alejandro Lucero > --- > drivers/net/nfp/nfp_net.c | 28 ++-- > drivers/net/nfp/nfp_net_ctrl.h | 13 + > 2 files changed, 39 insertions(+), 2

[dpdk-dev] [PATCH v2] nfp: report link speed using hardware info

2016-11-21 Thread Ferruh Yigit
On 11/18/2016 4:50 PM, Alejandro Lucero wrote: > On Fri, Nov 18, 2016 at 4:29 PM, Thomas Monjalon 6wind.com> > wrote: > >> 2016-11-18 16:06, Alejandro Lucero: >>> Previous reported speed was hardcoded. >>> >>> Signed-off-by: Alejandro Lucero >>> --- >>> drivers/net/nfp/nfp_net.c | 28

[dpdk-dev] Solarflare PMD submission question

2016-11-21 Thread Ferruh Yigit
On 11/21/2016 8:59 AM, Thomas Monjalon wrote: > 2016-11-21 11:46, Andrew Rybchenko: >> On 11/21/2016 11:19 AM, Thomas Monjalon wrote: Before submitting 56 patches I'd like to double-check that checkpatch.pl errors (for example, because of assignments in the 'if' condition,

[dpdk-dev] [PATCH] eal: postpone vdev initialization

2016-11-21 Thread Ferruh Yigit
On 11/20/2016 8:00 AM, Jerin Jacob wrote: > Some platform like octeontx may use pci and > vdev based combined device to represent a logical > dpdk functional device.In such case, postponing the > vdev initialization after pci device > initialization will provide the better view of > the pci device

[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info

2016-11-18 Thread Ferruh Yigit
On 11/18/2016 3:10 PM, Alejandro Lucero wrote: > Hi Thomas, > > I got this email when sending a patch some minutes ago. > > The point is I trusted script/checkpatches.sh which did not report those > warnings. > Am I doing anything wrong when using checkpatches.sh? > > > -- Forwarded

[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info

2016-11-18 Thread Ferruh Yigit
On 11/18/2016 3:10 PM, Alejandro Lucero wrote: > Hi Thomas, > > I got this email when sending a patch some minutes ago. > > The point is I trusted script/checkpatches.sh which did not report those > warnings. > Am I doing anything wrong when using checkpatches.sh? I am also getting same

[dpdk-dev] [PATCH 3/3] net/mlx5: do not invalidate title CQE

2016-11-18 Thread Ferruh Yigit
On 11/17/2016 10:38 AM, Adrien Mazarguil wrote: > On Thu, Nov 17, 2016 at 10:49:56AM +0100, Nelio Laranjeiro wrote: >> We can leave the title completion queue entry untouched since its contents >> are not modified. >> >> Reported-by: Liming Sun >> Signed-off-by: Nelio Laranjeiro <...> >

[dpdk-dev] [dpdk-stable] [PATCH 2/3] net/mlx5: fix wrong htons

2016-11-18 Thread Ferruh Yigit
On 11/17/2016 10:38 AM, Adrien Mazarguil wrote: > On Thu, Nov 17, 2016 at 10:49:55AM +0100, Nelio Laranjeiro wrote: >> Completion queue entry data uses network endian, to access them we should use >> ntoh*(). >> >> Fixes: c305090bbaf8 ("net/mlx5: replace countdown with threshold for Tx >>

[dpdk-dev] [dpdk-stable] [PATCH 1/3] net/mlx5: fix leak when starvation occurs

2016-11-18 Thread Ferruh Yigit
On 11/17/2016 10:37 AM, Adrien Mazarguil wrote: > On Thu, Nov 17, 2016 at 10:49:54AM +0100, Nelio Laranjeiro wrote: >> The list of segments to free was wrongly manipulated ending by only freeing >> the first segment instead of freeing all of them. The last one still >> belongs to the NIC and thus

[dpdk-dev] [PATCH v2 2/2] Move non-PCI related eth_dev initialization to rte_eth_dev_allocate()

2016-11-17 Thread Ferruh Yigit
unck Reviewed-by: Ferruh Yigit

[dpdk-dev] [PATCH v2 1/2] Clear eth_dev->data in rte_eth_dev_allocate()

2016-11-17 Thread Ferruh Yigit
On 11/17/2016 5:16 PM, Jan Blunck wrote: > Lets clear the eth_dev->data when allocating a new rte_eth_dev so that > drivers only need to set non-zero values. > > Signed-off-by: Jan Blunck > --- Reviewed-by: Ferruh Yigit

[dpdk-dev] [PATCH 1/2] Clear eth_dev->data in rte_eth_dev_allocate()

2016-11-17 Thread Ferruh Yigit
On 11/17/2016 2:24 PM, Jan Blunck wrote: > Lets clear the eth_dev->data when allocating a new rte_eth_dev so that > drivers only need to set non-zero values. > > Signed-off-by: Jan Blunck > --- > drivers/net/mlx4/mlx4.c | 1 - > drivers/net/mlx5/mlx5.c | 1 - >

[dpdk-dev] [PATCH 2/2] Move non-PCI related eth_dev initialization to rte_eth_dev_allocate()

2016-11-17 Thread Ferruh Yigit
On 11/17/2016 2:24 PM, Jan Blunck wrote: > This moves the non-PCI related initialization of the link state interrupt > callback list and the setting of the default MTU to rte_eth_dev_allocate() > so that drivers only need to set non-default values. > > Signed-off-by: Jan Blunck > --- >

[dpdk-dev] [PATCH] doc: announce kni_vhost removal

2016-11-17 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- doc/guides/prog_guide/kernel_nic_interface.rst | 2 ++ doc/guides/rel_notes/deprecation.rst | 6 ++ 2 files changed, 8 insertions(+) diff --git a/doc/guides/prog_guide/kernel_nic_interface.rst b/doc/guides/prog_guide/kernel_nic_interface.rst index

[dpdk-dev] [PATCH v2] eal/linuxapp: fix return value check of mknod()

2016-11-16 Thread Ferruh Yigit
Hi Wenzhuo, On 11/16/2016 3:28 AM, Lu, Wenzhuo wrote: > Hi Wei, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wei Dai >> Sent: Wednesday, November 16, 2016 10:41 AM >> To: dev at dpdk.org; Burakov, Anatoly; david.marchand at 6wind.com; Dai, Wei >>

[dpdk-dev] [PATCH] net/i40e: add additional prefetch instructions for bulk rx

2016-11-15 Thread Ferruh Yigit
On 10/13/2016 11:30 AM, Ananyev, Konstantin wrote: <...> Actually I can see some valid use cases where it is beneficial to have this prefetch in driver. In our sw distributor case it is trivial to just prefetch next packet on each iteration because packets are

[dpdk-dev] [PATCH v1 0/2] XStats fixes

2016-11-15 Thread Ferruh Yigit
On 11/14/2016 6:14 AM, Remy Horton wrote: > The offsets used in rte_i40evf_stats_strings for transmission > statistics were wrong, returning the total byte count rather than > the respective (unicast, multicast, broadcast, drop, & error) > packet counts. > > This patchset also fixes some spelling

[dpdk-dev] Clarification for eth_driver changes

2016-11-11 Thread Ferruh Yigit
On 11/10/2016 11:05 AM, Shreyansh Jain wrote: > Hello David, > > On Thursday 10 November 2016 01:46 PM, David Marchand wrote: >> Hello Shreyansh, >> >> On Thu, Nov 10, 2016 at 8:26 AM, Shreyansh Jain >> wrote: >>> I need some help and clarification regarding some changes I am doing to >>>

[dpdk-dev] [PATCH] improve git diff

2016-11-11 Thread Ferruh Yigit
On 11/11/2016 4:21 PM, Thomas Monjalon wrote: > 2016-11-11 11:22, Ferruh Yigit: >> On 11/9/2016 3:44 PM, Thomas Monjalon wrote: >>> Sometimes git does not print the name of the function being changed >>> after @@. It happens especially after a goto label which is not

[dpdk-dev] [PATCH v2] doc: add sub-repositories information

2016-11-11 Thread Ferruh Yigit
DPDK switched to main and sub-repositories approach, this patch documents new approach and updates development process according. Signed-off-by: Ferruh Yigit Acked-by: John McNamara --- doc/guides/contributing/patches.rst | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions

[dpdk-dev] [PATCH] doc: add sub-repositories information

2016-11-11 Thread Ferruh Yigit
Hi Shreyansh, On 11/11/2016 1:15 PM, Shreyansh Jain wrote: >> +* All sub-repositories merged into main repository for -rc1 and -rc2 >> versions of the release. > 'All sub-repositories *are* merged into ...'? I will send a fixed version. Thanks, ferruh

[dpdk-dev] [PATCH] doc: announce API and ABI changes for librte_eal

2016-11-11 Thread Ferruh Yigit
``eth_driver`` is planned to be removed in 17.02. This currently serves as >> + a placeholder for PMDs to register themselves. Changes for ``rte_bus`` >> will >> + provide a way to handle device initialization currently being done in >> + ``eth_driver``. >> -- >> 2.7.4 >> > > Acked-by: David Marchand Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH 2/2] net: align ethdev and eal driver names

2016-11-10 Thread Ferruh Yigit
On 11/10/2016 1:51 PM, David Marchand wrote: > Some virtual pmds report a different name than the vdev driver name > registered in eal. > While it does not hurt, let's try to be consistent. > > Signed-off-by: David Marchand > --- Since you did all the work, instead of second patch what do you

[dpdk-dev] [PATCH] doc: add sub-repositories information

2016-11-10 Thread Ferruh Yigit
DPDK switched to main and sub-repositories approach, this patch documents new approach and updates development process according. Signed-off-by: Ferruh Yigit --- doc/guides/contributing/patches.rst | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/doc

[dpdk-dev] [PATCH] maintainers: add staging tree for network drivers

2016-11-10 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- CC: Bruce Richardson CC: Thomas Monjalon --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 065397b..d6bb8f8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -252,6 +252,8 @@ F: examples/l2fwd-crypto/ Networking

[dpdk-dev] [PATCH v1] doc: announce API and ABI change for librte_ether

2016-11-10 Thread Ferruh Yigit
nounce API and ABI change for librte_ether >> >> In 17.02 five rte_eth_dev_set_vf_*** functions will be removed from >> librte_ether, renamed and moved to the ixgbe PMD. >> >> Signed-off-by: Bernard Iremonger > > Acked-by: John McNamara Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH v3] examples/ipsec-secgw: fix pointer to local outside scope

2016-11-07 Thread Ferruh Yigit
On 11/7/2016 5:25 PM, Fan Zhang wrote: > Coverity issue: 137871 > Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file") > > Signed-off-by: Fan Zhang > --- Although checkpatch will complain about long lines, I believe it is better not to wrap log me

[dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix copy into fixed size buffer issue

2016-11-07 Thread Ferruh Yigit
On 11/7/2016 2:21 PM, Fan Zhang wrote: > Fixes: 0d547ed0 ("examples/ipsec-secgw: support configuration > file") > Coverity issue: 137875 > > Signed-off-by: Fan Zhang Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH 2/2] bnxt: add a FALLTHROUGH comment in the cascading switch statement

2016-11-04 Thread Ferruh Yigit
On 11/3/2016 6:58 PM, Ajit Khaparde wrote: > The cascading switch statement in bnxt_hwrm.c is missing the FALLTHROUGH > comment. Adding that. > > Coverity: 127552 > > Signed-off-by: Ajit Khaparde Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix buffer not null terminated

2016-11-04 Thread Ferruh Yigit
On 11/3/2016 12:12 PM, Fan Zhang wrote: > Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file") > Coverity issue: 137854 > > Signed-off-by: Fan Zhang Acked-by: Ferruh Yigit Minor nit, for all coverity fixes, defined commit log format is: Cover

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix buffer not terminated issue

2016-11-04 Thread Ferruh Yigit
On 11/3/2016 12:12 PM, Fan Zhang wrote: > Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file") > Coverity issue: 137855 > > Signed-off-by: Fan Zhang Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix copy into fixed size buffer issue

2016-11-04 Thread Ferruh Yigit
On 11/3/2016 12:12 PM, Fan Zhang wrote: > Coverity issue: 137875 > Fixes: 0d547ed0 ("examples/ipsec-secgw: support configuration > file") > > Signed-off-by: Fan Zhang > --- > examples/ipsec-secgw/sa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[dpdk-dev] [PATCH v3] net/kni: add KNI PMD

2016-11-04 Thread Ferruh Yigit
Hi Yong, Thank you for the review. On 11/3/2016 1:24 AM, Yong Wang wrote: >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ferruh Yigit >> Sent: Monday, October 10, 2016 6:20 AM >> To: dev at dpdk.org >> Cc: Ferruh Yigit &g

[dpdk-dev] [PATCH 1/2 v2] bnxt: use appropriate data type in bnxt_alloc_vnic_attributes

2016-11-04 Thread Ferruh Yigit
On 11/3/2016 6:58 PM, Ajit Khaparde wrote: > Prevent the arithmetic in bnxt_alloc_vnic_attributes from causing > any unintentional havoc because of the usage of a signed variable. > > Coverity: 137874 > > Signed-off-by: Ajit Khaparde > > -- > v2: Previous attempt did not seem complete. > --- >

[dpdk-dev] [PATCH] E1000: fix for forced speed/duplex config

2016-11-02 Thread Ferruh Yigit
Hi Ananda, Thank you for the patch. Can you please take care a few minor issues? Patch tag should be: "net/e1000:", so patch title becomes: "net/e1000: fix for forced speed/duplex config" On 11/1/2016 10:47 PM, Ananda Sathyanarayana wrote: > From the code, it looks like, hw->mac.autoneg,

[dpdk-dev] [PATCH] igb_uio: fix build with backported kernel

2016-11-02 Thread Ferruh Yigit
On 11/2/2016 4:19 PM, martin_curran-gray at keysight.com wrote: > Hi , > > Sorry, struggling to see what happened to this thread > > I managed to get dpdk 2.2.0 to build on CentOs 6.8 by sorting the > MSIX_ENTRY_CTRL_MASKBIT > > But I'm trying to get 16.7 to run on 6.8, and am hitting the >

[dpdk-dev] [PATCH v3] net/ring: remove unnecessary NULL check

2016-11-02 Thread Ferruh Yigit
Signed-off-by: Mauricio Vasquez B > --- Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH v2] net/ring: remove unnecessary NULL check

2016-11-02 Thread Ferruh Yigit
On 11/2/2016 12:49 PM, Fulvio Risso wrote: > Dear Ferruh, > Maybe I'm wrong, but I cannot see your point. > The code is absolutely the same, only the following line > > if (eth_dev->data) { > > is actually removed. Please double check the condition "rx_queues" freed: before the patch:

[dpdk-dev] [PATCH v2] net/ring: remove unnecessary NULL check

2016-11-02 Thread Ferruh Yigit
Hi Mauricio, On 11/1/2016 7:55 PM, Mauricio Vasquez B wrote: > Coverity detected this as an issue because internals->data will never be NULL, > then the check is not necessary. > > Fixes: d082c0395bf6 ("ring: fix memory leak when detaching") > Coverity issue: 137873 > > Signed-off-by: Mauricio

[dpdk-dev] [PATCH] net: remove mempool as a dependency

2016-11-01 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- lib/librte_net/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/librte_net/Makefile b/lib/librte_net/Makefile index e5758ce..20cf664 100644 --- a/lib/librte_net/Makefile +++ b/lib/librte_net/Makefile @@ -45,7 +45,6 @@ SYMLINK

[dpdk-dev] [PATCH] doc: add missing library to release notes

2016-11-01 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- CC: Olivier Matz --- doc/guides/rel_notes/release_16_11.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11.rst index aa0c09a..5f185be 100644 --- a/doc/guides/rel_notes/release_16_11

[dpdk-dev] [PATCH] net/mlx5: fix wrong use of vector instruction

2016-11-01 Thread Ferruh Yigit
On 11/1/2016 8:13 AM, Elad Persiko wrote: > Constraint alignment was not respected in Tx. > > Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") > > Signed-off-by: Elad Persiko > --- > drivers/net/mlx5/mlx5_rxtx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

[dpdk-dev] [PATCH] pmd_ring: fix coverity issue

2016-11-01 Thread Ferruh Yigit
Hi Mauricio, On 11/1/2016 3:48 AM, Mauricio Vasquez B wrote: > internals->data will never be NULL, so the check is not necessary. > > Fixes: d082c0395bf6 ("ring: fix memory leak when detaching") > Coverity issue: 137873 > > Signed-off-by: Mauricio Vasquez B > --- Thank you for the patch. But

[dpdk-dev] [PATCH] net/bonding: not handle vlan slow packet

2016-11-01 Thread Ferruh Yigit
Hi Haifeng, On 10/31/2016 3:52 AM, linhaifeng wrote: > From: Haifeng Lin > > if rx vlan offload is enable we should not handle vlan slow > packets too. > > Signed-off-by: Haifeng Lin > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

[dpdk-dev] KNI discussion in userspace event

2016-10-28 Thread Ferruh Yigit
Hi, There was an "Interworking with the Linux Kernel" discussion in the DPDK userspace event, this mail is to summarize the output and to get more comments from community. Briefly, KNI mostly will stay as it is as an interworking with the Linux kernel solution. Out of tree kernel module concern

[dpdk-dev] [PATCH v2] eal: fix libabi macro for device generalization patches

2016-10-26 Thread Ferruh Yigit
Hi Shreyansh, On 10/26/2016 2:12 PM, Shreyansh Jain wrote: > On Wednesday 26 October 2016 06:30 PM, Shreyansh Jain wrote: >> rte_device/driver generalization patches [1] were merged without a change >> in the LIBABIVER macro. This patches bumps the macro of affected libs. >> >> Also, deprecation

[dpdk-dev] [PATCH RFC 0/2] Allow vectorized Rx with 4096 desc ring size on Intel NICs.

2016-10-19 Thread Ferruh Yigit
On 10/19/2016 3:07 PM, Ilya Maximets wrote: > Ilya Maximets (2): > net/i40e: allow bulk alloc for the max size desc ring > net/ixgbe: allow bulk alloc for the max size desc ring > > drivers/net/i40e/i40e_rxtx.c | 24 +--- > drivers/net/ixgbe/ixgbe_rxtx.c | 17

[dpdk-dev] [PATCH v4 04/32] net/qede/base: add HSI changes and register defines

2016-10-19 Thread Ferruh Yigit
On 10/19/2016 5:11 AM, Rasesh Mody wrote: > - add the hardware software interface(HSI) changes > - add register definitions > > These will be required for 8.10.9.0 FW upgrade. > > Signed-off-by: Rasesh Mody <...> > /* > * Igu cleanup bit values to distinguish between clean or producer

[dpdk-dev] [PATCH 1/2] net/i40e: fix link status change interrupt

2016-10-19 Thread Ferruh Yigit
Hi Qiming, On 10/13/2016 7:07 AM, Qiming Yang wrote: > Previously, link status interrupt in i40e is achieved by checking > LINK_STAT_CHANGE_MASK in PFINT_ICR0 register which is provided only > for diagnostic use. Instead, drivers need to get the link status > change notification by using LSE

[dpdk-dev] [PATCH v2 2/2] drivers/i40e: fix the hash filter invalid calculation in X722

2016-10-18 Thread Ferruh Yigit
On 10/16/2016 2:40 AM, Jeff Guo wrote: > As X722 extracts IPv4 header to Field Vector different with XL710/X710, > need to corresponding to modify the fields of IPv4 header in input set > to map different default Field Vector Table of different NICs. > > Signed-off-by: Jeff Guo > > --- > v2: >

[dpdk-dev] [PATCH v2 1/2] drivers/i40e: fix X722 macro absence result in compile

2016-10-18 Thread Ferruh Yigit
On 10/17/2016 10:54 AM, Ananyev, Konstantin wrote: > Hi Jeff, > >> >> hi, Konstantin >> Thanks your constructive suggestion. I don't think your question is >> silly and we also think about the code style simply and effective, but >> may be i would interpret the reason why we do that. >> >> 1)

  1   2   3   4   5   6   7   >