On 2/11/2024 4:55 AM, Kumara Parameshwaran wrote:
> In heavy-weight mode GRO which is based on timer, the GRO packets
> will not be flushed in spite of timer expiry if there is no packet
> in the current poll. If timer mode GRO is enabled the
> rte_gro_timeout_flush API should be invoked.
>
Relat
On 2/11/2024 9:30 AM, Gregory Etelson wrote:
> Template table creation API sets table flows capacity.
> If application needs more flows then the table was designed for,
> the following procedures must be completed:
> 1. Create a new template table with larger flows capacity.
> 2. Re-create existing
On 2/12/2024 5:48 AM, Stephen Hemminger wrote:
> The sfc base code had its own definition of static assertions
> using the out of bound array access hack. Replace it with a
> static_assert like rte_common.h.
>
> The use of null pointer to compute offset is not always a constant
> in older versions
On 2/8/2024 7:05 PM, Stephen Hemminger wrote:
> Rewrite the BPF program used to do queue based RSS.
> Important changes:
> - uses newer BPF map format BTF
> - accepts key as parameter rather than constant default
> - can do L3 or L4 hashing
> - supports IPv4 options
>
On 2/9/2024 12:05 AM, lon...@linuxonhyperv.com wrote:
> From: Long Li
>
> Use a MR on the stack instead of allocating it. This fixes the memory
> leak in the code where a MR is allocated but never freed.
>
> Fixes: 0f5db3c68ba7 ("net/mana: implement memory registration")
> Cc: sta...@dpdk.org
>
used in a load
> distribution scheme.
>
> Example to configure IPv6 flow label based RSS:
> flow create 0 ingress pattern eth / ipv6 / tcp / end actions rss types
> ipv6-flow-label end / end
>
> Signed-off-by: Ajit Khaparde
>
Acked-by: Ferruh Yigit
Applied to dpdk-next-net/main, thanks.
On 2/9/2024 4:07 PM, Dariusz Sosnowski wrote:
>> -Original Message-
>> From: David Marchand
>> Sent: Thursday, February 1, 2024 09:43
>> To: dev@dpdk.org
>> Cc: ktray...@redhat.com; NBU-Contact-Thomas Monjalon (EXTERNAL)
>> ; Ferruh Yigit ; Andrew
>
On 2/8/2024 12:09 PM, Jerin Jacob wrote:
> On Thu, Feb 8, 2024 at 6:15 AM Ferruh Yigit wrote:
>>
>> On 1/11/2024 5:25 AM, Kaiwen Deng wrote:
>>> Txonly forwarding engine does not call the Tx preparation API
>>> before transmitting packets. This may cause some prob
On 2/9/2024 4:52 PM, Maryam Tahhan wrote:
> On 09/02/2024 12:40, Loftus, Ciara wrote:
>>> Hi Maryam,
>>>
>>> How do you want to continue with the patch, I think options we considered:
>>>
>>> 1. Fix 'use_cni' documentation (which we can backport to LTS) and
>>> overload the argument for new purpose
On 2/9/2024 12:02 AM, lon...@linuxonhyperv.com wrote:
> From: Long Li
>
> Instead of allocating mbufs one by one during RX, use
> rte_pktmbuf_alloc_bulk() to allocate them in a batch.
>
> With this patch, there are no measurable performance improvements in
> benchmarks. However, this patch shoul
On 2/9/2024 4:00 PM, Dariusz Sosnowski wrote:
>> -Original Message-
>> From: Gregory Etelson
>> Sent: Thursday, October 26, 2023 09:31
>> To: dev@dpdk.org
>> Cc: Gregory Etelson ; Maayan Kashani
>> ; Ori Kam ; Aman Singh
>> ; Yuying Zhang
>> Subject: [PATCH] app/testpmd: add size paramete
On 2/9/2024 8:52 AM, Wei Hu wrote:
> For tx path, use LONG_PACKET_FORMAT if vlan tag is present. For rx,
> extract vlan id from oob, put into mbuf and set the vlan flags in
> mbuf.
>
> Also add myself to the maintainers list for vmbus, mana and netvsc.
>
> Signed-off-by: Wei Hu
> ---
> MAINTAIN
On 2/9/2024 3:32 PM, Thomas Monjalon wrote:
> 09/02/2024 15:58, Ferruh Yigit:
>> On 2/9/2024 1:44 PM, Thomas Monjalon wrote:
>>> 09/02/2024 13:11, Ferruh Yigit:
>>>> On 2/9/2024 10:12 AM, Thomas Monjalon wrote:
>>>>> 09/02/2024 00:54, Ferruh Yigit:
On 2/8/2024 2:45 PM, Ferruh Yigit wrote:
> On 11/11/2023 7:13 AM, Gregory Etelson wrote:
>> parse_prefix(), parse_int(), parse_mac_addr(),
>> parse_ipv4_addr() and parse_ipv6_addr() unconditionally overwrite
>> the `size` parameter with token size.
>> The `size` paramete
it for now.
>
Agree, I will drop.
> I'll post a general solution in the next iteration.
>
Ack, thanks.
> Regards,
> Gregory
> --------
> *From:* Ferruh Yigit
> *Sent:* Friday, February 9, 2024 15:55
On 2/9/2024 1:44 PM, Thomas Monjalon wrote:
> 09/02/2024 13:11, Ferruh Yigit:
>> On 2/9/2024 10:12 AM, Thomas Monjalon wrote:
>>> 09/02/2024 00:54, Ferruh Yigit:
>>>> On 1/30/2024 11:25 AM, Gavin Li wrote:
>>>>> Currently, DPDK supports VXLAN and VXLAN
On 2/9/2024 1:43 PM, Dariusz Sosnowski wrote:
>> -Original Message-
>> From: Dariusz Sosnowski
>> Sent: Friday, February 9, 2024 12:04
>> To: Gregory Etelson ; dev@dpdk.org
>> Cc: Gregory Etelson ; Maayan Kashani
>> ; Ori Kam ; Aman Singh
>> ; Yuying Zhang
>> Subject: RE: [PATCH] app/testp
On 2/9/2024 1:10 PM, Rahul Bhansali wrote:
>
>
>> -Original Message-----
>> From: Ferruh Yigit
>> Sent: Wednesday, February 7, 2024 4:06 PM
>> To: Rahul Bhansali ; dev@dpdk.org; Radu Nicolau
>> ; Akhil Goyal ; Konstantin
>> Ananyev ; Anoob J
On 2/9/2024 10:12 AM, Thomas Monjalon wrote:
> 09/02/2024 00:54, Ferruh Yigit:
>> On 1/30/2024 11:25 AM, Gavin Li wrote:
>>> Currently, DPDK supports VXLAN and VXLAN-GPE with similar header
>>> structures and we are working on adding support for VXLAN-GBP which is
>
On 1/30/2024 11:25 AM, Gavin Li wrote:
> Currently, DPDK supports VXLAN and VXLAN-GPE with similar header
> structures and we are working on adding support for VXLAN-GBP which is
> another extension to VXLAN. More extension of VXLAN may be added in the
> future.
>
> VXLAN and VXLAN-GBP use the sam
On 10/26/2023 8:30 AM, Gregory Etelson wrote:
> Testpmd always provides RAW_ENCAP flow action configuration with
> encap buffer and the buffer size.
> That implementation does not allow to create non-masked raw_encap
> action in the template API actions template.
>
> The patch adds the `size` para
On 2/7/2024 3:51 PM, Michael Baum wrote:
> Add new "rte_flow_field_id" enumeration values to describe both IPv6
> traffic class and IPv6 flow label fields.
>
> The TC value is "RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS" in flow API and
> "ipv6_traffic_class" in testpmd command.
> The FL value is "RTE_FLOW
ytes_set and hits_set flags.
>
> Fixes: 49dad9028e2a ("net/bonding: support flow API")
> Cc: ma...@mellanox.com
>
> Signed-off-by: Mário Kuka
>
Acked-by: Ferruh Yigit
Applied to dpdk-next-net/main, thanks.
On 2/8/2024 10:06 PM, Ajit Khaparde wrote:
> On supporting hardware, the 20-bit Flow Label field in the
> IPv6 header can be used to perform RSS in the ingress path.
>
> Flow label values can be chosen such that they can be
> used as part of the input to a hash function used in a load
> distributi
On 2/8/2024 6:56 PM, Ajit Khaparde wrote:
> On Thu, Feb 8, 2024 at 10:47 AM Ferruh Yigit wrote:
>>
>> On 2/8/2024 5:43 AM, Ajit Khaparde wrote:
>>> The use of 5-tuple of the source address, destination address,
>>> source port, destination port, and the trans
On 2/8/2024 5:43 AM, Ajit Khaparde wrote:
> The use of 5-tuple of the source address, destination address,
> source port, destination port, and the transport protocol type
> may not be possible due to IP fragmentation, encryption, or
> inability to parse past IPv6 extensions headers.
>
> Flow labe
On 2/8/2024 9:09 AM, Ori Kam wrote:
> During encapsulation of a packet, it is possible to change some
> outer headers to improve flow destribution.
> For example, from VXLAN RFC:
> "It is recommended that the UDP source port number
> be calculated using a hash of fields from the inner packet --
> o
On 2/7/2024 3:45 PM, Ferruh Yigit wrote:
> On 2/7/2024 3:13 AM, Andrew Boyer wrote:
>> This patchset provides miscellaneous fixes and improvements for
>> the net/ionic driver used by AMD Pensando devices.
>>
>> V3:
>> - Resend to fix patchwork threading.
>
c0a ("app/testpmd: support flow integer")
> Fixes: 6df81b325fa4 ("app/testpmd: add items eth/vlan to flow command")
> Fixes: ef6e38550f07 ("app/testpmd: add items ipv4/ipv6 to flow command")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Gregory Etelson
>
Acked-by: Ferruh Yigit
Applied to dpdk-next-net/main, thanks.
On 2/2/2024 3:04 AM, Chaoyong He wrote:
> Make multiple devices can use single core to run services for
> flower firmware.
> Also add synchronize module and service module to support it.
>
> ---
> v2:
> * Merge the last commit of v1 into the second commit.
> ---
>
> Long Wu (3):
> net/nfp: add
On 1/30/2024 6:15 PM, Etelson, Gregory wrote:
> Hello Ferruh,
>
>> So, by design, driver will keep the old table when it is resized.
>> - Can this have a performance impact, like when rules
>> updated/removed/inserted driver will need to look more tables?
>> - Or can this cause additional capacity
On 12/7/2023 6:56 PM, Stephen Hemminger wrote:
> Replace static logtype with dynamic logtype and
> remove dead code. Compile tested on Fedora.
>
> Stephen Hemminger (3):
> net/nfb: remove unused device args
> net/nfb: make device path local to init function
> net/nfb: use dynamic logtype
>
at
>
Acked-by: Ferruh Yigit
On 2/8/2024 10:50 AM, Konstantin Ananyev wrote:
>
>
>> On 1/11/2024 5:25 AM, Kaiwen Deng wrote:
>>> Txonly forwarding engine does not call the Tx preparation API
>>> before transmitting packets. This may cause some problems.
>>>
>>> TSO breaks when MSS spans more than 8 data fragments. Those
>>>
0:00:00:00:00
>
> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Dengdui Huang
> Acked-by: Chengwen Feng
>
Thanks for the fix.
Acked-by: Ferruh Yigit
Applied to dpdk-next-net/main, thanks.
On 10/11/2023 1:03 PM, Qi Zhang wrote:
> Parsing command line for rte_flow_action_prog.
>
> Syntax:
>
> "prog name [arguments \
>... end]"
>
> Use parse_string0 to parse name string.
> Use parse_hex to parse hex string.
> Use struct action_prog_data to store parsed result.
>
> Example:
>
On 12/8/2023 1:44 PM, Ferruh Yigit wrote:
> On 12/8/2023 2:38 AM, Liangxing Wang wrote:
>> The refcnt update of stored mbufs in memif driver is redundant since
>> those mbufs are only freed in eth_memif_tx_zc(). No other place
>> can free those stored mbufs quietly. So remo
/
> https://patchwork.dpdk.org/project/dpdk/patch/20231222171820.8778-9-step...@networkplumber.org/
>
Second one is larger set with multiple components involved, this one is
more specific, I will proceed with this one.
@Thomas may drop the nfp patch in that series.
>
> On Fri
On 1/11/2024 5:25 AM, Kaiwen Deng wrote:
> Txonly forwarding engine does not call the Tx preparation API
> before transmitting packets. This may cause some problems.
>
> TSO breaks when MSS spans more than 8 data fragments. Those
> packets will be dropped by Tx preparation API, but it will cause
>
On 2/7/2024 10:36 PM, Stephen Hemminger wrote:
> On Wed, 7 Feb 2024 19:10:37 +
> Ferruh Yigit wrote:
>
>> ../drivers/common/sfc_efx/base/ef10_filter.c:1246:18: error: shift count
>>> = width of type [-Werror,-Wshift-count-overflow]
>> matc
On 1/11/2024 2:21 PM, Ferruh Yigit wrote:
> On 1/11/2024 12:21 PM, Maryam Tahhan wrote:
>> On 11/01/2024 11:35, Ferruh Yigit wrote:
>>> Devarg is user interface, changing it impacts the user.
>>>
>>> Assume that user of '22.11.3' using 'use_cni
On 1/18/2024 8:36 AM, Kumara Parameshwaran wrote:
> In heavy-weight mode GRO which is based on timer, the GRO packets
> will not be flushed in spite of timer expiry if there is no packet
> in the current poll. If timer mode GRO is enabled the
> rte_gro_timeout_flush API should be invoked.
>
Agree
On 1/23/2024 11:46 AM, Ferruh Yigit wrote:
> On 1/22/2024 1:00 PM, Konstantin Ananyev wrote:
>> CAUTION: This message has originated from an External Source. Please use
>> proper judgment and caution when opening attachments, clicking links, or
>> responding to this email.
On 1/19/2024 10:13 PM, Stephen Hemminger wrote:
> The sfc base code had its own definition of static assertions
> using the out of bound array access hack. Replace it with a
> static_assert like rte_common.h.
>
> Fixes: f67e4719147d ("net/sfc/base: fix coding style")
> Signed-off-by: Stephen Hemmi
On 1/30/2024 1:24 AM, lon...@linuxonhyperv.com wrote:
> From: Long Li
>
> On MR cache expension failure, the request should fail as there is no path
> to get a new MR into the tree. Attempting to insert a new MR to the cache
> tree will result in memory violation.
>
if this patch is fixing memor
On 1/30/2024 1:24 AM, lon...@linuxonhyperv.com wrote:
> From: Long Li
>
> The content of the MR is copied to the cache trees, it's not necessary to
> allocate a MR to do this. Use a variable on the stack instead.
>
> This also fixes the memory leak in the code where a MR is allocated but
> never
-by: Satha Rao
>
Reviewed-by: Ferruh Yigit
Applied to dpdk-next-net/main, thanks.
On 2/5/2024 8:35 AM, Jie Hai wrote:
> From: Chengwen Feng
>
> This commit supports power monitor on the Rx queue descriptor of the
> next poll.
>
> Note: Although rte_power_monitor() on the ARM platform does not support
> callback, this commit still implements the callback so that it does not
>
On 2/5/2024 10:51 AM, Jie Hai wrote:
> This patch adds a telemetry command for registers dump,
> and supports get registers with specified names.
> The length of the string exported by telemetry is limited
> by MAX_OUTPUT_LEN. Therefore, the filter should be more
> precise.
>
> An example usage is
On 2/5/2024 10:51 AM, Jie Hai wrote:
> This patch adds "filter" and "names" fields to "rte_dev_reg_info"
> structure. Names of registers in data fields can be reported and
> the registers can be filtered by their names.
>
> For compatibility, the original API rte_eth_dev_get_reg_info()
> does not
evice start operation
>
> Brad Larson (1):
> net/ionic: add flexible firmware xstat counters
>
> Neel Patel (2):
> net/ionic: fix missing volatile type for cqe pointers
> net/ionic: memcpy descriptors when using Q-in-CMB
>
> Vamsi Krishna Atluri (1):
> net/ionic: report 1G and 200G link speeds when applicable
>
For series,
Acked-by: Ferruh Yigit
On 2/6/2024 1:10 AM, Jie Hai wrote:
> From: Dengdui Huang
>
> When KEEP_CRC offload is enabled, some packets will be truncated and
> the CRC is still be stripped in following cases:
> 1. For HIP08 hardware, the packet type is TCP and the length
>is less than or equal to 60B.
> 2. For other ha
On 2/7/2024 10:56 AM, Ferruh Yigit wrote:
> On 2/7/2024 10:47 AM, Ferruh Yigit wrote:
>> On 2/7/2024 9:27 AM, Thomas Monjalon wrote:
>>> 07/02/2024 01:57, Ferruh Yigit:
>>>> On 2/6/2024 10:21 PM, Thomas Monjalon wrote:
>>>>> 06/02/2024 18:36, Da
On 1/31/2024 12:46 AM, lon...@linuxonhyperv.com wrote:
> From: Long Li
>
> Secondary processes are started after primary, and in most cases with
> the device already started. Make them being able to process packets as
> soon as they start.
>
> This also works with the case where the primary proc
On 2/7/2024 10:47 AM, Ferruh Yigit wrote:
> On 2/7/2024 9:27 AM, Thomas Monjalon wrote:
>> 07/02/2024 01:57, Ferruh Yigit:
>>> On 2/6/2024 10:21 PM, Thomas Monjalon wrote:
>>>> 06/02/2024 18:36, Dariusz Sosnowski:
>>>>> --- a/doc/guides/nics/b
On 2/7/2024 9:27 AM, Thomas Monjalon wrote:
> 07/02/2024 01:57, Ferruh Yigit:
>> On 2/6/2024 10:21 PM, Thomas Monjalon wrote:
>>> 06/02/2024 18:36, Dariusz Sosnowski:
>>>> --- a/doc/guides/nics/build_and_test.rst
>>>> +++ b/doc/guides/nics/build_and_te
On 2/7/2024 6:46 AM, Rahul Bhansali wrote:
>
>
>> -Original Message-----
>> From: Ferruh Yigit
>> Sent: Tuesday, February 6, 2024 11:55 PM
>> To: Rahul Bhansali ; dev@dpdk.org; Radu Nicolau
>> ; Akhil Goyal ; Konstantin
>> Ananyev ; Anoob Joseph
On 2/1/2024 3:00 AM, Jiawen Wu wrote:
> To optimize Rx/Tx burst process, add SSE/NEON vector instructions on
> x86/arm architecture.
>
Do you have any performance improvement number with vector
implementation, if so can you put it into commit log for record?
> Signed-off-by: Jiawen Wu
> ---
>
exported by PMD.
>> + */
>
> This comment may be on one single line.
>
>> +const struct rte_flow_fp_ops *flow_fp_ops;
>> struct rte_device *device; /**< Backing device */
>> struct rte_intr_handle *intr_handle; /**< Device interrupt handle */
>
>> --- a/lib/ethdev/meson.build
>> +++ b/lib/ethdev/meson.build
>> +if get_option('buildtype').contains('debug')
>> +cflags += ['-DRTE_FLOW_DEBUG']
>> +endif
>
> This looks OK.
>
> Acked-by: Thomas Monjalon
>
>
Acked-by: Ferruh Yigit
Applied to dpdk-next-net/main, thanks.
On 2/1/2024 1:52 PM, skotesh...@marvell.com wrote:
> From: Satha Rao
>
> Existing Rx desc used count command extended to get Tx queue
> used count.
> testpmd> show port 0 rxq 0 desc used count
> testpmd> show port 0 txq 0 desc used count
>
> Signed-off-by: Satha Rao
> ---
> Depends-on:
a_type is tag a_tag_index is 1 b_type is tag b_tag_index is 2 \
> width is 32 / end actions count / drop / end
>
> Signed-off-by: Suanming Mou
> Acked-by: Ori Kam
> Acked-by: Andrew Rybchenko
>
Acked-by: Ferruh Yigit
On 2/6/2024 2:06 AM, Suanming Mou wrote:
> The new item type is added for the case user wants to match traffic
> based on packet field compare result with other fields or immediate
> value.
>
> e.g. take advantage the compare item user will be able to accumulate
> a IPv4/TCP packet's TCP data_offs
On 2/6/2024 2:06 AM, Suanming Mou wrote:
> @@ -80,6 +80,8 @@ New Features
>* Added support for Atomic Rules' TK242 packet-capture family of devices
> with PCI IDs: ``0x1024, 0x1025, 0x1026``.
>
> + * Added support for comparing result between packet fields or value.
> +
>
Comment in
On 2/6/2024 2:06 AM, Suanming Mou wrote:
> As flow field relevant data structures will be used by both actions and
> items, this commit moves the relevant data structures up to item parts.
>
> Signed-off-by: Suanming Mou
>
Acked-by: Ferruh Yigit
atible to be used by item.
>
> Signed-off-by: Suanming Mou
> Acked-by: Ori Kam
> Acked-by: Andrew Rybchenko
>
Acked-by: Ferruh Yigit
On 2/1/2024 10:08 AM, Kevin Traynor wrote:
> On 01/02/2024 08:43, David Marchand wrote:
>> As described in a recent bugzilla opened against the net/iavf driver,
>> a driver may call a event callback from other calls of the ethdev API.
>>
>> Nothing guarantees in the ethdev API against such behavior
rte_eth_dev_start(), and the callback takes a same lock, a deadlock
> + * occurs. Because of this, it is highly recommended NOT to take locks
> in
> + * those callbacks.
> + */
> typedef int (*rte_eth_dev_cb_fn)(uint16_t port_id,
> enum rte_eth_event_type event, void *cb_arg, void *ret_param);
>
Acked-by: Ferruh Yigit
On 2/6/2024 12:38 PM, Rahul Bhansali wrote:
> Single packet free using rte_pktmbuf_free_bulk() is dropping the
> performance. On cn10k, maximum of ~4% drop observed for IPsec
> event mode single SA outbound case.
>
> To fix this issue, single packet free will use rte_pktmbuf_free
> API.
>
> Fixes
On 2/2/2024 1:19 AM, lon...@linuxonhyperv.com wrote:
> From: Long Li
>
> Instead of allocating mbufs one by one during RX, use
> rte_pktmbuf_alloc_bulk() to allocate them in a batch.
>
> With this patch, there are no measurable performance improvements in
> benchmarks. However, this patch should
On 2/2/2024 3:04 AM, Chaoyong He wrote:
> Make multiple devices can use single core to run services for
> flower firmware.
> Also add synchronize module and service module to support it.
>
> ---
> v2:
> * Merge the last commit of v1 into the second commit.
>
Ask was to move the fix as first patch
On 2/1/2024 1:48 PM, Sivaramakrishnan Venkat wrote:
> Maintainers remove the Cc author line when merging the patch.
> So, the guidelines is updated with a suggestion for the placement
> of Cc lines in a commit message for easy merging.
>
> Signed-off-by: Sivaramakrishnan Venkat
> ---
> v3:
> -
On 2/1/2024 10:58 PM, Ferruh Yigit wrote:
> On 2/1/2024 3:50 PM, Sivaramakrishnan Venkat wrote:
>> Address Sanitizer detects a buffer overflow caused by an incorrect
>> ptypes list. Missing "RTE_PTYPE_UNKNOWN" ptype causes buffer overflow.
>> Fix the ptype
extending this improvement to this
dev_ops too.
Only better to mention from it in the commit log, I will update it while
merging.
> Signed-off-by: Sivaramakrishnan Venkat
>
Reviewed-by: Ferruh Yigit
<...>
> @@ -411,9 +408,9 @@ nicvf_dev_supported_ptypes_
pdate supported list of packet types")
> Fixes: 659b494d3d88 ("net/pfe: add packet types and basic statistics")
> Fixes: 398a1be14168 ("net/thunderx: remove generic passX references")
>
+ Cc: sta...@dpdk.org
I will add while merging.
> Signed-off-by: Sivaramakrishnan Venkat
> Reviewed-by: Ferruh Yigit
On 2/1/2024 12:29 PM, Suanming Mou wrote:
> diff --git a/doc/guides/rel_notes/release_24_03.rst
> b/doc/guides/rel_notes/release_24_03.rst
> index ffceab59e4..91b2cafb00 100644
> --- a/doc/guides/rel_notes/release_24_03.rst
> +++ b/doc/guides/rel_notes/release_24_03.rst
> @@ -80,6 +80,8 @@ New Fea
On 2/1/2024 12:29 PM, Suanming Mou wrote:
> Actions list
>
> @@ -5320,6 +5327,23 @@ A RAW rule can be created as following using
> ``pattern_hex`` key and mask.
> pattern_hex mask
> / end actions
>
On 2/1/2024 12:29 PM, Suanming Mou wrote:
> Current rte_flow_action_modify_data struct describes the pkt
> field perfectly and is used only in action.
>
> It is planned to be used for item as well. This commit renames
> it to "rte_flow_field_data" making it compatible to be used by item.
>
> Sign
On 2/1/2024 12:29 PM, Suanming Mou wrote:
> The new item type is added for the case user wants to match traffic
> based on packet field compare result with other fields or immediate
> value.
>
> e.g. take advantage the compare item user will be able to accumulate
> a IPv4/TCP packet's TCP data_off
> - Introduced size of array as third argument to rte_eth_devargs_parse()
> to avoid array corruption
> - Squashed separate document patch
>
>
> Harman Kalra (2):
> ethdev: parsing multiple representor devargs string
> test/devargs: add eth devargs parse cases
>
Reviewed-by: Ferruh Yigit
Squashed patches while merging,
Series applied to dpdk-next-net/main, thanks.
On 2/1/2024 4:00 PM, Ferruh Yigit wrote:
>
> On Wed, 31 Jan 2024 11:38:02 +0200, Bing Zhao wrote:
>> This patchset introduce the NAT64 action support for rte_flow.
>>
>
> Applied, thanks!
>
> [1/2] ethdev: introduce NAT64 action
> commit: 8d06f5a2da9991
d line
commit: 1d14e0581427004de88ac95e25529761f4492621
Best regards,
--
Ferruh Yigit
On 1/31/2024 10:13 PM, Joshua Washington wrote:
> This patch series introduces RSS support for the GVE poll-mode driver.
> This series includes implementations of the following eth_dev_ops:
>
> 1) rss_hash_update
> 2) rss_hash_conf_get
> 3) reta_query
> 4) reta_update
>
> In rss_hash_update, the
On 2/1/2024 11:09 AM, Suanming Mou wrote:
>
>
>> -Original Message-----
>> From: Ferruh Yigit
>> Sent: Thursday, February 1, 2024 6:56 PM
>> To: Suanming Mou ; Ori Kam ;
>> Aman Singh ; Yuying Zhang
>> ; Dariusz Sosnowski ; Slava
>> Ovsiienko
On 1/31/2024 2:57 AM, Suanming Mou wrote:
> Hi,
>
>> -Original Message-----
>> From: Ferruh Yigit
>> Sent: Wednesday, January 31, 2024 1:19 AM
>> To: Suanming Mou ; Ori Kam ;
>> Aman Singh ; Yuying Zhang
>> ; Dariusz Sosnowski ; Slava
>>
On 2/1/2024 3:55 AM, Long Li wrote:
'mbufs' is temporarily storage for allocated mbuf pointers, why not
allocate if from stack instead, can be faster and easier to manage:
"struct rte_mbuf *mbufs[count]"
>>>
>>> That would introduce a variable length array.
>>> VLA's should be remove
On 1/31/2024 5:43 PM, Ori Kam wrote:
>
>
>> -Original Message-----
>> From: Ferruh Yigit
>> Sent: Wednesday, January 31, 2024 6:46 PM
>> Subject: Re: [PATCH v3 2/3] ethdev: add compare item
>>
>> On 1/31/2024 3:56 PM, Ori Kam wrote:
>>&g
On 1/31/2024 3:56 PM, Ori Kam wrote:
> Hi
>
>> -Original Message-
>> From: Suanming Mou
>> Sent: Wednesday, January 31, 2024 4:48 AM
>>
>> Hi,
>>
>>> -Original Message-
>>> From: Ferruh Yigit
>>> Sen
On 1/26/2024 5:33 PM, Joshua Washington wrote:
> Subject: [PATCH v4 0/7] net/gve: RSS Support for GVE Driver
>
> This patch series introduces RSS support for the GVE poll-mode driver.
> This series includes implementations of the following eth_dev_ops:
>
> 1) rss_hash_update
> 2) rss_hash_conf_ge
On 1/31/2024 2:48 PM, Ferruh Yigit wrote:
> On 1/26/2024 5:33 PM, Joshua Washington wrote:
>> This patch updates the DPDK feature matrix to expose that the GVE driver
>> supports RSS hash, RSS key update, and RSS reta update.
>>
>> Signed-off-by: Joshua Washington
On 1/26/2024 5:33 PM, Joshua Washington wrote:
> This patch updates the GVE doc page to communicate that GVE now supports
> RSS configuration and explains the limitations.
>
> Signed-off-by: Joshua Washington
> ---
> doc/guides/nics/gve.rst | 16 ++--
> 1 file changed, 10 insertions(
On 1/26/2024 5:33 PM, Joshua Washington wrote:
> This patch updates the DPDK feature matrix to expose that the GVE driver
> supports RSS hash, RSS key update, and RSS reta update.
>
> Signed-off-by: Joshua Washington
> ---
> doc/guides/nics/features/gve.ini | 3 +++
> 1 file changed, 3 insertion
On 1/25/2024 4:07 PM, Sivaramakrishnan Venkat wrote:
> Missing "RTE_PTYPE_UNKNOWN" ptype causes buffer overflow.
> Enhance code such that the dev_supported_ptypes_get()
> function pointer now returns the number of elements to
> eliminate the need for "RTE_PTYPE_UNKNOWN" as the last item.
>
> Sign
On 1/30/2024 2:09 PM, Sivaramakrishnan Venkat wrote:
> Maintainers remove the Cc author line when merging the patch.
> So, the guidelines is updated with a suggestion for the placement
> of Cc lines in a commit message for easy merging.
>
> Signed-off-by: Sivaramakrishnan Venkat
> ---
> v2:
>
On 1/29/2024 6:20 PM, Harman Kalra wrote:
> Hi Ferruh
>
> Thanks for the review
> Please find response inline
>
>
>> -Original Message-----
>> From: Ferruh Yigit
>> Sent: Friday, January 26, 2024 7:13 PM
>> To: Harman Kalra ; dev@dpdk.org; Thoma
On 1/30/2024 4:43 PM, Stephen Hemminger wrote:
> On Tue, 30 Jan 2024 10:19:32 +
> Ferruh Yigit wrote:
>
>>> -mana_alloc_and_post_rx_wqes(struct mana_rxq *rxq)
>>> +mana_alloc_and_post_rx_wqes(struct mana_rxq *rxq, uint32_t count)
>>> {
>>>
On 1/30/2024 9:30 PM, Long Li wrote:
>> Can you please quantify the performance improvement (as percentage), this
>> clarifies the impact of the modification.
>
> I didn't see any meaningful performance improvements in benchmarks. However,
> this should improve CPU cycles and reduce potential loc
On 1/15/2024 9:13 AM, Suanming Mou wrote:
> The new item type is added for the case user wants to match traffic
> based on packet field compare result with other fields or immediate
> value.
>
> e.g. take advantage the compare item user will be able to accumulate
> a IPv4/TCP packet's TCP data_off
On 1/15/2024 9:13 AM, Suanming Mou wrote:
> Current rte_flow_action_modify_data struct describes the pkt
> field perfectly and is used only in action.
>
> It is planned to be used for item as well. This commit renames
> it to "rte_flow_field_data" making it compatible to be used by item.
>
ack t
On 12/17/2023 9:32 AM, Gregory Etelson wrote:
> Template table creation API sets table flows capacity.
> If application needs more flows then the table was designed for,
> the following procedures must be completed:
> 1. Create a new template table with larger flows capacity.
> 2. Re-create existin
On 1/30/2024 12:46 PM, Etelson, Gregory wrote:
> Hello Ferruh,
>
>>
>> If a multi-threaded application can add new and updated old
>> simultaneously, this should be done via monolithic API, like:
>> {
>> lock
>> resize
>> unlock
>> for each flow
>> lock
>> update
>> unlock
>> }
>>
>
601 - 700 of 2670 matches
Mail list logo
