Extended functional AES-CBC and AES-CTR cipher-only
tests to run on QAT PMD.
Added AES_CBC cipher-only performance tests on QAT PMD.
No driver changes, but as now tested, QAT documentation
is updated to remove constraint.
Signed-off-by: Fiona Trahe
---
app/test/test_cryptodev.c
In out-of-place operation, data is DMAed from source mbuf
to destination mbuf. To avoid header data in dest mbuf being
overwritten, the minimal data-set should be DMAed.
Fixes: 39e0bee48e81 ("crypto/qat: rework request builder for performance")
Signed-off-by: Fiona Trahe
---
This pat
raised, it is assumed to be not needed, so this patch
removes it, rather than add handling for the case on all PMDs.
The digest can still be appended to the data, but its
address must now be provided in the op.
Signed-off-by: Fiona Trahe
---
drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2
the second last buffer into the last buffer
so it's no longer split.
Does anyone see a problem with this?
Fiona Trahe (1):
crypto: remove unused digest-appended feature
drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 ++
drivers/crypto/qat/qat_crypto.c | 18
Issue is with the digest appended feature on QAT PMD.
A workaround is also documented.
Signed-off-by: Fiona Trahe
Acked-by: John McNamara
---
v2
- fixed trailing whitespace checkpatch errors
doc/guides/rel_notes/release_16_11.rst | 13 -
1 file changed, 12 insertions(+), 1
Issue is with the digest appended feature on QAT PMD.
A workaround is also documented.
Signed-off-by: Fiona Trahe
---
doc/guides/rel_notes/release_16_11.rst | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/doc/guides/rel_notes/release_16_11.rst
b/doc/guides
Updated comments on API to clarify which parts of mbufs are
copied or changed by crypto operations.
Signed-off-by: Fiona Trahe
---
lib/librte_cryptodev/rte_crypto_sym.h | 19 +++
1 file changed, 19 insertions(+)
diff --git a/lib/librte_cryptodev/rte_crypto_sym.h
b/lib
Add more information about VT-d/iommu settings for QAT PMD.
Remove limitation indicating QAT driver is not performance tuned.
Signed-off-by: Fiona Trahe
---
v2:
clarified commit message
doc/guides/cryptodevs/qat.rst | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
offsets for digest and data need to be adjusted
to take prepended IV into account
Signed-off-by: Fiona Trahe
---
app/test/test_cryptodev_perf.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/app/test/test_cryptodev_perf.c b/app/test/test_cryptodev_perf.c
re-factored
to do this efficiently.
Signed-off-by: Fiona Trahe
---
drivers/crypto/qat/qat_adf/icp_qat_hw.h | 5 +
drivers/crypto/qat/qat_adf/qat_algs.h| 1 +
drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 +
drivers/crypto/qat/qat_crypto.c | 239
re-factored
to do this efficiently.
Also performance test not taking IV prepend offsets
into account were corrected.
Fiona Trahe (2):
crypto/qat: rework request builder for performance
app/test: use correct offsets in AES perf test
app/test/test_cryptodev_perf.c | 15
ts_params->conf.nb_queue_pairs should not be hard coded with device
specific number. It should be retrieved from the device info.
Any test which changes it should restore it to orig value.
Signed-off-by: Akhil Goyal
Signed-off-by: Fiona Trahe
---
app/test/test_cryptodev.c | 5 -
Removed obsolete comments re inability to free and re-allocate
queue memory and obsolete workaround for it
which used to create maximum size queues first, then later
create smaller queues.
Signed-off-by: Fiona Trahe
---
app/test/test_cryptodev.c | 15 +--
app/test
Signed-off-by: Fiona Trahe
---
app/test/test_cryptodev.c | 49 +++
1 file changed, 24 insertions(+), 25 deletions(-)
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 8f40dea..db2f23c 100644
--- a/app/test/test_cryptodev.c
+++ b
Free ring memory on queue_pair release, else
releasing and setting up queue-pair of a different size fails.
Signed-off-by: Fiona Trahe
---
drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/aesni_mb
ode setting number and size of queue-pairs on a device
Also fix for aesni_mb PMD not freeing ring memory on qp release
Fiona Trahe (4):
crypto/aesni_mb: free ring memory on qp release in PMD
app/test: remove pointless for loop
app/test: cleanup unnecessary ring size setup
app/test: rem
Resending patch as first send got to mailing list but didn't get to pachwork
Improve error message if crypto PMD build is not enabled in config file
Signed-off-by: Fiona Trahe
---
app/test/test_cryptodev.c | 37 +
app/test/test_cryptodev_perf.c | 23
3DES support added to QuickAssist PMD
With CTR and CBC mode.
Both cipher-only and chained with HMAC_SHAx
This patch depends on following patch :
crypto/qat: enable support of Kasumi F8 in QAT cryptodev
http://dpdk.org/dev/patchwork/patch/15813/
Signed-off-by: Fiona Trahe
---
doc/guides
Cleanup of unused code.
Rename and simplify a badly named struct element, was aes, but
used for all types of ciphers
Print correct error msg (Unsupported rather than Undefined)
for all ciphers not supported by qat PMD.
Signed-off-by: Fiona Trahe
---
drivers/crypto/qat/qat_adf/icp_qat_hw.h
patch,
which will be sent separately.
Changes since v1:
* rebased qat.rst against Kasumi patch changes
http://dpdk.org/dev/patchwork/patch/15320/
http://dpdk.org/dev/patchwork/patch/15322/
Changes since v2:
* added 3DES to QAT PMD capabilities
* added 3DES to 16.11 release notes.
Fiona Trahe (2
From: Fiona Trahe <fiona.tr...@intel.com>
Improve error message if crypto PMD build is not enabled in config file
Signed-off-by: Fiona Trahe
---
app/test/test_cryptodev.c | 37 +
app/test/test_cryptodev_perf.c | 23 +++
2
From: Fiona Trahe <fiona.tr...@intel.com>
3DES support added to QuickAssist PMD
With CTR and CBC mode.
Both cipher-only and chained with HMAC_SHAx
This patch depends on following patch :
crypto/qat: enable support of Kasumi F8 in QAT cryptodev
http://dpdk.org/dev/patchwork/patch
From: Fiona Trahe <fiona.tr...@intel.com>
Cleanup of unused code.
Rename and simplify a badly named struct element, was aes, but
used for all types of ciphers
Print correct error msg (Unsupported rather than Undefined)
for all ciphers not supported by qat PMD.
Signed-off-by: Fiona
From: Fiona Trahe <fiona.tr...@intel.com>
Some preparatory cleanup done in QAT PMD for adding 3DES
3DES support added to QuickAssist PMD With CTR and CBC mode.
Both cipher-only and chained with HMAC_SHAx
3DES test code is included in the libcrypto patch,
which will be sent separately.
C
From: Fiona Trahe <fiona.tr...@intel.com>
This patch depends on
* 3DES QuickAssist driver patch:
http://dpdk.org/dev/patchwork/patch/15413/
* libcrypto test patch:
http://dpdk.org/dev/patchwork/patch/15344/
Signed-off-by: Fiona Trahe
---
app/test/test_cryptodev.
From: Fiona Trahe <fiona.tr...@intel.com>
3DES support added to QuickAssist PMD
With CTR and CBC mode.
Both cipher-only and chained with HMAC_SHAx
This patch depends on following patch :
crypto/qat: enable support of Kasumi F8 in QAT cryptodev
http://dpdk.org/dev/patchwork/patch
From: Fiona Trahe <fiona.tr...@intel.com>
Cleanup of unused code.
Rename and simplify a badly named struct element, was aes, but
used for all types of ciphers
Print correct error msg (Unsupported rather than Undefined)
for all ciphers not supported by qat PMD.
Signed-off-by: Fiona
From: Fiona Trahe <fiona.tr...@intel.com>
Some preparatory cleanup done in QAT PMD for adding 3DES 3DES support added to
QuickAssist PMD With CTR and CBC mode.
Both cipher-only and chained with HMAC_SHAx
3DES test code is dependent on the libcrypto patch, so will be sent separately
From: Fiona Trahe <fiona.tr...@intel.com>
3DES support added to QuickAssist PMD
With CTR and CBC mode.
Both cipher-only and chained with HMAC_SHAx
This patch depends on following patch :
crypto/qat: enable support of Kasumi F8 in QAT cryptodev
http://dpdk.org/dev/patchwork/patch
From: Fiona Trahe <fiona.tr...@intel.com>
Cleanup of unused code.
Rename and simplify a badly named struct element, was aes, but
used for all types of ciphers
Print correct error msg (Unsupported rather than Undefined)
for all ciphers not supported by qat PMD.
Signed-off-by: Fiona
From: Fiona Trahe <fiona.tr...@intel.com>
Some preparatory cleanup done in QAT PMD for adding 3DES
3DES support added to QuickAssist PMD With CTR and CBC mode.
Both cipher-only and chained with HMAC_SHAx
3DES test code is dependent on the libcrypto patch,
so will be sent separately
From: Fiona Trahe <fiona.tr...@intel.com>
using rte_mov128 instead of structure assignment to copy
template request from session context into request
Signed-off-by: Fiona Trahe
---
drivers/crypto/qat/qat_crypto.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
and the EXPERIMENTAL label should be removed.
v2:
- remove extra empty line
Signed-off-by: Fiona Trahe
---
MAINTAINERS | 2 +-
config/common_base | 1 -
lib/librte_cryptodev/rte_cryptodev.h | 3 ---
3 files changed, 1 insertion(+), 5 deletions(-)
diff
and the EXPERIMENTAL label should be removed.
v2:
- remove extra empty line
Signed-off-by: Fiona Trahe
---
MAINTAINERS | 2 +-
config/common_base | 1 -
lib/librte_cryptodev/rte_cryptodev.h | 3 ---
3 files changed, 1 insertion(+), 5 deletions(-)
diff
and the EXPERIMENTAL label should be removed.
Signed-off-by: Fiona Trahe
---
MAINTAINERS | 2 +-
config/common_base | 1 -
lib/librte_cryptodev/rte_cryptodev.h | 2 --
3 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/MAINTAINERS b
renamed rte_cryptodev_sym_session.type -> dev_type
(as it's not a session type, but a device type)
renamed rte_crypto_sym_op.type -> sess_type
(as it's not an op type, but a session type)
Signed-off-by: Fiona Trahe
---
drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 7 ---
drivers/
an error.
Fixes: 26c2e4ad5ad4 ("cryptodev: add capabilities discovery")
v2:
- extends fix to cover all crypto pmds.
Signed-off-by: Michael Qiu
Signed-off-by: Fiona Trahe
---
drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c | 16 +++---
drivers/crypto/aesni_mb/rte_aesni_mb_pmd_
Crash seen in qat pmd when nb_ops=0 on rte_cryptodev_enqueue_burst() API
Signed-off-by: Fiona Trahe
---
drivers/crypto/qat/qat_crypto.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/crypto/qat/qat_crypto.c
index 5c41a89
From: Arek Kusztal
Added AES and snow3g Authenticated encryption and decryption tests for
out-of-place operations.
Signed-off-by: Arek Kusztal
---
app/test/test_cryptodev.c | 495 -
1 files changed, 491 insertions(+),
From: Arek Kusztal
This patch adds out-of-place operations to qat symmetric crypto PMD,
i.e. the result of the operation can be written to the destination buffer
instead of overwriting the source buffer as done in "in-place" operation.
Both buffers can be of
From: Arek Kusztal
This patch adds out of place operations for qat symmetric crypto PMD,
i.e. the result of the operation can be written to the destination buffer
instead of overwriting the source buffer as done in "in-place" operation.
v2:
- updated commit
From: Arek Kusztal
Added AES and snow3g Authenticated encryption and decryption tests
Signed-off-by: Arek Kusztal
---
app/test/test_cryptodev.c | 495 -
1 files changed, 491 insertions(+), 4 deletions(-)
diff --git
From: Arek Kusztal
Driver now support out of place crypto operations,
driver assumes both buffers can be of different size.
Signed-off-by: Arek Kusztal
---
doc/guides/cryptodevs/qat.rst |1 -
drivers/crypto/qat/qat_crypto.c | 22 +-
2
From: Arek Kusztal
This patch adds out of place operations for qat symmetric crypto operations.
Arek Kusztal (2):
driver/crypto: out-of-place symmetric operations
app/test: added test for out-of-place symmetric operations
app/test/test_cryptodev.c |
From: Declan Doherty
As cryptodev library does not depend on mbuf_offload library
any longer, this patch removes it.
Signed-off-by: Declan Doherty
---
MAINTAINERS| 4 -
app/test/test_cryptodev.c | 1
From: Declan Doherty
This patch modifies the crypto burst enqueue/dequeue APIs to operate on bursts
rte_crypto_op's rather than the current implementation which operates on
rte_mbuf bursts, this simplifies the burst processing in the crypto PMDs and the
use of crypto
Remove unused phys_addr field from key in crypto_xform, simplifiy struct
and fix knock-on impacts in l2fwd-crypto app
Signed-off-by: Fiona Trahe
---
examples/l2fwd-crypto/main.c | 42 ++-
lib/librte_cryptodev/rte_crypto_sym.h | 16 ++---
2 files
of the public includes. The patch also introduces the _sym
prefix to symmetric specific structure and functions to improve clarity in
the API.
Signed-off-by: Fiona Trahe
---
app/test/test_cryptodev.c | 161 +++---
app/test/test_cryptodev_perf.c | 42
- Fixed >80char lines in test file
- Removed unused elements from stats struct
- Removed unused objects in rte_cryptodev_pmd.h
- Renamed variables
- Replaced leading spaces with tabs
- Improved performance results display in test
Signed-off-by: Fiona Trahe
Signed-off-by: Declan Doherty
---
_alloc in V3 patcheset.
- Typo fix in cached attribute on rte_crypto_op structure.
V3:
- Addresses V2 comments
- Rebased for head
Declan Doherty (2):
cryptodev: change burst API to be crypto op oriented
mbuf_offload: remove library
Fiona Trahe (3):
cryptodev: code cleanup
cryptodev: re
From: Declan Doherty
As cryptodev library does not depend on mbuf_offload library
any longer, this patch removes it.
Signed-off-by: Declan Doherty
---
MAINTAINERS| 4 -
app/test/test_cryptodev.c | 1
From: Declan Doherty
This patch modifies the crypto burst enqueue/dequeue APIs to operate on bursts
rte_crypto_op's rather than the current implementation which operates on
rte_mbuf bursts, this simplifies the burst processing in the crypto PMDs and the
use of crypto
Remove unused phys_addr field from key in crypto_xform, simplifiy struct
and fix knock-on impacts in l2fwd-crypto app
Signed-off-by: Fiona Trahe
---
examples/l2fwd-crypto/main.c | 42 ++-
lib/librte_cryptodev/rte_crypto_sym.h | 16 ++---
2 files
of the public includes. The patch also introduces the _sym
prefix to symmetric specific structure and functions to improve clarity in
the API.
Signed-off-by: Fiona Trahe
---
app/test/test_cryptodev.c | 161 +++---
app/test/test_cryptodev_perf.c | 42
- Fixed >80char lines in test file
- Removed unused elements from stats struct
- Removed unused objects in rte_cryptodev_pmd.h
- Renamed variables
- Replaced leading spaces with tabs
- Improved performance results display in test
Signed-off-by: Fiona Trahe
Signed-off-by: Declan Doherty
---
- Rebased for head
Declan Doherty (2):
cryptodev: change burst API to be crypto op oriented
mbuf_offload: remove library
Fiona Trahe (3):
cryptodev: code cleanup
cryptodev: refactor to partition common from symmetric-specific code
cryptodev: remove unused phys_addr field from key
MAINTAINERS
to the cryptodev API. It modifies the existing PMDs, unit
tests and sample application to work with the modified APIs and finally
removes the now unused rte_mbuf_offload library.
Signed-off-by: Declan Doherty
Signed-off-by: Fiona Trahe
---
MAINTAINERS| 4 -
app/test
structure of the public includes. The patch also introduces the _sym
prefix to symmetric specific structure and functions to improve clarity in
the API.
Signed-off-by: Fiona Trahe
---
app/test/test_cryptodev.c | 164 +++---
app/test/test_cryptodev_perf.c
in __rte_crypto_op_raw_bulk_alloc in V3 patcheset.
- Typo fix in cached attribute on rte_crypto_op structure.
V3:
- Addresses V2 comments
- Rebased for head
Declan Doherty (1):
cryptodev: change burst API to be crypto op oriented
Fiona Trahe (2):
cryptodev: API tidy and changes to support future
to the cryptodev API. It modifies the existing PMDs, unit
tests and sample application to work with the modified APIs and finally
removes the now unused rte_mbuf_offload library.
Signed-off-by: Declan Doherty
Signed-off-by: Fiona Trahe
---
MAINTAINERS| 4 -
app/test
structure of the public includes. The patch also introduces the _sym
prefix to symmetric specific structure and functions to improve clarity in
the API.
Signed-off-by: Fiona Trahe
---
app/test/test_cryptodev.c | 164 +++---
app/test/test_cryptodev_perf.c
structure.
V3:
- Addresses V2 comments
- Rebased for head
Declan Doherty (1):
cryptodev: change burst API to be crypto op oriented
Fiona Trahe (1):
cryptodev: API tidy and changes to support future extensions
MAINTAINERS| 4 -
app/test
rte_crypto_op pools to the cryptodev API. It modifies the existing PMDs, unit
tests and sample application to work with the modified APIs and finally
removes the now unused rte_mbuf_offload library.
Signed-off-by: Declan Doherty
Signed-off-by: Fiona Trahe
---
MAINTAINERS
Signed-off-by: Fiona Trahe
---
app/test/test_cryptodev.c | 164 +++---
app/test/test_cryptodev_perf.c | 79 +--
drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 44 +-
drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 6 +-
drivers/crypto
in __rte_crypto_op_raw_bulk_alloc in V3 patcheset.
- Typo fix in cached attribute on rte_crypto_op structure.
V3:
- Addresses V2 comments
- Rebased for head
Declan Doherty (1):
cryptodev: change burst API to be crypto op oriented
Fiona Trahe (1):
cryptodev: API tidy and changes to support future
Signed-off-by: Fiona Trahe
---
MAINTAINERS |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index b90aeea..748197f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -353,6 +353,9 @@ M: Declan Doherty
F: drivers/crypto/aesni_mb/
Intel
66 matches
Mail list logo