On 29.11.2016 15:50, Ananyev, Konstantin wrote:
> Hi Ilya,
>
>> Ping.
>>
>> Best regards, Ilya Maximets.
>>
>> On 19.10.2016 17:07, Ilya Maximets wrote:
>>> The only reason why bulk alloc disabled for the rings with
>>> more than (I40E_MAX_
Ping.
Best regards, Ilya Maximets.
On 19.10.2016 17:07, Ilya Maximets wrote:
> The only reason why bulk alloc disabled for the rings with
> more than (IXGBE_MAX_RING_DESC - RTE_PMD_IXGBE_RX_MAX_BURST)
> descriptors is the possible out-of-bound access to the dma
> memory. But it's th
Ping.
Best regards, Ilya Maximets.
On 19.10.2016 17:07, Ilya Maximets wrote:
> The only reason why bulk alloc disabled for the rings with
> more than (I40E_MAX_RING_DESC - RTE_PMD_I40E_RX_MAX_BURST)
> descriptors is the possible out-of-bound access to the dma
> memory. But it's th
PM, Ferruh Yigit
> wrote:
>>
>> Is there an update for this patch? Is a consensus reached?
Ferruh, I didn't receive any response on my e-mails. I've pinged this thread
few times, but didn't receive any feedback and I have no idea what patch Jan
talking about.
Best regards, Ilya Maximets.
Ping.
On 28.10.2016 09:14, Ilya Maximets wrote:
> On 25.10.2016 09:26, Ilya Maximets wrote:
>> On 24.10.2016 17:54, Jan Blunck wrote:
>>> On Wed, Oct 19, 2016 at 5:47 AM, Ilya Maximets
>>> wrote:
>>>> On 18.10.2016 18:19, Jan Blunck wrote:
>>>&
On 25.10.2016 09:26, Ilya Maximets wrote:
> On 24.10.2016 17:54, Jan Blunck wrote:
>> On Wed, Oct 19, 2016 at 5:47 AM, Ilya Maximets
>> wrote:
>>> On 18.10.2016 18:19, Jan Blunck wrote:
>>>> On Tue, Oct 18, 2016 at 2:49 PM, Ilya Maximets
>>>> wr
On 24.10.2016 17:54, Jan Blunck wrote:
> On Wed, Oct 19, 2016 at 5:47 AM, Ilya Maximets
> wrote:
>> On 18.10.2016 18:19, Jan Blunck wrote:
>>> On Tue, Oct 18, 2016 at 2:49 PM, Ilya Maximets
>>> wrote:
>>>> On 18.10.2016 15:28, Jan Blunck wrote:
&
-off-by: Ilya Maximets
---
drivers/net/ixgbe/ixgbe_rxtx.c | 17 +
drivers/net/ixgbe/ixgbe_rxtx.h | 2 +-
2 files changed, 2 insertions(+), 17 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index 2ce8234..07c04c3 100644
--- a/drivers/net
-by: Ilya Maximets
---
drivers/net/i40e/i40e_rxtx.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 7ae7d9f..1f76691 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e
Ilya Maximets (2):
net/i40e: allow bulk alloc for the max size desc ring
net/ixgbe: allow bulk alloc for the max size desc ring
drivers/net/i40e/i40e_rxtx.c | 24 +---
drivers/net/ixgbe/ixgbe_rxtx.c | 17 +
drivers/net/ixgbe/ixgbe_rxtx.h | 2 +-
3 files
On 18.10.2016 18:19, Jan Blunck wrote:
> On Tue, Oct 18, 2016 at 2:49 PM, Ilya Maximets
> wrote:
>> On 18.10.2016 15:28, Jan Blunck wrote:
>>> If the application already configured queues the PMD should not
>>> silently claim ownership and reset them.
>>&g
>= 0) && (ops_index < RTE_MEMPOOL_MAX_OPS_IDX)"
failed
You may just start OVS 2.6 with DPDK bonding device and attempt to change MTU
via 'mtu_request'.
Bug is easily reproducible.
Best regards, Ilya Maximets.
>
> On Wed, Sep 7, 2016 at 2:28 PM, Il
On 07.10.2016 05:02, Eric Kinzie wrote:
> On Wed Sep 07 15:28:10 +0300 2016, Ilya Maximets wrote:
>> This reverts commit 5b7bb2bda5519b7800f814df64d4e015282140e5.
>>
>> It is necessary to reconfigure all queues every time because configuration
>> can be changed.
Ping.
Best regards, Ilya Maximets.
On 07.09.2016 15:28, Ilya Maximets wrote:
> This reverts commit 5b7bb2bda5519b7800f814df64d4e015282140e5.
>
> It is necessary to reconfigure all queues every time because configuration
> can be changed.
>
> For example, if we're reconfigur
mempool be freed, application likely will panic in attempt to use
freed mempool.
This happens when we use the bonding device with OVS 2.6 while MTU
reconfiguration:
PANIC in rte_mempool_get_ops():
assert "(ops_index >= 0) && (ops_index < RTE_MEMPOOL_MAX_OPS_IDX)" failed
tes and
the higher maximum performance that is very sad.
Using of 16B descriptors doesn't really help with performance.
Upgrading the firmware from version 4.4 to 5.04 didn't help with drops.
Any thoughts? Can anyone reproduce this?
Best regards, Ilya Maximets.
On 21.07.2016 16:35, Yuanhan Liu wrote:
> On Thu, Jul 21, 2016 at 04:19:35PM +0300, Ilya Maximets wrote:
>> If something abnormal happened to QEMU, 'connect()' can block calling
>> thread (e.g. main thread of OVS) forever or for a really long time.
>> This can break whole
main
Fix that by setting non-blocking mode for client sockets for connection.
Fixes: 64ab701c3d1e ("vhost: add vhost-user client mode")
Signed-off-by: Ilya Maximets
---
This was reproduced with current QEMU master branch
(commit 1ecfb24da987b862f) + patch-set "vhost-use
On 21.07.2016 15:58, Yuanhan Liu wrote:
> On Thu, Jul 21, 2016 at 03:42:54PM +0300, Ilya Maximets wrote:
>> On 21.07.2016 15:35, Yuanhan Liu wrote:
>>> On Thu, Jul 21, 2016 at 03:13:14PM +0300, Ilya Maximets wrote:
>>>>>>
>>>>>> What do yo
I've fixed leak of file descriptors in 'vhost_user_remove_reconnect()'
and sent v3.
On 21.07.2016 11:31, Ilya Maximets wrote:
> Currently while calling of 'rte_vhost_driver_unregister()' connection
> to QEMU will not be closed. This leads to inability to register driver
> again and
connections from reconnection list.
Fixes: 64ab701c3d1e ("vhost: add vhost-user client mode")
Signed-off-by: Ilya Maximets
---
Version 3:
* fixed leak of file descriptors by adding of
'close(reconn->fd)' to 'vhost_user_remove_reconnect()'
Version 2:
* style
On 21.07.2016 15:35, Yuanhan Liu wrote:
> On Thu, Jul 21, 2016 at 03:13:14PM +0300, Ilya Maximets wrote:
>>>>
>>>> What do you think of it?
>>>
>>> I found that we can't check connection status without select/poll
>>> on it. 'ge
On 21.07.2016 15:10, Ilya Maximets wrote:
> On 21.07.2016 14:40, Yuanhan Liu wrote:
>> On Thu, Jul 21, 2016 at 02:14:59PM +0300, Ilya Maximets wrote:
>>>> Hmm, how about this fixup:
>>>> ---
On 21.07.2016 14:40, Yuanhan Liu wrote:
> On Thu, Jul 21, 2016 at 02:14:59PM +0300, Ilya Maximets wrote:
>>> Hmm, how about this fixup:
>>> --
>>> diff --git a/lib/librte_vhost/vhost_us
On 21.07.2016 13:37, Ilya Maximets wrote:
>
>
> On 21.07.2016 13:13, Yuanhan Liu wrote:
>> On Thu, Jul 21, 2016 at 12:45:32PM +0300, Ilya Maximets wrote:
>>> On 21.07.2016 12:37, Yuanhan Liu wrote:
>>>> On Thu, Jul 21, 2016 at 11:21:15AM +0300, Ilya Maximet
main
Fix that by setting non-blocking mode for client sockets for connection.
Fixes: 64ab701c3d1e ("vhost: add vhost-user client mode")
Signed-off-by: Ilya Maximets
---
This was reproduced with current QEMU master branch
(commit 1ecfb24da987b862f) + patch-set "vhost-use
e_mbuf **rx_pkts) if nb_pkts is less than 32.
Fix this by actually using nb_pkts inside the loop.
Fixes: 9ed94e5bb04e ("i40e: add vector Rx")
Signed-off-by: Sergey Dyasly
Acked-by: Ilya Maximets
---
drivers/net/i40e/i40e_rxtx_vec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On 21.07.2016 13:13, Yuanhan Liu wrote:
> On Thu, Jul 21, 2016 at 12:45:32PM +0300, Ilya Maximets wrote:
>> On 21.07.2016 12:37, Yuanhan Liu wrote:
>>> On Thu, Jul 21, 2016 at 11:21:15AM +0300, Ilya Maximets wrote:
>>>> If something abnormal happened to QEMU,
On 21.07.2016 12:37, Yuanhan Liu wrote:
> On Thu, Jul 21, 2016 at 11:21:15AM +0300, Ilya Maximets wrote:
>> If something abnormal happened to QEMU, 'connect()' can block calling
>> thread (e.g. main thread of OVS) forever or for a really long time.
>> This can break whole
Thanks. Fixed.
Best regards, Ilya Maximets.
On 21.07.2016 11:24, Yuanhan Liu wrote:
> On Wed, Jul 20, 2016 at 11:32:43AM +0300, Ilya Maximets wrote:
>> Currently while calling of 'rte_vhost_driver_unregister()' connection
>> to QEMU will not be closed. This leads to inability to
connections from reconnection list.
Fixes: 64ab701c3d1e ("vhost: add vhost-user client mode")
Acked-by: Yuanhan Liu
Signed-off-by: Ilya Maximets
---
lib/librte_vhost/vhost_user/fd_man.c | 15 ++--
lib/librte_vhost/vhost_user/fd_man.h | 2 +-
lib/librte_vhost/vhost_
main
Fix that by setting non-blocking mode for client sockets for connection.
Fixes: 64ab701c3d1e ("vhost: add vhost-user client mode")
Signed-off-by: Ilya Maximets
---
This was reproduced with current QEMU master branch
(commit 1ecfb24da987b862f) + patch-set "vhost-use
connections from reconnection list.
Fixes: 64ab701c3d1e ("vhost: add vhost-user client mode")
Signed-off-by: Ilya Maximets
---
Patch prepared for master branch because dpdk-next-virtio doesn't contain
commit acbff5c67ea7 ("vhost: fix crash when exceeding file descriptors").
nge number of virtqueues dynamically inside VM.
Fix that by checking addresses of descriptors before using.
Signed-off-by: Ilya Maximets
---
lib/librte_vhost/vhost_rxtx.c | 29 -
1 file changed, 24 insertions(+), 5 deletions(-)
diff --git a/lib/librte_vhost/vhost_rx
Signed-off-by: Ilya Maximets
---
lib/librte_vhost/vhost_rxtx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c
index 15ca956..a9b04df 100644
--- a/lib/librte_vhost/vhost_rxtx.c
+++ b/lib/librte_vhost/vhost_rxtx.c
,
because needed refactoring already done.
* Commit-message changed because old issue with
virtio reload accidentially fixed by commit
0823c1cb0a73.
Ilya Maximets (2):
vhost: fix using of bad return value on mergeable enqueue
vhost: do sanity check for ring
On 15.07.2016 09:17, Yuanhan Liu wrote:
> On Thu, Jul 14, 2016 at 11:18:39AM +0300, Ilya Maximets wrote:
>> In current implementation vhost will crash with segmentation fault
>> if malicious or buggy virtio application breaks addresses of descriptors.
>>
>> Before com
.
Fix that by checking addresses of descriptors before using.
Also fixed return value on error for 'copy_mbuf_to_desc_mergeable()'
from '-1' to '0' because it returns unsigned value and it means
number of used descriptors.
Signed-off-by: Ilya Maximets
---
Version 2:
* Rebased on top
On 14.07.2016 04:42, Yuanhan Liu wrote:
> On Wed, Jul 13, 2016 at 08:54:08AM -0700, Rich Lane wrote:
>> On Wednesday, July 13, 2016, Yuanhan Liu
>> wrote:
>>
>> On Wed, Jul 13, 2016 at 10:34:07AM +0300, Ilya Maximets wrote:
>> > This scenario fixed so
On 12.07.2016 08:53, Ilya Maximets wrote:
> On 12.07.2016 05:43, Yuanhan Liu wrote:
>> On Mon, Jul 11, 2016 at 02:47:56PM +0300, Ilya Maximets wrote:
>>> On 11.07.2016 14:05, Yuanhan Liu wrote:
>>>> On Mon, Jul 11, 2016 at 12:50:24PM +0300, Ilya Maximets wrote:
>
On 12.07.2016 05:43, Yuanhan Liu wrote:
> On Mon, Jul 11, 2016 at 02:47:56PM +0300, Ilya Maximets wrote:
>> On 11.07.2016 14:05, Yuanhan Liu wrote:
>>> On Mon, Jul 11, 2016 at 12:50:24PM +0300, Ilya Maximets wrote:
>>>> On 11.07.2016 11:38, Yuanhan Liu wrote:
>&
On 11.07.2016 11:38, Yuanhan Liu wrote:
> On Sun, Jul 10, 2016 at 09:17:31PM +0800, Yuanhan Liu wrote:
>> On Fri, Jul 08, 2016 at 02:48:56PM +0300, Ilya Maximets wrote:
>>>
>>> Another point is that crash constantly happens on queue_id=3 (second RX
>>> qu
On 06.07.2016 15:24, Yuanhan Liu wrote:
> On Wed, Jul 06, 2016 at 02:19:12PM +0300, Ilya Maximets wrote:
>> On 01.07.2016 10:35, Yuanhan Liu wrote:
>>> Hi,
>>>
>>> Sorry for the long delay.
>>>
>>> On Fri, May 20, 2016 at 03:50:04PM +0300, Ily
On 01.07.2016 10:35, Yuanhan Liu wrote:
> Hi,
>
> Sorry for the long delay.
>
> On Fri, May 20, 2016 at 03:50:04PM +0300, Ilya Maximets wrote:
>> In current implementation guest application can reinitialize vrings
>> by executing start after stop. In the same time ho
Since
commit f2bb7ae1d204 ("app/testpmd: handle all Rx queues in RSS setup")
behavior of rss_fwd_config_setup() changed and description of this
function is wrong now.
Also, there is a type mismatch in a loop.
Signed-off-by: Ilya Maximets
---
app/test-pmd/config.c | 17 ++-
Fixes memory leak on QEMU migration.
Fixes: 54f9e32305d4 ("vhost: handle dirty pages logging request")
Signed-off-by: Ilya Maximets
---
lib/librte_vhost/vhost-net.h | 1 +
lib/librte_vhost/vhost_user/virtio-net-user.c | 15 +--
2 files changed, 14 insert
g (deleted)
root qemu 1004 -> /memfd:vhost-log (deleted)
[...]
root qemu 996 -> /memfd:vhost-log (deleted)
root qemu 997 -> /memfd:vhost-log (deleted)
ovs-vswitchd.log:
|WARN|punix:ovs-vswitchd.ctl: accept failed: Too many open files
Fixes: 54f9e32305d4 ("vhost: handle dirty p
v2:
* rebased on top of dpdk-next-virtio/master
Ilya Maximets (2):
vhost: fix leak of file descriptors.
vhost: unmap log memory on cleanup.
lib/librte_vhost/vhost-net.h | 1 +
lib/librte_vhost/vhost_user/virtio-net-user.c | 16 ++--
2 files changed, 15
Fixes memory leak on QEMU migration.
Fixes: 54f9e32305d4 ("vhost: handle dirty pages logging request")
Signed-off-by: Ilya Maximets
---
lib/librte_vhost/rte_virtio_net.h | 3 ++-
lib/librte_vhost/vhost_user/virtio-net-user.c | 15 +--
2 files changed, 15
g (deleted)
root qemu 1004 -> /memfd:vhost-log (deleted)
[...]
root qemu 996 -> /memfd:vhost-log (deleted)
root qemu 997 -> /memfd:vhost-log (deleted)
ovs-vswitchd.log:
|WARN|punix:ovs-vswitchd.ctl: accept failed: Too many open files
Fixes: 54f9e32305d4 ("vhost: handle dirty p
Ilya Maximets (2):
vhost: fix leak of file descriptors.
vhost: unmap log memory on cleanup.
lib/librte_vhost/rte_virtio_net.h | 3 ++-
lib/librte_vhost/vhost_user/virtio-net-user.c | 16 ++--
2 files changed, 16 insertions(+), 3 deletions(-)
--
2.7.4
On 02.06.2016 19:22, Rich Lane wrote:
> On Thu, Jun 2, 2016 at 3:46 AM, Ilya Maximets <mailto:i.maximets at samsung.com>> wrote:
>
> Hi, Rich.
> Thank you for testing and analysing.
>
> On 01.06.2016 01:06, Rich Lane wrote:
> > On Fri, May 2
Hi, Rich.
Thank you for testing and analysing.
On 01.06.2016 01:06, Rich Lane wrote:
> On Fri, May 20, 2016 at 5:50 AM, Ilya Maximets <mailto:i.maximets at samsung.com>> wrote:
>
> In current implementation guest application can reinitialize vrings
> by execu
ks.
>
> --yliu
>
> On Mon, May 30, 2016 at 02:05:07PM +0300, Ilya Maximets wrote:
>> Ping.
>>
>> Best regards, Ilya Maximets.
>>
>> On 23.05.2016 14:04, Ilya Maximets wrote:
>>> On 23.05.2016 13:57, Yuanhan Liu wrote:
>>>> On Fri, Ma
On 31.05.2016 09:53, Tan, Jianfeng wrote:
> Hi,
>
>
> On 5/30/2016 8:24 PM, Ilya Maximets wrote:
>> On 30.05.2016 15:00, Tan, Jianfeng wrote:
>>> Hi,
>>>
>>>> -----Original Message-
>>>> From: Ilya Maximets [mailto:i.maxi
On 30.05.2016 15:00, Tan, Jianfeng wrote:
> Hi,
>
>> -Original Message-----
>> From: Ilya Maximets [mailto:i.maximets at samsung.com]
>> Sent: Friday, May 20, 2016 8:50 PM
>> To: dev at dpdk.org; Xie, Huawei; Yuanhan Liu
>> Cc: Dyasly Sergey; Heet
Ping.
Best regards, Ilya Maximets.
On 23.05.2016 14:04, Ilya Maximets wrote:
> On 23.05.2016 13:57, Yuanhan Liu wrote:
>> On Fri, May 20, 2016 at 03:50:04PM +0300, Ilya Maximets wrote:
>>> In current implementation guest application can reinitialize vrings
>>> by
On 23.05.2016 13:57, Yuanhan Liu wrote:
> On Fri, May 20, 2016 at 03:50:04PM +0300, Ilya Maximets wrote:
>> In current implementation guest application can reinitialize vrings
>> by executing start after stop. In the same time host application
>> can still poll virtqueue
ed. This is done
because checking of host's address in mergeable case requires additional
refactoring to keep virtqueue in consistent state in case of error.
Signed-off-by: Ilya Maximets
---
Actually, current virtio implementation looks broken for me. Because
'virtio_dev_start' breaks virtqueue
Hi, Christian.
You're, likely, using tar archive with openvswitch from openvswitch.org.
It doesn't contain many bug fixes from git/branch-2.5 unfortunately.
The problem that you are facing has been solved in branch-2.5 by
commit d9df7b9206831631ddbd90f9cbeef1b4fc5a8e89
Author: Ilya Maximets
--- Original Message ---
Sender : Yuanhan Liu
Date : Apr 06, 2016 08:38 (GMT+03:00)
Title : Re: Re: [RFC] vhost-user public struct refactor (was Re: [dpdk-dev]
[PATCH RFC 2/4] vhost: make buf vector for scatter RX) local.
On Wed, Apr 06, 2016 at 05:11:01AM +, Ilya Maximets wrote
:
> On Fri, Feb 19, 2016 at 03:06:50PM +0800, Yuanhan Liu wrote:
> > On Fri, Feb 19, 2016 at 09:32:41AM +0300, Ilya Maximets wrote:
> > > Array of buf_vector's is just an array for temporary storing information
> > > about available descriptors. It used only loc
On 18.03.2016 15:41, Yuanhan Liu wrote:
> On Fri, Mar 18, 2016 at 03:23:53PM +0300, Ilya Maximets wrote:
>> Since commit 4c02e453cc62 ("eal: introduce SMP memory barriers") virtio
>> uses architecture dependent SMP barriers. vHost should use them too.
>>
>>
CC to list.
On 18.03.2016 15:19, Ilya Maximets wrote:
>
>
> On 18.03.2016 14:42, Ilya Maximets wrote:
>> On 18.03.2016 14:30, Xie, Huawei wrote:
>>> On 3/18/2016 7:00 PM, Ilya Maximets wrote:
>>>> On 18.03.2016 13:47, Xie, Huawei wrote:
>>>
Since commit 4c02e453cc62 ("eal: introduce SMP memory barriers") virtio
uses architecture dependent SMP barriers. vHost should use them too.
Fixes: 4c02e453cc62 ("eal: introduce SMP memory barriers")
Signed-off-by: Ilya Maximets
---
lib/librte_vhost/vhost_rxtx.c | 7 --
On 18.03.2016 13:47, Xie, Huawei wrote:
> On 3/18/2016 6:39 PM, Ilya Maximets wrote:
>>
>> On 18.03.2016 13:27, Xie, Huawei wrote:
>>> On 3/18/2016 6:23 PM, Ilya Maximets wrote:
>>>> On 18.03.2016 13:08, Xie, Huawei wrote:
>>>
On 18.03.2016 13:27, Xie, Huawei wrote:
> On 3/18/2016 6:23 PM, Ilya Maximets wrote:
>> On 18.03.2016 13:08, Xie, Huawei wrote:
>>> On 2/24/2016 7:47 PM, Ilya Maximets wrote:
>>>> * Wait until it's our turn to add our buffer
>>>> @@ -979,
On 18.03.2016 13:08, Xie, Huawei wrote:
> On 2/24/2016 7:47 PM, Ilya Maximets wrote:
>> * Wait until it's our turn to add our buffer
>> @@ -979,7 +979,7 @@ rte_vhost_dequeue_burst(struct virtio_net *dev, uint16_t
>> queue_id,
>>
> On Thu, Mar 17, 2016 at 04:29:32PM +0100, Thomas Monjalon wrote:
>>>>>> 2016-02-24 14:47, Ilya Maximets:
>>>>>>> Implementation of rte_vhost_enqueue_burst() based on lockless
>>>>>>> ring-buffer
>>>>>>> algorithm
off-by: Ilya Maximets
---
lib/librte_vhost/vhost_rxtx.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c
index a8e2582..4d37aa3 100644
--- a/lib/librte_vhost/vhost_rxtx.c
+++ b/lib/librte_vhost/vhost_rxt
vhost_virtqueue marked as deprecated.
Signed-off-by: Ilya Maximets
---
doc/guides/rel_notes/deprecation.rst | 1 +
lib/librte_vhost/rte_virtio_net.h| 2 +-
lib/librte_vhost/vhost_rxtx.c| 49 ++--
3 files changed, 27 insertions(+), 25 deletions(-)
diff
Since commit 4c02e453cc62 ("eal: introduce SMP memory barriers") virtio
uses architecture dependent SMP barriers. vHost should use them too.
Fixes: 4c02e453cc62 ("eal: introduce SMP memory barriers")
Signed-off-by: Ilya Maximets
---
lib/librte_vhost/vhost_rxtx.c | 6 +++--
for the future.
* buf_vec field of struct vhost_virtqueue marked as deprecated.
Ilya Maximets (3):
vhost: use SMP barriers instead of compiler ones.
vhost: make buf vector for scatter RX local.
vhost: avoid reordering of used->idx and last_used_idx updating.
doc/guides/rel_no
On 23.02.2016 08:56, Xie, Huawei wrote:
> On 2/22/2016 6:16 PM, Thomas Monjalon wrote:
>> 2016-02-22 02:07, Xie, Huawei:
>>> On 2/19/2016 5:05 PM, Ilya Maximets wrote:
>>>> On 19.02.2016 11:36, Xie, Huawei wrote:
>>>>> On 2/19/2016 3:10 PM, Yuanhan Li
off-by: Ilya Maximets
---
lib/librte_vhost/vhost_rxtx.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c
index 9095fb1..a03f687 100644
--- a/lib/librte_vhost/vhost_rxtx.c
+++ b/lib/librte_vhost/vhost_rxt
vhost_virtqueue marked as deprecated.
Signed-off-by: Ilya Maximets
---
doc/guides/rel_notes/deprecation.rst | 1 +
lib/librte_vhost/rte_virtio_net.h| 2 +-
lib/librte_vhost/vhost_rxtx.c| 45 ++--
3 files changed, 25 insertions(+), 23 deletions(-)
diff
Since commit 4c02e453cc62 ("eal: introduce SMP memory barriers") virtio
uses architecture dependent SMP barriers. vHost should use them too.
Fixes: 4c02e453cc62 ("eal: introduce SMP memory barriers")
Signed-off-by: Ilya Maximets
---
lib/librte_vhost/vhost_rxtx.c | 6 +++--
vhost_virtqueue marked as deprecated.
Ilya Maximets (3):
vhost: use SMP barriers instead of compiler ones.
vhost: make buf vector for scatter RX local.
vhost: avoid reordering of used->idx and last_used_idx updating.
doc/guides/rel_notes/deprecation.rst | 1 +
lib/librte_vhost/rte_virtio_ne
On 19.02.2016 11:36, Xie, Huawei wrote:
> On 2/19/2016 3:10 PM, Yuanhan Liu wrote:
>> On Fri, Feb 19, 2016 at 09:32:43AM +0300, Ilya Maximets wrote:
>>> Signed-off-by: Ilya Maximets
>>> ---
>>> doc/guides/prog_guide/thread_safety_dpdk_functions.rst |
On 19.02.2016 10:06, Yuanhan Liu wrote:
> On Fri, Feb 19, 2016 at 09:32:41AM +0300, Ilya Maximets wrote:
>> Array of buf_vector's is just an array for temporary storing information
>> about available descriptors. It used only locally in virtio_dev_merge_rx()
>> a
Signed-off-by: Ilya Maximets
---
doc/guides/prog_guide/thread_safety_dpdk_functions.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/doc/guides/prog_guide/thread_safety_dpdk_functions.rst
b/doc/guides/prog_guide/thread_safety_dpdk_functions.rst
index 403e5fc..13a6c89 100644
--- a/doc
off-by: Ilya Maximets
---
lib/librte_vhost/vhost_rxtx.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c
index 9095fb1..a03f687 100644
--- a/lib/librte_vhost/vhost_rxtx.c
+++ b/lib/librte_vhost/vhost_rxt
Array of buf_vector's is just an array for temporary storing information
about available descriptors. It used only locally in virtio_dev_merge_rx()
and there is no reason for that array to be shared.
Fix that by allocating local buf_vec inside virtio_dev_merge_rx().
Signed-off-by: Ilya Maximets
Since commit 4c02e453cc62 ("eal: introduce SMP memory barriers") virtio
uses architecture dependent SMP barriers. vHost should use them too.
Fixes: 4c02e453cc62 ("eal: introduce SMP memory barriers")
Signed-off-by: Ilya Maximets
---
lib/librte_vhost/vhost_rxtx.c | 6 +++--
.
Second and third adds fixes to make rte_vhost_enqueue_burst thread safe.
Last is a documentation fix.
Ilya Maximets (4):
vhost: use SMP barriers instead of compiler ones.
vhost: make buf vector for scatter RX local.
vhost: avoid reordering of used->idx and last_used_idx updating.
doc:
id in memcpy:
> /**
> * Copy 16 bytes from one location to another,
> * locations should not overlap.
> */
>
Isn't it enough to have an error in the log?
lib/librte_vhost/vhost_user/vhost-net-user.c:130:
RTE_LOG(ERR, VHOST_CONFIG, "fail to bind fd:%d, remove file:%s and try
ated problem discussed previously here
( http://dpdk.org/ml/archives/dev/2015-December/030326.html )
fixed in OVS by
commit 9b5422a98f817b9f2a1f8224cab7e1a8d0bbba1f
Author: Ilya Maximets
Date: Wed Dec 16 15:32:21 2015 +0300
ovs-lib: Try to call exit before killing.
While killing OVS may
Sorry for pinging, but have you tried to merge this patch?
Best regards, Ilya Maximets.
On 02.10.2015 14:25, Wiles, Keith wrote:
> I looked at the code and everything looks good. I will try to merge the
> code next week as I am traveling again :-(
>
> Thanks for the patch, I am gl
Ping.
On 17.09.2015 08:55, Ilya Maximets wrote:
> Ok. Thank you. I'll wait.
>
> On 16.09.2015 18:37, Wiles, Keith wrote:
>> Thanks the patch looks fine, but I have not had a lot of time to review it
>> detail. I hope to get to it next week after I return back home.
>
Ok. Thank you. I'll wait.
On 16.09.2015 18:37, Wiles, Keith wrote:
> Thanks the patch looks fine, but I have not had a lot of time to review it
> detail. I hope to get to it next week after I return back home.
>
> On 9/16/15, 2:09 AM, "Ilya Maximets" wrote:
>
>>
Ping.
On 09.09.2015 17:22, Ilya Maximets wrote:
> While pktgen_setup_packets() all threads of one port uses same
> info->seq_pkt. This leads to constructing packets in the same memory region
> (>hdr). As a result, pktgen_setup_packets generates random headers.
>
> Fix that b
f packets.
Signed-off-by: Ilya Maximets
---
app/pktgen-arp.c | 2 +-
app/pktgen-cmds.c | 40
app/pktgen-ipv4.c | 2 +-
app/pktgen.c | 39 +++
app/pktgen.h | 4 ++--
app/t/pktgen.t.c | 6 +++---
6 files ch
92 matches
Mail list logo
