&& (ops_index < RTE_MEMPOOL_MAX_OPS_IDX)" failed
Cc:
Signed-off-by: Ilya Maximets
Acked-by: Declan Doherty
Acked-by: Declan Doherty
Acked-by: Jan Blunck
---
drivers/net/bonding/rte_eth_bond_pmd.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/net/bonding
After a slave interface is removed from a bond group it still has the
configuration of the bond interface. Lets enforce that the slave interface
is reconfigured after removal by resetting it.
Signed-off-by: Jan Blunck
---
drivers/net/bonding/rte_eth_bond_pmd.c | 3 +++
1 file changed, 3
This is a helper for DPDK internal users to force a reconfiguration of a
device.
Signed-off-by: Jan Blunck
---
lib/librte_ether/rte_ethdev.c | 16
lib/librte_ether/rte_ethdev.h | 13 +
lib/librte_ether/rte_ether_version.map | 6 ++
3 files
If all queues are released lets also free up the dev->data->rx/tx_queues
to be able to properly reinitialize.
Signed-off-by: Jan Blunck
---
lib/librte_ether/rte_ethdev.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
If a queue has been setup before lets release it before we setup.
Otherwise we might leak resources.
Signed-off-by: Jan Blunck
---
lib/librte_ether/rte_ethdev.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
already initialized queues before they are setup again. Therefore the driver
call sequence is as if the number of queues is temporarily reduced before the
queues are setup again.
Ilya Maximets (1):
Revert "bonding: use existing enslaved device queues"
Jan Blunck (4):
ethde
After a slave interface is removed from a bond group it still has the
configuration of the bond interface. Lets enforce that the slave interface
is reconfigured after removal by resetting it.
Signed-off-by: Jan Blunck
---
drivers/net/bonding/rte_eth_bond_pmd.c | 3 +++
1 file changed, 3
This is a helper for DPDK internal users to force a reconfiguration of a
device.
Signed-off-by: Jan Blunck
---
lib/librte_ether/rte_ethdev.c | 15 +++
lib/librte_ether/rte_ethdev.h | 13 +
lib/librte_ether/rte_ether_version.map | 6 ++
3 files
If all queues are released lets also free up the dev->data->rx/tx_queues
to be able to properly reinitialize.
Signed-off-by: Jan Blunck
---
lib/librte_ether/rte_ethdev.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
If a queue has been setup before lets release it before we setup.
Otherwise we might leak resources.
Signed-off-by: Jan Blunck
---
lib/librte_ether/rte_ethdev.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
On Sun, Nov 20, 2016 at 4:20 PM, David Marchand
wrote:
> Hello Jan,
>
> On Sun, Nov 20, 2016 at 11:05 AM, Jan Blunck wrote:
>> Signed-off-by: Jan Blunck
>> ---
>> lib/librte_eal/common/include/rte_pci.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>&g
The struct rte_intr_handle is an abstraction layer for different types of
interrupt mechanisms. It is embedded in the low-level device (e.g. PCI).
On allocation of a struct rte_eth_dev a reference to the intr_handle
should be stored for devices supporting interrupts.
Signed-off-by: Jan Blunck
Only the device itself can decide its PCI or not.
Signed-off-by: Jan Blunck
---
drivers/net/bnx2x/bnx2x_ethdev.c| 1 +
drivers/net/bnxt/bnxt_ethdev.c | 2 ++
drivers/net/cxgbe/cxgbe_ethdev.c| 2 ++
drivers/net/e1000/em_ethdev.c | 1 +
drivers/net/e1000
We don't need to depend on rte_eth_dev->pci_dev to differentiate between
the virtio_user and the virtio_pci case. Instead we can use the private
virtio_hw struct to get that information.
Signed-off-by: Jan Blunck
---
drivers/net/virtio/virtio_ethdev.c | 21 ++---
1 file chan
This adds a helper to get the rte_intr_handle from the virtio_hw. This is
safe to do since the usage of the helper is guarded by RTE_ETH_DEV_INTR_LSC
which is only set if we found a PCI device during initialization.
Signed-off-by: Jan Blunck
---
drivers/net/virtio/virtio_ethdev.c | 12
The drivers should not directly access the rte_eth_dev->pci_dev but use
a macro instead. This is a preparation for replacing the pci_dev with
a struct rte_device member in the future.
Signed-off-by: Jan Blunck
---
drivers/net/bnxt/bnxt_ethdev.c | 19 ++-
drivers/net/b
Signed-off-by: Jan Blunck
---
lib/librte_ether/rte_ethdev.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 9678179..3adbb2b 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -1644,6
This macro is based on Jan Viktorin's original patch but also checks the
type of the passed pointer against the type of the member.
Signed-off-by: Jan Viktorin
Signed-off-by: Shreyansh Jain
[jblunck at infradead.org: add type checking and __extension__]
Signed-off-by: Jan Blunck
---
lib
On Mon, Nov 21, 2016 at 10:08 AM, Thomas Monjalon
wrote:
> 2016-11-20 16:30, David Marchand:
>> For a first patchset, I would see:
>> - introduce the rte_bus object. In rte_eal_init, for each bus, we call
>> the scan method. Then, for each bus, we find the appropriate
>> rte_driver using the bus
Only the device itself can decide its PCI or not.
Signed-off-by: Jan Blunck
---
drivers/net/bnx2x/bnx2x_ethdev.c| 1 +
drivers/net/bnxt/bnxt_ethdev.c | 2 ++
drivers/net/cxgbe/cxgbe_ethdev.c| 2 ++
drivers/net/e1000/em_ethdev.c | 1 +
drivers/net/e1000
This adds a helper to get the rte_intr_handle from the virtio_hw. This is
safe to do since the usage of the helper is guarded by RTE_ETH_DEV_INTR_LSC
which is only set if we found a PCI device during initialization.
Signed-off-by: Jan Blunck
---
drivers/net/virtio/virtio_ethdev.c | 12
This is overwritten in rte_eth_dev_info_get().
Signed-off-by: Jan Blunck
---
drivers/net/virtio/virtio_ethdev.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/virtio/virtio_ethdev.c
index 079fd6c..741688e 100644
--- a/drivers/net/virtio
The drivers should not directly access the rte_eth_dev->pci_dev but use
a macro instead. This is a preparation for replacing the pci_dev with
a struct rte_device member in the future.
Signed-off-by: Jan Blunck
---
drivers/net/bnxt/bnxt_ethdev.c | 19 ++-
drivers/net/b
Signed-off-by: Jan Blunck
---
lib/librte_eal/common/include/rte_pci.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_eal/common/include/rte_pci.h
b/lib/librte_eal/common/include/rte_pci.h
index 9ce8847..0376160 100644
--- a/lib/librte_eal/common/include/rte_pci.h
+++ b/lib
This moves the non-PCI related initialization of the link state interrupt
callback list and the setting of the default MTU to rte_eth_dev_allocate()
so that drivers only need to set non-default values.
Signed-off-by: Jan Blunck
---
app/test/virtual_pmd.c | 2 --
drivers/net
Lets clear the eth_dev->data when allocating a new rte_eth_dev so that
drivers only need to set non-zero values.
Signed-off-by: Jan Blunck
---
drivers/net/bonding/rte_eth_bond_api.c | 7 ---
drivers/net/mlx4/mlx4.c| 1 -
drivers/net/mlx5/mlx5.c| 1 -
driv
On Thu, Nov 17, 2016 at 2:08 PM, Shreyansh Jain
wrote:
> On Thursday 17 November 2016 05:25 PM, Jan Blunck wrote:
>>
>> On Thu, Nov 17, 2016 at 6:29 AM, Shreyansh Jain
>> wrote:
>>>
>>> DPDK has been inherently a PCI inclined framework. Because of this,
On Thu, Nov 17, 2016 at 4:46 PM, Ferruh Yigit wrote:
> On 11/17/2016 2:24 PM, Jan Blunck wrote:
>> This moves the non-PCI related initialization of the link state interrupt
>> callback list and the setting of the default MTU to rte_eth_dev_allocate()
>> so that drivers
On Thu, Nov 17, 2016 at 2:00 PM, Shreyansh Jain
wrote:
>
> On Thursday 17 November 2016 04:49 PM, Jan Blunck wrote:
>>
>> On Thu, Nov 17, 2016 at 6:30 AM, Shreyansh Jain
>> wrote:
>>>
>>> A device is connected to a bus and services by a driver associa
This moves the non-PCI related initialization of the link state interrupt
callback list and the setting of the default MTU to rte_eth_dev_allocate()
so that drivers only need to set non-default values.
Signed-off-by: Jan Blunck
---
drivers/net/bonding/rte_eth_bond_api.c | 2 --
drivers/net
Lets clear the eth_dev->data when allocating a new rte_eth_dev so that
drivers only need to set non-zero values.
Signed-off-by: Jan Blunck
---
drivers/net/mlx4/mlx4.c | 1 -
drivers/net/mlx5/mlx5.c | 1 -
lib/librte_ether/rte_ethdev.c | 2 +-
3 files changed, 1 insertion(+)
On Thu, Nov 17, 2016 at 6:30 AM, Shreyansh Jain
wrote:
> This patch demonstrates how eth_driver can be replaced with appropriate
> changes for rte_xxx_driver from the PMD itself. It uses ixgbe_ethernet as
> an example.
>
> A large set of changes exists in the rte_ethdev.c - primarily because too
On Thu, Nov 17, 2016 at 6:30 AM, Shreyansh Jain
wrote:
> From: Jan Viktorin
>
> Signed-off-by: Jan Viktorin
> Signed-off-by: Shreyansh Jain
> ---
> lib/librte_eal/common/include/rte_common.h | 18 ++
> 1 file changed, 18 insertions(+)
>
> diff --git
On Thu, Nov 17, 2016 at 6:29 AM, Shreyansh Jain
wrote:
> DPDK has been inherently a PCI inclined framework. Because of this, the
> design of device tree (or list) within DPDK is also PCI inclined. A non-PCI
> device doesn't have a way of being expressed without using hooks started from
> EAL to
On Thu, Nov 17, 2016 at 6:30 AM, Shreyansh Jain
wrote:
> A device is connected to a bus and services by a driver associated with
> the bus. It is responsibility of the bus to identify the devices (scan)
> and then assign each device to a matching driver.
>
> A PMD would allocate a rte_xxx_driver
This registers the legacy names of the driver being renamed in
commit 2f45703c17ac ("drivers: make driver names consistent").
Signed-off-by: Jan Blunck
Tested-by: Pablo de Lara
---
drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 1 +
drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 1
This registers the legacy names of the driver being renamed in
commit 2f45703c17ac ("drivers: make driver names consistent").
Signed-off-by: Jan Blunck
---
drivers/net/af_packet/rte_eth_af_packet.c | 1 +
drivers/net/bonding/rte_eth_bond_pmd.c| 1 +
drivers/net/mpipe/mpip
This adds infrastructure for drivers to allow being requested by an alias
so that a renamed driver can still get loaded by its legacy name.
Signed-off-by: Jan Blunck
Reviewed-by: Maxime Coquelin
Tested-by: Pablo de Lara
---
lib/librte_eal/common/eal_common_vdev.c | 8
lib/librte_eal
On Wed, Oct 19, 2016 at 5:47 AM, Ilya Maximets
wrote:
> On 18.10.2016 18:19, Jan Blunck wrote:
>> On Tue, Oct 18, 2016 at 2:49 PM, Ilya Maximets
>> wrote:
>>> On 18.10.2016 15:28, Jan Blunck wrote:
>>>> If the application already configured queues th
On Mon, Oct 24, 2016 at 7:02 AM, Declan Doherty
wrote:
> On 14/10/16 00:37, Eric Kinzie wrote:
>>
>> On Wed Oct 12 16:24:21 +0100 2016, Bruce Richardson wrote:
>>>
>>> On Wed, Oct 12, 2016 at 04:24:54PM +0300, Ilya Maximets wrote:
On 07.10.2016 05:02, Eric Kinzie wrote:
>
> On
This registers the legacy names of the driver being renamed in commit
2f45703c17acb943aaded9f79676fd56a72542b2.
Signed-off-by: Jan Blunck
---
drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 1 +
drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 1 +
drivers/crypto/kasumi/rte_kasumi_pmd.c | 1
On Thu, Oct 20, 2016 at 4:03 AM, Oleg Kuporosov wrote:
> Hello Konstantin,
>
>>
>> My vote also would be to have timestamp in the second cache line.
>> About moving seqn to the 2-nd cache line too - that's probably a fair point.
>
> It may impact throughput till ~6% for applications required such
This registers the legacy names of the driver being renamed in commit
2f45703c17acb943aaded9f79676fd56a72542b2.
Signed-off-by: Jan Blunck
---
drivers/net/af_packet/rte_eth_af_packet.c | 1 +
drivers/net/bonding/rte_eth_bond_pmd.c| 1 +
drivers/net/mpipe/mpipe_tilegx.c | 2
This adds infrastructure for drivers to allow being requested by an alias
so that a renamed driver can still get loaded by its legacy name.
Signed-off-by: Jan Blunck
---
lib/librte_eal/common/eal_common_vdev.c | 8
lib/librte_eal/common/include/rte_dev.h | 1 +
lib/librte_eal/common
On Tue, Oct 18, 2016 at 3:42 PM, Thomas Monjalon
wrote:
> 2016-10-18 21:06, Yuanhan Liu:
>> On Tue, Oct 18, 2016 at 02:50:16PM +0200, Jan Blunck wrote:
>> > >From my understanding this is a massive API breakage. This forces all
>> > existing users of the virtual PM
On Tue, Oct 18, 2016 at 2:49 PM, Ilya Maximets
wrote:
> On 18.10.2016 15:28, Jan Blunck wrote:
>> If the application already configured queues the PMD should not
>> silently claim ownership and reset them.
>>
>> What exactly is the problem when changing MTU? This wo
>From my understanding this is a massive API breakage. This forces all
existing users of the virtual PMDs to change with zero benefit. Even
if that isn't enough it also makes it impossible to switch between
releases by recompiling.
Can we please revert these changes and work on some aliasing
If the application already configured queues the PMD should not
silently claim ownership and reset them.
What exactly is the problem when changing MTU? This works fine from
what I can tell.
Cheers,
Jan
On Wed, Sep 7, 2016 at 2:28 PM, Ilya Maximets wrote:
> This reverts commit
On Di, 2016-07-12 at 11:34 +0200, Thomas Monjalon wrote:
> Hi all,
>
> We are facing some issues with Xen dom0.
> Some were fixed in RC2:
> https://urldefense.proofpoint.com/v2/url?u=http-3A__dpdk.org_ml
> _archives_dev_2016-
> 2DJuly_043760.html=CwICAg=IL_XqQWOjubgfqINi2jTzg=eGq7Pg5OSP440n
On Tue, Mar 22, 2016 at 12:27 PM, Thomas Monjalon
wrote:
> 2016-03-22 12:04, Jan Blunck:
>> On Tue, Mar 22, 2016 at 11:42 AM, Thomas Monjalon
>> wrote:
>> > 2016-03-22 10:55, Jan Blunck:
>> >> New UIO helper kernel driver for Xen netfront UIO poll mode driver
On Tue, Mar 22, 2016 at 11:42 AM, Thomas Monjalon
wrote:
> 2016-03-22 10:55, Jan Blunck:
>> New UIO helper kernel driver for Xen netfront UIO poll mode driver.
>>
>> Signed-off-by: Stephen Hemminger
>> Signed-off-by: Jan Blunck
>
> Is it contributed upstr
On Tue, Mar 22, 2016 at 11:07 AM, David Marchand
wrote:
> Hello,
>
> On Tue, Mar 22, 2016 at 10:55 AM, Jan Blunck wrote:
>> +static struct eth_dev_ops xen_eth_dev_ops = {
>> + /*dev*/
>> + .dev_configure= xen_dev_configure,
>> + .dev
Add basic documentation for Xen Netfront PMD compilation and testpmd
invocation.
Signed-off-by: Jan Blunck
---
doc/guides/nics/overview.rst | 28 ++--
doc/guides/nics/xen.rst | 101 +++
2 files changed, 115 insertions(+), 14 deletions
This implements a poll mode driver that has the same functionality as
the Xen netfront driver in the Linux kernel.
Signed-off-by: Stephen Hemminger
Signed-off-by: Jan Blunck
---
config/common_base | 6 +
drivers/net/Makefile | 1 +
drivers/net/xen/Makefile
New UIO helper kernel driver for Xen netfront UIO poll mode driver.
Signed-off-by: Stephen Hemminger
Signed-off-by: Jan Blunck
---
lib/librte_eal/linuxapp/Makefile | 1 +
lib/librte_eal/linuxapp/xen_uio/Makefile | 56 ++
lib/librte_eal/linuxapp/xen_uio/compat.h | 47 ++
lib
v3 changes:
- removed fake PCI interface
- removed struct virt_eth_driver
- check for UIO name and version
- added basic documentation
Jan Blunck (3):
xen: Add UIO kernel driver
xen: Add netfront poll mode driver
xen: Add documentation
config/common_base| 6
On Fri, Oct 2, 2015 at 12:15 PM, Panu Matilainen wrote:
> On 10/01/2015 03:11 AM, Mario Carrillo wrote:
>>
>> Add hierarchy-file support to the DPDK libraries, modules,
>> binary files, nic bind files and documentation,
>> when invoking "make install-fhs" (filesystem hierarchy standard)
>>
!= NULL" failed
Signed-off-by: Jan Blunck
---
drivers/net/bonding/rte_eth_bond_pmd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
b/drivers/net/bonding/rte_eth_bond_pmd.c
index 5a2fbef..1fd1321 100644
--- a/driver
On Mon, Jun 1, 2015 at 10:31 AM, Olivier MATZ
wrote:
> Hi Jan,
>
> On 05/29/2015 12:34 PM, Jan Blunck wrote:
> > In rte_log_dump_history() the log_history list is reinitialized without
> > resetting the log_history_size. In the next call to
> rte_log_add_in_history()
ion fault.
rte_log_add_in_history (
buf=buf at entry=0x7f02035cd000 "DATAPLANE: 9:dp0s7 link RTM_NEWLINK
[dp0s7] <UP,BROADCAST,RUNNING,MULTICAST,LOWER_UP>\nCAST,LOWER_UP>\n", size=size
at entry=86)
at /usr/src/packages/BUILD/lib/librte_eal/common/eal_common_log.c:122
Sig
ion fault.
rte_log_add_in_history (
buf=buf at entry=0x7f02035cd000 "DATAPLANE: 9:dp0s7 link RTM_NEWLINK
[dp0s7] <UP,BROADCAST,RUNNING,MULTICAST,LOWER_UP>\nCAST,LOWER_UP>\n", size=size
at entry=86)
at /usr/src/packages/BUILD/lib/librte_eal/common/eal_common_log.c:122
Sig
61 matches
Mail list logo
