[dpdk-dev] [RFC PATCH] ixgbe: ixgbe_recv_pkts_vec shouldn't override mbuf buffer length

On 05/12/2014 18:07, Ananyev, Konstantin wrote: > > >> -Original Message----- >> From: Jean-Mickael Guerin [mailto:jean-mickael.guerin at 6wind.com] >> Sent: Friday, December 05, 2014 4:59 PM >> To: Ananyev, Konstantin >> Cc: dev at dpdk.org >>

[dpdk-dev] [RFC PATCH] ixgbe: ixgbe_recv_pkts_vec shouldn't override mbuf buffer length

On 05/12/2014 16:20, Konstantin Ananyev wrote: > That's an alternative way to fix the problem described in the patch: > http://dpdk.org/ml/archives/dev/2014-December/009394.html. > The main difference is: > - move buf_len fields out of rearm_data marker. > - make ixgbe_recv_pkts_vec() not touch buf

[dpdk-dev] [PATCH v2] ixgbe: don't override mbuf buffer length

-by: Jean-Mickael Guerin Acked-by: David Marchand Fixes: 0ff3324da2 ("ixgbe: rework vector pmd following mbuf changes") --- v2: check returned value of ixgbe_rxq_vec_setup lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 5 - lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 19 --

[dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length

>> Which makes me think, that we probably shouldn't overwrite buf_len by >> rxq->mbuf_initializer. >> > I believe that it is perfectly safe to do so. All buffers from a mempool are > meant > to be the same size, therefore reading the length of one buffer should tell > you > what size all buffers

[dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length

On 04/12/2014 16:32, Bruce Richardson wrote: > On Thu, Dec 04, 2014 at 03:29:04PM +, Ananyev, Konstantin wrote: >> >> >>> -Original Message- >>> From: Richardson, Bruce >>> Sent: Thursday, December 04, 2014 3:15 PM >>> To: Anan

[dpdk-dev] [PATCH 1/2] ixgbe: fix setup of mbuf initializer template

On 04/12/2014 15:42, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson >> Sent: Thursday, December 04, 2014 2:40 PM >> To: Jean-Mickael Guerin >> Cc: dev at dpdk.org >>

[dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length

-by: Jean-Mickael Guerin Acked-by: David Marchand Fixes: 0ff3324da2 ("ixgbe: rework vector pmd following mbuf changes") --- lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_ve

[dpdk-dev] [PATCH 1/2] ixgbe: fix setup of mbuf initializer template

Add a compiler barrier to make sure all fields covered by the marker rearm_data are assigned before the read. Signed-off-by: Jean-Mickael Guerin Acked-by: David Marchand Fixes: 0ff3324da2 ("ixgbe: rework vector pmd following mbuf changes") --- lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c

[dpdk-dev] [PATCH 0/2] ixgbe: bug fixes for RX vector mode

Jean-Mickael Guerin (2): ixgbe: fix setup of mbuf initializer template ixgbe: don't override mbuf buffer length lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) -- 2.1.3