[dpdk-dev] [PATCH v3] net/ring: remove unnecessary NULL check

Coverity detected this as an issue because internals->data will never be NULL, then the check is not necessary. Fixes: d082c0395bf6 ("ring: fix memory leak when detaching") Coverity issue: 137873 Signed-off-by: Mauricio Vasquez B --- drivers/net/ring/rte_et

[dpdk-dev] [PATCH v2] net/ring: remove unnecessary NULL check

Coverity detected this as an issue because internals->data will never be NULL, then the check is not necessary. Fixes: d082c0395bf6 ("ring: fix memory leak when detaching") Coverity issue: 137873 Signed-off-by: Mauricio Vasquez B --- drivers/net/ring/rte_eth_ring.c | 20 +-

[dpdk-dev] [PATCH] pmd_ring: fix coverity issue

internals->data will never be NULL, so the check is not necessary. Fixes: d082c0395bf6 ("ring: fix memory leak when detaching") Coverity issue: 137873 Signed-off-by: Mauricio Vasquez B --- drivers/net/ring/rte_eth_ring.c | 20 +--- 1 file changed, 9 insertions(+),

[dpdk-dev] [PATCH] fix documentation error on debug functions

Previous patch updated the functions without updating all the comments. Fixes: 591a9d7985c1 ("add FILE argument to debug functions") Signed-off-by: Mauricio Vasquez B --- lib/librte_eal/common/include/rte_malloc.h | 2 +- lib/librte_eal/common/include/rte_memory.h | 2 +- lib/

[dpdk-dev] [PATCH] doc/versioning: add missing return value type in MAP_STATIC_SYMBOL example

The example only had as return type struct, it is actually struct rte_acl_ctx * Signed-off-by: Mauricio Vasquez B --- doc/guides/contributing/versioning.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/guides/contributing/versioning.rst b/doc/guides/contributing

[dpdk-dev] [PATCH] doc/tespmd: fix flow director examples

A previous patch modified the CLIs witout updating the examples. Fixes: 53b2bb9b7ea7 ("app/testpmd: new flow director commands") Signed-off-by: Mauricio Vasquez B --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -

[dpdk-dev] [PATCH v3] librte_ether: use RTE_ETH_VALID_PORTID_OR_ERR_RET to check port_id

The RTE_ETH_VALID_PORTID_OR_ERR_RET macro is used in some places to check if a port id is valid or not. This commit makes use of it in some new parts of the code. Signed-off-by: Mauricio Vasquez B --- v3: - use it also in rte_eth_add_rx_callback and rte_eth_add_tx_callback v2: - add missed

[dpdk-dev] [PATCH v2] librte_ether: use RTE_ETH_VALID_PORTID_OR_ERR_RET to check port_id

The RTE_ETH_VALID_PORTID_OR_ERR_RET macro is used in some places to check if a port id is valid or not. This commit makes use of it in some new parts of the code. Signed-off-by: Mauricio Vasquez B --- v2: - add missed case - change also cases in examples/ethtool/lib/rte_ethtool.c examples

[dpdk-dev] [PATCH v2] examples: remove useless checking

The rte_eth_dev_count() function will never return a value greater than RTE_MAX_ETHPORTS, so that checking is useless. Signed-off-by: Mauricio Vasquez B --- v2: Add missed case in examples/kni/main.c app/proc_info/main.c | 4 app/test/test_pmd_perf.c

[dpdk-dev] [PATCH] examples: remove useless checking

The rte_eth_dev_count() function will never return a value greater than RTE_MAX_ETHPORTS, so that checking is useless. Signed-off-by: Mauricio Vasquez B --- app/proc_info/main.c | 4 app/test/test_pmd_perf.c | 3 --- doc/guides

[dpdk-dev] [PATCH v2] mem: fix freeing of memzone used by ivshmem

although previous implementation returned an error when trying to release a memzone assigned to an ivshmem device, it stills freed it. Fixes: cd10c42eb5bc ("mem: fix ivshmem freeing") Signed-off-by: Mauricio Vasquez B --- v2: solved compilation problem when ivshmem is disabled lib/

[dpdk-dev] [PATCH] mem: fix freeing of memzone used by ivshmem

although previous implementation returned an error when trying to release a memzone assigned to an ivshmem device, it stills freed it. Fixes: cd10c42eb5bc ("mem: fix ivshmem freeing") Signed-off-by: Mauricio Vasquez B --- lib/librte_eal/common/eal_common_memzone.c | 12 ++

[dpdk-dev] [PATCH v2] ivshmem: fix race condition

The memory zone could be freed just after adding it to the metadata file and just before marking it as not freeable. This patch changes the locking logic in order to prevent it. Fixes: cd10c42eb5bc ("mem: fix ivshmem freeing") Signed-off-by: Mauricio Vasquez B --- lib/libr

[dpdk-dev] [PATCH] ivshmem: fix race condition

The memory zone could be freed just after adding it to the metadata file and just before marking it as not freeable. This patch changes the locking logic in order to prevent it. Fixes: cd10c42eb5bc ("mem: fix ivshmem freeing") Signed-off-by: Mauricio Vasquez B --- lib/libr

[dpdk-dev] [PATCH] pmd_ring: free rings when detaching

e rte_eth_from_rings function. Signed-off-by: Mauricio Vasquez B --- drivers/net/ring/rte_eth_ring.c | 82 - 1 file changed, 56 insertions(+), 26 deletions(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index d92

[dpdk-dev] [PATCH 19/19] doc: fix vm power man sample app hard-coded references

Signed-off-by: Mauricio Vasquez B --- doc/guides/sample_app_ug/vm_power_management.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/sample_app_ug/vm_power_management.rst b/doc/guides/sample_app_ug/vm_power_management.rst index da8be12..7f299e0 100644

[dpdk-dev] [PATCH 18/19] doc: fix vmdq and dcb fwd sample app hard-coded references

Signed-off-by: Mauricio Vasquez B --- doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst b/doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst index 9140a22..e9ced9f 100644

[dpdk-dev] [PATCH 17/19] doc: fix tep termination sample app hard-coded references

Signed-off-by: Mauricio Vasquez B --- doc/guides/sample_app_ug/tep_termination.rst | 8 doc/guides/sample_app_ug/vhost.rst | 7 +++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/doc/guides/sample_app_ug/tep_termination.rst b/doc/guides/sample_app_ug

[dpdk-dev] [PATCH 15/19] doc: fix link status int sample app hard-coded references

Signed-off-by: Mauricio Vasquez B --- doc/guides/sample_app_ug/link_status_intr.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guides/sample_app_ug/link_status_intr.rst b/doc/guides/sample_app_ug/link_status_intr.rst index de0dff8..a4dbb54 100644 --- a/doc

[dpdk-dev] [PATCH 14/19] doc: fix l3fwd virtual sample app hard-coded references

Signed-off-by: Mauricio Vasquez B --- doc/guides/sample_app_ug/l2_forward_real_virtual.rst | 1 + doc/guides/sample_app_ug/l3_forward.rst | 2 ++ doc/guides/sample_app_ug/l3_forward_virtual.rst | 7 +++ 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/doc

[dpdk-dev] [PATCH 13/19] doc: fix l3fwd power man sample app hard-coded references

Signed-off-by: Mauricio Vasquez B --- doc/guides/sample_app_ug/l3_forward_power_man.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/doc/guides/sample_app_ug/l3_forward_power_man.rst b/doc/guides/sample_app_ug/l3_forward_power_man.rst index ac688f8..ea9c404 100644

[dpdk-dev] [PATCH 12/19] doc: fix l3fwd access control sample app hard-coded references

Signed-off-by: Mauricio Vasquez B --- doc/guides/sample_app_ug/l3_forward_access_ctrl.rst | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/doc/guides/sample_app_ug/l3_forward_access_ctrl.rst b/doc/guides/sample_app_ug/l3_forward_access_ctrl.rst index dbf47c7..4049e01

[dpdk-dev] [PATCH 11/19] doc: fix l3 fwd sample app hard-coded references

Signed-off-by: Mauricio Vasquez B --- doc/guides/sample_app_ug/l3_forward.rst | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/doc/guides/sample_app_ug/l3_forward.rst b/doc/guides/sample_app_ug/l3_forward.rst index 4ce734b..1aac7dd 100644 --- a/doc/guides/sample_app_ug

[dpdk-dev] [PATCH 10/19] doc: fix l2 fwd sample app hard-coded references

Signed-off-by: Mauricio Vasquez B --- doc/guides/sample_app_ug/l2_forward_real_virtual.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/sample_app_ug/l2_forward_real_virtual.rst b/doc/guides/sample_app_ug/l2_forward_real_virtual.rst index 12f0d27..2a576f3

[dpdk-dev] [PATCH 09/19] doc: fix kni sample app hard-coded references

Signed-off-by: Mauricio Vasquez B --- doc/guides/sample_app_ug/kernel_nic_interface.rst | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/doc/guides/sample_app_ug/kernel_nic_interface.rst b/doc/guides/sample_app_ug/kernel_nic_interface.rst index 985c664..2ae9b70 100644

[dpdk-dev] [PATCH 08/19] doc: fix kepp alive sample app hard-coded references

Signed-off-by: Mauricio Vasquez B --- doc/guides/sample_app_ug/keep_alive.rst | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/doc/guides/sample_app_ug/keep_alive.rst b/doc/guides/sample_app_ug/keep_alive.rst index 080811b..b00f43b 100644 --- a/doc/guides/sample_app_ug

[dpdk-dev] [PATCH 07/19] doc: fix multicast sample app hard-coded references

Signed-off-by: Mauricio Vasquez B --- doc/guides/sample_app_ug/ipv4_multicast.rst | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/doc/guides/sample_app_ug/ipv4_multicast.rst b/doc/guides/sample_app_ug/ipv4_multicast.rst index ec76087..67ea944 100644 --- a/doc/guides

[dpdk-dev] [PATCH 06/19] doc: fix ip reassembly sample app hard-coded references

Signed-off-by: Mauricio Vasquez B --- doc/guides/sample_app_ug/ip_reassembly.rst | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/doc/guides/sample_app_ug/ip_reassembly.rst b/doc/guides/sample_app_ug/ip_reassembly.rst index 6bf5938..3c5cc70 100644 --- a/doc/guides

[dpdk-dev] [PATCH 05/19] doc: fix ip fragmentation sample app hard-coded references

Signed-off-by: Mauricio Vasquez B --- doc/guides/sample_app_ug/ip_frag.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/doc/guides/sample_app_ug/ip_frag.rst b/doc/guides/sample_app_ug/ip_frag.rst index 0c18fff..0c8da19 100644 --- a/doc/guides/sample_app_ug/ip_frag.rst

[dpdk-dev] [PATCH 04/19] doc: fix intel quickAssist technology sample app hard-coded references

Signed-off-by: Mauricio Vasquez B --- doc/guides/sample_app_ug/intel_quickassist.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/sample_app_ug/intel_quickassist.rst b/doc/guides/sample_app_ug/intel_quickassist.rst index a80d4ca..04d1593 100644 --- a/doc/guides

[dpdk-dev] [PATCH 03/19] doc: fix exception path sample app hard-coded references

Signed-off-by: Mauricio Vasquez B --- doc/guides/sample_app_ug/exception_path.rst | 5 ++--- doc/guides/sample_app_ug/l2_forward_real_virtual.rst | 4 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/doc/guides/sample_app_ug/exception_path.rst b/doc/guides

[dpdk-dev] [PATCH 01/19] doc: fix vhost sample app hard-coded references

Signed-off-by: Mauricio Vasquez B --- doc/guides/sample_app_ug/vhost.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/guides/sample_app_ug/vhost.rst b/doc/guides/sample_app_ug/vhost.rst index e5d1326..751656c 100644 --- a/doc/guides/sample_app_ug/vhost.rst +++ b

[dpdk-dev] [PATCH] doc: fix vhost bad section number references

Section numbers were "hard-coded". This patch adds them as hyperlinks. Signed-off-by: Mauricio Vasquez B --- doc/guides/sample_app_ug/vhost.rst | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/doc/guides/sample_app_ug/vhost.rst b/doc/guides/sample_app_ug

[dpdk-dev] [PATCH v2] tools/dpdk_nic_bind: fix flake8 warnings

flake8 checks were run for both python 2.7 and 3.4 There were some style issues as: - Line width > 79 - No double blank line before function definition - No double blank space before inline comment - Some other minor issues Signed-off-by: Mauricio Vasquez B --- v2: fix still existing warn

[dpdk-dev] [PATCH] tools/dpdk_nic_bind: fix flake8 warnings

flake8 checks were run for both python 2.7 and 3.4 There were some style issues as: - Line width > 79 - No double blank line before function definition - No double blank space before inline comment - Some other minor issues Signed-off-by: Mauricio Vasquez B --- tools/dpdk_nic_bind.py |

[dpdk-dev] [PATCH] ring: Fix memory leakage in rte_pmd_ring_devuninit

When freeing the device it is also neccesary to free rx_queues and tx_queues Signed-off-by: Mauricio Vasquez B --- v2: Added extra control before freeing members of eth_dev->data drivers/net/ring/rte_eth_ring.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/driv

[dpdk-dev] [PATCH] ring: Fix memory leakage in rte_pmd_ring_devuninit()

When freeing the device, it is also necessary to free rx_queues and tx_queues Signed-off-by: Mauricio Vasquez B --- drivers/net/ring/rte_eth_ring.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index 9a31bce..e091e4f