Hi Morten,
On Thu, Jan 06, 2022 at 10:29:11AM +0100, Morten Brørup wrote:
> Hi Olivier,
>
> The data_room_size parameter description for the mbuf pool creation functions
> says:
> "Size of data buffer in each mbuf, including RTE_PKTMBUF_HEADROOM."
>
> Furthermore, both rte_mbuf_data_iova_defaul
ET_IPV6_DSCP
> > > RTE_FLOW_ACTION_TYPE_SET_TAG
> > > RTE_FLOW_ACTION_TYPE_SET_META
> > >
> > > The VLAN set actions are interrelated to VLAN header insertion/removal
> > > and supported by multiple PMDs and widely used by applications and
> > > not supposed to be deprecated due to potential large impact on
> > > drivers and applications.
> > >
> > > Signed-off-by: Viacheslav Ovsiienko
> >
> > Thanks for the update,
> > Acked-by: Ferruh Yigit
> >
> >
> > We need to follow with relevant PMD maintainers to switch to new
> > 'MODIFY_FIELD' action till end of v22.07 release.
>
> Yes I would like to see them replying here, but seems some are not watching.
> I don't want to block this interesting deprecation plan,
> so I will merge if few more maintainers involved in ethdev give their ack.
>
> Acked-by: Thomas Monjalon
Acked-by: Olivier Matz
Members Attending
-
- Aaron
- Bruce
- Ferruh
- Honnappa
- Jerin
- Kevin
- Konstantin
- Maxime
- Olivier (Chair)
- Stephen
- Thomas
NOTE: The technical board meetings every second Wednesday at
https://meet.jit.si/DPDK at 3 pm UTC.
Meetings are public, and DPDK community members are
From: Alexander Bechikov
The dump of dynamic fields and flags fails if the shm is already
allocated. Add a check to fix the issue.
Cc: sta...@dpdk.org
Fixes: d4902ed31c63 ("mbuf: check shared memory before dumping dynamic space")
Signed-off-by: Alexander Bechikov
Acked-by: Ol
or devargs without name specified.
Fixes: 6aebb942907d ("kvargs: add function to get from key and value")
Signed-off-by: Xueming Li
Signed-off-by: Olivier Matz
Reviewed-by: Xueming Li
---
bug is specific to 21.11, no need to cc sta...@dpdk.org
v4:
- disable unit test when net/null is n
On Wed, Nov 24, 2021 at 11:43:29AM +, Xueming(Steven) Li wrote:
> On Wed, 2021-11-24 at 19:30 +0800, Xueming Li wrote:
> > On Wed, 2021-11-24 at 12:02 +0100, Olivier Matz wrote:
> > > From: Xueming Li
> > >
> > > Device iterator RTE_DEV_FOR
ith the unit test.
In case there is an issue with it, your v2 looks good to me:
Acked-by: Olivier Matz
As a side note, I was wondering if we should keep
rte_kvargs_get_with_value() in kvargs api, since there
is no more user. I think there it can still be useful, let's
keep it for now
or devargs without name specified.
Fixes: 6aebb942907d ("kvargs: add function to get from key and value")
Signed-off-by: Xueming Li
Signed-off-by: Olivier Matz
---
bug is specific to 21.11, no need to cc sta...@dpdk.org
---
app/test/meson.build | 3 +
Hello Xueming,
On Tue, Nov 23, 2021 at 12:49:32PM +, Xueming(Steven) Li wrote:
> On Tue, 2021-11-23 at 13:31 +0100, Olivier Matz wrote:
> > On Tue, Nov 23, 2021 at 11:25:22AM +, Xueming(Steven) Li wrote:
> > > On Tue, 2021-11-23 at 11:25 +0100, Olivier Matz wrote:
On Tue, Nov 23, 2021 at 11:25:22AM +, Xueming(Steven) Li wrote:
> On Tue, 2021-11-23 at 11:25 +0100, Olivier Matz wrote:
> > Hi Xueming,
> >
> > On Mon, Nov 22, 2021 at 02:12:50PM +0800, Xueming Li wrote:
> > > Device iterator RTE_DEV_FOREACH() failed to return
Hi Xueming,
On Mon, Nov 22, 2021 at 02:12:50PM +0800, Xueming Li wrote:
> Device iterator RTE_DEV_FOREACH() failed to return devices from
> classifier like "class=vdpa", because matching name from empty kvargs
> returns no result. If device name not specified in kvargs, the function
> should itera
On Wed, Nov 03, 2021 at 09:36:49PM +0100, David Marchand wrote:
> On Fri, Oct 29, 2021 at 10:45 AM Olivier Matz wrote:
> >
> > +CC David
> >
> > On Tue, Oct 26, 2021 at 11:17:08AM +0200, Olivier Matz wrote:
> > > On Tue, Oct 26, 2021 at 11:06:10AM +0200, Hous
On Wed, Nov 03, 2021 at 09:26:02PM +0100, David Marchand wrote:
> On Fri, Oct 29, 2021 at 11:49 AM Olivier Matz wrote:
> >
> > From: Ilyes Ben Hamouda
> >
> > When using rte_malloc() from a control thread, the used heap is the one
> > from numa socket 0, wh
On Wed, Nov 03, 2021 at 09:03:19PM +0100, David Marchand wrote:
> On Fri, Oct 29, 2021 at 11:53 AM Olivier Matz wrote:
> >
> > Since its introduction in 2018, the SIGBUS handler was never registered,
> > and all related functions were unused.
> >
> > A SIGBUS c
flag instead.
Bugzilla ID: 867
Fixes: 7b295dceea07 ("test/mbuf: add unit test cases")
Cc: sta...@dpdk.org
Reported-by: David Marchand
Signed-off-by: Olivier Matz
---
app/test/test_mbuf.c | 26 ++
1 file changed, 18 insertions(+), 8 deletions(-)
diff --git
On Fri, Oct 29, 2021 at 01:23:15PM +0200, David Marchand wrote:
> Previous change wrongly removed a valid cmdline_free().
>
> Fixes: 6ad06203a587 ("cmdline: free on exit")
>
> Signed-off-by: David Marchand
Acked-by: Olivier Matz
Thanks!
hugepages. In this case, we
need to recover. A similar scheme can be found in eal_memory.c.
Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime")
Cc: sta...@dpdk.org
Signed-off-by: Olivier Matz
---
lib/eal/linux/eal_memalloc.c | 13 +
1 file changed, 9 insert
there, and remove the inline keyword.
Fixes: b94580d6887e ("malloc: avoid unknown socket id")
Cc: sta...@dpdk.org
Signed-off-by: Ilyes Ben Hamouda
Signed-off-by: Olivier Matz
---
lib/eal/common/malloc_heap.c | 20
lib/eal/common/malloc_heap.h | 11 --
IO flag")
>
> Reported-by: YuX Jiang
> Signed-off-by: Dmitry Kozlyuk
Reviewed-by: Olivier Matz
However, I launched the test like this and it failed:
$ ./build/app/test/dpdk-test --no-huge -m 512
EAL: Detected CPU lcores: 12
EAL: Detected NUMA nodes: 1
EAL: Detected shared linka
+CC David
On Tue, Oct 26, 2021 at 11:17:08AM +0200, Olivier Matz wrote:
> On Tue, Oct 26, 2021 at 11:06:10AM +0200, Houssem Bouhlel wrote:
> > There can be dev binding issue when no hugepages
> > are allocated for socket 0.
> > To avoid this, set device numa node value b
On Wed, Oct 27, 2021 at 01:29:52PM +0200, Morten Brørup wrote:
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit
> > Sent: Wednesday, 27 October 2021 12.49
> >
> > On 10/20/2021 11:12 AM, Xiaoyun Li wrote:
> > > In csum forwarding mode, software UDP/TCP csum calculation only ta
Hi Alexander,
Thanks for submitting this patch. Few comments below.
On Wed, Oct 27, 2021 at 07:11:18AM -0400, Alexander Bechikov wrote:
> mbuf: Improved error message. Added check if shared memory already allocated
I suggest another title:
mbuf: fix dump of dynamic fields and flags
Indeed, i
Hi,
On Wed, Oct 27, 2021 at 09:20:52AM +0200, David Marchand wrote:
> On Tue, Oct 26, 2021 at 5:57 PM Thomas Monjalon wrote:
> >
> > 26/10/2021 16:58, David Marchand:
> > > Warning continuously is a pain when developping or if a unit test
> > > is/gets broken.
> > >
> > > It could also be a probl
add Hyper-V virtual bus support")
Sorry, the Fixes line is wrong. This is the correct one:
Fixes: 8a04cb612589 ("pci: set default numa node for broken systems")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Houssem Bouhlel
> Signed-off-by: Olivier Matz
> ---
> dr
: 11541c5c81dd ("mempool: add non-IO flag")
>
> Signed-off-by: Dmitry Kozlyuk
Acked-by: Olivier Matz
Thanks
On Thu, Oct 21, 2021 at 04:32:21PM -0500, Honnappa Nagarahalli wrote:
> Add a testcase to test launching of control threads.
>
> Signed-off-by: Honnappa Nagarahalli
Reviewed-by: Olivier Matz
> Signed-off-by: Honnappa Nagarahalli
Reviewed-by: Olivier Matz
Few cosmetics comments below.
(...)
> +enum __rte_ctrl_thread_status {
> + __RTE_CTRL_THREAD_LAUNCHING, /* Yet to call pthread_create function */
> + __RTE_CTRL_THREAD_RUNNING, /* Control thr
On Tue, Oct 19, 2021 at 08:40:22PM +0300, Andrew Rybchenko wrote:
> MEMPOOL_PG_NUM_DEFAULT and MEMPOOL_PG_SHIFT_MAX are not used.
>
> Fixes: fd943c764a63 ("mempool: deprecate xmem functions")
>
> Signed-off-by: Andrew Rybchenko
Acked-by: Olivier Matz
cl will not be
> > released alone.
> >
> > Fixes: af75078fece3 ("first public release")
> > Cc: intel.com
> >
> > Signed-off-by: Zhihong Peng
>
> Reviewed-by: Dmitry Kozlyuk
Acked-by: Olivier Matz
On Tue, Oct 19, 2021 at 08:40:21PM +0300, Andrew Rybchenko wrote:
> Add RTE_ prefix to macro used to register mempool driver.
> The old one is still available but deprecated.
>
> Signed-off-by: Andrew Rybchenko
Acked-by: Olivier Matz
On Tue, Oct 19, 2021 at 08:40:20PM +0300, Andrew Rybchenko wrote:
> Add RTE_ prefix to helper macro to calculate mempool header size and
> make it internal. Old macro is still available, but deprecated.
>
> Signed-off-by: Andrew Rybchenko
Acked-by: Olivier Matz
On Tue, Oct 19, 2021 at 01:08:45PM +0300, Andrew Rybchenko wrote:
> MEMPOOL_PG_NUM_DEFAULT and MEMPOOL_PG_SHIFT_MAX are not used.
>
> Signed-off-by: Andrew Rybchenko
Fixes: fd943c764a63 ("mempool: deprecate xmem functions") ?
> --- a/lib/mempool/rte_mempool.h
> +++ b/lib/mempool/rte_mempool.h
>
On Tue, Oct 19, 2021 at 01:08:44PM +0300, Andrew Rybchenko wrote:
> Add RTE_ prefix to macro used to register mempool driver.
> The old one is still available but deprecated.
>
> Signed-off-by: Andrew Rybchenko
(...)
> rte_mempool_register_ops(&ops); \
> }
>
On Tue, Oct 19, 2021 at 06:13:54PM +0200, Olivier Matz wrote:
> On Tue, Oct 19, 2021 at 01:08:41PM +0300, Andrew Rybchenko wrote:
> > Fix the mempool flgas namespace by adding an RTE_ prefix to the name.
>
> nit: flgas -> flags
>
> > The old flags remain usable, to
On Tue, Oct 19, 2021 at 01:08:43PM +0300, Andrew Rybchenko wrote:
> Add RTE_ prefix to helper macro to calculate mempool header size and
> make it internal. Old macro is still available, but deprecated.
>
> Signed-off-by: Andrew Rybchenko
(...)
> +/** Deprecated. Use RTE_MEMPOOL_HEADER_SIZE() f
On Tue, Oct 19, 2021 at 01:08:42PM +0300, Andrew Rybchenko wrote:
> Add RTE_ prefix to internal API defined in public header.
> Use the prefix instead of double underscore.
> Use uppercase for macros in the case of name conflict.
>
> Signed-off-by: Andrew Rybchenko
Acked-by: Olivier Matz
On Tue, Oct 19, 2021 at 01:08:41PM +0300, Andrew Rybchenko wrote:
> Fix the mempool flgas namespace by adding an RTE_ prefix to the name.
nit: flgas -> flags
> The old flags remain usable, to be deprecated in the future.
>
> Signed-off-by: Andrew Rybchenko
(...)
> @@ -777,12 +777,12 @@ rte_me
On Tue, Oct 19, 2021 at 01:08:40PM +0300, Andrew Rybchenko wrote:
> Move documentation into a separate line just before define.
> Prepare to have a bit longer flag name because of namespace prefix.
>
> Signed-off-by: Andrew Rybchenko
Acked-by: Olivier Matz
Hi Eli,
On Tue, Oct 19, 2021 at 09:41:56AM +0300, Eli Britstein wrote:
> Hi Olivier,
>
> On 8/1/2021 11:06 AM, Eli Britstein wrote:
> >
> > On 7/30/2021 2:10 PM, Olivier Matz wrote:
> > > External email: Use caution opening links or attachments
> > >
&
On Mon, Oct 18, 2021 at 11:37:32AM +0300, Andrew Rybchenko wrote:
> On 10/18/21 11:26 AM, David Marchand wrote:
> > As reported by Dmitry, MEMPOOL_F_POOL_CREATED is a flag only manipulated
> > internally.
> > This flag is not supposed to be requested from an application and would
> > probably resul
ion did pass it.
>
> Other internal flags may be introduced later.
>
> Rework the check and export a mask of valid user flags for use in the
> unit test.
>
> Fixes: b240af8b10f9 ("mempool: enforce valid flags at creation")
>
> Reported-by: Dmitry Kozlyuk
&g
Hi Andrew,
On Sat, Oct 16, 2021 at 10:50:50AM +0300, Andrew Rybchenko wrote:
> On 10/15/21 10:24 PM, Olivier Matz wrote:
> > The flags PKT_TX_VLAN_PKT and PKT_TX_QINQ_PKT are
> > marked as deprecated since commit 380a7aab1ae2 ("mbuf: rename deprecated
> > VLAN flags&q
8_t *)&left = *(const uint8_t *)u16_buf;
> > + *(unsigned char*)&left = *(const unsigned char *)end;
> > sum += left;
> > }
> >
> > --
> > 2.31.1
> >
>
> Great work documenting your thoughts behind this patch, Georg! I, for one,
> didn't know about the aliasing difference between uint8_t and unsigned char.
> :-)
>
> After taking a good look at v2 and the Godbolt reference to confirm the
> claimed benefits, there can be no doubts about this patch.
+1, thanks for the good documentation
> Reviewed-by: Morten Brørup
Acked-by: Olivier Matz
On Mon, Oct 18, 2021 at 10:04:46AM +0300, Andrew Rybchenko wrote:
> On 10/15/21 11:32 AM, Olivier Matz wrote:
> > On Thu, Oct 14, 2021 at 07:12:29AM +, Xia, Chenbo wrote:
> >>> -Original Message-
> >>> From: Ivan Malov
> >>> Sent: Fri
ut dropped by mistake at
commit.
Link: http://inbox.dpdk.org/dev/20210730155700.32574-1-olivier.m...@6wind.com
Signed-off-by: Olivier Matz
---
.../cocci/prefix_mbuf_offload_flags.cocci | 441 ++
1 file changed, 441 insertions(+)
create mode 100644 devt
The flags PKT_TX_VLAN_PKT and PKT_TX_QINQ_PKT are
marked as deprecated since commit 380a7aab1ae2 ("mbuf: rename deprecated
VLAN flags") (2017). But they were not using the RTE_DEPRECATED
macro, because it did not exist at this time. Add it, and replace
usage of these flags.
Signed-off-b
The flags PKT_RX_L4_CKSUM_BAD and PKT_RX_IP_CKSUM_BAD are defined
twice with the same value. Remove one of the occurence, which was
marked as "deprecated".
Signed-off-by: Olivier Matz
---
lib/mbuf/rte_mbuf_core.h | 18 --
1 file changed, 18 deletions(-)
diff --git
instead of removing them
* clarify that rx checksum flags are not really removed (just remove dup)
Olivier Matz (4):
mbuf: remove duplicate definition of cksum offload flags
mbuf: mark old VLAN offload flags as deprecated
cocci: add cocci script to rename mbuf offload flags
mbuf: add rte prefix
using AVX registers while halving the number of instructions
> in the generated code.
>
> Signed-off-by: Georg Sauthoff
The patch looks good to me, thanks!
Acked-by: Olivier Matz
On Fri, Oct 15, 2021 at 01:27:59PM +, Dmitry Kozlyuk wrote:
> > [...]
> > > +static int
> > > +test_mempool_flag_non_io_set_when_no_iova_contig_set(void)
> > > +{
> > > + struct rte_mempool *mp;
> > > + int ret;
> > > +
> > > + mp = rte_mempool_create_empty("empty", MEMPOOL_SIZE,
>
On Fri, Oct 15, 2021 at 01:07:42PM +, Dmitry Kozlyuk wrote:
[...]
> > > +static void
> > > +mempool_event_callback_invoke(enum rte_mempool_event event,
> > > + struct rte_mempool *mp)
> > > +{
> > > + struct mempool_callback_list *list;
> > > + struct rte_tailq
Hi Dmitry,
On Wed, Oct 13, 2021 at 02:01:29PM +0300, Dmitry Kozlyuk wrote:
> Mempool is a generic allocator that is not necessarily used for device
> IO operations and its memory for DMA. Add MEMPOOL_F_NON_IO flag to mark
> such mempools automatically if their objects are not contiguous
> or IOVA
On Wed, Oct 13, 2021 at 03:48:12PM -0500, Dharmik Thakkar wrote:
> From: Joyce Kong
>
> In stack module, remove the header file rte_atomic.h
> as it is not being used.
>
> Signed-off-by: Joyce Kong
> Signed-off-by: Dharmik Thakkar
> Reviewed-by: Ruifeng Wang
Acked-by: Olivier Matz
Thanks
On Wed, Oct 13, 2021 at 01:52:22AM +, zhihongx.p...@intel.com wrote:
> From: Zhihong Peng
>
> Malloc cl in the cmdline_stdin_new function, so release in the
> cmdline_stdin_exit function is logical, so that cl will not be
> released alone.
>
> Fixes: af75078fece3 ("first public release")
> C
On Thu, Oct 14, 2021 at 02:56:31PM -0700, Stephen Hemminger wrote:
> Lots of little typos in test programs.
>
> Signed-off-by: Stephen Hemminger
Reviewed-by: Olivier Matz
On Thu, Oct 14, 2021 at 02:56:22PM -0700, Stephen Hemminger wrote:
> More codespell finds.
>
> Signed-off-by: Stephen Hemminger
Acked-by: Olivier Matz
Thanks!
On Fri, Oct 15, 2021 at 10:39:41AM +0200, David Marchand wrote:
> This option should be prefixed with -- for consistency with others.
>
> Fixes: a103a97e7191 ("eal: allow user to override default mempool driver")
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Marchand
Reviewed-by: Olivier Matz
On Fri, Oct 15, 2021 at 10:20:06AM +0100, Morrissey, Sean wrote:
>
> On 15/10/2021 10:00, Olivier Matz wrote:
> > Hi Sean,
> >
> > On Thu, Oct 07, 2021 at 10:25:56AM +, Sean Morrissey wrote:
> > > These header includes have been flagged by the iwyu_tool
>
On Fri, Oct 15, 2021 at 01:41:40PM +0200, David Marchand wrote:
> On Fri, Oct 15, 2021 at 12:42 PM Dmitry Kozlyuk wrote:
> > > a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c index
> > > 8d5f99f7e7..27d197fe86 100644
> > > --- a/lib/mempool/rte_mempool.c
> > > +++ b/lib/mempool/rte_mempool
Hi Dmitry,
On Wed, Oct 13, 2021 at 02:01:28PM +0300, Dmitry Kozlyuk wrote:
> Data path performance can benefit if the PMD knows which memory it will
> need to handle in advance, before the first mbuf is sent to the PMD.
> It is impractical, however, to consider all allocated memory for this
> purp
On Fri, Oct 15, 2021 at 09:58:49AM +, Dmitry Kozlyuk wrote:
>
>
> > -Original Message-
> > From: Olivier Matz
> > Sent: 15 октября 2021 г. 12:43
> > To: Andrew Rybchenko
> > Cc: Dmitry Kozlyuk ; dev@dpdk.org; Matan Azrad
> >
> > Subj
On Fri, Oct 15, 2021 at 12:33:31PM +0300, Andrew Rybchenko wrote:
> On 10/15/21 12:18 PM, Dmitry Kozlyuk wrote:
> >> -Original Message-
> >> From: Andrew Rybchenko
> >> [...]
> >>> diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c
> >>> index 51c0ba2931..2204f140b3 100644
Hi Sean,
On Thu, Oct 07, 2021 at 10:25:56AM +, Sean Morrissey wrote:
> These header includes have been flagged by the iwyu_tool
> and removed.
>
> Signed-off-by: Sean Morrissey
> ---
> lib/kvargs/rte_kvargs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/kvargs/rte_kvargs.c b
On Thu, Oct 14, 2021 at 07:12:29AM +, Xia, Chenbo wrote:
> > -Original Message-
> > From: Ivan Malov
> > Sent: Friday, September 17, 2021 2:50 AM
> > To: dev@dpdk.org
> > Cc: Maxime Coquelin ; sta...@dpdk.org; Andrew
> > Rybchenko ; Xia, Chenbo
Hi Radu,
On Fri, Sep 03, 2021 at 11:59:42AM +0100, Radu Nicolau wrote:
> [PATCH] net: add support for UDP segmentation case
What about this title instead?
net: exclude IP len from phdr cksum if offloading UDP frag
> Add support to the ipv4/ipv6 pseudo-header function when TSO is enabled
> in th
Hi Dmitry,
On Tue, Oct 05, 2021 at 11:15:45PM +0300, Dmitry Kozlyuk wrote:
> Hide struct rdline definition and some RDLINE_* constants in order
> to be able to change internal buffer sizes transparently to the user.
> Add new functions:
>
> * rdline_new(): allocate and initialize struct rdline.
>
On Tue, Oct 05, 2021 at 12:03:01PM +0300, Dmitry Kozlyuk wrote:
> Hi Olivier,
>
> Thanks for the review, please see below.
>
> 2021-10-05 10:27 (UTC+0200), Olivier Matz:
> > [...]
> > > diff --git a/lib/cmdline/cmdline_cirbuf.c b/lib/cmdline/cmdline_cirbuf.c
>
Hi Dmitry,
Few comments below.
On Tue, Oct 05, 2021 at 03:55:16AM +0300, Dmitry Kozlyuk wrote:
> Hide struct rdline definition and some RDLINE_* constants in order
> to be able to change internal buffer sizes transparently to the user.
> Add new functions:
>
> * rdline_create(): allocate and ini
t; Time to mark them stable.
> >
> > rte_mbuf_to_baddr() could be removed, but since we lack a deprecation
> > notice, keep it as a simple wrapper.
> >
> > Signed-off-by: David Marchand
>
> Acked-by: Stephen Hemminger
Acked-by: Olivier Matz
On Mon, Oct 04, 2021 at 12:33:02PM -0700, Stephen Hemminger wrote:
> This inline function was added in 18.08
>
> Signed-off-by: Stephen Hemminger
> ---
> lib/mbuf/rte_mbuf.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h
> index 6913b6d6f3ff..a
On Mon, Oct 04, 2021 at 12:33:01PM -0700, Stephen Hemminger wrote:
> This function should be made stable now.
>
> Cc: konstantin.anan...@intel.com
> Signed-off-by: Stephen Hemminger
> Acked-by: Andrew Rybchenko
Acked-by: Olivier Matz
On Mon, Oct 04, 2021 at 08:59:34AM -0700, Stephen Hemminger wrote:
> On Mon, 4 Oct 2021 15:13:22 +0300
> Gregory Etelson wrote:
>
> > diff --git a/app/test/test_flow_classify.c b/app/test/test_flow_classify.c
> > index 951606f248..4f64be5357 100644
> > --- a/app/test/test_flow_classify.c
> > +++
Hi David,
Thank you for the review, my comments below.
On Mon, Oct 04, 2021 at 10:29:36AM +0200, David Marchand wrote:
> On Wed, Sep 29, 2021 at 11:50 PM Olivier Matz wrote:
> >
> > The flags PKT_TX_VLAN_PKT, PKT_TX_QINQ_PKT, PKT_RX_EIP_CKSUM_BAD are
> > marked as de
s-on: f7383e7c7ec1 ("net: announce changes in IPv4 header access")
Acked-by: Olivier Matz
> --- a/lib/net/rte_ip.h
> +++ b/lib/net/rte_ip.h
> @@ -38,7 +38,21 @@ extern "C" {
> * IPv4 Header
> */
> struct rte_ipv4_hdr {
> - uint8_t version_ihl;
Hi Aman,
On Thu, Sep 30, 2021 at 09:50:15PM +0530, Aman Singh wrote:
> Proposed name change of offload flag PKT_RX_EIP_CKSUM_BAD
> to PKT_RX_OUTER_IP_CKSUM_BAD has already been done in the
> code as per the deprecation note.
>
> Signed-off-by: Aman Singh
> Acked-by: Ferruh Yigit
Almost the sam
On Wed, Sep 29, 2021 at 11:39:42PM +0200, Olivier Matz wrote:
> The function was designed to be used as a handler for
> rte_kvargs_process() to compare the value string in a kvlist. For
> readability, its usages in DPDK have been replaced by
> rte_kvargs_get_with_value() in pre
Hi Andrew,
On Wed, Sep 29, 2021 at 10:37:34AM +0300, Andrew Rybchenko wrote:
> Removed offload flag PKT_RX_EIP_CKSUM_BAD. PKT_RX_OUTER_IP_CKSUM_BAD
> should be used as a replacement.
>
> Signed-off-by: Andrew Rybchenko
FYI, I just submitted a patchset that removes all PKT_ flags and
fixes the n
ut dropped by mistake at
commit.
Link: http://inbox.dpdk.org/dev/20210730155700.32574-1-olivier.m...@6wind.com
Signed-off-by: Olivier Matz
---
.../cocci/prefix_mbuf_offload_flags.cocci | 441 ++
1 file changed, 441 insertions(+)
create mode 100644 devt
The flags PKT_TX_VLAN_PKT, PKT_TX_QINQ_PKT, PKT_RX_EIP_CKSUM_BAD are
marked as deprecated since commit 380a7aab1ae2 ("mbuf: rename deprecated
VLAN flags") (2017). Remove their definitions from rte_mbuf_core.h,
and replace their usages.
Signed-off-by: Olivier Matz
---
app/test-pmd
sync with to get an updated
version.
Olivier Matz (3):
mbuf: remove deprecated offload flags
cocci: add cocci script to rename mbuf offload flags
mbuf: add rte prefix to offload flags
app/test-pmd/csumonly.c | 62 +--
app/test-pmd/flowgen.c
A '*' is missing at 2 places, add them.
Fixes: e1a00536c8ed ("kvargs: add a new library to parse key/value arguments")
Fixes: 3ab385063cb9 ("kvargs: add get by key")
Signed-off-by: Olivier Matz
Reviewed-by: Xueming Li
---
lib/kvargs/rte_kvargs.h | 4 ++--
1 fi
The function was designed to be used as a handler for
rte_kvargs_process() to compare the value string in a kvlist. For
readability, its usages in DPDK have been replaced by
rte_kvargs_get_with_value() in previous commit.
Remove this function, as it is not used anymore.
Signed-off-by: Olivier
replaced by this new
function.
Signed-off-by: Olivier Matz
Reviewed-by: Xueming Li
---
drivers/bus/auxiliary/auxiliary_params.c | 9
drivers/bus/vdev/vdev_params.c | 13 ++-
lib/kvargs/rte_kvargs.c | 23 +++
lib/kvargs/rte_kvargs.h
The function rte_kvargs_get() is used by eal and pci bus driver since
its introduction in commit 3ab385063cb9 ("kvargs: add get by key") and
commit d2a66ad79480 ("bus: add device arguments name parsing"), in
dpdk 21.05.
Let's promote it as stable.
Signed-off-by:
This function is used by EAL to parse key/value strings separated with
specified delimiters.
It was introduced in 2018 by commit 5d6af85ab00c ("kvargs: introduce a
more flexible parsing function"), and can be promoted as stable.
Signed-off-by: Olivier Matz
Reviewed-by: Xueming Li
This patchset promotes 2 functions rte_kvargs_parse_delim() and
rte_kvargs_get() as stable.
It also replaces rte_kvargs_strcmp() by a new one
rte_kvargs_get_with_value(), which is easier to use.
v2
* remove rte_kvargs_strcmp from version.map
Olivier Matz (5):
kvargs: promote delimited parsing
-1-olivier.m...@6wind.com/
Thanks,
Olivier
>
> Thanks,
> Ali
>
> > -Original Message-
> > From: Morten Brørup
> > Sent: Tuesday, September 28, 2021 12:40 PM
> > To: Slava Ovsiienko ; NBU-Contact-Thomas
> > Monjalon ; Olivier Matz ;
> > Al
an issue because it is expected that mbufs stored
in pool have their nb_seg field set to 1.
Fixes: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
Cc: sta...@dpdk.org
Signed-off-by: Olivier Matz
Acked-by: Morten Brørup
Acked-by: Ajit Khaparde
Acked-by: Konstantin Ananyev
---
a
> reworked because of the refactoring that happened in v21.02.
>
> Fixes: 17043a2909bb ("net/virtio: force IOVA as VA mode for virtio-user")
> Cc: sta...@dpdk.org
>
> Reported-by: Olivier Matz
> Signed-off-by: Maxime Coquelin
Tested-by: Olivier Matz
Many thanks for your quick solution on this!
Hi Joyce,
On Sun, Aug 22, 2021 at 10:20:34PM -0500, Joyce Kong wrote:
> In stack module, remove the duplicated header file rte_atomic.h
> as it has been included in rte_spinlock.h/rte_pause.h
>
> Signed-off-by: Joyce Kong
> Reviewed-by: Ruifeng Wang
Sorry for the late feedback.
No objection a
; > Fixes: 45a08ef55e44 ("net: introduce functions to verify L4 checksums")
> > Cc: sta...@dpdk.org
> > Signed-off-by: Lance Richardson
>
> Acked-by: Ferruh Yigit
>
Acked-by: Olivier Matz
Thanks!
On Fri, Sep 24, 2021 at 05:57:39PM +0200, Olivier Matz wrote:
> The function was designed to be used as a handler for
> rte_kvargs_process() to compare the value string in a kvlist. For
> readability, its usages in DPDK have been replaced by
> rte_kvargs_get_with_value() in pre
A '*' is missing at 2 places, add them.
Fixes: e1a00536c8ed ("kvargs: add a new library to parse key/value arguments")
Fixes: 3ab385063cb9 ("kvargs: add get by key")
Signed-off-by: Olivier Matz
---
lib/kvargs/rte_kvargs.h | 4 ++--
1 file changed, 2 insertions(+)
The function was designed to be used as a handler for
rte_kvargs_process() to compare the value string in a kvlist. For
readability, its usages in DPDK have been replaced by
rte_kvargs_get_with_value() in previous commit.
Remove this function, as it is not used anymore.
Signed-off-by: Olivier
replaced by this new
function.
Signed-off-by: Olivier Matz
---
drivers/bus/auxiliary/auxiliary_params.c | 9
drivers/bus/vdev/vdev_params.c | 13 ++-
lib/kvargs/rte_kvargs.c | 23 +++
lib/kvargs/rte_kvargs.h | 29
The function rte_kvargs_get() is used by eal and pci bus driver since
its introduction in commit 3ab385063cb9 ("kvargs: add get by key") and
commit d2a66ad79480 ("bus: add device arguments name parsing"), in
dpdk 21.05.
Let's promote it as stable.
Signed-off-by: Oliv
This function is used by EAL to parse key/value strings separated with
specified delimiters.
It was introduced in 2018 by commit 5d6af85ab00c ("kvargs: introduce a
more flexible parsing function"), and can be promoted as stable.
Signed-off-by: Olivier Matz
---
lib/kvargs/rte_kv
This patchset promotes 2 functions rte_kvargs_parse_delim() and
rte_kvargs_get() as stable.
It also replaces rte_kvargs_strcmp() by a new one
rte_kvargs_get_with_value(), which is easier to use.
Olivier Matz (5):
kvargs: promote delimited parsing as stable
kvargs: promote get from key as
This function is public since commit 8f0e4d6a78a5 ("net: export IPv6
header extensions skip function") (2018), and is used by vmxnet3 driver.
Promote it as stable.
Signed-off-by: Olivier Matz
---
lib/net/rte_net.h | 4
lib/net/version.map | 2 +-
2 files changed, 1 inser
Hi Zhihong,
On Fri, Sep 24, 2021 at 02:16:29AM +, zhihongx.p...@intel.com wrote:
> From: Zhihong Peng
>
> AddressSanitizer (ASan) is a google memory error detect
> standard tool. It could help to detect use-after-free and
> {heap,stack,global}-buffer overflow bugs in C/C++ programs,
> print
101 - 200 of 3408 matches
Mail list logo
