[dpdk-dev] [PATCH v2] doc: announce ABI change for rte_eth_dev structure

application that won't use it will have to prepare the mbuf, and this preparation will depend on the device, which is not acceptable inside an application. So, to conclude, the api change notification looks good to me, even if there is still some room to discuss the implementation details. Acked-by: Olivier Matz

[dpdk-dev] usages issue with external mempool

Hi Hemant, Jerin, On 07/27/2016 11:51 AM, Jerin Jacob wrote: > On Tue, Jul 26, 2016 at 10:11:13AM +, Hemant Agrawal wrote: >> Hi, >> There was lengthy discussions w.r.t external mempool >> patches. However, I am still finding usages issue with the agreed approach. >> >> The

[dpdk-dev] [PATCH v2] mempool: fix unsafe removal from list by callback

t; (*func)((struct rte_mempool *) te->data, arg); > } > > Acked-by: Olivier Matz Thanks

[dpdk-dev] [PATCH 2/2] mempool: fix unsafe tailq element removal

Hi Sergio, On 07/22/2016 06:01 PM, Sergio Gonzalez Monroy wrote: > Potentially user provided function could remove/free tailq elements. > Doing so within a TAILQ_FOREACH loop is not safe. > > Use _SAFE versions of _FOREACH macros. > > Signed-off-by: Sergio Gonzalez Monroy > --- >

[dpdk-dev] [PATCH 04/12] mbuf: add function to calculate a checksum

tio pmd in next commits to calculate >> the checksum in software in case the protocol is not recognized. >> >> Signed-off-by: Olivier Matz >> --- >> doc/guides/rel_notes/release_16_11.rst | 5 >> lib/librte_mbuf/rte_mbuf.c | 55 >>

[dpdk-dev] [PATCH 05/12] mbuf: add new Rx checksum mbuf flags

Hi Stephen, On 07/21/2016 11:22 PM, Stephen Hemminger wrote: > On Thu, 21 Jul 2016 10:08:23 +0200 > Olivier Matz wrote: > >> +/** >> + * Deprecated. >> + * Checking this flag alone is deprecated: check the 2 bits of >> + * PKT_RX_L4_CKSUM_MASK. >> + *

[dpdk-dev] [PATCH 02/12] virtio: setup and start cq in configure callback

On 07/21/2016 11:15 PM, Stephen Hemminger wrote: > On Thu, 21 Jul 2016 10:08:20 +0200 > Olivier Matz wrote: > >> +dev_info->max_rx_queues = (uint16_t) >> +((VIRTIO_MAX_RX_QUEUES < hw->max_queue_pairs) ? >> +VIRTIO

[dpdk-dev] [PATCH 04/12] mbuf: add function to calculate a checksum

Dear Don, On 07/21/2016 06:26 PM, Don Provan wrote: >> -Original Message- >> From: Ananyev, Konstantin [mailto:konstantin.ananyev at intel.com] >> Sent: Thursday, July 21, 2016 3:51 AM >> Subject: Re: [dpdk-dev] [PATCH 04/12] mbuf: add function to calculate a >> checksum >> >> ... >>> +

[dpdk-dev] [PATCH v2] mempool: adjust name string size in related data types

On 07/21/2016 03:47 PM, Zoltan Kiss wrote: > > > On 21/07/16 14:40, Olivier Matz wrote: >> Hi Zoltan, >> >> >> On 07/20/2016 07:16 PM, Zoltan Kiss wrote: >>> A recent patch brought up an issue about the size of the 'name' fields: >>> >>&

[dpdk-dev] [PATCH] memzone: allow full length name

XIST; > - return NULL; > - } > - > /* if alignment is not a power of two */ > if (align && !rte_is_power_of_2(align)) { > RTE_LOG(ERR, EAL, "%s(): Invalid alignment: %u\n", __func__, > Acked-by: Olivier Matz Thanks for fixing this.

[dpdk-dev] [PATCH] app/test: fix refcnt_mbuf_ring size

ZE, SOCKET_ID_ANY, > + rte_align32pow2(REFCNT_RING_SIZE), SOCKET_ID_ANY, > RING_F_SP_ENQ)) == NULL) { > printf("%s: cannot allocate " MAKE_STRING(refcnt_mbuf_ring) > "\n", __func__); > Acked-by: Olivier Matz

[dpdk-dev] [PATCH v2] mempool: adjust name string size in related data types

Hi Zoltan, On 07/20/2016 07:16 PM, Zoltan Kiss wrote: > A recent patch brought up an issue about the size of the 'name' fields: > > 85cf0079 mem: avoid memzone/mempool/ring name truncation > > These relations should be observed: > > 1. Each ring creates a memzone with a prefixed name: >

[dpdk-dev] [PATCH] test_mempool: remove unused mp_ext var

he); > rte_mempool_free(mp_cache); > - rte_mempool_free(mp_ext); > + rte_mempool_free(mp_stack); > return -1; > } > > Strange, it seems these modifications were present in latest patch from David Hunt (v6). Maybe a bad manipulation during the push? The "Fixes:" line should be added though. Acked-by: Olivier Matz

[dpdk-dev] [PATCH] app/test: disable filtering with stripped binary

k to the old behaviour if the binary > has no symbol information: > > PCI autotest: Fail [Not found] [00m 00s] > Malloc autotest: Success [00m 00s] > > Fixes: d553c8f2b1a2 ("app/test: filter out unavailable tests

[dpdk-dev] [PATCH] app/test: increase memory allocated for greedy autotests

y tests > which often fail because of memory fragmentation: > LPM6 and reentrancy tests in groups 3 and 6 respectively. > > Signed-off-by: Thomas Monjalon Tested-by: Olivier Matz

[dpdk-dev] [PATCH 12/12] virtio: add Tso support

Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 6 ++ drivers/net/virtio/virtio_ethdev.h | 2 + drivers/net/virtio/virtio_rxtx.c | 129 - 3 files changed, 134 insertions(+), 3 deletions(-) diff --git a/drivers/net/virtio

[dpdk-dev] [PATCH 11/12] virtio: add Lro support

Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 7 ++- drivers/net/virtio/virtio_ethdev.h | 9 - drivers/net/virtio/virtio_rxtx.c | 21 + 3 files changed, 27 insertions(+), 10 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c

[dpdk-dev] [PATCH 10/12] virtio: add Tx checksum offload support

Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 7 + drivers/net/virtio/virtio_ethdev.h | 1 + drivers/net/virtio/virtio_rxtx.c | 57 +- 3 files changed, 45 insertions(+), 20 deletions(-) diff --git a/drivers/net/virtio

[dpdk-dev] [PATCH 09/12] virtio: add Rx checksum offload support

Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 14 drivers/net/virtio/virtio_ethdev.h | 2 +- drivers/net/virtio/virtio_rxtx.c | 66 ++ drivers/net/virtio/virtqueue.h | 1 + 4 files changed, 75 insertions(+), 8 deletions

[dpdk-dev] [PATCH 08/12] app/testpmd: display lro segment size

In csumonly engine, display the value of LRO segment if the LRO flag is set. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 34a2591..3455a7e 100644 --- a/app/test-pmd

[dpdk-dev] [PATCH 07/12] mbuf: new flag for LRO

gsz field is valid and is set to the segment size of original packets. This flag is used in next commits in the virtio pmd. Signed-off-by: Olivier Matz --- doc/guides/rel_notes/release_16_11.rst | 5 + lib/librte_mbuf/rte_mbuf.c | 2 ++ lib/librte_mbuf/rte_mbuf.h

[dpdk-dev] [PATCH 06/12] app/testpmd: fix checksum stats in csum engine

--- app/test-pmd/csumonly.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 4b36d74..34a2591 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -680,8 +680,10 @@ pkt_burst_checksum_forward(struct

[dpdk-dev] [PATCH 05/12] mbuf: add new Rx checksum mbuf flags

with existing applications that only check the existing flag (CKSUM_BAD). [1] http://dpdk.org/ml/archives/dev/2016-May/039920.html [2] http://dpdk.org/ml/archives/dev/2016-June/040007.html Signed-off-by: Olivier Matz --- doc/guides/rel_notes/release_16_11.rst | 6 lib/librte_mbuf/rte_mbuf.c

[dpdk-dev] [PATCH 04/12] mbuf: add function to calculate a checksum

This function can be used to calculate the checksum of data embedded in mbuf, that can be composed of several segments. This function will be used by the virtio pmd in next commits to calculate the checksum in software in case the protocol is not recognized. Signed-off-by: Olivier Matz --- doc

[dpdk-dev] [PATCH 03/12] virtio: reinitialize the device in configure callback

Add the ability to reset the virtio device in the configure callback if the features flag changed since previous reset. This will be possible with the introduction of offload support in next commits. Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 26

[dpdk-dev] [PATCH 02/12] virtio: setup and start cq in configure callback

fig->max_virtqueue_pairs is already displayed above. Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 45 +++--- drivers/net/virtio/virtio_pci.h| 3 +-- 2 files changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/net/

[dpdk-dev] [PATCH 01/12] virtio: move device initialization in a function

ion. Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 99 ++ 1 file changed, 58 insertions(+), 41 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index fcc996e..4926a2c 100644 --- a/drivers/

[dpdk-dev] [PATCH 00/12] net/virtio: add offload support

/2016-May/039920.html [2] http://dpdk.org/ml/archives/dev/2016-July/04.html [3] http://dpdk.org/ml/archives/dev/2016-July/043826.html [4] http://dpdk.org/ml/archives/dev/2016-July/044266.html Olivier Matz (12): virtio: move device initialization in a function virtio: setup and start cq

[dpdk-dev] [PATCH] mempool: adjust name string size in related data types

Hi, On 07/20/2016 02:41 PM, Zoltan Kiss wrote: > > > On 19/07/16 17:17, Olivier Matz wrote: >> Hi Zoltan, >> >> On 07/19/2016 05:59 PM, Zoltan Kiss wrote: >>> >>> >>> On 19/07/16 16:37, Olivier Matz wrote: >>>> Hi Zoltan, >&

[dpdk-dev] [PATCH v2] doc: announce ABI change for mbuf structure

For 16.11, the mbuf structure will be modified implying ABI breakage. Some discussions already took place here: http://www.dpdk.org/dev/patchwork/patch/12878/ Signed-off-by: Olivier Matz --- v1->v2: - reword the sentences to keep things more open, as suggested by Bruce doc/guides/rel_no

[dpdk-dev] [PATCH] mempool: adjust name string size in related data types

Hi Zoltan, On 07/19/2016 05:59 PM, Zoltan Kiss wrote: > > > On 19/07/16 16:37, Olivier Matz wrote: >> Hi Zoltan, >> >> On 07/19/2016 04:37 PM, Zoltan Kiss wrote: >>> A recent fix brought up an issue about the size of the 'name' fields: >>> >

[dpdk-dev] [PATCH] ixgbe: support checksum flags in sse vector Rx function

Hi Sugesh, On 07/14/2016 11:24 AM, Chandran, Sugesh wrote: > Hi Olivier, > Thank you for working on this. > We tried to enable checksum offload in OVS-DPDK and couldn't proceed due to > the performance impact. > I assume this patch will fix that issue by enabling checksum offloading with >

[dpdk-dev] [PATCH] mempool: adjust name string size in related data types

Hi Zoltan, On 07/19/2016 04:37 PM, Zoltan Kiss wrote: > A recent fix brought up an issue about the size of the 'name' fields: > > 85cf0079 mem: avoid memzone/mempool/ring name truncation > > These relations should be observed: > > RTE_RING_NAMESIZE <= RTE_MEMZONE_NAMESIZE -

[dpdk-dev] [PATCH] doc: announce ABI change for mbuf structure

On 07/19/2016 05:07 PM, Richardson, Bruce wrote: > > >> -Original Message----- >> From: Olivier Matz [mailto:olivier.matz at 6wind.com] >> Sent: Tuesday, July 19, 2016 4:04 PM >> To: Richardson, Bruce >> Cc: dev at dpdk.org; jerin.jacob at ca

[dpdk-dev] [PATCH] mempool: fix lack of free() registration

queue = h->enqueue; > ops->dequeue = h->dequeue; > ops->get_count = h->get_count; > Apart from that: Acked-by: Olivier Matz +CC Thomas, I think it should be included in 16.07. Thanks!

[dpdk-dev] [PATCH] doc: announce ABI change for mbuf structure

Hi Bruce, On 07/19/2016 04:40 PM, Bruce Richardson wrote: > On Tue, Jul 19, 2016 at 04:01:15PM +0200, Olivier Matz wrote: >> For 16.11, the mbuf structure will be modified implying ABI breakage. >> Some discussions already took place here: >> http://www.dpdk.org/dev/

[dpdk-dev] [PATCH] doc: announce ABI change for mbuf structure

For 16.11, the mbuf structure will be modified implying ABI breakage. Some discussions already took place here: http://www.dpdk.org/dev/patchwork/patch/12878/ Signed-off-by: Olivier Matz --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc

[dpdk-dev] [PATCH] virtio: fix packet corruption

Hi, On 07/19/2016 03:57 PM, Tan, Jianfeng wrote: > > >> -Original Message----- >> From: Olivier Matz [mailto:olivier.matz at 6wind.com] >> Sent: Tuesday, July 19, 2016 9:11 PM >> To: Tan, Jianfeng; dev at dpdk.org; Xie, Huawei; yuanhan.liu at >> li

[dpdk-dev] [PATCH] virtio: fix packet corruption

Hi Jianfeng, On 07/19/2016 03:03 PM, Tan, Jianfeng wrote: > Hi Oliver, > >> -Original Message----- >> From: Olivier Matz [mailto:olivier.matz at 6wind.com] >> Sent: Tuesday, July 19, 2016 8:32 PM >> To: dev at dpdk.org; Tan, Jianfeng; Xie, Huawei; yuan

[dpdk-dev] [PATCH] virtio: fix packet corruption

escriptors") Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 2 +- drivers/net/virtio/virtio_rxtx.c| 5 +++-- drivers/net/virtio/virtio_rxtx_simple.c | 13 +++-- drivers/net/virtio/virtqueue.h | 25 + 4 files changed, 2

[dpdk-dev] crash in virtio pmd

Sorry, there was a typo in Huawei's mail, I copy-pasted it from the other thread "[dpdk-dev] virtio PMD issue". On 07/18/2016 06:06 PM, Olivier Matz wrote: > Hi, > > On 16.07-rc3, when I start testpmd with a virtio driver in a VM, > requesting options that are not im

[dpdk-dev] crash in virtio pmd

Hi, On 16.07-rc3, when I start testpmd with a virtio driver in a VM, requesting options that are not implemented (rx checksum), it crashes: ./build/app/testpmd -l 0,1 --log-level 8 -- --total-num-mbufs=16384 -i --port-topology=chained --disable-hw-vlan-filter --disable-hw-vlan-strip

[dpdk-dev] mutli process C/S model example init failed on xen dom0 with dpdk-16.07 rc2 package

Hi Sergio, On 07/18/2016 01:33 PM, Sergio Gonzalez Monroy wrote: > On 12/07/2016 12:30, Olivier MATZ wrote: >> On 07/12/2016 11:22 AM, Xu, HuilongX wrote: >>> /examples/multi_process/client_server_mp/mp_server/mp_server/x86_64-native-linuxapp-gcc/mp_server >>> >>

[dpdk-dev] [PATCH] mempool: fix empty structure definition

use the same size for objects to avoid corruption during run > time. > > Fixes: 97e7e685bfcd ("mempool: add structure for object trailers") > > Signed-off-by: Adrien Mazarguil Acked-by: Olivier Matz

[dpdk-dev] mutli process C/S model example init failed on xen dom0 with dpdk-16.07 rc2 package

Hi Huilong, On 07/12/2016 11:22 AM, Xu, HuilongX wrote: > Hi all, > > I run mutli procee C/S model example failed on xen dom0. Does anyone > give me some suggest how to debug it? > > Thanks a lot > > test environment: > >OS: 3.17.4-301.fc21.x86_64 > > Gcc version: gcc version 4.9.2

[dpdk-dev] [PATCH 8/8] app/testpmd: hide segsize when unrelevant in csum engine

When TSO is not asked, hide the segment size. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 9938150..4b36d74 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test

[dpdk-dev] [PATCH 7/8] app/testpmd: don't use tso if packet is too small

Asking for TSO (TCP Segmentation Offload) on packets that are already smaller than (headers + MSS) does not work, for instance on ixgbe. Fix the csumonly engine to only set the TSO flag when a segmentation offload is really required, i.e. when packet is large enough. Signed-off-by: Olivier Matz

[dpdk-dev] [PATCH 6/8] app/testpmd: display rx port in csum engine

This information is useful when debugging, especially with bidirectional traffic. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index ee98724..35edf1d 100644

[dpdk-dev] [PATCH 5/8] app/testpmd: do not change ip addrs in csum engine

ner_cksums() and process_outer_cksums() already reset the checksum field to 0, so this is not necessary. Moreover, this makes the engine more complex than needed, and prevents to easily use it to forward traffic (like iperf) as it modifies the packets. This patch drops this behavior. Signed-off-b

[dpdk-dev] [PATCH 4/8] app/testpmd: add option to enable lro

Introduce a new argument '--enable-lro' to ask testpmd to enable the LRO feature on enabled ports, like it's done for '--enable-rx-cksum' for instance. Signed-off-by: Olivier Matz --- app/test-pmd/parameters.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test-pmd/parameters.c b

[dpdk-dev] [PATCH 3/8] app/testpmd: dump rx flags in csum engine

Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 7cc51df..a484b18 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c

[dpdk-dev] [PATCH 2/8] app/testpmd: use new function to dump offload flags

Use the functions introduced in the previous commit to dump the offload flags. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 27 +++ app/test-pmd/rxonly.c | 15 ++- 2 files changed, 5 insertions(+), 37 deletions(-) diff --git a/app/test-pmd

[dpdk-dev] [PATCH 1/8] mbuf: add function to dump ol flag list

new functions to do that. Similarly to the packet type dump functions, the goal is to factorize the code that could be used in several applications and reduce the risk of desynchronization between the flags and the dump functions. Signed-off-by: Olivier Matz --- doc/guides/rel_notes/release_16_11.rst |

[dpdk-dev] [PATCH 0/8] Misc enhancements in testpmd

/archives/dev/2016-July/04.html Olivier Matz (8): mbuf: add function to dump ol flag list app/testpmd: use new function to dump offload flags app/testpmd: dump rx flags in csum engine app/testpmd: add option to enable lro app/testpmd: do not change ip addrs in csum engine app/testpmd

[dpdk-dev] [PATCH 0/4] fix mempool creation with Xen Dom0

On 07/11/2016 12:20 PM, Olivier Matz wrote: > Since the recent mempool rework [1], Xen Dom0 is broken. > This series aims at fixing it. I think it should be integrated > in 16.07. > > As I don't have a full testing platform, any help in validating > this patchset would be ap

[dpdk-dev] [PATCH] lib: move rte_ring read barrier to correct location

Hi, On 07/11/2016 01:22 PM, Kuusisaari, Juhamatti wrote: > > Hi, > >>> -Original Message- >>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Juhamatti >>> Kuusisaari >>> Sent: Monday, July 11, 2016 11:21 AM >>> To: dev at dpdk.org >>> Subject: [dpdk-dev] [PATCH] lib: move

[dpdk-dev] [PATCH 4/4] mempool: fix creation with Xen Dom0

Restore the use of 2M hugepages when using Xen Dom0 that was dropped during mempool rework. Fixes: c042ba20674a ("mempool: rework support of Xen dom0") Signed-off-by: Olivier Matz --- lib/librte_mempool/rte_mempool.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff -

[dpdk-dev] [PATCH 3/4] eal: fix retrieval of phys address with Xen Dom0

mpool: rework support of Xen dom0") Fixes: 3097de6e6bfb ("mem: get physical address of any pointer") Signed-off-by: Olivier Matz --- lib/librte_eal/linuxapp/eal/eal_memory.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/lib/librte_eal/linuxapp/eal

[dpdk-dev] [PATCH 2/4] mbuf: set errno on pool creation error

In rte_pktmbuf_pool_create(), the rte_errno variable was not always set on failure. Fixes: 152ca517900b ("mbuf: use default mempool handler from config") Signed-off-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff -

[dpdk-dev] [PATCH 1/4] eal: fix typo in Xen Dom0 specific code

Fix the compilation with CONFIG_RTE_LIBRTE_XEN_DOM0=y, by correcting the typo in variable names. Fixes: 8dab48370129 ("xen: return machine address without knowing memseg id") Signed-off-by: Olivier Matz --- lib/librte_eal/linuxapp/eal/eal_xen_memory.c | 4 ++-- 1 file changed, 2

[dpdk-dev] [PATCH 0/4] fix mempool creation with Xen Dom0

Olivier Matz (4): eal: fix typo in Xen Dom0 specific code mbuf: set errno on pool creation error eal: fix retrieval of phys address with Xen Dom0 mempool: fix creation with Xen Dom0 lib/librte_eal/linuxapp/eal/eal_memory.c | 23 +++ lib/librte_eal/linuxapp/eal

[dpdk-dev] [PATCH] net/enic: decrement Tx mbuf reference count before recycling

Hi John, On 07/09/2016 12:22 AM, John Daley wrote: > In the Tx cleanup function, the reference count in mbufs to be > returned to the pool should to be decremented before they are > returned. Decrementing is not done by rte_mempool_put_bulk() > so it must be done separately using

[dpdk-dev] [PATCH] ixgbe: support checksum flags in sse vector Rx function

Hi Bruce, On 07/08/2016 10:42 PM, Bruce Richardson wrote: > On Thu, Jul 07, 2016 at 02:19:02PM +0200, Olivier Matz wrote: >> Update desc_to_olflags_v() to set PKT_RX_IP_CKSUM_BAD and >> PKT_RX_L4_CKSUM_BAD in the ol_fags of the mbuf. >> {...} > > Given this

[dpdk-dev] [PATCH 09/18] mbuf: support Mpls in software packet type parser

Hi Cunming, On 07/07/2016 10:48 AM, Liang, Cunming wrote: > Hi Olivier, > >> -Original Message----- >> From: Olivier MATZ [mailto:olivier.matz at 6wind.com] >> Sent: Wednesday, July 06, 2016 4:00 PM >> To: Liang, Cunming ; dev at dpdk.org >> Subjec

[dpdk-dev] [PATCH 05/18] mbuf: add function to get packet type from data

Hi Cunming, Thank you for your feedback. On 07/07/2016 10:19 AM, Liang, Cunming wrote: > Hi Olivier, > >> -Original Message----- >> From: Olivier MATZ [mailto:olivier.matz at 6wind.com] >> Sent: Wednesday, July 06, 2016 3:43 PM >> To: Liang, Cunming ; dev at

[dpdk-dev] [PATCH] ixgbe: support checksum flags in sse vector Rx function

src=00:01:02:03:04:05 - dst=00:1B:21:AB:8F:10 - type=0x0800 - length=92 - nb_segs=1Unknown packet type - Receive queue=0x0 PKT_RX_L4_CKSUM_BAD port 0/queue 0: received 1 packets src=00:01:02:03:04:05 - dst=00:1B:21:AB:8F:10 - type=0x0800 - length=92 - nb_segs=1Unknown packet typ

[dpdk-dev] about rx checksum flags

Hi Sugesh On 07/06/2016 02:52 PM, Chandran, Sugesh wrote: > Hi Olivier, > > Just to confirm , is this rx checksum patch already submitted in the DPDK ML? > We would like to use these flags to speed up the tunneling in OVS. No it is not submitted yet. I plan to send it in the coming days, it

[dpdk-dev] [PATCH 05/18] mbuf: add function to get packet type from data

Hi Andrey, On 07/06/2016 01:59 PM, Chilikin, Andrey wrote: > Hi Oliver, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier MATZ >> Sent: Wednesday, July 6, 2016 8:43 AM >> To: Liang, Cunming ; dev at dpdk.org >>

[dpdk-dev] [PATCH 01/18] doc: add template for release notes 16.11

Hi John, On 07/06/2016 01:48 PM, Mcnamara, John wrote: >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier Matz >> Sent: Tuesday, July 5, 2016 4:42 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH 01/18] doc:

[dpdk-dev] [PATCH 09/18] mbuf: support Mpls in software packet type parser

Hi Cunming, On 07/06/2016 09:08 AM, Liang, Cunming wrote: > Hi Olivier, > > On 7/5/2016 11:41 PM, Olivier Matz wrote: >> Add a new RTE_PTYPE_L2_ETHER_MPLS packet type, and its support in >> rte_pktmbuf_get_ptype(). >> >> Signed-off-by: Didier Pallar

[dpdk-dev] [PATCH 05/18] mbuf: add function to get packet type from data

Hi Cunming, On 07/06/2016 08:44 AM, Liang, Cunming wrote: > Hi Olivier, > > On 7/5/2016 11:41 PM, Olivier Matz wrote: >> Introduce the function rte_pktmbuf_get_ptype() that parses a >> mbuf and returns its packet type. For now, the following packet >> types are parsed:

[dpdk-dev] [PATCH 18/18] app/testpmd: display sw packet type

supports. Signed-off-by: Olivier Matz --- app/test-pmd/rxonly.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/rxonly.c b/app/test-pmd/rxonly.c index aba07ee..00da1a2 100644 --- a/app/test-pmd/rxonly.c +++ b/app/test-pmd/rxonly.c @@ -93,6

[dpdk-dev] [PATCH 17/18] app/testpmd: dump ptype using the new function

Use the function introduced in previous commit to dump the packet type of the received packet. Signed-off-by: Olivier Matz --- app/test-pmd/rxonly.c | 175 ++ 1 file changed, 4 insertions(+), 171 deletions(-) diff --git a/app/test-pmd/rxonly.c b

[dpdk-dev] [PATCH 16/18] mbuf: clarify definition of fragment packet types

An IPv4 packet is considered as a fragment if: - MF (more fragment) bit is set - or Fragment_Offset field is non-zero Update the API documentation of packet types to reflect this. Signed-off-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf_ptype.h | 26 -- 1 file changed

[dpdk-dev] [PATCH 15/18] mbuf: add functions to dump packet type

Dumping the packet type is useful for debug purposes. Instead of having each application providing its function to do that, introduce functions to do it. It factorizes the code and reduces the risk of desynchronization between the new packet types and the dump function. Signed-off-by: Olivier

[dpdk-dev] [PATCH 14/18] mbuf: get ptype for the first layers only

Add a parameter to rte_pktmbuf_get_ptype() to select which layers should be parsed. This avoids to parse all layers if only the first ones are required. Signed-off-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf_ptype.c | 33 - lib/librte_mbuf/rte_mbuf_ptype.h | 7

[dpdk-dev] [PATCH 13/18] mbuf: support Nvgre in software packet type parser

Add support of Nvgre tunnels in rte_pktmbuf_get_ptype(). At the same time, as Nvgre transports Ethernet, we need to add the support for inner Vlan, QinQ, and Mpls. Signed-off-by: Jean Dao Signed-off-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf_ptype.c | 48

[dpdk-dev] [PATCH 12/18] mbuf: support Gre in software packet type parser

Add support of Gre tunnels in rte_pktmbuf_get_ptype(). Signed-off-by: Jean Dao Signed-off-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf_ptype.c | 40 lib/librte_mbuf/rte_mbuf_ptype.h | 2 +- 2 files changed, 37 insertions(+), 5 deletions(-) diff --git

[dpdk-dev] [PATCH 11/18] net: add Gre header structure

Add the Gre header structure in librte_net. It will be used by next patches that adds the support of Gre tunnels in the software packet type parser. The extended headers (checksum, key or sequence number) are not defined. Signed-off-by: Jean Dao Signed-off-by: Olivier Matz --- lib/librte_net

[dpdk-dev] [PATCH 10/18] mbuf: support Ip tunnels in software packet type parser

Add support of IP and IP6 tunnels in rte_pktmbuf_get_ptype(). We need to duplicate some code because the packet types do not have the same value for a given protocol between inner and outer. Signed-off-by: Jean Dao Signed-off-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf_ptype.c | 158

[dpdk-dev] [PATCH 09/18] mbuf: support Mpls in software packet type parser

Add a new RTE_PTYPE_L2_ETHER_MPLS packet type, and its support in rte_pktmbuf_get_ptype(). Signed-off-by: Didier Pallard Signed-off-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf_ptype.c | 25 + lib/librte_mbuf/rte_mbuf_ptype.h | 9 - lib/librte_net/Makefile

[dpdk-dev] [PATCH 08/18] net: add Mpls header structure

Add the Mpls header structure in librte_net. It will be used by next patches that adds the support of Mpls L2 layer in the software packet type parser. Signed-off-by: Olivier Matz --- lib/librte_net/rte_mpls.h | 64 +++ 1 file changed, 64 insertions

[dpdk-dev] [PATCH 07/18] mbuf: support QinQ in software packet type parser

Add a new RTE_PTYPE_L2_ETHER_QINQ packet type, and its support in rte_pktmbuf_get_ptype(). Signed-off-by: Didier Pallard Signed-off-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf_ptype.c | 12 lib/librte_mbuf/rte_mbuf_ptype.h | 9 - lib/librte_net/rte_ether.h | 1

[dpdk-dev] [PATCH 06/18] mbuf: support Vlan in software packet type parser

Add a new RTE_PTYPE_L2_ETHER_VLAN packet type, and its support in rte_pktmbuf_get_ptype(). Signed-off-by: Didier Pallard Signed-off-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf_ptype.c | 13 + lib/librte_mbuf/rte_mbuf_ptype.h | 9 - 2 files changed, 21 insertions(+), 1

[dpdk-dev] [PATCH 05/18] mbuf: add function to get packet type from data

if the checksum is relevant for inner or outer. This information has to be known to properly set the ol_flags in mbuf. Signed-off-by: Didier Pallard Signed-off-by: Jean Dao Signed-off-by: Olivier Matz --- doc/guides/rel_notes/release_16_11.rst | 5 + lib/librte_mbuf/Makefile

[dpdk-dev] [PATCH 04/18] mbuf: move packet type definitions in a new file

The file rte_mbuf.h starts to be quite big, and next commits will introduce more functions related to packet types. Let's move them in a new file. Signed-off-by: Olivier Matz --- lib/librte_mbuf/Makefile | 2 +- lib/librte_mbuf/rte_mbuf.h | 495

[dpdk-dev] [PATCH 03/18] net: move Ethernet header definitions to the net library

Pallard Signed-off-by: Olivier Matz --- lib/librte_ether/Makefile| 3 +- lib/librte_ether/rte_ether.h | 416 --- lib/librte_net/Makefile | 2 +- lib/librte_net/rte_ether.h | 416 +++ 4 files changed, 418

[dpdk-dev] [PATCH 02/18] mbuf: add function to read packet data

Introduce a new function to read the packet data from an mbuf chain. It linearizes the data if required, and also ensures that the mbuf is large enough. This function is used in next commits that add a software parser to retrieve the packet type. Signed-off-by: Olivier Matz --- doc/guides

[dpdk-dev] [PATCH 01/18] doc: add template for release notes 16.11

Signed-off-by: Olivier Matz --- doc/guides/rel_notes/release_16_11.rst | 160 + 1 file changed, 160 insertions(+) create mode 100644 doc/guides/rel_notes/release_16_11.rst diff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11

[dpdk-dev] [PATCH 00/18] software parser for packet type

when implementing Rx offload support in virtio pmd. Indeed, the virtio protocol gives the csum start and offset, but it does not give the L4 protocol nor it tells if the checksum is relevant for inner or outer. This information has to be known to properly set the ol_flags in mbuf. Olivier Matz (18

[dpdk-dev] [PATCH 3/3] net/mlx4: add link up/down callback function

From: Guo Fengtian Implement dev_set_link_up and dev_set_link_down device operations. Code is inspired from mlx5. Signed-off-by: Guo Fengtian --- drivers/net/mlx4/mlx4.c | 86 + 1 file changed, 86 insertions(+) diff

[dpdk-dev] [PATCH 2/3] net/mlx5: fix api comment of link set function

Fixes: 62072098b54e ("mlx5: support setting link up or down") Signed-off-by: Olivier Matz --- drivers/net/mlx5/mlx5_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 6fef902..130e

[dpdk-dev] [PATCH 0/3] net/mlx: fix link state modification

This series adds a missing device operation in mlx4 to set the link state. It also fixes the function to set the flags on the kernel interface in both mlx4 and mlx5. Guo Fengtian (1): net/mlx4: add link up/down callback function Olivier Matz (2): net/mlx: fix setting of interface flags net

[dpdk-dev] [PATCH v3] mempool: rename functions with confusing names

On 06/30/2016 10:05 PM, Thomas Monjalon wrote: > 2016-06-30 13:49, Bruce Richardson: >> The mempool_count and mempool_free_count behaved contrary to what their >> names suggested. The free_count function actually returned the number of >> elements that were allocated from the pool, not the

[dpdk-dev] [PATCH] ethdev: enhance api doc for getting supported packet types

As discussed in http://dpdk.org/ml/archives/dev/2016-June/042229.html, clarify the behavior of rte_eth_dev_get_supported_ptypes(). Signed-off-by: Olivier Matz --- lib/librte_ether/rte_ethdev.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.h b

[dpdk-dev] [PATCH v6 0/2] mempool: add stack mempool handler

f the Mempool Handler feature > > v2 changes: > * updated based on mailing list feedback (Thanks Stephen) > * checkpatch fixes. > > David Hunt (2) > mempool: add stack (lifo) mempool handler > test: migrate custom handler test to stack handler > Acked-by: Olivier Matz Thanks!

[dpdk-dev] [PATCH v2] net/ixgbe: fix compilation when offload flags disabled

the third error. Fixes: b37b528d957c ("mbuf: add new Rx flags for stripped VLAN") Reported-by: Amin Tootoonchian Signed-off-by: Olivier Matz --- drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx_

[dpdk-dev] [PATCH v5 2/2] test: migrate custom handler test to stack handler

Hi David, On 06/30/2016 08:05 PM, David Hunt wrote: > After introducing the stack handler in the previous commit, > we now have very similar code to the custom handler in test_mempool.c, > which creates a custom mempool based on simple mallocs. > The stack handler is a cleaner example of adding a

[dpdk-dev] [PATCH] cmdline: fix unchecked return value

Hi Daniel, >>> --- a/lib/librte_cmdline/cmdline_rdline.c >>> +++ b/lib/librte_cmdline/cmdline_rdline.c >>> @@ -377,7 +377,10 @@ rdline_char_in(struct rdline *rdl, char c) >>> case CMDLINE_KEY_CTRL_K: >>> cirbuf_get_buf_head(>right, rdl->kill_buf, >>

[dpdk-dev] [PATCH] mempool: rename functions with confusing names

On 06/29/2016 06:02 PM, Wiles, Keith wrote: > > On 6/29/16, 11:00 AM, "dev on behalf of Bruce Richardson" dpdk.org on behalf of bruce.richardson at intel.com> wrote: > >> On Wed, Jun 29, 2016 at 05:55:27PM +0200, Thomas Monjalon wrote: >>> 2016-06-29 14:55, Bruce Richardson: The

<    1   2   3   4   5   6   7   8   9   10   >