On Tue, Jul 16, 2019 at 11:01:21AM +0200, Olivier Matz wrote:
> On Fri, Jul 12, 2019 at 11:54:36PM +0800, Gavin Hu wrote:
> > Currently, the flush is done by dequeuing the ring in a while loop. It is
> > much simpler to flush the queue by resetting the head and tail indices.
Hi,
On Tue, Jul 16, 2019 at 09:40:59AM +, Vamsi Krishna Attunuru wrote:
>
>
> > -Original Message-
> > From: Olivier Matz
> > Sent: Tuesday, July 16, 2019 2:17 PM
> > To: Burakov, Anatoly
> > Cc: Jerin Jacob Kollanukkaran ; Ferruh Yigit
&g
On Fri, Jul 12, 2019 at 05:54:57PM +0300, Andrew Rybchenko wrote:
> On 10.07.2019 12:29, Olivier Matz wrote:
> > Many features require to store data inside the mbuf. As the room in mbuf
> > structure is limited, it is not possible to have a field for each
> > feature. Also, c
On Fri, Jul 12, 2019 at 12:23:19PM +, Jerin Jacob Kollanukkaran wrote:
> > -Original Message-
> > From: dev On Behalf Of Olivier Matz
> > Sent: Thursday, July 11, 2019 1:07 PM
> > To: Stephen Hemminger
> > Cc: dev@dpdk.org
> > Subject: Re: [d
dk.org
>
> Signed-off-by: Gavin Hu
> Reviewed-by: Ruifeng Wang
> Reviewed-by: Honnappa Nagarahalli
Acked-by: Olivier Matz
On Tue, Jul 16, 2019 at 10:47:20AM +0200, Olivier Matz wrote:
> On Fri, Mar 15, 2019 at 11:31:25AM +0800, Gavin Hu wrote:
> > Currently, the flush is done by dequeuing the ring in a while loop. It is
> > much simpler to flush the queue by resetting the head and tail indices.
dk.org
>
> Signed-off-by: Gavin Hu
> Reviewed-by: Ruifeng Wang
> Reviewed-by: Honnappa Nagarahalli
Acked-by: Olivier Matz
Hi,
On Mon, Jul 15, 2019 at 10:38:53AM +0100, Burakov, Anatoly wrote:
> On 15-Jul-19 5:54 AM, Jerin Jacob Kollanukkaran wrote:
> > > > > > > > (also, i don't really like the name NO_PAGE_BOUND since in
> > > > > > > > memzone API there's a "bounded memzone" allocation API, and this
> > > > > > > >
Hi Gavin,
On Fri, Jul 12, 2019 at 11:06:28AM +, Gavin Hu (Arm Technology China) wrote:
> Hi Olivier,
>
> > -Original Message-
> > From: Olivier Matz
> > Sent: Friday, July 12, 2019 5:54 PM
> > To: Gavin Hu (Arm Technology China)
> > Cc: t
Hi Gavin,
On Fri, Jul 12, 2019 at 09:32:39AM +, Gavin Hu (Arm Technology China) wrote:
> Hi Olivier and Thomas,
>
> > -Original Message-
> > From: Thomas Monjalon
> > Sent: Thursday, July 4, 2019 10:42 PM
> > To: Gavin Hu (Arm Technology China)
>
On Thu, Jul 11, 2019 at 08:31:19AM -0700, Stephen Hemminger wrote:
> On Thu, 11 Jul 2019 09:26:19 +0200
> Olivier Matz wrote:
>
> > For generic fields, I think they should be declared in this file. For
> > instance, if we decide to replace the current m->timestamp fiel
Hi,
On Thu, Jul 11, 2019 at 02:37:23PM +, Wiles, Keith wrote:
>
>
> > On Jul 11, 2019, at 2:53 AM, Olivier Matz wrote:
> >
> > Hi Keith,
> >
> > On Wed, Jul 10, 2019 at 06:12:16PM +, Wiles, Keith wrote:
> >>
> >>
> >>
ke.
This fixes the following command:
SYSDIR=/usr/src/sys ./devtools/test-build.sh \
-j4 x86_64-native-freebsd-gcc
Signed-off-by: Olivier Matz
---
v3:
- fix examples installation path, pointed-out by Flavia
v2:
- remove sed_ri() function and use 'sed -ri=""' as suggested by Bru
Hi,
On Tue, Jul 09, 2019 at 12:05:59PM +0100, Musatescu, Flavia wrote:
>
> On 05/07/2019 14:58, Olivier Matz wrote:
> > - As "readlink -e" and "readlink -m" do not exist on freebsd,
> >use "readlink -f", it should not have any impact in these
On Mon, Jul 08, 2019 at 06:35:25PM +0200, Thomas Monjalon wrote:
> 05/07/2019 15:58, Olivier Matz:
> > - As "readlink -e" and "readlink -m" do not exist on freebsd,
> > use "readlink -f", it should not have any impact in these cases.
> > - &qu
On Thu, Jul 11, 2019 at 08:04:00AM +, Wang, Haiyue wrote:
> > -Original Message-
> > From: Olivier Matz [mailto:olivier.m...@6wind.com]
> > Sent: Thursday, July 11, 2019 15:26
> > To: Wang, Haiyue
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [R
Hi Keith,
On Wed, Jul 10, 2019 at 06:12:16PM +, Wiles, Keith wrote:
>
>
> > On Jul 10, 2019, at 12:49 PM, Stephen Hemminger
> > wrote:
> >
> > On Wed, 10 Jul 2019 11:29:07 +0200
> > Olivier Matz wrote:
> >
> >> /**
> >&g
On Wed, Jul 10, 2019 at 10:49:17AM -0700, Stephen Hemminger wrote:
> On Wed, 10 Jul 2019 11:29:07 +0200
> Olivier Matz wrote:
>
> > /**
> > * Indicate that the metadata field in the mbuf is in use.
> > @@ -738,6 +741,8 @@ struct rte_mbuf {
> > */
> &
Hi,
On Wed, Jul 10, 2019 at 05:14:33PM +, Wang, Haiyue wrote:
> Hi,
>
> Sounds cool, just have some questions inline.
>
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz
> > Sent: Wednesday, July 10, 2
On Wed, Jul 10, 2019 at 10:55:34AM +0100, Bruce Richardson wrote:
> On Wed, Jul 10, 2019 at 11:31:56AM +0200, Olivier Matz wrote:
> > Hi Yongseok,
> >
> > On Thu, Jul 04, 2019 at 04:21:22PM -0700, Yongseok Koh wrote:
> > > Currently, metadata can be set on egress pa
Hi Yongseok,
On Thu, Jul 04, 2019 at 04:21:22PM -0700, Yongseok Koh wrote:
> Currently, metadata can be set on egress path via mbuf tx_meatadata field
> with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_RX_META matches metadata.
>
> This patch extends the usability.
>
> 1) RTE_FLOW_ACTION_TYPE_SE
sts to enable this feature. As
the space in mbuf is limited, the space should only be reserved if it
is going to be used (i.e when the application explicitly asks for it).
The registration can be done at any moment, but it is not possible
to unregister fields or flags for now.
Signed-off-by: Oliv
hi,
On Fri, Jul 05, 2019 at 03:40:20PM +, Harman Kalra wrote:
> A secondary process cannot access HW mempool already
> initiazed by primary, and neither it can setup its own
> HW mempool due to its own restrictions.
>
> Since dpdk-pdump creates mempool for managing its local
> mbufs, SW mempo
hould be
> updated. Otherwise l2_len should be updated.
>
> Fixes: c974021a5949 ("ether: add soft vlan encap/decap")
> Cc: step...@networkplumber.org
> Cc: sta...@dpdk.org
>
> Signed-off-by: Dilshod Urazov
> Signed-off-by: Andrew Rybchenko
Acked-by: Olivier Matz
pt either bytes XX:XX:XX:XX:XX:XX
> or words :: and we need to keep compatiablity.
>
> Signed-off-by: Stephen Hemminger
Acked-by: Olivier Matz
Thanks!
BTW, I noticed that it also fixes a more serious bug: the previous
commandline parser was using a static buffer, making it thread-unsafe.
igned-off-by: Stephen Hemminger
> Reviewed-by: Andrew Rybchenko
Acked-by: Olivier Matz
On Tue, Jul 02, 2019 at 03:12:40PM -0700, Stephen Hemminger wrote:
> From: Bruce Richardson
>
> When including the rte_ether.h header in applications with warnings
> enabled, a warning was given because of the assumption of 2-byte alignment
> of ethernet addresses when processing them.
>
> .../i
just a nit in the title: net/ether instead of net/rte_ether for
consistency with other patches
Acked-by: Olivier Matz
Thanks
Hi,
On Tue, Jul 02, 2019 at 03:12:37PM -0700, Stephen Hemminger wrote:
> Make a function that can be used in place of eth_aton_r
> to convert a string to rte_ether_addr. This function
> allows both byte (xx:xx:xx:xx:xx:xx) and word (::)
> format and has the same lack of error handling
ke.
This fixes the following command:
SYSDIR=/usr/src/sys ./devtools/test-build.sh \
-j4 x86_64-native-freebsd-gcc
Signed-off-by: Olivier Matz
---
v2:
- remove sed_ri() function and use 'sed -ri=""' as suggested by Bruce
devtools/check-dup-includes.sh | 2 +-
devtools/checkp
Hi,
On Thu, Jul 04, 2019 at 06:29:25PM +0200, Thomas Monjalon wrote:
> 15/03/2019 16:27, Harman Kalra:
> > Since pdump uses SW rings to manage packets hence
> > pdump should use SW ring mempool for managing its
> > own copy of packets.
>
> I'm not sure to understand the reasoning.
> Reshma, Olivi
On Mon, Jul 01, 2019 at 04:00:44PM +0200, Olivier Matz wrote:
> On Mon, Jul 01, 2019 at 03:38:05PM +0200, Morten Brørup wrote:
> > IPv6 header TC field is 8 bits, not 4.
> >
> > Signed-off-by: Morten Brørup
>
> Acked-by: Olivier Matz
>
> Thanks
CC: sta...@dpdk.org
On Mon, Jul 01, 2019 at 03:59:04PM +0200, Morten Brørup wrote:
> Added definitions of DSCP and ECN masks.
>
> Signed-off-by: Morten Brørup
Acked-by: Olivier Matz
Thanks!
On Tue, Jul 02, 2019 at 09:53:14AM +0200, Olivier Matz wrote:
> Hi,
>
> On Mon, Jun 24, 2019 at 01:44:31PM -0700, Stephen Hemminger wrote:
> > Using bit operations like or and xor is faster than a loop
> > on all architectures. Really just explicit unrolling.
> >
Hi,
On Mon, Jun 24, 2019 at 03:39:57PM +0200, Marcin Smoczynski wrote:
> Introduce new function for IPv6 header extension parsing able to
> determine extension length and next protocol number.
>
> This function is helpful when implementing IPv6 header traversing.
>
> Signed-off-by: Marcin Smoczy
Hi Stephen,
On Mon, Jun 24, 2019 at 01:44:28PM -0700, Stephen Hemminger wrote:
> Formatting Ethernet address and getting a random value are
> not in critical path so they should not be inlined.
>
> Signed-off-by: Stephen Hemminger
> Acked-by: Rami Rosen
> Reviewed-by: Andrew Rybchenko
> ---
>
Hi,
On Mon, Jun 24, 2019 at 01:44:31PM -0700, Stephen Hemminger wrote:
> Using bit operations like or and xor is faster than a loop
> on all architectures. Really just explicit unrolling.
>
> Similar cast to uint16 unaligned is already done in
> other functions here.
>
> Signed-off-by: Stephen H
Hi,
On Mon, Jul 01, 2019 at 02:21:41PM +, Wang, Xiao W wrote:
> Hi,
>
> > -Original Message-
> > From: Olivier Matz [mailto:olivier.m...@6wind.com]
> > Sent: Monday, July 1, 2019 9:11 PM
> > To: Andrew Rybchenko
> > Cc: Wang, Xiao W ; dev@dpdk.
Hi Bruce,
On Mon, Jul 01, 2019 at 02:38:43PM +0100, Bruce Richardson wrote:
> On Mon, Jul 01, 2019 at 03:11:12PM +0200, Olivier Matz wrote:
> > Hi Bruce,
> >
> > On Thu, May 16, 2019 at 04:54:57PM +0100, Bruce Richardson wrote:
> > > When including the rte_ether
On Mon, Jul 01, 2019 at 03:38:05PM +0200, Morten Brørup wrote:
> IPv6 header TC field is 8 bits, not 4.
>
> Signed-off-by: Morten Brørup
Acked-by: Olivier Matz
Thanks
On Mon, Jul 01, 2019 at 01:01:23PM +0100, Fan Zhang wrote:
> Add support for RFC 4301(5.1.2) to update of
> Type of service field and Traffic class field
> bits inside ipv4/ipv6 packets for outbound cases
> and inbound cases which deals with the update of
> the DSCP/ENC bits inside each of the fiel
Hi Bruce,
On Thu, May 16, 2019 at 04:54:57PM +0100, Bruce Richardson wrote:
> When including the rte_ether.h header in applications with warnings
> enabled, a warning was given because of the assumption of 2-byte alignment
> of ethernet addresses when processing them.
>
> .../include/rte_ether.h:
N flags, so it was renamed to reflect
> that it applies to N-tuple filtering only.
>
> Updated other files affected by the renaming accordingly.
>
> Signed-off-by: Morten Brørup
Acked-by: Olivier Matz
chenko
> Acked-by: Konstantin Ananyev
Acked-by: Olivier Matz
Hi,
On Wed, May 15, 2019 at 10:41:07PM -0700, Mesut Ali Ergin wrote:
> When arguments delimited with RTE_KVARGS_PAIRS_DELIM happen to have
> spaces before and after the delimiter, the rte_kvargs_process() can not
> match them to the intended key. For example, the first argument below
> triggers th
Hi,
On Tue, May 21, 2019 at 12:34:55PM +0300, Andrew Rybchenko wrote:
> On 5/21/19 12:03 PM, Xiao Wang wrote:
> > Use rte_memcpy to improve the pointer array copy. This optimization method
> > has already been applied to __mempool_generic_put() [1], this patch applies
> > it to __mempool_generic_g
Hi Morten,
On Fri, Jun 21, 2019 at 04:05:38PM +0200, Morten Brørup wrote:
> IPv4 header TOS field is also used as DSCP and ECN fields.
>
> Signed-off-by: Morten Brørup
> ---
> lib/librte_net/rte_ip.h | 10 --
> 1 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/lib/lib
Hi Lavanya,
Please find some comments inline.
On Mon, Apr 15, 2019 at 01:40:15PM +0100, Lavanya Govindarajan wrote:
> added new unit test cases for
> rte_validate_tx_offload,
> rte_pktmbuf_alloc_bulk,
> rte_pktmbuf_read,
> rte_pktmbuf_ext_shinfo_init_helper,
> rte_pktmbuf_attach_extbuf,
> rte_mbu
On Wed, May 29, 2019 at 09:59:11AM +0200, David Marchand wrote:
> On Fri, May 24, 2019 at 1:38 PM Ferruh Yigit wrote:
>
> > On 5/21/2019 5:13 PM, Olivier Matz wrote:
> > > The rte_net headers conflict with the libc headers, because
> > > some definitions are
"s/\<$old\>/$new/g"
>
> Signed-off-by: David Marchand
Reviewed-by: Olivier Matz
/g"
>
> Signed-off-by: David Marchand
Reviewed-by: Olivier Matz
"s/\<$old\>/$new/g"
>
> Signed-off-by: David Marchand
Reviewed-by: Olivier Matz
: add rte prefix to IP defines")
>
> Signed-off-by: David Marchand
Reviewed-by: Olivier Matz
On Wed, May 29, 2019 at 01:29:14PM +0200, David Marchand wrote:
> No need for this macro here, take it from librte_net.
>
> Fixes: 24ac604ef746 ("net: add rte prefix to IP defines")
>
> Signed-off-by: David Marchand
Reviewed-by: Olivier Matz
o/dpdk.org/devtools/checkpatches.sh
Signed-off-by: Olivier Matz
---
devtools/checkpatches.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 6a01b39c8..bd0a93178 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@
ke.
This fixes the following command:
SYSDIR=/usr/src/sys ./devtools/test-build.sh \
-j4 x86_64-native-freebsd-gcc
Signed-off-by: Olivier Matz
---
devtools/check-dup-includes.sh | 2 +-
devtools/checkpatches.sh | 8 ++--
devtools/get-maintainer.sh | 2 +-
devtools/load-d
Add 'rte_' prefix to structures:
- rename struct udp_hdr as struct rte_udp_hdr.
Signed-off-by: Olivier Matz
---
app/test-pmd/csumonly.c| 27 ++-
app/test-pmd/flowgen.c | 4 ++--
app/test-pmd/txonly.c | 8 +++
Hi Ferruh,
On Mon, May 20, 2019 at 06:11:35PM +0100, Ferruh Yigit wrote:
> On 4/10/2019 9:32 AM, Olivier Matz wrote:
> > This RFC targets 19.08.
> >
> > The rte_net headers conflict with the libc headers, because
> > some definitions are duplicated, sometimes with few
Signed-off-by: Olivier Matz
---
doc/guides/rel_notes/deprecation.rst | 4
doc/guides/rel_notes/release_19_08.rst | 3 +++
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/doc/guides/rel_notes/deprecation.rst
b/doc/guides/rel_notes/deprecation.rst
index 098d24381..7e2dcb769
Add 'rte_' prefix to structures:
- rename struct sctp_hdr as struct rte_sctp_hdr.
Signed-off-by: Olivier Matz
---
app/test-pmd/csumonly.c | 5 +++--
app/test/packet_burst_generator.c | 6 +++---
app/test/packet_burst_generator.h | 2 +-
app/test/test_flow_classify.
Add 'rte_' prefix to structures:
- rename struct tcp_hdr as struct rte_tcp_hdr.
Signed-off-by: Olivier Matz
---
app/test-pmd/csumonly.c| 14 --
app/test/packet_burst_generator.c | 10 +-
app/test/packet_burst_generator.h
DR_FL_MASK.
- rename IPV6_HDR_TC_MASK as RTE_IPV6_HDR_TC_MASK.
Signed-off-by: Olivier Matz
---
app/test-acl/main.c| 2 +-
app/test-pmd/cmdline_flow.c| 4 +-
app/test-pmd/flowgen.c | 4 +-
app/test-pmd
Add 'RTE_' prefix to defines:
- rename IP_ICMP_ECHO_REPLY as RTE_IP_ICMP_ECHO_REPLY.
- rename IP_ICMP_ECHO_REQUEST as RTE_IP_ICMP_ECHO_REQUEST.
Signed-off-by: Olivier Matz
---
app/test-pmd/icmpecho.c | 10 +-
lib/librte_net/rte_icmp.h | 4 ++--
2 files changed, 7 insert
Add 'rte_' prefix to structures:
- rename struct gre_hdr as struct rte_gre_hdr.
Signed-off-by: Olivier Matz
---
drivers/net/mlx5/mlx5_flow_dv.c | 4 ++--
lib/librte_net/rte_gre.h| 2 +-
lib/librte_net/rte_net.c| 4 ++--
3 files changed, 5 insertions(+), 5 deletion
Add 'rte_' prefix to structures:
- rename struct esp_hdr as struct rte_esp_hdr.
Signed-off-by: Olivier Matz
---
app/test/test_ipsec.c| 4 ++--
examples/ipsec-secgw/esp.c | 47 +++-
examples/ipsec-secgw/sa.c| 6 +++---
lib/lib
Add 'rte_' prefix to structures:
- rename struct icmp_hdr as struct rte_icmp_hdr.
Signed-off-by: Olivier Matz
---
app/test-pmd/icmpecho.c | 4 ++--
lib/librte_ethdev/rte_flow.h | 2 +-
lib/librte_net/rte_icmp.h| 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff -
REQUEST as RTE_ARP_OP_INVREQUEST.
- rename ARP_OP_INVREPLY as RTE_ARP_OP_INVREPLY.
Signed-off-by: Olivier Matz
---
app/test-pmd/icmpecho.c| 18 +-
app/test/packet_burst_generator.c | 2 +-
app/test/test_link_bonding.c | 18 +-
d
* tested compilation on x86_64-linux and x86_64-freebsd.
rfc-v2:
* rebase on top of v19.05-rc1
[1] http://mails.dpdk.org/archives/dev/2018-January/087384.html
[2] http://mails.dpdk.org/archives/dev/2019-February/125033.html
Olivier Matz (15):
net: add rte prefix to arp structures
net: a
Also rename arp_hrd, arp_pro, arp_hln, arp_pln and arp_op fields
to avoid conflict with the #defines in gnu libc.
Signed-off-by: Olivier Matz
---
app/test-pmd/icmpecho.c| 24 ++---
app/test/packet_burst_generator.c | 12 +--
app/test
On Thu, May 16, 2019 at 03:28:56PM +0800, Xiaolong Ye wrote:
> As memzone.h is introduced by commit 38c9817ee1d8 ("mempool: adjust name
> size in related data types"), forward declaration for rte_memzone is no
> longer needed.
>
> Signed-off-by: Xiaolong Ye
Acked-by: Olivier Matz
Thanks
e tricky part is returning the buffer to the application. If
> > you create a copy and transmit fails, you need to free that buffer or
> > return it to the application for it to free. If you free the buffer when
> > making a buffer, you certainly can't return it to the application for
> > it to be freed a second time.
> >
> Right. For transmit though, in most cases the only reason for failure is
> lack of space in a transmit ring, so most NIC drivers can be sure of
> success before cloning.
>
> Overall, it seems the consensus is that for real-world cases it's better to
> have this patch than not, so I'm ok for it to go into DPDK.
Agree.
Acked-by: Olivier Matz
Hi Gage,
On Thu, May 09, 2019 at 10:19:55PM +, Eads, Gage wrote:
> Hi all,
>
> I ran into a problem with a multi-process application, in which two processes
> assigned the same mempool handler ops index to *different* handlers. This
> happened because the two processes supplied the -d EAL a
On Mon, Apr 22, 2019 at 09:03:27AM -0700, Stephen Hemminger wrote:
> On Wed, 10 Apr 2019 10:32:05 +0200
> Olivier Matz wrote:
>
> > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
> > b/drivers/net/bonding/rte_eth_bond_pmd.c
> > index f30422a6d..9c5425ef5 1
On Mon, Apr 22, 2019 at 09:05:54AM -0700, Stephen Hemminger wrote:
> On Wed, 10 Apr 2019 10:32:15 +0200
> Olivier Matz wrote:
>
> > diff --git a/app/test-acl/main.c b/app/test-acl/main.c
> > index b80179417..eb6294396 100644
> > --- a/app/test-acl/main.c
&g
Hi Stephen,
On Mon, Apr 22, 2019 at 09:00:45AM -0700, Stephen Hemminger wrote:
> On Wed, 10 Apr 2019 10:32:05 +0200
> Olivier Matz wrote:
>
> > Add 'rte_' prefix to structures:
> > - rename struct arp_hdr as struct rte_arp_hdr.
> > - rename struct arp_ipv4
> +#define TCP_URG_FLAG 0x20 /**< Urgent Pointer field significant */
> +#define TCP_ACK_FLAG 0x10 /**< Acknowledgment field significant */
> +#define TCP_PSH_FLAG 0x08 /**< Push Function */
> +#define TCP_RST_FLAG 0x04 /**< Reset the connection */
> +#define TCP_SYN_FLAG 0x02 /**< Synchronize sequence numbers */
> +#define TCP_FIN_FLAG 0x01 /**< No more data from sender */
> +
> #ifdef __cplusplus
> }
> #endif
Moving these flags in rte_tcp.h makes sense.
But I think they will need to be renamed with a RTE_ prefix inside this
patchset: https://patches.dpdk.org/patch/52556/
So we need to take care to the dependency between these 2 patchsets.
Acked-by: Olivier Matz
On Fri, May 10, 2019 at 04:28:16PM +, Eads, Gage wrote:
> > -Original Message-
> > From: Ola Liljedahl [mailto:ola.liljed...@arm.com]
> > Sent: Friday, May 10, 2019 10:19 AM
> > To: step...@networkplumber.org; Eads, Gage
> > Cc: arybche...@solarflare.com; nd ; Ananyev, Konstantin
> > ;
Hi,
Here are the meeting notes of the DPDK technical board meeting held on
2019-04-10.
Attendees:
- Bruce Richardson
- Ferruh Yigit
- Hemant Agrawal
- Jerin Jacob
- Konstantin Ananyev
- Olivier Matz
- Stephen Hemminger
- Thomas Monjalon
1) DPDK development process and tools survey
As discussed at techboard, the network definitions, structures
and functions will be prefixed by 'rte_'.
Link: http://mails.dpdk.org/archives/dev/2019-February/125033.html
Link: https://mails.dpdk.org/archives/dev/2019-April/129752.html
Signed-off-by: Olivier Matz
---
doc/guides
Add 'rte_' prefix to structures:
- rename struct sctp_hdr as struct rte_sctp_hdr.
Signed-off-by: Olivier Matz
---
app/test-pmd/csumonly.c | 4 ++--
app/test/packet_burst_generator.c | 6 +++---
app/test/packet_burst_generator.h | 2 +-
app/test/test_flow_classify.
Add 'rte_' prefix to structures:
- rename struct udp_hdr as struct rte_udp_hdr.
Signed-off-by: Olivier Matz
---
app/test-pmd/csumonly.c| 24
app/test-pmd/flowgen.c | 4 ++--
app/test-pmd/txonly.c | 8
Add 'rte_' prefix to structures:
- rename struct tcp_hdr as struct rte_tcp_hdr.
Signed-off-by: Olivier Matz
---
app/test-pmd/csumonly.c| 12 ++--
app/test/packet_burst_generator.c | 10 +-
app/test/packet_burst_generator.h
DR_FL_MASK.
- rename IPV6_HDR_TC_MASK as RTE_IPV6_HDR_TC_MASK.
Signed-off-by: Olivier Matz
---
app/test-acl/main.c| 2 +-
app/test-pmd/cmdline_flow.c| 4 +-
app/test-pmd/flowgen.c | 4 +-
app/test-pmd
Add 'RTE_' prefix to defines:
- rename IP_ICMP_ECHO_REPLY as RTE_IP_ICMP_ECHO_REPLY.
- rename IP_ICMP_ECHO_REQUEST as RTE_IP_ICMP_ECHO_REQUEST.
Signed-off-by: Olivier Matz
---
app/test-pmd/icmpecho.c | 10 +-
lib/librte_net/rte_icmp.h | 4 ++--
2 files changed, 7 insert
Add 'rte_' prefix to structures:
- rename struct icmp_hdr as struct rte_icmp_hdr.
Signed-off-by: Olivier Matz
---
app/test-pmd/icmpecho.c | 4 ++--
lib/librte_ethdev/rte_flow.h | 2 +-
lib/librte_net/rte_icmp.h| 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff -
Add 'rte_' prefix to structures:
- rename struct gre_hdr as struct rte_gre_hdr.
Signed-off-by: Olivier Matz
---
drivers/net/mlx5/mlx5_flow_dv.c | 4 ++--
lib/librte_net/rte_gre.h| 2 +-
lib/librte_net/rte_net.c| 4 ++--
3 files changed, 5 insertions(+), 5 deletion
Add 'rte_' prefix to structures:
- rename struct arp_hdr as struct rte_arp_hdr.
- rename struct arp_ipv4 as struct rte_arp_ipv4.
Also rename arp_hrd, arp_pro, arp_hln, arp_pln and arp_op fields
to avoid conflict with the #defines in gnu libc.
Signed-off-by: Olivier Matz
---
ap
Add 'rte_' prefix to structures:
- rename struct esp_hdr as struct rte_esp_hdr.
Signed-off-by: Olivier Matz
---
app/test/test_ipsec.c| 4 ++--
examples/ipsec-secgw/esp.c | 42 +-
examples/ipsec-secgw/sa.c| 6 +++---
lib/lib
REQUEST as RTE_ARP_OP_INVREQUEST.
- rename ARP_OP_INVREPLY as RTE_ARP_OP_INVREPLY.
Signed-off-by: Olivier Matz
---
app/test-pmd/icmpecho.c| 18 +-
app/test/packet_burst_generator.c | 2 +-
app/test/test_link_bonding.c | 18 +-
d
API of many functions, but not the ABI.
This was discussed in [1], and recently requested by the techboard [2].
v2:
* rebase on top of v19.05-rc1
[1] http://mails.dpdk.org/archives/dev/2018-January/087384.html
[2] http://mails.dpdk.org/archives/dev/2019-February/125033.html
Olivier Matz (14
gt;
> ---
> lib/librte_mbuf/rte_mbuf.h | 10 +++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
Acked-by: Olivier Matz
Thanks
s,
> and new function to generate raw tx_offload value.
> Add new test-case into UT for introduced function.
>
> Signed-off-by: Konstantin Ananyev
> Acked-by: Akhil Goyal
Acked-by: Olivier Matz
Thanks
Hi,
On Tue, Apr 02, 2019 at 10:58:52AM +0300, Andrew Rybchenko wrote:
> Hi,
>
> added more people in CC.
>
> On 4/1/19 6:29 PM, N. Benes wrote:
> > Hi,
> >
> > I wrote to the users list a bit more a week ago concerning the IPv4
> > Header Checksum computation and received no comments on it yet:
Hi Konstantin,
On Mon, Apr 01, 2019 at 01:56:48PM +0100, Konstantin Ananyev wrote:
> Operations to set/update bit-fields often cause compilers
> to generate suboptimal code.
> To help avoid such situation for tx_offload fields:
> introduce new enum for tx_offload bit-fields lengths and offsets,
>
Hi Xiaolong,
On Tue, Mar 26, 2019 at 08:20:28PM +0800, Xiaolong Ye wrote:
> Now, af_xdp registered memory buffer is managed by rte_mempool. mbuf
> allocated from rte_mempool can be converted to xdp_desc's address and
> vice versa.
>
> Signed-off-by: Xiaolong Ye
> ---
> drivers/net/af_xdp/rte_et
Hi,
On Fri, Mar 29, 2019 at 01:37:17PM +0300, Andrew Rybchenko wrote:
> On 3/27/19 12:00 PM, Xiaolong Ye wrote:
> > Allow create a mempool with page size aligned base address.
> >
> > Signed-off-by: Qi Zhang
> > Signed-off-by: Xiaolong Ye
> > ---
> > lib/librte_mempool/rte_mempool.c | 3 +++
>
ere it comes from except
> rte_net_intel_cksum_prepare() functions which relies on it.
>
> It could be NIC vendor specific driver or hardware limitation, but,
> if so, it should be documented and checked in corresponding Tx
> prepare callbacks.
>
> Signed-off-by: Andrew R
Hi,
On Fri, Mar 15, 2019 at 11:31:25AM +0800, Gavin Hu wrote:
> Currently, the flush is done by dequeuing the ring in a while loop. It is
> much simpler to flush the queue by resetting the head and tail indices.
>
> Fixes: af75078fece3 ("first public release")
> Cc: sta...@dpdk.org
>
> Signed-of
Hi Andrew,
On Thu, Mar 28, 2019 at 08:04:31PM +0300, Andrew Rybchenko wrote:
> Ping? (I have a number of net/sfc patches which heavily depend on this
> one and must not be applied without this one)
>
> Andrew.
>
> On 2/19/19 9:30 AM, Andrew Rybchenko wrote:
> > rte_validate_tx_offload() is used
Hi Konstantin,
On Fri, Mar 29, 2019 at 10:27:18AM +, Konstantin Ananyev wrote:
> Operations to set/update bit-fields often cause compilers
> to generate suboptimal code.
> To help avoid such situation for tx_offload fields:
> introduce new enum for tx_offload bit-fields lengths and offsets,
>
701 - 800 of 3408 matches
Mail list logo
