Fix the following compilation error:
examples/bond/main.c:717:1: error: control reaches end of
non-void function [-Werror,-Wreturn-type]
The prompt() function does not return anything, so fix its prototype
to be void.
Signed-off-by: Olivier Matz
---
examples/bond/main.c | 2 +-
1 file
This series contains compilation fixes.
Olivier Matz (4):
examples/bond: fix compilation with clang
examples/netmap: fix compilation for x86_x32-native-linuxapp-gcc
pmds: fix 32 bits compilation with debug enabled
examples/mk: add dependencies for timer and vm_power_manager
examples
> used outside of the rte.app.mk file.
>
> Signed-off-by: Keith Wiles
Series
Acked-by: Olivier Matz
Thanks,
Olivier
Hi,
On 05/13/2015 06:35 PM, Keith Wiles wrote:
> Simplify the ifdefs in rte.app.mk to make the code more
> readable and maintainable by introducing a internal
> _LDLIBS-y variable to build up the LDLIBS variable.
>
> The new internal variable _LDLIBS-y should not be
> used outside of the
On 05/13/2015 04:04 PM, Wiles, Keith wrote:
>
>
> On 5/13/15, 8:56 AM, "Olivier MATZ" wrote:
>
>> Hi Keith,
>>
>> On 05/13/2015 03:17 PM, Wiles, Keith wrote:
>>>>>
>>>>> endif # ifeq ($(NO_AUTOLIBS),)
>>>
Hi Keith,
On 05/13/2015 03:17 PM, Wiles, Keith wrote:
>>>
>>>endif # ifeq ($(NO_AUTOLIBS),)
>>>
>>> -LDLIBS += $(CPU_LDLIBS)
>>> +LDLIBS += $(_LDLIBS-y) $(EXTRA_LDLIBS)
>>>
>>
>> As discussed in the previous mail, all things that are about
>> EXTRA_LDLIBS should be moved in the second patch.
1 +
> lib/librte_cmdline/cmdline_vt100.h | 2 ++
> lib/librte_cmdline/rte_cmdline_version.map | 8 +++
> 7 files changed, 73 insertions(+)
>
Acked-by: Olivier Matz
Thanks,
Olivier
On 05/13/2015 12:14 PM, Gonzalez Monroy, Sergio wrote:
> On 12/05/2015 15:48, Olivier MATZ wrote:
>> Hi Sergio,
>>
>> On 05/06/2015 06:10 PM, Gonzalez Monroy, Sergio wrote:
>>> Hi,
>>>
>>> I was wondering about the use case of rte_memzone_reserve_
Hi,
On 05/12/2015 09:11 PM, Keith Wiles wrote:
> Simplify the ifdefs in rte.app.mk to make the code more
> readable and maintainable by moving LDLIBS variable to
> use the same style as LDLIBS-y being used in the rest
> of the code. The new internal variable _LDLIBS should
> not be used outside
Hi Sergio,
On 05/08/2015 06:37 PM, Sergio Gonzalez Monroy wrote:
> Please NOTE that this series is meant to illustrate an idea/approach and start
> discussion on the topic.
>
> Current implemetation allows reserving/creating memzones but not the opposite
> (unreserve/delete). This affects
Hi Keith,
On 05/12/2015 01:14 AM, Keith Wiles wrote:
> Trying to simplify the ifdefs in rte.app.mk to make the code
> more readable and maintainable by moving LDLIBS variable to use
> the same style as LDLIBS-y being used in the rest of the code.
>
> Added a new variable
Hi Sergio,
On 05/06/2015 06:10 PM, Gonzalez Monroy, Sergio wrote:
> Hi,
>
> I was wondering about the use case of rte_memzone_reserve_ APIs with
> len=0.
>
> From the docs (http://dpdk.org/doc/api/rte__memzone_8h.html):
> len The size of the memory to be reserved. If it is 0, the
>
Hi Pawel,
On 05/12/2015 01:10 PM, Pawel Wodkowski wrote:
> This patch adds the ability to process console input in the same thread
> as packet processing by using poll() function.
>
> Signed-off-by: Pawel Wodkowski
> [...]
> --- a/lib/librte_cmdline/cmdline.h
> +++ b/lib/librte_cmdline/cmdline.h
dk.org] On Behalf Of Zoltan Kiss
> Sent: Friday, April 24, 2015 6:39 PM
> To: Ananyev, Konstantin; Olivier Matz; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 00/13] mbuf: enhancements of mbuf clones
>
> Hi,
>
> On 22/04/15 12:59, Ananyev, Konstantin wrote:
>>
Hi,
On 05/05/2015 11:21 AM, Gonzalez Monroy, Sergio wrote:
> On 04/05/2015 08:55, Olivier MATZ wrote:
>> Hi Sergio,
>>
>> On 04/15/2015 11:30 AM, Sergio Gonzalez Monroy wrote:
>>> This patch introduces a new LDLIBS variable to be set per library.
>>> I
Hi Simon,
On 05/05/2015 11:00 AM, Olivier Matz wrote:
> The script relpath.sh return the relative path of the first directory
> from the second directory. It is used to generate relative symlinks,
> which can be useful if the build directory is embedded in the dpdk
> directory: the wh
for an installation.
In case the build directory is a symlink, the script was not generating
the proper relative path. Fix this by calling "readlink -f" on the
arguments.
Signed-off-by: Olivier Matz
---
scripts/relpath.sh | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
Hi Keith,
On 05/04/2015 06:50 PM, Wiles, Keith wrote:
>
>
> Sent from my iPhone
>
>> On May 4, 2015, at 8:27 AM, Olivier MATZ wrote:
>>
>>
>>
>>> On 05/04/2015 04:36 PM, Wiles, Keith wrote:
>>>
>>>
>>>> On 5/4/15, 2:18 AM
On 05/04/2015 04:49 PM, Wiles, Keith wrote:
>
>
> On 5/4/15, 1:37 AM, "Olivier MATZ" wrote:
>
>> Hello,
>>
>> On 04/26/2015 06:55 PM, Wiles, Keith wrote:
>>>
>>>
>>> On 4/26/15, 11:53 AM, "Wiles, Keith" wrote:
On 05/04/2015 05:09 PM, Wiles, Keith wrote:
>
>
> Sent from my iPhone
>
>> On May 4, 2015, at 2:19 AM, Olivier MATZ wrote:
>>
>> Hi Keith,
>>
>>> On 05/01/2015 04:22 PM, Keith Wiles wrote:
>>> Trying to simplify the ifdefs in rte.app.
On 05/04/2015 04:36 PM, Wiles, Keith wrote:
>
>
> On 5/4/15, 2:18 AM, "Olivier MATZ" wrote:
>
>> Hi Keith,
>>
>> On 05/01/2015 04:22 PM, Keith Wiles wrote:
>>> Trying to simplify the ifdefs in rte.app.mk to make the code
>>> more
Hi Simon,
On 05/04/2015 02:42 PM, Simon K?gstr?m wrote:
> Hi!
>
> I'm trying to do a out-of-tree build of DPDK 2.0.0 (with make -C and
> O=), but failing with errors such as
>
> In file included from
> [...]/lib/librte_eal/common/include/rte_eal_memconfig.h:40:0,
> [...]
>
Hi Cyril,
On 04/29/2015 06:15 PM, Cyril Chemparathy wrote:
> This series contains a few improvements that allow the DPDK code base to build
> properly on machines that enforce strict pointer cast alignment constraints.
>
> When dealing with packet data which could be arbitrarily aligned, we get
Hi Keith,
On 05/01/2015 04:22 PM, Keith Wiles wrote:
> Trying to simplify the ifdefs in rte.app.mk to make the code
> more readable and maintainable by moving LDLIBS variable to use
> the same style as LDLIBS-y being used in the rest of the code.
>
> Added a new variable called EXTRA_LDLIBS to
Hello,
On 04/26/2015 06:55 PM, Wiles, Keith wrote:
>
>
> On 4/26/15, 11:53 AM, "Wiles, Keith" wrote:
>
>> Hi All,
>>
>> I noticed in my builds with foo.S file I would get a warning from the
>> compiler the foo_s.o.tmp linker file will not be used as the code is not
>> linked. A strange error
ader file, also triggers inclusion of the mempool headers
> which causes the inclusion of the ring headers amongst others.
>
> Therefore, I propose changing the header files for our libraries to just use
> the forward declaration instead of the full header inclusion where possible.
Series
Acked-by: Olivier Matz
Hi Sergio,
On 04/15/2015 11:30 AM, Sergio Gonzalez Monroy wrote:
> This patch introduces a new LDLIBS variable to be set per library.
> Its purpose is to especify the library's dependent libraries to
> be explicitly linked against.
>
> Given the circular dependencies between eal, malloc, mempool
Hi,
On 04/30/2015 04:31 PM, Wiles, Keith wrote:
>
>
> On 4/30/15, 8:38 AM, "Olivier MATZ" wrote:
>
>> Hi Keith,
>>
>> On 04/30/2015 03:24 PM, Wiles, Keith wrote:
>>>
>>>
>>> On 4/30/15, 4:45 AM, "Olivier MATZ" wrote:
Hi Keith,
On 04/30/2015 03:24 PM, Wiles, Keith wrote:
>
>
> On 4/30/15, 4:45 AM, "Olivier MATZ" wrote:
>
>> Hi Keith,
>>
>> Thank you for submitting a clean-up. Please see some comments below.
>>
>> On 04/29/2015 05:25 PM, Keith Wiles wr
Hi Keith,
Thank you for submitting a clean-up. Please see some comments below.
On 04/29/2015 05:25 PM, Keith Wiles wrote:
> Trying to simplify the ifdefs in rte.app.mk to make the code
> more readable and maintainable by moving LDLIBS variable to use
> the same style as LDLIBS-y being used in
MAX_LEN).
> To overcome that problem and unify the code, new macro was created
> to represent recommended minimal buffer length for mbuf.
> When appropriate, samples are updated to use that macro.
>
> Signed-off-by: Konstantin Ananyev
Acked-by: Olivier Matz
Thanks
Hi Konstantin,
On 04/29/2015 12:39 PM, Ananyev, Konstantin wrote:
> Hi Olivier,
>
>> -Original Message-----
>> From: Olivier MATZ [mailto:olivier.matz at 6wind.com]
>> Sent: Wednesday, April 29, 2015 10:55 AM
>> To: Ananyev, Konstantin; dev at dpdk.org
>>
that? (maybe
not, as it is driver-specific, and it is just an optimization)
- should we check the other examples to see if the same problem
exists?
If my understanding is correct,
Acked-by: Olivier Matz
Regards,
Olivier
Hi Konstantin,
On 04/21/2015 05:01 PM, Ananyev, Konstantin wrote:
> Hi Olivier,
>
>> -Original Message-----
>> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
>> Sent: Tuesday, April 21, 2015 10:55 AM
>> To: dev at dpdk.org
>> Cc: Ananyev, K
d increase the reference counter of this one.
When detaching the mbuf, we can retrieve this direct mbuf as the pointer
is determined from the buffer address.
Signed-off-by: Olivier Matz
---
lib/librte_mbuf/rte_mbuf.h | 46 ++
1 file changed, 26 insertions(+), 20
the private size in account when attaching and detaching
mbufs.
Signed-off-by: Olivier Matz
Reviewed-by: Zoltan Kiss
---
examples/vhost/main.c | 4 ++--
lib/librte_mbuf/rte_mbuf.c | 2 +-
lib/librte_mbuf/rte_mbuf.h | 59 +++---
3 files changed, 43
When it's possible, use the new helper to create the mbuf pools.
Most of the patch is trivial, except for the following files that
have some specifics (indirect mbufs):
- ip_fragmentation
- ip_pipeline
- ipv4_multicast
- vhost
Signed-off-by: Olivier Matz
---
app/test-pipeline/init.c
Add a new wrapper to rte_mempool_create() to simplify the creation
of a packet mbuf pool.
This wrapper can be used if there is no specific mempool flags, and
no specific mbuf or pool constructor function, which is most of the
use cases.
Signed-off-by: Olivier Matz
---
doc/guides/rel_notes
The rte_pktmbuf_pool_init() and rte_pktmbuf_init() functions now
support to have a non-hardcoded buffer length. We can remove the
specific functions used in testpmd and replace them by the standard
ones.
Signed-off-by: Olivier Matz
---
app/test-pmd/testpmd.c | 74
Allow the user to use the default rte_pktmbuf_init() function even
if the mbuf private size is not 0.
Signed-off-by: Olivier Matz
---
lib/librte_mbuf/rte_mbuf.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf
This code retrieving the pool private area is duplicated in many
places, we can use of function for it.
Signed-off-by: Olivier Matz
---
lib/librte_ether/rte_ethdev.c| 4 +--
lib/librte_mbuf/rte_mbuf.h | 41
lib/librte_pmd_af_packet
The mbuf pool private area must always be populated in a mbuf pool.
The applications or drivers may expect that for a mbuf pool, the mbuf
pool private area (mbuf_data_room_size and mbuf_priv_size) are
properly filled.
Signed-off-by: Olivier Matz
---
examples/ip_fragmentation/main.c | 4
Signed-off-by: Olivier Matz
---
app/test/test_mbuf.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
index 01838c6..b5ae5b7 100644
--- a/app/test/test_mbuf.c
+++ b/app/test/test_mbuf.c
@@ -324,6 +324,7
Check that the data in the cloned mbuf is the same than in the
reference mbuf.
Check that the reference counter is incremented for each segment.
Signed-off-by: Olivier Matz
---
app/test/test_mbuf.c | 37 +
1 file changed, 37 insertions(+)
diff --git a/app
It's better to name the mbuf 'm' instead of 'mc' as it's not a clone.
Signed-off-by: Olivier Matz
---
app/test/test_mbuf.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
index 4774263..2614598 100644
d increase the reference counter of this one.
When detaching the mbuf, we can retrieve this direct mbuf as the pointer
is determined from the buffer address.
Signed-off-by: Olivier Matz
---
lib/librte_mbuf/rte_mbuf.h | 46 ++
1 file changed, 26 insertions(+), 20
the private size in account when attaching and detaching
mbufs.
Signed-off-by: Olivier Matz
Reviewed-by: Zoltan Kiss
---
examples/vhost/main.c | 4 ++--
lib/librte_mbuf/rte_mbuf.c | 2 +-
lib/librte_mbuf/rte_mbuf.h | 59 +++---
3 files changed, 43
When it's possible, use the new helper to create the mbuf pools.
Most of the patch is trivial, except for the following files that
have some specifics (indirect mbufs):
- ip_fragmentation
- ip_pipeline
- ipv4_multicast
- vhost
Signed-off-by: Olivier Matz
---
app/test-pipeline/init.c
Add a new wrapper to rte_mempool_create() to simplify the creation
of a packet mbuf pool.
This wrapper can be used if there is no specific mempool flags, and
no specific mbuf or pool constructor function, which is most of the
use cases.
Signed-off-by: Olivier Matz
---
doc/guides/rel_notes
The rte_pktmbuf_pool_init() and rte_pktmbuf_init() functions now
support to have a non-hardcoded buffer length. We can remove the
specific functions used in testpmd and replace them by the standard
ones.
Signed-off-by: Olivier Matz
---
app/test-pmd/testpmd.c | 74
Allow the user to use the default rte_pktmbuf_init() function even
if the mbuf private size is not 0.
Signed-off-by: Olivier Matz
---
lib/librte_mbuf/rte_mbuf.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf
This code retrieving the pool private area is duplicated in many
places, we can use of function for it.
Signed-off-by: Olivier Matz
---
lib/librte_ether/rte_ethdev.c| 4 +--
lib/librte_mbuf/rte_mbuf.h | 41
lib/librte_pmd_af_packet
The mbuf pool private area must always be populated in a mbuf pool.
The applications or drivers may expect that for a mbuf pool, the mbuf
pool private area (mbuf_data_room_size and mbuf_priv_size) are
properly filled.
Signed-off-by: Olivier Matz
---
examples/ip_fragmentation/main.c | 4
ize is assumed to be 0, and the room size is
mp->elt_size - sizeof(struct rte_mbuf).
- give the rte_pktmbuf_pool_private filled with appropriate
data_room_size and priv_size values.
Signed-off-by: Olivier Matz
---
app/test-pmd/testpmd.c | 1 +
doc/guides/rel_notes/updating_apps.rs
d mbuf cache line
- fix mbuf free in test error case
Olivier Matz (12):
mbuf: fix mbuf data room size calculation rte_pktmbuf_pool_init
examples: always initialize mbuf_pool private area
mbuf: add accessors to get data room size and private size
mbuf: fix rte_pktmbuf_init when mbuf privat
Hi Konstantin,
On 04/08/2015 03:45 PM, Ananyev, Konstantin wrote:
> Hi Olivier,
>
>> -Original Message-----
>> From: Olivier MATZ [mailto:olivier.matz at 6wind.com]
>> Sent: Wednesday, April 08, 2015 10:44 AM
>> To: Ananyev, Konstantin; dev at dpdk.org
&g
Hi Konstantin,
On 04/07/2015 07:17 PM, Ananyev, Konstantin wrote:
>> Just to be sure we're on the same line:
>>
>> - before the patch series
>>
>> - private area was working before that patch series if clones were not
>> used. To use a private are, the user had to provide another
>>
Hi Konstantin,
On 04/07/2015 02:40 PM, Ananyev, Konstantin wrote:
> Hi Olivier,
>
>> -Original Message-----
>> From: Olivier MATZ [mailto:olivier.matz at 6wind.com]
>> Sent: Monday, April 06, 2015 10:50 PM
>> To: Ananyev, Konstantin; dev at dpdk.org
&g
Hi Konstantin,
Thanks for your comments.
On 04/02/2015 07:21 PM, Ananyev, Konstantin wrote:
> Hi Olivier,
>
>> -Original Message-----
>> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
>> Sent: Tuesday, March 31, 2015 8:23 PM
>> To: dev at dpdk.
Hi,
On 04/01/2015 03:48 PM, Ananyev, Konstantin wrote:
>> With this solution, there are 2 options:
>> - no mempool modification, so each application/driver has to add
>> priv_size bytes to the object to get the mbuf pointer. This does not
>> look feasible.
>> - change the
t; +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -64,8 +64,9 @@
> extern "C" {
> #endif
>
> -/* deprecated feature, renamed in RTE_MBUF_REFCNT */
> +/* deprecated options */
> #pragma GCC poison RTE_MBUF_SCATTER_GATHER
> +#pragma GCC poison RTE_MBUF_REFCNT
>
> /
From: Olivier Matz <olivier.m...@6wind.com>
Signed-off-by: Olivier Matz
---
app/test/test_mbuf.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
index 9d8ee4e..e59aedc 100644
--- a/app/test/test_mbuf.c
+++ b/ap
From: Olivier Matz <olivier.m...@6wind.com>
Check that the data in the cloned mbuf is the same than in the
reference mbuf.
Check that the reference counter is incremented for each segment.
Signed-off-by: Olivier Matz
---
app/test/test_mbuf.c | 37 +
From: Olivier Matz <olivier.m...@6wind.com>
It's better to name the mbuf 'm' instead of 'mc' as it's not a clone.
Signed-off-by: Olivier Matz
---
app/test/test_mbuf.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/app/test/test_mbuf.c b/ap
From: Olivier Matz <olivier.m...@6wind.com>
Remove one limitation of rte_pktmbuf_attach(): "mbuf we're attaching to
must be direct".
Now, when we attach to an indirect mbuf:
- copy the all relevant fields (addr, len, offload, ...) as before
- get the pointer to the mbuf that
From: Olivier Matz <olivier.m...@6wind.com>
Add a new private_size field in mbuf structure that should
be initialized at mbuf pool creation. This field contains the
size of the application private data in mbufs.
Introduce new static inline functions rte_mbuf_from_indirect()
and rte_mbuf_to
ach()
- move m->priv_size in second mbuf cache line
- fix mbuf free in test error case
Olivier Matz (5):
mbuf: fix clone support when application uses private mbuf data
mbuf: allow to clone an indirect mbuf
test/mbuf: rename mc variable in m
test/mbuf: enhance mbuf refcnt test
test/mbuf:
Hi Konstantin,
On 03/31/2015 01:17 AM, Ananyev, Konstantin wrote:
With this solution, there are 2 options:
- no mempool modification, so each application/driver has to add
priv_size bytes to the object to get the mbuf pointer. This does not
look feasible.
- change the
Hi Konstantin,
On 03/30/2015 02:34 PM, Ananyev, Konstantin wrote:
> Hi Olivier,
>
>> -Original Message-----
>> From: Olivier MATZ [mailto:olivier.matz at 6wind.com]
>> Sent: Friday, March 27, 2015 3:17 PM
>> To: Ananyev, Konstantin; dev at dpdk.org
>> S
Hi Zoltan,
On 03/27/2015 07:11 PM, Zoltan Kiss wrote:
>> Sorry if it was not clear in my previous messages, but I agree
>> with your description. When attaching a mbuf, only data, not
>> metadata should be shared.
>>
>> In the solution you are suggesting (quoted above), you say we need
>> to set
Hi Konstantin,
On 03/27/2015 03:25 PM, Ananyev, Konstantin wrote:
> Hi Olivier,
>
>> -Original Message-----
>> From: Olivier MATZ [mailto:olivier.matz at 6wind.com]
>> Sent: Friday, March 27, 2015 1:56 PM
>> To: Ananyev, Konstantin; dev at dpdk.org
>> S
Hi Konstantin,
On 03/27/2015 10:07 AM, Olivier MATZ wrote:
>> I think that to support ability to setup priv_size on a mempool basis,
>> and reserve private space between struct rte_mbuf and rte_mbuf. buf_addr,
>> we need to:
>>
>> 1. Store priv_size both inside t
Hi Neil,
On 03/27/2015 01:44 PM, Neil Horman wrote:
> On Fri, Mar 27, 2015 at 10:48:20AM +, Ananyev, Konstantin wrote:
>>
>>
>>> -Original Message-
>>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman
>>> Sent: Friday, March 27, 2015 10:26 AM
>>> To: Wiles, Keith
Hi Konstantin,
Thank you for your comments.
On 03/27/2015 01:24 AM, Ananyev, Konstantin wrote:
> Hi Olivier,
>
>> -Original Message-
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier Matz
>> Sent: Thursday, March 26, 2015 4:00 PM
>
nt, so we need to check that
> + * result also, to make sure the mbuf is freed properly.
> + */
> if (likely (rte_mbuf_refcnt_read(m) == 1) ||
> likely (rte_mbuf_refcnt_update(m, -1) == 0)) {
>
>
Acked-by: Olivier Matz
Thanks!
Signed-off-by: Olivier Matz
---
app/test/test_mbuf.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
index 9d8ee4e..e59aedc 100644
--- a/app/test/test_mbuf.c
+++ b/app/test/test_mbuf.c
@@ -325,6 +325,7
Check that the data in the cloned mbuf is the same than in the
reference mbuf.
Check that the reference counter is incremented for each segment.
Signed-off-by: Olivier Matz
---
app/test/test_mbuf.c | 37 +
1 file changed, 37 insertions(+)
diff --git a/app
It's better to name the mbuf 'm' instead of 'mc' as it's not a clone.
Signed-off-by: Olivier Matz
---
app/test/test_mbuf.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
index 1ff66cb..9a3cf8f 100644
d increase the reference counter of this one.
When detaching the mbuf, we can retrieve this direct mbuf as the pointer
is determined from the buffer address.
Signed-off-by: Olivier Matz
---
lib/librte_mbuf/rte_mbuf.h | 46 ++
1 file changed, 26 insertions(+), 20
the private size in account when attaching and detaching
mbufs.
Signed-off-by: Olivier Matz
---
app/test-pmd/testpmd.c | 1 +
examples/vhost/main.c | 2 +-
lib/librte_mbuf/rte_mbuf.c | 1 +
lib/librte_mbuf/rte_mbuf.h | 44 ++--
4 files changed
- fix and rework rte_pktmbuf_detach()
- move m->priv_size in second mbuf cache line
- fix mbuf free in test error case
Olivier Matz (5):
mbuf: fix clone support when application uses private mbuf data
mbuf: allow to clone an indirect mbuf
test/mbuf: rename mc variable in m
test/m
Hi Bruce,
On 03/26/2015 02:35 PM, Bruce Richardson wrote:
> On Wed, Mar 25, 2015 at 06:00:34PM +0100, Olivier Matz wrote:
>> Add a new private_size field in mbuf structure that should
>> be initialized at mbuf pool creation. This field contains the
>> size of the application
On 03/26/2015 05:00 AM, Shankari Vaidyalingam wrote:
> Hi,
>
>
> Would like to know whether enabling of promiscouous mode in the command
> line is removed in the DPDK version 1.7.1.
> I tried enabling the option by giving -P but it was giving me "Invalid
> argument" error.
Which program?
Have you
Hi,
On 03/26/2015 04:58 AM, Shankari Vaidyalingam wrote:
> Hi Olivier,
>
> Thanks for the response.
> I executed the L2fwd application by injecting packets from an external
> source to the DPDK bound interface.
> I was not able to see the stats getting incremented. I'm doing this
> testing on a
On 03/25/2015 06:00 PM, Olivier Matz wrote:
> Signed-off-by: Olivier Matz
> ---
> app/test/test_mbuf.c | 26 ++
> 1 file changed, 26 insertions(+)
>
> [...]
>
> @@ -394,6 +418,8 @@ fail:
> rte_pktmbuf
Hi Zoltan,
On 03/25/2015 07:57 PM, Zoltan Kiss wrote:
> I have some comments for the first patch:
>
>> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
>> index c3fcb80..050f3ac 100644
>> --- a/examples/vhost/main.c
>> +++ b/examples/vhost/main.c
> I've sent in a separate patch for this
On 03/25/2015 06:22 PM, Neil Horman wrote:
> On Wed, Mar 25, 2015 at 04:42:23PM +0100, Olivier MATZ wrote:
>> On 03/25/2015 04:22 PM, Neil Horman wrote:
>>> On Wed, Mar 25, 2015 at 04:06:10PM +0100, Olivier MATZ wrote:
>>>> Hi,
>>>>
>>>> On 03/
Signed-off-by: Olivier Matz
---
app/test/test_mbuf.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
index 9d8ee4e..68cd4de 100644
--- a/app/test/test_mbuf.c
+++ b/app/test/test_mbuf.c
@@ -325,6 +325,7
Check that the data in the cloned mbuf is the same than in the
reference mbuf.
Check that the reference counter is incremented for each segment.
Signed-off-by: Olivier Matz
---
app/test/test_mbuf.c | 37 +
1 file changed, 37 insertions(+)
diff --git a/app
It's better to name the mbuf 'm' instead of 'mc' as it's not a clone.
Signed-off-by: Olivier Matz
---
app/test/test_mbuf.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
index 1ff66cb..9a3cf8f 100644
d increase the reference counter of this one.
When detaching the mbuf, we can retrieve this direct mbuf as the pointer
is determined from the buffer address.
Signed-off-by: Olivier Matz
---
lib/librte_mbuf/rte_mbuf.h | 46 ++
1 file changed, 26 insertions(+), 20
the private size in account when attaching and detaching
mbufs.
Signed-off-by: Olivier Matz
---
app/test-pmd/testpmd.c | 1 +
examples/vhost/main.c | 6 ++
lib/librte_mbuf/rte_mbuf.c | 1 +
lib/librte_mbuf/rte_mbuf.h | 44 +++-
4 files changed
, it's faster to have it in the mbuf.
The series also removes the limitation that rte_pktmbuf_clone() is
only allowed on direct (non-cloned) mbufs.
Olivier Matz (5):
mbuf: fix clone support when application uses private mbuf data
mbuf: allow to clone an indirect mbuf
test/mbuf: rename mc
On 03/25/2015 04:22 PM, Neil Horman wrote:
> On Wed, Mar 25, 2015 at 04:06:10PM +0100, Olivier MATZ wrote:
>> Hi,
>>
>> On 03/24/2015 06:00 PM, Neil Horman wrote:
>>> On Tue, Mar 24, 2015 at 02:52:59PM +, John McNamara wrote:
>>>> Added a 'make sy
Hi Shankari,
On 03/25/2015 04:14 PM, Shankari Vaidyalingam wrote:
> Hi Bruce,
>
>
> If I want to capture the packets received by the interface bound to IGB
> (DPDK interface) then I'd like to know what would be the interface name
> that must be given.
If you want to capture the packets, you have
Hi,
On 03/24/2015 11:48 AM, Jastrzebski, MichalX K wrote:
>>> On 02/20/2015 05:18 PM, Daniel Mrzyglod wrote:
Function match_inst is used to take buffor using sizeof() which is size_t
>> type.
This modification also involved changing '%u' to '%zu' in printf function.
Hi Neil,
On 03/19/2015 02:16 PM, Neil Horman wrote:
>> On 03/18/2015 09:58 PM, Neil Horman wrote:
+/**
+ * Free a bulk of mbufs into its original mempool.
+ * This function assumes:
+ * - refcnt equals 1
+ * - mbufs are direct
+ * - all mbufs must belong to the same
Hi,
On 03/23/2015 09:11 AM, gaohaifeng wrote:
> From: Haifeng Gao
>
> eal options OPT_CREATE_UIO_DEV does not need argument so set it to zero.
> It needs to reset create_uio_dev explicitly.
>
> Signed-off-by: Haifeng Gao
Acked-by: Olivier Matz
Thank you for fixing this
Hi Shankari,
On 03/23/2015 04:54 PM, Shankari Vaidyalingam wrote:
> Hi
>
> I'm trying to do a packet capture on the DPDK interface while running l2fwd
> sample application and injecting packets from a traffic generator.
> I'm getting the below error when I give this command: sudo ./build/l2fw-c
Signed-off-by: Olivier Matz
---
doc/guides/prog_guide/mbuf_lib.rst | 89 +
doc/guides/prog_guide/poll_mode_drv.rst | 24 +
2 files changed, 104 insertions(+), 9 deletions(-)
diff --git a/doc/guides/prog_guide/mbuf_lib.rst
b/doc/guides/prog_guide
801 - 900 of 1449 matches
Mail list logo
