[dpdk-dev] [PATCH v3 2/3] mk: add DT_NEEDED entries for librte_vhost external dependencies

2016-03-10 Thread Panu Matilainen
Add DT_NEEDED entries for external library dependencies which are the most critical ones for sane operation. Clean up vhost_cuse CFLAGS/LDFLAGS confusion while at it. Signed-off-by: Panu Matilainen --- lib/librte_vhost/Makefile | 7 --- mk/rte.app.mk | 14 ++ 2

[dpdk-dev] [PATCH v3 1/3] mk: clear up libm and librt linkage confusion

2016-03-10 Thread Panu Matilainen
There are two places that need -lm (test app and librte_sched) and exactly one that needs -lrt (librte_sched). Add the relevant DT_NEEDED entries to both, and eliminate the bogus discrepancy between Linux and BSD EXECENV_LDLIBS wrt these libs. Signed-off-by: Panu Matilainen --- app/test

[dpdk-dev] [PATCH v3 0/3] mk: add DT_NEEDED entries for external library deps

2016-03-10 Thread Panu Matilainen
Add hopefully all the remaining missing DT_NEEDED entries for external library dependencies on the libraries side: librte_vhost, librte_sched and librte_eal. Panu Matilainen (3): mk: clear up libm and librt linkage confusion mk: add DT_NEEDED entries for librte_vhost external dependencies

[dpdk-dev] [PATCH 3/3] scripts: ignore self-generated directories in validate-abi startup check

2016-03-10 Thread Panu Matilainen
On 03/10/2016 02:34 PM, Ferruh Yigit wrote: > On 3/10/2016 12:29 PM, Panu Matilainen wrote: >> On 03/10/2016 02:22 PM, Ferruh Yigit wrote: >>> On 3/10/2016 10:53 AM, Panu Matilainen wrote: >>>> When doing multiple runs of validate-abi.sh, the git status c

[dpdk-dev] [PATCH 2/3] scripts: avoid editing defconfig_* files in validate-abi.sh

2016-03-10 Thread Panu Matilainen
On 03/10/2016 02:25 PM, Ferruh Yigit wrote: > On 3/10/2016 10:53 AM, Panu Matilainen wrote: >> The defconfig_* files are templates which are not supposed to be >> edited, and doing so tends to leave unwanted cruft behind. Edit >> the "working copy" config instead,

[dpdk-dev] [PATCH 3/3] scripts: ignore self-generated directories in validate-abi startup check

2016-03-10 Thread Panu Matilainen
On 03/10/2016 02:22 PM, Ferruh Yigit wrote: > On 3/10/2016 10:53 AM, Panu Matilainen wrote: >> When doing multiple runs of validate-abi.sh, the git status check >> will more often than not unnecessarily fail with "Working directory not >> clean" error because o

[dpdk-dev] [PATCH 3/3] scripts: ignore self-generated directories in validate-abi startup check

2016-03-10 Thread Panu Matilainen
g. Signed-off-by: Panu Matilainen --- scripts/validate-abi.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/validate-abi.sh b/scripts/validate-abi.sh index ea60639..a21f883 100755 --- a/scripts/validate-abi.sh +++ b/scripts/validate-abi.sh @@ -163,8 +163,7 @@

[dpdk-dev] [PATCH 2/3] scripts: avoid editing defconfig_* files in validate-abi.sh

2016-03-10 Thread Panu Matilainen
The defconfig_* files are templates which are not supposed to be edited, and doing so tends to leave unwanted cruft behind. Edit the "working copy" config instead, which is the intended DPDK way. Signed-off-by: Panu Matilainen --- scripts/validate-abi.sh | 18 +- 1 fi

[dpdk-dev] [PATCH 1/3] scripts: support parallel building in validate-abi.sh via -j[N] option

2016-03-10 Thread Panu Matilainen
Signed-off-by: Panu Matilainen --- doc/guides/contributing/versioning.rst | 4 +++- scripts/validate-abi.sh| 13 ++--- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/doc/guides/contributing/versioning.rst b/doc/guides/contributing/versioning.rst index

[dpdk-dev] [PATCH] eal: add option --avail-cores to detect lcores

2016-03-09 Thread Panu Matilainen
On 03/08/2016 07:38 PM, Tan, Jianfeng wrote: > Hi Panu, > > On 3/8/2016 4:54 PM, Panu Matilainen wrote: >> On 03/04/2016 12:05 PM, Jianfeng Tan wrote: >>> This patch adds option, --avail-cores, to use lcores which are available >>> by calling pthread_getaffinity_n

[dpdk-dev] [PATCH v3 3/4] mempool: allow rte_pktmbuf_pool_create switch between memool handlers

2016-03-09 Thread Panu Matilainen
On 03/09/2016 01:38 PM, Hunt, David wrote: > Hi Panu, > > On 3/9/2016 10:54 AM, Panu Matilainen wrote: >> On 03/09/2016 11:50 AM, David Hunt wrote: >>> If the user wants to have rte_pktmbuf_pool_create() use an external >>> mempool >>> handler, they defi

[dpdk-dev] [PATCH v3 3/4] mempool: allow rte_pktmbuf_pool_create switch between memool handlers

2016-03-09 Thread Panu Matilainen
On 03/09/2016 11:50 AM, David Hunt wrote: > If the user wants to have rte_pktmbuf_pool_create() use an external mempool > handler, they define RTE_MEMPOOL_HANDLER_NAME to be the name of the > mempool handler they wish to use, and change RTE_MEMPOOL_HANDLER_EXT to 'y' > > Signed-off-by: David Hunt

[dpdk-dev] [PATCH v3 4/4] mempool: add in the RTE_NEXT_ABI for ABI breakages

2016-03-09 Thread Panu Matilainen
On 03/09/2016 11:50 AM, David Hunt wrote: > This patch is for those people who want to be easily able to switch > between the new mempool layout and the old. Change the value of > RTE_NEXT_ABI in common_base config file I guess the idea here is to document how to switch between the ABIs but to

[dpdk-dev] [PATCH v2 1/4] lib/librte_port: add PCAP file support to source port

2016-03-08 Thread Panu Matilainen
On 03/08/2016 10:36 AM, Dumitrescu, Cristian wrote: > > >> -Original Message- >> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >> Sent: Monday, March 7, 2016 11:18 AM >> To: Zhang, Roy Fan >> Cc: dev at dpdk.org; Panu Matilainen ; Dum

[dpdk-dev] [PATCH] eal: add option --avail-cores to detect lcores

2016-03-08 Thread Panu Matilainen
On 03/04/2016 12:05 PM, Jianfeng Tan wrote: > This patch adds option, --avail-cores, to use lcores which are available > by calling pthread_getaffinity_np() to narrow down detected cores before > parsing coremask (-c), corelist (-l), and coremap (--lcores). > > Test example: > $ taskset 0xc

[dpdk-dev] [PATCH v2 1/5] mem: add --single-file to create single mem-backed file

2016-03-08 Thread Panu Matilainen
On 03/07/2016 03:13 PM, Yuanhan Liu wrote: > CC'ed EAL hugepage maintainer, which is something you should do when > send a patch. > > On Fri, Feb 05, 2016 at 07:20:24PM +0800, Jianfeng Tan wrote: >> Originally, there're two cons in using hugepage: a. needs root >> privilege to touch

[dpdk-dev] [PATCH] config: remove duplicate configuration information

2016-03-04 Thread Panu Matilainen
On 03/03/2016 08:37 PM, Thomas Monjalon wrote: >> --- a/config/defconfig_x86_64-native-bsdapp-clang >> +++ b/config/defconfig_x86_64-native-bsdapp-clang >> @@ -37,6 +37,7 @@ CONFIG_RTE_MACHINE="native" >> CONFIG_RTE_ARCH="x86_64" >> CONFIG_RTE_ARCH_X86_64=y >> CONFIG_RTE_ARCH_X86=y >>

[dpdk-dev] [PATCH] config: remove duplicate configuration information

2016-03-04 Thread Panu Matilainen
On 03/04/2016 11:28 AM, Traynor, Kevin wrote: > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon >> Sent: Thursday, March 3, 2016 6:38 PM >> To: Wiles, Keith >> Cc: dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate

[dpdk-dev] [PATCH] config: remove duplicate configuration information

2016-03-04 Thread Panu Matilainen
On 03/03/2016 08:37 PM, Thomas Monjalon wrote: > 2016-02-22 07:53, Keith Wiles: >> --- /dev/null >> +++ b/config/common_base >> +CONFIG_RTE_EAL_IGB_UIO=y >> +CONFIG_RTE_EAL_VFIO=y > > These options should be disabled in the base file > and enabled in Linux. > >> +CONFIG_RTE_LIBRTE_PMD_AF_PACKET=y

[dpdk-dev] [PATCH v3] mk: stop on warning only in developer build

2016-03-03 Thread Panu Matilainen
On 03/03/2016 12:36 PM, Thomas Monjalon wrote: > 2016-03-02 22:04, Bruce Richardson: >> On Wed, Mar 02, 2016 at 03:22:23PM +0100, Thomas Monjalon wrote: >>> From: Panu Matilainen >>> >>> Add RTE_DEVEL_BUILD make-variable which can be used to do things >&

[dpdk-dev] [PATCH 1/3] kcp: add kernel control path kernel module

2016-03-03 Thread Panu Matilainen
On 03/03/2016 12:05 PM, Ferruh Yigit wrote: > On 3/3/2016 8:31 AM, Panu Matilainen wrote: >> On 03/03/2016 12:35 AM, Thomas Monjalon wrote: >>> 2016-03-02 12:21, Thomas Monjalon: >>>> 2016-03-02 11:47, Vincent JARDIN: >>>>> Le 02/03/2016 09:27, Panu

[dpdk-dev] [PATCH v6 1/5] lib/librte_ether: change function name of tunnel port config

2016-03-03 Thread Panu Matilainen
On 03/03/2016 03:22 AM, Wenzhuo Lu wrote: > The names of function for tunnel port configuration are not > accurate. They're tunnel_add/del, better change them to > tunnel_port_add/del. > As it may be an ABI change if change the names directly, the > new functions are added but not remove the old

[dpdk-dev] [PATCH v3 1/2] librte_pipeline: add support for packet redirection at action handlers

2016-03-03 Thread Panu Matilainen
On 03/02/2016 10:41 PM, Jasvinder Singh wrote: > Currently, there is no mechanism that allows the pipeline ports (in/out) and > table action handlers to override the default forwarding decision (as > previously configured per input port or in the table entry). Therefore, new > pipeline API

[dpdk-dev] [PATCH 1/3] kcp: add kernel control path kernel module

2016-03-03 Thread Panu Matilainen
On 03/03/2016 12:35 AM, Thomas Monjalon wrote: > 2016-03-02 12:21, Thomas Monjalon: >> 2016-03-02 11:47, Vincent JARDIN: >>> Le 02/03/2016 09:27, Panu Matilainen a ?crit : >>>>>> I'd like to see these be merged. >>>>>> >>>>>>

[dpdk-dev] [PATCH v2] mk: replace the combined library with a linker script

2016-03-02 Thread Panu Matilainen
On 03/02/2016 02:40 PM, Thomas Monjalon wrote: > 2016-03-02 14:30, Panu Matilainen: >> On 03/01/2016 04:48 PM, Panu Matilainen wrote: >>> On 03/01/2016 03:40 PM, Thomas Monjalon wrote: >>>> ping >>>> I would like to be sure nothing is forgotten in this n

[dpdk-dev] [PATCH v2] mk: replace the combined library with a linker script

2016-03-02 Thread Panu Matilainen
On 03/01/2016 04:48 PM, Panu Matilainen wrote: > On 03/01/2016 03:40 PM, Thomas Monjalon wrote: >> ping >> I would like to be sure nothing is forgotten in this new revision. > > Sorry, didn't realize you were waiting for input from me, it feels a bit > strange to comment

[dpdk-dev] [PATCH 1/3] kcp: add kernel control path kernel module

2016-03-02 Thread Panu Matilainen
On 03/02/2016 04:02 AM, Stephen Hemminger wrote: > On Mon, 29 Feb 2016 08:33:25 -0600 > Jay Rolette wrote: > >> On Mon, Feb 29, 2016 at 5:06 AM, Thomas Monjalon > 6wind.com> >> wrote: >> >>> Hi, >>> I totally agree with Avi's comments. >>> This topic is really important for the future of DPDK.

[dpdk-dev] [PATCH v4 4/4] ena: DPDK polling-mode driver for Amazon Elastic Network Adapters (ENA)

2016-03-02 Thread Panu Matilainen
On 03/01/2016 06:46 PM, Jan Medala wrote: > This is a PMD for the Amazon ethernet ENA family. > The driver operates variety of ENA adapters through feature negotiation > with the adapter and upgradable commands set. > ENA driver handles PCI Physical and Virtual ENA functions. > > Signed-off-by:

[dpdk-dev] [PATCH v6 1/4] lib/ether: optimize the'rte_eth_tunnel_filter_conf' structure

2016-03-02 Thread Panu Matilainen
On 03/02/2016 05:10 AM, Sun, Xutao wrote: > Hi, Panu > >> -Original Message----- >> From: Panu Matilainen [mailto:pmatilai at redhat.com] >> Sent: Tuesday, March 01, 2016 4:54 PM >> To: Sun, Xutao ; dev at dpdk.org >> Subject: Re: [dpdk-dev

[dpdk-dev] [PATCH v2] mk: replace the combined library with a linker script

2016-03-01 Thread Panu Matilainen
0, Thomas Monjalon: >> From: Panu Matilainen >> >> The physically linked-together combined library has been an increasing >> source of problems, as was predicted when library and symbol versioning >> was introduced. Replace the complex and fragile construction with a >>

[dpdk-dev] [PATCH 3/8] drivers/net/e1000: Fix missing brackets

2016-03-01 Thread Panu Matilainen
On 02/26/2016 03:13 PM, Aaron Conole wrote: > Hi Wenzhou, > > "Lu, Wenzhuo" writes: > >> Hi Aaron, >> >> >>> -Original Message- >>> From: Aaron Conole [mailto:aconole at redhat.com] >>> Sent: Friday, February 26, 2016 2:49 AM >>> To: dev at dpdk.org >>> Cc: Lu, Wenzhuo; Zhang, Helin;

[dpdk-dev] [PATCH v3] af_packet: make the device detachable

2016-03-01 Thread Panu Matilainen
On 02/29/2016 08:22 PM, Wojciech ?muda wrote: > Hi Bernard, > >> Does making rte_pmd_af_packet_devinit local result in an ABI breakage? > If someone uses it in their app, they'll be forced to change it. > However, as this function is not intentionally public and there is API > to create devices

[dpdk-dev] [PATCH v6 1/4] lib/ether: optimize the'rte_eth_tunnel_filter_conf' structure

2016-03-01 Thread Panu Matilainen
On 03/01/2016 05:47 AM, Xutao Sun wrote: > Change the fields of outer_mac and inner_mac from pointer to struct > in order to keep the code's readability. > > Signed-off-by: Xutao Sun > Signed-off-by: Jijiang Liu > --- > app/test-pmd/cmdline.c | 6 -- >

[dpdk-dev] [PATCH v5 01/11] ethdev: add API to query packet type filling info

2016-03-01 Thread Panu Matilainen
On 02/29/2016 06:41 PM, Tan, Jianfeng wrote: > Hi Panu, > > On 2/29/2016 7:34 PM, Panu Matilainen wrote: [...] >> >> More importantly, to export a function you need to add an entry for it >> in rte_ether_version.map. > > Oh, yes, thanks for pointing out

[dpdk-dev] [PATCH 1/3] kcp: add kernel control path kernel module

2016-02-29 Thread Panu Matilainen
On 02/29/2016 05:27 PM, Thomas Monjalon wrote: > 2016-02-29 17:19, Panu Matilainen: >> On 02/29/2016 01:35 PM, Ferruh Yigit wrote: >>> On 2/29/2016 11:06 AM, Thomas Monjalon wrote: >>>> Hi, >>>> I totally agree with Avi's comments. >>>>

[dpdk-dev] [PATCH 1/3] kcp: add kernel control path kernel module

2016-02-29 Thread Panu Matilainen
On 02/29/2016 01:35 PM, Ferruh Yigit wrote: > On 2/29/2016 11:06 AM, Thomas Monjalon wrote: >> Hi, >> I totally agree with Avi's comments. >> This topic is really important for the future of DPDK. >> So I think we must give some time to continue the discussion >> and have netdev involved in the

[dpdk-dev] [PATCH v5 01/11] ethdev: add API to query packet type filling info

2016-02-29 Thread Panu Matilainen
On 02/26/2016 09:34 AM, Jianfeng Tan wrote: > Add a new API rte_eth_dev_get_ptype_info to query whether/what packet > type can be filled by given pmd rx burst function. > > Signed-off-by: Jianfeng Tan > --- > lib/librte_ether/rte_ethdev.c | 26 ++ >

[dpdk-dev] [PATCH v6 1/2] mbuf: provide rte_pktmbuf_alloc_bulk API

2016-02-29 Thread Panu Matilainen
On 02/24/2016 03:23 PM, Ananyev, Konstantin wrote: > Hi Panu, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen >> Sent: Wednesday, February 24, 2016 12:12 PM >> To: Xie, Huawei; Olivier MATZ; dev at dpdk.o

[dpdk-dev] [PATCH v6 1/2] mbuf: provide rte_pktmbuf_alloc_bulk API

2016-02-24 Thread Panu Matilainen
On 02/23/2016 07:35 AM, Xie, Huawei wrote: > On 2/22/2016 10:52 PM, Xie, Huawei wrote: >> On 2/4/2016 1:24 AM, Olivier MATZ wrote: >>> Hi, >>> >>> On 01/27/2016 02:56 PM, Panu Matilainen wrote: >>>> Since rte_pktmbuf_alloc_bulk() is an inline

[dpdk-dev] [PATCH] mk: fix the combined library problems by replacing it with a linker script

2016-02-24 Thread Panu Matilainen
seemed to me most (if not everybody) had converged on the side of the linker script approach. > > Comments below: > > 2015-11-24 16:31, Panu Matilainen: >> The physically linked-together combined library has been an increasing >> source of problems, as was pr

[dpdk-dev] including rte.app.mk from a Makefile.am

2016-02-24 Thread Panu Matilainen
On 02/24/2016 04:24 AM, Stefan Puiu wrote: > Hi, > > I'm working on a Linux project that uses the DPDK and (unfornately, > IMO) automake; so we have a Makefile.am where we include rte.extapp.mk > and rte.vars.mk from the DPDK, add LDLIBS to the linker > > However, I've tried building against DPDK

[dpdk-dev] [PATCH] config: remove duplicate configuration information

2016-02-22 Thread Panu Matilainen
On 02/22/2016 06:02 PM, Wiles, Keith wrote: >> Hi Keith, >> >> What makes a param common? >> >> e.g. cryptodev QAT PMD is supported in linux, but currently not supported >> in bsd. >> So typically I disable it in the bsd file and enable it in the linux file. >> >> Couldn't the same apply to any

[dpdk-dev] [PATCH v2 4/6] bond mode 4: allow external state machine

2016-02-22 Thread Panu Matilainen
On 02/19/2016 09:17 PM, Eric Kinzie wrote: > From: Eric Kinzie > > Provide functions to allow an external 802.3ad state machine to transmit > and recieve LACPDUs and to set the collection/distribution flags on > slave interfaces. > > Signed-off-by: Eric Kinzie > Signed-off-by: Stephen Hemminger

[dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net

2016-02-18 Thread Panu Matilainen
On 02/18/2016 03:56 PM, Yuanhan Liu wrote: > On Thu, Feb 18, 2016 at 03:39:26PM +0200, Panu Matilainen wrote: >> On 02/18/2016 03:25 PM, Yuanhan Liu wrote: >>> On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote: >>>> Commit d0cf91303d73 added dependency

[dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net

2016-02-18 Thread Panu Matilainen
On 02/18/2016 03:25 PM, Yuanhan Liu wrote: > On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote: >> Commit d0cf91303d73 added dependency on librte_net headers to vhost >> but did not add this to the Makefile, which makes builds >> non-deterministic. Curiously it

[dpdk-dev] [PATCH] vhost: fix missing dependency on librte_net

2016-02-18 Thread Panu Matilainen
On 02/18/2016 01:47 PM, Jan Viktorin wrote: > This patch fixes the following build regression: > > lib/librte_vhost/vhost_rxtx.c: At top level: > lib/librte_vhost/vhost_rxtx.c:41:20: fatal error: rte_ip.h: No such file or > directory > #include > ^ >

[dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net

2016-02-18 Thread Panu Matilainen
-j(n) fails with: dpdk/lib/librte_vhost/vhost_rxtx.c:41:20: fatal error: rte_ip.h: No such file or directory Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities") Signed-off-by: Panu Matilainen --- lib/librte_vhost/Makefile | 1 + 1 file changed, 1 insertion(+)

[dpdk-dev] [PKTGEN] fixing weird termio issues that complicate debugging

2016-02-17 Thread Panu Matilainen
On 01/23/2016 04:22 AM, Wiles, Keith wrote: > On 1/22/16, 1:45 AM, "Panu Matilainen" wrote: >> We wouldn't be discussing this if it was not an issue. It is offensive >> enough to turn away both users and contributors, and merely speeding up >> a bit is not goin

[dpdk-dev] [PATCH v2] PCI: ABI change request for adding new field in rte_pci_id structure

2016-02-16 Thread Panu Matilainen
On 02/16/2016 09:43 AM, Yang, Ziye wrote: > Hi Panu, > > " ABI breakage announcements go into doc/guides/rel_notes/deprecation.rst, > see the examples there. Also you can't break the ABI in the version under > development but only the next one, so right now the earliest ABI breakage >

[dpdk-dev] [PATCH v2] PCI: ABI change request for adding new field in rte_pci_id structure

2016-02-16 Thread Panu Matilainen
On 02/16/2016 05:16 AM, Ziye Yang wrote: > From: Ziye > > The purpose of this patch is used to add a new field > "class" in rte_pci_id structure. The new class field includes > class_id, subcalss_id, programming interface of a pci device. > With this field, we can identify pci device by its class

[dpdk-dev] vm_power_manager uses channel_commands.h which is not placed in installed copy of DPDK

2016-02-15 Thread Panu Matilainen
On 02/15/2016 12:15 PM, Thomas Monjalon wrote: > 2016-02-15 10:29, Panu Matilainen: >> On 02/14/2016 01:38 AM, Matthew Hall wrote: >>> Hello, >>> >>> I found a peculiarity in the vm_power_manager example on DPDK 2.2 if you >>> use an installed

[dpdk-dev] vm_power_manager uses channel_commands.h which is not placed in installed copy of DPDK

2016-02-15 Thread Panu Matilainen
On 02/14/2016 01:38 AM, Matthew Hall wrote: > Hello, > > I found a peculiarity in the vm_power_manager example on DPDK 2.2 if you use > an installed copy of DPDK to compile the examples instead of the master copy > (while trying to update some outdated stuff in my build system). > > mhall at

[dpdk-dev] [PATCH v3] mempool: reduce rte_mempool structure size

2016-02-12 Thread Panu Matilainen
On 02/12/2016 03:57 PM, Thomas Monjalon wrote: > 2016-02-12 13:23, Panu Matilainen: >> On 02/10/2016 11:18 PM, Keith Wiles wrote: >>>static inline void *rte_mempool_get_priv(struct rte_mempool *mp) >>>{ >>> +#ifdef RT

[dpdk-dev] [PATCH] config: add default linux configuration

2016-02-12 Thread Panu Matilainen
On 01/28/2016 04:31 PM, Bernard Iremonger wrote: > add config/defconfig_x86_64-default-linuxapp-gcc file. > > Signed-off-by: Bernard Iremonger > --- > config/defconfig_x86_64-default-linuxapp-gcc | 42 > > 1 file changed, 42 insertions(+) > create mode 100644

[dpdk-dev] [PATCH v2] mempool: reduce rte_mempool structure size

2016-02-12 Thread Panu Matilainen
On 02/10/2016 08:02 PM, Thomas Monjalon wrote: > 2016-02-10 18:01, Wiles, Keith: > --- a/config/defconfig_x86_64-native-linuxapp-gcc > +++ b/config/defconfig_x86_64-native-linuxapp-gcc > @@ -40,3 +40,8 @@ CONFIG_RTE_ARCH_64=y > > CONFIG_RTE_TOOLCHAIN="gcc" >

[dpdk-dev] [PATCH v3] mempool: reduce rte_mempool structure size

2016-02-12 Thread Panu Matilainen
On 02/10/2016 11:18 PM, Keith Wiles wrote: > The rte_mempool structure is changed, which will cause an ABI change > for this structure. Providing backward compat is not reasonable > here as this structure is used in multiple defines/inlines. > > Allow mempool cache support to be dynamic depending

[dpdk-dev] [PATCH v7 5/5] ethdev: add rte_eth_speed_to_bm_flag() to ver. map

2016-01-29 Thread Panu Matilainen
On 01/29/2016 02:42 AM, Marc Sune wrote: > Added rte_eth_speed_to_bm_flag() to DPDK2.2 version map. > > Signed-off-by: Marc Sune > --- > lib/librte_ether/rte_ether_version.map | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/librte_ether/rte_ether_version.map >

[dpdk-dev] [PATCH] pci: Add the class_id support in pci probe

2016-01-29 Thread Panu Matilainen
On 01/29/2016 12:10 PM, Panu Matilainen wrote: > On 01/29/2016 11:34 AM, Thomas Monjalon wrote: >> 2016-01-29 11:21, Panu Matilainen: >>> On 01/28/2016 11:38 PM, Thomas Monjalon wrote: >>>> 2016-01-13 14:22, Panu Matilainen: >>>>> On 01/13/2016 01:55 P

[dpdk-dev] [PATCH] pci: Add the class_id support in pci probe

2016-01-29 Thread Panu Matilainen
On 01/29/2016 11:34 AM, Thomas Monjalon wrote: > 2016-01-29 11:21, Panu Matilainen: >> On 01/28/2016 11:38 PM, Thomas Monjalon wrote: >>> 2016-01-13 14:22, Panu Matilainen: >>>> On 01/13/2016 01:55 PM, Bruce Richardson wrote: >>>>> On Thu, Dec 31, 2015

[dpdk-dev] [PATCH] pci: Add the class_id support in pci probe

2016-01-29 Thread Panu Matilainen
On 01/28/2016 11:38 PM, Thomas Monjalon wrote: > 2016-01-13 14:22, Panu Matilainen: >> On 01/13/2016 01:55 PM, Bruce Richardson wrote: >>> On Thu, Dec 31, 2015 at 09:12:14AM -0800, Stephen Hemminger wrote: >>>> On Tue, 29 Dec 2015 10:53:26 +0800 >>>> Ziye

[dpdk-dev] [PATCH 1/4] lib/librte_port: add PCAP file support to source port

2016-01-28 Thread Panu Matilainen
On 01/27/2016 07:39 PM, Fan Zhang wrote: > Originally, source ports in librte_port is an input port used as packet > generator. Similar to Linux kernel /dev/zero character device, it > generates null packets. This patch adds optional PCAP file support to > source port: instead of sending NULL

[dpdk-dev] [PATCH 3/4] lib/librte_port: add packet dumping to PCAP file support in sink port

2016-01-28 Thread Panu Matilainen
On 01/27/2016 07:39 PM, Fan Zhang wrote: > Originally, sink ports in librte_port releases received mbufs back to > mempool. This patch adds optional packet dumping to PCAP feature in sink > port: the packets will be dumped to user defined PCAP file for storage or > debugging. The user may also

[dpdk-dev] [PATCH v6 1/2] tools: Add support for handling built-in kernel modules

2016-01-28 Thread Panu Matilainen
On 01/28/2016 01:17 PM, Kamil Rytarowski wrote: > > > W dniu 26.01.2016 o 16:23, Thomas Monjalon pisze: >> 2016-01-20 10:48, krytarowski at caviumnetworks.com: >>> --- a/tools/dpdk_nic_bind.py >>> +++ b/tools/dpdk_nic_bind.py >>> -for line in loaded_mods: >>> +try: >>> +# Get list

[dpdk-dev] [PATCH v3 4/4] virtio: check if kernel driver is manipulating the virtio device

2016-01-28 Thread Panu Matilainen
On 01/27/2016 05:21 PM, Huawei Xie wrote: > v3 changes: > change log message to tell user that the virtio device is skipped > due to it is managed by kernel driver, instead of asking user to > unbind it from kernel driver. > > v2 changes: > change LOG level from ERR to INFO > > virtio PMD

[dpdk-dev] [PATCH v2] fix checkpatch errors

2016-01-28 Thread Panu Matilainen
On 01/28/2016 10:38 AM, Xie, Huawei wrote: > On 1/28/2016 4:06 PM, Thomas Monjalon wrote: >> 2016-01-28 03:09, Xie, Huawei: >>> On 1/28/2016 2:17 AM, Thomas Monjalon wrote: 2016-01-27 01:26, Huawei Xie: > v2 changes: > add missed commit message in v1 > > fix the error

[dpdk-dev] [PATCH V1 1/1] jobstats: added function abort for job

2016-01-28 Thread Panu Matilainen
On 01/27/2016 05:57 PM, Jastrzebski, MichalX K wrote: >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen >> Sent: Wednesday, January 27, 2016 2:38 PM >> To: Kerlin, MarcinX ; dev at dpdk.org >> Subject: Re: [dpd

[dpdk-dev] [PATCH v6 1/2] mbuf: provide rte_pktmbuf_alloc_bulk API

2016-01-27 Thread Panu Matilainen
On 01/26/2016 07:03 PM, Huawei Xie wrote: > v6 changes: > reflect the changes in release notes and library version map file > revise our duff's code style a bit to make it more readable > > v5 changes: > add comment about duff's device and our variant implementation > > v3 changes: > move

[dpdk-dev] [PATCH V1 1/1] jobstats: added function abort for job

2016-01-27 Thread Panu Matilainen
On 01/26/2016 06:15 PM, Marcin Kerlin wrote: > This patch adds new function rte_jobstats_abort. It marks *job* as finished > and time of this work will be add to management time instead of execution > time. > This function should be used instead of rte_jobstats_finish if condition > occure, >

[dpdk-dev] [PATCH v3] Patch introducing API to read/write Intel Architecture Model Specific Registers (MSR)...

2016-01-22 Thread Panu Matilainen
On 01/21/2016 12:51 PM, Ananyev, Konstantin wrote: > Hi Panu, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen >> Sent: Thursday, January 21, 2016 10:39 AM >> To: Andralojc, WojciechX >> Cc: dev at dpdk.o

[dpdk-dev] [PKTGEN] fixing weird termio issues that complicate debugging

2016-01-22 Thread Panu Matilainen
On 01/21/2016 05:03 PM, Wiles, Keith wrote: > On 1/21/16, 2:46 AM, "Panu Matilainen" wrote: > >> On 01/20/2016 06:26 PM, Wiles, Keith wrote: >>> On 1/20/16, 12:32 AM, "dev on behalf of Matthew Hall" >> dpdk.org on behalf of mhall at mhcomput

[dpdk-dev] [PATCH v3] Patch introducing API to read/write Intel Architecture Model Specific Registers (MSR)...

2016-01-21 Thread Panu Matilainen
On 01/21/2016 10:18 AM, Wojciech Andralojc wrote: > Patch reworked. > > Signed-off-by: Wojciech Andralojc > --- > lib/librte_eal/common/include/arch/x86/rte_msr.h | 88 + > lib/librte_eal/linuxapp/eal/Makefile | 1 + >

[dpdk-dev] [PKTGEN] fixing weird termio issues that complicate debugging

2016-01-21 Thread Panu Matilainen
On 01/20/2016 06:26 PM, Wiles, Keith wrote: > On 1/20/16, 12:32 AM, "dev on behalf of Matthew Hall" dpdk.org on behalf of mhall at mhcomputing.net> wrote: > >> Hello, >> >> Since the pktgen code is reindented I am finding time to read through it >> and experiment and see if I can get it working.

[dpdk-dev] [PATCH v2] cfgfile: support looking up sections by index

2016-01-21 Thread Panu Matilainen
On 01/19/2016 06:41 AM, Rich Lane wrote: > This is useful when sections have duplicate names. > > Signed-off-by: Rich Lane > --- > v1->v2: > - Added new symbol to version script. > > lib/librte_cfgfile/rte_cfgfile.c | 16 > lib/librte_cfgfile/rte_cfgfile.h

[dpdk-dev] [RFC 0/3] Use common Linux tools to control DPDK ports

2016-01-19 Thread Panu Matilainen
On 01/19/2016 11:59 AM, Ferruh Yigit wrote: > On Mon, Jan 18, 2016 at 11:20:02AM -0500, Aaron Conole wrote: >> Ferruh Yigit writes: >>> This work is to make DPDK ports more visible and to enable using common >>> Linux tools to configure DPDK ports. >> >> This is a good goal. Only question - why

[dpdk-dev] [PATCH] cfgfile: support looking up sections by index

2016-01-18 Thread Panu Matilainen
On 01/17/2016 05:58 AM, Rich Lane wrote: > This is useful when sections have duplicate names. > > Signed-off-by: Rich Lane > --- > lib/librte_cfgfile/rte_cfgfile.c | 16 > lib/librte_cfgfile/rte_cfgfile.h | 23 +++ > 2 files changed, 39 insertions(+) >

[dpdk-dev] [PATCH v2 1/3] cmdline: increase command line buffer

2016-01-15 Thread Panu Matilainen
On 01/15/2016 10:44 AM, N?lio Laranjeiro wrote: > On Tue, Jan 12, 2016 at 02:46:07PM +0200, Panu Matilainen wrote: >> On 01/12/2016 12:49 PM, Nelio Laranjeiro wrote: >>> Allow long command lines in testpmd (like flow director with IPv6, ...). >>> >>> Signed-o

[dpdk-dev] [PATCH] pci: Add the class_id support in pci probe

2016-01-13 Thread Panu Matilainen
On 01/13/2016 01:55 PM, Bruce Richardson wrote: > On Thu, Dec 31, 2015 at 09:12:14AM -0800, Stephen Hemminger wrote: >> On Tue, 29 Dec 2015 10:53:26 +0800 >> Ziye Yang wrote: >> >>> This patch is used to add the class_id support >>> for pci_probe since some devices need the class_info >>>

[dpdk-dev] [PATCH v2 1/3] cmdline: increase command line buffer

2016-01-12 Thread Panu Matilainen
On 01/12/2016 12:49 PM, Nelio Laranjeiro wrote: > Allow long command lines in testpmd (like flow director with IPv6, ...). > > Signed-off-by: John McNamara > Signed-off-by: Nelio Laranjeiro > --- > doc/guides/rel_notes/deprecation.rst | 5 - > lib/librte_cmdline/cmdline_rdline.h | 2 +- >

[dpdk-dev] [PATCH v2 4/4] virtio: check if any kernel driver is manipulating the virtio device

2016-01-07 Thread Panu Matilainen
On 01/03/2016 07:56 PM, Huawei Xie wrote: > v2 changes: > change LOG level from ERR to INFO > > virtio PMD could use IO port to configure the virtio device without > using uio driver. > > There are two issues with previous implementation: > 1) virtio PMD will take over each virtio device blindly

[dpdk-dev] [PATCH 4/4] virtio: check if any kernel driver is manipulating the device

2016-01-05 Thread Panu Matilainen
On 01/04/2016 11:02 AM, Xie, Huawei wrote: > On 12/25/2015 6:33 PM, Xie, Huawei wrote: >> virtio PMD could use IO port to configure the virtio device without >> using uio driver. >> >> There are two issues with previous implementation: >> 1) virtio PMD will take over each virtio device blindly

[dpdk-dev] [PATCH] scripts: fix abi-validator regression when revision is a tag

2015-12-15 Thread Panu Matilainen
t any git revisions as ABI validation range") Signed-off-by: Panu Matilainen --- scripts/validate-abi.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/validate-abi.sh b/scripts/validate-abi.sh index 8d7be24..c36ad61 100755 --- a/scripts/validate-abi.sh +++

[dpdk-dev] [PATCH 2/2] ethdev: remove old flow director symbols

2015-12-15 Thread Panu Matilainen
On 12/15/2015 12:47 PM, Thomas Monjalon wrote: > The API has been removed but the symbols were still declared in the map. > > Fixes: a421b86a4a02 ("ethdev: remove old flow director API") > > Signed-off-by: Thomas Monjalon > --- > lib/librte_ether/rte_ether_version.map | 8 > 1 file

[dpdk-dev] [PATCH] scripts: fix relpath.sh output when $prefix is set in environment

2015-12-11 Thread Panu Matilainen
../../include/dpdk lib -> /usr../../../lib Initialize the local variable to empty to avoid side-effects from environment. Signed-off-by: Panu Matilainen --- scripts/relpath.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/relpath.sh b/scripts/relpath.sh index 7d2f48f

[dpdk-dev] [PATCH] doc: announce API change for rte_ether.h

2015-12-11 Thread Panu Matilainen
On 12/11/2015 01:27 AM, Stephen Hemminger wrote: > Plan to change to version of struct ether_addr in > DPDK 2.3. The change in DPDK source is trivial but it will impact > source compatablilty therefore notification is necessary. > > Signed-off-by: Stephen Hemminger > --- >

[dpdk-dev] [PATCH v2] examples/vhost: reduce number of hugepages needed

2015-12-11 Thread Panu Matilainen
On 12/10/2015 04:50 PM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bernard Iremonger >> Sent: Thursday, December 10, 2015 1:53 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH v2] examples/vhost: reduce number of

[dpdk-dev] [PATCH v2] mk: fix external shared library dependencies of libraries

2015-12-09 Thread Panu Matilainen
On 12/08/2015 06:28 PM, Sergio Gonzalez Monroy wrote: > On 08/12/2015 11:47, Panu Matilainen wrote: >> Similar to commit 5f9115e58cc6f304ff4ade694cf5823d32887d1a etc, but >> for libraries. Clean up librte_vhost CFLAGS/LDFLAGS/LDLIBS confusion >> while at it. >> >&g

[dpdk-dev] [PATCH v4 2/2] eal/linux: Add support for handling built-in kernel modules

2015-12-09 Thread Panu Matilainen
On 12/08/2015 05:33 PM, Kamil Rytarowski wrote: > Currently rte_eal_check_module() detects Linux kernel modules via reading > /proc/modules. Built-in ones aren't listed there and therefore they are not > being found by the script. > > Add support for checking built-in modules with parsing the

[dpdk-dev] [ovs-discuss] [announce] driverctl: utility for persistent alternative driver binding

2015-12-08 Thread Panu Matilainen
On 12/04/2015 05:44 PM, Gray, Mark D wrote: > I welcome this initiative, one question below: > >> -Original Message- >> From: discuss [mailto:discuss-bounces at openvswitch.org] On Behalf Of Panu >> Matilainen >> Sent: Friday, December 4, 2015 10:54 AM

[dpdk-dev] [PATCH v2] mk: fix external shared library dependencies of libraries

2015-12-08 Thread Panu Matilainen
, shared libraries should always know their own dependencies for sane operation. Linking with the combined library (whether shared or not) still requires knowing the internal dependencies, and intra-dpdk dependencies are also not currently recorded. Signed-off-by: Panu Matilainen --- v2: - clean up

[dpdk-dev] [PATCH] mk: fix external shared library dependencies of libraries

2015-12-08 Thread Panu Matilainen
On 12/08/2015 12:11 PM, Thomas Monjalon wrote: > Hi Panu, > > 2015-12-08 10:30, Panu Matilainen: >> --- a/lib/librte_vhost/Makefile >> +++ b/lib/librte_vhost/Makefile >> @@ -44,10 +44,12 @@ CFLAGS += -I vhost_user >> else >> CFLAGS += -I vhost_cuse -

[dpdk-dev] [PATCH] mk: fix external shared library dependencies of libraries

2015-12-08 Thread Panu Matilainen
operation. Linking with the combined library (whether shared or not) still requires knowing the internal dependencies, and intra-dpdk dependencies are also not currently recorded. Signed-off-by: Panu Matilainen --- Note: I haven't tested on FreeBSD, it should be straightforward but it wouldn't

[dpdk-dev] [PATCH v3 2/2] eal/linux: Add support for handling built-in kernel modules

2015-12-08 Thread Panu Matilainen
On 12/07/2015 10:55 PM, Stephen Hemminger wrote: > On Mon, 7 Dec 2015 19:36:05 +0100 > Kamil Rytarowski wrote: > >> +/* Check if there is sysfs mounted */ >> +if (stat("/sys/module", ) != 0) { >> +RTE_LOG(DEBUG, EAL, "Open /sys/module failed: %s\n", >> +

[dpdk-dev] [PATCH 1/4] vhost: handle VHOST_USER_SET_LOG_BASE request

2015-12-07 Thread Panu Matilainen
On 12/07/2015 03:55 PM, Thomas Monjalon wrote: > 2015-12-07 13:41, Panu Matilainen: >> On 12/07/2015 01:28 PM, Thomas Monjalon wrote: >>> 2015-12-07 08:29, Panu Matilainen: >>>> On 12/07/2015 01:07 AM, Thomas Monjalon wrote: >>>>> 2015-12-02 15:

[dpdk-dev] [PATCH v2] scripts: support any legal git revisions as abi validation range

2015-12-07 Thread Panu Matilainen
On 12/07/2015 04:32 PM, Thomas Monjalon wrote: > 2015-12-07 16:09, Panu Matilainen: >> On 12/03/2015 04:05 PM, Panu Matilainen wrote: >>> In addition to git tags, support validating abi between any legal >>> gitrevisions(7) syntaxes, such as "validate-abi.sh -1

[dpdk-dev] [PATCH v2] scripts: support any legal git revisions as abi validation range

2015-12-07 Thread Panu Matilainen
On 12/03/2015 04:05 PM, Panu Matilainen wrote: > In addition to git tags, support validating abi between any legal > gitrevisions(7) syntaxes, such as "validate-abi.sh -1 . " > "validate-abi.sh master mybranch " etc in addition to > validating between tags. Make

[dpdk-dev] [PATCH] mk: fix warning spew when EXTRA_CFLAGS specifies warning flags

2015-12-07 Thread Panu Matilainen
ty ignored without -Wformat [-Wformat-security] Passing WERROR_FLAGS to AUTO_CPU helper makes the warning flag usage consistent throughout the codebase, silencing the warnings. Fixes: 9aa2053c6e81 ("mk: influence CPU flags with user input") Signed-off-by: Panu Matilainen --- mk/rte.c

[dpdk-dev] [PATCH] i40e: remove redundant compiler warning disablers

2015-12-07 Thread Panu Matilainen
These may have been required at some point but current i40e base driver compiles cleanly without them, at least with clang 3.7.0 and gcc 5.1.1. Signed-off-by: Panu Matilainen --- drivers/net/i40e/Makefile | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/net/i40e

[dpdk-dev] [PATCH 1/4] vhost: handle VHOST_USER_SET_LOG_BASE request

2015-12-07 Thread Panu Matilainen
On 12/07/2015 01:28 PM, Thomas Monjalon wrote: > 2015-12-07 08:29, Panu Matilainen: >> On 12/07/2015 01:07 AM, Thomas Monjalon wrote: >>> 2015-12-02 15:53, Panu Matilainen: >>>> This (and other changes in patch 2 breaks the librte_vhost ABI again, so >>>>

[dpdk-dev] [PATCH v2] mk: fix external shared library dependencies of drivers, round 2

2015-12-07 Thread Panu Matilainen
Similar to commit 5f9115e58cc6f304ff4ade694cf5823d32887d1a, but for qat and mpipe drivers. The former did not exist when the previous patch was sent and latter I just missed. Fixes: 5f9115e58cc6 ("mk: fix shared library dependencies of drivers") Signed-off-by: Panu Matilainen --- v

[dpdk-dev] [PATCH] mk: fix external shared library dependencies of drivers, round 2

2015-12-07 Thread Panu Matilainen
Similar to commit 5f9115e58cc6f304ff4ade694cf5823d32887d1a, but for qat and mpipe drivers. The former did not exist when the previous patch was sent and latter I just missed. Fixes: 5f9115e58cc6 ("mk: fix shared library dependencies of drivers") Signed-off-by: Panu Matilainen --

<    1   2   3   4   >