Re: [dpdk-dev] [PATCH] igb_uio: revert open and release operations

2017-10-20 Thread Tan, Jianfeng
Hi Ferruh & Harish, On 10/20/2017 9:15 AM, Ferruh Yigit wrote: On 10/19/2017 3:43 PM, Patil, Harish wrote: -Original Message- From: Harish Patil Date: Tuesday, October 17, 2017 at 9:50 PM To: Thomas Monjalon , Ferruh Yigit Cc: "dev@dpdk.org" , Jianfeng Tan , Jingjing Wu , "Thotton, S

Re: [dpdk-dev] [PATCH] pmd_virtio: Unchecked return value from library

2017-10-16 Thread Tan, Jianfeng
Hi Sebastian, Sorry for the late response. I missed the previous emails. On 10/16/2017 4:32 PM, Basierski, SebastianX wrote: flags = fcntl(dev->vhostfd, F_GETFL); - fcntl(dev->vhostfd, F_SETFL, flags | O_NONBLOCK); + if (fcntl(

Re: [dpdk-dev] [PATCH] igb_uio: fix compile error

2017-10-16 Thread Tan, Jianfeng
> -Original Message- > From: Wu, Jingjing > Sent: Monday, October 16, 2017 9:58 AM > To: Tan, Jianfeng > Cc: dev@dpdk.org; Wu, Jingjing > Subject: [PATCH] igb_uio: fix compile error > > Compile fails when kernel version is <= 3.17 with error: > "deref

Re: [dpdk-dev] [PATCH v7 0/4] move vdev into drivers/bus

2017-10-13 Thread Tan, Jianfeng
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, October 13, 2017 4:27 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; jblu...@infradead.org; Richardson, Bruce; Ananyev, > Konstantin; De Lara Guarch, Pablo; y...@fridaylinux.o

Re: [dpdk-dev] [PATCH v5 3/5] bus: introduce new log type for bus drivers

2017-10-11 Thread Tan, Jianfeng
On 10/11/2017 7:20 PM, Shreyansh Jain wrote: On Wednesday 11 October 2017 04:12 PM, Tan, Jianfeng wrote: On 10/11/2017 2:54 PM, Shreyansh Jain wrote: Hello Jianfeng, On Monday 09 October 2017 04:57 PM, Jianfeng Tan wrote: [...] -#define PMD_DRV_LOG(level, fmt, args

Re: [dpdk-dev] [PATCH 2/2] net: enable IOVA mode for PMDs

2017-10-11 Thread Tan, Jianfeng
On 10/11/2017 6:43 PM, Burakov, Anatoly wrote: On 11-Oct-17 11:33 AM, Jianfeng Tan wrote: If we want to enable IOVA mode, introduced by commit 93878cf0255e ("eal: introduce helper API for IOVA mode"), we need PMDs (for PCI devices) to expose this flag. Signed-off-by: Jianfeng Tan --- Is th

Re: [dpdk-dev] [PATCH v5 3/5] bus: introduce new log type for bus drivers

2017-10-11 Thread Tan, Jianfeng
On 10/11/2017 2:54 PM, Shreyansh Jain wrote: Hello Jianfeng, On Monday 09 October 2017 04:57 PM, Jianfeng Tan wrote: [...] -#define PMD_DRV_LOG(level, fmt, args...) \ -PMD_DRV_LOG_RAW(level, fmt "\n", ## args) +#define FSLMC_VFIO_LOG(level, fmt, args...) \ +RTE_LOG(level, EAL, "%s(

Re: [dpdk-dev] [PATCH v10 3/9] linuxapp/eal_pci: get iommu class

2017-10-11 Thread Tan, Jianfeng
> > Then how about we enable this, iova=va, if only all PCI devices are binded > to vfio-pci (iommu mode)? > > Right, same I proposed (I guess) in v2 such that iova bus autodetecting in > case see all device bound > to vfio-pci then autoselect iova=va, in v3 series (I guess) discussion: it was >

Re: [dpdk-dev] [PATCH v10 3/9] linuxapp/eal_pci: get iommu class

2017-10-11 Thread Tan, Jianfeng
> -Original Message- > From: santosh [mailto:santosh.shu...@caviumnetworks.com] > Sent: Wednesday, October 11, 2017 1:38 PM > To: Tan, Jianfeng; olivier.m...@6wind.com; dev@dpdk.org > Cc: tho...@monjalon.net; jerin.ja...@caviumnetworks.com; > hemant.agra...@nxp.com;

Re: [dpdk-dev] [PATCH v10 3/9] linuxapp/eal_pci: get iommu class

2017-10-10 Thread Tan, Jianfeng
On 10/11/2017 12:43 PM, santosh wrote: On Wednesday 11 October 2017 07:17 AM, Tan, Jianfeng wrote: Hi, Nice patch series. But I still have a small question about below flag. On 10/6/2017 7:03 PM, Santosh Shukla wrote: Get iommu class of PCI device on the bus and returns preferred iova

Re: [dpdk-dev] [PATCH v10 3/9] linuxapp/eal_pci: get iommu class

2017-10-10 Thread Tan, Jianfeng
Hi, Nice patch series. But I still have a small question about below flag. On 10/6/2017 7:03 PM, Santosh Shukla wrote: Get iommu class of PCI device on the bus and returns preferred iova mapping mode for that bus. Patch also introduces RTE_PCI_DRV_IOVA_AS_VA drv flag. Flag used when driver ne

Re: [dpdk-dev] Can xenvirt pmd work in xen guest (aka DomU) without xen-vhost in Dom0 ?

2017-10-09 Thread Tan, Jianfeng
for me, the most important thing at the moment, is to run our system on xen guest (aka DomU), with the full functions. the performance could be a secondary consideration. most of time, for our guests, full functions, with the acceptable performance, is fine. do we have plan to support xen net

Re: [dpdk-dev] [PATCH v4 0/5] move vdev into drivers/bus

2017-10-09 Thread Tan, Jianfeng
Apologize! Just found I sent out the wrong patches. Please ignore this series. > -Original Message- > From: Tan, Jianfeng > Sent: Monday, October 9, 2017 6:55 PM > To: dev@dpdk.org > Cc: jblu...@infradead.org; Richardson, Bruce; Ananyev, Konstantin; De Lara >

Re: [dpdk-dev] [PATCH v2 07/12] eal: add channel for primary/secondary communication

2017-10-08 Thread Tan, Jianfeng
Hi Jan, > -Original Message- > From: jblu...@gmail.com [mailto:jblu...@gmail.com] On Behalf Of Jan > Blunck > Sent: Thursday, October 5, 2017 8:02 PM > To: Tan, Jianfeng > Cc: dev; Richardson, Bruce; Ananyev, Konstantin; De Lara Guarch, Pablo; > Thomas Monjalon;

Re: [dpdk-dev] [PATCH v2 08/12] bus/vdev: scan and probe vdev in secondary processes

2017-10-08 Thread Tan, Jianfeng
Hi Jan, > -Original Message- > From: jblu...@gmail.com [mailto:jblu...@gmail.com] On Behalf Of Jan > Blunck > Sent: Thursday, October 5, 2017 9:05 PM > To: Tan, Jianfeng > Cc: dev; Richardson, Bruce; Ananyev, Konstantin; De Lara Guarch, Pablo; > Thomas Monjalon;

Re: [dpdk-dev] [PATCH v2 03/12] cryptodev: avoid dependency on rte_vdev.h

2017-10-08 Thread Tan, Jianfeng
Hi Jan, > -Original Message- > From: jblu...@gmail.com [mailto:jblu...@gmail.com] On Behalf Of Jan > Blunck > Sent: Thursday, October 5, 2017 9:14 PM > To: Tan, Jianfeng > Cc: dev; Richardson, Bruce; Ananyev, Konstantin; De Lara Guarch, Pablo; > Thomas Monjalon;

Re: [dpdk-dev] [PATCH v2 09/12] ethdev: support attach vdev in secondary process

2017-10-08 Thread Tan, Jianfeng
Hi Jan, > -Original Message- > From: jblu...@gmail.com [mailto:jblu...@gmail.com] On Behalf Of Jan > Blunck > Sent: Thursday, October 5, 2017 10:27 PM > To: Tan, Jianfeng > Cc: dev; Richardson, Bruce; Ananyev, Konstantin; De Lara Guarch, Pablo; > Thomas Monjalon;

Re: [dpdk-dev] Can xenvirt pmd work in xen guest (aka DomU) without xen-vhost in Dom0 ?

2017-10-08 Thread Tan, Jianfeng
Hi, On 10/8/2017 12:54 PM, Bill Bonaparte wrote: Thanks Jianfeng for taking time to reply. please allow me to briefly explain why I want to run dpdk on xen. our system is based on dpdk, which means we use dpdk as packet receive/transmit engine, and with integrated dpdk virtio/vmxnet3 driver,

Re: [dpdk-dev] Can xenvirt pmd work in xen guest (aka DomU) without xen-vhost in Dom0 ?

2017-10-01 Thread Tan, Jianfeng
On 9/30/2017 5:25 PM, Bill Bonaparte wrote: Hi Jianfeng, Thank you for replying, I appreciate so much for this. we are trying to run our dpdk application on AWS cloud which use xen platform. for this case, what should I do to support AWS cloud ? Is there any way to do this ? Sorry, I

Re: [dpdk-dev] [PATCH v2 12/12] net/vhost: support to run in the secondary process

2017-10-01 Thread Tan, Jianfeng
On 9/30/2017 7:49 PM, Yuanhan Liu wrote: On Sat, Sep 30, 2017 at 12:06:44PM , Jianfeng Tan wrote: + /* share callfd and kickfd */ + params->type = VHOST_MSG_TYPE_SET_FDS; + vring_num = rte_vhost_get_vring_num(vid); + for (i = 0; i < vring_num; i++) { +

Re: [dpdk-dev] [PATCH v2 12/12] net/vhost: support to run in the secondary process

2017-10-01 Thread Tan, Jianfeng
On 9/30/2017 7:34 PM, Yuanhan Liu wrote: On Thu, Sep 30, 2017 at 12:53:00PM +, Jianfeng Tan wrote: On 9/30/2017 4:23 PM, Yuanhan Liu wrote: On Thu, Sep 28, 2017 at 01:55:59PM +, Jianfeng Tan wrote: +static int new_device(int vid) { struct rte_eth_dev *eth_dev; @@ -610,6

Re: [dpdk-dev] [PATCH v2 12/12] net/vhost: support to run in the secondary process

2017-09-30 Thread Tan, Jianfeng
On 9/30/2017 4:23 PM, Yuanhan Liu wrote: On Thu, Sep 28, 2017 at 01:55:59PM +, Jianfeng Tan wrote: +static int new_device(int vid) { struct rte_eth_dev *eth_dev; @@ -610,6 +685,8 @@ new_device(int vid) _rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_INTR_LSC,

Re: [dpdk-dev] [PATCH 10/12] vhost: support to kick in secondary process

2017-09-30 Thread Tan, Jianfeng
On 9/30/2017 4:18 PM, Yuanhan Liu wrote: On Thu, Sep 28, 2017 at 08:09:38AM +, Tan, Jianfeng wrote: Actually, the key (and typical) issue of multi-process here is the fds are process specific, while they are stored in the shared memory. That means only one will take effect eventually

Re: [dpdk-dev] [PATCH v2 12/12] net/vhost: support to run in the secondary process

2017-09-30 Thread Tan, Jianfeng
On 9/30/2017 4:16 PM, Yuanhan Liu wrote: On Sat, Sep 30, 2017 at 12:03:33PM +0800, Tan, Jianfeng wrote: + if (rte_eal_mp_sendmsg("vhost pmd", params, sizeof(*params) + len, To me, it's not a good idea to identify an object by a string. The common practice is to use a

Re: [dpdk-dev] Can xenvirt pmd work in xen guest (aka DomU) without xen-vhost in Dom0 ?

2017-09-30 Thread Tan, Jianfeng
Hi Bill On 9/30/2017 4:47 PM, Bill Bonaparte wrote: Hi, everybody: I am trying to run dpdk in xen guest, after trying dpdk17.05 without success, I tried dpdk16.04 again. and it's sucessful to run testpmd this time. but it can't receive any packets. the command I used is : ./testpmd

Re: [dpdk-dev] [PATCH v2 07/12] eal: add channel for primary/secondary communication

2017-09-29 Thread Tan, Jianfeng
On 9/29/2017 6:00 PM, Burakov, Anatoly wrote: On 29-Sep-17 2:03 AM, Tan, Jianfeng wrote: + Reshma and Jan. -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Burakov, Anatoly Sent: Thursday, September 28, 2017 11:30 PM To: dev@dpdk.org Subject: Re: [dpdk-dev

Re: [dpdk-dev] [PATCH v2 12/12] net/vhost: support to run in the secondary process

2017-09-29 Thread Tan, Jianfeng
Hi Yuanhan, On 9/29/2017 4:28 PM, Yuanhan Liu wrote: On Thu, Sep 28, 2017 at 01:55:59PM +, Jianfeng Tan wrote: static int +share_device(int vid) +{ + uint32_t i, vring_num; + int len; + int fds[8]; + struct rte_vhost_memory *mem; + struct vhost_params *param

Re: [dpdk-dev] [PATCH v2 07/12] eal: add channel for primary/secondary communication

2017-09-28 Thread Tan, Jianfeng
ion > > On 28-Sep-17 4:01 PM, Ananyev, Konstantin wrote: > > Hi Jianfeng, > > > > > >> -Original Message- > >> From: Tan, Jianfeng > >> Sent: Thursday, September 28, 2017 2:56 PM > >> To: dev@dpdk.org > >> Cc: Richardson

Re: [dpdk-dev] [PATCH 06/12] eal: add channel for primary/secondary communication

2017-09-28 Thread Tan, Jianfeng
Yuanhan, Thank you for the detailed review! Most of your suggestions are very good and I'll fix them in next version. > -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Wednesday, September 27, 2017 8:20 PM > To: Tan, Jianfeng > Cc: dev@

Re: [dpdk-dev] [PATCH 10/12] vhost: support to kick in secondary process

2017-09-28 Thread Tan, Jianfeng
> -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Wednesday, September 27, 2017 5:36 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; maxime.coque...@redhat.com; mtetsu...@gmail.com > Subject: Re: [PATCH 10/12] vhost: support to kick in seconda

Re: [dpdk-dev] [PATCH 10/12] vhost: support to kick in secondary process

2017-09-27 Thread Tan, Jianfeng
> -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Wednesday, September 27, 2017 5:36 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; maxime.coque...@redhat.com; mtetsu...@gmail.com > Subject: Re: [PATCH 10/12] vhost: support to kick in seconda

Re: [dpdk-dev] [PATCH] vhost: fix vhost_user_set_mem_table error

2017-09-21 Thread Tan, Jianfeng
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yi Yang > Sent: Wednesday, September 20, 2017 4:32 PM > To: y...@fridaylinux.org > Cc: dev@dpdk.org; Yang, Yi Y > Subject: [dpdk-dev] [PATCH] vhost: fix vhost_user_set_mem_table error > > Usually vhost_user messa

Re: [dpdk-dev] [PATCH 10/12] vhost: support to kick in secondary process

2017-09-21 Thread Tan, Jianfeng
> -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Thursday, September 21, 2017 5:18 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; maxime.coque...@redhat.com; mtetsu...@gmail.com > Subject: Re: [PATCH 10/12] vhost: support to kick in secondary p

Re: [dpdk-dev] [PATCH 10/12] vhost: support to kick in secondary process

2017-09-21 Thread Tan, Jianfeng
On 9/21/2017 11:33 AM, Yuanhan Liu wrote: Firstly, very sorry for so late review! That is understood. On Fri, Aug 25, 2017 at 09:40:50AM +, Jianfeng Tan wrote: To support kick in secondary process, we propose callfd_pri and kickfd_pri to store the value in primary process; and by a ne

Re: [dpdk-dev] [PATCH 06/12] eal: add channel for primary/secondary communication

2017-09-20 Thread Tan, Jianfeng
Hi Jiayu, On 9/20/2017 11:00 AM, Jiayu Hu wrote: Hi Jianfeng, Few questions are inline. Thanks, Jiayu On Fri, Aug 25, 2017 at 09:40:46AM +, Jianfeng Tan wrote: Previouly, there is only one way for primary/secondary to exchange messages, that is, primary process writes info into some pre

Re: [dpdk-dev] [PATCH 06/12] eal: add channel for primary/secondary communication

2017-09-20 Thread Tan, Jianfeng
Hi Jiayu, On 9/18/2017 9:49 PM, Jiayu Hu wrote: Hi Jianfeng, On Fri, Aug 25, 2017 at 09:40:46AM +, Jianfeng Tan wrote: Previouly, there is only one way for primary/secondary to exchange messages, that is, primary process writes info into some predefind file, and secondary process reads i

Re: [dpdk-dev] [PATCH] pmd_virtio: Buffer not null terminated

2017-09-20 Thread Tan, Jianfeng
> -Original Message- > From: Basierski, SebastianX > Sent: Wednesday, September 20, 2017 5:20 PM > To: Tan, Jianfeng; skh...@vmware.com > Cc: dev@dpdk.org > Subject: RE: [PATCH] pmd_virtio: Buffer not null terminated > ... > > > Hi, > > I don'

Re: [dpdk-dev] [PATCH] net/virtio: fix of untrusted scalar value

2017-09-20 Thread Tan, Jianfeng
Hi, > -Original Message- > From: Mrzyglod, DanielX T > Sent: Wednesday, September 20, 2017 5:19 PM > To: y...@fridaylinux.org > Cc: dev@dpdk.org; Mrzyglod, DanielX T; Tan, Jianfeng > Subject: [PATCH] net/virtio: fix of untrusted scalar value > > The unscrutinized

Re: [dpdk-dev] [PATCH v4 3/5] gso: add VxLAN GSO support

2017-09-19 Thread Tan, Jianfeng
On 9/19/2017 3:32 PM, Jiayu Hu wrote: From: Mark Kavanagh This patch adds GSO support for VxLAN-encapsulated packets. Supported VxLAN packets must have an outer IPv4 header (prepended by an optional VLAN tag), and contain an inner TCP/IPv4 packet (with an optional inner VLAN tag). This patch

Re: [dpdk-dev] [PATCH v4 4/5] gso: add GRE GSO support

2017-09-19 Thread Tan, Jianfeng
Hi, On 9/19/2017 3:32 PM, Jiayu Hu wrote: From: Mark Kavanagh This patch adds GSO support for GRE-tunneled packets. Supported GRE packets must contain an outer IPv4 header, and inner TCP/IPv4 headers. They may also contain a single VLAN tag. GRE GSO doesn't check if all input packets have cor

Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix not working on 32-bit system

2017-09-19 Thread Tan, Jianfeng
Hi Jim, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jim Murphy > Sent: Wednesday, September 20, 2017 6:24 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/virtio-user: fix not working on 32-bit > system > > Hi, > > The fix contained in this patch

Re: [dpdk-dev] [PATCH] pmd_virtio: Unchecked return value from library

2017-09-19 Thread Tan, Jianfeng
Hi, Thank you for those fixes. > -Original Message- > From: Basierski, SebastianX > Sent: Tuesday, September 19, 2017 7:47 PM > To: skh...@vmware.com > Cc: Basierski, SebastianX; Tan, Jianfeng; dev@dpdk.org > Subject: [PATCH] pmd_virtio: Unchecked return value from

Re: [dpdk-dev] [PATCH] pmd_virtio: Buffer not null terminated

2017-09-19 Thread Tan, Jianfeng
> -Original Message- > From: Basierski, SebastianX > Sent: Tuesday, September 19, 2017 7:41 PM > To: skh...@vmware.com > Cc: Basierski, SebastianX; Tan, Jianfeng; dev@dpdk.org > Subject: [PATCH] pmd_virtio: Buffer not null terminated > > Fix calling strncpy with

Re: [dpdk-dev] [PATCH 04/12] vdev: move to drivers/bus

2017-09-18 Thread Tan, Jianfeng
Hi Pablo > -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, September 18, 2017 7:48 PM > To: Tan, Jianfeng; Gaëtan Rivet > Cc: dev@dpdk.org; Richardson, Bruce; Ananyev, Konstantin; > tho...@monjalon.net; y...@fridaylinux.org; maxime.coque...@re

Re: [dpdk-dev] [PATCH 12/12] examples/helloworld: do not exit automatically

2017-09-18 Thread Tan, Jianfeng
Hi Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, September 18, 2017 7:44 PM > To: Tan, Jianfeng; dev@dpdk.org > Cc: Richardson, Bruce; Ananyev, Konstantin; tho...@monjalon.net; > y...@fridaylinux.org; maxime.coque...@redhat.com; mtetsu...@

Re: [dpdk-dev] long initialization of rte_eal_hugepage_init

2017-09-06 Thread Tan, Jianfeng
> -Original Message- > From: 王志克 [mailto:wangzh...@jd.com] > Sent: Wednesday, September 6, 2017 2:03 PM > To: Tan, Jianfeng; us...@dpdk.org; dev@dpdk.org > Subject: RE: long initialization of rte_eal_hugepage_init > > Do you mean "pagesize" when you say

Re: [dpdk-dev] long initialization of rte_eal_hugepage_init

2017-09-05 Thread Tan, Jianfeng
> -Original Message- > From: users [mailto:users-boun...@dpdk.org] On Behalf Of ??? > Sent: Wednesday, September 6, 2017 11:25 AM > To: us...@dpdk.org; dev@dpdk.org > Subject: [dpdk-users] long initialization of rte_eal_hugepage_init > > Hi All, > > I observed that rte_eal_hugepage_init

Re: [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support

2017-09-05 Thread Tan, Jianfeng
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, September 5, 2017 3:31 PM > To: Tan, Jianfeng > Cc: Richardson, Bruce; dev@dpdk.org; xen-de...@lists.xenproject.org; > Mcnamara, John; joao.m.mart...@oracle.com; > jerin.ja.

Re: [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support

2017-09-04 Thread Tan, Jianfeng
> -Original Message- > From: Richardson, Bruce > Sent: Monday, September 4, 2017 10:49 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; xen-de...@lists.xenproject.org; tho...@monjalon.net; > Mcnamara, John; joao.m.mart...@oracle.com; > jerin.ja...@caviumnetworks.com;

Re: [dpdk-dev] [PATCH v3] eal: add counter size for efd clean

2017-09-03 Thread Tan, Jianfeng
> -Original Message- > From: Wu, Jingjing > Sent: Thursday, August 24, 2017 10:11 AM > To: Tan, Jianfeng > Cc: Wu, Jingjing; dev@dpdk.org > Subject: [PATCH v3] eal: add counter size for efd clean > > For virtual device, the rte_intr_handle struct is > initia

Re: [dpdk-dev] [PATCH 04/12] vdev: move to drivers/bus

2017-08-29 Thread Tan, Jianfeng
Hi Gaetan, On 8/29/2017 6:04 AM, Gaëtan Rivet wrote: On Fri, Aug 25, 2017 at 09:40:44AM +, Jianfeng Tan wrote: Move the vdev bus from lib/librte_eal to drivers/bus. As the crypto vdev helper function refers to data structure in rte_vdev.h, so we move those helper function into drivers/bus

Re: [dpdk-dev] [PATCH 05/12] bus/vdev: change log type from EAL to PMD

2017-08-29 Thread Tan, Jianfeng
On 8/29/2017 5:54 AM, Gaëtan Rivet wrote: On Fri, Aug 25, 2017 at 09:40:45AM +, Jianfeng Tan wrote: Signed-off-by: Jianfeng Tan --- drivers/bus/vdev/vdev.c | 10 ++ drivers/bus/vdev/vdev_logs.h | 40 2 files changed, 46 insertions(

Re: [dpdk-dev] [PATCH 02/12] eal: avoid calling rte_vdev_init()

2017-08-29 Thread Tan, Jianfeng
Hi Gaetan, On 8/29/2017 5:50 AM, Gaëtan Rivet wrote: Hi, On Fri, Aug 25, 2017 at 09:40:42AM +, Jianfeng Tan wrote: We can call bus->plug() to avoid calling rte_vdev_init() explicitly. Signed-off-by: Jianfeng Tan --- lib/librte_eal/common/eal_common_dev.c | 21 + 1

Re: [dpdk-dev] [PATCH v2] eal: add counter size for efd clean

2017-08-14 Thread Tan, Jianfeng
On 8/13/2017 8:03 AM, Jingjing Wu wrote: For virtual device, the rte_intr_handle struct is initialized by the virtual device driver, including the event fd assignment. If the event fd need to be read for clean, an argument is required for the proper event fd read. This patch adds efd_counter_s

Re: [dpdk-dev] [PATCH] doc: announce API and ABI change for ethdev

2017-08-03 Thread Tan, Jianfeng
On 7/12/2017 12:58 AM, Zhiyong Yang wrote: This is an API/ABI change notice for DPDK 17.11 on redefinition of A nit: we usually don't indent at the commit message paragraph. port_id. port_id is defined as uint8_t by now, which is just ranged from 0 to 255. For more and more scenerioes, m

Re: [dpdk-dev] [PATCH] doc: deprecate Xen dom0 support

2017-08-03 Thread Tan, Jianfeng
Hi Thomas, On 8/3/2017 7:49 AM, Thomas Monjalon wrote: Following the calls on the mailing list: http://dpdk.org/ml/archives/dev/2017-June/068151.html The Technical Board decided to drop Xen dom0 support from EAL: http://dpdk.org/ml/archives/dev/2017-June/068615.html As dom0 is

Re: [dpdk-dev] [PATCH] net/virtio: fix fail to configure rxq interrupt

2017-07-19 Thread Tan, Jianfeng
On 7/19/2017 4:08 AM, Yuanhan Liu wrote: On Wed, Jul 19, 2017 at 11:18:23AM +0800, Jiayu Hu wrote: When use rte_eth_dev_configure() to enable rx queue interrupt for virtio devices, virtio_configure_intr() isn't called to set up the interrupt environment, which causes rx queue interrupt setup f

Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary process

2017-07-12 Thread Tan, Jianfeng
> -Original Message- > From: Gonzalez Monroy, Sergio > Sent: Wednesday, July 12, 2017 3:32 PM > To: Tan, Jianfeng; Stephen Hemminger; dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary > process > > On 12/07/2017 03

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-11 Thread Tan, Jianfeng
> -Original Message- > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > Sent: Friday, July 7, 2017 7:14 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh; Gregory Etelson; Thomas Monjalon; Stephen Hemminger; > Tan, Jianfeng; Lu, Wenzhuo > Subject: [PATCH v

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-11 Thread Tan, Jianfeng
> -Original Message- > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > Sent: Monday, July 10, 2017 6:43 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; Yigit, Ferruh; Gregory Etelson; Thomas Monjalon; > Stephen Hemminger; Lu, Wenzhuo > Subject: R

Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary process

2017-07-11 Thread Tan, Jianfeng
> -Original Message- > From: Gonzalez Monroy, Sergio > Sent: Tuesday, July 11, 2017 7:36 PM > To: Tan, Jianfeng; Stephen Hemminger; dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary > process > > On 11/07/2017 02

Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary process

2017-07-10 Thread Tan, Jianfeng
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen > Hemminger > Sent: Tuesday, July 11, 2017 9:13 AM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [RFC] pci: force address of mappings in secondary > process > > The PCI memory resources

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-10 Thread Tan, Jianfeng
> -Original Message- > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > Sent: Monday, July 10, 2017 3:11 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; Yigit, Ferruh; Gregory Etelson; Thomas Monjalon; > Stephen Hemminger; Lu, Wenzhuo > Subject: R

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-09 Thread Tan, Jianfeng
Hi Thotton, > -Original Message- > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > Sent: Friday, July 7, 2017 7:14 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh; Gregory Etelson; Thomas Monjalon; Stephen Hemminger; > Tan, Jianfeng; Lu, Wenzhuo > Subjec

Re: [dpdk-dev] [PATCH v12 2/3] lib/gro: add TCP/IPv4 GRO support

2017-07-08 Thread Tan, Jianfeng
On 7/7/2017 6:39 PM, Jiayu Hu wrote: In this patch, we introduce five APIs to support TCP/IPv4 GRO. - gro_tcp4_reassemble: reassemble an inputted TCP/IPv4 packet. - gro_tcp4_tbl_create: create a TCP/IPv4 reassembly table, which is used to merge packets. - gro_tcp4_tbl_destroy: free memory

Re: [dpdk-dev] [PATCH v12 1/3] lib: add Generic Receive Offload API framework

2017-07-08 Thread Tan, Jianfeng
Hi Jiayu, On 7/7/2017 6:39 PM, Jiayu Hu wrote: Generic Receive Offload (GRO) is a widely used SW-based offloading technique to reduce per-packet processing overhead. It gains performance by reassembling small packets into large ones. This patchset is to support GRO in DPDK. To support GRO, this

Re: [dpdk-dev] [PATCH v11 1/3] lib: add Generic Receive Offload API framework

2017-07-07 Thread Tan, Jianfeng
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tan, Jianfeng > Sent: Friday, July 7, 2017 2:56 PM > To: Hu, Jiayu; dev@dpdk.org > Cc: Ananyev, Konstantin; y...@fridaylinux.org; > step...@networkplumber.org; Wu, Jingjing; Yao, Lei A > S

Re: [dpdk-dev] [PATCH v11 1/3] lib: add Generic Receive Offload API framework

2017-07-06 Thread Tan, Jianfeng
On 7/5/2017 12:08 PM, Jiayu Hu wrote: Generic Receive Offload (GRO) is a widely used SW-based offloading technique to reduce per-packet processing overhead. It gains performance by reassembling small packets into large ones. This patchset is to support GRO in DPDK. To support GRO, this patch im

Re: [dpdk-dev] [PATCH v11 2/3] lib/gro: add TCP/IPv4 GRO support

2017-07-06 Thread Tan, Jianfeng
On 7/5/2017 12:08 PM, Jiayu Hu wrote: In this patch, we introduce five APIs to support TCP/IPv4 GRO. - gro_tcp4_tbl_create: create a TCP/IPv4 reassembly table, which is used to merge packets. - gro_tcp4_tbl_destroy: free memory space of a TCP/IPv4 reassembly table. - gro_tcp4_tbl_timeout_f

Re: [dpdk-dev] [PATCH] eal: fix secondary process segfault on multipe virtio devices

2017-07-03 Thread Tan, Jianfeng
HI Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Saturday, July 1, 2017 10:10 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; yuanhan@linux.intel.com; > maxime.coque...@redhat.com > Subject: Re: [dpdk-dev] [PATCH] eal:

Re: [dpdk-dev] [PATCH v10 1/3] lib: add Generic Receive Offload API framework

2017-07-02 Thread Tan, Jianfeng
On 7/1/2017 7:08 PM, Jiayu Hu wrote: Generic Receive Offload (GRO) is a widely used SW-based offloading technique to reduce per-packet processing overhead. It gains performance by reassembling small packets into large ones. This patchset is to support GRO in DPDK. To support GRO, this patch imp

Re: [dpdk-dev] [PATCH v10 2/3] lib/gro: add TCP/IPv4 GRO support

2017-07-02 Thread Tan, Jianfeng
On 7/1/2017 7:08 PM, Jiayu Hu wrote: In this patch, we introduce five APIs to support TCP/IPv4 GRO. - gro_tcp4_tbl_create: create a TCP/IPv4 reassembly table, which is used to merge packets. - gro_tcp4_tbl_destroy: free memory space of a TCP/IPv4 reassembly table. - gro_tcp4_tbl_timeout_fl

Re: [dpdk-dev] [PATCH] vhost: fix checking of device features

2017-06-29 Thread Tan, Jianfeng
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Thursday, June 29, 2017 3:27 PM > To: Tan, Jianfeng; Ivan Dyukov; y...@fridaylinux.org; dev@dpdk.org > Cc: i.maxim...@samsung.com; heetae82@samsung.com; > sta...@dpdk.org > S

Re: [dpdk-dev] [PATCH] vhost: fix MTU device feature check

2017-06-29 Thread Tan, Jianfeng
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Thursday, June 29, 2017 3:58 PM > To: dev@dpdk.org; y...@fridaylinux.org > Cc: i.dyu...@samsung.com; Tan, Jianfeng; sta...@dpdk.org; Maxime > Coquelin > Subject: [PATCH] vhost: f

Re: [dpdk-dev] [PATCH] vhost: fix checking of device features

2017-06-28 Thread Tan, Jianfeng
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ivan Dyukov > Sent: Wednesday, June 28, 2017 8:41 PM > To: y...@fridaylinux.org; maxime.coque...@redhat.com; dev@dpdk.org > Cc: i.maxim...@samsung.com; heetae82@samsung.com; Ivan Dyukov; > sta...@dpdk.org > Su

Re: [dpdk-dev] bug: virtio PMD sends malformed packets for 32-bit processes on 64-bit kernel

2017-06-27 Thread Tan, Jianfeng
> -Original Message- > From: Frederico Cadete [mailto:frederico.cadete-...@oneaccess-net.com] > Sent: Tuesday, June 27, 2017 9:32 PM > To: yuanhan@linux.intel.com; maxime.coque...@redhat.com; Tan, > Jianfeng > Cc: John Sucaet; dev@dpdk.org > Subject: Re:

Re: [dpdk-dev] bug: virtio PMD sends malformed packets for 32-bit processes on 64-bit kernel

2017-06-26 Thread Tan, Jianfeng
On 6/26/2017 4:14 PM, Frederico Cadete wrote: On Fri, 2017-06-23 at 23:36 +0800, Tan, Jianfeng wrote: Hi Cadete, On 6/22/2017 10:58 PM, Frederico Cadete wrote: Hello, I believe commit 260aae9a [1] has introduced a regression for the case of 32-bit process running on a 64-bit kernel. The

Re: [dpdk-dev] [PATCH v6 1/3] lib: add Generic Receive Offload API framework

2017-06-25 Thread Tan, Jianfeng
Hi Jiayu, On 6/23/2017 10:43 PM, Jiayu Hu wrote: Generic Receive Offload (GRO) is a widely used SW-based offloading technique to reduce per-packet processing overhead. It gains performance by reassembling small packets into large ones. This patchset is to support GRO in DPDK. To support GRO, th

Re: [dpdk-dev] [PATCH v6 2/3] lib/gro: add TCP/IPv4 GRO support

2017-06-25 Thread Tan, Jianfeng
Hi Jiayu, On 6/23/2017 10:43 PM, Jiayu Hu wrote: In this patch, we introduce five APIs to support TCP/IPv4 GRO. - gro_tcp_tbl_create: create a TCP reassembly table, which is used to merge packets. - gro_tcp_tbl_destroy: free memory space of a TCP reassembly table. - gro_tcp_tbl_flush: flus

Re: [dpdk-dev] [PATCH v6 0/3] Support TCP/IPv4 GRO in DPDK

2017-06-25 Thread Tan, Jianfeng
On 6/23/2017 10:43 PM, Jiayu Hu wrote: Generic Receive Offload (GRO) is a widely used SW-based offloading technique to reduce per-packet processing overhead. It gains performance by reassembling small packets into large ones. Therefore, we propose to support GRO in DPDK. To enable more flexibi

Re: [dpdk-dev] bug: virtio PMD sends malformed packets for 32-bit processes on 64-bit kernel

2017-06-23 Thread Tan, Jianfeng
Hi Cadete, On 6/22/2017 10:58 PM, Frederico Cadete wrote: Hello, I believe commit 260aae9a [1] has introduced a regression for the case of 32-bit process running on a 64-bit kernel. The commit is effectively casting mbuf->buf_physaddr to uintptr_t before dereferencing it. It truncates the phy

Re: [dpdk-dev] [PATCH v3 0/9] bus/pci: remove PCI bus from EAL

2017-06-23 Thread Tan, Jianfeng
Hi Thomas & Gaetan, On 6/23/2017 8:48 PM, Thomas Monjalon wrote: 23/06/2017 10:19, Gaëtan Rivet: Hi Jianfeng, On Fri, Jun 23, 2017 at 11:29:46AM +0800, Tan, Jianfeng wrote: Hi Gaetan, Do you (or anyone else) have plan to move vdev bus into drivers/bus/. It is in the roadmap for the

Re: [dpdk-dev] [PATCH v3 0/9] bus/pci: remove PCI bus from EAL

2017-06-22 Thread Tan, Jianfeng
Hi Gaetan, Do you (or anyone else) have plan to move vdev bus into drivers/bus/. Thanks, Jianfeng On 6/21/2017 7:36 AM, Gaetan Rivet wrote: This patchset moves the PCI bus out of the EAL to the drivers/bus subdirectory. Almost all dependencies have been worked out, only remains KNI to be made

Re: [dpdk-dev] [PATCH v5 2/3] lib/gro: add TCP/IPv4 GRO support

2017-06-22 Thread Tan, Jianfeng
Hi Jiayu, > -Original Message- > From: Hu, Jiayu > Sent: Thursday, June 22, 2017 4:18 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; Ananyev, Konstantin; y...@fridaylinux.org; Wiles, Keith; > Bie, Tiwei; Yao, Lei A > Subject: Re: [PATCH v5 2/3] lib/gro: add TCP/IPv4 GR

Re: [dpdk-dev] [PATCH v5 2/3] lib/gro: add TCP/IPv4 GRO support

2017-06-20 Thread Tan, Jianfeng
Hi Jiayu, On 6/20/2017 11:22 AM, Jiayu Hu wrote: Hi Jianfeng, On Mon, Jun 19, 2017 at 11:43:20PM +0800, Tan, Jianfeng wrote: On 6/18/2017 3:21 PM, Jiayu Hu wrote: In this patch, we introduce six APIs to support TCP/IPv4 GRO. Those functions are not used outside of this library. Don't

Re: [dpdk-dev] [PATCH v5 2/3] lib/gro: add TCP/IPv4 GRO support

2017-06-19 Thread Tan, Jianfeng
On 6/18/2017 3:21 PM, Jiayu Hu wrote: In this patch, we introduce six APIs to support TCP/IPv4 GRO. Those functions are not used outside of this library. Don't make it as extern visible. - gro_tcp_tbl_create: create a TCP reassembly table, which is used to merge packets. Will tcp6

Re: [dpdk-dev] [PATCH v5 1/3] lib: add Generic Receive Offload API framework

2017-06-19 Thread Tan, Jianfeng
On 6/18/2017 3:21 PM, Jiayu Hu wrote: Generic Receive Offload (GRO) is a widely used SW-based offloading technique to reduce per-packet processing overhead. It gains performance by reassembling small packets into large ones. This patchset is to support GRO in DPDK. To support GRO, this patch im

Re: [dpdk-dev] [PATCH v5 0/3] Support TCP/IPv4 GRO in DPDK

2017-06-18 Thread Tan, Jianfeng
Hi Jiayu, You need to update the document: - Release note file: release_17_08.rst. - A howto doc is welcomed. On 6/18/2017 3:21 PM, Jiayu Hu wrote: Generic Receive Offload (GRO) is a widely used SW-based offloading technique to reduce per-packet processing overhead. It gains performance by rea

Re: [dpdk-dev] [RFC PATCH] igb_uio: issue FLR during open and release of device file

2017-06-04 Thread Tan, Jianfeng
sue FLR by PMD's during init and close. > > Cc: Jianfeng Tan > > Jianfeng also implemented following patch: > http://dpdk.org/dev/patchwork/patch/17495/ > > Which also implements release and open ops, for slightly different > reason (prevent DMA access after app e

Re: [dpdk-dev] [RFC] Enable primary/secondary model for vdev

2017-05-17 Thread Tan, Jianfeng
Any comments please? > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tan, Jianfeng > Sent: Thursday, May 11, 2017 2:20 PM > To: dev@dpdk.org > Cc: Thomas Monjalon; Richardson, Bruce; Ananyev, Konstantin; Stephen > Hemminger; Yuanhan Liu; Y

Re: [dpdk-dev] [PATCH] maintainers: claim responsability for xen

2017-05-11 Thread Tan, Jianfeng
Hi Thomas and all, Apologize for being an unqualified maintainer. > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, May 5, 2017 6:04 AM > To: Joao Martins; Konrad Rzeszutek Wilk; Tan, Jianfeng > Cc: Konrad Rzeszutek Wilk; dev@dpdk

[dpdk-dev] [RFC] Enable primary/secondary model for vdev

2017-05-10 Thread Tan, Jianfeng
Hi, Status quo: Almost none of vdev supports primary/secondary model. Two exceptions are rte_ring, virtio-user (limited support). Two problems facing this issue. P1: How to attach vdev in secondary process? Previous discussion: http://dpdk.org/ml/archives/dev/2017-April/063370.html According

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix exit without freeing resources

2017-04-27 Thread Tan, Jianfeng
> -Original Message- > From: Hu, Jiayu > Sent: Friday, April 28, 2017 9:33 AM > To: dev@dpdk.org > Cc: Wu, Jingjing; sta...@dpdk.org; Tan, Jianfeng; Hu, Jiayu > Subject: [PATCH v2] app/testpmd: fix exit without freeing resources > > When testpmd exists, it free

Re: [dpdk-dev] [PATCH 2/3] net/virtio: clean up LSC setting

2017-04-27 Thread Tan, Jianfeng
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Wednesday, April 26, 2017 11:11 PM > To: Tan, Jianfeng > Cc: Yuanhan Liu; dev@dpdk.org; maxime.coque...@redhat.com; > tho...@monjalon.net > Subject: Re: [PATCH 2/3] net/virtio: clean u

Re: [dpdk-dev] [PATCH 2/3] net/virtio: clean up LSC setting

2017-04-25 Thread Tan, Jianfeng
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Wednesday, April 26, 2017 1:52 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; maxime.coque...@redhat.com; tho...@monjalon.net; > Michael S. Tsirkin > Subject: Re: [PATCH 2/3] net

Re: [dpdk-dev] [PATCH 2/3] net/virtio: clean up LSC setting

2017-04-25 Thread Tan, Jianfeng
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Wednesday, April 26, 2017 1:33 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; maxime.coque...@redhat.com; tho...@monjalon.net > Subject: Re: [PATCH 2/3] net/virtio: clean up LSC setting &

Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix not working on 32-bit system

2017-04-18 Thread Tan, Jianfeng
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Wednesday, April 19, 2017 1:54 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; olivier.m...@6wind.com; sta...@dpdk.org > Subject: Re: [PATCH v2] net/virtio-user: fix not working on 32-bit

Re: [dpdk-dev] [PATCH v3 4/8] eal: change specific log levels at startup

2017-04-18 Thread Tan, Jianfeng
On 4/18/2017 4:50 PM, Olivier MATZ wrote: Hi Jianfeng, On Fri, 14 Apr 2017 13:33:49 +0800, "Tan, Jianfeng" wrote: Hi Olivier, If I understand it correctly, this patch is to shift log level setting earlier. But we did not remove the one in eal_parse_common_option(). So we ca

Re: [dpdk-dev] [PATCH] net/virtio-user: fix not working on 32-bit system

2017-04-14 Thread Tan, Jianfeng
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Friday, April 14, 2017 3:01 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; olivier.m...@6wind.com; sta...@dpdk.org > Subject: Re: [PATCH] net/virtio-user: fix not working on 32-bit syste

Re: [dpdk-dev] [PATCH] net/virtio-user: fix not working on 32-bit system

2017-04-13 Thread Tan, Jianfeng
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Friday, April 14, 2017 2:20 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; olivier.m...@6wind.com; sta...@dpdk.org > Subject: Re: [PATCH] net/virtio-user: fix not working on 32-bit syste

<    1   2   3   4   5   6   >