On 2015/06/25 18:18, David Marchand wrote:
> On Thu, Jun 25, 2015 at 5:19 AM, Tetsuya Mukawa <mailto:mukawa at igel.co.jp>> wrote:
>
> From: "Tetsuya.Mukawa" mailto:mukawa at
> igel.co.jp>>
>
> This patch fixes following memory leaks.
>
On 2015/06/25 18:16, David Marchand wrote:
> Hello Tetsuya,
>
>
> On Thu, Jun 25, 2015 at 5:19 AM, Tetsuya Mukawa <mailto:mukawa at igel.co.jp>> wrote:
>
> From: "Tetsuya.Mukawa" mailto:mukawa at
> igel.co.jp>>
>
> This patch fixes f
sage of linuxapp.
'pci_uio_map_resource()' is implemented in both linuxapp and bsdapp,
but interface is different. The patch fixes the function of bsdapp
to do same as linuxapp. After applying it, file descriptor should be
opened and closed out of pci_map_resource().
Signed-off-by: Tetsuya Mukawa
---
lib/librt
From: "Tetsuya.Mukawa" <muk...@igel.co.jp>
To merge pci code of linuxapp and bsdapp, this patch changes names
like below.
- uio_map to pci_map
- uio_resource to mapped_pci_resource
- uio_res_list to mapped_pci_res_list
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsda
ble.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 14 +++--
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 51 ---
2 files changed, 44 insertions(+), 21 deletions(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c
b/lib/librte_eal/bsdapp/eal
From: "Tetsuya.Mukawa" <muk...@igel.co.jp>
When pci_uio_unmap_resource() is called, a file descriptor that is used
for uio configuration should be closed.
Signed-off-by: Tetsuya Mukawa
Acked-by: Stephen Hemminger
---
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 6 +-
1
From: "Tetsuya.Mukawa" <muk...@igel.co.jp>
This patch fixes coding style of below files in linuxapp and bsdapp.
- eal_pci.c
- eal_pci_uio.c
Signed-off-by: Tetsuya Mukawa
Acked-by: Stephen Hemminger
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 12 +++-
lib/librte_
This patch set cleans up pci uio implementation. These clean up are
for consolidating pci uio implementation of linuxapp and bsdapp, and
moving consolidated functions in eal common.
Because of above, this patch set tries to implement linuxapp and bsdapp
almost same.
Actual consolidations will be
Hi Jijiang,
It seems below patch introduces compile error of examples.
- a50245e examples/tep_term: initialize VXLAN sample
Here is log.
Could you please check it?
$ T=x86_64-native-linuxapp-gcc make examples -j12
== Build examples for x86_64-native-linuxapp-gcc
== cmdline
==
On 2015/06/17 20:05, Xie, Huawei wrote:
> On 6/17/2015 12:17 PM, Tetsuya Mukawa wrote:
>> On 2015/06/02 10:50, Huawei Xie wrote:
>>> rte_vhost_driver_unregister will remove the listenfd from event list, and
>>> then close it.
>>>
>>> Signed-of
On 2015/06/02 10:50, Huawei Xie wrote:
> rte_vhost_driver_unregister will remove the listenfd from event list, and
> then close it.
>
> Signed-off-by: Huawei Xie
> Signed-off-by: Peng Sun
> ---
>
> +/**
> + * Unregister the specified vhost server
> + */
> +int
>
+For example, to move a pci device under kernel management:
> +
> +.. code-block:: console
> +
> +./tools/dpdk_nic_bind.py -b ixgbe :0a:00.0
> +./tools/dpdk_nic_bind.py --status
> +
> +Network devices using DPDK-compatible driver
> +
> +
> +
> +Network devices using kernel driver
> +===
> +:0a:00.0 '82599ES 10-Gigabit SFI/SFP+ Network Connection' if=eth2
> drv=ixgbe unused=igb_uio
> +
> +To remove a port created by a virtual device, above steps are not needed.
>
> port start
> ~~
Acked-by: Tetsuya Mukawa
The patch fixes potential null pointer accesses in test_mbuf.
if 'm[i]' is null, stop accessing it.
Signed-off-by: Tetsuya Mukawa
---
app/test/test_mbuf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
index 5e8a377..5d13b37 100644
--- a/app
On 2015/06/11 17:34, Thomas Monjalon wrote:
> 2015-06-11 10:30, Tetsuya Mukawa:
>> On 2015/06/11 3:39, Thomas Monjalon wrote:
>>> Hi,
>>>
>>> As described in the roadmap (http://dpdk.org/dev/roadmap),
>>> starting from this week,
>>> every n
On 2015/06/11 3:39, Thomas Monjalon wrote:
> Hi,
>
> As described in the roadmap (http://dpdk.org/dev/roadmap),
> starting from this week,
> every new feature submission will be postponed to release 2.2.
> The below features, which were submitted earlier, will be accepted in
> the release 2.1 if
Hi Maciej,
I guess it's nice to make sure guest memory is actually allocated by
hugepages.
So please check like below.
$ cat /sys/kernel/mm/hugepage/x/free_hugepages
$ ./start_qemu.sh
$ cat /sys/kernel/mm/hugepage/x/free_hugepages
If qemu guest allocates memory from hugepages, 2nd cat
()
- rte_eal_pci_probe_one()
- rte_eal_pci_scan()
- rte_eal_vdev_init()
- rte_eal_vdev_uninit()
Signed-off-by: Tetsuya Mukawa
---
config/common_bsdapp | 6 --
config/common_linuxapp| 5 -
lib/librte_eal/bsdapp/eal/eal_pci.c | 6 +++---
lib
The patch consolidates below functions, and implement these
in eal_common_pci_uio.c.
- pci_uio_map_secondary()
- pci_uio_map_resource()
- pci_uio_unmap()
- pci_uio_find_resource()
- pci_uio_unmap_resource()
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/Makefile
The patch consolidates below functions, and implemented in common
eal code.
- pci_map_resource()
- pci_unmap_resource()
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c| 22
lib/librte_eal/common/eal_common_pci.c | 42
The patch consolidates below functions, and implemented in common
eal code.
- pci_map_device()
- pci_unmap_device()
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 12 +++
lib/librte_eal/common/eal_common_pci.c | 57 +
lib
to
linuxapp one with later patch.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c| 74 ++---
lib/librte_eal/common/eal_common_pci.c | 129
lib/librte_eal/common/eal_private.h| 21 ++---
lib/librte_eal/linuxapp/eal/eal_pci.c | 148
This patch consolidates below structures, and defines them in common code.
- struct pci_map
- strucy mapped_pci_resouces
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c| 24
lib/librte_eal/common/include/rte_pci.h| 28
This patch adds a new function called pci_uio_map_resource_by_index().
The function hides how to map uio resource in linuxapp and bsdapp.
With the function, pci_uio_map_resource() will be more abstracted.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 107
This patch adds a new function called pci_uio_alloc_uio_resource().
The function hides how to prepare uio resource in linuxapp and bsdapp.
With the function, pci_uio_map_resource() will be more abstracted.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 70
and BSD code.
Tetsuya Mukawa (8):
eal: Add pci_uio_alloc_uio_resource()
eal: Add pci_uio_map_uio_resource_by_index()
eal: Consolidate pci_map and mapped_pci_resource of linuxapp and
bsdapp
eal: Consolidate rte_eal_pci_probe/close_one_driver() of linuxapp and
bsdapp
eal: Consolidate
Hi Bernard,
I've updated the series, because I've found the issue in BSD code.
Also, I have rebased the series for latest master branch.
Could you please read my below comments?
On 2015/05/19 14:54, Tetsuya Mukawa wrote:
> This patch set cleans up pci uio implementation. These clean
and bsdapp,
but interface is different. The patch fixes the function of bsdapp
to do same as linuxapp. After applying it, file descriptor should be
opened and closed out of pci_map_resource().
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 118
To merge pci code of linuxapp and bsdapp, this patch changes names
like below.
- uio_map to pci_map
- uio_resource to mapped_pci_resource
- uio_res_list to mapped_pci_res_list
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 24
1 file changed
be freed.
Also, fixes below.
- When pci_map_resource() is failed, mapaddr will be MAP_FAILED.
In this case, pci_map_addr should not be incremented in
pci_uio_map_resource().
- To shrink code, move close().
- Remove fail variable.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal
When pci_uio_unmap_resource() is called, a file descriptor that is used
for uio configuration should be closed.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/linuxapp/eal
This patch fixes coding style of below files in linuxapp and bsdapp.
- eal_pci.c
- eal_pci_uio.c
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 24 +---
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 12
2 files changed, 21
le fixings.
- Fix coding style of if-else condition.
(Thanks to Richardson, Bruce)
Tetsuya Mukawa (5):
eal: Fix coding style of eal_pci.c and eal_pci_uio.c
eal: Close file descriptor of uio configuration
eal: Fix memory leaks and needless increment of pci_map_addr
eal/bsdapp: Change na
x on ICC 13.0.0
> i40e: compile fix on clang 3.3
>
> lib/librte_pmd_i40e/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Acked-by: Tetsuya Mukawa
Hi Helin,
It seems master branch cannot be compiled with icc like below.
$ T=x86_64-native-linuxapp-icc make install
...snip
dpdk/lib/librte_pmd_i40e/i40e/i40e_nvm.c(1022): error #188: enumerated
type mixed with another type
hw->aq.asq_last_status = old_asq_status;
As a
On 2015/04/21 22:15, Iremonger, Bernard wrote:
>> -Original Message-
>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>> Sent: Friday, March 27, 2015 8:39 AM
>> To: dev at dpdk.org
>> Cc: Iremonger, Bernard; Richardson, Bruce; david.marchand at 6wind.com;
On 2015/04/01 18:29, De Lara Guarch, Pablo wrote:
> Hi Tetsuya,
>
>> -Original Message-
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa
>> Sent: Wednesday, April 01, 2015 10:18 AM
>> To: Mcnamara, John
>> Cc: dev at dpdk.org
>
Hi John,
It seems after applying following patch, I cannot build doc.
ebf8050 doc: add pdf output
---
$ T=x86_64-native-linuxapp-gcc make doc
(snip)
lookup cache used 2433/65536 hits=6354 misses=2576
finished...
sphinx processing guides-html...
sphinx processing
structure.
'pci_uio_map_resource()' is implemented in both linuxapp and bsdapp,
but interface is different. The patch fixes the function of bsdapp
to do same as linuxapp. After applying it, file descriptor should be
opened and closed out of pci_map_resource().
Signed-off-by: Tetsuya Mukawa
---
lib
To merge pci code of linuxapp and bsdapp, this patch changes names
like below.
- uio_map to pci_map
- uio_resource to mapped_pci_resource
- uio_res_list to mapped_pci_res_list
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 24
1 file changed
be freed.
Also, fixes below.
- When pci_map_resource() is failed, mapaddr will be MAP_FAILED.
In this case, pci_map_addr should not be incremented in
pci_uio_map_resource().
- To shrink code, move close().
- Remove fail variable.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal
When pci_uio_unmap_resource() is called, a file descriptor that is used
for uio configuration should be closed.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/linuxapp/eal
This patch fixes coding style of below files in linuxapp and bsdapp.
- eal_pci.c
- eal_pci_uio.c
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 24 +---
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 12
2 files changed, 21
Port Hotplug support for BSD"
- Set cfg_fd as -1, when cfg_fd is closed.
(Thanks to Iremonger, Bernard)
- Remove needless coding style fixings.
- Fix coding style of if-else condition.
(Thanks to Richardson, Bruce)
Tetsuya Mukawa (5):
eal: Fix coding style of eal_pci.c and eal
On 2015/03/26 19:41, Iremonger, Bernard wrote:
>
>> -Original Message-
>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>> Sent: Thursday, March 26, 2015 2:51 AM
>> To: Iremonger, Bernard; dev at dpdk.org
>> Cc: Richardson, Bruce; david.marchand at 6w
On 2015/03/26 19:03, Iremonger, Bernard wrote:
>
>> -Original Message-
>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>> Sent: Thursday, March 26, 2015 4:19 AM
>> To: Stephen Hemminger
>> Cc: Iremonger, Bernard; david.marchand at 6wind.com; dev at d
On 2015/03/25 14:07, Stephen Hemminger wrote:
> On Wed, 25 Mar 2015 12:17:32 +0900
> Tetsuya Mukawa wrote:
>
>> On 2015/03/25 3:33, Stephen Hemminger wrote:
>>> On Tue, 24 Mar 2015 13:18:33 +0900
>>> Tetsuya Mukawa wrote:
>>>
>>>> When
On 2015/03/26 0:27, Iremonger, Bernard wrote:
>
>> -Original Message-
>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>> Sent: Tuesday, March 24, 2015 4:19 AM
>> To: dev at dpdk.org
>> Cc: Iremonger, Bernard; Richardson, Bruce; david.marchand
On 2015/03/26 0:00, Iremonger, Bernard wrote:
>
>> -Original Message-
>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>> Sent: Tuesday, March 24, 2015 4:19 AM
>> To: dev at dpdk.org
>> Cc: Iremonger, Bernard; Richardson, Bruce; david.marchand
On 2015/03/25 3:33, Stephen Hemminger wrote:
> On Tue, 24 Mar 2015 13:18:33 +0900
> Tetsuya Mukawa wrote:
>
>> When pci_uio_unmap_resource() is called, a file descriptor that is used
>> for uio configuration should be closed.
>>
>> Signed-off-by: Tetsuya Mukawa
&
-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 111 ++
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 21 +++---
2 files changed, 77 insertions(+), 55 deletions(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c
b/lib/librte_eal/bsdapp/eal
This patch changes code that maps pci resources in bsdapp.
Linuxapp has almost same code. To consolidate both, fix implementation
of bsdapp to work same as linuxapp.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 24
1 file changed, 12
To merge pci code of linuxapp and bsdapp, this patch changes names
like below.
- uio_map to pci_map
- uio_resource to mapped_pci_resource
- uio_res_list to mapped_pci_res_list
Also, add 'path' variable to pci_map of bsdapp.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal
, fixes below.
- When pci_map_resource() is failed, mapaddr will be MAP_FAILED.
In this case, pci_map_addr should not be incremented in
pci_uio_map_resource().
- To shrink code, move close().
- Remove fail variable.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal/eal_pci_uio.c
When pci_uio_unmap_resource() is called, a file descriptor that is used
for uio configuration should be closed.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/linuxapp/eal
This patch fixes coding style of below files in linuxapp and bsdapp.
- eal_pci.c
- eal_pci_uio.c
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 24 +---
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 12
2 files changed, 21
On 2015/03/20 18:53, Iremonger, Bernard wrote:
>> -Original Message-
>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>> Sent: Tuesday, March 17, 2015 9:31 AM
>> To: dev at dpdk.org
>> Cc: Iremonger, Bernard; Richardson, Bruce; Tetsuya Mukawa
>> Sub
is derived from below.
"[PATCH v2] eal: Port Hotplug support for BSD"
- Set cfg_fd as -1, when cfg_fd is closed.
(Thanks to Iremonger, Bernard)
- Remove needless coding style fixings.
- Fix coding style of if-else condition.
(Thanks to Richardson, Bruce)
Tetsuya Mukawa (6):
On 2015/03/20 1:20, Iremonger, Bernard wrote:
>
>> -Original Message-
>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>> Sent: Tuesday, March 17, 2015 9:31 AM
>> To: dev at dpdk.org
>> Cc: Iremonger, Bernard; Richardson, Bruce; Tetsuya Mukawa
>&g
On 2015/03/20 1:04, Iremonger, Bernard wrote:
>> -Original Message-
>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>> Sent: Tuesday, March 17, 2015 9:31 AM
>> To: dev at dpdk.org
>> Cc: Iremonger, Bernard; Richardson, Bruce; Tetsuya Mukawa
>>
On 2015/03/19 0:39, David Marchand wrote:
> On Tue, Mar 17, 2015 at 10:30 AM, Tetsuya Mukawa <mailto:mukawa at igel.co.jp>> wrote:
>
> When pci_map_resource() is failed but path is allocated correctly,
> path won't be freed. Also, when open() is failed, uio_res
On 2015/03/19 0:19, David Marchand wrote:
> On Tue, Mar 17, 2015 at 10:30 AM, Tetsuya Mukawa <mailto:mukawa at igel.co.jp>> wrote:
>
> When pci_uio_unmap_resource() is called, a file descriptor that is
> used
> for uio configuration should be closed.
>
&
-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 109 ++
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 21 +++---
2 files changed, 75 insertions(+), 55 deletions(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c
b/lib/librte_eal/bsdapp/eal
This patch changes code that maps pci resources in bsdapp.
Linuxapp has almost same code. To consolidate both, fix implementation
of bsdapp to work same as linuxapp.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 24
1 file changed, 12
To merge pci code of linuxapp and bsdapp, this patch changes names
like below.
- uio_map to pci_map
- uio_resource to mapped_pci_resource
- uio_res_list to mapped_pci_res_list
Also, add 'path' variable to pci_map of bsdapp.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal
.
Also, the patch fixes belows.
- To shrink code, move close().
- Remove fail variable.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal
When pci_uio_unmap_resource() is called, a file descriptor that is used
for uio configuration should be closed.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/linuxapp/eal
This patch fixes cording style of below files in linuxapp and bsdapp.
- eal_pci.c
- eal_pci_uio.c
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 24 +---
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 12
2 files changed, 21
(Thanks to Richardson, Bruce)
Tetsuya Mukawa (6):
eal: Fix cording style of eal_pci.c and eal_pci_uio.c
eal: Close file descriptor of uio configuration
eal: Fix memory leaks and needless incrementation of pci uio
implementation
eal/bsdapp: Change names of pci related data structure
On 2015/03/14 0:47, Iremonger, Bernard wrote:
>
>> -Original Message-
>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>> Sent: Thursday, March 12, 2015 10:18 AM
>> To: dev at dpdk.org
>> Cc: Iremonger, Bernard; Richardson, Bruce; Tetsuya Mukawa
'struct rte_kvargs' is allocated in rte_kvargs_parse(), and should be
freed with rte_kvargs_free().
This patch fixes memory leaks of 'struct rte_kvargs' in below PMDs.
- pcap PMD
- null PMD
Reported-by: Mcnamara, John
Signed-off-by: Tetsuya Mukawa
---
lib/librte_pmd_null/rte_eth_null.c | 13
On 2015/03/16 20:07, Mcnamara, John wrote:
>> -Original Message-
>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>> Sent: Monday, March 16, 2015 3:43 AM
>> To: dev at dpdk.org
>> Cc: Mcnamara, John; Tetsuya Mukawa
>> Subject: [PATCH] pcap,af_pack
On 2015/03/16 19:47, Neil Horman wrote:
> On Mon, Mar 16, 2015 at 12:42:56PM +0900, Tetsuya Mukawa wrote:
>> 'struct rte_kvargs' is allocated in rte_kvargs_parse(), and should be
>> freed with rte_kvargs_free().
>> This patch fixes memory leaks of 'struct rte_kvargs' in below
On 2015/03/16 23:47, Iremonger, Bernard wrote:
>
>> -Original Message-
>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>> Sent: Monday, March 16, 2015 8:57 AM
>> To: Iremonger, Bernard
>> Cc: John W. Linville; dev at dpdk.org
>> Subject: Re: [
On 2015/03/16 17:38, Tetsuya Mukawa wrote:
> On 2015/03/13 19:14, Iremonger, Bernard wrote:
>>> -Original Message-
>>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>>> Sent: Friday, March 13, 2015 12:11 AM
>>> To: Iremonger, Bernard
&g
On 2015/03/13 19:14, Iremonger, Bernard wrote:
>
>> -Original Message-
>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>> Sent: Friday, March 13, 2015 12:11 AM
>> To: Iremonger, Bernard
>> Cc: John W. Linville; dev at dpdk.org
>> Subject: Re: [
This patch fixes potential null pointer access of eth_null_copy_tx().
Reported-by: Mcnamara, John
Signed-off-by: Tetsuya Mukawa
---
lib/librte_pmd_null/rte_eth_null.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_pmd_null/rte_eth_null.c
b/lib/librte_pmd_null
'struct rte_kvargs' is allocated in rte_kvargs_parse(), and should be
freed with rte_kvargs_free().
This patch fixes memory leaks of 'struct rte_kvargs' in below PMDs.
- pcap PMD
- af_packet PMD
- null PMD
Reported-by: Mcnamara, John
Signed-off-by: Tetsuya Mukawa
---
lib
On 2015/03/13 20:46, Iremonger, Bernard wrote:
>
>> -Original Message-
>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>> Sent: Thursday, March 12, 2015 10:18 AM
>> To: dev at dpdk.org
>> Cc: Iremonger, Bernard; Richardson, Bruce; Tetsuya Mukawa
>&
2015-03-12 20:09 GMT+09:00 Bruce Richardson :
> On Thu, Mar 12, 2015 at 10:57:18AM +, Qiu, Michael wrote:
>> On 3/12/2015 6:50 PM, Bruce Richardson wrote:
>> > On Thu, Mar 12, 2015 at 07:17:40PM +0900, Tetsuya Mukawa wrote:
>> >> This patch fixes cording st
upport port hotplug
>>
>> This patch adds finalization code to free resources allocated by the PMD.
>> This is based on earlier
>> patches for other PMDs by Tetsuya Mukawa , with
>> corrections related to data-
>> >name.
>>
>> Sign
On 2015/03/09 11:23, Tetsuya Mukawa wrote:
> On 2015/03/06 19:32, Iremonger, Bernard wrote:
>
>> Hi Tetsuya,
>>
>> The above functions being added to /lib/librte_eal/bsdapp/eal/eal_pci.c are
>> very similar to the functions
>> in lib/librte_eal/linuxapp/eal
()
- rte_eal_pci_probe_one()
- rte_eal_pci_scan()
- rte_eal_vdev_init()
- rte_eal_vdev_uninit()
Signed-off-by: Tetsuya Mukawa
---
config/common_bsdapp | 6 --
config/common_linuxapp| 5 -
lib/librte_eal/bsdapp/eal/eal_pci.c | 6 +++---
lib
The patch consolidates below functions, and implement these
in eal_common_pci_uio.c.
- pci_uio_map_secondary()
- pci_uio_map_resource()
- pci_uio_unmap()
- pci_uio_find_resource()
- pci_uio_unmap_resource()
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/Makefile
The patch consolidates below functions, and implemented in common
eal code.
- pci_map_resource()
- pci_unmap_resource()
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c| 24 -
lib/librte_eal/common/eal_common_pci.c | 43
The patch consolidates below functions, and implemented in common
eal code.
- pci_map_device()
- pci_unmap_device()
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 12 +++
lib/librte_eal/common/eal_common_pci.c | 57 +
lib
to
linuxapp one with later patch.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c| 79 ++---
lib/librte_eal/common/eal_common_pci.c | 138 +
lib/librte_eal/common/eal_private.h| 21 ++---
lib/librte_eal/linuxapp/eal/eal_pci.c | 153
This patch consolidates below structures, and defines them in common code.
- struct pci_map
- strucy mapped_pci_resouces
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c| 24
lib/librte_eal/common/include/rte_pci.h| 28
This patch adds a new function called pci_uio_map_resource_by_index().
The function hides how to map uio resource in linuxapp and bsdapp.
With the function, pci_uio_map_resource() will be more abstracted.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 108
This patch adds a new function called pci_uio_alloc_uio_resource().
The function hides how to prepare uio resource in linuxapp and bsdapp.
With the function, pci_uio_map_resource() will be more abstracted.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 61
The function is implemented in both linuxapp and bsdapp, but interface
is different. The patch fixes the function of bsdapp to do same as
linuxapp. After applying it, file descriptor should be opened and
closed out of pci_map_resource().
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp
This patch changes code that maps pci resources in bsdapp.
Linuxapp has almost same code. To consolidate both, fix implementation
of bsdapp to work same as linuxapp.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 24
1 file changed, 12
To merge pci code of linuxapp and bsdapp, this patch changes names
like below.
- uio_map to pci_map
- uio_resource to mapped_pci_resource
- uio_res_list to mapped_pci_res_list
Also, add 'path' variable to pci_map of bsdapp.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal
When pci_map_resource() is failed, mapaddr will be MAP_FAILED.
In this case, pci_map_addr should not be incremented.
The patch fixes it. Also, fix below.
- To shrink code, move close().
- Remove fail variable.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 10
When pci_uio_unmap_resource() is called, a file descriptor that is used
for uio configuration should be closed.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
b/lib
This patch fixes cording style of below files in linuxapp and bsdapp.
- eal_pci.c
- eal_pci_uio.c
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 67 ++-
lib/librte_eal/linuxapp/eal/eal_pci.c | 32 +--
lib/librte_eal
is enabled as default with both Linux and BSD.
eal: Enable Port Hotplug as default in Linux and BSD
PATCH v2 changes
- Consolidate pci uio functions of linuxapp and bsdapp.
Tetsuya Mukawa (15):
eal: Fix cording style of eal_pci.c and eal_pci_uio.c
eal: Close file descriptor of uio
Hi John.
On 2015/03/11 3:36, John W. Linville wrote:
> This patch adds finalization code to free resources allocated by
> the PMD. This is based on earlier patches for other PMDs by Tetsuya
> Mukawa , with corrections related to data->name.
>
> Signed-off-by: John W. Linvi
On 2015/03/12 11:05, Tetsuya Mukawa wrote:
> On 2015/03/12 7:25, Mcnamara, John wrote:
>> From: David Marchand [mailto:david.marchand at 6wind.com]
>> Sent: Wednesday, March 11, 2015 9:30 PM
>> To: Mcnamara, John
>> Cc: Tetsuya Mukawa; dev at dpdk.org
>> Subject:
On 2015/03/12 7:25, Mcnamara, John wrote:
>
> From: David Marchand [mailto:david.marchand at 6wind.com]
> Sent: Wednesday, March 11, 2015 9:30 PM
> To: Mcnamara, John
> Cc: Tetsuya Mukawa; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 00/10] eal: rte_tailq api cleanup
&
On 2015/03/10 20:20, Thomas Monjalon wrote:
> 2015-03-05 19:26, Neil Horman:
>> On Wed, Mar 04, 2015 at 10:50:00PM +0100, David Marchand wrote:
>>> This is a first cleanup at trying to remove references to other dpdk
>>> libraries
>>> from eal.
>>>
>>> This cleanup is focused on rte_tailq api
401 - 500 of 983 matches
Mail list logo
