Fixes: 948fd64befc3 ("mk: replace the combined library with a linker script")
Signed-off-by: Thomas Monjalon
---
mk/rte.lib.mk | 18 --
1 file changed, 18 deletions(-)
diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
index 1ff403f..d2523ee 100644
--- a/mk/rte.lib.m
external library link
- fix external dependencies of crypto drivers
Panu Matilainen (3):
pipeline: fix truncated dependency list
pdump: fix missing dependency on libpthread
mk: check shared library dependencies
Thomas Monjalon (4):
mk: remove traces of combined library
mk: fix external
There is no need to have this parsing inlined in the header.
It brings kvargs dependency to every crypto drivers.
The functions are moved into rte_cryptodev.c.
Signed-off-by: Thomas Monjalon
---
v2:
- remove kvargs dep in null PMD
- add function in .map file
v3:
- remove kvargs include
2016-06-25 15:24, De Lara Guarch, Pablo:
> > +DPDK_16.07 {
> > + global:
> > +
> > + rte_cryptodev_parse_vdev_init_params;
>
> I think this function does not need to be public.
> This function is only called in the PMDs, and the only public function
> to initialize a crypto device is
Every new symbols in release 16.07 are exported with the version
string DPDK_16.07.
Also remove the empty local: section which is not needed because
inherited from the DPDK_2.0 block.
Signed-off-by: Thomas Monjalon
---
lib/librte_mempool/rte_mempool_version.map | 3 +--
1 file changed, 1
There is no need to have this parsing inlined in the header.
It brings kvargs dependency to every crypto drivers.
The functions are moved into rte_cryptodev.c.
Signed-off-by: Thomas Monjalon
---
lib/librte_cryptodev/rte_cryptodev.c | 91 ++
lib/librte_cryptodev
|...]
>
> OK alright :)
>
> Acked-by: Olivier Matz
Applied
2016-06-24 14:54, Reshma Pattan:
> +#define SOCKET_DIR "/pdump_sockets"
I think the default socket directory should contain dpdk as prefix.
Like dpdk-pdump-sockets (I think dash is preferred for filenames).
I wonder whether it should be a hidden directory:
~/.dpdk-pdump-sockets
And
2016-06-24 16:06, Olivier Matz:
> Hi Thomas,
>
> On 06/24/2016 01:22 PM, Thomas Monjalon wrote:
> > --- a/app/test/Makefile
> > +++ b/app/test/Makefile
> > @@ -43,14 +43,14 @@ define linked_resource
> > SRCS-y += $(1).res.o
> > $(1).res.o: $(2)
> >
> > This patch introduced scalable multi-writer Cuckoo Hash insertion
> > based on a split Cuckoo Search and Move operation using Intel
> > TSX. It can do scalable hash insertion with 22 cores with little
> > performance loss and negligible TSX abortion rate.
> >
> > * Added an extra rte_hash
The PCI test was failing because some fake devices had no PCI class.
Fixes: 1dbba1650c89 ("app/test: remove real PCI ids")
Signed-off-by: Thomas Monjalon
---
app/test/test_pci_sysfs/bus/pci/devices/:01:02.0/class | 1 +
app/test/test_pci_sysfs/bus/pci/devices/:02:ab.0/clas
2016-06-24 13:20, Jan Viktorin:
> thanks for the patchset. I am sorry, I didn't have any time for DPDK this week
> and didn't test it before applying. The current master produces the following
> error in my regular builds:
>
> INSTALL-LIB librte_eal.a
> == Build lib/librte_ring
> CC
directory through a symbolic link.
Fixes: 1e9e0a6270 ("app/test: fix resource creation with objcopy on FreeBSD")
Signed-off-by: Thomas Monjalon
---
v2: fix rebuild error due to link test_resource.c in build directory
---
app/test/Makefile | 14 --
1 file changed, 8 insert
The verbose option was available but not advertised.
Fixes: 6e38dfe21389 ("scripts: add verbose test build option")
Signed-off-by: Thomas Monjalon
---
scripts/test-build.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/test-build.sh b/scripts/test-build.sh
index 31d558
2016-06-24 09:25, Dumitrescu, Cristian:
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Catalin Vasile
> > I'm trying to add a feature to DPDK and I'm having a hard time printing a
> > backtrace.
> > I tried using this[1] functions for printing, but it does not print more
> > than one
>
2016-06-24 00:43, Lu, Wenzhuo:
> Thanks for this patch. But normally the code in the base directory is synced
> from the kernel driver. So we don't change it if there's no critical issue.
> It's easy for us to maintain it. Thanks.
I think a build error is critical enough.
ation with objcopy on FreeBSD")
Signed-off-by: Thomas Monjalon
---
app/test/Makefile | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/app/test/Makefile b/app/test/Makefile
index 9fa03fb..46f6005 100644
--- a/app/test/Makefile
+++ b/app/test/Makefile
@@ -43,14 +43,14
2016-06-20 12:44, Simon Kagstrom:
> I.e., avoid dump messages with double 0x0x, e.g.,
>
> dump mbuf at 0x0x7fac7b17c800, phys=17b17c880, buf_len=2176
> pkt_len=2064, ol_flags=0, nb_segs=1, in_port=255
> segment at 0x0x7fac7b17c800, data=0x0x7fac7b17c8f0, data_len=2064
>
>
> David Hunt (2):
> mempool: support mempool handler operations
> app/test: test mempool handler
> mbuf: make default mempool ops configurable at build
Applied, thanks for the nice feature
I'm sorry David, the revision record is v17 ;)
2016-06-23 22:53, Thomas Monjalon:
> The compilation for 32-bit fails when CONFIG_RTE_VIRTIO_USER is enabled:
>
> drivers/net/virtio/virtio_user_ethdev.c:84:47:
> error: format ?%llu? expects argument of type ?long long unsigned int?,
> but argument 5 has type ?size_t {a
: add new virtual PCI driver")
Signed-off-by: Thomas Monjalon
---
drivers/net/virtio/virtio_user_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_user_ethdev.c
b/drivers/net/virtio/virtio_user_ethdev.c
index 9216182..5ab2471 100644
---
2016-06-02 02:39, Zhe Tao:
> On Tue, May 03, 2016 at 01:51:10PM +0800, Jingjing Wu wrote:
> > NSH packet can be recognized by Intel X710/XL710 series. This
> > patch set enables it.
> >
> > Jingjing Wu (2):
> > mbuf: new NSH packet type
> > i40e: NSH packet type support
> >
> Acked-by: Zhe
2016-05-16 11:33, Simon Kagstrom:
> This allows releasing RX/TX queue memory.
> ---
> We're using DPDK 16.04 and have a test suite which performs a sequence
> of separate tests of the type
>
>allocate mempool
>rte_eth_dev_configure(port, n_rxq, n_txq, ...)
>setup rx/tx queues
>
2016-06-23 15:38, Pablo de Lara:
> Using gcc 6.1, in some cases, kni fails to compile
> because of unused variables:
Curiosity: is it only with gcc 6.1? Have you tested other versions?
> lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_main.c | 4
> 1 file changed, 4 deletions(-)
We all
Hi,
Thank you for providing more doc.
I am just not convinced it is the right place
and it must be discussed.
Some questions below to help deciding where it must be.
2016-06-23 11:02, Jingjing Wu:
> Bifurcated driver is a mechanism which depends the advanced
> Ethernet device to split traffic
2016-06-18 02:27, Hiroyuki Mikita:
> This commit fixes some functions missing in API documentation.
>
> Signed-off-by: Hiroyuki Mikita
Applied, thanks
2016-05-03 18:12, Jerin Jacob:
> Elements of struct rte_eth_dev used in the fast path.
> Make struct rte_eth_dev cache aligned to avoid the cases where
> rte_eth_dev elements share the same cache line with other structures.
>
> Signed-off-by: Jerin Jacob
Let's try it in real tests.
Applied,
> Jerin Jacob (2):
> ethdev: add tunnel and port RSS offload types
> ethdev: add ETH_RSS_RETA_SIZE_256
Applied with suggested rewording, thanks
2016-05-06 05:33, Wenzhuo Lu:
> An issue is found that DCB cannot be configured on ixgbe
> NICs. It's said the TX queue number is not right.
> On ixgbe the max TX queue number is not fixed, it depends
> on the multi-queue mode. The API rte_eth_dev_configure
> should be used to configure this mode.
2016-06-22 18:33, Jerin Jacob:
> - added VXLAN, GENEVE and NVGRE tunnel flow types
> - added PORT flow type for accounting physical/virtual
> port or channel number in flow creation
[...]
> +#define RTE_ETH_FLOW_PORT 18
> + /**< Physical/virtual port number based flow */
What
2016-06-22 09:27, Neil Horman:
> > +++ b/lib/librte_cryptodev/rte_cryptodev_version.map
> > - rte_cryptodev_pmd_driver_register;
> NAK, you can't just remove exported symbols without going through the
> deprecation process. Better still would be to only expose it for DPDK_16.04
> and
> hide it
2016-06-22 14:27, Thomas F Herbert:
> Program received signal SIGSEGV, Segmentation fault.
> 0x00616172 in vtpci_init (dev=0xbfb0f0, hw=0x7fffd57d0700,
> dev_flags=0x7fffdf9c)
> at /home/heat-admin/dpdk/drivers/net/virtio/virtio_pci.c:722
> 722
2016-06-22 17:49, Gadre Nayan:
> I need to get the interface speed though standard IOCTL call:
[...]
>
> However, for 10G interface I do not read a correct speed, since it may
> not be supported.
Yes
> Out 1G cards are I350 and 10G card is I40.
[...]
> There is no support for 1base. So to
2016-06-22 13:57, Olivier Matz:
> Hi Thomas,
>
> On 06/22/2016 01:49 PM, Thomas Monjalon wrote:
> > 2016-06-22 14:34, Panu Matilainen:
> >> --- a/lib/librte_port/Makefile
> >> +++ b/lib/librte_port/Makefile
> >> @@ -82,6 +82,8 @@ DEPDIRS-$(CON
2016-06-22 14:34, Panu Matilainen:
> --- a/lib/librte_port/Makefile
> +++ b/lib/librte_port/Makefile
> @@ -82,6 +82,8 @@ DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_mempool
> DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_ether
> DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_ip_frag
>
can be deprecated and removed in the next release.
> On 21.06.2016 11:55, Zyta Szpak wrote:
> > OK, I will do the v4.
> >
> > On 17.06.2016 12:20, Thomas Monjalon wrote:
> >> 2016-06-13 16:51, Remy Horton:
> >>> On 12/06/2016 15:51, Zyta Szpa
2016-06-22 13:29, Jerin Jacob:
> Thomas,
> As a librte_ether maintainer any comments on this?
+1 for adding details and make sure naming is good.
I don't really need to comment here because I have already done this
comment earlier:
http://dpdk.org/ml/archives/dev/2016-June/041845.html
2016-06-22 09:56, Thomas Monjalon:
> 2016-06-19 13:05, David Hunt:
> > v15 changes:
> >
> > * Changed rte_mempool_ops_get() to rte_mempool_get_ops()
>
> I don't find this change in the patch.
> But I wonder wether it is really needed.
If we assume that rte_mem
2016-06-19 13:05, David Hunt:
> v15 changes:
>
> * Changed rte_mempool_ops_get() to rte_mempool_get_ops()
I don't find this change in the patch.
But I wonder wether it is really needed.
2016-06-22 12:45, Jerin Jacob:
> On Wed, Jun 22, 2016 at 08:43:52AM +0200, Thomas Monjalon wrote:
> > 2016-06-22 09:00, Jerin Jacob:
> > > On Tue, Jun 21, 2016 at 11:02:59PM +0200, Thomas Monjalon wrote:
> > > > 2016-03-31 02:21, Jerin Jacob:
> > > > >
2016-06-22 09:00, Jerin Jacob:
> On Tue, Jun 21, 2016 at 11:02:59PM +0200, Thomas Monjalon wrote:
> > Hi Jerin,
>
> Hi Thomas,
>
> >
> > I wanted to push this patch which is now a dependency of ThunderX
> > but I do not fully understand it.
> >
> &
Hi Jerin,
I wanted to push this patch which is now a dependency of ThunderX
but I do not fully understand it.
2016-03-31 02:21, Jerin Jacob:
> - added VXLAN, GENEVE and NVGRE tunnel flow types
> - added PORT flow type for accounting physical/virtual
> port or channel number in flow creation
2016-06-16 10:04, Jasvinder Singh:
> Replace APP_PARAM_ADD_LINK_FOR_TXQ with APP_PARAM_ADD_LINK_FOR_TM macro
> in TM (Traffic Manager) port section parsing function. This macro adds
> nic ports entry specified in TM port section of the application
> configuration file to the application parameters
2016-06-21 15:20, Michal Kobylinski:
> Change type of nht field from uint32_t to uint8_t and increase max of
> next hops.
>
> nht_entry and nht should be declared as uint8_t because
> entry_size is in bytes and is given as a parameter to compute
> the position in nht array.
>
> Fixes:
> > From: WeiJie Zhuang
> >
> > add KNI port type to the packet framework
> >
> > Signed-off-by: WeiJie Zhuang
>
> Series-acked-by: Cristian Dumitrescu
Applied, thanks
2016-06-21 13:27, Ferruh Yigit:
> On 6/21/2016 12:43 PM, Anupam Kapoor wrote:
> > This commit fixes build errors triggered due misleading indentation.
> >
> > Fixes: 38db3f7f50bde (e1000: update base driver)
> Fixes: b9ee370557f1 ("kni: update kernel driver ethtool baseline")
>
> > Fixes:
2016-06-15 16:57, Ferruh Yigit:
> Following compile error observed with CentOS 6.8, which uses kernel
> kernel-devel-2.6.32-642.el6.x86_64:
>
> CC eal_thread.o
> .../build/lib/librte_eal/linuxapp/igb_uio/igb_uio.c:
> In function 'igbuio_msix_mask_irq':
>
> Remy Horton (2):
> app/test-pmd: fix Coverity issues
> examples/l2fwd-keepalive: fix Coverity issues
Applied with titles reworded as suggested by Pablo, thanks
2016-06-21 10:03, Deepak Kumar Jain:
> From: "Jain, Deepak K"
>
> Updated the code to use RTE_PCI_DEVICE.
>
> Fixes: 701c8d80c820 ("pci: support class id probing")
>
> Signed-off-by: Jain, Deepak K
Applied, thanks
> > Change type of nht field from uint32_t to uint8_t and increase max of
> > next hops.
> >
> > Fixes: dc81ebbacaeb ("lpm: extend IPv4 next hop field")
> > Signed-off-by: Michal Kobylinski
> > ---
> > v2:
> > - removed changing from file: pipeline_routing_be.h
> > - changed macro:
2016-06-21 11:44, Ferruh Yigit:
> Although this is really detail, for multi version patchsets, if there is
> a preferred way between (A) or (B) I would like to learn too?
In my opinion, A and B are fine.
And I prefer B.
> A)
>
> - [0/N]
> - - [1/N]
> - - [2/N]
> - - [v2 0/N]
> - - - [v2 1/N]
>
> > Sergio Gonzalez Monroy (9):
> > examples/ipsec-secgw: fix esp padding check
> > examples/ipsec-secgw: fix stack smashing error
> > examples/ipsec-secgw: add build option and cleanup
> > examples/ipsec-secgw: rework ipsec execution loop
> > examples/ipsec-secgw: fix no sa found case
>
> Pablo de Lara (11):
> snow3g: rename libsso reference due to library update
> doc: update build instructions for libsso_snow3g
> snow3g: define IV/digest length macros
> snow3g: support bit-level operations
> snow3g: add missing feature flags
> test: use new bit-level memcmp macro
>
> Pablo de Lara (3):
> kasumi: add new KASUMI PMD
> test: add new buffer comparison macros
> test: add unit tests for KASUMI PMD
Applied (with "make clean" fixed), thanks
As for other crypto drivers with a dependency, I'm not sure the PMD.so
can be loaded.
2016-06-20 15:40, Pablo de Lara:
> --- /dev/null
> +++ b/drivers/crypto/kasumi/Makefile
> +# external library include paths
> +CFLAGS += -I$(LIBSSO_KASUMI_PATH)
> +CFLAGS += -I$(LIBSSO_KASUMI_PATH)/include
>
2016-06-20 15:40, Pablo de Lara:
> +include $(RTE_SDK)/mk/rte.vars.mk
> +
> +ifeq ($(LIBSSO_KASUMI_PATH),)
> +$(error "Please define LIBSSO_KASUMI_PATH environment variable")
> +endif
This is not "make clean" compliant.
See previous fix of other crypto drivers:
> > Some crypto PMDs that support symmetric crypto were not marked as
> > supported in the supported feature flags table.
> >
> > Fixes: 2373c0661b2f0 ("doc: add cryptodevs guide overview")
> >
> > Signed-off-by: Pablo de Lara
>
> Acked-by: John McNamara
Applied, thanks
2016-06-20 17:10, Jain, Deepak K:
> Updated the code to use RTE_PCI_DEVICE.
>
> Fixes: 701c8d80c820 ("pci: support class id probing")
>
> Signed-off-by: Jain, Deepak K
> ---
> drivers/crypto/qat/rte_qat_cryptodev.c | 10 +++---
> lib/librte_eal/common/include/rte_pci_dev_ids.h |
2016-06-20 16:44, Ferruh Yigit:
> On 6/15/2016 7:34 PM, Thomas Monjalon wrote:
> > 2016-06-15 19:16, Ferruh Yigit:
> >> On 6/9/2016 10:26 PM, Thomas Monjalon wrote:
> >>> So this is my proposal:
> >>> Someone start working on the above cleanup now, oth
> > Pablo de Lara (4):
> > test: remove useless hexdump include
> > test: fix compilation when RTE_APP_TEST_DEBUG was set
> > test: remove unnecessary hexdump_mbuf_data and HEXDUMP
> > app: add new TEST_HEXDUMP macro
>
> Series-acked-by: Fan Zhang
Applied, thanks
> Fiona Trahe (2):
> app/test: adding Snow3g performance test
> app/test: updating AES SHA performance test
>
> Jain, Deepak K (1):
> app/test: typo fixing
Applied, thanks
> > Fan Zhang (2):
> > app/test: rework the crypto AES unit test
> > app/test: add crypto AES-CBC-128 HMAC-SHA224 and HMAC-SHA384 unit
> > tests
>
> Series-acked-by: Pablo de Lara
Applied, thanks
2016-06-20 14:49, Remy Horton:
> Fixes memory leaks detected by Coverity. These are due to ephemeral
> memory allocations not being freed when errors occur.
>
> Coverity issue 127348: Resource leak
> Coverity issue 127349: Resource leak
>
> Fixes: e2aae1c1ced9 ("ethdev: remove name from extended
2016-06-20 18:55, Jerin Jacob:
> On Mon, Jun 20, 2016 at 02:08:10PM +0100, David Hunt wrote:
> > This is a mempool handler that is useful for pipelining apps, where
> > the mempool cache doesn't really work - example, where we have one
> > core doing rx (and alloc), and another core doing Tx (and
2016-06-17 15:12, Jerin Jacob:
> Thunderx nicvf also got the same problem when I rebased to
> dpdk-next-net/rel_16_07.
>
> The root cause for this issue is that, PCI CLASS_ID EAL add
> changeset(701c8d80c820461e8255dfb7387a09f0e54399f0)
> has taken care only the pci devices where id table is
2016-06-20 10:59, Remy Horton:
> The KeepAlive rte_keepalive_mark_sleep function was not being exported.
>
> Fixes: 90c622f35679 ("keepalive: add liveness callback")
>
> Signed-off-by: Remy Horton
I missed it during the review.
Applied, thanks
2016-06-20 12:10, Michal Jastrzebski:
> From: Michal Kobylinski
>
> Change type of nht field from uint32_t to uint8_t and increase max of
> next hops.
>
> Fixes: dc81ebbacaeb ("lpm: extend IPv4 next hop field")
Why the type is wrong?
2016-06-20 10:38, Sergio Gonzalez Monroy:
> On 20/06/2016 10:14, Thomas Monjalon wrote:
> >> + RTE_LOG(ERR, EAL,
> >> + "All memory segments exhausted by IVSHMEM. "
> > There is no evidence that it is related to IVSHMEM.
> >
2016-06-16 20:49, Jain, Deepak K:
> From: Declan Doherty
>
> Adding rte_crypto_op_bulk_free to free up the ops in bulk
> so as to expect improvement in performance.
>
> Signed-off-by: Declan Doherty
I wonder why these changes are dropped so late?
> /**
> + * free crypto operation structure
2016-05-12 11:12, Daniel Mrzyglod:
> Fix issue reported by Coverity.
> Coverity ID 97920
>
> munmap structure of hugepage
>
> leaked_storage: Variable hugepage going out of scope leaks the storage
> it points to.
>
> The system resource will not be reclaimed and reused, reducing the future
>
2016-06-16 17:14, Marcin Kerlin:
> Patch fixes resource leak in rte_eal_hugepage_attach() where mapped files
> were not freed back to the OS in case of failure. Patch uses the behavior
> of Linux munmap: "It is not an error if the indicated range does not
> contain any mapped pages".
>
> Coverity
2016-06-15 13:17, Marcin Kerlin:
> Minor typo fix to error message
>
> Fixes: 148f963fb532 ("xen: core library changes")
>
> Signed-off-by: Marcin Kerlin
Applied, thanks
2016-06-16 16:52, Slawomir Mrozowicz:
> Overrunning array mcfg->memseg of 256 44-byte elements
> at element index 257 using index j.
> Fixed by add condition with message information.
>
> Fixes: af75078fece3 ("first public release")
> Coverity ID 13282
Please use this formatting:
Coverity issue:
2016-06-14 19:07, Sergio Gonzalez Monroy:
> It is possible to get an integer overflow if we try to reserve a memzone
> with len = 0 (meaning the maximum contiguous space available) and the
> maximum available elem size is less than (MALLOC_ELEM_OVERHEAD + align).
>
> Issue reported by Coverity:
>
2016-06-19 23:11, Thomas Monjalon:
> The function rte_thread_setname needs glibc 2.12,
> otherwise it returns -1 without using any parameter.
> The macro RTE_SET_USED avoids an "unused parameter" warning.
>
> Fixes: 3901ed99c2f8 ("eal: fix thread naming on FreeBS
2016-06-20 11:19, Tetsuya Mukawa:
> On 2016/06/17 21:28, David Marchand wrote:
> > On Thu, Jun 16, 2016 at 4:33 AM, Tetsuya Mukawa
> > wrote:
> >> This patch fixes resource leak of pci_uio_map_secondary().
> >> If pci_map_resource() succeeds but mapped address is different from an
> >> address
2016-06-17 14:12, David Marchand:
> On Thu, Jun 16, 2016 at 4:33 AM, Tetsuya Mukawa wrote:
> > This patch fixes wrong resource release of pci_uio_unmap().
> > The 'path' member of mapped_pci_resource structure is allocated by
> > primary process, but currently it will be freed by both primary
> >
2016-06-17 14:10, David Marchand:
> On Thu, Jun 16, 2016 at 4:33 AM, Tetsuya Mukawa wrote:
> > This patch fixes wrong error checking of rte_eal_parse_devargs_str().
> > Currently, a return value of strdup() is wrongly checked.
> >
> > Fixes: 0fe11ec592b2 ("eal: add vdev init and uninit")
> >
The function rte_thread_setname needs glibc 2.12,
otherwise it returns -1 without using any parameter.
The macro RTE_SET_USED avoids an "unused parameter" warning.
Fixes: 3901ed99c2f8 ("eal: fix thread naming on FreeBSD")
Signed-off-by: Thomas Monjalon
---
lib/lib
2016-06-17 18:04, David Marchand:
> On Fri, Jun 17, 2016 at 6:02 PM, Thomas Monjalon
> wrote:
> > rte_thread_setname was a macro defined only for Linux.
> > The function rte_thread_setname() can now be used on FreeBSD
> > as well on Linux.
> > It is
2016-06-17 17:02, Thomas Monjalon:
> The function rte_keepalive_register_alive_callback do not exist.
> The function rte_keepalive_register_relay_callback was missing for BSD.
>
> Fixes: 90c622f35679 ("keepalive: add liveness callback")
>
> Signed-off-by: Thomas Monjalon
Applied
because
it is not an important failure, just a debug inconvenience.
Fixes: 278f945402c5 ("pdump: add new library for packet capture")
Signed-off-by: Thomas Monjalon
---
examples/tep_termination/main.c| 2 +-
examples/vhost/main.c | 2 +-
The function rte_keepalive_register_alive_callback do not exist.
The function rte_keepalive_register_relay_callback was missing for BSD.
Fixes: 90c622f35679 ("keepalive: add liveness callback")
Signed-off-by: Thomas Monjalon
---
lib/librte_eal/bsdapp/eal/rte_eal_version.map |
2016-06-17 15:19, Thomas Monjalon:
> 2016-06-17 14:52, Jan Viktorin:
> > Using of the /dev/stdin generates a warning when compiling on FreeBSD:
> >
> > objcopy: Warning: '/dev/stdin' is not an ordinary file
> > app/test/Makefile:78: recipe for target 'test_resource_c
2016-06-17 15:22, Thomas Monjalon:
> The variables AESNI_MULTI_BUFFER_LIB_PATH and LIBSSO_PATH
> are not required for "make clean".
> It is the same fix as in the commit e277b2397.
Fixes: eec136f3c54f ("aesni_gcm: add driver for AES-GCM crypto operations")
Fixes: 3aaf
The variables AESNI_MULTI_BUFFER_LIB_PATH and LIBSSO_PATH
are not required for "make clean".
It is the same fix as in the commit e277b2397.
Signed-off-by: Thomas Monjalon
---
drivers/crypto/aesni_gcm/Makefile | 2 ++
drivers/crypto/snow3g/Makefile| 2 ++
2 files changed, 4
root wheel 4 Jun 17 12:24 /dev/stdin -> fd/0
>
> Replace /dev/stdin by a temporary file.
>
> Signed-off-by: Jan Viktorin
> Reported-by: Thomas Monjalon
Tested-by: Thomas Monjalon
Looks good, thanks
2016-05-19 17:56, Thomas Monjalon:
> 2016-05-19 21:48, Jianbo Liu:
> > On 13 May 2016 at 23:49, Thomas Monjalon
> > wrote:
> > > 2016-05-10 14:01, Jianbo Liu:
> > >> Other APP may call rte_memcpy by function pointer,
> > >> so change it to an
2016-06-13 16:51, Remy Horton:
>
> On 12/06/2016 15:51, Zyta Szpak wrote:
> > I would prefer having only one function rte_eth_dev_get_regs()
> > which returns length and width if data is NULL.
> > The first call is a parameter request before buffer allocation,
> > and the second
t;app/test: support resources archived by tar")
> >
> > Signed-off-by: Thomas Monjalon
> > ---
> Acked-by: Bruce Richardson
Applied
2016-06-17 09:42, Hunt, David:
>
> On 17/6/2016 9:08 AM, Olivier Matz wrote:
> > Hi David,
> >
> > On 06/17/2016 08:58 AM, Hunt, David wrote:
> >> A comment below:
> >>
> >> On 16/6/2016 1:30 PM, David Hunt wrote:
> >>> +/**
> >>> + * Set the ops of a mempool.
> >>> + *
> >>> + * This can only be
2016-06-16 16:25, Jain, Deepak K:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > 2016-06-16 16:29, Jain, Deepak K:
> > > Due to addition of CLASS_ID in EAL, class_id is amended into the code.
> >
> > Why the VF is not recognized?
> >
The objcopy and tar commands were printed even in quiet mode.
They are now replaced by a simple line and still visible in verbose mode.
Fixes: ab64f5df8004 ("app/test: support resources externally linked")
Fixes: 66819e6c11d8 ("app/test: support resources archived by tar")
S
2016-06-15 15:06, Reshma Pattan:
> Converted rte_eth_dev_get_port_by_name to a public API.
> Converted rte_eth_dev_get_name_by_port to a public API.
> Updated the release notes with the changes.
It is not an API change, just a new API, so no need to reference
it in the release notes.
2016-06-15 15:06, Reshma Pattan:
> The new fields nb_rx_queues and nb_tx_queues are added to the
> rte_eth_dev_info structure.
> Changes to API rte_eth_dev_info_get() are done to update these new fields
> to the rte_eth_dev_info object.
The ABI is changed, not the API.
> Release notes is updated
2016-06-16 16:41, Iremonger, Bernard:
> Hi Thomas,
>
> > 2016-06-16 15:32, Bruce Richardson:
> > > On Mon, Jun 13, 2016 at 01:28:08PM +0100, Iremonger, Bernard wrote:
> > > > > Why does this particular PMD need spinlocks when doing RX and TX,
> > > > > while other device types do not? How is
> Remy Horton (3):
> eal: export keepalive state enumerations
> eal: add additional keepalive callbacks
> examples/l2fwd-keepalive: add IPC liveness reporting
Applied, thanks
Just a last comment: the agent in the example should not appear
in examples/Makefile.
2016-06-16 16:29, Jain, Deepak K:
> Due to addition of CLASS_ID in EAL, class_id is
> amended into the code.
Why the VF is not recognized?
The class id should not be mandatory.
> Remy Horton (7):
> rte: change xstats to use integer ids
> drivers/net/ixgbe: change xstats to use integer ids
> drivers/net/e1000: change xstats to use integer ids
> drivers/net/fm10k: change xstats to use integer ids
> drivers/net/i40e: change xstats to use integer ids
>
2016-06-15 11:03, Wenzhuo Lu:
> +/**
> + * Reset an Ethernet device.
> + *
> + * @param port_id
> + * The port identifier of the Ethernet device.
> + */
> +int
> +rte_eth_dev_reset(uint8_t port_id);
Please explain in the doxygen comment what means a reset.
We must understand why and when an
901 - 1000 of 5910 matches
Mail list logo
