[dpdk-dev] [PATCH v9 1/3] Remove ABI requirement for external library builds.

2015-11-20 Thread Wang, Liang-min
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton > Sent: Friday, November 20, 2015 3:35 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v9 1/3] Remove ABI requirement for external > library builds. > > Signed-off-by: Andrew G. Harvey > ---

[dpdk-dev] [PATCH v2 2/2] examples: new example: l2fwd-ethtool

2015-11-17 Thread Wang, Liang-min
Thomas, Could you explain why this patch is put on RFC? Thanks, Larry > -Original Message- > From: Wang, Liang-min > Sent: Wednesday, October 21, 2015 12:47 PM > To: 'Thomas Monjalon' > Cc: dev at dpdk.org; Andrew Harvey (agh) (agh at cisco.com) > Subject: RE:

[dpdk-dev] [PATCH v2 2/2] examples: new example: l2fwd-ethtool

2015-10-21 Thread Wang, Liang-min
he mk file inclusion. Since Andy is on vacation, I am not sure if he could make a comment on that. Larry > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, October 21, 2015 12:36 PM > To: Wang, Liang-min > Cc: dev at dpdk.org

[dpdk-dev] [PATCH v17 0/5] User-space Ethtool

2015-07-16 Thread Wang, Liang-min
njalon at 6wind.com] > Sent: Thursday, July 16, 2015 6:09 PM > To: Wang, Liang-min > Cc: dev at dpdk.org; O'Driscoll, Tim > Subject: Re: [dpdk-dev] [PATCH v17 0/5] User-space Ethtool > > 2015-07-16 21:55, Wang, Liang-min: > > Thomas, > > Do you want me to create a separ

[dpdk-dev] [PATCH v17 0/5] User-space Ethtool

2015-07-16 Thread Wang, Liang-min
? Thanks, Larry > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, July 16, 2015 5:48 PM > To: Wang, Liang-min > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v17 0/5] User-space Ethtool > > 2015-07-16 09:

[dpdk-dev] [PATCH v15 1/4] ethdev: add apis to support access device info

2015-07-15 Thread Wang, Liang-min
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, July 15, 2015 7:21 AM > To: Wang, Liang-min > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v15 1/4] ethdev: add apis to support access > device info >

[dpdk-dev] [PATCH v15 1/4] ethdev: add apis to support access device info

2015-07-15 Thread Wang, Liang-min
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, July 15, 2015 6:27 AM > To: Wang, Liang-min > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v15 1/4] ethdev: add apis to support access > device info >

[dpdk-dev] [PATCH v16 0/6] User-space Ethtool

2015-07-15 Thread Wang, Liang-min
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, July 15, 2015 1:53 AM > To: Wang, Liang-min > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v16 0/6] User-space Ethtool > > 2015-07-14 20:56, Wan

[dpdk-dev] [PATCH v15 1/4] ethdev: add apis to support access device info

2015-07-15 Thread Wang, Liang-min
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, July 15, 2015 2:16 AM > To: Wang, Liang-min > Cc: dev at dpdk.org; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v15 1/4] ethdev: add apis to support access > dev

[dpdk-dev] [PATCH v16 0/6] User-space Ethtool

2015-07-14 Thread Wang, Liang-min
nd.com] > Sent: Tuesday, July 14, 2015 4:14 PM > To: Wang, Liang-min > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v16 0/6] User-space Ethtool > > 2015-07-14 09:11, Liang-Min Larry Wang: > > v16 changes: > > - Re-do patch v15 and separate changes between v15 an

[dpdk-dev] [PATCH v9 5/5] ixgbe/igb: changed register tables to const

2015-07-10 Thread Wang, Liang-min
Stephen, > -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Friday, June 26, 2015 9:37 PM > To: Wang, Liang-min > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 5/5] ixgbe/igb: changed register tables to > const >

[dpdk-dev] [PATCH v9 5/5] ixgbe/igb: changed register tables to const

2015-06-27 Thread Wang, Liang-min
> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Friday, June 26, 2015 9:37 PM > To: Wang, Liang-min > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 5/5] ixgbe/igb: changed register tables to > const > > O

[dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool ops

2015-06-27 Thread Wang, Liang-min
> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Friday, June 26, 2015 9:34 PM > To: Wang, Liang-min > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool ops > > On Fri, 26

[dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool ops

2015-06-27 Thread Wang, Liang-min
> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Friday, June 26, 2015 9:33 PM > To: Wang, Liang-min > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool ops > > On Fri, 26

[dpdk-dev] [PATCH v9 5/5] ixgbe/igb: changed register tables to const

2015-06-27 Thread Wang, Liang-min
> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Friday, June 26, 2015 9:37 PM > To: Wang, Liang-min > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 5/5] ixgbe/igb: changed register tables to > const > > O

[dpdk-dev] [PATCH v8 1/5] ethdev: add apis to support access device info

2015-06-27 Thread Wang, Liang-min
> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Friday, June 26, 2015 12:52 PM > To: Wang, Liang-min > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 1/5] ethdev: add apis to support access > device info >

[dpdk-dev] [PATCH v7 1/4] ethdev: add apis to support access device info

2015-06-25 Thread Wang, Liang-min
> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Thursday, June 25, 2015 9:44 AM > To: Wang, Liang-min > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v7 1/4] ethdev: add apis to support access > device info >

[dpdk-dev] [PATCH v7 1/4] ethdev: add apis to support access device info

2015-06-25 Thread Wang, Liang-min
> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Thursday, June 25, 2015 9:40 AM > To: Wang, Liang-min > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v7 1/4] ethdev: add apis to support access > device info >

[dpdk-dev] [PATCH v7 0/4] User-space Ethtool

2015-06-23 Thread Wang, Liang-min
Stephen, From: Wang, Liang-min Sent: Thursday, June 18, 2015 8:47 AM To: Stephen Hemminger Cc: dev at dpdk.org Subject: RE: [dpdk-dev] [PATCH v7 0/4] User-space Ethtool >>I agree with having a more complete API, but have some nits to pick. >>Could the API be more abstract to reduc

[dpdk-dev] [PATCH v7 0/4] User-space Ethtool

2015-06-18 Thread Wang, Liang-min
>I agree with having a more complete API, but have some nits to pick. >Could the API be more abstract to reduce ABI issues in future? Which API? Are you referring to the APIs over ethdev level, or something else? More abstract on input/output data structure definition or else? Could you be more

[dpdk-dev] [PATCH v4 1/4] ethdev: add apis to support access device info

2015-06-15 Thread Wang, Liang-min
> -Original Message- > From: Ananyev, Konstantin > Sent: Monday, June 15, 2015 9:46 AM > To: Wang, Liang-min; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH v4 1/4] ethdev: add apis to support access > device info > > > > > -Original Messa

[dpdk-dev] [PATCH v4 1/4] ethdev: add apis to support access device info

2015-06-15 Thread Wang, Liang-min
> -Original Message- > From: Ananyev, Konstantin > Sent: Friday, June 12, 2015 8:31 AM > To: Wang, Liang-min; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH v4 1/4] ethdev: add apis to support access > device info > > > > > -Original Messa

[dpdk-dev] [PATCH v4 1/4] ethdev: add apis to support access device info

2015-06-11 Thread Wang, Liang-min
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, June 11, 2015 9:07 AM > To: Wang, Liang-min; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH v4 1/4] ethdev: add apis to support access > device info > > > > > -Original Messa

[dpdk-dev] [PATCH v4 1/4] ethdev: add apis to support access device info

2015-06-11 Thread Wang, Liang-min
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, June 11, 2015 8:26 AM > To: Wang, Liang-min; dev at dpdk.org > Cc: Wang, Liang-min > Subject: RE: [dpdk-dev] [PATCH v4 1/4] ethdev: add apis to support access > devi

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-05 Thread Wang, Liang-min
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, June 05, 2015 9:41 AM > To: Wang, Liang-min > Cc: Andrew Harvey (agh); Stephen Hemminger; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-05 Thread Wang, Liang-min
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, June 05, 2015 6:47 AM > To: Andrew Harvey (agh) > Cc: Stephen Hemminger; Wang, Liang-min; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-02 Thread Wang, Liang-min
>I have the feeling we are not progressing in this discussion. >Please bring new explanations or I'll give up. >David Harton already acked it so maybe he could explain why it is useful. > >Comments below > >2015-06-02 17:06, Wang, Liang-min: >> >2015-06-02 15:4

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-02 Thread Wang, Liang-min
>2015-06-02 15:47, Wang, Liang-min: >> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >> > >>I'm curious to understand how renaming rte_eth_dev_set_mtu() to >> > >>rte_ethtool_net_change_mtu() will help anyone. >> >> >> &

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-02 Thread Wang, Liang-min
-Original Message- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Tuesday, June 02, 2015 10:33 AM To: Wang, Liang-min Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs >Wang, hope it's clear that any

[dpdk-dev] [PATCH 1/2] ethdev: add api to set default mac address

2015-06-02 Thread Wang, Liang-min
>On Tue, 02 Jun 2015 14:23:22 +0200 >Thomas Monjalon wrote: >> 2015-06-02 10:52, Ananyev, Konstantin: > >> From: Wang, Liang-min > > >> int > > >>+rte_eth_dev_default_mac_addr_set(uint8_t port_id, struct > > >> +et

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-02 Thread Wang, Liang-min
>2015-05-29 15:26, Liang-Min Larry Wang: >> adding a new library based upon ethdev APIs to provide API's that bear >> the same functionality as ethtool_ops (linux/ethtool.h) and >> net_device_ops (linux/netdevice.h). >> >> Signed-off-by: Liang-Min Larry Wang >> --- >> MAINTAINERS

[dpdk-dev] [PATCH 1/2] ethdev: add api to set default mac address

2015-06-02 Thread Wang, Liang-min
>> -Original Message- >> From: Wang, Liang-min >> Sent: Friday, May 29, 2015 8:27 PM >> To: dev at dpdk.org >> Cc: Richardson, Bruce; Ananyev, Konstantin; dharton at cisco.com; > >agh at cisco.com; Wang, Liang-min >> Subject: [PATCH 1/2]

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-05-31 Thread Wang, Liang-min
>>On Sat, 30 May 2015 19:40:46 +0000 >>"Wang, Liang-min" wrote: >> >>> > >>On Sat, 30 May 2015 16:16:01 + > >>"Wang, Liang-min" wrote: > >> > >> >>The design decision is to keep ethdev as THE inter

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-05-31 Thread Wang, Liang-min
>On Sat, 30 May 2015 19:40:46 + >"Wang, Liang-min" wrote: > >> > >On Sat, 30 May 2015 16:16:01 + > >"Wang, Liang-min" wrote: > > > >> >The design decision is to keep ethdev as THE interface for all the >

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-05-30 Thread Wang, Liang-min
On Sat, 30 May 2015 16:16:01 + "Wang, Liang-min" wrote: > >The design decision is to keep ethdev as THE interface for all the external > >API, so ethtool APIs are designed based upon ethdev API. At the meantime, > >the ethtool APIs are designed to enable us

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-05-30 Thread Wang, Liang-min
>On Fri, 29 May 2015 20:37:56 -0400 >Liang-Min Larry Wang wrote: > >> adding a new library based upon ethdev APIs to provide API's that bear >> the same functionality as ethtool_ops (linux/ethtool.h) and > >net_device_ops (linux/netdevice.h). >The API's for ethtool like things are valuable,

[dpdk-dev] [PATCH 1/2] ethdev: add api to set default mac address

2015-05-29 Thread Wang, Liang-min
>On Fri, 29 May 2015 09:15:08 -0400 >Liang-Min Larry Wang wrote: > >> } > > >> int >> +rte_eth_dev_default_mac_addr_set(uint8_t port_id, struct ether_addr >> +*addr) { >> +struct rte_eth_dev *dev; >> +const int index = 0; >> +const uint32_t pool = 0; >> + >> +if

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-05-29 Thread Wang, Liang-min
>On Fri, 29 May 2015 09:15:09 -0400 >Liang-Min Larry Wang wrote: > >> +drvinfo->n_stats = sizeof(struct rte_eth_stats) / sizeof(uint64_t); > >+drvinfo->testinfo_len = 0; > > >Providing a hook to access more functionality is good and compatiablity with >old API's is helpful. Too bad