[dpdk-dev] [PATCH] hash: fix CRC32c computation

2016-02-11 Thread Didier Pallard
gt; Sent: Tuesday, December 22, 2015 9:35 AM >> To: dev at dpdk.org; Richardson, Bruce ; De >> Lara >> Guarch, Pablo >> Subject: [dpdk-dev] [PATCH] hash: fix CRC32c computation >> diff --git a/lib/librte_hash/rte_hash_crc.h b/lib/librte_hash/rte_hash_crc.h

[dpdk-dev] [PATCH] hash: fix CRC32c computation

2016-02-10 Thread Pattan, Reshma
Hi, Small typo. > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Didier Pallard > Sent: Tuesday, December 22, 2015 9:35 AM > To: dev at dpdk.org; Richardson, Bruce ; De > Lara > Guarch, Pablo > Subject: [dpdk-dev] [PATCH] hash: f

[dpdk-dev] [PATCH] hash: fix CRC32c computation

2016-02-08 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, February 08, 2016 2:40 PM > To: De Lara Guarch, Pablo > Subject: FW: [dpdk-dev] [PATCH] hash: fix CRC32c computation > > > > From: Vincent JARDIN [mailto:vincent.jardin at 6wind.com] >

[dpdk-dev] [PATCH] hash: fix CRC32c computation

2015-12-23 Thread Vincent JARDIN
Le 23 d?c. 2015 10:12, "Qiu, Michael" a ?crit : > > Is it suitable to put so many code in commit log? It is more explicit than a text/comment. I do not think it should be maintained code. > > Thanks, > Michael > On 12/22/2015 5:36 PM, Didier Pallard wrote: > > As demonstrated by the following

[dpdk-dev] [PATCH] hash: fix CRC32c computation

2015-12-23 Thread Qiu, Michael
Is it suitable to put so many code in commit log? Thanks, Michael On 12/22/2015 5:36 PM, Didier Pallard wrote: > As demonstrated by the following code, CRC32c computation is not valid > when buffer length is not a multiple of 4 bytes: > (Output obtained by code below) > > CRC of 1 NULL bytes

[dpdk-dev] [PATCH] hash: fix CRC32c computation

2015-12-22 Thread Didier Pallard
As demonstrated by the following code, CRC32c computation is not valid when buffer length is not a multiple of 4 bytes: (Output obtained by code below) CRC of 1 NULL bytes expected: 0x527d5351 soft: 527d5351 rte accelerated: 48674bc7 rte soft: 48674bc7 CRC of 2 NULL bytes expected: