[dpdk-dev] [PATCH] librte_cmdline: FreeBSD Fix oveflow when size of command result structure is greater than BUFSIZ

2014-12-04 Thread Thomas Monjalon
2014-12-04 14:01, Carew, Alan: > I did post a V2 http://dpdk.org/ml/archives/dev/2014-November/007920.html. > I must have used an incorrect message ID incorrect for "--in-reply-to" though. Sorry I failed to check similar patches. I reverted the v1 patch and wait the review to apply the v2. --

[dpdk-dev] [PATCH] librte_cmdline: FreeBSD Fix oveflow when size of command result structure is greater than BUFSIZ

2014-12-04 Thread Carew, Alan
Hi folks and thanks, > > Sorry, I had no time to deeply check this. I think your patch can go > > in 1.8 as it's still an enhancement compared to the current situation. > > We may go back on this later. > > > > Acked-by: Olivier Matz > > Applied > > Thanks > -- > Thomas I did post a V2

[dpdk-dev] [PATCH] librte_cmdline: FreeBSD Fix oveflow when size of command result structure is greater than BUFSIZ

2014-12-03 Thread Thomas Monjalon
2014-12-03 17:05, Olivier MATZ: > Hi, > > On 10/27/2014 10:14 AM, Olivier MATZ wrote: > > Hello Alan, > > > > On 10/20/2014 05:26 PM, Carew, Alan wrote: > >> A comment on my own patch. > >> > >> Making the size of result_buf consistent across each OS and keeping it as > >> large > >> as the

[dpdk-dev] [PATCH] librte_cmdline: FreeBSD Fix oveflow when size of command result structure is greater than BUFSIZ

2014-12-03 Thread Olivier MATZ
Hi, On 10/27/2014 10:14 AM, Olivier MATZ wrote: > Hello Alan, > > On 10/20/2014 05:26 PM, Carew, Alan wrote: >> A comment on my own patch. >> >> Making the size of result_buf consistent across each OS and keeping it as >> large >> as the Linux BUFSIZ(8192) doesn't really address the core issue.

[dpdk-dev] [PATCH] librte_cmdline: FreeBSD Fix oveflow when size of command result structure is greater than BUFSIZ

2014-10-27 Thread Olivier MATZ
Hello Alan, On 10/20/2014 05:26 PM, Carew, Alan wrote: > A comment on my own patch. > > Making the size of result_buf consistent across each OS and keeping it as > large > as the Linux BUFSIZ(8192) doesn't really address the core issue. > > In the event that a user of librte_cmdline creates a

[dpdk-dev] [PATCH] librte_cmdline: FreeBSD Fix oveflow when size of command result structure is greater than BUFSIZ

2014-10-20 Thread Alan Carew
When using test-pmd with flow director in FreeBSD, the application will segfault/Bus error while parsing the command-line. This is due to how each commands result structure is represented during parsing, where the offsets for each tokens value is stored in a character array(char

[dpdk-dev] [PATCH] librte_cmdline: FreeBSD Fix oveflow when size of command result structure is greater than BUFSIZ

2014-10-20 Thread Carew, Alan
ew > Sent: Monday, October 20, 2014 4:23 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] librte_cmdline: FreeBSD Fix oveflow when size of > command result structure is greater than BUFSIZ > > When using test-pmd with flow director in FreeBSD, the application will > se