[dpdk-dev] [PATCH] mbuf: remove inconsistent assert statements

2016-06-20 Thread Adrien Mazarguil
On Wed, Jun 08, 2016 at 10:34:17AM +, Ananyev, Konstantin wrote: > Hi Adrien, > > > > > An assertion failure occurs in __rte_mbuf_raw_free() (called by a few PMDs) > > when compiling DPDK with CONFIG_RTE_LOG_LEVEL=RTE_LOG_DEBUG and starting > > applications with a log level high enough to tri

[dpdk-dev] [PATCH] mbuf: remove inconsistent assert statements

2016-06-09 Thread Don Provan
> -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.ananyev at intel.com] > Sent: Thursday, June 09, 2016 8:45 AM > To: Thomas Monjalon > Cc: dev at dpdk.org; Olivier Matz ; Adrien > Mazarguil ; Zhang, Helin intel.com> > Subject: Re: [dpdk-d

[dpdk-dev] [PATCH] mbuf: remove inconsistent assert statements

2016-06-09 Thread Thomas Monjalon
2016-06-09 13:21, Ananyev, Konstantin: > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > > Today: > > > > /* allowed */ > > m = rte_pktmbuf_alloc(); > > rte_pktmbuf_free(m); > > > > /* not allowed */ > > m = rte_mbuf_raw_alloc(); > > __rte_mbuf_raw_free(m); > > > > /* we sh

[dpdk-dev] [PATCH] mbuf: remove inconsistent assert statements

2016-06-09 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, June 09, 2016 4:28 PM > To: Ananyev, Konstantin > Cc: dev at dpdk.org; Olivier Matz; Adrien Mazarguil; Zhang, Helin > Subject: Re: [dpdk-dev] [PATCH] mbuf: remove i

[dpdk-dev] [PATCH] mbuf: remove inconsistent assert statements

2016-06-09 Thread Bruce Richardson
rien Mazarguil > > Subject: Re: [dpdk-dev] [PATCH] mbuf: remove inconsistent assert statements > > > > Hi Konstantin, > > > > >>>>>> Yes, it refcnt supposed to be set to 0 by > > >>>>>> __rte_pktmbuf_prefree_seg()

[dpdk-dev] [PATCH] mbuf: remove inconsistent assert statements

2016-06-09 Thread Ananyev, Konstantin
Hi Olivier, > -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Thursday, June 09, 2016 8:47 AM > To: Ananyev, Konstantin; dev at dpdk.org; Adrien Mazarguil > Subject: Re: [dpdk-dev] [PATCH] mbuf: remove inconsistent assert statements >

[dpdk-dev] [PATCH] mbuf: remove inconsistent assert statements

2016-06-09 Thread Olivier Matz
Hi Konstantin, >> Yes, it refcnt supposed to be set to 0 by __rte_pktmbuf_prefree_seg(). >> Wright now, it is a user responsibility to make sure refcnt==0 before >> pushing >> mbuf back to the pool. >> Not sure why do you consider that wrong? > > I do not consider this

[dpdk-dev] [PATCH] mbuf: remove inconsistent assert statements

2016-06-08 Thread Olivier Matz
Hi Adrien, Konstantin, I'm jumping in this (interesting) discussion. I already talked a bit with Adrien in point to point, and I think its patch is valid. Please see some comments below. On 06/08/2016 03:57 PM, Adrien Mazarguil wrote: > On Wed, Jun 08, 2016 at 01:09:18PM +, Ananyev, Konstant

[dpdk-dev] [PATCH] mbuf: remove inconsistent assert statements

2016-06-08 Thread Ananyev, Konstantin
Hi Olivier, > > Hi Adrien, Konstantin, > > I'm jumping in this (interesting) discussion. I already talked a > bit with Adrien in point to point, and I think its patch is valid. > Please see some comments below. > > > On 06/08/2016 03:57 PM, Adrien Mazarguil wrote: > > On Wed, Jun 08, 2016 at 0

[dpdk-dev] [PATCH] mbuf: remove inconsistent assert statements

2016-06-08 Thread Adrien Mazarguil
On Wed, Jun 08, 2016 at 01:09:18PM +, Ananyev, Konstantin wrote: > > > > Hi Konstantin, > > > > On Wed, Jun 08, 2016 at 10:34:17AM +, Ananyev, Konstantin wrote: > > > Hi Adrien, > > > > > > > > > > > An assertion failure occurs in __rte_mbuf_raw_free() (called by a few > > > > PMDs) > >

[dpdk-dev] [PATCH] mbuf: remove inconsistent assert statements

2016-06-08 Thread Adrien Mazarguil
Hi Konstantin, On Wed, Jun 08, 2016 at 10:34:17AM +, Ananyev, Konstantin wrote: > Hi Adrien, > > > > > An assertion failure occurs in __rte_mbuf_raw_free() (called by a few PMDs) > > when compiling DPDK with CONFIG_RTE_LOG_LEVEL=RTE_LOG_DEBUG and starting > > applications with a log level hi

[dpdk-dev] [PATCH] mbuf: remove inconsistent assert statements

2016-06-08 Thread Ananyev, Konstantin
> > Hi Konstantin, > > On Wed, Jun 08, 2016 at 10:34:17AM +, Ananyev, Konstantin wrote: > > Hi Adrien, > > > > > > > > An assertion failure occurs in __rte_mbuf_raw_free() (called by a few > > > PMDs) > > > when compiling DPDK with CONFIG_RTE_LOG_LEVEL=RTE_LOG_DEBUG and starting > > > applic

[dpdk-dev] [PATCH] mbuf: remove inconsistent assert statements

2016-06-08 Thread Ananyev, Konstantin
Hi Adrien, > > An assertion failure occurs in __rte_mbuf_raw_free() (called by a few PMDs) > when compiling DPDK with CONFIG_RTE_LOG_LEVEL=RTE_LOG_DEBUG and starting > applications with a log level high enough to trigger it. > > While rte_mbuf_raw_alloc() sets refcount to 1, __rte_mbuf_raw_free(

[dpdk-dev] [PATCH] mbuf: remove inconsistent assert statements

2016-06-08 Thread Adrien Mazarguil
An assertion failure occurs in __rte_mbuf_raw_free() (called by a few PMDs) when compiling DPDK with CONFIG_RTE_LOG_LEVEL=RTE_LOG_DEBUG and starting applications with a log level high enough to trigger it. While rte_mbuf_raw_alloc() sets refcount to 1, __rte_mbuf_raw_free() expects it to be 0. Con